Milos Fabian [Tue, 10 Jun 2014 06:18:45 +0000 (08:18 +0200)]
Moved Ipv4Util and Ipv6Util from concepts to util
-added new functionality to the Ipv4Util/Ipv6Util
-read from ByteBuf buffer and convert bytes to Ipv4/Ipv6 address
Change-Id: I30ca7ab5d2dcaba7f4ccaa12dd94382c77f738da
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Sun, 22 Jun 2014 20:51:31 +0000 (20:51 +0000)]
Merge "Bug 611 - NlriReg supports serialization"
Martin Bobak [Wed, 4 Jun 2014 14:11:17 +0000 (16:11 +0200)]
Bug 611 - NlriReg supports serialization
Change-Id: Iba038fcf2d139cb32e1ad2192bb7a1f885604f4c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 17 Jun 2014 11:40:04 +0000 (13:40 +0200)]
BUG-612 : switched PCEP label serializers to ByteBuf
Change-Id: I9d017439eecd6f7b52ef273ac04aca2ee4a5a22c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Martin Bobak [Thu, 22 May 2014 07:46:18 +0000 (09:46 +0200)]
Bug 611 - linkstate path attribute serializer added
Change-Id: I6bf9ee966b1171935ab7ecc1401641bb9d238bd5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 22 Jun 2014 18:12:40 +0000 (20:12 +0200)]
Fixed incorrect parsinf og IGP bits.
Change-Id: Ibafda976fe07ba6fdabd0a124f3febf2a7f13098
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 22 Jun 2014 17:00:51 +0000 (19:00 +0200)]
Fixed length of LINK_PROTECTION_TYPE.
BGP parses incorrectly parsed one-byte value of this field.
Correct length of this field is 2B.
Change-Id: I272aad323dc7e7d26cfa89d368028a4bbce9dcae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 17 Jun 2014 10:21:08 +0000 (12:21 +0200)]
BUG-612 : switched PCEP XRO subobject serializers to ByteBuf
Change-Id: Ibc07ffa75cb7c38f870f40d92e45b35a9700d59a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 17 Jun 2014 09:42:52 +0000 (11:42 +0200)]
BUG-612 : switched PCEP RRO subobject serializers to ByteBuf
Change-Id: Ic4cdb21ea5f4bbaf7e98bf13c10984b1b6690809
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 16 Jun 2014 19:55:40 +0000 (21:55 +0200)]
BUG-612 : switched PCEP ERO subobject serializers to ByteBuf
Change-Id: Ic7de4fdaedf9aafb7c9dc572e329d1ce57915979
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 16 Jun 2014 14:27:43 +0000 (16:27 +0200)]
BUG-612 : switched PCEP tlv serializers to ByteBuf
Change-Id: I836c1a0ae71987d5ae9fe0dcbc8d84c540e43af0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 13 Jun 2014 20:46:51 +0000 (22:46 +0200)]
BUG-612 : switched PCEP message serializers to ByteBuf
Change-Id: I380427951f0d3d505bd53c7fa0ad286fb226422e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Martin Bobak [Tue, 20 May 2014 14:57:08 +0000 (16:57 +0200)]
Bug 611 - Update message serialization
- multi protocol attributes serialization for update message
Change-Id: I710b87a67c9f19bd9ed9391dab32ed1522188a05
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Robert Varga [Thu, 19 Jun 2014 17:38:55 +0000 (17:38 +0000)]
Merge "Bug 611 - serialization of path attributes - added Nlri,originatorId and clusterId serialization to BGPUPdateMessageParser - added Ipv4NextHopCase Ipv6NextHopCase serialization - added serialization methods to attribute objects - attribute_flags and attribute_type added to all attribute serializers - attribute descriptors <attribute type, attribute length, attribute value> unified by AttributeDescriptor interface - added tests for Update message serialization"
Robert Varga [Thu, 19 Jun 2014 13:01:17 +0000 (15:01 +0200)]
Update maven-nar-plugin to 3.1.0
Bumps the version to pickup bugfixes/features.
Change-Id: I8049fc13c8dd0fd28cce6f02598c201686ff7832
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Bobak [Thu, 29 May 2014 14:23:32 +0000 (16:23 +0200)]
Bug 611 - serialization of path attributes
- added Nlri,originatorId and clusterId serialization to BGPUPdateMessageParser
- added Ipv4NextHopCase Ipv6NextHopCase serialization
- added serialization methods to attribute objects
- attribute_flags and attribute_type added to all attribute serializers
- attribute descriptors <attribute type, attribute length, attribute
value> unified by AttributeDescriptor interface
- added tests for Update message serialization
Change-Id: I49e6bb6c0883f125a24fa2a058f0f0bf0e404261
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 19 Jun 2014 09:29:40 +0000 (11:29 +0200)]
Bug 1205 - AS path segment value encoded by 2 bytes
Change-Id: I613efb48273553276204d2569b699a57d136a3d0
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Dana Kutenicsova [Tue, 17 Jun 2014 12:33:20 +0000 (14:33 +0200)]
BUG-1199 : Small adjustments to stateful07 interop
- removed R bit in LSP in remove-lsp
- explicit approval of empty ERO object
Change-Id: Iaf7c9e6371ca8573ea241242fae548a05694b68a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 16 Jun 2014 22:05:31 +0000 (00:05 +0200)]
Bug 611 - BGP Update message serialization
- serializers use ByteBuf instead of byte[]
- added update message path attributes serialization
- AttributeSerializer expects ByteBuf as method param
- MessageSerializer uses ByteBuf as method param
Change-Id: Ic7bb94e1ab20980a90967ef0a8b00ea17d04db69
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 12 Jun 2014 13:56:43 +0000 (15:56 +0200)]
Fix parser test concurrency
Change-Id: If91119c49308af46336d727edb2ebe045b85f197
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Thu, 12 Jun 2014 22:32:21 +0000 (00:32 +0200)]
Put VS-Tlv to LSP object.
Change-Id: Ic86871fecf1ee37e07f2f3dfa8f311c01be9cf56
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 11 Jun 2014 08:14:19 +0000 (10:14 +0200)]
Do not override LSP arguments when updating LSP. Make LSP mandatory object in update-lsp operation.
Change-Id: I948ecbff10b83b7b91795c1e936ff5e220712fbc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 11 Jun 2014 14:28:54 +0000 (14:28 +0000)]
Merge "Bug-1115 : model for AdjRIBsIn/Out."
Dana Kutenicsova [Wed, 11 Jun 2014 13:55:13 +0000 (15:55 +0200)]
Bug-1115 : model for AdjRIBsIn/Out.
Change-Id: Ia09757e69b3476564c36569a96ac52f276294d6d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Martin Bobak [Mon, 2 Jun 2014 12:51:17 +0000 (14:51 +0200)]
BUG 611 MultiRegistry and HandlerRegistry exposes collection of serializers
Change-Id: I54225673c7f3d6ab253cf931a57606c2b5709cf9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Dana Kutenicsova [Tue, 10 Jun 2014 13:14:51 +0000 (15:14 +0200)]
Removed final modifier from LSP (stateful07) to allow for new tlvs.
Change-Id: Ieeeb03241f529ccfac734e4947a00c54f21b1db0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Tue, 10 Jun 2014 09:23:33 +0000 (11:23 +0200)]
Stateful07LspaObjectParser - removed "final" keyword
-class should be extensible
Change-Id: I3a4793087e678f3ce0f2194fd5c6976058d48e23
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Martin Bobak [Thu, 29 May 2014 14:19:26 +0000 (16:19 +0200)]
Bug 611 - Added method which returns IpPrefix length.
Change-Id: I722dbe6d42f7173bbf62dff5b3b32e5b17321211
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Dana Kutenicsova [Fri, 6 Jun 2014 13:34:36 +0000 (15:34 +0200)]
BUG-1144 : added defensive statements to avoid NPEs.
Change-Id: Ifd8e91f619c9165492458ffb07252699d15185fa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 7 Jun 2014 12:11:35 +0000 (14:11 +0200)]
Force checkstyle (failOnViolation=true)
Change-Id: I924a575eec62d21c79bbe3f2f0f56d9f2f2d2f6b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 7 Jun 2014 11:51:03 +0000 (13:51 +0200)]
Removed checkstyle warnings.
Change-Id: I040d5f047235ca2807fae021d21df85079104604
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Mon, 9 Jun 2014 08:48:32 +0000 (10:48 +0200)]
Bug-602: Fixed PcepRpObjectWithPstTlvParser Tlvs augmentation class
Change-Id: Ic824b025139261e9d8c0348c26da7c6e860f24bb
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Sat, 7 Jun 2014 10:09:26 +0000 (10:09 +0000)]
Merge "Bug-607: Segment Routing TLVs parsers/serializers"
Robert Varga [Fri, 6 Jun 2014 08:28:59 +0000 (10:28 +0200)]
BUG-1132: update netty dependency to 4.0.19
Follow-up patch, since controller has already moved.
Change-Id: I01ebfb185918f0ebc4802e394ffaa76dbba7a7f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 6 Jun 2014 07:54:36 +0000 (07:54 +0000)]
Merge "Checkstyle plugin check - bgpcep"
Tony Tkacik [Wed, 4 Jun 2014 09:37:45 +0000 (11:37 +0200)]
Ensured numbering in augmentations with same target name.
Change-Id: If3ba934595b0044678156f7ccd87c17fa82f1d9a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Dana Kutenicsova [Thu, 5 Jun 2014 11:25:36 +0000 (13:25 +0200)]
Fixed remove-lsp (stateful07), added remove=true to SRP object.
- fixed typo
Change-Id: I01fcb728ec1138f4ea7b6df9332e0a8a2335f6ae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Wed, 4 Jun 2014 15:04:45 +0000 (17:04 +0200)]
Checkstyle plugin check - bgpcep
-violations do not fail build
-rules defined in yangtools/common/checkstyle-logging
Change-Id: Idd7cdb368979ce200325a9562342d02876e18f37
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 4 Jun 2014 17:50:35 +0000 (17:50 +0000)]
Merge "Fixed CInitiated00SrpObjectParser"
Robert Varga [Wed, 4 Jun 2014 17:50:03 +0000 (17:50 +0000)]
Merge "Bug 607 - PCEP Segment Routing - yang model"
Dana Kutenicsova [Wed, 4 Jun 2014 17:38:25 +0000 (19:38 +0200)]
Fixed wrong handling of LSP argument in stateful07.
Change-Id: Ibd9d2432631ffa302dc8fb8738fc7c242cd905c9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Wed, 4 Jun 2014 09:26:33 +0000 (11:26 +0200)]
Bug-607: Segment Routing TLVs parsers/serializers
-added parser/serializer for Path Setup Type Tlv + augmented RP and SRP object
-added parser/serializer for SR PCE Capability Tlv + augmented Open Object
-added parsers/serializers junit tests
-added activator
Change-Id: Ib800bdc12ed78f89e39b3df185e006707bd702b0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 4 Jun 2014 09:19:41 +0000 (11:19 +0200)]
Fixed CInitiated00SrpObjectParser
-fixed parser/serializer to be able read/write TLVs
-removed "final" keyword from class declaration - to be extensible class
Change-Id: I127575163677aeda2813940180007059ea7edbe0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 12 May 2014 06:42:32 +0000 (08:42 +0200)]
Bug 607 - PCEP Segment Routing - yang model
-created yang model odl-pcep-segment-routing02
-based on http://tools.ietf.org/html/draft-sivabalan-pce-segment-routing-02
-SR-ERO object and subobject
-SR-PCE-CAPABILITY TLV
-related augmentation
-created yang model odl-pcep-lsp-setup-type01
-based on http://tools.ietf.org/html/draft-sivabalan-pce-lsp-setup-type-01
-PATH-SETUP-TYPE TLV
-related augmentations
Change-Id: I9d0b0d1a1ad4adae843c04009d3259fd23f50f2a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Tue, 3 Jun 2014 13:48:11 +0000 (15:48 +0200)]
Added missing augment.
Change-Id: Ia33695afab751e21396d5cd94f86e657ddb2be6a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 3 Jun 2014 13:22:55 +0000 (15:22 +0200)]
Fixed failing PCEP tests (wrong readerIndex handling).
Change-Id: I12f54f56b47c40ceed2b40b3981862bcf822fdd4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 1 Jun 2014 22:01:43 +0000 (00:01 +0200)]
BUG-612 : switched Labels to ByteBuf.
Change-Id: Ib3ff3cc49022af0193c55d7d0fef6f872ac4f250
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 1 Jun 2014 21:53:46 +0000 (23:53 +0200)]
BUG-612 : switch XRO to ByteBuf.
Change-Id: I2122ef661f5697a7e8cff8c293aa24b7c200cd0f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 1 Jun 2014 21:14:44 +0000 (23:14 +0200)]
BUG-612 : switched ERO to ByteBuf.
Change-Id: Ifb376786285f8dc0abce2405dcdadb9f1f7d0883
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 1 Jun 2014 20:15:28 +0000 (22:15 +0200)]
Removed unnecessary checks for SRP-ID value.
Change-Id: Ie01e1e47a6b956bfd3c5f15fac3a57fdcca20ef0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 1 Jun 2014 17:48:15 +0000 (19:48 +0200)]
BUG-612 : switched RRO subobjects to ByteBuf.
Change-Id: I0a353e9c0196be8b3524014a65ab387c8e09e541
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 1 Jun 2014 13:15:58 +0000 (15:15 +0200)]
BUG-612 : switched PCEP Tlvs to ByteBuf
Change-Id: I103e4bf0c5104993cded9c281795571786379889
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 1 Jun 2014 09:04:52 +0000 (11:04 +0200)]
BUG-612 : switch PCEP objects to ByteBuf.
Change-Id: I14a6f1877e0feeb08499807b51632630a79104e3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 31 May 2014 21:45:48 +0000 (23:45 +0200)]
BUG-612 : switched PCEP message parsing to ByteBuf.
Change-Id: I4f68539bd8b70097f62506ad655f1d899ef4204f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 30 May 2014 13:47:24 +0000 (15:47 +0200)]
Removed additional check for SRP-ID value.
Change-Id: I63b1769899d80dcf94589ba0e62740e8d564ccae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 30 May 2014 13:20:08 +0000 (15:20 +0200)]
Fixed various small bugs when testing stateful07 version.
- srp & lsp serializers assumed all flags are present
- missing augmentation of lsp in add-lsp operation
Change-Id: I945fe7adf5f3352760dda8936c74642de91f7f94
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Martin Bobak [Tue, 27 May 2014 06:16:06 +0000 (08:16 +0200)]
Fixed test failing on windows because of missing resources.
Change-Id: Ic8218f4ce0f6c45995e3ae510377c73fecd901d2
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Robert Varga [Thu, 29 May 2014 13:25:38 +0000 (15:25 +0200)]
Fix integration tests failing on yangtools.util
Yangtools has introduced a new package, which is now required by some of
our dependencies. List it in the pax-exam config.
Change-Id: I9a762339163698fb51e93a8833f8316c3c378b9f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Thu, 29 May 2014 10:56:12 +0000 (12:56 +0200)]
BUG-429 : fixed unstable tests when two verify jobs are running.
Change-Id: I176a9322b5f33d2349cc25be9d71d74112bb1cc1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 27 May 2014 11:26:18 +0000 (13:26 +0200)]
Removed unused and deprecated message type class.
Change-Id: Ie9586811155b7f689c4446f858df8d2fa88605a4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 27 May 2014 09:08:24 +0000 (11:08 +0200)]
BUG-730 : added test for pcep-spi util classes.
Change-Id: I1c89c176a0a5567dd3e2b102e498c47330edced5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 27 May 2014 08:43:55 +0000 (10:43 +0200)]
Adjusted SRP-ID range to include 0.
Change-Id: I5c5bcf160c727f018d15f0bc82f107442950a058
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Tomas Olvecky [Tue, 20 May 2014 15:20:01 +0000 (17:20 +0200)]
Quick fix for failing PAX tests.
This test removes TestHelper that was copied from controller.
There are several drawbacks of current usage of PAX, that this commit
is not solving:
* several abstract classes, each defines its own configuration that is hard
to merge into TestHelper
* PAX in general is not helpful when dealing with resolvation and other errors
* these tests are not run with the actual distribution
Change-Id: Ib4304b3bf3d7e0f0dd33322f0f53de294e66f53f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Dana Kutenicsova [Wed, 14 May 2014 09:11:50 +0000 (11:11 +0200)]
Fixed Ipv4 topology appearing in ipv6 slot.
Change-Id: I4543e4fddba97444190b17b5c46cc334511be131
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 13 May 2014 14:17:23 +0000 (16:17 +0200)]
Improved logging in PCEP.
Change-Id: I65fc9ff9ab7409317e2cb43033534ad643efb051
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 13 May 2014 13:54:51 +0000 (15:54 +0200)]
Improved logging in BGP.
Change-Id: Id9d8f726a4ca255280be0ea31e1b217af64c72ee
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 10 May 2014 20:33:30 +0000 (22:33 +0200)]
Concepts cleanup.
Change-Id: I7ecc2989c14d26c47a8b0add293cd678871ef6fe
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 10 May 2014 13:55:32 +0000 (15:55 +0200)]
Refactoring util.
Change-Id: I9c26d821c8ebc9c959c966de3b347fc16413895c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 10 May 2014 12:01:48 +0000 (12:01 +0000)]
Merge "BUG-731: rename LSPID and SRPID"
Dana Kutenicsova [Sat, 10 May 2014 06:45:42 +0000 (08:45 +0200)]
Refactoring of linkstate module.
- removed ByteList
- refactor to use Multimap to allow for multiple keys in map
- simplified AdjRIBsIn class
- use UnsignedInteger for casting back longs
Change-Id: Iebdf4081bad909fd861d8a10b8b7286f70962038
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 9 May 2014 11:17:26 +0000 (13:17 +0200)]
BUG-731: rename LSPID and SRPID
This adds a bit of documentation and renames the offending generic
arguments to L (for LSP) and S (for SRP).
Change-Id: I2854f2cbc5df345b4febcebc229f7ec22ae5c7fc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 9 May 2014 11:38:55 +0000 (13:38 +0200)]
Removing deprecated getType() method from serializers.
Change-Id: I502916e21f74f546f3e374fa5bdabdcf242731d0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 9 May 2014 11:23:06 +0000 (11:23 +0000)]
Merge "BUG-730 : added tests for Encoders/Decoders in PCEP."
Robert Varga [Fri, 9 May 2014 09:59:55 +0000 (11:59 +0200)]
BUG-731: do not throw Exceptions
This patch updates the configuration bindings to declare concrete
exceptions as thrown.
Furthermore it removes the ability for a LocRIBListener to throw checked
exceptoins: implementations are expected to handle them from now on.
Change-Id: Iaf4785075ea901af5cd9d9a9ad5e9954526e9a93
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 9 May 2014 10:14:20 +0000 (12:14 +0200)]
BUG-730 : added tests for Encoders/Decoders in PCEP.
Change-Id: I07fca73a415f78c7f3e15f5522ea22efbccb44fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 7 Apr 2014 11:56:26 +0000 (13:56 +0200)]
Move uptodate into its own container
This patch side-steps the need to read the entire table in order
to update a single leaf (uptodate) by moving it into its own container.
Change-Id: Ib9f31cd4d10e2c2808b374a215ee6f4325e95ef3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 7 May 2014 13:18:30 +0000 (15:18 +0200)]
Fix nagasena artifact ID
Change-Id: Ic955d272d1007b18dabdd8093e8b6bbc9d220129
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 7 May 2014 07:46:07 +0000 (07:46 +0000)]
Merge "BUG-632: add missing module"
Robert Varga [Wed, 7 May 2014 07:15:44 +0000 (09:15 +0200)]
BUG-632: add missing module
This adds the missing controller-config module for TCPMD5.
Change-Id: Id61f93ab9e2c3aaf50ce4b37bd02bded37b4458c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 6 May 2014 16:04:35 +0000 (18:04 +0200)]
BUG-731: reduce field visibility
Sonar correctly reports these fields should be private. Let's add
accessors and hide them.
Change-Id: I97e4f6443d22a9b9ed90c3bdab8c3db251d5e4f3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 6 May 2014 15:59:48 +0000 (17:59 +0200)]
BUG-731: limit protected field visibility
One field can become private, others get @VisibleForTesting
Change-Id: I2d5214620a83953dae080d4a1f67e1e6470944e9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 6 May 2014 15:52:49 +0000 (17:52 +0200)]
BUG-731: hide visible fields
Fields in private class need to have non-private access, so squash the
associated warnings.
Change-Id: Ib285c8d17230452f8958a85e5c2cb0d0fb54df0f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 6 May 2014 15:49:29 +0000 (17:49 +0200)]
BUG-731: hide serverSessionManager
It should not be visible, so expose the only functionality required by
subclasses.
Change-Id: Ic90c71080ed14cfcb1afbc67f18f85ab9888ffa5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 6 May 2014 15:43:24 +0000 (17:43 +0200)]
BUG-731: simplify CommunitiesParser
We can unify some parts of into common codepaths, so let's do it.
Change-Id: I1e9acba475b5b35e5aba670937776ee9d5e9c236
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 6 May 2014 14:11:35 +0000 (14:11 +0000)]
Merge "Bug 187 - PCEP: object parser - report correctly unknown objects"
Milos Fabian [Mon, 5 May 2014 14:59:28 +0000 (16:59 +0200)]
Bug 187 - PCEP: object parser - report correctly unknown objects
-differs between unknown object-class and object-type, returns proper error
Change-Id: I04c5f274294793776c84c4de8875e22d71b9a650
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Mon, 5 May 2014 14:39:42 +0000 (16:39 +0200)]
BUG-731: unnecessary final keywords
We don't need them, so reduce warnings a bit.
Change-Id: Iac20966ae2ef4a89a7dde6610341f5d549339c43
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 5 May 2014 14:32:46 +0000 (16:32 +0200)]
BUG-731: remove empty statements
These are not harmful, but let's keep the code clean;
Change-Id: Ifbf7ba2af61e8b5361bf8dba3c1447fb9bd4fc2f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 5 May 2014 15:21:50 +0000 (15:21 +0000)]
Merge "BUG-730: cleanup tests in pcep-impl"
Robert Varga [Mon, 5 May 2014 15:21:03 +0000 (15:21 +0000)]
Merge "Remove unnecessary try-catch. OF codes are no longer in an enum."
Robert Varga [Mon, 5 May 2014 15:20:18 +0000 (15:20 +0000)]
Merge "Added open object parser/serializer to basic activator."
Robert Varga [Mon, 5 May 2014 14:24:45 +0000 (16:24 +0200)]
BUG-731: do not declare Exception as thrown
In one place it's completely unneeded, on the other one we can refactor.
Change-Id: I6d84424c02430c33a964013c11e7130cd2f4ec0f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 5 May 2014 13:26:37 +0000 (15:26 +0200)]
BUG-731: move annotation
Moving the annotation renders the temporary variable unneeded, which in
turn fixes a warning. The method is simple enough so it does not matter.
Change-Id: I188870a6f5c0ab55f30803d2f944589ee6a74ad9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 5 May 2014 13:24:54 +0000 (15:24 +0200)]
BUG-731: simplify boolean expression
This is less obvious, but still as good as the original. Plus it removes
a complaint.
Change-Id: I672a16c41687b319de3918822edc7a4073f5169e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 5 May 2014 13:24:30 +0000 (15:24 +0200)]
BUG-730: cleanup tests in pcep-impl
Change-Id: Ic478b45803faff29d63b01cc986a0dcb135af295
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 5 May 2014 13:22:45 +0000 (15:22 +0200)]
BUG-731: do not assign to parameters
It is convenient to coerce the argument value, but this approach is a
bit more clean and avoids the sonar warning.
Change-Id: I8648e09c5c02bb082321c3a9a858142eaabdc9ea
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 5 May 2014 13:19:35 +0000 (15:19 +0200)]
BUG-731: do not throw RuntimeException
Let's turn this into an IllegalArgumentException, with a proper message.
Change-Id: I5bb149de83001ea6817c6f58fb1d5d9be41907e1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 5 May 2014 13:16:09 +0000 (15:16 +0200)]
BUG-731: rework catch clausule
This eliminates warning about rethrowing exceptions.
Change-Id: I46a3531a7753c049d78919c0134d714a509b29a6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 5 May 2014 13:15:46 +0000 (15:15 +0200)]
Remove unnecessary try-catch.
OF codes are no longer in an enum.
Change-Id: I635565fb04d7439d2bf2bb761d8b39e02785ae48
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 5 May 2014 13:14:27 +0000 (15:14 +0200)]
Added open object parser/serializer to basic activator.
Change-Id: I4ebb828b67becd89a35880594914daca7e800b5d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Code Review / bgpcep.git / log