BUG-139: PCEP TLVs extensions implementation

- yang model augmented by LSP-DB-VERSION and SPEAKER-ENTITY-ID
- parsers/serializers implementation
- integration into Lsp and Open objects
- expansion of unit tests

Change-Id: I07d2da05f27a5fdb1fe87ebdb58793ab59a08012
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar issue fixed.

serializeNlri() was too complex, split it into
various small methods.

Change-Id: Ibc6623f379beaa077bee193b5d0721504d976dfe
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Sonar issue fix: BestPathSelector

Replaced if-then-else statement by a single return statement.

Change-Id: Ia5e5e162a3337e01cc26253e586de6eefd989680
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-139: Implement PCEP state synchronization avoidance

Advertising Support of Synchronization Optimizations
- defined yang model for STATEFUL-PCE-CAPABILITY TLV
- implemented SyncOptimizationsCapabilityTlvParser
- parser/serializer Activator
- Config-subsystem integration
- tests: update and extension

Change-Id: Ief4a928a1cd3e6c18e35f13fa1e49053351eebd7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3840 : introduced Supported tables

When advertizing to other peers, we need to keep track
of afi/safi that a client supports. Not having them
causes exceptions in the logs, as the particular
AdjRibsOut was not created.

Change-Id: I3bea92666c200c8dceb83e3c4f144b9afe1f0305
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

PCEP LSP obj parser: missing PathBindingTlv serialization

Change-Id: Ife794f9d485cdffc2dc8c1efb9d5e77ccc2c170e
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug: Fix Cycles issues

Change-Id: I18e58d635dbc7cbd33d1b57afd7269278e25567c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG: Fix Sonar Issues

Change-Id: Ie037f085b39da5a0e6743798695c372ebd604a9e
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Rib-impl unit test for export policies

Change-Id: I094f9fab6774b824d8f1cbea9a8d851036f1853a
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3780: Fixed 41-bgp-example init config file

bgp-peer was refering to incorrect bgp-rib service type

Change-Id: I5b5dfc94bc073677e9fe4c7fe495cff573b1a2b0
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-2873 : Remove dependency protocol-framework on PCEP

Change-Id: I612108eeba62385b455fa7d8f4e633f41486a7aa
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-2823: Simplify AS_PATH encoding

Expaned yang model by leaf-lists as-set and as-sequence as new type and marked
old type as obsolete.
Changed bgp-parser functionality to support just new type.
Changed bgp-rib functionality to support just new type.
Updated and expanded unit tests.

Change-Id: I1a832167afa9c19f4de358704d122d969b8b6fa8
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-2873 : Remove dependency protocol-framework on BGP

Change-Id: Id04890456a517ca416f18be3de5bb3e777a5bfe9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BestPathSelector bug fix

expanded unit test BestPathSelectorTest and corrected BestPathSelector code.

Change-Id: I0591e7c7dbe455c852faed677b80694ef0dd9e63
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug: Fix missing break

Change-Id: If67090fbbff9baa160d58df5d9ccbb4884670853
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Sonar Issues fix

Change-Id: I1af7e2a6926b6d8717e862382f5540beab2df3a0
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Test coverage: yang.bmp.spi

Change-Id: Iaea73e11132e278e6be094f8bdab6dcf5ba56d75
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Add <relativePath/> for autorelease scripts

Autorelease requires <relativePath/> for parents that live outside of a
project so that it's scripts can properly find and replace this value
for use in the autorelease build.

Change-Id: I00f6a37c71d8a261316648eb2f00f3b3e7382ebe
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

IllegalArgument Exception changed to Preconditions checks

Change-Id: I30f607cbc6cbe1e6abd20b0bb375a4073e28cd17
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3075: BMP application integration test

-doploys client to BMP app. and send messages, check datastore

Change-Id: I6fadd5450bd2ff81a84b9b5cd38260187905a984
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: augment BMP pre-policy RIB and post-policy RIB

-augment BMP RIBs with BGP routes extensions (multiprotocol, linkstate, flowspec)

Change-Id: I84a02000c6672ad73d03b8939e274f291939beb2
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Fixed unit tests after yangtools change.

Commit in yangtools master: https://git.opendaylight.org/gerrit/#/c/23673/
Commit in yangtools lithium: https://git.opendaylight.org/gerrit/#/c/23045/

Change-Id: Ifab39c3188e80e793ecf384d496d853809e940fb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-3075: BMP feature

-integrate BMP with karaf
-defines "odl-bgpcep-bmp-all" feature
-starts all required bundles/features and initial config files

Change-Id: I145fbc7ca437ca9ff0cda322dabb5f347be19257
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP initial configuration

-initial configuration xml files
-instatiate BMP extension provider, dispatcher and application

Change-Id: I633c45d61dfa463c275c90bd1a68e8755f494c6d
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Test coverage: bmp.spi.registry

Change-Id: I2165c8e7861aa4667845c8ea8bbba14e2fa99469
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3075: BMP application configuration

-integrate BMP application with config subystem
-creates instance of BMP application
-configurable binding port and IP address of server instance

Change-Id: Id95fffc0612a746e3ea37f4de7af43d4df25265d
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 2208 - pcc-mock: enhancemnets

*new functionality
- refuse operations with not delegated LSP
- refuse removing of non PCE-initiated LSPs
- delegate PCC's LSPs to the first PCE at start-up
- support "return delegate" request from PCE for PCC's LSPs, re-delegate, after the "redelegation timeout" expires, to the next PCE in cyclic order
- support "delegate" and "return delegation" for PCE-initiated LSPs, delete LSP if "state-timeout" expires
- if PCE connects, report all LSPs (PCC's and PCE-initiated) with actual state

*new input arguments
--redelegation-timeout <seconds>, default 0 - start timer when delegation for PCC's LSP is returned or when PCE fails;
hold delegation for PCE until expiration; timout is cancelled when LSP is delegated to PCE

--state-timeout <seconds>, default -1 (infinite) - start timer when delegation is returned or when PCE fails;
after timeout expiration, LSP is removed; timeout is cancelled when LSP is delegated to PCE

*new PCEP error added
- LSP is not PCE-initiated Error-type=19, Error-value=9

Change-Id: I7bb4cdf03dd04f9caddc13cf7a70c913aa7e6e2b
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3919: Advertisement is always done using MP_REACH

Fix Check whenever Tablekey is empty do not advertise using MP_REACH

Change-Id: Ia77e8fbdf841c61b82e85965001ef0f1a183e369
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Adds new utility function

converts IpAddress and PortNumber to InetSocketAddress

Change-Id: I43f5e6af0316aeb0dfe2ab901d3c396118da707b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP application

-implementation of application layer
-handle messages->transform->write do data-store

*BmpMonitoringStation:
-top level of application
-instantiates lower level of application
-creates instance in data-store
*RouterSessionManager:
-manages sessions with remote devices (routers)
*BmpRouter:
-represents application layer of session with particular device
-message handling/delegation of per-peer messages
-manages peers as reported by router
*BmpRouterPeer
-represents peer reported by remote device
-per-peer messages handling
-delegates
*BmpRibInWriter
-handling of Update messages and their transformation to Rib
-uses BGP RIB extensions service

Change-Id: I5f00197f7f96d6feb3f21ddd5726c464c3aad1f3
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Adds utility function that converts InetAddress to IpAddress

Change-Id: Id19c064888755a17fb99de070de3182538a1349e
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Sonar Warning: removed unused parameter

Change-Id: Iab6fa30f3c0e53b239a8a088cb15e1a21e742f05
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Test coverage: bmp.spi.parser

Tests expansion

Change-Id: I5a0c470fb7f40bd098f72e182c0537a657f52bea
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar Warning Fix: complexity issues

NodeChangedListener:
- extracted for cycle into private updateTransaction method
Stateful07TopologySessionListener
- extracted building the Path variable
FSNlriParser
- switch extraction into private method setFlowspecType

Change-Id: Iec4d2d179527560150046531cc02fd198ea3d323
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar Warning Fix: reused parameter

moved obj Object into updated method
created new Object instead of reusing parameter

Change-Id: I0694a8e45f9c9070dd894c3382e8e39ec13beaf1
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar Warning Fix: anonymous class reduction

Change-Id: I93661cd78f12231e6989c7800606dd46fc75c3e7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar Warning Fix: BmpMessageConstants

set class as final

Change-Id: Iedd9912c7a0c8b5ada130c9270b6ffb621e3e856
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar Warning Fix: LocRibWriter

decrease of update method complexity
exctracted two for cycles into two private methods

Change-Id: I10003e4a87dccf251b1f06a8b7a964b64b51bc8b
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar Warning Fix: RIBImpl - log exception

Change-Id: I4bcb9ab05c62366e679d7d6d95d9d6d88de9d47f
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Unit tests for AttributeOperations.

Change-Id: I4a02fb11e25497d9ff3538c3103481bfa5b9f049
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3892 : specify LeafSet as ordered

When creating own ClusterId list it must be
ordered too.

Change-Id: I261f3757cd9ffafa6016d84f6238ce34aeedc69a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2848: BGP-LS EPE extension: Protocol Id

Added new protocol id value (bgp-epe)

Change-Id: I0d092464d9ea5253ce1f37c6db6355fec8fd6389
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-2848: BGP-LS EPE extension: Peer Sid

Parsering/serializing for Peer-SID, Peer-Set-SID
Added parsering/serializing of type and length of (Lan)AdjacencySegmentIdentifier

Change-Id: I56b4c2c131c205fa727f4261fc9cd06d4b39dd63
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-2848: BGP-LS EPE extension: EPE Descriptors

Parsering and serialization for Local and Remote node descriptors expanted by:
- BGP router id
- member As number

Change-Id: I1c25f76aa1a7947f7ff459bf4f9019116e055f49
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3879 : Fixed NPE in OspfPseudonodes case.

OspfPseudonodes weren't properly extracted from BI to BA.

Change-Id: I30a6b163806af69c9c8efa77a5d9f208228d54fa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 044b654e168135e1a272b7a5f4fcf0f44ed469aa)

BUG-3892 : added ordered-by user statement to clusterIds

Without this statement, LeafSet does not guarantee the order
of clusterIds. We need to maintain the order as our clusterId
needs to be first when advertising routes.

Change-Id: Ic5d7ca2fb514a31cffc958a8a69ee3f57e3d2636
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3839 : fixed various minor bugs related to AS Path BPS

- fixed classcast from Long to String
- fixed wrong NodeIdentifier
- fixed wrong algorithm in BPS

Change-Id: I7d87534d4e027d62a13fca7da13af81cb5f89caa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3860 : fixed config through RESTCONF

Not closing loc-rib caused many loc-ribs to be created
through config-pusher causing NodeModificationExceptions.

Change-Id: I9b168615875f02a40b120b13cc92e9d5bdcd42be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix Sonar warnings: bgp-bmp-impl

Change-Id: I50a3d1c10204cd421246a0d5f838bcfd83e3ff9d
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

bgp-bmp-spi sonar warnings

Change-Id: I167e53a743aaae073107addc86214d60e4f15302
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3075: BMP dependency management

-use project's dependency management
-clean dependecies in BMP poms

Change-Id: I4bbeae6d164d882ad33336b34dfc6a8712eeb9cd
Signed-off-by: Milos Fabian <milfabia@cisco.com>

bgp-bmp-spi cycle issue fix

Moved BmpTlvRegistry to spi.parser package

Change-Id: I55a39113617bf844503936ad93e7c7a438ff7840
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-2848: BGP-LS EPE extension yang model correction

Added epe descriptors to local descriptors
Removed from link descriptors

Change-Id: I434d5db602b599b50f8517ecd4b1b05c9f027048
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

nagasena lib: group id change

Change-Id: I1a93d8ebf081649b9918790f47a868400313c17d
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3714: Generalize RIBSupport

Changed instance idetifier for writing/deleting routes operations in RIBSupport.
Now identifier has to point to table's routes choice data node.
The change allows to properly use write/delete routes DOM operations out of "rib-api" module namespace.

Change-Id: I4b877683fdb5232179da05eab78120187a2fcf4f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP server dispatcher configuration

-integrates BMP dispatcher with config subsystem

Change-Id: If2b953361ae53ca8d3093bc19a0de2e892cb42cc
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP server dispatcher

-based on netty protocol framework
-dispatcher is able to create BMP servers
-BMP server is binded to particular IP address and port
-listening for incomimg connections
-initializes channel pipeline - message and session handler

Change-Id: Ibe15ef3fbde8369cdac320db82ba18f3f1e46d5f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP session implementation

-basic channel reading/message handling
-delegating messages to application layer
-error handling, end of input detection
-simple session factory

Change-Id: I827c44413a4cc7cfa6066ceb2c63b8d9c85c49bc
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Use {{VERSION}} where possible

Using properties is not something what we want to do, so switch where
supported.

Change-Id: I298167354857b832aebf48346238d22ac1b6c929
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug-2848: BGP-LS EPE extension yang model

Two new Node Descriptors Sub-TLVs:
-BGP-ROUTER-ID
-Confederation Member
A new Protocol-ID for Link-Type NLRI.
Two new BGP-LS Attribute Sub-TLVs:
-Peer-SID
-Peer-Set-SID
-ref.: https://tools.ietf.org/html/draft-ietf-idr-bgpls-segment-routing-epe-00

Change-Id: I78a32e4961ad73181b61750f681a496a91c8f9c5
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Get rid of BestPathState FIXMEs.

Created method to parse AsPath segments
from BI to BA.

Change-Id: Ibc49da3ddfb0ba5e1bb0a8da562c00e069df3923
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 8640c8d02873b9ce26b8ac9150804cd7a873edb2)

BUG-3075: BMP Session and dispatcher API

-BMP sesssion provides basic message handling as a part of pipeline
and decouples connection layer and application layer - delegated to
session listener
-BMP dispatcher is capable of creating BMP servers

Change-Id: I8cc5c6e71c8f6a592efe06f58152dd96640579af
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP Messages parser/serializer junit tests

Change-Id: Id2c67171f4d05f935fd9bfe3efe7dfe0c95a83cd
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: netty encoder/decored for BMP messages

-integrate message registry with netty pipeline handlers

Change-Id: I8207b57ba7d859ff0a877c8eb6d5e4d7ddbc93ef
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP activator

-registers all message and TLV parsers/serializers
-integrate BMP activator with config subystem
-create instance of activator, consume BGP extensions

Change-Id: I745fac383ff6c7e9d275ce94ed426b2751aacec6
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP TLV parsers/serializers implementation

Change-Id: Id3e9759e86f2054482d08e86fd5e8632a5db59ee
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP message parsers/serializers implementation

Change-Id: Ie0b8ee9c0086ffcebff9d5d767d87c198673f9fd
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Fix SrNodeAttributesParser + test

expanded tests by parsering serialized outputs
fixed seralization, parsering

Change-Id: I8382ab97d1b19791ba5395a69d1a9873be6cf8e5
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3075: BMP extension provider configuration

-configuration service for BMP extension provider and extension consumer

Change-Id: I53829a09a973b4da8ebda62d897e9958ce4fb317
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP parsers/serializers and registry abstraction

-implemented common functionality for BMP parsers/serializers
-implemented simple registr, extension provider and consumer

Change-Id: Ie3b042d8b20b2f25d15c40bea529a45a4f9db1e4
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP parser/serializer and registry APIs

-Java API for BMP message and TLV parsers/serializers
-Java API for BMP registry and extension consumer/provider

Change-Id: I4ea6fe6418b964bcf8976d85724d120efb128a5f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP application yang model

-representing data model for BMP application

Change-Id: I81c78516850829746df08a5d68ce9a2992d8d022
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2802: BGP Update message serialization bug

The next-hop value from MP reach attribute is not stored in AdjRibIn,
thus next-hop is missing in output Update message.
Copy next-hop value from MP reach to next hop attribute to keep it in DS.

Change-Id: I866af30ecc2cd0baa0ca1ca2f763dc03176ac009
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 7505f0031b58a178994ed90e12d0a7bb111ae8e1)

Removed duplicate logging from message parsers.

Message hex dumps are already printed out via Encoder/Decoder
classes, no need to print them in here as well.

Unified log messages and renamed some variables to make
code more readable.

Change-Id: I9bdcfed891ee1175d28ba1b993f1f22c9774da3e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BGPCEP Tests

PCEPExtensionProviderContextTest
LinkstateRIBSupportTest
FlowspecModuleTest

Change-Id: Ieec83b4dec1b010355a1001cf0f5adda4094c524
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit bfb96610200e708c010048c4ffde17c98e97000e)

Added a bit more tests for correctness and code coverage.

Change-Id: I21f1497279d4b297b533b5dc0872b545e594b11a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3362 : improved tests for application peer

Change-Id: I7fd771d534b1950ff08b47e7126009d8d3afe768
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 9fee7709aee0234aa264f8d38bd3127957872cc0)

RibSupportUtils Unit Test

Change-Id: I520fea6782847f3c29ffbfb520f133944613aa99
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Unit test: PCCEndPointIpv4ObjectParser

Test coverage from 5.6% to 100%

Change-Id: I33855fba9d89d30cfaef9cec325020833d4a41e7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Unit test: MultiProtocolCapabilityHandler

from 19.5% to 100% test coverage

Change-Id: I3b7ff5e31ef2c2bd33561366902f3d87fc40e531
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Unit test for Ipv4NlriParser

created Ipv4NlriParserTest
correction of:
- check of nlri instance type
- serialize nlri in <length, prefix> order

Change-Id: I00c06b352aabe4eb94a492c737377ec1efefec99
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Test - PCEPDispatcherImpl : customizeBootstrap method

Change-Id: Ifc2dab2ca522f53de81c31ffe0c3464ab065cef1
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3768 : fixed AdjRibsOutWriter

Added peerId to list of arguments for this writer
and limited listening to AdjRibsOut only for that
particular peer.

Fixed switched arguments for creating Mp_Reach and Mp_Unreach.

Change-Id: If1f3c576395d68aa3c26d2e4fabd696a4bf14457
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 8bf877875bc2038063008ffd2d99e67591db73ba)

BUG-3664: make sure the transaction is committed

Even in face of error, do not leave a transaction hanging, but rather
commit it with an error-level message logged beforehand.

Change-Id: I211caa7cae954d76e9a47021afcb466f8e7e6004
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 410d7ba6265f74c8180bf63ede523c30093e20e9)

Removed the rest of old BGP-RIB classes.

Change-Id: Ia849ec2ee2332b957f816b4691d5fd45dd1a2942
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 3044 - Conversion from Flowspec BI -> BA

Added support to convert flowspec type in BI to the BA.

Change-Id: I780cab9e3a2fb6c8acc4fdab6572057d76f63432
Signed-off-by: Ladislav Borak <lborak@cisco.com>

BUG-3664 Fix NPE caused by null AbstractRouteEntry

When we tried to get effectiveAttributes from an AbstractRouteEntry
which is null will cause a NPE, since it doesnt contain any attribute.
Fix by check this case.

Change-Id: I311743a165373ee2da4bd4f73e2d468023e445ad
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 902ea39154b62c25659967493a0130f1bed9a5bc)

Bug-3204: If no LSP Identifiers TLV is present in PCRpt message updateLsp in DS throws exception

-handle report message including non-RSVP-TE payload and no LSP Identifier TLV
-in this case use PLSP-ID value as a path identifier in PCEP topology

Change-Id: If1f5716ce0dfaa635028bb4e956ea8595d7b3e34
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BgpTableType: toString()

added toString method into BGPTableTypeImplModule $ AutoCloseableBgpTableType
changed toString in BgpTableTypeImpl

Change-Id: Idf122147522718ec98080d9e81d38bd7c17d9e93
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Fix delete case in EffRibIn.

Delete case was pushed with wrong InstanceIdentifier.

Change-Id: I3e57f5f0b7915bcd290d4b2e851bbb388a092eb4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry picked from commit 34ccd897e1384038c9e8a5cf8e270cd12b4c3199)

BUG-3347 : fix receiving updates only on first route

This was due to calling clear before each write into AdjRibsOut.
Create tables in AdjRibsOut beforehand, so we don't have to take
care about it when a route comes.

Change-Id: I442f9cb2bda715e57fc1c453a81caf13265980cd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit dc9c5f40dea1243dc044acc73904d3944809c10b)

BUG-3300 : Fixed BGP transitive attribute filtering

Namespace in AttributeOperation were hardcode therefore any transitive
attribute with different namespace(inet..) were not valid, reason why
FromExternalImportPolicy did not return any attribute, causing a NPE.
Fixed them by matching extension QName to corresponding Attribute.

Change-Id: Ic3ccf5eb0b1d181baaf8ea5b6dea6f84828b92a4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 1114255dc1be6586cef529178e1b1b3078f15b71)

Revert "BUG-3347 : fix receiving updates only on first route"

This reverts commit 0025391f847840fc6e89bcb6193695bc34f44d5f.

Change-Id: I6f690cddb114a3832301f855b281769e66f79b96
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3347 : fix receiving updates only on first route

This was due to calling clear before each write into AdjRibsOut.
Create tables in AdjRibsOut beforehand, so we don't have to take
care about it when a route comes.

Change-Id: I8679399a50b54d83d5432c7b75aadd9e1c7ea928
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry-picked from dc9c5f40dea1243dc044acc73904d3944809c10b)

Cache UnrecognizedAttributes

UnrecognizedAttributes is typically empty, so we can reuse it widely.

Change-Id: Ifff9a45335e6a0ffaf07db789e9d36394ff61301
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 0efe3c646ac46ed0855754ec627ead7b061ed297)

Cache IPv4/IPv6 nexthops

Next hop values are readily reused, so cache them to share instances.

Change-Id: Ib946a82d950c51644bea3cbc394d536e76663c6e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix EffectiveRibInWriter overwriting the entire route table

The fall-through in SUBTREE_MODIFIED case means that for any new write we
replace the entire route table, which has the effect of LocRib having to
run route selection even on routes which have not changed.

Fix this by removing the fall-through and deal with individual routes as appropriate.

Change-Id: I1297afc878d3d8bf9d0c0f461244cc4414f1caa1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry picked from commit 1d6e02186ac85eff5734db59d3cbf5017214ddce)

Fix confusing peer AS message

We printed the expected number in place of what the peer sent and vice
versa, confusing users. Fix that.

Change-Id: I874a25598818e58f4a05a10a977724b0cc853140
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit bcaeb7773976be48a2a8f52dd9fdf33e66d333a6)

Lower tracing overhead

Arrays.toString() and ByteBufUtil.hexDump() are expensive relative to an
disabled trace call. Guard the corresponding trace() calls with
LOG.isTraceEnabled(). Discovered in BGP performance traces to have some
4% overhead.

Change-Id: I94ce9b57b86bae9be35e5839447a19b268064469
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove LocRibWriter registration on close()

Retain the DataTreeChangeListenerRegistration we get when we subscribe
and cancel it when we are being shut down. Also place two FIXMEs for
future work.

Change-Id: I74364473736e863e63557e8ebf652424ea312a59
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit c1206aa82aaf35f93a2b74f83dea8fd2dd5eb048)