bgpcep.git
9 years agoMerge "Bug-730: Test Vendor-Information object/tlv in message/object"
Dana Kutenicsova [Wed, 10 Sep 2014 12:15:13 +0000 (12:15 +0000)]
Merge "Bug-730: Test Vendor-Information object/tlv in message/object"

9 years agoBug-730: Test Vendor-Information object/tlv in message/object 88/10988/1
Milos Fabian [Tue, 9 Sep 2014 12:53:37 +0000 (14:53 +0200)]
Bug-730: Test Vendor-Information object/tlv in message/object

Change-Id: I726bf160eaa64799b660aeff907204c1b0f3a356
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-730: Utils' private constructor tests. 87/10987/1
Milos Fabian [Wed, 10 Sep 2014 07:32:11 +0000 (09:32 +0200)]
Bug-730: Utils' private constructor tests.

Change-Id: I36b11c115fdf9496f23fba03d3108d5ac759085a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-1771: Private constuctors in utility static classes throws UnsupportedOperationEx... 86/10986/2
Milos Fabian [Tue, 9 Sep 2014 14:49:52 +0000 (16:49 +0200)]
Bug-1771: Private constuctors in utility static classes throws UnsupportedOperationException

Change-Id: I2acfccfeec9179bb109b46ae5c77e986e914fd98
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-730: Added pcep-stateful07 parsers tests. 06/10906/3
Milos Fabian [Mon, 8 Sep 2014 13:58:17 +0000 (15:58 +0200)]
Bug-730: Added pcep-stateful07 parsers tests.

Change-Id: Iaa0ca04383e4e0429904d458997c3c62b5574978
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "BUG-730 : increasing branch coverage"
Robert Varga [Tue, 9 Sep 2014 11:22:09 +0000 (11:22 +0000)]
Merge "BUG-730 : increasing branch coverage"

9 years agoBUG-730 : increasing branch coverage 32/10932/2
Dana Kutenicsova [Sun, 31 Aug 2014 14:05:58 +0000 (16:05 +0200)]
BUG-730 : increasing branch coverage

Change-Id: I3ea5792ba36e73cefe38ae41ebcad21fe1f36fa1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-730: Added pcep-tunnel-provider tests 00/10900/2
Milos Fabian [Mon, 8 Sep 2014 12:03:00 +0000 (14:03 +0200)]
Bug-730: Added pcep-tunnel-provider tests

Change-Id: I8fd1fda206609979aa620f5245dcc5d493f10a8a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-1741: Fix read/write operations 99/10899/2
Milos Fabian [Mon, 8 Sep 2014 12:01:43 +0000 (14:01 +0200)]
Bug-1741: Fix read/write operations

Change-Id: I77c6ddef5ce38a8284eaa8f39a04cac9eda90a10
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-1717 Rename duplicate node(bgp-id) from config yang for bgp-rib-impl 95/10895/3
Maros Marsalek [Mon, 8 Sep 2014 08:48:32 +0000 (10:48 +0200)]
BUG-1717 Rename duplicate node(bgp-id) from config yang for bgp-rib-impl

Change-Id: I0443cb684fccaf76dcf56bd9abd67e6f52e54c29
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Remove duplicate dependency declarations"
Dana Kutenicsova [Mon, 8 Sep 2014 10:56:26 +0000 (10:56 +0000)]
Merge "Remove duplicate dependency declarations"

9 years agoMerge "BUG-1736: remove wrong artifact reference"
Dana Kutenicsova [Mon, 8 Sep 2014 10:53:35 +0000 (10:53 +0000)]
Merge "BUG-1736: remove wrong artifact reference"

9 years agoRemove duplicate dependency declarations 96/10896/3
Robert Varga [Mon, 8 Sep 2014 09:26:20 +0000 (11:26 +0200)]
Remove duplicate dependency declarations

Change-Id: I1e566dd794e3cfbd6e59adb4e4306330f3c5b356
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1736: remove wrong artifact reference 94/10894/5
Robert Varga [Mon, 8 Sep 2014 08:24:17 +0000 (10:24 +0200)]
BUG-1736: remove wrong artifact reference

Remove old -config artifacts and all references to them. Also make sure
we unmask the final field so that our mucking with it actually works.

Change-Id: I50d3ab589c855e71273ce23cb29022ba678b8b7f
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-1737 - Advertize Segment-routing PATH-SETUP-TYPE in SRP 92/10892/1
Milos Fabian [Mon, 8 Sep 2014 07:36:12 +0000 (09:36 +0200)]
Bug-1737 - Advertize Segment-routing PATH-SETUP-TYPE in SRP

Change-Id: I7c952d9a03dc1febbac3b8ff499794c1ed2cdc56
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-730 : added tests for rib-impl 75/10875/3
Dana Kutenicsova [Sat, 6 Sep 2014 11:23:33 +0000 (13:23 +0200)]
BUG-730 : added tests for rib-impl

Change-Id: I65fe04fe824ee5bb595e6b8e13bc73f408b30fac
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-1728 : adjusted ipv6 object hierarchy 74/10874/2
Dana Kutenicsova [Sat, 6 Sep 2014 11:22:55 +0000 (13:22 +0200)]
BUG-1728 : adjusted ipv6 object hierarchy

Change-Id: I4fe7910b82b99454596a711e05b4b00a58f7c92d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoDeleted duplicate declaration in pom.xml. 47/10647/2
Hideyuki Tai [Tue, 2 Sep 2014 18:22:39 +0000 (14:22 -0400)]
Deleted duplicate declaration in pom.xml.

Change-Id: I3d149bbf388192df9f27aef8d0a5d34b1072c316
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
9 years agoBug-730: Added PCEP ietf-stateful02 tests 39/10839/1
Milos Fabian [Thu, 4 Sep 2014 10:09:52 +0000 (12:09 +0200)]
Bug-730: Added PCEP ietf-stateful02 tests

Change-Id: I927df1b0dcc68906ddaa5d7bd48e11a05cfd785e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoFixed feature file. 06/10706/4
Dana Kutenicsova [Wed, 3 Sep 2014 16:09:20 +0000 (18:09 +0200)]
Fixed feature file.

Change-Id: I06d6c960234f40b104d333fe1b5ee6d6b89a8921
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-730: Added concepts tests. 54/10754/1
Milos Fabian [Wed, 3 Sep 2014 14:21:27 +0000 (16:21 +0200)]
Bug-730: Added concepts tests.

Change-Id: I221fe2c100de1ce4ae703f4bc1a2237ffdce6ff8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-730: More pcep-topology-provider tests 96/10696/3
Milos Fabian [Wed, 3 Sep 2014 09:40:33 +0000 (11:40 +0200)]
Bug-730: More pcep-topology-provider tests

Change-Id: I91b8eebe90c1d00840d0d2d51fd30e711afffae5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "BUG-1663 : Removed check for SRP processed flag in parser."
Robert Varga [Wed, 3 Sep 2014 11:41:41 +0000 (11:41 +0000)]
Merge "BUG-1663 : Removed check for SRP processed flag in parser."

9 years agoBUG-1663 : Removed check for SRP processed flag in parser. 15/10615/4
Dana Kutenicsova [Tue, 2 Sep 2014 07:40:59 +0000 (09:40 +0200)]
BUG-1663 : Removed check for SRP processed flag in parser.

Change-Id: Ib952320949bd8ff0805553452629b41b3ffe44c7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-730: More tests for bgp-rib-spi 25/10625/4
Milos Fabian [Tue, 2 Sep 2014 12:12:45 +0000 (14:12 +0200)]
Bug-730: More tests for bgp-rib-spi

Change-Id: I6aa7994cde4ba1ed42b39b036eaee73b9ec4362f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoFixup integration tests after YT change 41/10641/1
Robert Varga [Tue, 2 Sep 2014 16:05:58 +0000 (18:05 +0200)]
Fixup integration tests after YT change

Change-Id: Ib1daa9617c4f10e08f82674ed64a557d4813998b
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Bug-730: More tests for testing tools."
Dana Kutenicsova [Tue, 2 Sep 2014 07:44:41 +0000 (07:44 +0000)]
Merge "Bug-730: More tests for testing tools."

9 years agoSegment routing Open-Object parser should extend Stateful07 Open-Object parser. 00/10600/2
Milos Fabian [Mon, 1 Sep 2014 19:33:13 +0000 (21:33 +0200)]
Segment routing Open-Object parser should extend Stateful07 Open-Object parser.

Change-Id: I32b490572c79ff9c3ae23ac18fc3506ab2d33f15
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-730: More tests for testing tools. 97/10597/4
Milos Fabian [Mon, 1 Sep 2014 14:03:52 +0000 (16:03 +0200)]
Bug-730: More tests for testing tools.

Change-Id: I0e467f5cf0c43e4ecbf54d853438a432381ab917
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-1116 : created grouping out of linkstate-routes 49/10449/2
Dana Kutenicsova [Thu, 28 Aug 2014 13:07:48 +0000 (15:07 +0200)]
BUG-1116 : created grouping out of linkstate-routes

Change-Id: I3a2bd6a2a449bb6a87fdafbf5b0ad95a09803899
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-1116 : application peer implementation and tests 53/10553/2
Dana Kutenicsova [Sun, 31 Aug 2014 15:34:49 +0000 (17:34 +0200)]
BUG-1116 : application peer implementation and tests

Change-Id: Iafe2fea57fcd9d39df7f0a70633ab2546928a2de
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Fix for bgp feature to use get proper configs"
Robert Varga [Mon, 1 Sep 2014 10:13:24 +0000 (10:13 +0000)]
Merge "Fix for bgp feature to use get proper configs"

9 years agoMerge "BUG-1116 : application peer API"
Robert Varga [Mon, 1 Sep 2014 10:08:31 +0000 (10:08 +0000)]
Merge "BUG-1116 : application peer API"

9 years agoFix for bgp feature to use get proper configs 66/10566/3
Ed Warnicke [Mon, 1 Sep 2014 02:00:47 +0000 (21:00 -0500)]
Fix for bgp feature to use get proper configs

Also remove unneeded wrap:, and fixed versions.

Change-Id: I62682fd7899ee153cc4202ea009db0cdd2833a27
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1116 : application peer API 66/10066/11
Dana Kutenicsova [Sun, 31 Aug 2014 14:26:17 +0000 (16:26 +0200)]
BUG-1116 : application peer API

Change-Id: I518938143019acb485ca897a8cecbc52a3d5f568
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Fixed and moved pcep-segment-routing initial configuration"
Robert Varga [Sat, 30 Aug 2014 17:43:16 +0000 (17:43 +0000)]
Merge "Fixed and moved pcep-segment-routing initial configuration"

9 years agoBug-730: Added more bgp-parser-spi tests 11/10511/2
Milos Fabian [Thu, 28 Aug 2014 06:41:35 +0000 (08:41 +0200)]
Bug-730: Added more bgp-parser-spi tests

-fixed lenght checks in AbstractMessageRegistry

Change-Id: I72ea33c30c604861c1b203dcf20f002bd2f0487f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoFixed and moved pcep-segment-routing initial configuration 81/10481/2
Milos Fabian [Fri, 29 Aug 2014 11:22:31 +0000 (13:22 +0200)]
Fixed and moved pcep-segment-routing initial configuration

-configuration is "disabled" (commented out) as we want to preserve stateful07 extension to be configured initially

Change-Id: I4aed882a6c8620939d3a7806c2d19b55802f16cf
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-1116 : if a new peer connects, advertize everything in loc-rib 29/10329/3
Dana Kutenicsova [Tue, 26 Aug 2014 14:27:12 +0000 (16:27 +0200)]
BUG-1116 : if a new peer connects, advertize everything in loc-rib

Change-Id: I44b334593e2239fb622da2f73b3ee23ebae783ce
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-1614: use per-NodeState transaction chains 64/10264/3
Milos Fabian [Thu, 28 Aug 2014 08:59:31 +0000 (10:59 +0200)]
BUG-1614: use per-NodeState transaction chains

Fixes thread safety issues with the provider. Transaction chaining is
really helpful, as it forces us to properly structure our code and
synchronize hand-offs.

Change-Id: I149f765bcbb1069a1656d67c0dcb70452eda6e03
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoadded feature module to bgpcep 22/9822/16
Heath Kesler [Fri, 8 Aug 2014 19:10:36 +0000 (13:10 -0600)]
added feature module to bgpcep

Refactored feature targets to ODL names

Removed refactored bundles out of targets. Updated dependencies.

Added repos, adjusted targets

Updating feature file to use version properties

Adding initial feature testing code

Demo change

updated the feature file for build success and collabrative work

updated the features, got some working

added a few more features for the test

added dependencies in order for hte test to run without previously building the controller or the yangtools

changed feature name to be inline with the naming convention of features-bgp

Change-Id: I4f3de88c07c4d0c63bc1160f462b7d598b19133b
Signed-off-by: Heath Kesler <hkesler@savoirtech.com>
Signed-off-by: jgoodyear <jgoodyea@cisco.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFixed checkstyle setup 75/10375/2
Milos Fabian [Wed, 27 Aug 2014 12:29:27 +0000 (14:29 +0200)]
Fixed checkstyle setup

-exclude /.m2repo from checking

Change-Id: I85cc521e5bffaa35d8a52e9ab620989b818e2d7d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "Bug-1517: Introduce topology data-change counter"
Robert Varga [Wed, 27 Aug 2014 12:40:32 +0000 (12:40 +0000)]
Merge "Bug-1517: Introduce topology data-change counter"

9 years agoBug-730: Added missing rib-impl's modules config tests. 57/10357/2
Milos Fabian [Wed, 27 Aug 2014 07:57:47 +0000 (09:57 +0200)]
Bug-730: Added missing rib-impl's modules config tests.

Change-Id: Ie558ea96aacd3901fa25c53a4ce4a62d940fd668
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-730: Added BGP Topology provider tests 02/10302/1
Milos Fabian [Tue, 26 Aug 2014 11:34:09 +0000 (13:34 +0200)]
Bug-730: Added BGP Topology provider tests

Change-Id: Ifc57b82039ff5c5c9fb845f5805ae44ff5edd7ec
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-730: Added PCEPSessionImpl test 43/10143/3
Milos Fabian [Thu, 21 Aug 2014 15:30:18 +0000 (17:30 +0200)]
Bug-730: Added PCEPSessionImpl test

Change-Id: I338bd27ebacf55a6a2507b8aab792501faf1d219
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-730 : added test for URI builder. 20/10220/1
Dana Kutenicsova [Sun, 24 Aug 2014 19:08:28 +0000 (21:08 +0200)]
BUG-730 : added test for URI builder.

Change-Id: I45c79b3e39d207388e68248e2eb9578abf24acac
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Use transaction chaining in RIB"
Dana Kutenicsova [Sat, 23 Aug 2014 13:34:06 +0000 (13:34 +0000)]
Merge "Use transaction chaining in RIB"

9 years agoMerge "Use transaction chaining in PCE"
Dana Kutenicsova [Sat, 23 Aug 2014 12:54:01 +0000 (12:54 +0000)]
Merge "Use transaction chaining in PCE"

9 years agoUse transaction chaining in RIB 03/10203/1
Robert Varga [Sat, 23 Aug 2014 09:25:53 +0000 (11:25 +0200)]
Use transaction chaining in RIB

Change-Id: I639266cb0a3c80ff64d80090bac7c6c5caa6eb12
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoUse transaction chaining in PCE 02/10202/1
Robert Varga [Sat, 23 Aug 2014 09:17:45 +0000 (11:17 +0200)]
Use transaction chaining in PCE

Change-Id: I44fd4dee4b432a9f6905c2b56e1c672b4deb22d8
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-730 : moved BGP parser-to-sal test from integration 01/10101/3
Dana Kutenicsova [Wed, 20 Aug 2014 13:32:48 +0000 (15:32 +0200)]
BUG-730 : moved BGP parser-to-sal test from integration

Change-Id: I77601286f750a150af50119e6c18446fc1817993
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Bug-730: Added Stateful02 PCRep and PCReq Message tests"
Dana Kutenicsova [Fri, 22 Aug 2014 19:16:06 +0000 (19:16 +0000)]
Merge "Bug-730: Added Stateful02 PCRep and PCReq Message tests"

9 years agoBug-730: Added Stateful02 PCRep and PCReq Message tests 29/10129/2
Milos Fabian [Thu, 21 Aug 2014 11:21:53 +0000 (13:21 +0200)]
Bug-730: Added Stateful02 PCRep and PCReq Message tests

Change-Id: Ia377c437ddc6986e9cbdf432c9a561657854ebf8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-1517: Introduce topology data-change counter 15/10015/3
Milos Fabian [Sun, 17 Aug 2014 08:57:04 +0000 (10:57 +0200)]
Bug-1517: Introduce topology data-change counter

-registers DataChangeListener on specific topology
-increases counter on every "onDataChanged" invocation

-plugin contains sample initial configuration
-topology name is configurable
-can create only sole instance

-exposes data-change count via restconf:
GET "/restconf/operational/data-change-counter:data-change-counter"

Change-Id: I49665f059fa8db0c60491fef1f9424d0b0d87a6b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoUse transaction chaining 48/10148/2
Robert Varga [Thu, 21 Aug 2014 20:31:08 +0000 (22:31 +0200)]
Use transaction chaining

Topology providers usually expect the state to be present in the data
store when they update it. Transaction chaining adds the ordering
guarantee, which is needed to prevent false positives uncovered by the
recent speedup of the datastore.

Change-Id: Ie17a83303485d592640d094d53eff695a3c05bb1
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFixed BGPCEP tests 57/10157/4
Milos Fabian [Fri, 22 Aug 2014 10:34:36 +0000 (12:34 +0200)]
Fixed BGPCEP tests

Add missing binding-data-codec
This dependency is pulled in now by sal-binding-broker.

Change-Id: Ic7be4dcbe0a00da73a2ab440076ac96baff2f5a1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-730: Added stateful02/07 topology session listener tests 65/10065/2
Milos Fabian [Tue, 19 Aug 2014 13:48:11 +0000 (15:48 +0200)]
Bug-730: Added stateful02/07 topology session listener tests

tests: add-lsp, upd-lsp, ensure-lsp-operational, remove-lsp

Change-Id: Ie7c8f7b55836ddff943f0c44f58e42943e17e796
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "Revert "Fixed PCE's remote and local address""
Dana Kutenicsova [Tue, 19 Aug 2014 09:05:50 +0000 (09:05 +0000)]
Merge "Revert "Fixed PCE's remote and local address""

9 years agoRevert "Fixed PCE's remote and local address" 55/10055/1
Dana Kutenicsova [Tue, 19 Aug 2014 08:21:42 +0000 (08:21 +0000)]
Revert "Fixed PCE's remote and local address"

This reverts commit eba1a2fb790c5d3b5b0b667c5a2550b4262f81a9.

Change-Id: I4e8b016ce85883417cbe2e2ce1d2d9b80b8e536b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge changes I0f764a60,I5f7eff95
Robert Varga [Mon, 18 Aug 2014 12:09:12 +0000 (12:09 +0000)]
Merge changes I0f764a60,I5f7eff95

* changes:
  Fixed PCE's remote and local address
  Bug-1516: Introduce PCC mock.

9 years agoFixed PCE's remote and local address 06/10006/5
Milos Fabian [Fri, 15 Aug 2014 12:15:03 +0000 (14:15 +0200)]
Fixed PCE's remote and local address

-server's channel remote and local address are reversed
if channel has parent channel - return proper values,
since remote address is used to build pcc's node-id

-hit the issue while testing PCC Mock with ODL's PCE on localhost

Change-Id: I0f764a606fde2336c51e085184cf0feb08cb748a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-1516: Introduce PCC mock. 05/10005/5
Milos Fabian [Fri, 15 Aug 2014 11:42:50 +0000 (13:42 +0200)]
Bug-1516: Introduce PCC mock.

-dummy PCC responder
-contains executable jar
-input parameters:
--address <inet address> (the first PCC's address, mandatory argument)
--pcc <count> (a number of PCC mocks to connect ODL's PCE, 1 by default)
--lsp <count> (a number of LSPs per PCC, 1 by default)
--pcerr (optional flag - PCC returns random PCError Msg as a response to PCUpd)
-PCC mock can establish connection with PCE, periodically (30s) sends keep-alive msg
-creates dummy LSPs and sync with PCE, responses to PCE requests (PCUpd Msg) - with PCRpt Msg

Change-Id: I5f7eff957375be53f48bc169cf85a22a19ff60b1
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-730 : added missing tests for linkstate adjacency ribs in 88/9988/1
Dana Kutenicsova [Thu, 14 Aug 2014 13:29:49 +0000 (15:29 +0200)]
BUG-730 : added missing tests for linkstate adjacency ribs in

Change-Id: I1b60a1497d880a8821b73e97685c2f13590a5ee3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-730 : more unit tests to Util. 87/9987/1
Dana Kutenicsova [Thu, 14 Aug 2014 11:16:37 +0000 (13:16 +0200)]
BUG-730 : more unit tests to Util.

Change-Id: Iee0db68ef7883bd7db391241d09ac6e9615cd2fb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Fixed config tests"
Dana Kutenicsova [Fri, 15 Aug 2014 18:45:47 +0000 (18:45 +0000)]
Merge "Fixed config tests"

9 years agoFixed config tests 85/9985/1
Milos Fabian [Fri, 15 Aug 2014 17:42:22 +0000 (19:42 +0200)]
Fixed config tests

-according to RuntimeMappingModule implenation changes

Change-Id: I9fc05d0bfa88a4c41f0a2139a4a882d789ed238d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoTell to IT the version of object-api in BGPCEP 16/9716/4
Giovanni Meo [Tue, 5 Aug 2014 16:27:04 +0000 (18:27 +0200)]
Tell to IT the version of object-api in BGPCEP

Change-Id: Ia377178f883a2747f2663e728c8752cf9137a52f
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFix a sonar warning 36/9936/1
Robert Varga [Wed, 13 Aug 2014 21:45:20 +0000 (23:45 +0200)]
Fix a sonar warning

Just be explicit about expected null-ness.

Change-Id: I3f9363878c0e985bc1fedafe3af05d3e685be400
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-730 : moved BGP path selection test to proper place. 98/9898/1
Dana Kutenicsova [Tue, 12 Aug 2014 19:47:49 +0000 (21:47 +0200)]
BUG-730 : moved BGP path selection test to proper place.
- added test for vendor tlv in pcep

Change-Id: Ibca29e9dc440a24f2b160f325df4d381be4ce149
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoFixed bgp-testool activator exception. 58/9858/3
Dana Kutenicsova [Mon, 11 Aug 2014 15:14:02 +0000 (17:14 +0200)]
Fixed bgp-testool activator exception.

Change-Id: Ic515178061e745774e51e11fc00780e3049ccd22
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Pre-populate links/nodes with empty lists"
Robert Varga [Tue, 12 Aug 2014 10:24:39 +0000 (10:24 +0000)]
Merge "Pre-populate links/nodes with empty lists"

9 years agoMerge "Bug-731: Fixed few major Sonar warnings"
Dana Kutenicsova [Tue, 12 Aug 2014 10:15:29 +0000 (10:15 +0000)]
Merge "Bug-731: Fixed few major Sonar warnings"

9 years agoPre-populate links/nodes with empty lists 85/9885/1
Robert Varga [Tue, 12 Aug 2014 10:09:26 +0000 (12:09 +0200)]
Pre-populate links/nodes with empty lists

This should for existence of the nodes in datastore.

Change-Id: Ie2ba183e927089971ce024ae0cc9d053f27f0029
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-731: Fixed few major Sonar warnings 85/9785/5
Milos Fabian [Thu, 7 Aug 2014 13:39:16 +0000 (15:39 +0200)]
Bug-731: Fixed few major Sonar warnings

Change-Id: Ic176a1f7e5478721571b8efdab470bd0dad760d6
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoProperly create parent nodes in reachability builders 80/9880/2
Robert Varga [Tue, 12 Aug 2014 05:41:39 +0000 (07:41 +0200)]
Properly create parent nodes in reachability builders

The abstract class quietly relied on parent nodes being created by the
datastore, which could have lead to them not being cleaned up. Fix the
code to do the right thing.

Change-Id: Ie5dd735b4a0791a4439d446cb2a7a5bb6fe87db5
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-1399: Fixed initial linkstate-attribute type configuration. 59/9859/1
Milos Fabian [Mon, 11 Aug 2014 15:10:12 +0000 (17:10 +0200)]
Bug-1399: Fixed initial linkstate-attribute type configuration.

Change-Id: Ie318d01687ed570aa205eed82a07dfce6835decd
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoSwitch Sonar profile 28/9828/2
Robert Varga [Wed, 6 Aug 2014 08:11:56 +0000 (10:11 +0200)]
Switch Sonar profile

This switches the sonar profile to the more strict findbugs-enabled one.
Merge when confident we can take the extra work.

Change-Id: Ia2e9224d69baf3dc74f25995bf3aeef4f5ada64d
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Revoke delegation sent as Pcinitiate message."
Robert Varga [Sun, 10 Aug 2014 05:50:01 +0000 (05:50 +0000)]
Merge "Revoke delegation sent as Pcinitiate message."

9 years agoMerge "Bug-731 Fixed few minor Sonar warnings"
Dana Kutenicsova [Fri, 8 Aug 2014 13:15:27 +0000 (13:15 +0000)]
Merge "Bug-731 Fixed few minor Sonar warnings"

9 years agoMerge "Fixed lookup of created routes in BGP Topology Exporter."
Robert Varga [Fri, 8 Aug 2014 13:03:43 +0000 (13:03 +0000)]
Merge "Fixed lookup of created routes in BGP Topology Exporter."

9 years agoFixed lookup of created routes in BGP Topology Exporter. 09/9809/1
Tony Tkacik [Fri, 8 Aug 2014 12:52:35 +0000 (14:52 +0200)]
Fixed lookup of created routes in BGP Topology Exporter.

Change-Id: I6f44c0e0265cd4ddf475a43553ba835ec8964e4b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoRevoke delegation sent as Pcinitiate message. 07/9807/1
Dana Kutenicsova [Fri, 8 Aug 2014 12:36:44 +0000 (14:36 +0200)]
Revoke delegation sent as Pcinitiate message.

Change-Id: Ife958b1a2ff98f4b2b03b0108704518ebf33b64b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-731 Fixed few minor Sonar warnings 79/9779/2
Milos Fabian [Thu, 7 Aug 2014 10:44:27 +0000 (12:44 +0200)]
Bug-731 Fixed few minor Sonar warnings

Change-Id: Id1ac7061e395f4feca8d29304785d03ef14007ad
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-731: PCEPErrors enum with error-type and error-value 70/9770/2
Milos Fabian [Thu, 7 Aug 2014 08:17:16 +0000 (10:17 +0200)]
Bug-731: PCEPErrors enum with error-type and error-value

-enum backed with inverse mapping - look-up enum for type and value
-deleted PCEPErrorMapping class - got rid of Sonar "Magic Number" warnings
-AbstractMessageParser - merge two createErrorMsg methods to one

Change-Id: I94a688427ae606eecdbafffa09d29e364f183526
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoFix UT coverage not being reported in Sonar 32/9732/5
Robert Varga [Wed, 6 Aug 2014 04:57:59 +0000 (06:57 +0200)]
Fix UT coverage not being reported in Sonar

Makes sure jacoco is run and points sonar the right way.

Change-Id: Ica97f4635e83d66133ebcaae479d6987f7b7794d
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-1116: Finish up egress path API changes"
Tony Tkacik [Tue, 5 Aug 2014 20:13:10 +0000 (20:13 +0000)]
Merge "BUG-1116: Finish up egress path API changes"

9 years agoBUG-1116: Finish up egress path API changes 22/9122/26
Milos Fabian [Tue, 5 Aug 2014 11:54:45 +0000 (13:54 +0200)]
BUG-1116: Finish up egress path API changes

This finishes the API-level changes required to support route
dissemination. The codepath should just work, but more testing is
needed.

Change-Id: I79ace174c78f0653b057b0bad1c685ecd5e9d0cb
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-479: Implementation of Vendor-Information Object 48/9648/7
Milos Fabian [Mon, 4 Aug 2014 11:25:04 +0000 (13:25 +0200)]
Bug-479: Implementation of Vendor-Information Object

-reference: http://tools.ietf.org/html/draft-ietf-pce-rfc7150bis-00
-added yang model of new object
-added abstract skeleton of Vendor-Information object parser/serializer
-PCReq and PCRep Messages models and parsers enhanced with list of VI objects
-introduced new Vendor-Information object parsers/serializers registry
-added junit tests

Change-Id: Icbf1ff79542cc2f7e5219de208ec015e31323730
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoFix integration tests after object-cache-api addition 90/9690/2
Robert Varga [Tue, 5 Aug 2014 12:05:26 +0000 (14:05 +0200)]
Fix integration tests after object-cache-api addition

Change-Id: I81ac3d42374fc80f74801b646625e93a3b08a7eb
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-479: Implementation of Vendor-Information TLV 29/9629/6
Milos Fabian [Sun, 3 Aug 2014 14:02:34 +0000 (16:02 +0200)]
Bug-479: Implementation of Vendor-Information TLV

-reference: http://tools.ietf.org/html/draft-ietf-pce-rfc7150bis-00
-added yang model of new TLV
-added abstract skeleton of Vendor-Information TLV parser/serializer
-objects's tlvs container enhanced with list of Vendor-Information Tlvs
-added junit tests

-introduced new Vendor-Information TLV registry

Change-Id: Ib14c369afb39dffd58160596dbca4954f5641a7f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-1429: Get rid of overriding managed dependencies version 49/9649/2
Milos Fabian [Mon, 4 Aug 2014 12:19:24 +0000 (14:19 +0200)]
Bug-1429: Get rid of overriding managed dependencies version

Change-Id: If9d821cf7143fe46956ea0ad7cdf6f5373a90fde
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-1116: Rework AbstractAdjRIBsIn interface 91/9491/7
Milos Fabian [Mon, 4 Aug 2014 15:45:22 +0000 (17:45 +0200)]
BUG-1116: Rework AbstractAdjRIBsIn interface

Rework the class such that we have support for encoding of individual
NLRI types, as well as adding proper insulation of the subclasses from
the actual place where a particular data node is being written to.

Change-Id: I82196d506004c30745820fd2769d63d34d5cf806
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-1116: add BGP application peer skeleton 33/9033/4
Robert Varga [Tue, 15 Jul 2014 08:17:12 +0000 (10:17 +0200)]
BUG-1116: add BGP application peer skeleton

This adds the skeleton of the application peer, which routes data
written to MD-SAL through best path selection into the local rib.

Change-Id: Id9466d4206c30747cfa59eeabcd5d79dd9718c24
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-868: migrate SchemaServiceListener users 42/9542/2
Robert Varga [Thu, 31 Jul 2014 15:55:38 +0000 (17:55 +0200)]
BUG-868: migrate SchemaServiceListener users

Follow-through for the changes introduced in yangtools/controller.

Change-Id: I9bbf1f5233a37b46219799fcfa2a81c47b236876
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-1463: Unknown attribute's bytes must be skipped. 66/9566/1
Milos Fabian [Fri, 1 Aug 2014 08:09:28 +0000 (10:09 +0200)]
Bug-1463: Unknown attribute's bytes must be skipped.

Change-Id: Ibea17c4b83a7b054997bfeb5631054a2f666c1c6
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-1383: BGP listener should fail to configure if we do not have privileges 59/9259/5
Milos Fabian [Mon, 21 Jul 2014 19:12:17 +0000 (21:12 +0200)]
Bug-1383: BGP listener should fail to configure if we do not have privileges

-verify if has root privileges, before BGP server is created.
-changed bgp's binding port initial configuration to 1790

Change-Id: Ic15c5c18ee773902b060fde733fe54f3a7a8526c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-1447: Ensure candidate's parents exist. 85/9485/5
Milos Fabian [Wed, 30 Jul 2014 13:29:12 +0000 (15:29 +0200)]
Bug-1447: Ensure candidate's parents exist.

-When electing Rib enty's new state, ensure it's parents are created.

Change-Id: Ia0791eee031dc2dba5c5b206dae693fa880df1ab
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-1116: add AbstractAdjRIBsIn documentation 88/9488/3
Robert Varga [Wed, 30 Jul 2014 09:12:56 +0000 (11:12 +0200)]
BUG-1116: add AbstractAdjRIBsIn documentation

Adds proper documentation before we start movint things around.

Change-Id: I49cd2f41a7f3294e345c733c0803c9f03d0a6264
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1116: Move BGPSession and friends to a more private place 36/9436/6
Robert Varga [Tue, 29 Jul 2014 14:28:52 +0000 (16:28 +0200)]
BUG-1116: Move BGPSession and friends to a more private place

The parser API is independent of BGPSession details. BGPSession will be
needed for the RIBsOut work.

Change-Id: I3b0774e5325d07465c00718c185e3f4a7925827c
Signed-off-by: Robert Varga <rovarga@cisco.com>