Add infrautils features to netconf-karaf

Needed as well for csit, make sure to pull it in here
so we dont have to modify the features repo in jjb scripts.

Change-Id: I76b51a7fc2f1bd70f6eadee9fc045f78087f911c
Signed-off-by: Tomas Cere <[email protected]>

Pull in controller-testing features in netconf karaf

Looks like we need this for csit.

Change-Id: I29d6de3943081d24e7a2e79280587fb89efe5b15
Signed-off-by: Tomas Cere <[email protected]>

Bump versions to 2.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I3b46e1c7dfe80f4d86f552a14aae356fb60ceb59
Signed-off-by: Robert Varga <[email protected]>

Publish netconf-karaf artifact

We want to eventually start running csit on individual distros
so make sure we have an artifact published.

Change-Id: I46aba477df05b175f0ad2e1df313ae37f51e59c2
Signed-off-by: Tomas Cere <[email protected]>

Use RFC 8040 paths by testtool

Switch to use RFC 8040 implementation paths
for device registration in testool.

JIRA: NETCONF-796
Signed-off-by: Ivan Hrasko <[email protected]>
Change-Id: Id86fc5e7d6f0339f78e3dbc0c20aa45457bec799

Fix testtool device registration

The NETCONF testtool functionality for automatic bulk
registration of devices was broken for some time.

We have decided to not only fix the problem but also
refactor testtool the following way:

- Create request bodies using NormalizedNodes
instead of using config templates.

- Register devices with PATCH instead of POST
to allow merging nodes into topology and prevent
error for consequent batch requests.

JIRA: NETCONF-796
Change-Id: Ifd7c74e9b07bb56b84e6a1ffea0bf2809b85246c
Signed-off-by: Illia <[email protected]>
Signed-off-by: Ivan Hrasko <[email protected]>

Modernize test suite

- Remove try catch blocks and use assertThrows method instead
- Use assertEquals method where possible

Change-Id: I5790d8197187e2130b52920b8659acd56cc98e57
Signed-off-by: Dominik Vrbovsky <[email protected]>

Use Java 11 HttpClient

Reduce dependencies by using JRE-provided HTTP client.

JIRA: NETCONF-751
Change-Id: I49a51306a042ed534bafd7174633e300f00ce305
Signed-off-by: Robert Varga <[email protected]>

Remove DocumentedException.ErrorTag

We have an openly-extensible ErrorTag concept in yang-common. Remove
the hard-coded enum we have in DocumentedException.

JIRA: NETCONF-793
Change-Id: Ic4e1bebff549c5fd09a78995b8e76e37905241ef
Signed-off-by: Robert Varga <[email protected]>

Remove RestconfError.ErrorType

yang-common is providing us with a replacement, switch to using it,
which allows us to ditch some amount of legacy code.

JIRA: NETCONF-793
Change-Id: Id71b5f7a992456ff17b53795e54e7a8b49120586
Signed-off-by: Robert Varga <[email protected]>

Remove DocumentedException.ErrorType

Use ErrorType from yang-common instead of defining our own. This allows
us to reuse some mapping code as well.

JIRA: NETCONF-793
Change-Id: I00c3344f15f5e052784e9f439a025678b093655e
Signed-off-by: Robert Varga <[email protected]>

Remove DocumentedException.ErrorSeverity

Use ErrorServerity from yang-common, eliminating some amount of
duplication. This also allows us to take advantage of bidirectional
mapping to (now legacy) RpcError.ErrorSeverity.

Also modernize test suite to perform correct asserts.

JIRA: NETCONF-793
Change-Id: Ie7e592233e6a948a9a991e4309315e1fb857b8d2
Signed-off-by: Robert Varga <[email protected]>

Cleanup DocumentedException and subclasses

Do not qualify Error{Type,Tag,Severity} and use Map.of() instead
of Collections.emptyMap().

Change-Id: I9eb201a2c02f8ac4370341a98fdf94a1f7a6425e
Signed-off-by: Robert Varga <[email protected]>

Remove Jakub Toth from committers

Jakub has been mostly inactive in this project since 18.8.2020. He
has asked to step down now.

Change-Id: I8ee4705ee09bd6666b48bbd4dc10a9936b445cc9
Signed-off-by: Robert Varga <[email protected]>

Bump upstream versions

Adopt mdsal-8.0.1, controller-4.0.1, aaa-0.14.1. Also fix unit test
assertion now that yangtools reports the right layer.

Change-Id: If8c205094a55d8c956d575af8a8d7cec5eb2aadf
Signed-off-by: Robert Varga <[email protected]>

Log full exception when we are missing errors

Our current logging does not identify the source of the offending
exception. Make sure we log the entire input exception, so that
offenders may be fixed up.

JIRA: NETCONF-789
Change-Id: I30a24a615ce221a838e1ad95f6b11263e2d6f8f5
Signed-off-by: Robert Varga <[email protected]>

Bump versions to 2.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: Icfc93a2326c62319d8e82008141c2b7c21409353
Signed-off-by: Robert Varga <[email protected]>

Bump janino to 3.1.4

https://janino-compiler.github.io/janino/changelog.html

Change-Id: I40ce79d4001a10af6bedfaf8ff5657036d892a88
Signed-off-by: Robert Varga <[email protected]>

Convert netconf-client to OSGi DS

This is a rather straighforward migration, but we also ditch the
now-unneeded Autocloseable from AbstractNetconfDispatcher.

JIRA: NETCONF-791
Change-Id: I4737ef30e0ff3b12bbaedcf8940edf80d8eb7d7a
Signed-off-by: Robert Varga <[email protected]>

Ditch blueprint-maven-plugin

We have two artifacts using a combination of generated and hand-written
blueprint containers. This makes reasoning about the actual wiring
rather hard. Inline the generated XML into the hand-written one, so that
we can untangle it more easily.

JIRA: NETCONF-749
Change-Id: I380600215a0fadf438b9a44e6ea4465f15d63fbf
Signed-off-by: Robert Varga <[email protected]>

Cleanup NetconfConsoleUtils

We have a few strange methods here, clean them up to streamline.

Change-Id: Icf0ca4661d4b62cf9e3855af99a6611d1b719869
Signed-off-by: Robert Varga <[email protected]>

Convert netconf-console to OSGi DS

netconf-console is a very simple component, convert it to OSGi DS.

JIRA: NETCONF-792
Change-Id: Ic92a59b52a85af67a8ed648a53cb11a083928ece
Signed-off-by: Robert Varga <[email protected]>

Remove old AbstractNetconfDispatcher.getReconnectingClient()

This method is not used anywhere, remove it. Also deprecate the
corresponding re-establishment policy, as it is no longer used.

Change-Id: I89b5ebf3197e8d459501b11433f3c9eaa3845281
Signed-off-by: Robert Varga <[email protected]>

Move Rfc8040.Restconf constants

We are using most of these constants only in export, clean them up and
move them to their sole user.

Change-Id: I493bb2baed521367ff78d6ec07ad64ee56516c32
Signed-off-by: Robert Varga <[email protected]>

Move mapModulesByIetfYangLibraryYang()

This method has only a single production caller, migrate it to that
class, making reducing utility overloads.

Change-Id: I2c210e93797fbe5575c524e54c6c3ad6841b950f
Signed-off-by: Robert Varga <[email protected]>

Migrate getDataChildByName() callers

ControllerContext missed the migration of getDataChildByName(), hence
it's nullness checks are ineffective and it is tripping over. Make sure
we use plain dataChildByName() when we can tolerate missing data.

JIRA: NETCONF-790
Change-Id: Ic3aa31c764d08c199085b750674e5f98c9165f2e
Signed-off-by: Robert Varga <[email protected]>

Update tests with Akka Artery

Upstream has switched to using Artery TCP instead of classic transport.
Update test config file
netconf/netconf-topology-singleton/src/test/resources/application.conf
with new transport (artery-tcp)

JIRA: NETCONF-787
Change-Id: I70a4a5bb23f53166d8b164fced7f1311f1d7f764
Signed-off-by: Kostiantyn Nosach <[email protected]>
Signed-off-by: Robert Varga <[email protected]>

Single out RestconfConstants.MOUNT

This constant should be used via its PathArgument equivalent. Reduce
its use in tests and mark it for removal.

Change-Id: Ia3b75b95b236e35167ffb213c138930ed419a7f1
Signed-off-by: Robert Varga <[email protected]>

Remove RestconfConstants.IDENTIFIER

This constant is not really useful, as it is referenced once in
production code and once in testing. Inline the definitions, as we
really want to make an explicit assertion in tests.

Change-Id: I7fd7a6e64562cb054b15011c1aad7624c47fea3d
Signed-off-by: Robert Varga <[email protected]>

Collapse streams.{sse,websocket}

This two packages have just a few classes, collapse them to simplify
overall structure.

Change-Id: Ib3df507ac7b68e8641b933ac45c42f3bd7494437
Signed-off-by: Robert Varga <[email protected]>

RestconfTransaction always operates on a single datastore

Previous refactors in this area have suffered from lack of actual
clarity. All legitimate users of RestconfTransaction operate on
CONFIGURATION, hence use that without allowing a possiblity to
mix&match datastore access.

Change-Id: Ief9ff8d51e12c3cd3e04e55f9cd04b2b42f81068
Signed-off-by: Robert Varga <[email protected]>

Clean up RestconfInvokeOperationsUtil

RPC/action invocation through mount point and service is the same,
except for an additional lookup/throws. Restructure code to take
advantage of that.

JIRA: NETCONF-773
Change-Id: I68a4d75564b2f0a42070ad9f8ebd140109a6eb62
Signed-off-by: Robert Varga <[email protected]>

Clean up listener activation

We have a two-step process in listener create/activate. Move methods
around so that the process can become properly stateful, without
giving out too much in terms of actual implementation methods.

JIRA: NETCONF-773
Change-Id: Ib9aa28a7b00e8f292a8a97a56d472ed51a9c45fd
Signed-off-by: Robert Varga <[email protected]>

Package ietf-yang-patch

This is the model published in RFC8072, which gives us some basic
structural elements. Its value will increase once we can generate
structures for rc:yang-data.

JIRA: NETCONF-788
Change-Id: I063cea05f33cc8191db4320ee686b253b0471679
Signed-off-by: Robert Varga <[email protected]>

Rename {Xml,Json}ToPatchBodyReader

Make sure we have consistent naming here by dropping 'To'.

JIRA: NETCONF-773
Change-Id: If1fd3cb6b07c97c7faf18b8d8324e81e9888c084
Signed-off-by: Robert Varga <[email protected]>

Move validation methods

PutDataTransactionUtil is rather ugly in that it is used only
by a single implementation. Start disolving it by moving data validation
methods to RestconfDataServiceImpl.

JIRA: NETCONF-773
Change-Id: I365c087392fb0f593560c4dac3583622b341b037
Signed-off-by: Robert Varga <[email protected]>

Add AbstractPatchStatusBodyWriter

We have two specializations of this writer, create a common superclass
and share common code. Also improve error handling by mapping wrapping
XMLStreamException into an IOException.

JIRA: NETCONF-773
Change-Id: I000b9c7b333f59d000dc28ce2e75ee65477da193
Signed-off-by: Robert Varga <[email protected]>

Add AbstractNormalizedNodeBodyWriter

We have two specializations of this writer, share common code in
an abstract class. Also use more regular class naming.

JIRA: NETCONF-773
Change-Id: I8f52090de19a44a0293cb2cb07bfb9623250e34c
Signed-off-by: Robert Varga <[email protected]>

Move AbstractNormalizedNodeBodyReader

We have only two specializations in jersey.providers package, move
the base class there.

JIRA: NETCONF-773
Change-Id: I1ae2cadff525af8089a511738989de68a3866df7
Signed-off-by: Robert Varga <[email protected]>

Refactor source export

Add AbstractSchemaExportBodyWriter and specialize it for YIN/YANG.
Also eliminate jersey.provides.schema package, as it does not really
make sense.

JIRA: NETCONF-773
Change-Id: Ia099e927da10f451cd843ba947a79312dd35af19
Signed-off-by: Robert Varga <[email protected]>

Remove MessageBodyWriter.getSize() implementations

getSize() is documented legacy method which has a default implementation
and does nothing. Remove unneeded implementations.

JIRA: NETCONF-773
Change-Id: I1e1a9310f3ad78fe684de02fbaec5035bd1fcb90
Signed-off-by: Robert Varga <[email protected]>

Remove TransactionChainHandler

This class is pure overhead and serves no purpose. Remove it to
simplify lifecycle as well as improve latencies.

JIRA: NETCONF-773
Change-Id: I0506f17d05cec910057e40742adfbb04225f4211
Signed-off-by: Robert Varga <[email protected]>

Reduce use of TransactionChainHandler

SchemaContextHandler does not need transaction chains at this point.
When it will need them, it will manage their lifecycle on its own.

JIRA: NETCONF-773
Change-Id: I89587b9777cb1ae7aa0b0fe628e3fa4ef16e83a3
Signed-off-by: Robert Varga <[email protected]>

Use free-standing transaction in SubscribeToStreamUtil

There is no point in juggling transaction chains here, just use
a simple free-standing transaction. Also note we do not need a
read-write transaction, so allocate a write-only transaction, which
is generally cheaper.

JIRA: NETCONF-773
Change-Id: Ib9995f664a27a2d29e91c18032d2a02cca6d768d
Signed-off-by: Robert Varga <[email protected]>

Unwrap ListenersAdapter

We are calling Optional.get() repeatedly here, after performing
an isPresent() check. Use .orElseThrows() to ditch the Optional,
making things simpler.

Change-Id: I4242b39176bfee52d316969eb806a1fef21c2f90
Signed-off-by: Robert Varga <[email protected]>

Remove ResolveEnumUtil

ResolveEnumUtil is a rather timid utility, which is best eliminated
by adapting its users to do something smarter. We also suffle a few
constants around to make information scoping a bit clearer.

Change-Id: I54b347e7ec24876a3e1515c57af6c2db3cec9c55
Signed-off-by: Robert Varga <[email protected]>

Make ListenersBroker.getInstance() lockless

While this is a huge antipattern in terms of retained global state,
we do not need to bounce a global lock to access it.

Use Initialization-on-demand holder idiom to make the access completely
lockless.

Change-Id: I374737f2dc5b3b07226eb7bbffcaaf2665cc8967
Signed-off-by: Robert Varga <[email protected]>

Fix checkArgument() use

We do not want to concat the strings here, use a proper formatting
string -- speeding things up.

Change-Id: I0585752e07a4e58abf22d3e0facc93d0623ee198
Signed-off-by: Robert Varga <[email protected]>

Deprecate restconf.common.util.MultivaluedHashMap

This is a custom-coded class, which has a direct competitor in
javax.ws.rs.core. Deprecate it in favor of the standard class.

Change-Id: I2397c4a3b72d410a39806c1b147d9816b95eb875
Signed-off-by: Robert Varga <[email protected]>

Improve content checking

We have neat nested ifs to check for the content value, which makes
it rather hard to understand what is going on. Use a simple switch
expression to validate the values instead.

Change-Id: I7799fafd45ec393541a5f7f2ede92d8e6a178375
Signed-off-by: Robert Varga <[email protected]>

Fix field count check

This is a simple copy&paste error which slipped past review, fix it up.

Change-Id: Ia381754abc7ec9d3adf53066ab2f8910e5554123
Signed-off-by: Robert Varga <[email protected]>

Speed up checkParametersTypes()

Our checking logic here is rather sub-optimal, performing multiple
operations. Improve situation by using a fixed Set along with its
containsAll() method. The actual delta is computed only if we determine
there is something amiss.

Change-Id: If85e1049a34804444db6ad9849147b51b333b76f
Signed-off-by: Robert Varga <[email protected]>

Speed up parseUriParameters()

Pre-construct our default values and access query parameters only once.

Change-Id: Ice551e9c441e86711d7705bf40fe0f2670c0440a
Signed-off-by: Robert Varga <[email protected]>

Bump versions to 2.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I4783ed8f10b04820f00857379dd316d030802cec
Signed-off-by: Robert Varga <[email protected]>

Add a logging event when schema is loaded

This is a useful indication as to when we are laying claim on the
directory.

Change-Id: I8a9057fa0b0ea84b54b1ec16c01979286a195277
JIRA: NETCONF-605
Signed-off-by: Robert Varga <[email protected]>

Use released aaa 0.14.0

Fix version to released artifacts.

Change-Id: I1a62c6475d9e7c0fc27426ba6b42c066bf676a0e
Signed-off-by: Robert Varga <[email protected]>

Remove OSGiSchemaResourceManager

We have OSGi R7, hence we have use constructor injection and express our
dependency on SCR.

Change-Id: I77f92de079aa2d51c444451ffd0db4bf2168695f
Signed-off-by: Robert Varga <[email protected]>

Update sal-rest-docgen dependencies

We do not need parser here, we are getting all we need from
yang-test-util.

Change-Id: I3450b7ad3b0422b01cf3d43e8e2ed1f67c04d756
Signed-off-by: Robert Varga <[email protected]>

Use controller-4.0.0

Do not use snapshots for controller artifacts.

Change-Id: I86a46dbc466d0c4dde611f364e57808fc23b8e33
Signed-off-by: Robert Varga <[email protected]>

Update RESTCONF error mapping

yang.common.YangError is an attachment used to propagate RFC6020-defined
failure modes enforced by YANG Tools as exceptions. One such example is
YangInvalidValueException, which is reporting YANG constraint
violations.

Recognize these when mapping to RestconfDocumentedException, so that
their error-app-tag and error-message are properly propagated.

JIRA: NETCONF-786
Change-Id: Id6ea1877e03f42fc193942a4e2b83ecb6daeb631
Signed-off-by: Robert Varga <[email protected]>

Fixup MD-SAL breakages

There are a few last-minute breaking changes coming from MD-SAL, make
sure we adapt to them. Also use released artifacts, so we should be fine
until we use snapshots again.

Change-Id: I12a44b2041fc47a824c039dddfdb21e3ebc8be17
Signed-off-by: Robert Varga <[email protected]>

Cleanup yanglib dependencies

We do not need yang-model-{api,util} here, remove the declarations.

Change-Id: I63ebd0b2fba3be82009b7a3e1e916526d2f0d36a
Signed-off-by: Robert Varga <[email protected]>

Update json-unit-assertj to 2.27.0

There have been a few releases over the past year, catch up with them.

Change-Id: Ia3f24f73ecb386a9d3d6850159cd2ae8167c9049
Signed-off-by: Robert Varga <[email protected]>

Cleanup restconf-nb-rfc8040 dependencies

We have a few unnecessary dependencies here, readjust them to minimize
footprint.

Change-Id: Iacf49cce058aedc37e3d63067391026f65d0c235
Signed-off-by: Robert Varga <[email protected]>

Cleanup restconf-nb-bierman02 dependencies

We have a ton of dependencies which are not used, or used only for
testing. Clean them up.

Change-Id: I8e86de3279b8f82b66b53879583cb2ec9b19c90d
Signed-off-by: Robert Varga <[email protected]>

Cleanup restconf-common dependencies

We do not need parser-impl nor model-util, just model-ir.

Change-Id: Id37cd1fd37697b27f4f67ec40b652bb93403e571
Signed-off-by: Robert Varga <[email protected]>

Cleanup netconf-topology-singleton dependencies

We are not using codec-xml here, remove it.

Change-Id: I1c0f8e264d9465c45daba805f744df5f48b482e6
Signed-off-by: Robert Varga <[email protected]>

Clean up mdsal-netconf-connector dependencies

We have a few superfluous dependencies here, remove them.

Change-Id: I3a47677de71d134437b6ff321009386bd7fea435
Signed-off-by: Robert Varga <[email protected]>

Drop an unneeded dependency from mdsal-netconf-monitoring

We do not use ietf-inet-types here, remove it.

Change-Id: I359aa26a6cc9463e9f706070debb5f707501465c
Signed-off-by: Robert Varga <[email protected]>

Remove sal-rest-docgen-maven

Static generator for swagger documentation is not used anywhere and it
is an utter mess. Remove it.

JIRA: MDSAL-232
Change-Id: I8a131f22f7f5d01aa0d66116413ded822fda1341
Signed-off-by: Robert Varga <[email protected]>

Add restconf-wadl-generator

WADL generator is a tiny bit coming from MD-SAL's
maven-sal-api-gen-plugin, but dependent on RESTCONF semantics.

This patch imports its state as of commit
123a8fe79fa859b5e64e3efbd004d0730e25164d, taking ownership of it.

JIRA: MDSAL-232
Change-Id: I81cc5cb6e2ef3496605e3532087688eb4ab172e2
Signed-off-by: Robert Varga <[email protected]>

Refactor Swagger unit tests

Get rid of incorrect equals call on module revision by
using SchemaContext#findModule methods to find
module according to namespace (and revision).

Because of incorrect equals call the tests
were just passing without any assertions and
were not maintained for long time, some of the
assertions needed to be adapted.

Remove unnecessary code to load EffectiveModelContext
from DocGenTestHelper and instead use YangParserTestUtils
methods directly in tests.

Refactor DocGenTestHelper to be utility class.
Refactor tests code, make tests logic more simple.
Also, introduce tests for ApiDocGeneratorRFC8040.

JIRA: NETCONF-785
Change-Id: I195acbca354cdfe80241430255254436d0dac23f
Signed-off-by: Ivan Hrasko <[email protected]>

Fix multiple keys path in RFC8040 swagger

ListPathBuilder for RFC8040 needs to change its state
when processing multiple keys (= to ,) thus we have
to create it before the iteration over all list keys.

JIRA: NETCONF-708
Change-Id: If617ff1508e63b1001ab7857e3b3fdebff287f74
Signed-off-by: Ivan Hrasko <[email protected]>
Signed-off-by: Robert Varga <[email protected]>

Mark netconf node with ext:mount

Add an explicit marker for netconf topology nodes.

JIRA: NETCONF-783
Change-Id: Ie037ea099ed2ebb426242922cf3f7b791e5f7dc4
Signed-off-by: Robert Varga <[email protected]>

Bump MRI upstreams

Adopt latest versions, namely;
- odlparent-9.0.2
- yangtools-7.0.2-SNAPSHOT
- infrautils-2.0.2
- mdsal-8.0.0-SNAPSHOT
- controller-4.0.0-SNAPSHOT
- aaa-0.14.0-SNAPSHOT

Change-Id: Ic4cbc01d88134df26416cd2d6f3e7ac64a03dc1a
Signed-off-by: Robert Varga <[email protected]>

Use InstanceIdentifier.empty()

We do not need a builder here, just use the empty identifier.

Change-Id: I65d6cd0d27e71316b5a8eed330157b583e406474
Signed-off-by: Robert Varga <[email protected]>

Handle NetconfDocumentedExceptions correctly

These need to be wrapped in TransactionCommitFailedException
so they are handled correctly, so restconf can map these and
return correct status code on failure.

JIRA: NETCONF-777
Change-Id: Id4833bfe46da6f97a216163452dd2a44af599063
Signed-off-by: Tomas Cere <[email protected]>
Signed-off-by: Robert Varga <[email protected]>

Correct stream instance identifier

Constructed path has a mismatch in both depth and map identifier QName,
fix that up.

JIRA: NETCONF-773
Change-Id: Ib0ce3c3727f5cf340d8d1d6ea8e449bf3f83f2f3
Signed-off-by: Robert Varga <[email protected]>

Add sample how to use karaf static distribution for NETCONF and RESTCONF

This shows how the combination of NETCONF connector and RESTCONF can be
packaged inside the static karaf distribution.

JIRA: INTDIST-116
Change-Id: I4b21b0cde3ae3ca3276133355b166e662d3212e7
Signed-off-by: Oleksii Mozghovyi <[email protected]>
Signed-off-by: Robert Varga <[email protected]>

Fix augment argument

As per RFC6020 section 7.15, augment statement used under a module
(or submodule} statement MUST use absolute form must be used.
Fix our test model.

Change-Id: I0b6a566f448464643c0796714de268464412bff6
Signed-off-by: Robert Varga <[email protected]>

Fixup netconf-parent path

netconf-parent's directory is just 'parent', fix that up.

Change-Id: I863f07415ec49cb8ecda0c60de316ce048c27d9b
Signed-off-by: Robert Varga <[email protected]>

Cleanup FilterContentValidator

Make sure we do not mutate our argument and do not access children
until necessary.

Change-Id: Ic2a1a7561fc321b75f2e63a6968eb20507cdda43
Signed-off-by: Robert Varga <[email protected]>

Initialize FilterTree.children

This is a simple move of initializer, so that it is obvious what
is going on.

Change-Id: I002cc767bd0d98855c31a172d45ccdc39389a5b5
Signed-off-by: Robert Varga <[email protected]>

Modernize netconf-util tests

Use assertThrows() and fixup imports a bit.

Change-Id: I2816141af08815afb0dc926e78ace962ba561ded
Signed-off-by: Robert Varga <[email protected]>

Cleanup netconf-impl tests

Use static imports for assert methods, and use assertThrows() instead
of try/catch blocks.

Change-Id: I0054becc441cbe33c6aedf156b267429eb53e224
Signed-off-by: Robert Varga <[email protected]>

Cleanup NetconfMDSalMappingTest

Use assertThrows() and remove unused code.

Change-Id: Ia0c1ab438ad93026fff28c476254e409bd2cc4ae
Signed-off-by: Robert Varga <[email protected]>

Update RuntimeRpc a bit

Move Element cast to the method which is producing it, saving one
import.

Change-Id: Ie00e716681666ae64f2774cf068a202e54fbeb81
Signed-off-by: Robert Varga <[email protected]>

Remove restconf-parent

This pom is a useless wrapper around netconf-parent. Eliminate it and
migrate its users.

Change-Id: Id3c0cc6458855a7c4bd9eeb6a2e8e3d47d57b9da
Signed-off-by: Robert Varga <[email protected]>

Remove superfluous version/groupId declarations

We can inherit these declarations from our parent structure, making
poms a tad leaner.

Change-Id: Ia56733a45566af971d8963b1465341925de4ce7f
Signed-off-by: Robert Varga <[email protected]>

Enable TCP_NODELAY for SSH client/server

Both NETCONF northbound (SshProxyServer) and southbound
(AsyncSshHandler) plugins exhibit latencies caused by Nagle's algorithm.
These are superfluous, as we typically work in request-response manner,
with reasonable level of buffering going on in the intermediate layers.

Set TCP_NODELAY flag to get rid of these artifacts.

JIRA: NETCONF-776
Change-Id: I68a87cc2bef4f0032e104833b8d241f5b1f7566b
Signed-off-by: Robert Varga <[email protected]>

Cleanup RFC8040 media type handling

Promote Rfc8040.MediaTypes to a top-level types, adding documentation
and proper constants mimicking the layout of javax.ws.rs.core.MediaType.

As part of this exercise, also correct the media types produced by our
JAX-RS services so they accurately comply with RFC8040, RFC8072 and
RFC6415.

JIRA: NETCONF-779
JIRA: NETCONF-780
Change-Id: Iaaf192e9d30858f5ce6f8e3484ea232fbf69e92f
Signed-off-by: Robert Varga <[email protected]>

Switch to using SseEventSink

JAX-RS 2.1 has a standard way of working with SSE, do not use
Jersey-specific APIs (except in test).

JIRA: NETCONF-775
Change-Id: I46c2b80be52d2313ab9193361da788f41923c175
Signed-off-by: Robert Varga <[email protected]>

Use MediaType.SERVER_SENT_EVENTS

We are using JAX-RS 2.1, hence we have SSE support built-in. Reduce
dependency surface by using MediaType constant instead of Jersey's
Feature.

JIRA: NETCONF-775
Change-Id: I27338775dd3cd92681a4c1f953f71145100f24ef
Signed-off-by: Robert Varga <[email protected]>

Improve event fragmentation

Rather than instantiating String objects, use StrinBuilder's ability to
append CharSequence parts.

Change-Id: I1283791c50a9e41fd1703786cbf2aefe71e75484
Signed-off-by: Robert Varga <[email protected]>

Use a simple isEmpty() check

Rather than checking size() == 0, use isEmpty(), which is clearer
and potentially fasterUse a simple isEmpty() check

Rather than checking size() == 0, use isEmpty(), which is clearer
and potentially faster.

Change-Id: I0aadff4a55258f2fbb0bd60c26993b08b3b8e7b0
Signed-off-by: Robert Varga <[email protected]>

Refactor ietf-restconf constants

We have a number of constants which overlap with definitions generated
for the ietf-restconf module. Use QNames from generated code and rehost
all constants to their users.

JIRA: NETCONF-773
Change-Id: Ic6fe0a8fedf4029fabc5cdf3ea634975b5949515
Signed-off-by: Robert Varga <[email protected]>

Use ImmutableNodes.leafNode()

Do not use schema-aware builder, use a straight-up shortcut to a
LeafNode.

JIRA: NETCONF-773
Change-Id: I306dde8b7f8857945d1036945545c65fc98c4c3b
Signed-off-by: Robert Varga <[email protected]>

Refactor constants relating to restconf-monitoring

We have a number of constants scattered around, some of which can
have better names and placement, or are duplicates of constants
generated for the ietf-restconf binding.

Reuse generated constants and construct native YangInstanceIdentifiers,
so we minimize duplication.

JIRA: NETCONF-773
Change-Id: I5a17cbdd863fcdbaf75db56d4a8b0daddfe5e7a9
Signed-off-by: Robert Varga <[email protected]>

Cleanup Rfc8040 constants

A number of constants here are unused, remove them.

JIRA: NETCONF-773
Change-Id: If75073a19eff52da4cf68c9601c1b775258a42d4
Signed-off-by: Robert Varga <[email protected]>

Rename SessionHandlerInterface

The 'Interface' part is obvious, but it is not immediately obvious
what sort of 'session' and 'handler' we are talking about. Rename
it to StreamSessionHandler.

Change-Id: I76fe4f0a7fc87134ce15dece17bb5bdd2075b779
Signed-off-by: Robert Varga <[email protected]>