Removing Blind imports across the module

This commit removes blind imports across the netvirt module.

Change-Id: I3b6d70cd6e83384eaf54f2a2f97495ae47df9e49
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>

Merge "Fix IndexOutOfBoundsException when a port with IPv6 address is deleted"

Merge "Addition of BgpAlarms"

Merge "BUG-6501: avoid NPE if sgm isn't defined"

Merge "BUG 6489: Routes to InterVpnLink not advertised on BGP"

Fix IndexOutOfBoundsException when a port with IPv6 address is deleted

This patch avoids the following exception.
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
 at java.util.ArrayList.rangeCheck(ArrayList.java:653)[:1.8.0_101]
 at java.util.ArrayList.get(ArrayList.java:429)[:1.8.0_101]
 at *netvirt.neutronvpn.NeutronPortChangeListener.addPortToSubnets(NeutronPortChangeListener.java:552)
 at *.netvirt.neutronvpn.NeutronPortChangeListener.handleNeutronPortUpdated(NeutronPortChangeListener.java:355)
 <SNIP>

Change-Id: If9de109b22dde15da07dcd9284b8525ffba2b6fb
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

BUG 6489: Routes to InterVpnLink not advertised on BGP

 + Missing functionality: when a route pointing to an interVpnLink
   endpoint is added/removed to a Neutron Router, CSC must advertise
   the prefix. The nexthop(s) for the BGP are the DPNs where the
   endpoint of the InterVpnLink was instantiated

 + Moves some InterVpnLink utility methods from VpnUtil.java to
   InterVpnLinkUtil.java

 + Changes some return values to Optional.

Change-Id: I9e671b34400151099e501d26a8a7839c7730d0b7
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>

BUG-6501: avoid NPE if sgm isn't defined

System.getProperty("sgm") returns null if the system property isn't
defined, which throws a NullPointerException on the equals() call.
Inverting the equals() avoids this.

Change-Id: I6060d07a1958ab60de9e816cdfdbe477e4503cf2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Addition of BgpAlarms

Change-Id: I14071695fa0ed858627b0bb1ea16e90ae2188cdc
Signed-off-by: Chintan Apte <chintan.apte@ericsson.com>

Learn Security Groups bug fixes

Change-Id: I0d0b93847520b349c9e5c6a1ef05d6ddce62adb6
Signed-off-by: Slava <slava.radune@hpe.com>

Merge "Fix bug wherein console commands would not work with Karaf ssh session"

Fix bug wherein console commands would not work with Karaf ssh session

Change-Id: I672e5498cc5d8be2e3d6d3d08e1c72f73bf597c8
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>

Bug 6477 - Fixes dissc of rtr from VPN & VPNPortFixedIpToPort

1. Fix to ensure adjacencies are deleted properly for learnt routes upon
dissociation.
2. Refactor to reduce reads/writes/builders
3. Added synchronization on interfacename for Arp and NeutronVPN while
updating vpninterface-adjacencies.
4. Fix in remove FibManager to not call leakRouteIfNeeded for non-BGP
routes
5. Renamed ArpRemoveCacheTask and ArpAddCacheTask classes to have proper name.
6. Eliminated reads upon DS deletes for VpnPortIPToPortData DS.

Change-Id: Ib6580c71cbce6451d411e1c5f030582225830b4d
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>

Merge "Use node conn info remote ip for sff"

Merge "Copy default aclservice-config.xml to etc/...config"

Use node conn info remote ip for sff

Change-Id: I789e650fb465bc2f8123cd021c242d315320c906
Signed-off-by: Sam Hague <shague@redhat.com>

Copy default aclservice-config.xml to etc/...config

Change-Id: I13c3f7618830c8864a1c3cd1a91bba4c7efe7989
Signed-off-by: Sam Hague <shague@redhat.com>

Fix read of VpnPortipToPort to read from Operational

In patchset https://git.opendaylight.org/gerrit/#/c/43719/
VpnPortipToPort is written operational DS.

This commit fixes NatUtil/SubnetGwMacChangeListener to read from
the updated location.

Change-Id: I7045c9bff47ef0bde7fc3e9a9d8a3b526e54e125
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>

Handle learn security groups

Change-Id: I9d3385502a1e902ba6dd1a034927595d04b54ee8
Signed-off-by: Slava <slava.radune@hpe.com>

BUG 6487: Extra routes to IVpnLink endpoint not in FIB

 + LportTag range for InterVpnLink endpoints has changed to a range of
   [170001..270000]. Those values does not fit in a uint16 attribute

 + Also applies a bit of refactoring to reduce the duplication of code
   as much as possible

 + It also aligns the system properties names to the ones defined
   in sdnc repository

 Apart from above bug fix this commit also deals with:

 1> Fixes in metadata writing
 2> InterVpnLink Active even if VPN not exists

Change-Id: Iafe72a651153a7ca48e68748c6b7b271541e835c
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>

Merge "Bug 6486 - Add waits for IT Utils"

Bug 6486 - Add waits for IT Utils

Change-Id: I315706be5e216d23de4f4a0d037cd272b698f734
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Allow non-default controller-dhcp-enabled at init"

Merge "Fixes Bug 6469 "

Merge "code optimization for cluster environment"

Merge "Fixes Bug 6478"

BUG 6389: ServChain not applied to VMs in VPN

Service Chaining Traffic should be forwarded to the DPN connected to
the Fist VM of SC Path.

Aprt from fixing above bug, this review also deals with the following:

1> Fixes bug in InterVpnLink static route provision
2> Removes NPE protection from NeutronVpnmanager

Change-Id: Ic31e0399e5684d7512571a4d63f4ab01fd3400a3
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>

Bug 6390 Fix ArpNotificationHandler initialization.

Change-Id: If9b755be9dab216e75c945bc9c28e9943f954e06
Signed-off-by: Achuth <achuth.maniyedath@ericsson.com>

Fixes Bug 6478

Changed the code to match the destination port for TCP and UDP in both
egress and ingress.

Change-Id: I6da8373e6526ef621dfe90ecdfc51ed80db12c80
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Fixes Bug 6469

CtZone is added while submitting the packet to the netfilter. This help
addressing the issue with overlapping ip address as each elanId will be
tracked separately.

Change-Id: I70867cfb89e279926128bbe794cc8164affc115f
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Merge "Bug 6390 VpnPortIpToportData to use Oper DS"

Merge "No need to create br-ex any more. br-ex(it) ;)"

Allow non-default controller-dhcp-enabled at init

Currently controller-dhcp-enabled cn only be set through yang and defaults
to false. To change one must wait for bundles to come up and change
through restconf. This adds option to specif a different default at bring
up.

To set the default for controller-dhcp-enabled:

1. Change the value in dhcpservice/.../netvirt-dhcpservice.xml
2. Copy the file into the unzipped distribution before starting karaf:
  cd netvirt/vpnservice
  mkdir -p ./distribution/karaf/target/assembly/etc/opendaylight/datastore/initial/config
  cp dhcpservice/impl/src/main/resources/netvirt-dhcpservice.xml ./distribution/karaf/target/assembly/etc/opendaylight/datastore/initial/config

Change-Id: I6768e117515a4ff2c52e70961efb3aeac65c8d5f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

No need to create br-ex any more. br-ex(it) ;)

devstack no longer checks for it and we
do not use it.

Change-Id: I4f72331e321e5094ffb7b378cbee894932001dbf
Signed-off-by: Josh <jhershbe@redhat.com>

Merge "elanmanager CLI console commands impl should never catch Exception"

Blueprint fix

Registration of entity type "elan" missed out. This is used by L2Gw in
order to identify the owner for type "elan".

Change-Id: I583ec617529a82ee8a0db1dbd34421c29ac9f571
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>

Merge "Port cloud-servicechain to Blueprint"

Merge "add local_ip to other_config to satisfy auto-tunnel"

Merge "Clean up a bunch of trival Checkstyle violations"

Merge "Bug 6449 - Issues in Service Function Forwarder translation"

Merge "clean isExternal NPE and string syntax"

Merge "ACL Support for IPv6 IPAM"

Merge "More elan Blueprint clean-up"

Merge "Remove elanUtils instance from ElanInstanceManager"

add local_ip to other_config to satisfy auto-tunnel

Change-Id: I06b6688572440f2445a0a0f64f9fe6a6933ac18b
Signed-off-by: Sam Hague <shague@redhat.com>

clean isExternal NPE and string syntax

Change-Id: I5aed5a3bcc830a9df461e7c76fa92d0095ff796f
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Fixing external network group table lifecycle"

Merge "Neutronvpn caches require update upon Router/Network changes"

Merge "Rename JMX MBean's ObjectName from com.ericsson to org.opendaylight"

Merge "Fix completely broken ElanStatusMonitor JMX MBean"

Neutronvpn caches require update upon Router/Network changes

Change-Id: I1381bc8def2124a57b0daa29faa11341ecdd99f9
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Rename JMX MBean's ObjectName from com.ericsson to org.opendaylight

From com.ericsson.sdncp.services.status:type=SvcElanService to
org.opendaylight.netvirt.elan:type=SvcElanService

Change-Id: I598004f3272f267cdd1331aef0e96cac5ac82ef7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix completely broken ElanStatusMonitor JMX MBean

including a test for future non-regression of this problem:

javax.management.NotCompliantMBeanException: MBean class
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX does
not implement DynamicMBean, and neither follows the Standard MBean
conventions (javax.management.NotCompliantMBeanException: Class
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX is not
a JMX compliant Standard MBean) nor the MXBean conventions
(javax.management.NotCompliantMBeanException:
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX: Class
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX is not
a JMX compliant MXBean)
at
com.sun.jmx.mbeanserver.Introspector.checkCompliance(Introspector.java:176)
at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:317)
at
com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
at
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX.registerMbean(ElanStatusMonitorJMX.java:30)
at
org.opendaylight.netvirt.elan.statusanddiag.ElanStatusMonitorJMX.init(ElanStatusMonitorJMX.java:24)

Change-Id: Ic269921840effd7ffae1c3c51dba88afd78999d5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Port cloud-servicechain to Blueprint

This also enables the feature.

Change-Id: Ia65d372c291fea413661b33be93e5b5731ddee71
Signed-off-by: Stephen Kitt <skitt@redhat.com>

ACL Support for IPv6 IPAM

This patch implements the following support.
1. Programs the anti-spoofing rules not to allow a VM to run an IPv6 Router.
2. Allows the necessary ICMPv6 traffic in the VM-egress pipeline.
3. Allows the necessary ICMPv6 traffic in the VM-ingress pipeline.
4. Fixes the DHCPv6 ports

Pending:
Some of the flows should be made more restrictive by taking into
consideration the MAC address of the IPv6 Router/DHCP server. This
change is required for both V4 and V6 rules and will be handled in
a separate patch.

Change-Id: I5e64d989dfa4d03ad6ce941201e32f2f2caef308
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Clean up a bunch of trival Checkstyle violations

None of these changes has any real impact on code, so please merge this
ASAP, to avoid re-re-re-base.

Change-Id: Ie83af4724b183ed94f093c80e21a81a12ed8186e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "Create VLAN trunk once for multiple VLAN networks"

More elan Blueprint clean-up

* Use static ElanUtils methods where appropriate.
* Drop ElanUtils and IInterfaceManager from
  ElanInterfaceStateChangeListener.
* Drop ElanUtils and MdsalUtils from ElanStatisticsImpl.
* Remove ElanServiceProvider.getElanUtils().

Change-Id: I00271336051cf82ba28bdc596576000ac201a51d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "allow all should be verified by null protocol"

Fixing external network group table lifecycle

Subnet changes will create and remove group tables

Change-Id: I000a295f93af5f1217cc54d5ad2cbf3b3aa3ed9a
Signed-off-by: yair <yair.zinger@hpe.com>

Bug 6449 - Issues in Service Function Forwarder translation

Change-Id: I7ca466ae65aa36c732d74a26def73bd64981b133
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

elanmanager CLI console commands impl should never catch Exception

Thank You to Checkstyle for pointing these out.  Please see
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#IllegalCatch
for background & details.

Change-Id: Ib192ff632b73552fd4b11a4641e31e5f4d9fab32
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove elanUtils instance from ElanInstanceManager

With a couple of clean-ups in ElanUtils, ElanInstanceManager can run
with only static method calls.

Change-Id: Idf73692c0109d0e38c8233653c34bbe7425fde25
Signed-off-by: Stephen Kitt <skitt@redhat.com>

code optimization for cluster environment

1. handle to execute code only from one of the cluster node.
2. handle local cache updation in all the cluster nodes.

Change-Id: Iff2b79d4e1d96cb08883650bf9c82876e803aef2
Signed-off-by: gujele <imanilyadav@gmail.com>

Create VLAN trunk once for multiple VLAN networks

Change-Id: I1d4134ddcebffaf6ded35abce41c840d28ea2a77
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Merge "Refactoring to make ElanStatusMonitor more pluggable for tests"

allow all should be verified by null protocol

Change-Id: I94720d90cba5822a75a5ca3454927303d9eaf66c
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>

Merge "wrong goto table in stateless default flows"

Refactoring to make ElanStatusMonitor more pluggable for tests

Change-Id: I541f60b55af7bcf3b3a861e872931eba3707d8a8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "elanmanager Checkstyle clean-up (94%) "

wrong goto table in stateless default flows

Change-Id: Ieebb317073dbd4511e35a084d5f79a6caabd2aad
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>

Merge "Listen to changes on subnet GW mac addresses"

Merge "Check network type before adding vtep to TZ"

Merge "add nextHopPointerPool poolId"

Listen to changes on subnet GW mac addresses

- Update ext-net flow based on MAC changes

Change-Id: Id107872a3c04d5d1a218ad87e020c1216adb6265
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Check network type before adding vtep to TZ

Change-Id: Iba7f71812e3ab9eaa69c1a8a38157fb77c1783c2
Signed-off-by: Slava <slava.radune@hpe.com>

add nextHopPointerPool poolId

Change-Id: I026df62363b2a15ad94ea806cc64bac197034479
Signed-off-by: Sam Hague <shague@redhat.com>

elanmanager Checkstyle clean-up (94%)

Enforcement on for api, but not yet for impl (coming later; let's at
least merge this already ASAP to save re-re-basing)

Change-Id: Ic727c9a9fdc8b0a10b61bfbe6a886b9f1d24ea7c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fixes Bug6423

1)The dhcp port should not have SG associated. DHCP will be created with
portsecurityenabled=true and later it will be updated. The update even
was getting ignored.
2)Updated few priority values

Change-Id: Ieb65ed02cf469aad0372fbd3e370c9043ef81682
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Merge "Fix bug wherein console commands would not work with Karaf ssh session"

Merge "netvirt-it Checkstyle clean-up (100%) and enforcement"

Merge "Fix (minor) usage of MacNotFoundException"

Merge "pom cleanup, odlparent-lite"

Merge "bug 5618 - fix creation of default rules in stateless security group mode"

pom cleanup, odlparent-lite

Change-Id: Ib277506b43241f035d1da52852c9a8f76abf40a1
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "blueprint cleanup"

Merge "MAC resolution of external GWs"

blueprint cleanup

Change-Id: I16e01a06b43c1325f4b4b0fad6e9117a73e9e0e2
Signed-off-by: Sam Hague <shague@redhat.com>

MAC resolution of external GWs

- NeutronSubnetGwMacResolver will send ARP requests periodically to GW ips
- ARP requests would also be triggered by neutron router changes

ARP responses are already handled and saved to the ARP cache by ArpNotificationHandler

Change-Id: Ib56ec1711aa8c5dd4be13c013dd64b7a59291ca6
Signed-off-by: Tali <tali.ben-meir@hpe.com>

bug 5618 - fix creation of default rules in stateless security group mode

Change-Id: I7bc8e2c52c9b783e722136840b5478e612e638f6
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>

Fix (minor) usage of MacNotFoundException

Change-Id: I0f25d30bca67d97145be3e00b719d9d71f5c8661
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix bug wherein console commands would not work with Karaf ssh session

Thank You to Checkstyle for pointing these out.  Please see
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#System.out
for background & details.

Change-Id: I042e2679a4463fc509a5d8d9cc9065454b55e2c3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

netvirt-it Checkstyle clean-up (100%) and enforcement

Change-Id: I5e40ef24063c33dd106618f75c43ab0706426271
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix vrf metadata not to override the SH bit

The original fix for this issue was deleted as part of
https://git.opendaylight.org/gerrit/#/c/43306/ (performance improvements)

Change-Id: I23ab430e7f7a7ed289c2619a88261e11259e1fef
Signed-off-by: Tali <tali.ben-meir@hpe.com>

Merge "Add config for aclservice to set security-group-mode"

Merge "change log debug level of elanutils lock print"

Merge "Fix IT default flows validation"

Add config for aclservice to set security-group-mode

1) add transparent security group
2) load default value from blueprint

To set the default for security-group-mode:
1. Change the value in aclservice/.../aclservice-config_aclservice-config.xml
2. Copy the file into the unzipped distribution before starting karaf:
cd netvirt/vpnservice
mkdir -p ./distribution/karaf/target/assembly/etc/opendaylight/datastore/initial/config; cp aclservice/impl/src/main/resources/aclservice-config_aclservice-config.xml ./distribution/karaf/target/assembly/etc/opendaylight/datastore/initial/config

Change-Id: Ic57c438499f6b529e462b57fbfcbc669c591bfc4
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>
Signed-off-by: Sam Hague <shague@redhat.com>

change log debug level of elanutils lock print

Change-Id: I14de4e470f9fc48e12ad868934217b5a124a29ea
Signed-off-by: Alon Kochba <alonko@hpe.com>

Fix ipv6service main pom.xml version.

Change-Id: I5c03fc57af0487d299512cfb6289ab5148dcc464
Signed-off-by: Alon Kochba <alonko@hpe.com>