Bug 4874 - distributed arp in old l3 for ovsdb is not installing rules when it should

Fix TenantNetworkManagerImpl::isTenantNetworkPresentInNode(), so it does not
use stale node to determine the termination points.

Patch set 2: fix UT

Change-Id: I22e1e88ca5b37f6da28b2281f01aaec07c3f751e
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Added more ITs to hwvtep

Adds following tests and required utils code:
1. testHwvtepNodeConnectDisconnect
2. testAddDeletePhysicalSwitch

Fixes issues found while writing and running ITs

Change-Id: Ia1b4bb03e228dd16c7b01dedc0ef1a4b3d3ea256
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Add Tunnel configuration

Yang changes to configure tunnels [including bfd]
Code to store tunnels information in Operational DataStore.
Code to configure tunnels

Change-Id: Ibd882c6737305af9931488e4cda394e92bcdaf91
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Added support for port range in TCP and UDP security group rules"

Added support for port range in TCP and UDP security group rules

Change-Id: I69ecc8eb52bedb641a7b2c4407b3e070ed2c1677
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Fix hwvtep.yang

BFD configuration and parameters are defined as string. This is incorrect
and makes it difficult to use BFD cofigs and params. This fix creates
them as lists of key:value pairs of type string:string.

Change-Id: I8af37e443cc04d3665ef4c70824b02d71c14b9b5
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "First netvirt renderer framework: Hardware Gateway (hwgw)"

Merge "Fix NPE in VLAN Bindings deletion"

ITs for hwvtepsouthbound

Enables IT for hwvtepsouthbound
adds hwvtepsouthboundutils to utils

Change-Id: I365604e75aa45c9a67312b2b275b4041141d75e1
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Fix NPE in VLAN Bindings deletion

Fixed NPE for multiple physical port addition.

Change-Id: I4b7324bd00dc086d843bb9f1327683dcac696e3d
Signed-off-by: karanrajsingh <karan.raj.s.singh@ericsson.com>

First netvirt renderer framework: Hardware Gateway (hwgw)

Change-Id: Ic84ba7c7fda140e1bba304541da2d7cc4c0254de
Signed-off-by: Andre Fredette <afredette@redhat.com>

Merge "Framework for netvirt model (Part 1)."

Framework for netvirt model (Part 1).

The structure planned is as follows:

/ovsdb/netvirt
/ovsdb/netvirt/api
/ovsdb/netvirt/artifacts
/ovsdb/netvirt/features
/ovsdb/netvirt/impl
/ovsdb/netvirt/karaf
/ovsdb/netvirt/it
/ovsdb/netvirt/renderers
/ovsdb/netvirt/renderers/hwgw
/ovsdb/netvirt/renderers/neutron
/ovsdb/netvirt/renderers/ovs

This patch contains the "netvirt" directory.

Change-Id: I03ba77273f6193566df63795230db7bd4e20b2e7
Signed-off-by: Andre Fredette <afredette@redhat.com>

Remove extra return statement.

When Flow id caches that were no longer needed
were removed from code, a lonely return statement
in the router interface remove code path was
left behind.

Gerrit: https://git.opendaylight.org/gerrit/#/c/29204/

Change-Id: Ic978953ab65da91baf543e21ea86333b4a9ee5ca
Reference: Ic2acced7a9a006e6e04afba6fea22aaf0620f134
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Use initFlowBuilder for SfcClassifier"

Merge "Use initFlowBuilder for SfcClassifierService"

Merge "Use initFlowBuilder for OF13Provider"

Merge "Use initFlowBuilder for IngressAclService"

Merge "Use initFlowBuilder for EgressAclService"

Merge "Use initFlowBuilder for RoutingService"

Merge "Use initFlowBuilder for OutboundNatService"

Merge "Use initFlowBuilder for LoadBalancerService"

Merge "Use initFlowBuilder for L3ForwardingService"

Merge "Use initFlowBuilder for InboundNatService"

Merge "Use initFlowBuilder for ClassifierService"

Merge "Use initFlowBuilder for ArpResponderService"

Merge "Use strict for flows"

Use initFlowBuilder for SfcClassifier

Change-Id: I06d398cac6faeaae76718e306159d0cfe6a55708
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for SfcClassifierService

Change-Id: I88349b11efa11638930f90b4bf7232d36ad3d36e
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for OF13Provider

Change-Id: I4ea3ed96bd99bc7cf1d3465513a209be76444544
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for IngressAclService

Change-Id: Iec15b1d9d368cb715a7fa1aa5aaf8dc341c2f531
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for EgressAclService

Change-Id: I96b5ba5b99421366eeebbe6a358b983fe248b2d1
Signed-off-by: Sam Hague <shague@redhat.com>

Use ${project.version} instead of ovsdb.ui.version

This aligns ovsdb-ui with the rest of the project. The definition of
ovsdb.ui.version was removed in
I0a795d81e4422a5677981a1396ac36f90e103d35 but it was still referenced
in a couple of places.

Change-Id: Icd3a70c25aaf1af3429b5dfac488ad504de16fd2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use initFlowBuilder for RoutingService

Change-Id: Ib740544ddbbb08745aa7f21aa9246acad1ad1d53
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for OutboundNatService

Change-Id: I3babd5e2f159045da89f510a2e876f5787bc7769
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for LoadBalancerService

Change-Id: I913f235658def11a76cb58ab0b173d2ba272b313
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for L3ForwardingService

Change-Id: Ibc4b611c30e21e63ad3b3412712b0e787faaeda4
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for InboundNatService

Change-Id: I0df8314aa718256d543d435bdba63a405d61f031
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for ClassifierService

Change-Id: Ibd15c9c351e218a6e6637e3b494bbd1d9269d74d
Signed-off-by: Sam Hague <shague@redhat.com>

Use initFlowBuilder for ArpResponderService

Change-Id: Iede2080f6870eab1e16311020d9db664ff79cc92
Signed-off-by: Sam Hague <shague@redhat.com>

Use strict for flows

Change-Id: I8ec483eccc617717fa0a9f42cf3adaed9b51d18e
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "setTunnel in PhysicalSwitchUpdateCommand"

Merge "Change logical-switch-ref to iid in hwvtep.yang"

Merge "Remove Macs by Listening on ConfigDS"

Merge "Close the OVSDB connection after the last test"

Add controller target to log output for NetvirtIT

Change-Id: I9646c16e05cc90050ef0efaff398b192efb367e6
Signed-off-by: Sam Hague <shague@redhat.com>

setTunnel in PhysicalSwitchUpdateCommand

Added code for updating tunnels on physical switch.
Removed redundant methods.

Change-Id: Iea1562a2816458ff4d91bffe681dd272aa874568
Signed-off-by: karanrajsingh <karan.raj.s.singh@ericsson.com>

Change logical-switch-ref to iid in hwvtep.yang

Change the type of logical-switch-ref from string to instance-identifier in hwvtep.yang

PatchSet 2:
1. fix logical-switch-ref in postman collection

Change-Id: I67fc5f80ac0fea88ed3f6ac7eaeeee9e63f0da92
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Remove Macs by Listening on ConfigDS

PatchSet 2:
1. fix "unknown-dst" exception
2. add local McastMacs remove command

PatchSet 3:
1. add UcastMacs remove command

Change-Id: Ia79cdbc3ea89991b71b6e77a322a3c8539f3de33
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "Bug 4789 - allowed address pair doesn't have port id"

Close the OVSDB connection after the last test

Change-Id: Iba99e08bde33fbb72e9387f0ae70a991f64699be
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Cleanup NetvirtIT

Removed methods that were added to SouthboundUtils.
Moved the Neutron IAware methods to their own class.
Remove the controller methods and used those defined in BridgeConfigurationManager.

Change-Id: I573d698805888e0dcefe1dddfbd47df5dc8828cf
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Remove Physical Switch by Listening on DS"

Merge "Fix Physical Switch Update Command"

Merge "Remove Physical Port by Listening on ConfigDS"

Merge "ManagerUpdate/Remove Command"

Remove Physical Switch by Listening on DS

PatchSet 2:
1. add mutation to Global table
2. remove a unused import

PatchSet 3:
1. fix typos in postman collection

Change-Id: I7a13208f16feb0a0f3af7a09f2a3a263dcc1f9cf
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Fix Physical Switch Update Command

Change-Id: Ibcb66f43bead8b381f8f6ad98050401c2e8b5de1
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

southbound should only monitor Open_vSwitch tables

The patch also adds more clear logging to indicate connection events and indicate which direction the events happened.

Patch Set 4: Review comments. Remove the filter since it doesn't make sense because the caller is asking explictly for the table to monitor.
Patch Set 2, 3: fix unit tests and update commit message

Change-Id: I4ea511906911bf9296e78f57f1b63dc2608c9501
Signed-off-by: Sam Hague <shague@redhat.com>

ManagerUpdate/Remove Command

Manager Update and Remove Commands done.Updated as per the comments.
Redundant HwvtepTunnelUpdateCommand.java removed.Tunnel updates would be
handled as a part of PhysicalSwitchUpdate.
Updated as per comment for Patchset4 and Patschset6.
VlanBindings deletion updated in PhysicalPortUpdateCommand.
Updated for comments in Patchset7

Change-Id: I081935a1adbe237e14efb16a0e694e8f912ab617
Signed-off-by: karanrajsingh <karan.raj.s.singh@ericsson.com>

Bug 4789 - allowed address pair doesn't have port id

So getPortId, setPortId methods aren't defined.
This is the ovsdb part of Bug 4789.

Change-Id: Id9ad4762b5ed92c5b84e6fab1d7c5135782ca528
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Remove Physical Port by Listening on ConfigDS

PatchSet 2:
change according to review comments

Change-Id: I47436608877bfd05985263a6f27837662635bb4a
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Bug 4776 - handle cases when network/subnet contains no tentant id

When ODL is used with l3 agent and l3_ha subnet/network for handling
keep alive traffic contains no tenant id. Added missing checks that
handle these cases gracefully.

Change-Id: Ia9e2e963bc0d2df6d7a08b493c1f9bbcbae5659f
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Bug 4579 - Periodic ARP resolver is missing callback for MAC updates"

Merge "Require min ovs version for SG IT"

Require min ovs version for SG IT

Change-Id: I535fcfc5b29a3ddadfd22a7461d252e0899ddcfe
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Remove ovs-sfc bundle"

Merge "Remove commons/parent bundle"

Remove ovs-sfc bundle

Change-Id: I6108515d7cc1738b6fc68f0f9ea7546a21637bc5
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Remove commons/parent bundle

- Reformat aggregator so they use odlparent and don't deploy themselves as they are used only for build purposes

Change-Id: Ia70c0bff4327d376a985c263569aebbc37cfec32
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Bug 4579 - Periodic ARP resolver is missing callback for MAC updates

Patch set 2: fix formatting

Change-Id: I21523c0c6e06c21f4dbf5b914f5dec625a40ab83
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Also-By: Andre Fredette <afredette@redhat.com>

Merge "Attempt to fix report in sonar for test coverage"

Attempt to fix report in sonar for test coverage

Current coverage reported for this class is 1.1%

Change-Id: I41a2498dff15dbb1d474040abd667dfddb33a149
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Clean up ovsdb feature

- Remove ovs-sfc feature
- Move feature-ovsdb under /features
- clean-up feature-ovsdb
- unify version number by using project.version everywhere in the project

Change-Id: I0a795d81e4422a5677981a1396ac36f90e103d35
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Bug 4752 - Distributed arp only needed on compute nodes that have tenant net

Missing logic to avoid adding unnecessary rules for distributed arp in
compute nodes that did not have any tenant vms for a particular
segmentation id

Patch set 2: Fix UT

Change-Id: Ib9183be4bdc6a23e0b748acfff13992e6a36c684
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Fold netvirtsfc-env demo into ovsdb project"

Merge "Drop dependencies on netty-all"

Fold netvirtsfc-env demo into ovsdb project

Keeping the ovsdb netvirt-sfc demo together with the ovsdb project itself.

Original location: https://github.com/flavio-fernandes/netvirtsfc-env

Change-Id: I747694a9860433c4d4deab06aed537ecba1a96f5
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Remove Logical Switch by Listening on ConfigDS"

Merge "Fix Port UUID in hwvtep.yang"

Merge "Fix "unknown-dst" Exception"

Drop dependencies on netty-all

Use specific dependencies instead; this also allows ovsdb to depend on
the upstream versions provided by odlparent.

Change-Id: Ice5b76300e08a6985dff9ad10c6ad92476315c7e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove Logical Switch by Listening on ConfigDS

PatchSet 2:
1. change according to review comments

Change-Id: Ia40effbf63a66db94a733d2017009abf18627e79
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Avoid producing controller artifacts

Specify the groupId for artifacts inheriting from
org.opendaylight.controller:config-parent to avoid producing
controller artifacts.

Change-Id: Ic1f8ccbbcc109f9e538d01c6494c33d020b5fe9d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix Port UUID in hwvtep.yang

'leaf physical-port-uuid' was within 'list vlan-bindings'. It should not be there
since uuid is an attribute of Port.

Change-Id: I01e1794cdb39b1f93f559df295d38c950dcd2160
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Fix "unknown-dst" Exception

Since the type of mac-entry-key is yang:mac and does not accept "unknown-dst",
use "00:00:00:00:00:00" instead of "unknown-dst".

PatchSet 2:
1. change according review comments
2. delete unused "locator-set-ref" in hwvtep.yang

PatchSet 3:
1. rebase on "Cleanup on Hwvtepsouthbound"

Change-Id: I46258fc749bc0df5608010c0fb76e4c3319dc74f
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "Clean up pom files"

Merge "Clean up hwvtepsouthbound"

Clean up pom files

Change-Id: Ifdb9c2bf63249f90b8813cd5fbe67bc80cd772e9
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Make utils bundles use config-parent

Instead of using either common or binding-parent use config-parent

Change-Id: I61ab66a511e9c3a372f7bacbd3f053864d048d16
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Merge "Bug 4735 - null pointer exception in SouthboundImpl"

Merge "Bug 4734 - netvirt/GatewayMacResolverService: null pinter exception"

Merge "Bug 4733 - impl/SecurityServicesImpl.java: null pointer exception"

Merge "Bug 4736 - Add null poiner check of getFixedIPs()"

Drop duplicate classes

Use a single copy of MdsalUtils, SouthboundUtils, SouthboundConstants
and SouthboundMapper.

Minor clean-ups.

Check the operational ingress flow at the end of testDefaultsSG().

Change-Id: Ib8713f6ad0e8f5eec1693ef36ebf6095fd43ce09
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Clean up hwvtepsouthbound

General code clean-up:
* use optimal operations on maps: iterate over values if only values
  are needed; avoid double gets; use entry sets if both keys and
  values are needed;
* use the single-parameter variant of firstKeyOf();
* drop unused methods, fields and imports;
* limit variable scope;
* use Java 7 <> operator;
* since TyperUtils.extractRows...() never returns null, remove all
  such null-checks and rely on the for loops to check for emptiness.

Change-Id: Id9e4643a46a96d819146b04a146c2ac00c88509d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

test code to debug it getFlow errors 2

Change-Id: I0086ddb3f846893c7c48cb24ebf1eaff21a4e5f9
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Adding integration tests for Security Groups (fixed and default SG)"

Merge "Use SouthboundUtils in SouthboundIT"

Merge "Extract neutron-utils from mdsal-utils"