Jozef Bacigal [Tue, 5 Sep 2017 09:27:57 +0000 (11:27 +0200)]
Fix transaction manager closing.
- the event onTransactionFailed we properly closing chain and creating
a new chain
- changed writeOnlyTransaction to readWriteTransaction
- moved transaction manager to the common module
- topology manager using transaction manager instead of creating a
transaction chain for itself
- added control of unfinished transaction on close
See also: Bug-9038
Change-Id: Idadbb4ed0f4c61e7f80da5e2dbedbd80dece118e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 19 Sep 2017 07:40:13 +0000 (07:40 +0000)]
Merge "Terminate SLAVE task before sending role change"
Tomas Slusny [Tue, 19 Sep 2017 07:19:16 +0000 (07:19 +0000)]
Merge "Fix NPE, version 1.0 returns null on auxiliary id."
Jozef Bacigal [Mon, 18 Sep 2017 07:43:46 +0000 (09:43 +0200)]
Fix NPE, version 1.0 returns null on auxiliary id.
Change-Id: Id2bce3ec8c03e73d1fcb20a4bde099d5c2a0224d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 14 Sep 2017 07:16:05 +0000 (09:16 +0200)]
Terminate SLAVE task before sending role change
- Terminate SLAVE task in role context when role change is requested and
not after role change is finished.
- Do not send notification about role failed to set to mastership
service in case future was cancelled
See also: bug 9089
Change-Id: Ia784d3b682b8991fe7a471bbfc7462aebfa6d4ef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
David Suarez [Thu, 14 Sep 2017 15:44:20 +0000 (17:44 +0200)]
Fix issues related to checkstyle enforcement
Change-Id: I3d96af4e9d5f72921767e2aa06d9daffc20ef26d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Tomas Slusny [Fri, 8 Sep 2017 09:07:11 +0000 (11:07 +0200)]
Move used code from openflowplugin to impl
Move used code that was used only in openflowplugin-impl from
openflowplugin (old Helium design)
See also: bug 8653
Change-Id: I5a425db395601f49625f598057d835ca7a471ac9
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Fri, 8 Sep 2017 10:20:27 +0000 (10:20 +0000)]
Merge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 10:19:57 +0000 (10:19 +0000)]
Merge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 10:18:24 +0000 (10:18 +0000)]
Merge "Fix codestyle"
Jozef Bacigal [Fri, 8 Sep 2017 08:35:39 +0000 (10:35 +0200)]
Fix codestyle
- Removed deprecated getLOGValue from deviceInfo
See also:Bug-8607
Change-Id: Ic9c11ea6e2ace4e802ddc8dd3e2445655e2a57fd
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 8 Sep 2017 07:23:23 +0000 (09:23 +0200)]
Fix codestyle
- Anonymous type replaced by lambda
See also:Bug-8607
Change-Id: I7134315329b860d698927c6eb2c7f94a9476afde
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 8 Sep 2017 06:42:56 +0000 (08:42 +0200)]
Fix codestyle
- Removed unused import
See also:Bug-8607
Change-Id: Ie5f9e2449bcb072ff0a1a65857e3b371a1722dcd
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 8 Sep 2017 08:43:03 +0000 (08:43 +0000)]
Merge "Remove dependency of impl on onf-extensions"
Jozef Bacigal [Fri, 8 Sep 2017 08:42:57 +0000 (08:42 +0000)]
Merge "Add missing bundle converters"
Tomas Slusny [Fri, 8 Sep 2017 08:39:30 +0000 (08:39 +0000)]
Merge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 08:39:20 +0000 (08:39 +0000)]
Merge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 08:22:35 +0000 (08:22 +0000)]
Merge "Cleanup"
Jozef Bacigal [Fri, 8 Sep 2017 07:35:22 +0000 (07:35 +0000)]
Merge "Move match converter to new converter system"
Jozef Bacigal [Fri, 8 Sep 2017 06:39:50 +0000 (08:39 +0200)]
Fix codestyle
- Optional.isPresent replacesd to functional expression
See also:Bug-8607
Change-Id: Ib9a81b66751db08f93b12232f83da549cf9f2c1b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 8 Sep 2017 06:34:37 +0000 (08:34 +0200)]
Fix codestyle
- Arrays.asList() memory save
See also:Bug-8607
Change-Id: I697affb49632c279175488ad35a2fe2111ddc234
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
David Suarez [Sun, 3 Sep 2017 09:22:52 +0000 (11:22 +0200)]
Cleanup
- Remove dead code
- Join if statements
- Private methods called from inner classes should be moved to those
classes
Change-Id: If66b8291e4b9cb237ebc88d1ce362e0aeb32d393
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Jozef Bacigal [Thu, 7 Sep 2017 11:13:30 +0000 (13:13 +0200)]
Fix codestyle
- explicit type
See also:Bug-8607
Change-Id: I5078f0b423942fdec385e9043d5a719cbffb9a6d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 7 Sep 2017 11:11:40 +0000 (13:11 +0200)]
Fix codestyle
- unnecessary boxing removed
See also:Bug-8607
Change-Id: Ia37138f17e4831d38611571b37e74553f06e93af
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 7 Sep 2017 11:00:12 +0000 (13:00 +0200)]
Move match converter to new converter system
In preparation of removal of Helium design, remove MatchReactor and move
MatchConvertor to new converter manager based system.
See also: bug 8653
Change-Id: I14db62975cd16d07f3fd7a39e36fc38bacb8abf8
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 6 Sep 2017 15:04:56 +0000 (17:04 +0200)]
Remove dependency of impl on onf-extensions
As preparation for removal of helium design:
- Remove dependency of openflowplugin-impl on onf-extensions and move
SalBundleService to openflowplugin-impl, as it is registered and used
only there
- Move onf extension yang models to extension-api
See also: bug 8653
Change-Id: Ib5813b5e7a115f1918d27ea116d7d49b4605799d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 6 Sep 2017 15:03:47 +0000 (17:03 +0200)]
Add missing bundle converters
Add missing bundle converters about what was device context throwing
warnings.
Change-Id: Ic3d89c386c32f06d80afe1221f2d30fd919d087d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Wed, 6 Sep 2017 14:43:31 +0000 (16:43 +0200)]
Fix possible NPE on ContextChainHolderImpl
- deviceConnected method
Change-Id: I7cbd8c3bb2a4d92ecdaa5fc541e01e3d8ac738b6
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 5 Sep 2017 08:04:56 +0000 (10:04 +0200)]
Do not mark device as connecting when closing it
Do not put incoming device connection to connectingDevices map when it
is still in closing state, to prevent having stale entry in
connectingDevices map.
Resolves: bug 9088
Change-Id: Ibee87152cd791f639999097c07a737c64afda990
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 2 Aug 2017 07:48:37 +0000 (09:48 +0200)]
Redesign statistics context and manager
- To simplify statistics context and statistics manager code,
have better control over statistics polling and to remove
referencing of statistics manager from statistics context,
remove current method of statistics scheduling and replace
it with Guava scheduled service that will handle starting,
periodic gathering and stopping of statistics.
- Simplify chain of steps that continues with statistics initialization
with reconciliation framework enabled
See also: bug 8913
Change-Id: I0f3dcdd5292c6c7180ea80afc6d4d3df16b05ff9
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Anil Vishnoi [Sun, 3 Sep 2017 08:11:07 +0000 (08:11 +0000)]
Merge "BUG8607 Fix checkstyle issues"
David Suarez [Sat, 2 Sep 2017 17:04:02 +0000 (19:04 +0200)]
BUG8607 Fix checkstyle issues
- Formatting
- JavaDoc
- Line lengths
- Name of variables
- Exception catching
- Remove redundant modifiers
- Add default case to switch
- Move variables closer to their
- Enforcement in pom.xml
Change-Id: If17fcdc00e8d22818a5501027a6bb7db3f2dcba3
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
David Suarez [Fri, 1 Sep 2017 08:45:32 +0000 (10:45 +0200)]
Enforce checkstyle
Enforce checkstyle by changing severity to error.
Change-Id: I4a6ae191bfec6df72e17f1c8ca50e92a9fd68ba5
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Tomas Slusny [Wed, 30 Aug 2017 07:25:38 +0000 (07:25 +0000)]
Merge "Remove CSS artifact remnants"
Anil Vishnoi [Fri, 25 Aug 2017 22:43:24 +0000 (22:43 +0000)]
Merge "Fix checkstyle warnings for impl/protocol test package"
Anil Vishnoi [Fri, 25 Aug 2017 22:42:13 +0000 (22:42 +0000)]
Merge "Fix checkstyle warnings for impl/karaf, lifecycle, common, mastership"
Anil Vishnoi [Fri, 25 Aug 2017 22:30:55 +0000 (22:30 +0000)]
Merge "Fix checkstyle warnings for impl/device package"
Anil Vishnoi [Fri, 25 Aug 2017 22:30:20 +0000 (22:30 +0000)]
Merge "Fix checkstyle warnings for impl/datastore package"
Anil Vishnoi [Fri, 25 Aug 2017 22:24:14 +0000 (22:24 +0000)]
Merge "Fix checkstyle warnings for impl/protocol package"
Tom Pantelis [Fri, 25 Aug 2017 18:46:27 +0000 (14:46 -0400)]
Remove CSS artifact remnants
The project has already been converted to blueprint (except for test-extension)
so removed he remaining CSS remnants (eg use of config-parent, JMXGenerator).
Change-Id: I38c3e16ece82e2f5deada17a3faafa180e11a210
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
miroslav.macko [Fri, 25 Aug 2017 12:46:50 +0000 (14:46 +0200)]
Fix checkstyle warnings for impl/datastore package
See also: bug 8607
Change-Id: I7701b8b611648a3c7af90686847ecefd1970bf8a
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Fri, 25 Aug 2017 11:40:29 +0000 (13:40 +0200)]
Fix checkstyle warnings for impl/device package
See also: bug 8607
Change-Id: I3f29d2ea40989877995b34211ac3e2f3aee5f637
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Thu, 24 Aug 2017 15:32:14 +0000 (17:32 +0200)]
Fix checkstyle warnings for impl/karaf, lifecycle, common, mastership
See also: bug 8607
Change-Id: I8fc6a4677ec53df886877c62c5a98d624c01022f
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Thu, 24 Aug 2017 13:22:41 +0000 (15:22 +0200)]
Fix checkstyle warnings for impl/protocol test package
See also: bug 8607
Change-Id: Icd8914faf38d0d6493dbe633b93cd2442e0bdfd4
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Tomas Slusny [Thu, 24 Aug 2017 15:40:19 +0000 (15:40 +0000)]
Merge "Fix checkstyle warnings for impl/role package"
miroslav.macko [Wed, 23 Aug 2017 14:59:42 +0000 (16:59 +0200)]
Fix checkstyle warnings for impl/protocol package
See also: bug 8607
Change-Id: I2adea22e939e8cf9bc87505ca4e130c73fc93a0f
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Thu, 24 Aug 2017 07:33:03 +0000 (09:33 +0200)]
Remove unsupported statistics warning
Remove warning for unsupported statistics type when deleting all groups,
flows and meters since it is unwanted.
See also: bug 8607
Change-Id: Ib91383a66306bebba3da9dff88bcb38664ec5860
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Wed, 23 Aug 2017 08:59:20 +0000 (10:59 +0200)]
Fix checkstyle warnings for impl/role package
See also: bug 8607
Change-Id: Ia72af7d846cd1a6e900b36821ef62703db4ebc1d
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Jozef Bacigal [Tue, 8 Aug 2017 08:22:07 +0000 (10:22 +0200)]
Solves issue with two connections from one device.
See also:Bug 8723
Change-Id: I1e07eb590f285f9d6c1326b94ef5b159242c0757
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
miroslav.macko [Mon, 21 Aug 2017 14:57:30 +0000 (16:57 +0200)]
Fix checkstyle warnings for rpc package
See also: bug 8607
Change-Id: I2ad3e70aac83509f8af49369004633befba73df7
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Mon, 21 Aug 2017 12:01:07 +0000 (14:01 +0200)]
Fix checkstyle warnings for services package
See also: bug 8607
Change-Id: I1f97d8faed46209423f95170af2413e0fb4beb07
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Wed, 16 Aug 2017 13:49:07 +0000 (15:49 +0200)]
Fix checkstyle warnings for statistics package
See also: bug 8607
Change-Id: I45875a328dbfb078701ff1c6684c7c28a97a7634
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Wed, 16 Aug 2017 11:58:47 +0000 (13:58 +0200)]
Fix checkstyle warnings for translator and registry package
See also: bug 8607
Change-Id: I793e00ae546e745cb42c0917494c7896f3b95719
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Tue, 15 Aug 2017 14:25:26 +0000 (16:25 +0200)]
Fix checkstyle warnings for util package
See also: bug 8607
Change-Id: I3bd3b473ebb673b6883def0503cf8d3b3a8a6d10
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Tomas Slusny [Tue, 22 Aug 2017 07:27:02 +0000 (07:27 +0000)]
Merge "Remove deprecated bootstrap channel options"
Jozef Bacigal [Tue, 22 Aug 2017 05:09:11 +0000 (07:09 +0200)]
Remove deprecated bootstrap channel options
- LOW and HIGH WATERMARK are deprecated
Bug: 8607
Change-Id: I6735aed51882361bc69d665f99b008e1d11f9030
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Wed, 2 Aug 2017 11:15:42 +0000 (13:15 +0200)]
Add RoleManager and RoleContext
- Move sending of MASTER and SLAVE role from DeviceContext
and ContextChainHolder to new RoleContext and RoleManager
- Use hashed wheel timer for setting SLAVE role on device in
case MASTER role was not propagated instead of ItemScheduler
- Remove retries from SalRoleService
See also: bug 8913
Change-Id: I808efef843ed936035fbf7759ae22d8976c80ca7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Fri, 28 Jul 2017 13:35:33 +0000 (15:35 +0200)]
Guard lifecycle of contexts
- Add GuardedContext wrapper for OFPContext that will guard each
phase of context lifecycle (new instance, instantiateServiceInstance,
closeServiceInstance, close)
Resolves: bug 8913
Change-Id: I6c054575c9f93f03e45dcc23feefa0e7dae6fa88
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 21 Aug 2017 11:14:46 +0000 (11:14 +0000)]
Merge "Update ONF tests"
Jozef Bacigal [Wed, 9 Aug 2017 16:15:18 +0000 (18:15 +0200)]
Update ONF tests
- previously ingored tests fix
Change-Id: I70c4d2264635d1282391a7151c43ad802e0acb2c
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 21 Aug 2017 08:57:46 +0000 (10:57 +0200)]
Fix checkstyle impl/common and impl/configuration
Change-Id: I88b6af868552053cbaa3e01cec19df09db472979
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 21 Aug 2017 07:17:27 +0000 (09:17 +0200)]
Fix chectyle warning.
Change-Id: Ie3e95d406edb98a77e0656ffaa8540231509e4f1
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Mon, 21 Aug 2017 06:47:47 +0000 (06:47 +0000)]
Merge "Fix checkstyle"
Tomas Slusny [Mon, 21 Aug 2017 06:46:21 +0000 (06:46 +0000)]
Merge "Remove deprecated CheckedFuture."
Jozef Bacigal [Mon, 21 Aug 2017 06:45:44 +0000 (06:45 +0000)]
Merge "Move extension implementation from API to impl"
Jozef Bacigal [Tue, 15 Aug 2017 06:58:07 +0000 (08:58 +0200)]
Fix checkstyle
- on openflowplugin.api
- set default checkstyle to error instead of warning to prevent new checstyle violations
Change-Id: I0e539639b95d9f2d417aa10a576419211f110083
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 14 Aug 2017 07:53:08 +0000 (09:53 +0200)]
Remove deprecated CheckedFuture.
Change-Id: Ica92197df035bffc032e27e0805816a1a8e264a8
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
gobinath [Tue, 11 Jul 2017 10:24:22 +0000 (15:54 +0530)]
Bug 8902 - Changes in FRM for Reconciliation Framework
Change-Id: Id063eb8be61396113d0b10fabb43f0d64d02f6a8
Signed-off-by: gobinath <gobinath@ericsson.com>
Jozef Bacigal [Thu, 17 Aug 2017 13:05:10 +0000 (13:05 +0000)]
Merge "Bump reconciliation"
Robert Varga [Thu, 17 Aug 2017 11:03:55 +0000 (13:03 +0200)]
Fix version reference
This component has not been adjusted to reflect version bump,
fix that.
Change-Id: I9702ef9dbc9b56faf9ef43d6ad7565da1bbaf0f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Gobinath [Thu, 17 Aug 2017 09:30:42 +0000 (15:00 +0530)]
Bump reconciliation
Change-Id: Ic35a2543fbb3864134bd11860ef7d889f47882e2
Signed-off-by: Gobinath <gobinath@ericsson.com>
Prasanna Huddar [Thu, 17 Aug 2017 06:08:44 +0000 (06:08 +0000)]
Merge "Bug 8902 - Reconciliation Framework changes"
Tomas Slusny [Thu, 10 Aug 2017 10:47:51 +0000 (12:47 +0200)]
Move extension implementation from API to impl
Currently, some parts of openflowjava extension implementation is
located in API and not in implementation project as it should be, so
move this code from api to implementation.
Change-Id: I85b6f75f4c6bc23bf1944061bcfec339f189cb1e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Thanh Ha [Mon, 14 Aug 2017 17:35:49 +0000 (13:35 -0400)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I6d7ff6cf68d043fc4dc2cfc4a26f59fda21818fa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Tomas Slusny [Fri, 11 Aug 2017 00:16:34 +0000 (00:16 +0000)]
Merge "Bump odlparent 2.0.2 to 2.0.4"
Stephen Kitt [Tue, 8 Aug 2017 16:14:14 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4
Change-Id: I168975753b4ea7728eb361f7ef7803fbb970f64b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Jozef Bacigal [Wed, 9 Aug 2017 09:00:10 +0000 (09:00 +0000)]
Merge "Update unit tests pt2"
Jozef Bacigal [Wed, 9 Aug 2017 09:00:00 +0000 (09:00 +0000)]
Merge "Update unit tests"
Tomas Slusny [Tue, 8 Aug 2017 10:48:42 +0000 (12:48 +0200)]
Remove unused code from He design
See also: bug 8656
Change-Id: Ib1657f519587e6ec463bf1f2af2e50ccd3b727e5
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 7 Aug 2017 10:17:03 +0000 (12:17 +0200)]
Update unit tests pt2
- Add unit tests for single layer sal services
- Add some missing unit tests for device context
- Add unit test for mastership service delegate
- Fix sal table service for single layer
See also: bug 8607
Change-Id: I4f850ee83f82d98e1b66ac467ca08a1b963de3c1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 24 Jul 2017 15:44:48 +0000 (17:44 +0200)]
Update unit tests
Add unit tests for:
- Arp target transport address serializer
- Packet in message deserializer
- All serializers for multipart request messages
- All serializers for table feature properties and match fields in table
features
- Configuration service and OpenFlowProviderConfigImpl
- Device initializers (OF10 and OF13)
- Single-layer direct statistics
- Request context and input utils
Remove custom comparators for sorting of actions and instructions and
use OrderComparator.build() instead. Also, add missing sorting of table
feature instructions and actions properties.
See also: bug 8607
Change-Id: I83e0ad9a3469c80f4fa45df4de78c1e0fd53954b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Gobinath [Mon, 10 Jul 2017 09:15:25 +0000 (14:45 +0530)]
Bug 8902 - Reconciliation Framework changes
Changes related to the Reconciliation Framework are done in this patch.
The APIs needed to be implemented by the services registering to the
Reconciliation framework are present in the interface
ReconciliationNotificationListener.The APIs to register the service to
Reconciliation framework and the APIs to start the reconciliation /
cancellation of the ongoing reconciliation of a node are present in
ReconciliationManager.
Change-Id: I8bd1845db8b86f4a4314977e05c6b699592f5658
Signed-off-by: gobinath <gobinath@ericsson.com>
Tomas Slusny [Mon, 7 Aug 2017 07:14:16 +0000 (07:14 +0000)]
Merge "Bug 8873 - Bundle based reconciliation to enable bundling of messages"
eeiillu [Tue, 18 Jul 2017 05:13:00 +0000 (10:43 +0530)]
Bug 8873 - Bundle based reconciliation to enable bundling of messages
Change-Id: Ida09badca9a16619fec6e6f293042956ce8ec4e4
Signed-off-by: eeiillu <suja.t@ericsson.com>
Tomas Slusny [Thu, 3 Aug 2017 05:52:20 +0000 (05:52 +0000)]
Merge "Bug 8882 - With conntrack SNAT communication with PNF fails "
Jozef Bacigal [Tue, 1 Aug 2017 10:50:56 +0000 (12:50 +0200)]
Change return type of events
- remove callback from onDevicePrepared
- added ListenableFuture as return type for events
- added many tests
- small fixes found on test run
Change-Id: Id18bd669589e11a8526bdb77d70ef73df737039c
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 31 Jul 2017 12:01:05 +0000 (14:01 +0200)]
Reconciliation framework binding point improvements
- added tests for mastership service manager
- removed factory managed instantiated direct thought blueprint service
- reconciliation framework returns registration, can be closed directly
- hide explicit unregister method from manager to prevent confuse the consumer
- exception thrown after second reconciliation framework try to register
- reconciliation framework doesn't need register mastership service for disconnect
- added new event for device disconnect into reconciliation framework events
Change-Id: I19f7fdd528e453388f69c34e3669488d4d52644b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 1 Aug 2017 19:11:06 +0000 (19:11 +0000)]
Merge "Remove logback related stuff"
Jozef Bacigal [Tue, 1 Aug 2017 10:15:55 +0000 (10:15 +0000)]
Merge "Lower logging level of FRM reconciliation process"
Tomas Slusny [Tue, 1 Aug 2017 07:31:12 +0000 (09:31 +0200)]
Lower logging level of FRM reconciliation process
Change most of logging to match logging of OpenFlowPlugin sal services
(add and deletion and failures are logged on debug levels) to remove
unnecessary clutter from logs.
Change-Id: I6ae82c8a5125cf2ef35f4b2039f5d31d3f341948
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 31 Jul 2017 15:03:59 +0000 (17:03 +0200)]
Remove missing inPort in PacketIn error
Make new PacketIn message handler behave like old one, and that is that
when there was no inPort, we just set null ingress for packet in
notification.
See also: bug 8772
Change-Id: Ia108f4c732c32a5ebfc22d50c0c63bb93bde71e4
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Aswin Suryanarayanan [Fri, 28 Jul 2017 12:13:40 +0000 (17:43 +0530)]
Bug 8882 - With conntrack SNAT communication with PNF fails
Added support for load metadata action.
Change-Id: Ia1b0454a4aeccd9a04cecb59b50f516264bddb3e
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Fri, 28 Jul 2017 06:41:31 +0000 (12:11 +0530)]
Remove logback related stuff
as discussed on https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001262.html
openflowplugin-it appears to be completely broken anyway, and is not in build
Change-Id: Ic52d5d38754f2692415788d364969d42eadff1e0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tomas Slusny [Thu, 27 Jul 2017 10:35:31 +0000 (10:35 +0000)]
Merge "Remove config knob for reconciliation framework"
Jozef Bacigal [Tue, 25 Jul 2017 10:47:51 +0000 (12:47 +0200)]
Remove config knob for reconciliation framework
Change-Id: I601a28bd55006f5ae74399794a4fd756fb2bc3f0
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Mon, 24 Jul 2017 15:49:45 +0000 (17:49 +0200)]
Close CSS registration in separate thread
Instead of sending initialization of CSS in separate thread,
do closing of registration in separate thread and only in case
we are closing the registration during initialization, to prevent
CSS freezes. Also, when closing CSS service, add checks for connection
state to prevent closing context when connection is already RIP.
See also: bug 8805
Change-Id: I0759f7913937c897f41899a87b699989cdfe4abc
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Fri, 21 Jul 2017 11:40:25 +0000 (13:40 +0200)]
Exctract onDevicePrepared to interface
- In the previous implementation the client was able to register
many of reconciliation frameworks as a mastership service.
This may lead to broken code where each registration of
mastership service could implement own onDevicePrepared.
- Issue with configuration parameter isUsingReconciliationFramework
solved by putting this status into statistics context constructor.
- Removed depricated deviceInfo.getLOGvalue from statistics.
Change-Id: I3691a3cf5eb755671f756815dd99ac2d637f1298
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 11 Jul 2017 07:57:23 +0000 (09:57 +0200)]
Extract mastership blueprint service
Change-Id: I87180a1705c25cb51e9d71e1083e48cd4e52683c
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 11 Jul 2017 07:26:44 +0000 (09:26 +0200)]
Mastershipchange service implementation.
Change-Id: I9ca11e05100a2369ae4a91f1232b4f14435a11f6
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 10 Jul 2017 08:42:25 +0000 (10:42 +0200)]
Mastership service provider API
- create new API for mastership listener
- rename MastershipChangeListener to ContextChainMastershipWatcher
Change-Id: I45e919494039180df895602b6536af37f679cb58
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Code Review / openflowplugin.git / log