Thanh Ha [Sun, 9 Aug 2015 22:35:10 +0000 (18:35 -0400)]
Fix license header violations in test-common
Change-Id: Iabc6631a52d28502a392bd894b74bb0e48a5f2cc
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Aug 2015 22:32:00 +0000 (18:32 -0400)]
Fix license header violations in applications
Change-Id: I3cdee24a89daaa84c8016d084ce5fd6820d8e1bf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Aug 2015 22:22:01 +0000 (18:22 -0400)]
Fix license header violations in extensions/openflowplugin
Change-Id: I207ce541e33b4686ffbc70b637684ac6c0f0b784
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Aug 2015 22:15:27 +0000 (18:15 -0400)]
Fix license header violations in extensions/openflowjava
Change-Id: I5a98e7a825b6f0dadaf69b7a3aed4c247de08e7a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Aug 2015 22:06:40 +0000 (18:06 -0400)]
Fix license header violations in openflowplugin-impl
Change-Id: I78583a6850bec6e2d4231469951bce773b02ab4b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Aug 2015 22:03:27 +0000 (18:03 -0400)]
Fix license header violations in openflowplugin
Change-Id: I875803a56f7d9841bffc7acc9a06c488e0bfa010
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Aug 2015 21:54:18 +0000 (17:54 -0400)]
Fix license header violations in openflowplugin-api
Change-Id: If831f8a9c155c9f5fc362ed1d04c663556249adf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Abhijit Kumbhare [Thu, 6 Aug 2015 18:49:53 +0000 (18:49 +0000)]
Merge "Coverage - karaf commands - ResetSessionStat"
Abhijit Kumbhare [Thu, 6 Aug 2015 18:48:38 +0000 (18:48 +0000)]
Merge "BUG-4065: Karaf command ResetSessionStats resets wrong counter"
Abhijit Kumbhare [Wed, 5 Aug 2015 13:58:37 +0000 (13:58 +0000)]
Merge "Coverage - karaf commands - ofp/impl/karaf"
Abhijit Kumbhare [Tue, 4 Aug 2015 16:22:41 +0000 (16:22 +0000)]
Merge "Coverage - rpc manager and context"
Abhijit Kumbhare [Tue, 4 Aug 2015 16:09:18 +0000 (16:09 +0000)]
Merge "BUG-4068: RpcContextImpl doesn't close rpcRegistrations correctly"
Abhijit Kumbhare [Tue, 4 Aug 2015 15:59:03 +0000 (15:59 +0000)]
Merge topic 'UnitTestCoverage'
* changes:
Coverage - common package
Added OFPM_ALL constant
michal rehak [Fri, 31 Jul 2015 16:15:00 +0000 (16:15 +0000)]
Merge "Coverage - AbstractRequestCallback."
michal rehak [Fri, 31 Jul 2015 13:08:07 +0000 (13:08 +0000)]
Merge "Coverage - SalEchoServiceImplTest."
michal rehak [Fri, 31 Jul 2015 13:07:50 +0000 (13:07 +0000)]
Merge "Coverage - NodeConfigServiceImpl."
Jozef Gloncak [Fri, 31 Jul 2015 13:05:10 +0000 (15:05 +0200)]
Coverage - AbstractRequestCallback.
Increase code coverage for AbstractRequestCallback class.
Change-Id: I6d796e083980bb7db340facb867968f735ae0bbf
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Fri, 31 Jul 2015 12:09:05 +0000 (14:09 +0200)]
Coverage - NodeConfigServiceImpl.
Increase code coverage for NodeConfigServiceImpl.
Change-Id: I0cce5a9e3cde42bf79a3bbf3b457450be1eb9f30
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Fri, 31 Jul 2015 11:30:41 +0000 (13:30 +0200)]
Coverage - SalEchoServiceImplTest.
Change-Id: Ib630506804ff5528f0a96f5417164854eb4646d3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Fri, 31 Jul 2015 09:33:58 +0000 (11:33 +0200)]
Coverage - SalGroupServiceImpl.
Increase of code coverage for class SalGroupServiceImplTest.
Change-Id: Ia171a6a2c41c65a1d4e1772269473919c32a1a32
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Fri, 31 Jul 2015 08:28:02 +0000 (08:28 +0000)]
Merge "Coverage - SalMeterServiceImpl."
Jozef Gloncak [Fri, 31 Jul 2015 07:39:38 +0000 (09:39 +0200)]
Coverage - SalMeterServiceImpl.
Increase code coverage for SalMeterServiceImpl class.
Change-Id: I27850e93dde5a44ff0a04f2e6142f66ad29f787e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Thu, 30 Jul 2015 13:46:10 +0000 (15:46 +0200)]
Coverage - SalPortServiceImpl.
Increase code coverage for SalPortServiceImpl class.
Change-Id: I0ca4e870b5f1a35758381d033dcf1a18d5a87f01
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Thu, 30 Jul 2015 13:39:21 +0000 (15:39 +0200)]
Coverage - ancestor mocking class for services testing.
New ancestor class is added for easier testing of service classes.
Change-Id: I769aea6caeea4785714bdce1d5f449a0e9fa6384
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Thu, 30 Jul 2015 16:01:30 +0000 (18:01 +0200)]
Coverage - common package
Change-Id: I2f3f8f1f5fa4695989990d6b1f2b1079cf0efa4d
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Thu, 30 Jul 2015 16:00:17 +0000 (18:00 +0200)]
Added OFPM_ALL constant
- this constant represents all meters for stat
requests commands
- replaced wrong usage in MultipartRequestInputFactory
Change-Id: If3e8e7caad445aaa173b7a267bf341f6346dee93
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Thu, 30 Jul 2015 12:14:23 +0000 (14:14 +0200)]
Coverage - MultipartRequestOnTheFlyCallback.
Increase of code coverage for class MultipartRequestOnTheFlyCallback.
Change-Id: Ieb5719d540122bfc3969fece77d1b96f42d1596f
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Thu, 30 Jul 2015 08:55:19 +0000 (10:55 +0200)]
Coverage - rpc manager and context
Change-Id: I8ee20f13633e2010767758447a66b80cb026faeb
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Thu, 30 Jul 2015 08:53:33 +0000 (10:53 +0200)]
BUG-4068: RpcContextImpl doesn't close rpcRegistrations correctly
- fixed onDeviceContextClosed() method
Change-Id: I934abf198cc0101a53c9f4651d0ccad019c93985
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Wed, 29 Jul 2015 14:53:11 +0000 (16:53 +0200)]
Coverage - karaf commands - ResetSessionStat
Change-Id: I56704760a5897f8a89fea035053d255a82ccae5c
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Wed, 29 Jul 2015 14:51:08 +0000 (16:51 +0200)]
BUG-4065: Karaf command ResetSessionStats resets wrong counter
- copy-paste error - resetting wrong counter
- added missing reset method into SessionStatistics
- fixed the target of counter reset in ResetSessionStatsComandProvider
Change-Id: I0e15e3e82508cd8d5883bdd870839d90bfb8ec4c
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Wed, 29 Jul 2015 14:30:37 +0000 (16:30 +0200)]
Coverage - karaf commands - ofp/impl/karaf
Change-Id: I0db686de47ebcfb90bf31143f1cc7c1632de39b7
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Abhijit Kumbhare [Wed, 29 Jul 2015 13:27:45 +0000 (13:27 +0000)]
Merge "BUG-4034: Missing barrier after flow remove"
michal rehak [Wed, 29 Jul 2015 13:26:29 +0000 (13:26 +0000)]
Merge "Coverage - SalTableServiceImpl."
Abhijit Kumbhare [Wed, 29 Jul 2015 13:25:02 +0000 (13:25 +0000)]
Merge "BUG-4032: Missing topology-lldp-discovery config"
Jozef Gloncak [Mon, 27 Jul 2015 09:11:45 +0000 (11:11 +0200)]
Coverage - MessageIntelligenceAgencyImpl.
Increase code coverage for MessageIntelligenceAgencyImpl.
Change-Id: I16000bb415f1b58e0b94113f5dc9b27c6e0fb1c1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Vratko Polak [Mon, 27 Jul 2015 17:14:32 +0000 (19:14 +0200)]
Add sal-binding-config as dependency into various components
Usually, only sal-binging-api was present,
sometimes with sal-binding-broker-impl, but the essential yang model
opendaylight-md-sal-binding:2013-10-28 was never there;
and in Beryllium it stopped being found transitively.
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Change-Id: I47bd1be2002e92fdda69bd6e2699b5a40edc0b0e
Jozef Gloncak [Fri, 24 Jul 2015 12:49:31 +0000 (14:49 +0200)]
Coverage - SalTableServiceImpl.
Increase code coverage for SalTableServiceImpl class.
Change-Id: I9e52368010b254a33ef9f596b3b1e271ebce4d70
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Abhijit Kumbhare [Fri, 24 Jul 2015 14:20:01 +0000 (14:20 +0000)]
Merge "Coverage - ofp/impl/statistics/services"
michal rehak [Fri, 24 Jul 2015 14:03:12 +0000 (14:03 +0000)]
Merge "Coverage - SalFlowServiceImpl."
michal rehak [Fri, 24 Jul 2015 14:02:51 +0000 (14:02 +0000)]
Merge "Coverage - StatisticsManagerImpl."
Jozef Gloncak [Fri, 24 Jul 2015 09:16:43 +0000 (11:16 +0200)]
Coverage - SalFlowServiceImpl.
Increase code coverage for class SalFlowServiceImpl.
Change-Id: I8234976c60858dbc25e90db569e90c96d325a52e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Fri, 24 Jul 2015 12:47:14 +0000 (14:47 +0200)]
Coverage - StatisticsManagerImpl.
Increase code coverage for StatisticsManagerImpl.
Change-Id: I7c61449766c7400748e19ee8b3bdcb98ee7fc924
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Fri, 24 Jul 2015 09:43:56 +0000 (11:43 +0200)]
Coverage - fix error in FlowUtilTest.
If method createAlienFlowId() was called before this test it caused that
dummy alien ID didn't contain index 1 but index 2 and test failed.
Currently test calls createAlienFlowId() method twice and then compares
whether index suffix from first call is smaller then index from second call.
Change-Id: Ie8e1e1ab7825e266e94045a30c9d63770ef33611
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Thu, 23 Jul 2015 14:59:58 +0000 (16:59 +0200)]
Coverage - ofp/impl/statistics/services
Change-Id: I59ab9efdf1883a0ddc0f2311fed0b6f30ce83aca
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Thu, 23 Jul 2015 12:53:58 +0000 (14:53 +0200)]
Coverage - SalFlowServiceImpl.
Increase code coverage for class SalFlowServiceImpl.
Change-Id: Iffe547107d6fb84b7125db9015a8d29f436e388d
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Thu, 23 Jul 2015 11:54:34 +0000 (11:54 +0000)]
Merge "Coverage - OutboundQueueProviderImpl."
Jozef Gloncak [Thu, 23 Jul 2015 11:12:47 +0000 (13:12 +0200)]
Coverage - OutboundQueueProviderImpl.
Increase code coverage for class OutboundQueueProviderImplTest.
Change-Id: Iaae0a5808b5080567107ae991888064b335d2fa1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 22 Jul 2015 16:50:17 +0000 (18:50 +0200)]
Coverage - DeviceContextImpl2.
Continuing increasing of code coverage for DeviceContextImpl.
Change-Id: I6c9eb9a12dd4aebff13bd2d5a29fe37f06300ec8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Wed, 22 Jul 2015 15:58:11 +0000 (15:58 +0000)]
Merge "Use Beryllium version of liblldp"
michal rehak [Wed, 22 Jul 2015 14:06:14 +0000 (14:06 +0000)]
Merge "Coverage - DeviceContextImpl."
Thanh Ha [Wed, 22 Jul 2015 13:52:06 +0000 (09:52 -0400)]
Use Beryllium version of liblldp
Bug: 4030
Change-Id: I2d8c496c23f7b6a5cc6acc89accef1ffada78c0b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Jozef Gloncak [Wed, 22 Jul 2015 11:13:23 +0000 (13:13 +0200)]
Coverage - DeviceContextImpl.
Increase code coverage in class DeviceContextImpl.
Change-Id: Iff4e793fcdf23c029c2df5cda2bb2cd80635a12b
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 22 Jul 2015 08:53:47 +0000 (10:53 +0200)]
Coverage - SinglePurposeMultipartReplyTranslator.
Increase code coverage for method getGroupActionsSupportBitmap()
Change-Id: Ia9b8f72a4586394e7ccd301a31e3c320a88cf294
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Wed, 22 Jul 2015 08:28:29 +0000 (10:28 +0200)]
BUG-4034: Missing barrier after flow remove
- fixed barrier support for:
- flow: remove
- meter: remove, update
- group: remove, update
Change-Id: I5934923614e7572343ce5bef068f74c0c7a5fb69
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Wed, 22 Jul 2015 06:53:10 +0000 (08:53 +0200)]
BUG-4032: Missing topology-lldp-discovery config
- in Li-features there was missing dependency on
topology-manager and topology-lldp-discovery config files
Change-Id: I9d98d0f617deb4bc629b17b0dd9dec38d687fad4
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Tue, 21 Jul 2015 14:18:06 +0000 (16:18 +0200)]
Coverage - SinglePurposeMultipartReplyTranslator.
Increase code coverage for SinglePurposeMultipartReplyTranslator.
Change-Id: I2d816a51e5b3b9c8a6a3cd8f60603b9c6be6bafd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Anil Vishnoi [Mon, 20 Jul 2015 16:11:34 +0000 (16:11 +0000)]
Merge "Cover - StatisticsGatheringUtils"
Anil Vishnoi [Mon, 20 Jul 2015 16:11:08 +0000 (16:11 +0000)]
Merge "Coverage - StatisticsContextImpl"
Anil Vishnoi [Mon, 20 Jul 2015 16:10:11 +0000 (16:10 +0000)]
Merge "Coverage - PortUpdateTranslator"
Anil Vishnoi [Mon, 20 Jul 2015 16:09:40 +0000 (16:09 +0000)]
Merge "Coverage - PacketReceivedTranslator"
Anil Vishnoi [Mon, 20 Jul 2015 16:09:23 +0000 (16:09 +0000)]
Merge "Coverage - AggregatedFlowStatisticsTranslator"
Jozef Gloncak [Mon, 20 Jul 2015 13:22:50 +0000 (15:22 +0200)]
Coverage - DeviceManagerImpl.
Increase code coverage in DeviceManagerImpl.
Change-Id: I89ebfc2791fe656205bc8a8c90aacd3199e772cc
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
joe [Fri, 17 Jul 2015 11:37:37 +0000 (13:37 +0200)]
Coverage - DeviceManagerImpl.
Increase coverage of DeviceManagerImpl.
Change-Id: I5bf1d7388280edd016bb46f6033d2a2701f716af
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 15 Jul 2015 09:08:36 +0000 (11:08 +0200)]
Cover - StatisticsGatheringUtils
Change-Id: I465ba12b5e14f699bde710a59decf85a5f34f99e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Fri, 17 Jul 2015 15:21:25 +0000 (17:21 +0200)]
Coverage - PortUpdateTranslator
- fixed typo in the translator (supportedFeatures per OF-version)
Change-Id: Ica52f80fb1b157c1de1a2497b4dcc440396234c4
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Fri, 17 Jul 2015 15:20:28 +0000 (17:20 +0200)]
Coverage - PacketReceivedTranslator
Change-Id: I42ce751aeadd49d7fa079a0c28bb4bb500adc266
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Fri, 17 Jul 2015 15:18:48 +0000 (17:18 +0200)]
Coverage - AggregatedFlowStatisticsTranslator
Change-Id: Id71d62eb759e6b7dc5db0e8a461c0366e5d8bd89
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Thu, 16 Jul 2015 15:19:29 +0000 (17:19 +0200)]
Coverage - StatisticsContextImpl
Change-Id: Ifee04a43a1a10498e47c50fb8fbb983ab78e5050
Signed-off-by: Michal Rehak <mirehak@cisco.com>
michal rehak [Thu, 16 Jul 2015 12:44:59 +0000 (12:44 +0000)]
Merge "Coverage - DeviceManagerImpl."
Jozef Gloncak [Wed, 15 Jul 2015 13:50:39 +0000 (15:50 +0200)]
Coverage - DeviceManagerImpl.
Increase of code coverage for clase DeviceManagerImpl.
Change-Id: I0dbee99d7ba299ec2a6a7052a70a3cc28e979bd9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Thu, 16 Jul 2015 09:27:20 +0000 (11:27 +0200)]
BUG-4004: sal-echo.yang contains strange characters
- chacters replaced (origin was probably OFP-1.3.2 specification pdf)
Change-Id: I1d37a291f14388c3436eb1fbb4f1245ad9fe09dd
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Thu, 16 Jul 2015 08:35:30 +0000 (10:35 +0200)]
Method visibility change - DeviceManagerImpl.
To be able to test some method, modifiers were changed.
Change-Id: I5d331659c6fc0db300eebbc7fd35bf885a67d8b4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Wed, 15 Jul 2015 09:08:20 +0000 (09:08 +0000)]
Merge "Cover - StatisticsContextImpl."
Jozef Gloncak [Tue, 14 Jul 2015 12:09:02 +0000 (14:09 +0200)]
Cover - StatisticsContextImpl.
Coverage for StatisticsContextImpl.
Change-Id: I42b9351379728f791535dc6d943974757ab34c6e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Michal Rehak [Tue, 14 Jul 2015 14:52:52 +0000 (16:52 +0200)]
unit test - fixing package
- moving tests of RpcManagerImpl and RpcContextImpl to appropriate package
Change-Id: Ibb0d0c55f049affd7c81558b8d56c8a2f0039daf
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Tue, 14 Jul 2015 06:34:18 +0000 (08:34 +0200)]
FlowUtilTest
Test for class FlowUtil.
Change-Id: I805f31f508a196dc4a69793ab3f55547ba23487a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Mon, 13 Jul 2015 09:23:53 +0000 (11:23 +0200)]
Coverage - registrator and translator libraty util.
Increasing code coverage for classes:
- MdSalRegistratorUtils
- TranslatorLibratyUtil
- DeviceStateUtil
- MatchUtil
Cosmetics.
Change-Id: I193862f8a2d9e96e719fc1b1185140230a7d31eb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Anil Vishnoi [Wed, 1 Jul 2015 06:48:44 +0000 (06:48 +0000)]
Merge "BUG-3849: Unit test failure due to timing issues"
Michal Rehak [Wed, 24 Jun 2015 14:47:21 +0000 (16:47 +0200)]
BUG-2429: Need to close the ODL Denial of Service interface
- added hsContext close action to connectionContext
Change-Id: I93d92951450f6a7af366d75ce985f1076b977d3f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Tue, 23 Jun 2015 18:44:16 +0000 (20:44 +0200)]
BUG-3849: Unit test failure due to timing issues
- ConnectionConductorImplTest works better on machine under heavy load
or slow CPU
- added more reliable message sending (make sure that harvester picks it up)
- (this bug manifests only when small amount of messages is sent in
short time frame)
Change-Id: Iaa89748dfd938bf677cde0c8fc0893a95ded7430
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Ed Warnicke [Mon, 22 Jun 2015 11:43:51 +0000 (05:43 -0600)]
Bug 3829: Fix for race condition between loading of plugin and inv/stats manager.
Change-Id: I63e0494e26cbb21876946a2bb0d2eaf3fce676b5
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit
f1df44b59cd71db628b4985a826cf5bc21ac8155)
michal rehak [Mon, 22 Jun 2015 16:10:38 +0000 (16:10 +0000)]
Merge "Bug 3754 - NPE at org.opendaylight.openflowplugin.openflow.md.core.ConnectionConductorImpl"
Martin Bobak [Mon, 22 Jun 2015 12:36:50 +0000 (14:36 +0200)]
Bug 3754 - NPE at org.opendaylight.openflowplugin.openflow.md.core.ConnectionConductorImpl
Change-Id: Ib340a463076f805b29363c008bbdd214f25c2b78
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Jozef Gloncak [Thu, 18 Jun 2015 12:10:52 +0000 (14:10 +0200)]
BUG 3548 - LLDP speaker doesn't start send LLDP packet on port up.
Listener on changes on changes on State subtree was added.
If instance of FlowCapableNodeConnector with port down is received
in NodeConnectorInventoryEventTranslator then it is stored to local map.
When event port up event is received then stored instance is looked up
in map, state part is replaced (with port up information) and it is sent
to LLDP.
Change-Id: Ic989a88c06b2e266c63375bd19e3ed2c2b4d4c2d
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
(cherry picked from commit
5865c58f43808e730fdb9dc310741663c304112d)
Martin Bobak [Wed, 17 Jun 2015 12:25:30 +0000 (14:25 +0200)]
BUG-3741 - groups and meters failing
- fixed group deletion
- fixed meter deletion
- optimized instance identifiers for flowCapableNode
Change-Id: I4645b2bd2e9b2aded1c55015dc2ad8f5b1428517
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit
01b5fb16c02331da1d9dd6b2ca40509f4c90785f)
Martin Bobak [Tue, 16 Jun 2015 07:08:28 +0000 (09:08 +0200)]
BUG-3157: cbench tuneup - packetIn dynamic throttling proposal.
Limit for total amount of outstanding notification can be parametrized.
By default there is 120k. Every device gets proportional part of that
limit and corresponding limiter is notified when number of devices
changes and new proportions affect limits.
- added parameter to configSubsystem
- water marks adaptation proposal
- sanitize limit computation
Change-Id: I257f1b91b8f5d512f512c1694be6be3a670128c6
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit
024a822cccc79cd15ca7f9d5d67f54215c82a9d5)
Jan Medved [Tue, 16 Jun 2015 03:23:01 +0000 (20:23 -0700)]
- Creating separate bulk-o-matic features for the He and Li plugins
- fixed dependencies
Change-Id: I2de2addc4d31c7b03b5b9206367c9fe168dd4439
Signed-off-by: Jan Medved <jmedved@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit
cca6476b40b353886ac1a501dcd3659a6aaa462b)
michal rehak [Mon, 22 Jun 2015 08:36:44 +0000 (08:36 +0000)]
Merge "bulk support application - initial proposal"
Martin Bobak [Mon, 8 Jun 2015 16:44:34 +0000 (18:44 +0200)]
bulk support application - initial proposal
- added models to config subsystem config file
- created simple implementation
- added to ofp-li features
- workarounded restconf bugs (flow-ref related)
- added parents creation for dataStore way (all or first only)
- clean up rpc intput models
- fixed version
Change-Id: I1716b32738c8e430d674ff5f0476d55ab10b43fb
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit
45c121d507dbd45995fa3efa56a9cef5154dee62)
michal rehak [Mon, 22 Jun 2015 07:11:32 +0000 (07:11 +0000)]
Merge "Bug 3817: Fix action convertor for OF 1.3."
Hideyuki Tai [Thu, 18 Jun 2015 22:05:58 +0000 (15:05 -0700)]
Bug 3817: Fix action convertor for OF 1.3.
The action convertor for flow entries of OpenFlow 1.3 wrongly used
instance builders for UDP source port in the conversion for the UDP
destination port. In the result, the OpenFlow plugin failed to install a
flow entry which has an action modifying UDP destination port.
Also, the action convertor wrongly used Icmpv4Type.class to create an
action modifying ICMPv4 code filed. And, the size of mask for ICMPv4
code and type fields was wrongly set into 0x0f, though the size of these
fields were 8 bits.
This patch fixes these issues so that the OF plugin can correctly
install flow entries which modify UDP destination port and ICMPv4
fields.
Change-Id: I8e972233bbea5741bb8bca39cbd281b6c00b763b
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit
05d964944576807810ef9e8622f56eb2cff4c4ce)
Anil Vishnoi [Fri, 19 Jun 2015 13:30:02 +0000 (19:00 +0530)]
Bug-3794 - OFHandshake thread leak leads to OOM.
Fixed the thread pool cleanup
Change-Id: I95f7c8f54f839767c7dddbf47eaee79101cecf59
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit
b3e707fd60476c7ebf79b53a198b703eee0030ca)
Anil Vishnoi [Wed, 17 Jun 2015 22:16:41 +0000 (03:46 +0530)]
Bug 3792 - Change default flow timeout values to 0
Current OF plugin sets the following default values if idle and
hard timeouts are not set in flow body:
Idle_timeout=300
hard_timeout=600
as per openflow spec, if user don't set hard-timeout and idle-timeout
value explicitly, switch will set it to 0 and consider the flow permanent
flow. So existing behavior is clearly violating the specs.
Change-Id: Ibb08d5913d8cb6b2c794e2206e4c854537f2ce7d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Thu, 26 Mar 2015 13:43:49 +0000 (19:13 +0530)]
Bug 2902 - NPE when apply_action doesn't contain action list
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: Ibf7f2e940388f1a28466fa5b19b75a95aa9a4e24
Anil Vishnoi [Sun, 7 Jun 2015 11:31:06 +0000 (17:01 +0530)]
Bug 3041 - Meter and Meter Config messages not sent when controller starts after the switch
Openflow plugin explictly sends group/meter features statistics request
after successful switch handshake to the controller. Statistics-manager
receives multipart reply and ignores it, because it only process response
for the request sent by itself. So it does not make sense to send these
request from plugin.
Statistics manager also sends meter/group feature multipart request when
it's get notified that new node is added to the inventory. In case where
it gets the response immdiately from switch, sometime it creates race
condition where statistics manager don't find the transaction-id of the
request in the cache for which it received the response. This race condition
occures because statistics manager store the key in cache once request send
operation finishes successfully in asyn manner. Processing the group/meter
response for the request send by plugin causing the reordering of the event
so that statistics processing happens before it adds transaction-id to the
cache. This race condition make statistics manager believe that the request
was not send by it and so it does not update the meter statistics capability
of the node and hence it stops sending the meter stats.
Patch 2 : Fixed unit test - plugin don't send meter/group feature request
now, so two less events.
Patch 3 : Fixed integration test for stable/lithium and master
Change-Id: I15fb58b8f9118f94d1a4154a2662972f69f938a0
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
michal rehak [Sat, 13 Jun 2015 17:25:32 +0000 (17:25 +0000)]
Merge "Bug 3660 - Missing flow for match ARP."
Jozef Gloncak [Wed, 10 Jun 2015 14:25:54 +0000 (16:25 +0200)]
Bug 3660 - Missing flow for match ARP.
Probably typo. Incorrect variable was evaluated.
Change-Id: I02ece504dda3603e8d5dbc60e6dda06d5f60ebbd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
(cherry picked from commit
33637cfb62d32ce59894c18de5e86e73c9047e70)
Jozef Gloncak [Mon, 8 Jun 2015 09:36:47 +0000 (11:36 +0200)]
BUG 3603 - Flow without priority isn't processed.
If flow priority isn't specified then default value 0x8000 is used.
Operation no more fail with NPE.
Change-Id: I9de3457781478e83401a4b18000ded58af501654
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
(cherry picked from commit
81f9238a2012999c4fe94c87486f4d7c9bf0f54a)
Jozef Gloncak [Mon, 8 Jun 2015 11:23:48 +0000 (13:23 +0200)]
Bug 3616 - NPE if flow ref isn't provided.
Check of nullity was added.
If flow ref:
- was provided in input data then it is used.
- wasn't then new flow isn't stored in flow registry.
Once statistics will come then allien ID will be generated
for this flow.
Change-Id: Id1ee07ca38825077acfda3af82badbac92db79a5
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
(cherry picked from commit
2679df2fb38df97b44c4ca6f60526a35dc0d018f)