Overall hardening of the code

- Overall hardening of the code
- Expansion of regression testing

Change-Id: Ib62aae644d85e47ee8c14fc8566556db413082aa
Signed-off-by: Reinaldo Penno <[email protected]>
(cherry picked from commit 0ed2f0614b0076e3fbe22b2beedae52df0b9c28e)

Incrementing versions by 0.1.0 for post-helium master branch

Change-Id: I1ca0a618b1a412f847fdfa91a2304c5be8730d3d
Signed-off-by: Reinaldo Penno <[email protected]>

Enabling subnet-mask as input

Change-Id: Ibd1f4a2e077f7dfc096854f08b62537fe2584165
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Acl-flow fixed
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: I10a5db61e73502b27644448310bb2fd571763e72
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Bug 2146: SFC broken due to new auth requirement (correct fix)

HTTPBasicAuthFilter added to jersey REST client
It attaches Authorization: Basic YWRtaW46YWRtaW4= to HTTP header
It means that username and password is hardcoded to "admin", "admin"

Change-Id: Ib164a8736c5793a670b55347b703f249bdd63e66
Signed-off-by: Andrej Kincel <[email protected]>

Support for multiple data-plane locators

Change-Id: I0f04145d238298a9ec4bddf9102b851e361c7787
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Disabling egress transport table

Change-Id: Id08686d0083c52f21b8c4abd19fa918ca656e4bf
Signed-off-by: Shuva Jyoti Kar <[email protected]>

EthType matches not required
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Getting rid of vlan_vid/different priorities flow
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: I7c61fdc3c527b4ad5f2e7f37527d2a7c562b9163
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Resolved NoClassDefFoundError at runtime
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: I28ecf0139191f945d68a4be1185cc6167149d1bb
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Multiple Mac matches to address multiple chains

Change-Id: Iae7312446ff1ab9b646c7ebd62bbd4cf03e03f91
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Unit tests support for sfc-ui

karma-unit.tpl.js - config for karma test runner

package.json - config for npm package manager (contains packages required
to execute tests)

README.md - added step by step guide for karma installation and test execution

Change-Id: I19807a8a8404f7dfa1ffbef191ff0ec7970376a6
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Fix to write mac/ip to avoid frm bugs Signed-off-by: Shuva Jyoti Kar <[email protected]>"

Merge "Unit tests for provider API"

Fix to write mac/ip to avoid frm bugs
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: I3f1971ad23c4ae2b58b52199407fcfa3933241f5
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Bug 1948: Separate out restconf features

In order to avoid a maven project cycle in solving
Bug 1948, we need to separate restconf features.
Note, this is a first step, suffixing everything
with -new.  Subsquently, after everywhere using
odl-restconf has been fixed to use this new repo,
we will deprecate the ones in the mdsal features.xml
and rename these to not have the -new.

This patch just adds the dependency to features/pom.xml

Change-Id: I6de8b6bcaeec75eef41df14dbac58bbedec3a779
Signed-off-by: Ed Warnicke <[email protected]>

Unit tests for provider API

Change-Id: Ifef803488b660069ebb516c408bf88fbf0921c02
Signed-off-by: Konstantin Blagov <[email protected]>

Merge "serve index.html on sfc/ root directory request Activator.java code cleanup"

serve index.html on sfc/ root directory request
Activator.java code cleanup

Change-Id: Iad292289c8f5d8faaa6830b0c2e155b31489d722
Signed-off-by: malauko <[email protected]>

Bug fix pack for SFC-UI

Added missing angular-xeditable library (was not included because 'dist' is in .gitignore)
Fixed REST PUT requests
Fixed SFC/SFP table reload
Fixed SFC symmetric property
Fixed automatic addition of required SFF into SN

Signed-off-by: Andrej Kincel <[email protected]>, Martin Lauko <[email protected]>

Karaf final changes
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: Ia053649d19913d172dbc6993622ca4882a8cb27c
Signed-off-by: Shuva Jyoti Kar <[email protected]>

adding sfcofl2 karaf features

Change-Id: Id8e9e61bb990a5a253e9b13f97b0eebc78768317
Signed-off-by: ChrisPrice <[email protected]>

Bug 1867: fix to features files

Change-Id: I9acac68f8d9edee4875b252e46e6c0a0855d8b04
Signed-off-by: Ed Warnicke <[email protected]>

Merge "added missing bundle dependency"

added missing bundle dependency

Change-Id: I137487a5209a355a5be580742d54d737e96b6278
Signed-off-by: David Goldberg <[email protected]>

Merge "adding SFC features adding sfclisp"

adding SFC features
adding sfclisp

Change-Id: I3e4ac5a0fae056ca019a5475152b29fc0e6f890d
Signed-off-by: [email protected] <[email protected]>

Merge "SFC Python Regression Test for Karaf"

Added Karaf feature for SFC-UI

New odl-sfc-ui Karaf feature is added to odl-sfc-all.
SFC-UI is available on http://localhost:8181/sfc/index.html

This solution is only temporary because it's not using Dlux Karaf.
Instead it's only using dlux-web mvn bundle as dependency, then it inserts SFC-UI
project files into it creating merged SFC-UI bundle.

Signed-off-by: Andrej Kincel <[email protected]>, Martin Lauko <[email protected]>

Fix for missing features dependencies

fixing duplicate entries

Change-Id: Ie2229a4d273fec67dcb453a7c67a34b96a06ec1e
Signed-off-by: Ed Warnicke <[email protected]>

SFC Python Regression Test for Karaf

Change-Id: I5c59f4e298763df7eaea1f6a7383bd352296566d
Signed-off-by: Reinaldo Penno <[email protected]>

fixing bootfeatures: sfc-all and restconf load at startup

Change-Id: I055128ac8598c06d1064c6ad2a89e06b81707741
Signed-off-by: paulq <[email protected]>

Fix for SFC bootstrap config files loading

Change-Id: If54e22d65957d0162e032bf7ecee55902de860a7
Signed-off-by: Andrej Kincel <[email protected]>, Martin Lauko <[email protected]>

inital sfc feature for karaf integration

Change-Id: I9fd54bdb56f9df245b9a6ed8dd0433d86592429a
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Ed Warnicke <[email protected]>

added lisp updater bundle for service functions and service function forwarders with lisp address

Change-Id: Id7bc013a8c87eeb0a3d75149eb37c4a240b70da6
Signed-off-by: David Goldberg <[email protected]>

SFC-OF-L2 implementation
Signed-off-by: Shuva Jyoti Kar <[email protected]>
Change-Id: I30bf3eece86290f54ffad6112a2245b92880904b
Signed-off-by: Shuva Jyoti Kar <[email protected]>

Revert "added lisp updater for service functions and service function forwarders with lisp address"

This reverts commit 2fd4810db9dc9a22e472a40da37bf0cc91cee760.

Revert "added lisp updater for service functions and service function forwarders with lisp address"

This reverts commit 2fd4810db9dc9a22e472a40da37bf0cc91cee760.

Gal, David,
I am reverting this patch.

As noted in the comments to patch:
https://git.opendaylight.org/gerrit/#/c/10669/
This patch breaks the existing sfc-provider.

You were specifically asked not to do so in
the review for 10699 to which you provided no response.

The existing agreed architecture is extremely flexible and
allows for multiple independent providers, as you can see
in the openflow provider here:
https://git.opendaylight.org/gerrit/#/c/10631/
and here the provider for the ovsdb folks here:
https://git.opendaylight.org/gerrit/gitweb?p=ovsdb.git;a=tree;f=ovs-sfc;h=8fa462c53b4c92b50a292ec3bc2a5b3e0ba22282;hb=HEAD
An additional provider from you guys that does something LISP
specific is very welcome, but breaking existing code the day
before code freeze is not.

Let me know if you need a hand getting your provider in and
a karaf feature for it.

Change-Id: Ie84ed0d4540af9e12ac20d55291871a133b7a793
Signed-off-by: Ed Warnicke <[email protected]>

added lisp updater for service functions and service function forwarders with lisp address

Signed-off-by: David Goldberg <[email protected]>

Fix for missing exports from sfc

sfc-model adds ietf-acl.yang and packet-fields.yang but does not export them so other bundles fail to resolve when loading since they can't find them.

org.osgi.framework.BundleException: The bundle "org.opendaylight.ovsdb.ovssfc_0.0.1.SNAPSHOT [137]" could not be resolved. Reason: Missing Constraint: Import-Package: org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.acl.rev140520; version="[0.0.0,1.0.0)"

Change-Id: Id1db0f3c6cd666c6e5f463e94f81a99304a4532c
Signed-off-by: Sam Hague <[email protected]>

Fix for SFC-UI initial commit

Change-Id: Ia68677f302494dd3b0a81e913c64f251b810e990
Signed-off-by: Andrej Kincel <[email protected]>

Initial commit for SFC-UI

It's just collection of all sfc-ui source files enclosed in maven bundle.
Needs to be added to oncoming SFC Karaf as feature.
Then this feature should be pluggable into DLUX project.

Change-Id: I8f7704bbeda6b6e1287c3c0eeb86983298b19a80
Signed-off-by: Andrej Kincel <[email protected]>

Bug Fixes and Enhancements

- Bug due to recent callable change: When using more than one executor concurrently
   we need multiple threads in the pool or system deadlocks
- Bug: external-ids in Openstack/OVS Yang needs to be a list
- Enhancement: Changed SFP Yang so that it is a collection of hops that are a combination of SF & SFF
- Bug: Changed SF yang so that it can contain a list of locators instead of single container
- Fixed initial config files accordingly
- Bug: SFP Data Listener needs to listen to scope BASE otherwise we create an inifite loop

Change-Id: I2243e82b530baf549685cbcb7722fcb7f4517e24
Signed-off-by: Reinaldo Penno <[email protected]>

Moved provider API to subpackage .api; solved minor scope issues

Change-Id: I88ea03f4ee075e0467cb79a57447ee9e0e6c6869
Signed-off-by: Konstantin Blagov <[email protected]>

API classes changed to Callable
Added put/read/delete methods
Applied new DataBroker transactions API
Added dependencies for unit testing
Outdated classes to instantiate a SFC moved to sub-package

Change-Id: I69758c6212e1c8be81cdefbac4e7ebda41ae786c
Signed-off-by: Konstantin Blagov <[email protected]>

Add openflow bundles to sfc to fix openflow problems

Change-Id: I79b2e130be04f1e83bdc2e8481370cc5b8f904ee
Signed-off-by: Sam Hague <[email protected]>

Fixed most reported issues and general improvements

ACL model now references SFP name
Modified Data Plane Locator group and used within SF, SFF and SF dictionary
Added trasnport type to Data Plane locator group
Added more necessary information to SFF OVS model
SFP model has service index for each SF and consequently we populate
  SI for each SF
Modified ACL model by inserting a list under top container
Modified original configuration files accordingly
Added newer ietf-yang-types dependency to POM
Modified Log configuration from DEBUG to ERROR
Modified SF model to indicate whether SF is nsh-aware

Change-Id: Ifcf83e0841bea7624a5d9e52e866f26abb6c21d1
Signed-off-by: Reinaldo Penno <[email protected]>

Added apply logback.xml configuration to Logback service on sfc-provider initialization
Added '.hg' to .gitignore

configuration: logger for sfc-provider to sfc.log file and send messages to syslog server

Change-Id: Ibdcfc59bf89f53e486aca0645cd03205a67b78aa
Signed-off-by: malauko <[email protected]>

Bug Fixes and More Fine Tuning of Yang Models

- Further decoupling of SFF and SF
- Fixed bugs as part of moving to new DataBroker
- Fixed bootstrap files to account for modified Yang models
- Fixed RPCs accordingly

Change-Id: Icf7ae1c4d645696044cc5564c9e16eb45970e0c9
Signed-off-by: Reinaldo Penno <[email protected]>

Decoupling of SFF and SF. More bug fixes

- Decoupling SFF and SF in a upcoming commit. Today when you create
  a SF, we create a SFF if it does not exist. But any coupling
  between the models is really bad because it makes us have to do
  garbage collection and synching of data. So, the user will have
  to explicitly create a SFF and in its configuration also specify
  the list of SFs attached to it.
- Changed sfc_provider_config.json to pretty format.
- Changed SFC chain model to allow symmetric paths
- Fixed a few Yang modules with lines larger than 70 chars.
- Fixed a few Yang descriptions according to new arch draft-01
- Fixed LOG statement in SnDataListener()
- Fixed service-function-forwarders.json to use new model syntax.
- Fixed OVS yang namespace issue

Change-Id: I56227cd8ef1d8a78386c75f3c3b6fcd97f34c1cc
Signed-off-by: Reinaldo Penno <[email protected]>

Fixes several bugs on bootsrap code, Yang models and related

- Fix sfc-initial.xml to reference new Async Data Broker
- Fix SfcProviderConfig(). Static variables are initialized in order they are declared.
- Fix SfcProviderConfig(). Test if file exists
- Fix SFcProviderConfig(). Moved reading config file to a separate method so we can handle
    failure gracefully. If reading is inside constructor we can not test for failure.
- getPutBootstrapData() was trying to commit initial config too early - datastore not ready.
  Moved to a ScheduledExecutorService with delay of 15 seconds.
- Commented out recent changes to data-plane-locator (Mac address). During testing
  I found that the system becomes unusable due to a Yangtools bug.
  https://bugs.opendaylight.org/show_bug.cgi?id=1467
- Fixed all Yang modules to be IETF compliant

Change-Id: Ie04890166382027a0564be2a8e2eb2fef3693032
Signed-off-by: Reinaldo Penno <[email protected]>

Yang Model changes for simple use case.

Change-Id: I1492d86696a08bb99df5d63461515e56d6183794
Signed-off-by: ebrjohn <[email protected]>

JSON configuration file for provider

Change-Id: I7138fff9ee552737476a764d39106e6496b110a1
Signed-off-by: Konstantin Blagov <[email protected]>

Migrating SFC to new Data Broker

- All necessary changes to migrate to new data broker
- Changed SFF model to better accomodate OVS architecture

Change-Id: I313232085bf22284860d4d064707854658699645
Signed-off-by: Reinaldo Penno <[email protected]>

removed unnecessary imports

Change-Id: Iad22697de10d264dcbfab6cc5eb6248727841a3c
Signed-off-by: Konstantin Blagov <[email protected]>

added copyright headers

Change-Id: I08f61fb837f1bcd3cd9892564d4d4e55df568a60
Signed-off-by: Konstantin Blagov <[email protected]>

Bootstrapping data from JSON configuration files

Change-Id: I1731cd536d8889c10b60e620c516e542136ec9e7
Signed-off-by: Konstantin Blagov <[email protected]>

Merge "Bug fixes"

Bug fixes

- When a SF is deleted, we need to clean up the operational state.

- When a new service path is added at the top level it replaces existing
  ones that need to be removed from the service function state list

- When deleting a SF from SFF we were actually deleting the entire SFF.
  Not detected until tests with partial overlapping PUTs

Change-Id: Ie960761ed0d05b444748fe3b7187a9f4f7e3a48f
Signed-off-by: Reinaldo Penno <[email protected]>

added mandatory SFName parameter setting

Change-Id: Ifff85bab29fe5f467e0609466d62829201e902a8
Signed-off-by: Konstantin Blagov <[email protected]>

Several Enhancements and bug fixes

- Completely decoupled SF and SFC.
- Completely decoupled SFP and SFC
- SFC is just a blueprint to build SFPs
- SFC can be deleted and SFPs stay
- If SF is deleted/updated, SFPs/SFF
  are deleted/updated accordingly
- Enhanced REST API
- All APIs are using reflection and factories.
  Meaning API implementation can be changed without changing signature
- Hardening of the code
- Modified Yang models by introducing operational containers.
- Fixed concurrency issue.

Change-Id: I8478b4ce3b0d2ab3092b5458fcd09116b6b1664f
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Bug fixes"

Bug fixes

- Fixed bug in path-id generation. Due to concurrency variable is now atomic
- Change LOG.info to LOG.debug

Change-Id: Iae29cf18a55bf5acf6c6c52b0076ee7ce92972f0
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Add support for gitreview to sfc"

Integration with OVS and Hardening of APIs

- Tested complex scenarios such as deleting SF from chain,
  deleting data plane locator, deleting SF, adding SF, etc

- Updated models as needed based on code and tests

- Implemented southbound REST communication and
  tested OVS integration

Change-Id: Icfba656babd566ee82b0c1ec17bf7ba4fb154989
Signed-off-by: Reinaldo Penno <[email protected]>

minor fixes to POMs; fixed CRLFs

Change-Id: I2a7d50a1a048e71a00b42438b49cd9fd382df56f
Signed-off-by: Konstantin Blagov <[email protected]>

Add support for gitreview to sfc

Change-Id: Ia1fcf3d0d764ef19fcd156876c4219badfd17fc7
Signed-off-by: Sam Hague <[email protected]>

fixed RPC to instantiate SFC to SFP (selects SFs randomly)

Change-Id: I2ed4d0f0b5a76caabd06005b46cc480fc2cc409d
Signed-off-by: Konstantin Blagov <[email protected]>

added sfc-distribution, RPCs

Change-Id: I817c1071727a7c6d332c4010c66f0b0a26e9ecc3
Signed-off-by: Konstantin Blagov <[email protected]>

fourth state of Provider

- When a service function is created via RESTconf, internally
  we create SFF and SFP
- When a service function chain is created we patch SFF and SFP
  with the final info to send to devices

Change-Id: I9ef2c82a02ca08e7a58ddce8559da3e58345ee57
Signed-off-by: Reinaldo Penno <[email protected]>

Third Stage of Provider Commit

- Fixed yang models to reflect testing and use-cases
- Added Sfc-test-consumer
- Add listeners and APIs to reflect generic integration

Change-Id: Iac115f96ecd34ba08b262ab749431b43c796653c
Signed-off-by: Reinaldo Penno <[email protected]>

Stage 2 of SFC Provider Application

- Provider plug-in
- Changes to parent pom to compile provider plug-in

Change-Id: I2bf3624a05e233e292bd60d9cc102addf291ac3a
Signed-off-by: Reinaldo Penno <[email protected]>

Stage 1 of provider Commit

- Adding parallel sfc-model

Change-Id: I5d8ae5245dc2ad3055ec3bd65748afe733b82b06
Signed-off-by: Reinaldo Penno <[email protected]>

first round of POM changes. This commit makes sure
upcoming provider application can see model classes.

I will change names and organize dependencies in later commits

Change-Id: I5e052147c04cccf38d88c141d631b41c33056619
Signed-off-by: Reinaldo Penno <[email protected]>

Updated Yang models to reflext draft-penno-sfc-yang-03

Changed service-function-chain.yang and service-function.yang
back to unix encoding from DOS encoding (stripped out CRs).

Original-Signed-off-by: Reinaldo Penno <[email protected]>
Change-Id: Icb2eddbac7eb6e730c6b5b7e074043082f13eb9f
Signed-off-by: Ryan Moats <[email protected]>

Add dependencies to model pom.xml

The pom.xml was missing some yang dependencies for locating
items in a running controller.  Added same.

Change-Id: I448c546a0d69a1d32403db5efb263450f595fe8f
Signed-off-by: Ryan Moats <[email protected]>

Add initial checkstyle rules

This commit adds checkstyle rules (no tabs, no trailing white space)
to the project and fixes the yang models to conform.

Only the *.yang files are currently checked, we need to add *.java
while excluding the machine generated files

Change-Id: I408523b2a90f9e32b65415eb179c7a058c641d82
Signed-off-by: Ryan Moats <[email protected]>

Add distribution management to pom files

The original commit lacked pom files and so the jenkins
merge job failed when it came to deploying the artifacts.
This patch addresses this...

Change-Id: Ieb8b3d73f460852c5f0193ebb575cf562a5d2a43
Signed-off-by: Ryan Moats <[email protected]>

First SFC Model Commit

Change-Id: I21b35d7dc7611b9ec9658a3e848eae3b5e3838ad
Signed-off-by: Reinaldo Penno <[email protected]>

Initial empty repository