Merge "NeutronSecurityRuleInterface: remove nonsense code"

Merge "NeutronSubnetInterface: remove non sense code"

Merge "NeutronLoadBalancerPoolInterface: remove unused static final variables"

Merge "Do not deploy the karaf artifact"

NeutronLoadBalancerPoolInterface: remove unused static final variables

Change-Id: I31e4effccd59c0a6f9a08a452ce2411231d590df
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

NeutronSubnetInterface: remove non sense code

addSubnet and removeSubnet methods carries legacy code
which doesn't have any effect.
This patch Removes them and simplifies the code

Change-Id: I30d7f71336f9b7a99690235a7474e2fda67b8315
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

NeutronSecurityRuleInterface: remove nonsense code

updateSecGroupRuleInSecurityGroup and removeSecGroupRuleFromSecurityGroup
have no effect any more. They modifies variables no one else refers to.
There is no point to carry those methods.
So this patch removes those methods and simplify related code.

Change-Id: I378b8ce72b2d064940a5f345d1b55e60dd9981ae
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Do not deploy the karaf artifact

The karaf artifact is only used for testing. It does not need to be
released to the world.

Change-Id: Ic1ff344fa606666c08ec6c75e89984c535454bf3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Use controller.mdsal.version when appropriate

Use the property controller.mdsal.version when looking for mdsal
artifacts from org.opendaylight.controller.

Otherwise, it's confusing since mdsal.version actually referrs to
artifacts from org.opendaylight.mdsal.

Change-Id: I9571969998a04a0fdae65eb61ffab414b45ee60d
Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

Bug 4550 - always rebuild security group rule in security group

The change set of 906836c289a7e4c3d33669d90515d77e75cfb6d,
the effort transparent neutron northbound api, caused not to update
security group rule in security group.
So always rebuild rules in NeutronSecurityGroup and keep
security group rule in security group of yang model empty list.

openstack service provider that uses MD-SAL should not use
security group rules in security rule. But it should listen to
data change notification on security group rules.

Change-Id: I7da2e23d9c45549d2f5d138dfea148e36bd8061b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Bug 5431: Fixing bug & adding new tests for code coverage"

Merge "Added PortSecurity attribute support"

Merge "Bug 4354 -fromMd() doesn't convert tenant_id to neutron object"

Merge "Bug 5431 - Fixing bug & adding new tests for VPN files"

Merge "Bug 5431 - Fixing bug & adding new tests for LB files"

Added PortSecurity attribute support

Added portsecurity extension as augmentation for backward compatibility
Refer - http://developer.openstack.org/api-ref-networking-v2-ext.html

Change-Id: I75523702f6b1e83f192587396e3d103e507872d3
Signed-off-by: Dileep <dileep.ranganathan@intel.com>

Bug 4354 -fromMd() doesn't convert tenant_id to neutron object

L2 Gateway and L2 Gateway connection doesn't convert
tenant_id to neutron object properly. Adding a test case
to improve coverage. Fixed a test case to use proper
UUID format.

Change-Id: I92518fbffe5ee01c68c2bea79cb7299330737f4a
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 5431: Fixing bug & adding new tests for code coverage

Fixing parameter type in @GET function in
some NN API and adding new tests for NN API
files. Increased code coverage ~ 20% for these files

Change-Id: I63a871b7fc0270e325da0d03ef991c5aaa6f8843
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 5431 - Fixing bug & adding new tests for VPN files

Fixing parameter type in @GET function in IPSEC
Site Connection and VPN NN API adding new tests
VPN files.
Increases code coverage ~20% for these files

Change-Id: I7061735fec84bedc1bae210dcfa4bc7b5df464c0
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 5431 - Fixing bug & adding new tests for LB files

Fixing wrong parameter type in @GET function in
LB NN API and adding new tests for LB
files. Increased code coverage ~ 20% for these files

Change-Id: I4a5c373fc199c868655f6fef6be581cef761d24a
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 5431 - Fixing bug & adding new tests for firewall file

Fixing parameter type in @GET function in
firewall_policy NN API adding new tests for firewall
files. Increased code coverage ~ 20% for these files

Change-Id: Ic73601e99d91d6e67b7db7852c5e1f07974b300b
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Adding new test cases for Security Group and rules API

Adding a helper function to iterate over the JSON
string used during create to extract key values
pairs and then invoke GET with query with that
key value pair. Updated security group and security
rule tests to call this new tests. ~15% Code coverage
improvement with these new tests for the two files.

Change-Id: Ib9a8878a49feb0d897f8d67b50ca2f2429dc8341
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Merge "Bug 5210 - GET/DELETE L2GatewayConnection with optional portId"

Merge "maven version requirement is 3.1.1"

Bug 4944 - Fixing a QueryParam name typo

QueryParam  string is wrongly called shared when it
should be admin_state_up. Added test for checking
response of a query in a collection and added
testcase for reproducing the bug. Changeset
445690e94dd990ad6d117b4d7c86e95b8bf9392b
in stable/beryllium fixes the same issue.

Change-Id: I2e5a40ed392d57d9f1d61696910ad3613cdb206e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 5210 - GET/DELETE L2GatewayConnection with optional portId

Removed getNeutronInterface method, using getNeutronCRUD instead.
Changed PortId null check to avoid NPE.
Added test cases with optional PortId.

Change-Id: I68c118fbcdde8b24cc4210bb54d7cee7c8fc9139
Signed-off-by: Dileep <dileep.ranganathan@intel.com>
(cherry picked from commit 82bc8d9b594e17a904c4a72dd251b886e4698fc7)

Merge "Bug 5037 - Adding tests for L2 Gateway Connection API"

Bug 5037 - Adding tests for L2 Gateway Connection API

Adding tests for L2 Gateway Connection Northbound API.
Patch also contains fix for a typo
in the NeutronL2gatewayConnectionNorthbound file.

Change-Id: I257008bfe0a897eb778cc6916a15261b8bca0612
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
(cherry picked from commit 3d9691433d3e4f25f1168802d57b96471129e407)

maven version requirement is 3.1.1

As maven version is 3.1.1 or newer, set to it.
Although this doesn't harm much, this patch is for consistency.

Change-Id: Iae7cd197bb6c18e7a308d8acfce9574653dfa6b9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Adding tests for L2 Gateway Northbound API"

Merge "Bug 5278 [BORON] Remove checks that require neutron providers for L3 and others"

Adding tests for L2 Gateway Northbound API

Adding tests for post, put, get and Delete API's

Change-Id: Iaa8412a48f03a90cee715b65d49c6e17dd4cb77c
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
(cherry picked from commit b4f14c65faa90889dfbb4274d7a40e6b7468eb27)

Bug 5278 [BORON] Remove checks that require neutron providers for L3 and others

DO NOT MERGE in Beryllium.
This patch is follow up of 49479f5244ac3c7a9a2fc06f7bbb0fed9ca3b203
It missed L3, lbaaspools, and Metering Label.
This patch includes also related code clean up to use this.getInstances().

Change-Id: I82c3330dd16309fe9d6bf90e96b371ddafa9a12a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Adding more test cases to increase the code coverage of Neutron tests

Refactoring the code for collection tests to remove the wait from the test
Fixed the required changes

Change-Id: If6ff2851e26836cde25161ba43aade0d10448a91
Signed-off-by: Pramod <pramod.raghavendra.jayathirth@intel.com>

BUG-5137: extraroutes in router not working

Neutron API defines extraroutes as list of destination and nexthop but in
neutron-l3.yang they're defined as list of strings. So, when these routes
are present in a router object sent by openstack we are unable to store
them in MDSAL. Fix is to change the type of routes in l3-attributes to
match with what Neutron API sends us.

Change-Id: I83519edcbdf6f4fcae34ae9650cf8ede40256296
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
(cherry picked from commit 59f3919dd01797fb056fa5dcdebda2076a936954)

Add more tests to improve Code Coverage for Neutron Load balancer related files

Change-Id: If940948c993930f47840c935f14bcd039d7f5ba8
Signed-off-by: Pramod <pramod.raghavendra.jayathirth@intel.com>
(cherry picked from commit 492923ba34786b212e263cb84f452e26659be15d)

Bump yangtools to 1.0.0-SNAPSHOT

Change-Id: I74de7043fe75c081f6d5a8b8b686fb3e9516aacd
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

[BORON] Remove checks that require neutron providers

DO NOT MERGE in Beryllium.

- Remove exceptions caused when there are no I*Aware providers registered

Patch set 2: Make I*Aware interfaces deprecated in a separate gerrit [1]
Patch set 6: Rebase and use AbstractNeutronNorthboundIAware

With this change, we take one step closer to the desired goal of making
neutron northbound md-sal based. By Boron, ODL applications will be expected
to access all neutron northbound related data via the API provided by
the corresponding yang data models.

[1]: https://git.opendaylight.org/gerrit/#/c/27297/

Change-Id: I15ae07ff85620b3ceaf9e13b6aa386ec0aa669b0
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Bump versions by 0.1.0 for next dev cycle

Change-Id: Ia84b1a7e2860e4af71b119b7f0f9e98cf40d51e6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add more tests to improve Code Coverage for VPN related files"

Merge "Add more tests to improve Code Coverage for Load Balancer related files"

Merge "Add more tests to improve code coverage"

Merge "Add more tests to improve Code Coverage for Metering files"

Merge "Add more tests to improve Code Coverage"

Enhance Neutron Firewall tests to get better code coverage

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~15% in the files covered.
Also reverted the changes made to existing tests.

Change-Id: I8da4c7b7058915bb1c23a857b5f85d4281c3700e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Add more tests to improve Code Coverage

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by 12% for these files

Change-Id: Ib80bd954ce2373fc13d36191d27e2bdb06f74a39
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Add more tests to improve Code Coverage for Metering files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~13% in these files

Change-Id: I2c55ee615e432280c73e3ee643e476a7528fef8e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Add more tests to improve Code Coverage for Load Balancer related files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~15% in these files

Change-Id: I7fff8a65b3a33bab5f97a9480fee177982add169
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Merge "Bug 4845 - prefix neutron stuff to model bundle name"

Add more tests to improve Code Coverage for VPN related files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~17% in these files

Change-Id: Ia256aa2df4f0be138e6683c3dd0b42c8f42a724b
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Add more tests to improve code coverage

Adding new tests 1)update and 2)get with query achieved more
functional coverage. Moving the collection_get_test later after the
nodes were created helped getting more condition coverage in
listGroups and listRules functions. Improved code coverage from
66% to 80% for NeutronSecurityGroupsNorthbound and
42% to 70% NeutronSecurityRulesNorthbound.

Change-Id: I56708a0c1c66158dd29784a9a2edd99e5749077e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 4848 - Remove provider attributes from top neutron container

Provider attributes should not be under top neutron container.

Change-Id: I0369d651f9791d3077cf65fed2b6509a598dc7aa
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>

Bug 4845 - prefix neutron stuff to model bundle name

Add maven-bundle-plugin build plugin in POM to generate proper
bundle name.

Change-Id: I95821608ffe3acc63ced3c153bd880d404f4ff3d
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>

Merge "Bug 4818 dnsNameservers not stored in subnet MDSAL"

Bug 4838 - add missing LICENSE file

This patch adds a LICENSE file to show the terms of license explicitly.

Change-Id: Ie1732ea1b523220bb5a582e858a6dec6d279464e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4818 dnsNameservers not stored in subnet MDSAL

NeutronSubnet.initDefaults() wrongly initializes dnsNameservers even if
user passed a value. There should be a null check and initialization should
be done only if user didn't pass anything.

This adds check for dnsNameservers and improves the test cases in NeutronSubnetTests

Change-Id: Ibade65f18a65b9c8e6c0a26de02bbbbbe5cac0b7
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Bug 4805 add host_routes info to MDSAL"

Merge "Bug 4829 - ITNeutronE2E.java: connect test cases for bgpvpn"

Bug 4805 add host_routes info to MDSAL

Transcriber is missing code to add hostRoute information to
MDSAL when Subnet is created/updated.

This change adds code to toMd() and fromMd() to handle hostRoutes.

Change-Id: I7b7b7dc5092971d86aec38e5365518712d84e8c2
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Bug 4797 - prefix neutron stuff to model bundle name"

Bug 4829 - ITNeutronE2E.java: connect test cases for bgpvpn

Somehow testsets for bgpvpn isn't connected to ITNeutronE2E
so that it isn't run by CI.

Change-Id: Ib125ffcef2ea2d69f45b3166ff41028292618ce9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Bug 4775 - handle cases when tenant-id is an empty string"

Merge "Bug 4816 - Change common attributes' descriptions into resource neutral"

Merge "Bug 4807 fix destination type in subnets yang"

Bug 4775 - handle cases when tenant-id is an empty string

Enhanced transcriber to check cases when tenantId is an empty
string. Previous check were only looking for cases when tenantId
was null.

When ODL is used with l3 agent and l3_ha, subnet/network created
for handling keep alive traffic contains tenant id set to "".

Patch set 2: code review: Simplify changes by adding logic for
checking on empty string at the base object (NeutronObject).

Patch set 3: code review: Remove check in toMd of NeutronPortInterface
because it is no longer needed.

Patch set 4: add UT

Change-Id: I05b61d74fff9c1d4fe373446f60cf0bd98a54e14
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Bug 4789 - model allowed address pairs"

Bug 4816 - Change common attributes' descriptions into resource neutral

status, admin-status-up and tenant-id attributes are used by
many object types. Their descriptions should not be network
type specific.

Change-Id: Iaa671329e48fbc690aaefcc6ee99215730cc9703
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>

Bug 4807 fix destination type in subnets yang

host-routes attribute of subnets has destination
field defined as type inet:ip-address. As per Neutron
APIv2 spec it should be of type CIDR

Fix is to change it to ip-prefix

Change-Id: I0c8653b2e24eac06d98c5afd679a0a70d6669e3b
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Bug 4797 - prefix neutron stuff to model bundle name

Add maven-bundle-plugin build plugin in POM to generate proper
bundle name.

Change-Id: I05948de9feaace567d099c4147dda884aedfbec4
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>

Bug 4789 - model allowed address pairs

Allowed address pairs doesn't include port id according to neutron spec.
actually ip_address is ip address or network address.
So for simplicity, networking-odl should pass always pass network address.
in case of ip address case, address/32 will be passed.
This patch should be merged after
https://git.opendaylight.org/gerrit/#/c/31402/
is merged

Change-Id: I40b0142cd9a1af8fd30d1fa987ae7b8a5fa49db2
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Drop properties from features.xml"

Merge "Bug 4745 - extra dhcp opt: neutron API updated to include ip_version"

Drop properties from features.xml

features-parent allows properties to be replaced with {{VERSION}} in
many places in features.xml; this helps clean up odlparent.

Change-Id: I38ef9c8668c92f9e1aced7466db110bf7626a6f7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4745 - extra dhcp opt: neutron API updated to include ip_version

Exception occurs as follows with the context of extra_dhcp_opts.
Neutron API of extra_dhcp_opts added ip_version to distinguish ipv4 and ip6.
It needs to be handled, otherwise exception occurs.

create/update port with extra_dhcp_opts
    "extra_dhcp_opts": [
      {
        "opt_value": "pxelinux.0",
        "ip_version": 4,
        "opt_name": "bootfile-name"
      },
      {
        "opt_value": "123.123.123.45",
        "ip_version": 4,
        "opt_name": "server-ip-address"
      },
      {
        "opt_value": "123.123.123.123",
        "ip_version": 4,
        "opt_name": "tftp-server"
      }

> 2015-12-08 10:06:30,307 | ERROR | v2/neutron/ports | ContainerResponse                | 47 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.IllegalArgumentException: All keys must be specified for class org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.port.attributes.ExtraDhcpOptsKey. Missing key is getIpVersion. Supplied key is ExtraDhcpOptsKey [_optName=bootfile-na
> me]
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
>         at org.opendaylight.yangtools.binding.data.codec.impl.ValueContext.getAndSerialize(ValueContext.java:46)
>         at org.opendaylight.yangtools.binding.data.codec.impl.IdentifiableItemCodec.serialize(IdentifiableItemCodec.java:124)
>         at org.opendaylight.yangtools.binding.data.codec.impl.IdentifiableItemCodec.serialize(IdentifiableItemCodec.java:31)
>         at org.opendaylight.yangtools.binding.data.codec.impl.KeyedListNodeCodecContext.serialize(KeyedListNodeCodecContext.java:80)
>         at org.opendaylight.yangtools.binding.data.codec.impl.BindingToNormalizedStreamWriter.startMapEntryNode(BindingToNormalizedStreamWriter.java:156)
>         at org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.port.attributes.ExtraDhcpOpts$StreamWriter.serialize(DataObjectSerializerPrototype.java)
>         at org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.ports.attributes.ports.Port$StreamWriter.serialize(DataObjectSerializerPrototype.java)
>         at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry$DataObjectSerializerProxy.serialize(BindingNormalizedNodeCodecRegistry.java:295)
>         at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry.toNormalizedNode(BindingNormalizedNodeCodecRegistry.java:106)
>         at org.opendaylight.controller.md.sal.binding.impl.BindingToNormalizedNodeCodec.toNormalizedNode(BindingToNormalizedNodeCodec.java:133)
>         at org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.put(AbstractWriteTransaction.java:39)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.updateMd(AbstractNeutronInterface.java:177)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.addMd(AbstractNeutronInterface.java:151)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.add(AbstractNeutronInterface.java:360)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface$8.action(AbstractNeutronInterface.java:370)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface$8.action(AbstractNeutronInterface.java:367)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.chainWrapper1(AbstractNeutronInterface.java:94)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.add(AbstractNeutronInterface.java:366)
>         at org.opendaylight.neutron.northbound.api.AbstractNeutronNorthboundIAware.create(AbstractNeutronNorthboundIAware.java:64)[235:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at org.opendaylight.neutron.northbound.api.NeutronPortsNorthbound.createPorts(NeutronPortsNorthbound.java:247)[235:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at sun.reflect.GeneratedMethodAccessor99.invoke(Unknown Source)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_45-internal]
>         at java.lang.reflect.Method.invoke(Method.java:497)[:1.8.0_45-internal]
>         at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1511)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1442)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)[174:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)[174:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)[174:com.sun.jersey.servlet:1.17.0]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)[142:org.apache.geronimo.specs.geronimo-servlet_3.0_spec:1.0.0]
>         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.Server.handle(Server.java:366)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:982)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1043)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.

Change-Id: I6f2713ad6baedd60be58dbd38ca420906157810a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "L2gateway: Added yang, APIs,Transcriber for L2gateway."

L2gateway: Added yang, APIs,Transcriber for L2gateway.

Patch Set 4: Removed I*Aware related code, Addressed review comments.

Patch Set 5: Aligned code with merged changes. Addressed review
comments.
Openstack Neutron API:
https://github.com/openstack/networking-l2gw/blob/master/specs/kilo/l2-gateway-api.rst
Patch Set 8: fixed the review comments

Patch Set 9: fixed the review comments

Change-Id: Icfc93bc39f56f6b103b13834359128f29df804b9
Signed-off-by: raveek <raveek@hp.com>

Bug 4188 - null pointer exception in NeutronSubnetInterface.addSubnet()

When subnet is updated, the following exception happends.
This is because the corresponding network isn't always created before
subnet creation depending on situation.
The order of creation/update of network and subnet can be reordered.

In fact subnets list of network in MD-SAL isn't already well-maintained,
and it can be calculated from list of subnets with its parent network uuid.
Actually Openstack Neutron db generates subnet list by foreign key
with ORM mapper. So it makes sense for ODL neutron northbound to
eliminate subnet list instead of maintaining subnet list correct.

> 2015-08-20 14:10:21,025 | ERROR | p492280269-15502 | ContainerResponse                | 195 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.NullPointerException
>         at org.opendaylight.neutron.transcriber.NeutronSubnetInterface.addSubnet(NeutronSubnetInterface.java:118)
>         at org.opendaylight.neutron.northbound.api.NeutronSubnetsNorthbound.createSubnets(NeutronSubnetsNorthbound.java:218)[373:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)[:1.7.0_79]
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)[:1.7.0_79]
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.7.0_79]
>         at java.lang.reflect.Method.invoke(Method.java:606)[:1.7.0_79]
>         at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1511)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1442)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)[196:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)[196:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)[196:com.sun.jersey.servlet:1.17.0]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)[159:org.apache.geronimo.specs.geronimo-servlet_3.0_spec:1.0.0]
>         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.Server.handle(Server.java:370)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:982)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1043)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at java.lang.Thread.run(Thread.java:745)[:1.7.0_79]

Change-Id: Ie7861ae292ee7a1666505f0901cad99fb29a9ff3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge changes from topic 'bgpvpn-fixup'

* changes:
  use INeutronObject instead of NeutronObject where possible
  bgpvpn: simplify bgpvpn related code
  northbound: Split out AD-SAL logic from AbstractNeturonNorthbound

remove unused ConcurrentHashMap

The variable somehow was missed to be deleted.

Change-Id: I9784b64ee7b32154241d0efe183756e60404b251
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

use INeutronObject instead of NeutronObject where possible

Change-Id: Id5abdaa58af68985d4ec88ecfd4a1e0c9a60b653
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

bgpvpn: simplify bgpvpn related code

This patch simplifies bgpvpn related code.

Change-Id: I36fdb996d4b20dfb1319ec11fe815a882b1bed85
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northbound: Split out AD-SAL logic from AbstractNeturonNorthbound

This is a follow up patch for
  changeset of 43f88bf737adcb2e5df9e106d8b491de1549c41d
  change id of I3de3f9461047363501f0e3a6428580f93402c65b
  Neutron*Northbound: consolidate crud logic
and
  changeset of aafe31458a9990f50023566aed7f7b296b95067c,
  change id of I2c36c104dbd6c891a36c10419ed28d8060958d29.
  BGPVPN: Added yang, api and transcriber for BGPVPN

bgpvpn which was newly introduced after AD-SAL deprection doesn't implement
AD-SAL. So the class of NeutronBgpvpnsNorthbound requires its super class,
AbstractNeutronNorthbound, not to use AD-SAL.
This patch factors out ad-sal logic from AbstractNeutronNorthbound
into new subclass, AbstractNeutronNorthboundIAware with minor compilation
adjustment.

Change-Id: I9ce990558f178f1571cfac9760dd333b5b40174f
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Neutron_ID: check uuid string format

This patch adds check of uuid string format.
also it removes unnecessary String.valueof for consistency.

Change-Id: I340e2098a9f237b35c1072192adf37d265e56f65
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Align BGPVPN code with merged changes

Change-Id: I508a718ed2a9063d83ddff276dc8cb2848d583cd
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "BGPVPN: Added yang, api and transcriber for BGPVPN"

Merge changes from topic 'northbound-refactor'

* changes:
  Neutron*Northbound: consolidate crud logic
  NeutronObject: add initDefaults() method to NeutronObject

Merge "Changes to prepare for MOXy 2.6.x"

Merge "northgound: Make Neutron*Request implements INeutronRequest interface"

Reversion yang model

With the yang model cleanup, we really need to reversion it.
This patch will need notification of downstream projects

Change-Id: Iba70ab1a2ac66e9e0e880dd5384966ac2f77b7a9
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Bug 4365 - Null pointer exception at org.opendaylight.neutron.spi.NeutronNetwork.addSubnet"

Merge "Fixes Bug 4379"

Merge "Fixes Bug 4345"

Merge "Bug 4354 - neutron tenant_id doens't contain '-'(dash)"

Changes to prepare for MOXy 2.6.x

MOXy 2.6.x adds additional dependencies that need to be included.

Change-Id: I5ababbabef78f1eaf7a35d2fd0c2a76f5ae4c7de
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Bug 4365 - Null pointer exception at
org.opendaylight.neutron.spi.NeutronNetwork.addSubnet

Change-Id: Iff9b269aa99e6450e67edce718763e11ac4f4a9a
Signed-off-by: raveek <raveek@hp.com>

Fixes Bug 4379

Change-Id: Ia9ef5461bf44557e72c0a5932ed869d9a275cb52
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Neutron*Northbound: consolidate crud logic

This patch conslidates CRUD logic of Neutron*Northbound.
The refactor sorts out inconsistency between resources. As bonus,
all resources supports bulk creation now.

Change-Id: I3de3f9461047363501f0e3a6428580f93402c65b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

NeutronObject: add initDefaults() method to NeutronObject

Some of Neutron<Resrouce> classes defines initDefaults() method.
Define the method at the base class as preparation for code consolidation.

Change-Id: I4b3277c28aabd9bc94b2a5efeb3eb06ee749bf1c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northgound: Make Neutron*Request implements INeutronRequest interface

Some Neutron*Request class implements INeutronRequest and some doesn't.
Make all of them implements it.
This is preparation for code consolidation.

Change-Id: I3ceb4fc05b5e3e094be9854d6cd81bc05e6f00db
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge changes from topic 'bug/4143'

* changes:
  simplify NeutronNetworkInterface.networkExists()
  transcriber: make use transaction chain more