recover Fedora 20/21

Change-Id: Ic45ae69de0c04ebeb42d99fb1374765db7b731cd
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

add ubuntu support

Change-Id: Iaf0c4855b25373beea99346472a1ff3b6b1ad573
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Link to ODL homepage in README, clear headings

* Backticks for ODL in headings hopefully show class vs project

Change-Id: I46fc8847b4e1e8ff1f6416c1f7829d3e09a9caca
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

General cleanup of README

* Assorted small changes
* Noted Java dep

Change-Id: I0f5f12765ce35c742338cfbb20f22aacf456c48c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Tarball install method now stable, remove warning

* Relevant to #45 and others

Change-Id: I144e8f2402c80a33a7e7541652fc8663dc6123f1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

RPM sets odl user's home dir to `/opt/opendaylight`

* There's no trailing slash! Having one == Beaker fails.
* May want to fix this in future version of RPM?
* Relevant to #66

Change-Id: Iac2826ac38d53430d9aec8c2e5bd2b5a9734e3e4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Clean up file name endings (trailing slash or not)

* Was causing some strange dep cycle test failure

Change-Id: I08b4ae169a753eb527525a5067f7acd0567b420f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Remove ODL version from ODL dir name

* Follows change made by RPM
* Relevant to #66

Change-Id: I6ad56a8e47418bc98f7b6415fd77173aeccc1aa7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Move from pre-PR fork to official rspec-puppet

* Closes issue #16
* This commit has an interesting back story, see issue

Change-Id: I4a40fb133f8b06c33def54d75b4e51465895519e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Beaker tests, including tarball install ones

* Closes #45

Change-Id: Ifb3b024163a06eaf70fb9077c23dae4a72a0c3a7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix two tarball Beaker test failures

* The tarball extract isn't idempotent, don't assert it is (#45)
* We're no longer setting modes, don't assert one

Change-Id: Ic73092c2814ab6243880f171670fa0a965428ef2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Do all tarball Beaker tests with a tarball install[

* Used to do install tests with correct tarball/RPM method, but
all other tests with always-RPM method.
* Relevant to #45

Change-Id: I76eb3bc47c3c80e9ed133dba52e33e77375d273e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Don't set Karaf config file mode, leave default

Change-Id: I151792b62bd3a3bea9b8a6f96a551018555d1ec7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix Beaker test failure related to new mode config

* Related to #65

Change-Id: Ib6ffb32121ce4386ff17f798ade955fa85c68c5d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Don't set ODL archive mode, leave default

* Relevant to #65

Change-Id: I6743f8fc15ec464e813eab1b3c0d0ebd358c34f2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Minor in-line docs spelling fix

Change-Id: I27223dba7aaf91c3040a4aaeb41060316ddbbfc8
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Major update of tarball install Beaker tests

Move to totally different method of passing info about
which install method to test from rake command. We now
set env vars in the Rakefile, the access them in the
test context (not a helper) to get RPM xor tarball
behavior.

All tarball tests passing except a general one, debugging.

Large portion of #45.

Change-Id: I3ef3eeee6dc8999b1e93390ace162fc08f7be3d6
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix user/group/mod of features file (tarball only)

* A more specific file config was overriding ODL dir config
* Fixes some tests for #45

Change-Id: Ife6a7cbb89a0ed1823784ba6af43876100c74803
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Doc updates for install manifest

Change-Id: I067a8c502df419110207020d1ff7b6cf22b39d60
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Minor doc clean up in Beaker test helpers

Change-Id: Ie7221c0684ee07827eb511524fc8d46c214dd347
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add rpm flag to F20/21 Beaker host YAML files

* Without this, wouldn't be provisioned via RPM or tarball
* Relevant to #32 and #63

Change-Id: Ie196c943963e79bdae64854ca04a163a7db1bc17
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Ignore third-party code in rspec coverage reports

* Closes #50

Change-Id: I72f7c544b1ab44c6926898a29802c758986ea59c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add rspec-puppet tests for odl group

* Only relevant to tarball-based installs
* Closes #60

Change-Id: Ife790ed2678cb388e7a3aeabddad4fa094e7fd4b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add rspec-puppet tests for odl user

* Only relevant to tarball-based installs, RPM normally handles
* Closes #59

Change-Id: I58686f2c75d2471c2359c558b3cd135e7f20d3cd
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add rspec tests for systemd file owner/group/mode

* Relevant to #61

Change-Id: I497f732822a49b7354b5ead9cc92a8e0fc04144e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add rspec tests for ODL dir owner/group/mode

* Relevant to #61

Change-Id: I61ba5b104f1db1b70d1d0d4ae1f0d3cd86e08647
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update ODL and systemd tarball RSpec tests

* Recent code changes to these resources required test updates

Change-Id: I395ff38137c65b1c3c1faa04ed45e41ad12d653d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Set correct user/group/mode for ODL .service file

* Relevant to #62

Change-Id: Ia4f23a799a11812d65e45ae96e8c8da5ce1d1427
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Set correct mode (0775) for ODL dir

* Relevant to #62

Change-Id: I5b0a89ff746bee4088922223dc872e3e1fdfb441
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Set user:group to `odl:odl` for extracted ODL dir

* Needs testing
* Relevant to #58

Change-Id: Ib41860a248894d2a8a9f34748894891d87baa743
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Create odl group during tarball installs

* Relevant to #51

Change-Id: I4eecea456d9db7e46b03307f07c7182366921d10
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add and configure odl user during tarball installs

* Relevant to #51

Change-Id: I440c65a8e4e3e6f3bbaba76063448f0e74b42071
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Separate rake tasks for tarball/RPM Beaker tests

* Create rake task to run Beaker tests against CentOS 7 tarball install
* `rake centos` still runs Beaker tests against an RPM install Cent7
* Closes #54

Change-Id: I93ceb97ac2e358807bb81cedb0e3b71aca679d1b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Switch to camptocamp-archive in Beaker tests

* Relevant to #45

Change-Id: Iff94527103416b46ea9f820beb699d33702eef81
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Install Java Puppet mod in Beaker test hosts

* Related to #45, #56

Change-Id: I232bb3b31a89c0da69dd5d4f16496b0027c906c2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add OS release fact required by Java mod #56

Change-Id: I296c8f6e65c8357f75e5b008035451071a286fee
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Install Java during tarball-based installs, test

* Use Java Puppet mod to install Java OpenJDK 7
* Add RSpec tests to verify Java install
* Only applies to tarball installs, otherwise handled by RPM
* Relevant to issue #56

Change-Id: Ie34b63099a654a672759671c1e13a4f993bc8dbf
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Java Puppet mod dependency for tarball install

* Relevant to #56

Change-Id: I471927e458a17a3b08e0d02ccc760901a7d19192
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix systemd unitfile archive download/extraction

* Required by move from gini-archive to camptocamp-archive
* Wouldn't get an opendaylight.service file without this patch
* Relevant to #52

Change-Id: I9d90f1cc6348d9f68caa9d3128b777f570adf8f9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Adjust archive target param for camptocamp mod

- Need one more dir level in this situation
- Related to different implementation of strip-components
- See https://gist.github.com/dfarrell07/e5898d01fb94b5ded6d1

Change-Id: Iaaed92bce003a4f1b210984e8968bdef2fda7555
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add $::path fact to tests, required by archive mod

* The camptocamp-archive mod uses $::path for calls to various execs
* gini-archive accepted a default path param, so this wasn't an issue
* Not having this will cause compile tests to fail

Change-Id: I244732f91b2cd1c5ea8687fb7ccdb77e387f8b5a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Move to pre-PR fork of camptocamp-archive mod

* The fork is under development (adding strip_components flag)
* A PR will will submited to merge it back into camptocamp-archive
* Relevant to #52, #53

Change-Id: I9c6514a58de25df67d1e635f040f9da9d482fa74
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update install manifest's inline docs

Change-Id: I05ea868498f84fc1e49ee285204b1078be31364c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Ignore log files

Change-Id: I0ad3db62ed20b4efd4f7120b815ef5e8e06fab33
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Added some missing commas in README example

Change-Id: I2eb5beb1edf2a2536ed36fd815977123ae30a046
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Override timeout param (120 to 600s) in tarball dl

* ODL is a large download may legitimacy not finish in 120s
* See issue #53

Change-Id: Ie82c3edd92626b379354c84091b8f2701018fcc5
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Added note to README about tarball instability

* Tarball-based installs not recommended at the moment
* RPM installs fine
* Relevant to #45, #51, #52 and #53

Change-Id: I2960edaf99f42992a3ab07cfffbe9d978ca56aaa
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

General refactoring of Beaker tests

* Restructured install method tests
* Actually apply the manifest for a tarball install
* Minor single/double quote cleanup for consistency
* Moderate in-line doc updates
* Relevant to #45 and #51

Change-Id: I306004decc31d2536b600a1d55808c5604931cb9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Refactor Beaker tests by extracting odl install

* Punts applicaiton of manifest to install odl to a helper
* More Ruby-ish default params for odl install and Karaf features checks
* Doc'd that odl class, RSpec and Beaker tests must sync default params
* Relevant to #45 and #51

Change-Id: I67d373ec87f2c81f35b301463f0803577c0c7928
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Refactor Beaker tests, extract helper fns

- Relevant to #45 and #51

Change-Id: I3d40fc362323d00fc732f9c5b7f8a2fbf5bd0732
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Verify absence of RPM stuff in tarball installs

* These are RSpec tests only, not Beaker
* Relevant to #44

Change-Id: I6f12dd7c5754ae9b5596c20fd6bdef79ad8f7689
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Initial Beaker test for tarball install

- Relevant to #45
- Found #51

Change-Id: Ic15fbf50992f2e371d0640ad67fb78ef95dcd889
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add RSpec tests that pass unitfile/tarball URLs

- Relevant to #44

Change-Id: I347a1cc2d2fea28f99fe69a88be21aa84c1a4553
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add RSpec tests for install_method param

- Pull RPM-based install logic into dedicated fn
- Add tarball-based install logic
- Closes #44

Change-Id: I52aa83ef201a202db1c37686fcbce3fb433f9f57
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Split generic test and Karaf feature test helpers

- Add calls to generic tests in supported OS contexts
- Call both helpers in Karaf feature contexts
- Now have test parity with pre-refactored RSpec tests
- Closes #43

Change-Id: I69b6e4dddd385566aa67cc6ba4c3d032a88b3169
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Docs and unused var cleanup in RSpec tests

Change-Id: I57ed94bf0b709b800d55c9f902820c91bf8fdb6e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Karaf feature tests to refactored RSpec tests

- Relevant to #43

Change-Id: Ibd34a4524cc9bce4a8691cec1a7225c7f572355b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Refactored rspec tests now passing

- Relevant to #43
- The word 'class' must not appear in `describe` strings
- `let` statements aren't inherited by child contexts

Change-Id: I6e2c856580126c5036f14129a19ceb6f57fe2cf3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Major refactoring of README install method section

Change-Id: I3ec8f4220af833ce8ab313568432e2b59e364511
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Major refactoring of README usage section

Change-Id: I9cf2aeb6f3b9e19ff8dd44705a68d9321129bae4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updates README to document ODL rest port param

- Relevant to PR #35
- Closes #46

Change-Id: If5b2ef439a45c431f797606ca5dbfc7852925eb2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

General refactoring of in-class docs.

- Touches most manifests' class-level docs.
- Closes #49

Change-Id: I39c1f9f904cbee3166a05a7cae12af315accb8b9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Fix adds the ability to change ODL rest port.

This is needed as an option due to the fact that that if running ODL on
the same node as Swift in OpenStack there will be a conflict with ports.
Hence its a good idea to have it as a configurable option when
isntalling ODL using this puppet module.

Change-Id: Idb87f862b6ff92bf1f0289b81327319eb09e1ecb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Added parameter for odl_rest_port

This is needed when combining with openstack as swift already uses
default 8080 port. odl_rest_port configures tomcat to change REST
API listen port.

Change-Id: Ief9af904a41ed74a1bdf923aaab1da15169c28a2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Initial refactoring of test structure

- Currently only have OS-related tests, will add others back later
- Currently broken, no idea why, very obtuse syntax error

Change-Id: I704c3810acfcca2bb450f5dfda8a6bda2c8ad698
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated README with tarball-install docs #41

Change-Id: I8c41e69044e9c96e7ee8646f40589b14371352a5
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Inline doc updates for tarball install #41

Change-Id: Ib96ecd7a3a5f68d3f12b14f31a3b39e79d118308
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated in-code ODL class param docs

- Closes #29, relevant to #41

Change-Id: I2cd6d0e57fef224fd0a1ac83b88266b4f11a6e09
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Install systemd unitfile during tarball installs

- Pulls opendaylight.service from same repo as RPM
- Adds param for unitfile URL, so it can be overriden
- Tarball-based installs should mostly work now
- See #41

Change-Id: Idf57828330b6bedddada93c28f570666f1c7d890
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Refactors how install method is selected

- Adds an `install_method` param to choose method
- Still accepts tarball URL
- See #41

Change-Id: Ib1e11044063b23b2f3d91a4b3fd32d837f376de9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Initial ability to install from tarball

- Added dependency on gini/puppet-archive
- Would use camptocamp/puppet-archive, but it can't strip tar root dir
- Not currently pulling systemd .service file, so service broken
- Will refactor params for archive-installs in future commits
- See issue #41

Change-Id: Ib157f055fe0b7ea3bc6384af05e2107ac9c4c1ec
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Removed unnecessary class doc in README. #1

Change-Id: Id2f7cd3d3912896a1692e4a9d9b2421197e38c40
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Major README update. See #1

Change-Id: Iebd79b874a00d9fb170575be6387aeb9fab99973
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Revert "Report test coverage via Coveralls"

- Doesn't report real results for Puppet mods

This reverts commit 4dcc10cfe81fa1e8ec317b86222bc97bac647616.

Change-Id: Id6be50c2793ebb15609f18789b498f1f8d0cfd28
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Report test coverage via Coveralls

Change-Id: I3121879ba48c24fd2969503e466f034108ab2b0a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Template var scope maybe-fix. See #40

Change-Id: I1668baf90de12d343edbd4d9e3153b7faf8a8f30
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Add Beaker tests for default/extra Karaf features

- Closes #30

Change-Id: I3e7bc2380b8a4d33c9bbefaa67d0cf0d6da1ddac
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Minor clean-up of unused (commented out) code

Change-Id: I92095c219b0801141d43555eb029a96f913117a8
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Put Gitter badge on same line as others

Change-Id: I29939a67a59849d7f6b52e27d3edc58d62560594
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Added Gitter badge

Change-Id: I7c4c47dd367b344cb695a94a544203814ccec66f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Use readable multi-line hashes. Closes #36

Change-Id: Id651f4ae1076ad0c0cdeb83705eeaef2e29171e4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Bumped version to 0.1.0

Change-Id: I0f9d11cae74d2480e62049d64c60306f0afa6a42
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Don't have Travis test Ruby 1.8.7 #34

Change-Id: I87a5c24b273c70df84bf9a1d85d541f94c741492
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Accept default/extra features as diff class params

- The odl class now provides reasonable defaults that
can be overriden, as well as an extra_features param
intended for installing features in addition to defaults
- Added (many) rspec-puppet test to cover this feature
- Closes #26, closes #25

Change-Id: If9d62422b4401ac7c9df11629ff807bd3fa56d6f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Minor refactoring of shared supported OS tests

Change-Id: I7f0a4bd36a956e93d4ee64114f592a6afa19da5c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Initial tests with params, relevant to #25

Change-Id: Iebe8f02d47e087c9873030d15e6abe7d931545a7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Upgrade from Helium SR1.1 to SR2. Closes #31

Change-Id: Ic7bfc988636d9a034a2deb3b280231ad2ecc96a5
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Update ODL user home dir per new RPM

Change-Id: Idaba466bcf19a0d61c5f951554d8ce9ca5d5cf4c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Cleanup of metadata.json. Closes #24

- Added compatible Puppet version info
- Minor edits to summary and OS version formats
- Added tags list required by the Puppet Forge

Change-Id: Icd822b0e8d80c2820be519b61cf9da21915039b6
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Remove unused Modulefile, rely on metadata.json

Change-Id: I5d8dfc08c4e4d94a8f785191ceaa69993041f461
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Moved to semver syntax for stdlib deb. Closes #18

Change-Id: I237d9999785bb96cb840decefc501b2cf2e80fc3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Merge shared tests for unsupported OSs and OS families

Change-Id: I3b147fc1cfd2483cb66049227a6723e815be03cb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Share test logic for unsupported OS families #17

Change-Id: I05e583930db11d8c1241db25ea58b15946339ef9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Share test logic for unsupported OSs #17

Change-Id: Iea1fc8d4058ad0d569157321e5eeb157915b38d1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Removed deprecated tests dir. Closes #22

Change-Id: Ia23c1a3ea30464c3d171da31482b0ac10e641be2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Removed unused lib dir. Closes #20

Change-Id: I504b403ae5921da4dc921cd23d28e4a9285d4e1a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Removed unused static files dir

Change-Id: I8a56cc4b37e28896d390c7b479bff924846079bb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Extract common tests for valid OSs #17

Change-Id: I46e079030831026d7cef8f9b7e0ec212681a3b7e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

General refactoring of ODL class params

- Added param to accept Karaf features to install
- Removed unnecessary pkg/service name params
- Other minor docs cleanup

Change-Id: Ib0560197e5ab7d2a6b55cb957793fdbfa72cadde
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Added more Beaker tests for ODL dir/Karaf features file

Change-Id: I8097aa40bad5a387814a23f612d54ae980deb689
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>