Akshita Jha [Wed, 22 Feb 2017 10:01:08 +0000 (15:31 +0530)]
Add example playbooks
Change-Id: I26141d214a274c5d59834d110ce9ad0a8ec7dc7e
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Wed, 8 Feb 2017 07:48:07 +0000 (13:18 +0530)]
Create `requirements.yml` to install opendaylight role
Change-Id: Ie3e1b36f4682fd525e58b70b9743ad90d9109d00
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Sun, 8 Jan 2017 18:07:05 +0000 (23:37 +0530)]
Fix ansible-lint errors
Change-Id: I010ce114210a507ca560cfada4c45fefd8a5fc0b
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Mon, 12 Dec 2016 15:42:40 +0000 (21:12 +0530)]
CONTRIBUTING.md: Fix minor typo
Change-Id: I98fcec7353efcba3b708388a4843e4402962d604
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Sat, 3 Dec 2016 00:09:17 +0000 (05:39 +0530)]
Change `deb_path` to use remote URL instead of local path
Change-Id: I4fc94805ba54b6f19d98d01f6b2cfd926845d56c
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Fri, 2 Dec 2016 23:23:05 +0000 (04:53 +0530)]
Add .deb support to ansible-opendaylight
This commit checks the OS and then branches for either RPM or Deb installs.
It allows ODL to be installed in a debian based distribution (Debian or Ubuntu)
using a debian repo or .deb local/remote path.
Ansible version: 2.2.0.0
Tested for Debian 8.0 and Ubuntu 16.04
Change-Id: I341c9451352733c1138403cc558d30cfd7611423
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Thu, 1 Dec 2016 09:44:27 +0000 (15:14 +0530)]
Remove debug statements
Change-Id: I561cd2372fc2acc92dd8884c626565baab6e6052
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Akshita Jha [Thu, 1 Dec 2016 09:25:37 +0000 (14:55 +0530)]
Add .deb support to ansible-opendaylight
This commit checks the OS and then branches for either RPM or Deb
installs. This patch allows ODL to be installed in a debian distribution
(Debian or Ubuntu) via a deb repo.
Ansible version: 2.2.0.0
Tested for Debian 8.0 and Ubuntu 16.04
Change-Id: I5c238532c039543017af5c290b037df87eb942f2
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Wed, 30 Nov 2016 06:44:22 +0000 (12:14 +0530)]
CONTRIBUTING.md: Set IRC webchat link
Fixes https://github.com/dfarrell07/ansible-opendaylight/issues/25
Change-Id: I0aed5bb3175f9a7ba47411c5d928135a429fa104
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
srisankethu [Thu, 24 Nov 2016 09:54:12 +0000 (15:24 +0530)]
CONTRIBUTING.md: Add IRC channel information
Closes https://github.com/dfarrell07/ansible-opendaylight/issues/25
Change-Id: I7da3450e0c88c44cf17bd2a867d09565d747818f
Signed-off-by: srisankethu <sanketh.uppalapati@research.iiit.ac.in>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 21 Sep 2016 20:58:44 +0000 (16:58 -0400)]
Update default ODL version to Boron
Change-Id: Id7a5f47d678dec9b4c7a626a7a3e7de759c9d85f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 21 Sep 2016 18:09:11 +0000 (14:09 -0400)]
Prevent false failures during firewalld checks
Change-Id: I342fa3cfc1649b170b6bfd2452105dfc4d242a40
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 25 Jul 2016 18:48:22 +0000 (14:48 -0400)]
Add alt text for links, update maintainer info
Change-Id: Iff3063c9f8121feb379aed00caadee4c1b563eee
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 13 Jun 2016 21:20:37 +0000 (17:20 -0400)]
Change README markdown file extension
Change-Id: I7a6fe538eefd7277e899e3a1446f36ab01cbc073
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 20 May 2016 19:11:35 +0000 (15:11 -0400)]
Update default ODL version to Beryllium SR2 4.2
Change-Id: I2ef3a3c5a6798420eb4f935eab652ce2c128e44d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 20 May 2016 19:07:38 +0000 (15:07 -0400)]
Use task conditionals that work with Fedora 22+
Not sure if it was an Ansible or Ruby update that changed this, but
conditionals of the form `x in [1, 2]` fail with errors related to
template parsing. Changed the conditionals to logically equivalent ones
that use simple equality and conjunction.
Fixes #23
Change-Id: I4f76cc32fb6cd34253cd0b6374a933097ae04985
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Patrick Laurin [Tue, 26 Apr 2016 17:27:26 +0000 (13:27 -0400)]
Change 'yum' module to 'package'
Change-Id: I1a1f12bd2885e0197c544f7fb966b1714da777c1
Signed-off-by: Patrick Laurin <plaurin@inocybe.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 Apr 2016 01:37:05 +0000 (21:37 -0400)]
Remove deprecated update_cache package mod param
When moving from the yum module to the package module as a part of #22
and #19, the `update_cache` param became deprecated.
Deployments against Fedora 23 now work.
Change-Id: I92bacdfd7034bb9328bd5e0c1bc2027c617c7d39
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:30:49 +0000 (16:30 -0400)]
Add Travis CI badge to README
Change-Id: I0e9ec57046e585f37cae21c4a534adddd1f94c31
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:27:49 +0000 (16:27 -0400)]
Python line in Travis config is req'd for tox
Both the Python project type line here and installing tox in req.txt is
required for a working tox in Travis CI.
Change-Id: I54714a30634f30f99257252861b89b2b9b1bbefa
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:26:21 +0000 (16:26 -0400)]
Try removing python line from Travis config
Change-Id: I808c5f9b6a13872db1efb7601e99b725e36c5958
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:23:46 +0000 (16:23 -0400)]
Add tox to req.txt so it's installed in Travis CI
Change-Id: I63ce7e6c845a20d6b8bdad0279f89bb69e28bf98
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:21:29 +0000 (16:21 -0400)]
Update Travis cfg to install Tox on build box
Change-Id: Ic5d20051821ab6ab61707a7eef0aaf15a722218f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:17:31 +0000 (16:17 -0400)]
Add req.txt for installing ansible-lint
Change-Id: I9d1e760ccf3f2a3bde23d2aac0fda0dca0b3c0c7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:15:10 +0000 (16:15 -0400)]
Add tox dir to gitignore
Change-Id: I5a0e5427c5914f043dce212800910cff161367f1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:14:27 +0000 (16:14 -0400)]
Add Travis cfg for running ansible-lint in CI
Change-Id: Ia430773a5e8e722fc5d8db77f1eeb7ecabc3acb9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:13:52 +0000 (16:13 -0400)]
Add tox cfg for running ansible-lint against role
Change-Id: If4958e35976ba455b292a8384733855472a6788c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 20:12:45 +0000 (16:12 -0400)]
Add example playbook that uses this role
Change-Id: Ie600b3680c265ed158779cdeca000ae21f5208db
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 5 Apr 2016 19:46:31 +0000 (15:46 -0400)]
Use recommended file-absent method vs rm
The ansible-lint program complained about using rm to directly remove a
file, vs ensuring it's absent via the Ansible file type.
Change-Id: I3486b974b5ffd7f853aa252c7b89b92c60055665
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 29 Mar 2016 15:46:36 +0000 (11:46 -0400)]
Don't use template for Karaf feature config
Templates don't work well now that ansible-opendaylight supports
installing multiple versions of ODL (via rpm_repo*, for example).
The content of the tempalted file is completly replaced, when only the
exact line that needs to be changed should be managed and the rest of
the file should use the version's default content.
Changing the version of ODL installed via params also requires changing
the default Karaf feature repos to match the version. This is confusing
and unnecessary - no one uses this knob that I know of.
Change-Id: I4cbe53b0b1f91dd01b24d2672581e1f99f2bfccb
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 29 Mar 2016 13:46:26 +0000 (09:46 -0400)]
Update default ODL install to Be SR1 4.1.0
Change-Id: Iaa8f43568ea393db14ab5586d9ae83e7c3a8d940
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 28 Mar 2016 21:39:56 +0000 (17:39 -0400)]
Refactor logic for running in containers
New CentOS containers (7.2.1511 and not 7.1.1503) ship full systemd,
instead of using fakesystemd or not including it. It doesn't work
without modifying the Dockerfile and/or passing special params to the
`docker run` command, and it's generally not recommended for use in
containers, so we don't want to use it when provisioning a container.
The old checks were seeing systemd and (rightly so, it's installed) and
attempting to use it in containers. The new one directly checks if
running in a container instead of inferring from presence or absence of
systemd.
Change-Id: I9ee7c86c947396a3452a1c0b54d576bb9d512b47
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 22 Feb 2016 20:54:03 +0000 (15:54 -0500)]
Update ODL to Beryllium
ODL Li SR3 to Beryllium 4.0.0
Change-Id: I19efa52cb3cad0a34a3bd59eb74fe5e1a247c9ae
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 Jan 2016 20:01:30 +0000 (15:01 -0500)]
Add var to select .repo used for installing ODL
Defaults to Li SR3 repo config provided by upstream Int/Pack.
Can be overridden to install different ODL repo configs, and therefore
different ODL versions.
Other vars, like the karaf feature repos, would also need to be updated
if a different version of ODL is to be installed.
Change-Id: I33ee6cfe461d7dc1fda27a4107025faf6684b24f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 Jan 2016 18:51:17 +0000 (13:51 -0500)]
Update default rpm_path var to Li SR3
Closes #21
Change-Id: Ibf9f89485123ccb109d270303cddc5ffaeb0930d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 15 Jan 2016 20:46:54 +0000 (15:46 -0500)]
Update ODL Lithium Karaf feature repos for SR3
The 3-candidate RPM repo now installs ODL SR3, so the templated Karaf
feature repos need to be updated to find Li SR3 artifacts.
Change-Id: I610c075e5479061939c79bca1e6772c4c0304e1a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 11 Jan 2016 19:30:00 +0000 (14:30 -0500)]
Update ODL Lithium Karaf feature repos for SR2
The 3-candidate RPM repo now installs ODL SR2, so the templated Karaf
feature repos need to be updated to find Li SR2 artifacts.
Change-Id: I7354651d6048080491f0cc0b7760bd7f6f093677
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 3 Sep 2015 20:01:15 +0000 (16:01 -0400)]
Minor inline docs updates for default vars
Change-Id: If587261a0f8f05ecfca4d6d7803209e43533b404
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 15 Aug 2015 00:15:27 +0000 (20:15 -0400)]
Extract ODL install to a single task for clarity
Change-Id: I6f5055c954ab5d67b77d830a07f50ea6cf944d30
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 14 Aug 2015 17:51:26 +0000 (13:51 -0400)]
Officially support Fedora 21
Change-Id: I5c23d378c21f9546bfa87b84d5ed8c0d331cf484
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 14 Aug 2015 15:35:28 +0000 (11:35 -0400)]
Remove old, unused task
Change-Id: I81dc8ffe235f5a9a23c8853a13f1bc982c22c25c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 13 Aug 2015 20:35:35 +0000 (16:35 -0400)]
Confirm systemd intalled b4 using it in handlers
Change-Id: I6b8365b81e22aeb2b0bdd0172dee2b0a0348a15d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 13 Aug 2015 20:28:07 +0000 (16:28 -0400)]
Bugfix in check if systemd is installed
When systemd isn't installed, the `rpm -q` check exists with
a non-zero exit status (1), which is expected but interpreted
by Ansible as a failure. Tell Ansible that RC 0 and 1 are okay.
Change-Id: I75d5b7512a01001c46f7a9251f21bf772b7a9d4e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 13 Aug 2015 18:05:34 +0000 (14:05 -0400)]
Add skips for firewalld when systemd is missing
Change-Id: I92617366e70cb0341af98a8b775a3de82ce6cb11
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 13 Aug 2015 04:29:16 +0000 (00:29 -0400)]
Add logic for not starting ODL w/ sysd w/o sysd
Change-Id: Ic7dce2182086a0d6db530d978728d7e0bbb9014d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 12 Aug 2015 23:21:02 +0000 (19:21 -0400)]
Update port 8080 remap for Lithium
Lithium changed how ODL opens port 8080, so the config needed to be
updated to match.
This is needed to support running ODL with other apps that rely on
8080.
Ideally, we'll eventually support remapping 8181 as well.
We also need to clarify our API for doing port remapping,
as the var name is horrible.
Change-Id: I74212c5fdc90cf6bf397f89ace0893f450568476
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 8 Aug 2015 17:50:38 +0000 (13:50 -0400)]
Update ODL to Lithium, install RPM via CentOS CBS
Updates OpenDaylight's version from Helium SR3 to Lithium.
Changes ODL's NB REST port 8080->8282 (following Lithium change).
Updates Karaf 3.0.1->3.0.3.
Updates support Java versions to >=1.7.
Installs OpenDaylight via the CentOS Community Build System (CBS),
vs Fedora Copr. Upstream ODL has move to the CBS for Lithium.
Change-Id: If3e22a49a1f87a1cc906454b9b4c9ec5e6c0ae84
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sun, 26 Jul 2015 03:30:58 +0000 (23:30 -0400)]
Add local/remote path-based ODL RPM install
Introduces a number of API changes, but the default
is still a remote Yum repo-based install.
Change-Id: Icb8d8a2ed02a5a17402aa412a5fe131a612e640a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sun, 14 Jun 2015 17:43:24 +0000 (13:43 -0400)]
Refactor README for format, bugfixes and clarity
Change-Id: I36c6b4cdb3ed84c93415b35fa91fddb8dab6bf25
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 8 Jun 2015 05:07:17 +0000 (01:07 -0400)]
Remove unnecessary and confusing task conditions
Some task and handlers were marked to only run on
Red Hat family OSs. We currently don't support any
other OS, and running against another OS (so with
only the not-excluded tasks and handlers) would
break. They add unnecessary complexity, may mislead
people and add no benefit with our current feature
set.
Change-Id: I1f9670e55e0fb0020770a0836d57460fd8b7e493
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 30 May 2015 16:38:06 +0000 (12:38 -0400)]
Add handlers to clean start ODL after #10 test
This is mostly an experiment, may or may not be helpful.
Change-Id: I02cf4940c5bed79cd4770cc22798589ff12c5231
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 30 May 2015 16:15:09 +0000 (12:15 -0400)]
Revert "Include experiment task in tasks/main"
This reverts commit
a2c96d1f366cca1fba7f9eb9f23b5868e8425699.
Change-Id: Ia93b2f8ec074f6aa78f725bc1fcd6493758a7d5f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 30 May 2015 15:54:31 +0000 (11:54 -0400)]
Include experiment task in tasks/main
This should not be merged into master. It's an experiment.
Change-Id: Id3c9d4c6eb349f60a162643f078f5203b25c213f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 30 May 2015 15:49:01 +0000 (11:49 -0400)]
Add task to copy #10 test file to correct path
This is an experiment, may or may not be helpful/work.
Change-Id: Ie7f8ef4a5d856a49b0a3e71d48c15f8c483e5830
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 30 May 2015 15:46:27 +0000 (11:46 -0400)]
Add file related to test in #10
This may or may not be helpful/required for installing
the Jolokia bundle non-interactively (contracted with
our interactive Karaf shell command task, which works
fine for the record). It's basically an experiment.
Change-Id: Ibe9fa7a9765d44c571de0c7392550eea5606ec39
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 30 May 2015 00:29:16 +0000 (20:29 -0400)]
Document that NB port will be opened by firewall
Relevant to #15, closes #9
Change-Id: Ic0f45acd131ba78e153e88f6ba265b0129fac0e6
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 30 May 2015 00:24:27 +0000 (20:24 -0400)]
Include task to open NB REST port in tasks/main
Implies that it will be used by default when the role
is applied.
Relevant to #9
Change-Id: I2f6b73d5ca96965c6323ab131609f55180350654
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 30 May 2015 00:23:36 +0000 (20:23 -0400)]
Add task to open ODL's NB REST port via FirewallD
Relevant to #9
Change-Id: I82b5a1caca130a6b50654130a0ba13f7fe89d40c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 29 May 2015 22:05:49 +0000 (18:05 -0400)]
Fix trivial typo in README
Change-Id: Iac6106cd1da19df7e72f93346244b6dafbe250f5
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 29 May 2015 22:02:24 +0000 (18:02 -0400)]
Document the Karaf feature repos params in README
Relevant to #14 and #15
Change-Id: I7cce3a7066053bd9a8891b384145e26c35d7d7c6
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 29 May 2015 21:55:17 +0000 (17:55 -0400)]
Update features template to use Karaf repo vars
Closes #14
Change-Id: Id460cca040577b7d61ded4373fa201ff6dfb0e53
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 29 May 2015 21:54:11 +0000 (17:54 -0400)]
Add vars to configure ODL Karaf feature repos
Relevant to #14
Change-Id: I869ae2f3105cf66858b55ee0911fe7c5088d7114
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 29 May 2015 21:09:46 +0000 (17:09 -0400)]
Document overriding role vars to config ODL
Relevant to #15
Change-Id: I1d5057752e280af672919c8b35c1bad7322ab9d4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 28 May 2015 13:56:12 +0000 (09:56 -0400)]
Update contrib docs name/link to new extension
Was recently forced by Ansible Galaxy to use .md vs the
proper .markdown extension. Reflect that change in the README.
Change-Id: I4a8b4e435db37f40ecd3555065d8c16e9fb09829
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 21:19:07 +0000 (17:19 -0400)]
Ansible Galaxy requires .md extension
Even though .markdown is the best practice recommended
by the upstream Markdown people, Ansible Galaxy requires
a README.md for all roles.
Change-Id: I5f38f33d3d36e8e2275c02904a44372174675cf7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 20:46:17 +0000 (16:46 -0400)]
Use start/stop handlers vs restart handler
To get proper behavior with both the ODL NB config
and Karaf feature config changes notifying sets of handlers,
need to use the same ones when possible. Else, we might
stop ODL, make Karaf changes, start ODL and then restart ODL.
Change-Id: Ib850f0b10a2c625c60d04f72fad4eb68366605d4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 20:38:05 +0000 (16:38 -0400)]
Notify handlers to clean-start ODL after Karaf cfg
Calls the handers to stop ODL, clean up Karaf's cached
config (as recommended by Karaf docs) and then start
the ODL service after a Karaf features config change.
The order these handlers are listed in isn't what actually
causes them to be ordered correctly! Ansible defines the order
of handlers based on the order they are included in handlers/main.
Closes #7
Change-Id: I7661602703ea1b8aee996cb1413115ed1b243558
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 20:34:14 +0000 (16:34 -0400)]
Include currently used set of handlers in main
The order of the handlers is critical! Per the Ansible docs,
handlers are run in the order they are included. Changing
the order may result in event orders other than the desired
[stop ODL, cleanup Karaf, start ODL].
Relevant to #7
Change-Id: Ic64127b3f3fe8d3d27322524e3c8d0eb52a5c8f8
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 20:08:25 +0000 (16:08 -0400)]
Add handler to start ODL's systemd service
Relevant to #13
Change-Id: Id1f5d7795b497ab526165077522f65d61d555c77
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 20:07:26 +0000 (16:07 -0400)]
Add handler to cleanup Karaf's data dir
Removing the $KARAF_HOME/data dir is the recommended
way to start Karaf from a clean config, per Karaf docs.
Relevant to #13
Change-Id: I0c0cae099dab6cafa94d990553ddedca4f121235
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 20:06:37 +0000 (16:06 -0400)]
Add handler to clean start ODL's systemd service
Relevant to #13
Change-Id: Ib383687a114f242b594ecd1011968e347029c763
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 20:05:56 +0000 (16:05 -0400)]
Add handler to stop ODL's systemd service
Relevant to #13
Change-Id: I3adb5ebe673271d7c3d809fe2827769f6c8def25
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 27 May 2015 17:39:50 +0000 (13:39 -0400)]
Add task for issuing Karaf shell commands
Include this task in a playbook and set the karaf_cmd
var appropriately to issue ad hoc Karaf shell commands.
Closes #12, relevant to #10 and #7.
Change-Id: I1b9112c96eae180b4a230a8e5d32b47dac94d05c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 23 May 2015 16:52:49 +0000 (12:52 -0400)]
Add contrib docs link to README, other minor fixes
Corrects some documentation (based on puppet-opendaylight docs) to
reflect current location in Ansible role.
Change-Id: I3068628c7500bd316cd7d28238efae1ec6bfb5cf
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 23 May 2015 15:52:29 +0000 (11:52 -0400)]
Adjust contributing docs post copy from puppet-odl
Some links and docs were still specific to the Puppet mod.
As mentioned in the commit that added the contrib docs, they
are based on my docs under the same BSD license in the
puppet-opendaylight project.
Relevant to #4
Change-Id: I7b506224d893accadb837568b560bc696aa8b38a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Sat, 23 May 2015 15:46:17 +0000 (11:46 -0400)]
Add contributing documentation
Includes docs describing project communication and patch submission.
Based on puppet-opendaylight docs (also by me, under the same BSD license).
Closes #4
Change-Id: I4ac20afbb3626b91823b88ac04f8a88e8b7d1782
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 21 May 2015 23:35:01 +0000 (19:35 -0400)]
Add docs for configuring ODL's NB REST API port
Closes #11
Change-Id: Ie0ef900e9b0b33f13cc6a2bb24834fa1193c9007
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 21 May 2015 19:31:40 +0000 (15:31 -0400)]
Extract links in README for plain-text readability
Change-Id: I5e6157156176371694a68439c1b18a944fc07520
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 21 May 2015 19:23:10 +0000 (15:23 -0400)]
YAML syntax highlighting for example play in README
Change-Id: I024d4b50143e4618665812c1b9370a144daca505
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 21 May 2015 19:20:39 +0000 (15:20 -0400)]
Link to ODL Integration Team and main dev info
Change-Id: Ia9cfde18bbfc1709c50109cb3f8985d76e5f813e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 21 May 2015 18:50:02 +0000 (14:50 -0400)]
Include ODL NB REST port config task in tasks/main
This should be the final piece to allow the config of
ODL's NB REST API port.
Closes #5
Change-Id: Ibabc12381da9a5b5523ddf74a4d3d3ecbfd1e02a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 21 May 2015 18:49:40 +0000 (14:49 -0400)]
Add task for configuring ODL NB REST port
Change-Id: I44aa0ba87611052a57c5a9214c43315b96339992
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 21 May 2015 18:49:09 +0000 (14:49 -0400)]
Add template for configuring ODL NB REST port
Change-Id: I7a970b631e1f1dd17b06f498ab6c134027b716ad
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Thu, 21 May 2015 18:48:27 +0000 (14:48 -0400)]
Add variable for ODL NB REST interface
Change-Id: Ie23e9b069634129cb1d1cf680b7e71899391f65c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 20 May 2015 22:14:00 +0000 (18:14 -0400)]
Fix trivial spelling error in README
Change-Id: Iae780cd7f7464a776e99d064df8a14485faf83dc
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 20 May 2015 18:10:50 +0000 (14:10 -0400)]
Refactor README to use Ansible Galaxy template
Template generated by `ansible-galaxy init`, as recommended in docs.
Change-Id: I8423e5b628b50feb0e16d28961d79d49d7bf82a6
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 19 May 2015 14:46:26 +0000 (10:46 -0400)]
Add stub overview and more-info source to README
Relevant to #3
Change-Id: I34052a8441e7f329d5ad9a9fa9fc9bb946127c42
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 18 May 2015 15:38:39 +0000 (11:38 -0400)]
Remove unused default var config
These defaults are only for role dependencies, and as we don't
have any dependencies they aren't needed.
https://docs.ansible.com/playbooks_roles.html#role-default-variables
Change-Id: Id5a649f72c3f8b6dbb6253512e4609935d349a5d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 18 May 2015 15:28:50 +0000 (11:28 -0400)]
Remove unnecessary .gitkeep
Had been used to force git to track the templates dir, but as
we now have an actual template (Karaf features), it's unnecessary.
Change-Id: I846d08ab769b802744950f984e009af6bfc916c0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 15 May 2015 20:28:19 +0000 (16:28 -0400)]
Call ODL restart handler after Karaf config change
Closes #6.
Change-Id: Ie3a8a218936a440c7c89ecfc7844d4641d766622
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 15 May 2015 20:27:49 +0000 (16:27 -0400)]
Include ODL restart handler in handlers/main
Change-Id: I5da32f1b31a961315c567105229ffa0f4c2de1f0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 15 May 2015 20:26:37 +0000 (16:26 -0400)]
Add handler to restart ODL service after config
Relevant to Issue #6.
Change-Id: I6205d2dba7dd6b2699301ee39258c9511f96f7ec
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Fri, 15 May 2015 19:58:31 +0000 (15:58 -0400)]
Minor fix in JinJa CSV rendering
Listing no extra features left a trailing comma at the
end of the features list. This didn't cause a breakage,
but wasn't elegant. Should now work as expected.
Closes #1
Change-Id: I6b0a4b2359dd36f32bd38920e45e0c50502be098
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 13 May 2015 04:54:56 +0000 (00:54 -0400)]
Fix JinJa template to do proper CSV
There wasn't a comma between the last default feature
and the first extra feature. We now get a properly-formated
CSV list when passing extra features.
Relevant to Issue #1.
Change-Id: Ibb4f364c5d5169d758147e0a6de8c7859e5800ef
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 13 May 2015 04:19:27 +0000 (00:19 -0400)]
Include config Karaf features task in roles/main
Change-Id: I3f7bd5937f54178b7806e87aca3ba4379805417e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 13 May 2015 04:18:14 +0000 (00:18 -0400)]
Add task to configure ODL's Karaf features
Uses a template to configure which Karaf features to install at start.
Relevant Issues: #1
Change-Id: I67e1fabe12d2c979509d3dbbbb345c481f849e18
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 13 May 2015 00:43:04 +0000 (20:43 -0400)]
Add template to configure ODL Karaf features
Combines the default_features and extra_features vars in CSV
to configure the Karaf features to install at ODL start.
Relevant Issues: #1
Change-Id: If63431dd15f75ee0728bde599531494ecc2294ce
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Wed, 13 May 2015 00:13:43 +0000 (20:13 -0400)]
Add variables for ODL Karaf features to install
These will be consumed by a template, which will customize
the appropriate ODL config file.
Change-Id: I460ab6836d54cc43be81ec268de6beedf07b2e7e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 11 May 2015 21:02:36 +0000 (17:02 -0400)]
Include task to start ODL service in roles/main
Causes ODL's systemd service to be started when running
against Red Hat-family OSs (CentOS, Fedora, RHEL).
Change-Id: I9de09541106e08e6a402903a8e8f3235a81360ec
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Mon, 11 May 2015 21:02:07 +0000 (17:02 -0400)]
Add task to start ODL's systemd service
Change-Id: I97e3c222ebc915d2ab50341d76b5020f0b978b28
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Code Review / integration / packaging / ansible-opendaylight.git / log