Changes for SFC project features

Relies on https://git.opendaylight.org/gerrit/#/c/29169/

Change-Id: I61d19c9cd63262785ef7997ea5a6848e32cb2fb2
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Clean up pom files

Change-Id: I31eb3d576d92639b8fca269e76fb5759366074fd
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Move config file under src/main/config

Instead have having a seperate bundle for the config file, let's use the src/main/config
source package and the config-parent parent from controller project

This patch also fixes:

- header violation
- proper .gitignore entry for maven-metadata-local.xml

Change-Id: I738e592f8d7e559d9609b8c8f1d4cf9102311367
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Fix copyright header

Change-Id: I6bb5f24c3ffd70be7c4e36eea7c5e1384fa33a05
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Add yang generated packages in .gitignore

Change-Id: I1bd4365d9379ea8ba1de6981eef511be5f56774a
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Getting FAAS renderer started

This prepares the code structure for the FAAS renderer so that it can
be integrated with the Fabric As A Service (FAAS) project.
For more info about FAAS, Please see
https://wiki.opendaylight.org/view/FaaS:Main

Change-Id: Ie05739b4a9b68dad9c94d6639b3254a2bf0735a9
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

Typedef changes in SFC project

Change-Id: I54d60ee5d0d55150e371ef2e804dd792e921c7be
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Added revisions into imports in yang

Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 4487 fixing of NPE and moved creation of infrastructure

- Network Service EPG and Client Epg are created on neutronNetworkCreated

Change-Id: I85b805f327e73f41f81ce3c42846c55fa32cd641
Signed-off-by: Martin Sunal <msunal@cisco.com>

Removed tests based on changes in neutron

- commit [1] introduced UUID format check so we got errors in negative tests

[1] https://git.opendaylight.org/gerrit/#/c/28365/1

Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Gbp coverage increased in ./neutron/mapper/infrastructure"

Merge "Gbp coverage increased in ./neutron/mapper/util"

Gbp coverage increased in ./neutron/mapper/mapping/rule

- NeutronSecurityRuleAware.java (+35%, 87% overall)

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: Iecdf2dc507d76d9e58b253d7ee9ada50b3aed70c

Gbp coverage increased in ./neutron/mapper/util

- MappingUtils.java (94%)
- NeutronMapperIidFactory (100%)

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: I18918e1df68b87f768ad57284ed0573d379d89f6

Gbp coverage increased in ./neutron/mapper/infrastructure

- NetworkClient.java (100%)
- NetworkService.java (100%)
- Router (100%)
- Utils.java updated

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: Idaf4215f384d95ea6cd136913ea9825cffa9cf92

Merge "Bug 4195 - UT - GBP - NeutronMapper - groupbasedpolicy.neutron.gbp.util     NeutronGbpIidFactoryTest.java(98.3%)"

Bug 4195 - UT - GBP - NeutronMapper - groupbasedpolicy.neutron.gbp.util
    NeutronGbpIidFactoryTest.java(98.3%)

Change-Id: I26a87c83adb0387726a02792e8514b6ea9471404
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Test cases added to neutron-mapper and implementation improved:

Test cases relate to packages:
- org.opendaylight.groupbasedpolicy.neutron.mapper.mapping.group
- org.opendaylight.groupbasedpolicy.neutron.mapper.mapping.rule

Implementation improvement:
- <intra-group-policy>require-contract</intra-group-policy> is added for each endpoint group being added.
- Deleting a provider named selector from an endpoint group is added to a transaction only if it exists.

Change-Id: I91de3f130b78c6e456428702f053400999099fc3
Signed-off-by: Peter Palmar <peter.palmar@pantheon.sk>

Write resolved-policy.yang into Datastore, allowing renderers to listen to it.

Change-Id: I5316a680641293bd6394b1620a73c5c8e835049e
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

Merge "Version tag removal"

Merge "OpFlex removed from master"

Merge "Bug 3655: Endpoint location is now updated when OVS is disconnected/removed"

Version tag removal

Fix for: "'version' contains an expression but should be a constant"

Change-Id: I2c62963ecae899d024be6cb14cea444371ba070f
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>

OpFlex removed from master

Will not be released in Beryllium 2.It is out of date
with the LibOpFlex project and it is impacting UT targets
for no benefit.

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>

Feature uses features-parent as parent

- features-parent is used from odlparent as parent for features-groupbasedpolicy
- groupbasedpolicy-artifacs dependency management pom is created in artifacts
  folder
- removed dependency on features-sfc-netconf

Change-Id: I7bd5f9542a44c7f01e8ea38c922760d5754f44d3
Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3655: Endpoint location is now updated when OVS is disconnected/removed

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: I8efe7428cc2c8ffbf63ca4a8180cf7ae4292037f

Merge "Improved naming and usage of groupings"

Merge "Storing resolved PolicyInfo in Datastore"

Improved naming and usage of groupings

- naming of yang elements was changed
- created more groupings for better reusability
- improved descriptions
- renaming of yang module

Signed-off-by: Martin Sunal <msunal@cisco.com>

Storing resolved PolicyInfo in Datastore

Change-Id: Id8b14fe25595275f3342e558b7a65549af593a3a
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

Fix for bug 4287 and bug 4302

Change-Id: I1d4d82ab4b39b92f3116db5c3bc50a188ff0b3b4
Signed-off-by: Peter Palmar <peter.palmar@pantheon.sk>

Fix for compilation error introduced in merged bugfix

compilation error in
https://git.opendaylight.org/gerrit/#/c/27285/1

Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Use odlparent configuration for jacoco"

Merge "Bug 3693 - UT GBP - 4 - Ofoverlay-renderer - renderer/ofoverlay"

Bug 4341: Lifecycle Management of Endpoint Registry state

- add endpoint rpc registration to OfOverlayL3NatAug class
- classes OfOverlayAug and OfOverlayL3NatAug are autocloseable now

Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>
Change-Id: I32aa6a9eed4fbed0f6d3d4eb318a89ea89db4aa4

Remove unused adsal dependencies

Change-Id: I9bf62049e99b176bd88dd09b655cd12983c202a1
Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Bug 4098 - ofoverlay-renderer failure in jdk8

Modified Javadoc comments for jdk 8 compatibility
Formatted whitespaces/tabs
  - VxlanTunnelType.java
  - VxlanGpeTunnelType.java
  - AbstractTunnelType.java

Change-Id: I34f0722f8982424eae77aa7be97722e0dfc226d2
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Bug 3693 - UT GBP - 4 - Ofoverlay-renderer - renderer/ofoverlay

- SfcManager(42.9%)
- PolicyManager(73.3%)

Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>
Signed-off-by: Peter Palmar <peter.palmar@pantheon.sk>
Change-Id: If1e0f0f98c80319108e0d8202f01141183b56e0d

Bug 3302: fix for GroupTable

Change-Id: I38065618e28e0ff88fc50cd3c950549049cf04eb
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>

Correction of uncomplet cherry-pick

Diff in IngressNatMapperTest.java
https://git.opendaylight.org/gerrit/#/c/24151/4
https://git.opendaylight.org/gerrit/#/c/24204/4

Diff in all files
https://git.opendaylight.org/gerrit/#/c/22454/8
https://git.opendaylight.org/gerrit/#/c/22812/2

Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3240 3613: Asymetric policy in neutron

bug 3613
naming is more user-friendly because is composed from classifiers and actions

bug 3240
Assymetrical policy can occur when using neutron remote-security-group in rule.
Analysis showed that problem is caused by ANY endpoint-group
Fix of this bug is removing of ANY endpoint-group.

Basicly neutron Security Group Rule (SecRule) is translated to one Contract containing
one Subject with one Rule.

Change-Id: I8724c9eaa0244182ab26e2870399630c74b842df
Signed-off-by: Martin Sunal <msunal@cisco.com>
(cherry picked from commit 3bdadfae6e60e8ac58dd8572786da340f21b14ab)

Use odlparent configuration for jacoco

Change-Id: I4e46f59270716d5cea218d0e65e94f785583229c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Bug 4284 - PolicyEnforcer could not find CI"

Merge "Migration to use MD-SAL Project"

Bug 4284 - PolicyEnforcer could not find CI

PolicyEnforcer could not find classifier-instance
name because it has been refering to a name of classifier-ref.

Change-Id: Iff08420d51059a79297b15f7938689123e1fb699
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Migration to use MD-SAL Project

Change-Id: I609a37a0fb3ea741e5b4f0f1ff3f1b87eb47fe44
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Update ovsdb.southbound.version

OVSDB bumped that version to 1.2.1-SNAPSHOT in this change:
https://git.opendaylight.org/gerrit/#/c/25574/

Change-Id: Id44d7824e134973df0c8e9c056353cde34a7c392
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Bug 4128 - Addition of chain in neutron mapping OS environment causes tunnel NPE

Change-Id: I3587c717e0c8ea23f72bceb93a7424ce9e93554f
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Migrate restconf dependencies"

Migrate restconf dependencies

Migrate project's restconf dependencies and features
to new groupId/version

Change-Id: I6d52b97b2e1bcd70eb888050557066e5f2570f4d
Signed-off-by: JMorvay <jmorvay@cisco.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3353 - added table offset to of-overlay-config

Table offset added to ofoverlay model and might be changed in runtime.
 - offset leaf moved from overlay-provider-impl.yang to ofoverlay.yang
 - offset value changed from uint16 to uint8 according to spec,
 - offset value validation.
 - OfOverlayRendererTest adapted

Change-Id: I1479f36b0ef34be8fce97b562e59b723489a7482
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Explicitly set git-review branch to master

Change-Id: I8c3715b5f30f3e10cc475b2539b1750e167977ea
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 4047 - Missing getters in SfcNshHeader.java

- SfcNshHeader.java
- SfcNshHeaderTest.java
- Remove C3 and C4 fields which are not used

Change-Id: I9b33120fd0996d036b8f402229a29aafaa6e29ac
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Sonar bug fix for L4Classifier.java

Reduce Cyclomatic complexity of method "checkPresenceOfRequiredParams"
Reduce Cyclomatic complexity of method "update"
Removed redundant conditional checks
See - https://goo.gl/jgXZws

Change-Id: Ia69e4d447c361515a89e01e00023fb106aaa9427
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Bug 4053 - No selector for DHCP in multi-tenant

Assigned tenantId for consumer, provider epg and contract into mapping.
IDs of endpoint-groups and constants may not be unique accross multi
tenat topology especialy if ID is a constant for specific group (DHCP,
Any) or contract.

Change-Id: I39971221aabbb6450a3553fbcaa9abb1dfd4c2a3
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Bug 3696 - UT GBP - 7 - neutron/ovsdb

- TerminationPointDataChangeListener(75%)
- NodeDataChangeListener(92.7%)
- NeutronOvsdb(90.3%)

Change-Id: I432830cefad5eae3e116e07fe2b7c7094efdce96
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3254 - filling out names for EPGs

Router and Any group haven't had name parameter filled out.

Change-Id: I09f056ef64b6cd6529f742ecc01e2eb5d575dc53
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Bug 3700 - UT GBP - 11 - neutron/ovsdb

OvsdbHelper.java (98.8%)
NeutronOvsdbIidFactory.java (96.2%)

Change-Id: Id3e26aa8d031a8cad183c57c20e49da5f5d16744
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>
Signed-off-by: Peter Palmar <peter.palmar@pantheon.sk>

Merge "Bug 3703 - UT GBP - 14 - groupbasedpolicy-base"

Merge "Bug 3702 - UT GBP - 13 - groupbasedpolicy-base"

Bug 3703 - UT GBP - 14 - groupbasedpolicy-base

ActionInstanceValidator (100%)
SubjectFeatureInstancesValidator (100%)
TenantValidator (100%)

Change-Id: Ibbc626553785b67334f771f3322d5a20cb0b968a
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3702 - UT GBP - 13 - groupbasedpolicy-base

PolicyResolverUtils.java (73.1%)
PolicyResolutionException.java (100%)
PolicyResolver.java (58.1%)
EndpointConstraint.java (88%)
PolicyValidator.java (95.1%)
SimpleResult.java (100%)
ValidationResult (85.1%)

Change-Id: I63eb56c4b5e94366896c7f0b40a1c028dc181556
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3701 - UT GBP - 12 - groupbasedpolicy-base

SetUtils.java (81.5%)
IidFactory.java (98.3%)
DataStoreHelper.java (94.2%)

Change-Id: I7b2d03e80e7216da5d7edc5a9f1ea0a4ac95293c
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Merge "Bug 3699 - UT GBP - 10 - ofoverlay-renderer"

Merge "Bug 3698 - UT GBP - 9 - ofoverlay-renderer 1/2"

Merge "Bug 3697 - UT GBP - 8 - ofoverlay-renderer"

Bug 3699 - UT GBP - 10 - ofoverlay-renderer

- SfcIidFactory.java (85.7%)
- SfcNshHeader.java (95%)

Change-Id: Ifeb518de1510b3e9ea6e1da1df4fa02a7e078387
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3698 - UT GBP - 9 - ofoverlay-renderer 1/2

- ExternalMapperTest (100%)
- SourceMapperTest (99.8%)
- PolicyEnforcerTest (79.5%)
- GroupTableTest (100%)

Change-Id: I7304196e2ca83d71a5c0cc5eaf84129817021c88
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3697 - UT GBP - 8 - ofoverlay-renderer

- OfOverlayRenderer.java (85.3%)
- EndpointManager.java (79.8%)

Change-Id: Ia92933a9ad51275ed94cff738e7ada2b71da8358
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3694 - UT GBP - 5 - Ofoverlay-renderer

- ActionComparator (100%)
- FlowUtils (98.9%)
- IngressNatMapper (99.4%)
- EgressNatMapper (98.7%)

Change-Id: I379b86ff800fbafe13f12e944d59cf15f3e46d20
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

BUG3903: Fix for incorrect egress as well as incorrect VNID.

Change-Id: I0c8b3a7d73f638d584f0e93e438fc20f9b040660
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug 3695 - UT GBP - 6 - neutron/ovsdb

NeutronHelper (93.2%)
EndpointHelper (97.0%)
InventoryHelper (90.0%)

Change-Id: Ibc373d7c250db3855a92181627220ce328b7f320
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug-3836: Don't catch Throwable (use Exception).

Throwables shouldn't be caught, and the code should
instead catch Exceptions. This patch fixes bugs of
this kind that were found by sonar.

Change-Id: If9eda19712141107efea6b4432cdb6b4d5c8bf29
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3988 - Jenkins Build failing due to Changes is NeutronCRUDInterfaces

- NeutronRouterAware.java
- NeutronFloatingIpAware.java

See https://git.opendaylight.org/gerrit/#/c/23961/

Change-Id: I5329faa4fafe60494dfb37e688fa94ef747223bb
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Merge "Bug 3836 - sonar: Throwable and Error classes should not be caught - part1"

Merge "Bug 3854 - GBP sonar: System.out and System.err should not be used as loggers"

Bug 3836 - sonar: Throwable and Error classes should not be caught - part1

Change-Id: Ia994ac86100aca4f31dbe00d9f0a61db786a929a
Signed-off-by: Ruijing Guo <ruijing.guo@intel.com>

Bug 3914 - GBP sonar: Constants should be declared "final static"

Change-Id: Idbee2311dfa6ae94b4623f5167d1ec91993d873d
Signed-off-by: Ruijing Guo <ruijing.guo@intel.com>

Bug 3692 Ofoverlay-renderer - renderer/ofoverlay/sf

- ChainAction
- ClassificationResult

Change-Id: Iaa706247d8477d5cdd2606f898a546925cb4a400
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3854 - GBP sonar: System.out and System.err should not be used as loggers

Change-Id: Ib3e998bba62aba9a5a4bd683cd43a891cfffaa36
Signed-off-by: Ruijing Guo <ruijing.guo@intel.com>

Revert "Bug 3773: L2 EP is missing L3 Context + IP."

This reverts commit b39be843c7c41c13c3e5e053aa8f90ca9f572ae5.

Change-Id: I6b5a748c3838e982d8be0d23e1c09f05009f6c4b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
(cherry picked from commit 2a7626f09ca3953b21a3412c7c6b212afa6e309f)

Merge "Removal of POC."

Merge "Bug 3618: Tenant.OPER not removed when Tenant.CONF removed"

Removal of POC.

This will be handled via Vagrant etc.

Change-Id: I55156fd78de74dd8ab92dffbad13853c5044ab29
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Bug 3746 added check if node is also in oper DS"

Merge "Sonar bug fixes for SwitchManager.java"

Bug 3746 added check if node is also in oper DS

Based on info from OF plugin team:
if a node exists in OPER DS then routed RPC implementation is already registered

Change-Id: I6a7a9f6b5cde60d7b47dcbb3761c921163d35415
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "BUG3517 - switched sigma topology to jointjs"

Merge "Bug 3446 - clear Inventory CONF augmentations"

BUG3517 - switched sigma topology to jointjs

Change-Id: Ic1652cc50a9bdd17ec4c9e3abb77a04759f1c760
Signed-off-by: Juraj Sebin <jsebin@cisco.com>

Bug 3446 - clear Inventory CONF augmentations

Inventory in CONF DS is cleared of tunnel and external interface
information when a switch manager connection disconnects.

Change-Id: If996c37947d71a57227ded49546120f1130272c7
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

BUG 3686 - Fixed refreshing selectboxes in contract detail

Change-Id: Ifc3d0c40a4cc81f6e219e41cab0678df02500bab
Signed-off-by: Zdenko Krnac <zkrnac@cisco.com>
Signed-off-by: Juraj Sebin <jsebin@cisco.com>

Bug 3618: Tenant.OPER not removed when Tenant.CONF removed

Change-Id: I010489727f36c390ff4fe59f259e79c9a06968ae
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>

Bug 3690 - unit tests #4

SwitchManager

Change-Id: Id83aac3065fa276a76c582fff354882b9166c7a1
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3608 - Floating IP notifications fixed.

- Also fixed nasty Map NPE for unregister/register EP.
- Overuse of Maps are the devil's hand-maiden.

Change-Id: I144a528c54df036217fedffc0a3c6deccc31867b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Bug 3791: Add gateway MAC to Prefix flowmod match."

Merge "Bug 3773: L2 EP is missing L3 Context + IP."

Bug 3791: Add gateway MAC to Prefix flowmod match.

The current implementation of flow-mods for
Layer 3 IP prefixes doesn't provide a gateway
MAC address for the matcher. This patch creates
separate flow-mods for each subnet with a gateway
on the node for this prefix.

Change-Id: I11b652d5cfe714e2d7a112632e94826482a931d5
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3608 - Distributed External Gateway - flows only needed on local node for VM

Change-Id: Iacce577bd12cb6d08abeff2eea6d927b13caaaca
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug 3773: L2 EP is missing L3 Context + IP.

When an L2 EP is created after resolving the ARP
request for an external gateway, an external L2 EP
is created for it. That EP is missing the L3 information
(L3 Context + IP). This patch fixes that.

Change-Id: I55175773b697635e17c285be2cbc0af6fef1b2ec
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>