Merge "neutorn-spi: more remove neutron prefix of field"

neutorn-spi: more remove neutron prefix of field

The changeset of a2f1a28cb8b6c226f49716434cd8ccc34c43eaa4
the change id of I81984a294b4601bfb18b24140d03d615dba1424a was
imcomplete somehow.This patch removes remaining neutron prefix in spi.

Change-Id: I935e2028fc436cd01e8eb930eb5811f4dca26575
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

NeutronLogger: minor code clean up

remove unnecessary methods in NeutronLogger

Change-Id: I72cd2ebc6093cd48d714ed4d11abb6a47405c65e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

apiece unchecked cast warning

Eliminate unchecked cast warnings.
In some places we have to use @SuppressWarnings("unchecked")
unfortunately.

Change-Id: Ibaaeebabe86ec645bc61d68389c611b0a0bdc399
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

neutorn-spi: remove neutron prefix of field

field name of neutron spi doesn't prefix neutron.
The following three classes have the fields with neutorn prefix.
NeutronL2gateway, NeutronL2gatewayDevice, NeutronLoadBalancerListener
remove prefix of the fields of those classes For consistency.

Change-Id: I81984a294b4601bfb18b24140d03d615dba1424a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: remove suppression

Now there is no need of suppression for checkstyle.
remove checkstyle-suppressions.xml.

Change-Id: I1fe08a85542f52fcd94bf76f369b66bd0d02def6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: AbbreviationAsWordInName

fix AbbreviationAsWordInName and enable AbbreviationAsWordInName.

Change-Id: I6d0756598b7d2a000325b4986e2752aacfd30eb3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: TypeName

eliminate TypeName violation and enable it.

Change-Id: I97af3891eafc965176fa34f17176b62d897122a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: JavadocStyleCheck

fix JavadocStyleCheck and enable it.

Change-Id: I1689aebded15605474c3ef388e433a87577d190a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: enable SummaryJavadoc

fix SummaryJavadoc and enable it.

Change-Id: I68a464c78aacbb54d54b198b267d616d228e7403
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: enable JavadocTagContinuationIndentation

Eliminate the violation of JavadocTagContinuationIndentation and enable
it.

Change-Id: If854fa71db3115200f57faa8c06c0dd1e8995c0c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: enable JavadocParagraph

Eliminate the violation of JavadocParagraph and enable it.

Change-Id: I1f114f516d96bf0d3f5530d92e876b788cd73af6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: eliminate ConstantName violation

Eliminate ConstantName violation of checkstyle and enable it.

Change-Id: If124294de812c3b6f022edbe0d1540c78eeae2d8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: enable LocalVariableName

fix LocalVariableName violation of checkstyle and enable it.

Change-Id: I6945ac54f3851772cc848093c56111c142d0723d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: ParameterName

Fix PrameterName checkstyle violation and enable it.

Change-Id: I7f06123fcd1fb5a6db1f47672c788aeb521814ec
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: suppression to ignore files under target

the changeset of f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a
in odlparent introduced new supression to ignore sources under
target. This patch catches up it.

Change-Id: I7f35dffea41dbfc939238db0014632a2cd44fa18
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: use our own checkstyle-suppressions.xml

The changeset of f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a in odlparent
defines its own checktyle-suppressions.xml. so that neutron northbound
fails to build because unintented suppression rule is used.
Make it sure that intended supressions are used.

Change-Id: Ifb14d25e5b7b374515274ef9644e35fe64dde5a4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

BUG-7259: pool-attributes have wrong description

n neutron-lbaasv2.yang, the description of healthmonitor-id in
pool-attributes is as follow:
    leaf healthmonitor-id {
 type yang:uuid;
 description "List of healthmonitors
 associated with this pool.";
    }
here, healthmonitor-id is not a list, so the description need to be modified

Change-Id: I69709af3585bf66c8a4e25a239bc3e071e9bc809
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>

BUG-7185 NeutronLoadBalancerListener has wrong xmlElement name

Fixes bug 7185
    lb listener from openstack uses loadbalancers as xml key value,
    so the XmlElement name of load_balancers in
    NeutronLoadBalancerListener need to be changed to loadbalancers

Change-Id: Id05e4fedc9e516aca45f4c2fac4b3763ee9a1ed8
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>

NeutornLogger: print data when node is deleted

Log data of deleted node.

Change-Id: I84ae522cb49453f3d5d2b7812aecfe00628fa9dd
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Bug 6938 - Handle unknown protocol name as bad request"

Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: I36e42dac7ccc13f0f796bb95a28a6f30f141b05c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bug 6938 - Handle unknown protocol name as bad request

Fwaas, security group rule handled unknown protocol
name as internal server error. Changed that to respond
with bad request. lbaas ignored the wrong protocol field.
Also chaged that to respond with bad request.

Change-Id: I681d67b8704015b392ee811b0f4b1556a63b5809
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 6865 - Transcriber skips the uppercase protocol field

Networking-sfc sends protocol string in lowercase
(e.g tcp and not TCP), but neutron spi try to find
it using the uppercase and don't find it and
eventually ignore this field. To be consistent with
other API's, flow classifier will only accept lowercase
protocol name and return 400 (Bad Request) for any other
protocol string.

Change-Id: I204f58c9cf1cf13446122c8f818ce498866a2caf
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Fix checkstyle issues related to exception handling

This is based on the Guidelines given here
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#IllegalCatch

Change-Id: I70f9841f706c8d5c38b0834dba04b79ad8fbfa71
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Merge "sonar: Move this trailing comment on the previous empty line."

Merge "sonar: use dedicated exception instead of RuntimeException"

Bug 6796 - Fixes Priority bugs in integration-test

1.NeutronL2gatewayConnectionNorthbound.java:118,
EC_UNRELATED_TYPES, Priority: High

This method calls equals(Object) on two references of different class
types and analysis suggests they will be to objects of different
classes at runtime

2.NeutronL2gatewayNorthbound.java:116, EC_UNRELATED_CLASS_AND_INTERFACE
This method calls equals(Object) on two references, one of which is a
class and the other an interface,where neither the class nor any of
its non-abstract subclasses implement the interface.

3.NeutronRoutersNorthbound.java:102, EC_UNRELATED_TYPES - Same as 1st
Bug

Change-Id: I23cda778f807ba02179c7d9d4e682b9561a378d4
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>

sonar: Move this trailing comment on the previous empty line.

remove trailing comment by moving it on the previous empty line.

Change-Id: I72d7e93dd4d60c4773b437c36368d3297e8154d4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

sonar: use dedicated exception instead of RuntimeException

use IllegalArgumentException instead of RuntimeException

Change-Id: I32c17078499ff3cfd17f2d3b445a3e1bdac99574
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

remove unused inUse method

Change-Id: I10053b258e899324c30fff836c9ebd88c2ef216c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transscriber: consolidate createInstanceIdentifier(T item)

Consolidate InstanceIdentifier<T> createInstanceIdentifier(T item)
into AbstractNeutronInterface.

Change-Id: If6aedc24d9cc4a15cefa7c21ce3d00c51610c0f0
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transcriber: consolidate createInstanceIdentifier()

This patch consolidate createInstanceIdentifier() into parent class.

Change-Id: I6acf69e2ac328bf71cff3efbd846a72db02df6a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transcriber: refactor fromMd/toMd logic

Since there are several common fields like id, tenant_id, name,
admin_state_up status, factor out those common logic.

Change-Id: If5b11321769890d075eb6a331f1f013de4b5295a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

spi: consolidate common member

Since some fields are common to neutron resource, name, status, admin_state_up,
introduce common parent interfaces/classes to consolidate them.

Change-Id: Ie8b654010f0cf780eaa958b49d38b1ed72847961
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

AbstractNeutronNorthbound: make cast more accurate

Change-Id: I5cd28faedcbe037ae976e038f3f70ecae644f857
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

spi: consolidate extractFields logic

NeutronObject is common class to have id and tenant_id.
So consolidate extractFields logic to extract them into NeutronObject.

Change-Id: I1e79da6fca9824dbd0563fc09c2dd34843dd99ac
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

sonar: hide NeutronCRUDInterfaces construtor

The class is utility class to have only static method.
Hide public construct not to instantiate it.

Change-Id: Ib78e179c7ec540e0604f2be8c8be65400c1e6f82
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Adds SFC Integration test cases"

Adds SFC Integration test cases

Change-Id: Ie6844549f939123687226c3cbde0cd6239a85926
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>

Checkstyle exception handling fix (Neutron-spi)

Fixing checkstyle violations in the neutron-spi
integration tests

Change-Id: Ic7a1ed9ea6b4c9362fa73df550825da9e34e00e8
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 6736: Fix incorrect destination ip prefix value

Value of destination ip prefix read from mdsal
is not correct

Change-Id: I712097aed98bf1d5db581de8d3a8b254065adbef
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

spi: NeutronCRUDInterfaces remove unused mothos

remove unused methods in NeutronCRUDInterfaces

Change-Id: I236ad8e294dc40a0fb7055faf56379f00b800d76
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northbound: simplify neutron interface loading

Now subnets/ports/routers northbound doesn't need dependent
interface. So getNeutronInterface() can be removed.

Change-Id: I7a78ec35a0b7f2efa79840672e257cc7e5724457
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Bug 6641: Fix ip_address in allowed_address_pairs info"

Bug 6641: Fix ip_address in allowed_address_pairs info

Change-Id: Id612243cbdc6ab8db8d66ce46ca2973a0effc0ee
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Merge "Neutron-Logger: add final to public class"

Merge "transcriber: sprinkle final to public class"

Merge "northbound: code clean up"

Merge "neutron-spi: sprinkle final to concrete class"

Merge "simplify NeutronTranscriberProvider"

Merge "Add NeutronSubnetJAXBTest unit test"

Neutron-Logger: add final to public class

Change-Id: I44806c78dc34e8fe2575441f28a774889ac0beda
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transcriber: sprinkle final to public class

Change-Id: I48d6961a7e774957da1a4120c2ecb36045fee2d1
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northbound: code clean up

- sprinkle final to public class
- remove unused variable, uriinfo
- misc improvements

Change-Id: Ied5692ef500a768949e7a010266953b097790d7f
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

neutron-spi: sprinkle final to concrete class

Change-Id: I73453299f8ce890309fc7df7c1147f39742d2659
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

simplify NeutronTranscriberProvider

remove unused variables to simplify NeutronTranscriberProvider.

Change-Id: I1d8e7ac5e9506d752ed725920282662d0d73e8d2
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

consolidate NeturonCRUDInterface.fetchNeturonCRUD logic

The logic are mostly same, consolidate them by generics.

Change-Id: I4a38de02b2a11f355581702a711fe9244d835701
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northbound: make newNeutronRequest concrete method

By this change, about 120 lines are reduced.

Change-Id: Id4838b4e5109d92f01e18e611e869c27b56371e9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "sort out signature of extraceField method"

Add NeutronSubnetJAXBTest unit test

Change-Id: I62ddd9e0e4ae83866e50e170695871e6891105f7
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

sort out signature of extraceField method

So far, the signature of extractField was not defined cleanly.
Define it clean and simplify convoluted code due to it.

Change-Id: I48387b8df50bd019a735e6272a3850adfd10b0d5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

remove unused variable/method

Change-Id: Ide5eaee4ddef280cc2737f2d196691a805ee01f7
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northbound: simplify Neutron*Request

Consolidate Neutron*Request logic and make them consistent a bit.

Change-Id: I5b4a62ea14813b1656bc30de944f862e4e0ccec5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Enable checkstyle enforcement for the project

This patch enables checkstyle enforcements.
Also some checkstyle issues are not yet addressed
and those are added to the suppress file for now.
As some of those issues are addressed those will
be removed for the suppress file. The checkstyle
issues suppressed show as warnings during
compile.

Change-Id: I1c64aa426de7d29002e66c50367bbe84f23d885c
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle misc issues fix(Integration)

Patch fixes EmptyStatement, ModifierOrder, MethodName,
LineLength, RegexpSinglelineJava checkstyle issues for
integration tests files.

Change-Id: Ia81cb6ad86831b66d6e08ecfd37a68c3bf31a624
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Merge "Checkstyle indentation issues fix(Logger)"

Checkstyle indentation issues fix(Logger)

Patch fixes indentation checkstyle
issues for logger file

Change-Id: I8f81976cbea06c3275430f07f5b4e040ef6a4735
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle imisc issues fix(Transcriber)

Patch fixes OverloadMethodsDeclarationOrder, MemberName and
LineLength checkstyle issues for transcriber files

Change-Id: Id19b977735448a309c9c49c3674f62c4efb5ac4b
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle formatting issues fix (Integration)

Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
integration files.

Change-Id: Icd348dd86813c7682428361db90190b84a6958ff
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle formatting issues fix (Logger)

Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
logger files.

Change-Id: I7e763dc1b097e70d4b2c5af231709d0861d33654
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle formatting issues fix (Transcriber)

Patch fixes WhitespaceAround,  OperatorWrap,
LineLength and other formatting checkstyle issues for
transcriber files.

Change-Id: I71fa7937648fb07dd8a8eb53c7683a47953c87ff
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle misc issues fix(Northbound API)

Patch fixes VariableDeclarationUsageDistance, RedundantModifier,
OverloadMethodsDeclarationOrder checkstyle issues for
northbound api files.

Change-Id: If6f91851648e5a10094f0c6c03e07983ebca08f0
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle formatting issues fix (Northbound API)

Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
northbound api files.

Change-Id: I11123566ee4d96f3310c74834e9d0977af80f8f8
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle formatting issues fix (SPI)

Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
neutron-spi files.

Change-Id: Iafb65de2f544212e655d497d5e39a4bcb7f32b76
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle Import issues fix (Transcriber)

Patch fixes Import order issues and also removes
the unused imports. Patch is for transcriber.

Change-Id: Ib247eebb771ec66bd60f67cf457cf248f2dbf565
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle Import issues fix (SPI tests,Northbound API)

Patch fixes Import order issues and also removes
the unused imports. Patch is for spi tests,
northbound api.

Change-Id: I005975da29580140e28a4667b54729710857d362
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Checkstyle Import issues fix (SPI, Model)

Patch fixes Import order issues and also removes
the unused imports. Patch is for Integration tests,
spi and model

Change-Id: I5565cf9f83ba9bc3092ebaa8c40c8d3056821e72
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bump ietf versions to ...10-SNAPSHOT

Bump versions according to:
https://lists.opendaylight.org/pipermail/release/2016-August/007731.html

Change-Id: Iced0c6aa67afea7022dcef70ab4dbb098dbf098a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix ietf-yang-types version

The version bump script messed up the ietf-yang-types version. Fixing it
with this patch.

Change-Id: I09c85b68b79e98f129297250c5ed69d1f58a235c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump versions by 0.1.0 for next dev cycle

Change-Id: I5763bc1e3fe66570d0944ef515a7142608678cb9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove unused controller's jersey dependency

Change-Id: I4e42c9bf9c82eb26404f0745f4c08fee92df0126
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Adds Postman scripts to verify the API of QOS feature"

Adds Postman scripts to verify the API of QOS feature

The postman scripts can be imported into postman to make the REST calls
for Creating, Updating and deleting the QOS policies.

Change-Id: Id9c452d3c80cf0c79f32f783c96e0f2ed7b044bf
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>

Bug 6327 - transcriber port security group

SecurityGroup of Port includes only lists of uuids of security group.
Its contents aren't necessary on fromMd().
remove unnecessary logic to fulfill SecurityGroups.

Change-Id: I17bde352c842236b83d4c7b2bd1ffeebbf1c8211
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

This Increases the test coverage of the Neutronbgpvpn

Modified the tests to improve the code coverage

Change-Id: I26e9f47c22d4d0199fcdec451382aa3ecc50fdd2
Signed-off-by: Pramod <pramod.raghavendra.jayathirth@intel.com>

Add missing license headers

Change-Id: I9b8fa15d5b42585826e8b4b21fef0547d8e1a4db
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add Qos transcriber file and n/w and port extensions

Patches adds changes to implement transcriber
functionality for Qos feature. Also added code to support
network and port extensions for Qos.
Depends on the other Qos patches
https://git.opendaylight.org/gerrit/#/c/37165/

Change-Id: I29a539a5d980330b80ba3fe319e1ec823d0e2491
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Adds the "Quality of Service" to the OpenDayLight Neutron

This patch enables the Quality of Service feature in the OpenDayLight
Neutron.
The implementation is done as follows
1. Defining the YANG model
2. Implementing of API
3. Testing the developed API

The QOS is achieved using either limiting the bandwidth or through
DSCP marking

Data model -
https://specs.openstack.org/openstack/neutron-specs/specs/liberty/qos-api-extension.html
This link has the data model changes as suggested by the OpenStack
Neutron for the QOS feature
API -
http://developer.openstack.org/api-ref-networking-v2-ext.html#qos-ext
This link has the API for the Openstack for the QOS feature

Change-Id: I7074dbb6d494b1267b66a925742e9812ef8a9304
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>

Merge "Security rule: tests to exercise int as protocol"

make neutron.yang consistent

Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Change-Id: Iee560804c49fc3cc6f193e1d52576d11e84e8cd4

yang model for neutron extensions api

This patch defines a yang model for neutron extension api [1].
Through this model, openstack service provider is able to tell networking-odl
which neutron extensions are supported.

[1] http://developer.openstack.org/api-ref-networking-v2-ext.html#neutron_extensions

Change-Id: I68fc840545d260486fb7ab2e9cab10b9628daf1a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Security rule: tests to exercise int as protocol

Enhance tests to exercise more patterns in protocol of security group
rule. It accepts not only protocol name and also integer.
This patch is follow up patch for Bug 6112.

Change-Id: Ic3a944f1612dd67a0366b610ad77ad92c948eb07
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Upgrade ietf-{inet,yang}-types to 2013-07-15"

Merge "drop unnecessary executable flag of .gitignore"

Merge "Fix for multiple external fixedIPs under router-ext-gw-info"

drop unnecessary executable flag of .gitignore

Change-Id: I9bc0049f01db2c7c7f4f0c4b6e34d2b94da10da6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "remove dummyprovider"

Merge "remove unused methods"

Fix for multiple external fixedIPs under router-ext-gw-info

Updated the key to use both subnetID and fixedIP to allow multiple
fixedIPs per subnet to be configured.

Bug ID: https://bugs.opendaylight.org/show_bug.cgi?id=5723

Change-Id: Ib0bd24229ed3891275eb5dc5d02c0afd52065d41
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>