Fix mdsal-binding-spi parent setup

We need to have a relativePath to work correctly.

Change-Id: I8ab8e034001ce73546d73f7629ffe36b7ecb4b41
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable spotbugs in mdsal-{binding,dom}-spi

This patch addresses violations and flips the switch.

Change-Id: I9a0a715b26d42cff395f6448323be1b6e52b162d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable spotbugs in mdsal-{common,binding,dom}-api

This suppresses the single violation and flips the switch.

Change-Id: I48e8364604192a973a05bf35631551091403e2b2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate BaseYangTypes.UnionType

This class is not used anywhere and is defunct due to nullness
violation. Deprecate it for removal.

Change-Id: Icfdda71931571b8bf98f0f4d65a783447db13f7e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-binding-dom-adapter to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

Change-Id: I220ed55636d3a4a4bc3e4c39a6169541f89cf283
JIRA: MDSAL-373
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate ietf-type-util to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

Change-Id: I05d01bb4aa3a8e343432987e8a66e06971d22e69
JIRA: MDSAL-373
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Suppress javax.annotation imports in yang-binding

We do not want to generate references to javax.annotation, remove
it from imports.

Change-Id: I2edffd282db530c6052b3541a553d52e33c3fd78
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-dom-inmemory-datastore to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

Change-Id: I9b05210e5a927e78085779e216fde8cd2142c30b
JIRA: MDSAL-373
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-dom-broker to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

Change-Id: Idabf3b89a4aad9b04168126d5ea9ebee1268b1f9
JIRA: MDSAL-373
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-dom-spi to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

Change-Id: Ic7751f6fbffeb063ddda0bf4dc8b7dc7b66f7c80
JIRA: MDSAL-373
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-dom-api to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

JIRA: MDSAL-373
Change-Id: Ida93d05898d6b9d967e240096feb4d1092e02e87
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-dom-schema-service-osgi to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

Change-Id: Ife7598dcaca40e2bacc32f2da679cd85f60c1567
JIRA: MDSAL-373
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate entity ownership to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

Change-Id: If89fd8302e1e709c23c6802e3e10341f96bcfe00
JIRA: MDSAL-373
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-singleton-dom-impl to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

JIRA: MDSAL-373
Change-Id: I6b0683321f0f499383fb36e9658e9ba643f82b92
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-common-api to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package. Also improve APIs by annotating additional
elements with @NonNull and reusing FluentFutures, which are more JDT
friendly.

JIRA: MDSAL-373
Change-Id: I9cb82bcb5bd755dbb544efeefeb9a0ebec3cb69c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove mdsal-binding-util javax.annotation.Nullable reference

This removes the use of javax.annotation nullable annotations
to remove import-package.

JIRA: MDSAL-373
Change-Id: Iace3fb91218fae8ccc8d65b5f295f865dc1ba94c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-binding-generator-impl to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

JIRA: MDSAL-373
Change-Id: I51519c4587dfe6a06fb9f875c6e6e410192c0cc9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-binding-spi to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package.

JIRA: MDSAL-373
Change-Id: Ibaa0506b451e9f06fff05ed3043acb707609fba1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Annotate mdsal-binding-api with @NonNull

This fixes a mismatch with mdsal-binding-util and formalizes
existing effective contracts.

JIRA: MDSAL-373
Change-Id: I98914a04fb0efb8f5ebd70058f39f9fb36bdf5b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-binding-api to JDT annotations

This removes the use of javax.annotation nullable annotations
to remove import-package. Since we are using @CheckReturnValue
we also need to explicitly remove javax.annotation import.

JIRA: MDSAL-373
Change-Id: I2c18495a5082fb79a61278580c67ec3a21b979af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix up testShardRegistrationClose

Change-Id: I40d0fca6554a343f008fed5760256281d35e9f92
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Make sure we compare key members via their property name

As it turns out, simple comparison ignoring cases does not correctly
work if the schema is using CamelCase. We need to do the hard work of
deriving Binding property name and sort on that to be consistent with
what the codegen does.

JIRA: MDSAL-355
Change-Id: I34cdb032fbdeb093e2973b91c5011e302e6280bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 3.0.1-SNAPSHOT

This starts the next development cycle.

Change-Id: I1f1e0381f1abf9ae89c2c17ca3eb6ead58ce201a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move rfc7895 model

This fixes up the groupId for rfc7895 to match packaging requirements.

Change-Id: I599a0574553bd1447f473ac9a293985d847f8786
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Drop Xtend Equinox Common overrides

These are no longer necessary and make it harder than it should be to
upgrade Xtend in odlparent.

Change-Id: I3196ad374895e8e96f71f79529dde578913589ab
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Implement managed transactions

Managed transactions ensure that transactions are always closed in the
appropriate way:
* read-only transactions are closed when they are no longer needed;
* read-write and write-only transactions are submitted if the code
  manipulating them didn’t throw an exception, cancelled otherwise.

Managed transactions are datastore-specific and enforce either
configuration or operational reads and writes.

Two providers are included: a basic transaction manager which provides
transactions, ensures they are closed, without any extras, and a
retrying transaction manager which will retry if a retriable error
occurs (i.e. an OptimisticLockFailedException when writing, or a
ReadFailedException when reading).

This is copied from Genius where it’s used extensively; it’s also used
in NetVirt.

Change-Id: I391ca4ca50d1b1177d827e33c0d11e98378e1fb4
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "MDSAL-361: Deal with restricted types in unions"

This reverts commit 47693173debca78b74858ca15080445fc93d0953, as it
breaks on openconfig-network-instance-types.yang -- the construction
results in wring constants being generated and also conflicting
constructors being present.

Change-Id: If7e3fa155e83d454570beca64e92956e69987b10
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump 2.7.0-SNAPSHOT to 3.0.0-SNAPSHOT

We are just about ready for release, with all significant external
versions harmonized to 2.7.0-SNAPSHOT. Switch this to 3.0.0-SNAPSHOT
in preparation for mdsal-3.0.0.

Change-Id: Ia9a6e8e9714e6a75eba479a4e5daf56ab5520a89
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update iana-if-type revision and packaging

This bumps packaged model to the latest available registry
and repackages it to match packaging rules.

Change-Id: I0947f90bedf8c628eaf6e68c21344ef72ed0c6cd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup binding spec artifact versions

This bumps binding specification and related artifacts to version
1.0.0-SNAPSHOT.

Change-Id: Ia9fa86179e13eb5ec4a00a519ebba56311722a64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Harmonize parent versions with MD-SAL version

We want to keep entrypoints at the same versions -- i.e.
mdsal-artifacts and all parents, so users have an easier time
figuring out inconsistencies.

Change-Id: I014ef6db9649a9f8b42a2bf5ab76776a8816c467
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove common/parent

This parent is not used anywhere and it is rather dysfunctional,
remove it.

Change-Id: I2f0c78f8a28c612f91997dc1478dd8d296abd6e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove binding2/prototype

This code is not plugged into build, hence it is pure clutter.

Change-Id: I69139ceef2a26136a91e9c8cbc0ad95559eefc8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup aggregator poms

Aggregators should not be installed/deployed and should have
a version harmonized with project version (2.7.0-SNAPSHOT).

Change-Id: I6090c70adbef38fbc3cf3e4f93a551e484f664cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Introduce features-mdsal-experimental

This is a repository for experimental features, currently holding
Binding V2.

Change-Id: I7154f1c2f59556cf77b55ae902815a6fae480820
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move model features into top-level directory

This eliminates the second feature directory, concentrating all
features in one place.

Change-Id: Idb86b943d59cf5ad532dda8675b9fc2e781e692e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove features-mdsal-model

Integrate this feature repository into features-mdsal and remove
it.

Change-Id: I53914985e6001e551720379843b8865093831bd6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move features to top-level directory

Move our core feature repository and related features to a top-level
directory.

Change-Id: I6324db25c51ce8e43138e63bc0afe0d010b51b1c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add ForwardingTransaction

This is an aspect shared by all three flavors of forwarding
transaction, hence we can factor the code out into a common
subclass for reuse.

Change-Id: I2837d20084f54350337a111a0808dbaa2391145e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Split off Read/WriteOperations from Read/WriteTransaction

It is oftentimes useful to allow access to a transaction's operations
without allowing the state of the transaction to be modified. This
patch splits off operations from transactions, so proper isolation
can be maintained.

This also resolves the issue of ReadWriteTransaction having both
cancel() and close() methods -- since it has a write aspect, it
inherits lifecycle methods from WriteTransaction.

Change-Id: I98c02c0c5cbcac2432f629973860c56cf2818d6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkstyle in mdsal-binding2-java-api-generator

- Fix checkstyle issues and activate enforcement.
Change-Id: Id7400f6eb267c822597cf4ff9adb41ba117d3c70
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Fix checkstyle in mdsal-binding2-generator-util

- Fix checkstyle issues and activate enforcement.
Change-Id: I5e83540c54650f899afa9e711d17f4c3efb2e9f0
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Fix checkstyle in mdsal-binding2-generator-impl

 - - Fix checkstyle issues and activate enforcement.
Change-Id: I5fe421e7389e4c3f1c2d809f6321829b9d7559c5
Signed-off-by: Jie Han <han.jie@zte.com.cn>

MDSAL-361: Deal with restricted types in unions

- Simply address the issue by adding a numeric suffix
  to member type name of the union.

Change-Id: Ie096f9e4795766ca8729daee6f54947ce90d964b
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Bump yangtools to 2.1.1

This bumps yangtools to 2.1.1 to version-converge with odlparent-4.0.2

Change-Id: I6cbbb0bfe9029551d3ac69e6f56283e02694aae0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove AsyncDataBroker and related classes

DOM and Binding APIs need to evolve separately, remove the common
straightjacket they were using.

Change-Id: I91f49284c61020fff4b4e262aa03c0a7eca70a06
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove common.api.TransactionChain

This interface needs specialization for both DOM and Binding
levels. While this was partially done, the TransactionChainListener
inteface ended up being clunky.

Disaggregate the TransactionChain concept, by completely eliminating
it from common-api. BindingTransactionChain already existed,
so rename it and define DOMTransactionChain. Support classes are
refactored as well.

Change-Id: I899f1844a2ba84fdc74ba507d3235b87f6a43887
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a failing DataBroker

This imports DataBrokerFailures from Genius; this is a test class
which allows faults to be injected into a data broker.

Change-Id: I89ac278a9291245ca2a1cdc42e14ced4656695b4
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix BindingDOMOperationProviderServiceAdapter

This class did not have proper supressions and missing @Override
annotations.

Change-Id: I4850593c95527679462284a61f4d8e036fc50e55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix some raw types

Add trivial parameterization to silence eclipse.

Change-Id: I92642b35426f9582ff4578835c0c34146ced207a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded SuppressWarnings

We no longer do unsafe casts, remove suppression.

Change-Id: Id8fbd7b9a156265b4a18457c18561129001402e9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused import

BaseTemplate no longer uses GTO, remove the import.

Change-Id: I43259e05f251ea87083abd382f7e727d4ffd9624
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix KeyedListAction serialization

SchemaRootCodecContext needs to understand both Action and
KeyedListAction, as their parameterizations differ.

JIRA: MDSAL-371
Change-Id: I405a73b1a8ca8801ae1786be704cefe674c5fb72
Signed-off-by: Jakub Tóth <jakub.toth@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 4.0.2

This bumps the versions to receive updates of plugins.

Change-Id: If5c9346d221d5c4af6e4357b0c0847bc88465dbe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make sure we aggregate sonar reports

odlparent-4.0.0 is broken w.r.t. sonar, fix this up by aggregating
our execution reports.

Change-Id: I544fb6d196794e25d3892f7fffab44899840793d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to yangtools-2.1.0

This bumps from snapshot versions to release versions, bringing
us closer to mdsal-3.0.0.

Change-Id: I7cbc43f8814386fd5570ce37c3b96faf2c1f9a91
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

MDSAL-370: expose LogicalDatastoreType-aware constructor

This exposes the constructors needed to customize the underlying
data tree instances -- both through direct configuration and via
LogicalDatastoreType.

Change-Id: I056d74f4059cca792aa49e5463570b35e1d0005a
JIRA: MDSAL-370
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b1b71b0d804ed75853e31f92aa61258dcaf503fe)

Switch to odlparent-4.0.0

Now that odlparent-4.0.0 has been released, we can nail down that
version, getting us closer to our release.

Change-Id: I4669b27c013bd30101db0f45e0ba866da1dbb26e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Require in-memory datastore

mdsal-binding-dom-adapter publishes test-jar for downstreams,
which does not work if IMDS is excluded. Fix that up.

Change-Id: Iefeec6707e5dd94647591dedaba0481cebe07db3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Avoid depending on immutables.value at runtime"

This reverts commit 41896a415dd61236b5c385ee1d00b1a61a61a761. It is
no longer needed with immutables-2.7.1.

Change-Id: I61ca9b18899ad4d4168a0d3f7ba95744d71c8098
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

MDSAL-151: Add add/del utility methods to builders

- Add 'addTO{ListFieldName}' and 'removeFrom{ListFieldName}'
  to *Builder if there exists list properties.

Change-Id: Id01e93915ea9b5c7a4c42414fe370118ba8df134
Signed-off-by: Jie Han <han.jie@zte.com.cn>

MDSAL-17: Binding V2 - Simplify InstanceIdentifer creation

- Add a static method getInstanceIdentifier to generated interface
  of datastore nodes:

  - If there are list items, just toke its key as inputs, like:
    getInstanceIdentifier(key1, key2,...),

  -Or it would simply be getInstanceIdentifier().

- For choice/case's children data nodes, II does not reference
  choice or case but through them.

- Add unit tests.

Change-Id: Iea592557668fd7a8ab8e6874caaac7b9e834a859
Signed-off-by: Jie Han <han.jie@zte.com.cn>

mdsal-dom-inmemory-datastore only a test dependency of mdsal-dom-broker

found in https://github.com/vorburger/opendaylight-etcd/commit/097e0c1c62bc8dac2eef319ff7e2d273aabfd681

Change-Id: I70891d7d30364e0f0cc285fe930af95a5a4288ad
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Rename RFC7277 model artifacts

This patch renames ietf-ip artifact to follow unified naming.

Change-Id: If1cb032a2e66174d83ab931902e505665e4394ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename RFC7223 model artifacts

This patch renames ietf-interfaces artifact to follow unified naming.

Change-Id: Ibc615bc78f16a2b7f281e5eba4ed58f137a0b982
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename RFC6991 model artifacts

This patch renames ietf-{inet,yang}-types artifacts to follow
unified naming.

Change-Id: I72e14257f9df4487e8f26940178dee244a4e32cd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge branch 'mdsal-trace' from controller

Moved code from controller.git:opendaylight/md-sal/mdsal-trace
to mdsal.git:opendaylight/md-sal/mdsal-trace

Issue-Id: RELENG-1170
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I653644cd465e069331ca1cffdfa3502515a08771

Merge branch 'blueprint' from controller

Moved code from controller.git:opendaylight/blueprint
to mdsal.git:opendaylight/blueprint

Issue-Id: RELENG-1170
Change-Id: I06d81bd60410e174222762d4eaee1811cac9bcb8
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Extend BindingNamespaceType

- Extend BindingNamespaceType with 'Notification' and 'Operation'
  to distinguish data nodes from notifications and operations.
  It's useful to guide renderers to generate code like
  'getInstanceIdentifier' which is only needed by tree data nodes.
- Make binding namespace type of augmented nodes inherit target
  type's.

Change-Id: I5b7b598d1db40b8d2b70707b0d3ba6f41f9b9fd3
Signed-off-by: Jie Han <han.jie@zte.com.cn>

MDSAL-310 Binding v2 codec - Instance identifier should not reference choice/case.

- Since choice and case are not data tree nodes,
  InstanceIdentifier should not reference choice/case
  as well as YangInstanceIdentifier.

JIRA:MDSAL-310

Change-Id: I881a88bfce337ab3a5d9f2a648cf16ead8214e98
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Lower warn level in AbstractInvokableServiceMetadata

The warning "interface interface X has no accptable entries, assuming it is satisfied"
is emmitted quite often from RpcServiceMetadata, ie for every routed RPC I believe.
I'm unclear as to why it filters out routed RPCs here and why it's a warning but
we should at least reduce to debug to avoid the noise.

Change-Id: I954a4b7c6b2a5e0d3fdbe7bbd2cc44b47ef01fdc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Remove AsciiDoc documentation

Completed migrating these files to RST so remove the
AsciiDoc copy.

Change-Id: I92862e9bb3cd7e0d1263627da47a753319fb68dd
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Migrate conceptual-data-tree to RST

Change-Id: Ic3c417a1f985055b0a80e3162940480c674d4712
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix findbugs warnings

Upgraded findbugs finds these, fix them up.

Change-Id: Id5a008cddc6616c3a93f0528efca00b86843fc3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix findbugs warnings

Upgraded findbugs finds these, fix them up.

Change-Id: Id5a008cddc6616c3a93f0528efca00b86843fc3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Binding2 - Add yang and tests

- fix resolve action in generator
- add yang and tests

Change-Id: I81d100f5deb071a8f0f3b9a9a76c36be0051d652
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Binding2 - Do not confuse routed RPC with Action

DO not mix the concepts of RPC and Action which would
mislead users.

Change-Id: Ic3ba521c5365c93e2ebd0e18942127ac7dfac057
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Binding2 - Add ActionServiceAdapter

Add ActionServiceAdapter to adapt DOMActionService.

Change-Id: I303ab2007561f2b348d4e691fa04d9b49f0eaf1c
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Binding2 - Remove operation invokers

Just remove them as we could call 'invoke' directly.

Change-Id: I0a24937d3171b4c5e3dc46360ada6531b55b287d
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Rework ClusterSingletonServiceGroupImpl locking

The problem we are are seeing is a classic AB/BA deadlock, hence
we need to change how serviceGroup is handled. This patch reworks
ClusterSingletonServiceGroupImpl to separate state tracking from
service startup/shutdown mechanics.

State locking is separated out into three domains:
- entity state, guarded by ClusterSingletonServiceGroupImpl object
- service membership, tracked in a ConcurrentMap
- service instantiation, guarded by a simple CAS-based lock

Furthermore anytime state changes, we mark this fact in a volatile
variable. Whenever we observe dirty state, we attempt to reconcile
it -- if we can also acquire the service instantiation lock.

Each registered service is tracked separately, so we do not have
to have wholesale aggregator futures for stopping services and can
also start newcomer services without causing weird state tracking
disruptions.

Splitting state tracking and service instantiation leads to faster
group shutdown, because when a group is being closed we know we can
unregister the service entity irrespective of the state of user
services. Unit tests, especially asynchronous, are updated to account
for this accelerated shutdown procedure.

This has the benefit of improving inter-node failover latency,
because the process of user service shutdown and service entity
unregistration runs concurrently. That leads to lower likelihood
of the new service entity owner having to block on becoming
the cleanup entity owner, as services which shut down quickly
will have released the cleanup entity by the time the new owner
is selected.

JIRA: MDSAL-362
Change-Id: I7cd82f81da9135591e4242a196cc0f06a78973a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Binding2 - Implement RpcActionProviderService

Use inner class to simplify implemetation of adapter as
there's only one method 'invoke' in Rpc or Action/ListAction,
we then could take the implementation directly instead of
initiating xxxInvoker for every adapter.

Change-Id: Ide6247c4692aeb496d3bf85c918eef530a4e18cd
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Fix set schema context to action routing table

Change-Id: I33b400f05a0fafa01f64f64c599e457257f3ae02
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Make DefaultDOMRpcResult usable with DOMRpcResult redefinition

Since DOMRpcResult can now return a proper collection, users need
the ability to use that return to instantiate a DefaultDOMRpcResult,
but the constructor mismatch prevents that. Fix it.

Change-Id: Id1720a3b429f27aea6d971529687766090090ddf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate mdsal.common.api transaction-related interfaces

Sharing these interfaces between DOM and Binding world is actively
hurtful, as we cannot evolve them independently. Deprecate them
as a first step towards their elimination.

This also defines missing interface concretizations, to make
the transition easier.

Dealing with TransactionChains requires a separate patch, as that
cannot easily (if at all) be done breaking APIs.

Change-Id: Ib899f4dbf6c5bfb596a17fb025c913a03e00fa67
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix DataValidationFailedExceptionTest warnings

Type safety here is easily fixed.

Change-Id: I06b558ab90635c5b95e9ad306edc31ee1c7335fe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix typo and broken link in docs

Change-Id: I1d85940d7e8d5cd76177f74a4d1e7fbd9f870199
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>

Change InstanceIdentifier serialization format

This patch uses serialization proxy in order to get rid of use
of reflection in InstanceIdentifier serialization.

Change-Id: Ic146a80cba0e6e3aeaab75e805c6ca243fe047f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove deprecated InstanceIdentifier methods

This removes all deprecated methods in InstanceIdentifier,
slimming each instance down a bit.

Change-Id: I62cfaa9d4ce8f9672355822c3fb5d92f5c833249
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove deprecated BindingGeneratorUtil methods

These methods have their replacements and have been scheduled
for removal for quite some time. Do that now.

Change-Id: I1572c7a88ad4301704020536185de879fd260952
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove TypeProvider.javaTypeForYangType()

This has been deprecated for some time, remove it.

Change-Id: I9bb48986a3c72b128934f9539d59bb6b34950f46
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove deprecated BindingReflections methods

These methods have their replacements directly in YangModuleInfo,
remove them.

Change-Id: Ic38166ec0b94a74e78d6cedcde9358adae7b1fe0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move mdsal-artifacts to toplevel

As per best practices, move mdsal-artifacts to the root of our
project.

Change-Id: Ibb9880aa4875d706a04a3dd7c94e7796dd4ee1ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove mdsal-model-artifacts

Integrate the declarations into mdsal-artifacts and remove
mdsal-model-artifacts.

Change-Id: I4247d3ebe07cb9d5b689b70ec613782afcc06631
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove references to odlparent-artifacts

We are getting these already declared, no need to repeat
the declarations.

Change-Id: If2f3b97ce9e42554c518c3f9266b771184e9f978
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate mdsal-model-artifact references

Use mdsal-artifacts instead, or no imports when not needed.

Change-Id: I13d1847c6b9c079e9572091d7988c847c87593bf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Include mdsal-model-artifacts in mdsal-artifacts

mdsal-model-artifacts is going away, include it in mdsal-artifacts
so users can be migrated.

Change-Id: I72d9be3b91c866168ebbf24a67483260cba29e15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix mockito deprecation warnings

This fixes up all of the mockito warnings.

Change-Id: Ic0ca9b903c1c7cec001a4df0d2ca4d26b6a9db63
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup API components

- migrate to eclipse annotations where feasible
- import static utility methods checkState/requireNonNull

Change-Id: Ic5c36783695086d074cc5f9e3fec0a084c4f5356
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use com.google.common.base.Predicate

We have Java 8, hence we can reduce the API surface.

Change-Id: I93e9b7e046d3a57ec397bda5b2756a250b1d1c21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate com.google.common.base.Supplier

Java 8 provides and enquivalent, migrate to it.

Change-Id: I93e23cd7548e2135aae9ea20a2734347282901d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>