jenkins-releng [Tue, 17 Oct 2017 01:39:42 +0000 (01:39 +0000)]
Bump versions by x.y.(z+1)
Change-Id: Ibda3c2b284a823eaa9e25c29cadf91b2b69dd426
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Stephen Kitt [Thu, 10 Aug 2017 08:38:23 +0000 (10:38 +0200)]
Karaf 3 features must only use other K3 features
Use the Karaf 3 AAA repository, features-aaa, not the Karaf 4 AAA
feature, odl-aaa-cert.
Change-Id: Ia0190e43a5a1290246c2b4c614a228725c2ed49c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 31 Jul 2017 14:20:00 +0000 (16:20 +0200)]
Add missing Karaf 3 dependency
ovsdb's southbound-utils now needs the ovsdb library, so
odl-neutron-hostconfig-ovs needs to pull in the latter.
Also odl-aaa-cert is needed.
Change-Id: I42a8f3c5d25d28e7cc58f8738d722f65e65fb877
Signed-off-by: Stephen Kitt <skitt@redhat.com>
jenkins-releng [Fri, 14 Jul 2017 12:49:20 +0000 (12:49 +0000)]
Bump versions by x.y.(z+1)
Change-Id: Ia82c6b9a98ef8d81df9b389027288329db90242c
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Stephen Kitt [Mon, 12 Jun 2017 09:26:23 +0000 (11:26 +0200)]
Bug 8660: use southbound-artifacts
Instead of pulling in odl-ovsdb-southbound-api as an artifact POM, use
southbound-artifacts.
Change-Id: I6ca7f82b66fa4e2680393afc3efbac0ce151cd20
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
ce9eb785f9a663b34143b6f44004721231266327)
jenkins-releng [Thu, 25 May 2017 18:18:08 +0000 (18:18 +0000)]
Bump versions by x.y.(z+1)
Change-Id: I27b20b7cfb33f566fd195c4090e4d3984ecfa32e
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Isaku Yamahata [Thu, 4 May 2017 13:45:24 +0000 (13:45 +0000)]
Merge "use com.google.common.net.InetAddresses.forString()" into stable/carbon
Tomas Cechvala [Tue, 2 May 2017 11:33:28 +0000 (13:33 +0200)]
Updating yang revisions in hostconfig for VPP
Added 2017-03-15 revision for honeycomb 1704
Config file is automatically copied to ${KARAF}/etc
Change-Id: I1b8bfa4d1f7230252286ead5b95af8c1c3192f70
SIGned-off-by: Tomas Cechvala <tcechval@cisco.com>
Signed-off-by: Dileep <dileep.ranganathan@intel.com>
(cherry picked from commit
d5079246d47bda7f666777f8c8ec4b6329b1d980)
Isaku Yamahata [Thu, 27 Apr 2017 22:57:23 +0000 (15:57 -0700)]
use com.google.common.net.InetAddresses.forString()
instead of InteAddress.getByName(), use
com.google.common.net.InetAddresses.forString which is better.
Change-Id: Ic7405524882f94ecdd614f0b533deb093db0c8f3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
(cherry picked from commit
cf6ad21ed78ca6cf0bded50d4bd276c8ee892310)
Josh [Sun, 23 Apr 2017 08:29:01 +0000 (11:29 +0300)]
Add service-provider-feature for operational port status
This commit adds a service-provider-feature for port-status,
operational-port-status. This feature should be set in operational
when netvirt knows how to update port status in operational when
a port becomes active.
Change-Id: I7fe7c6998f67380338e240355def7d2676c98335
Signed-off-by: Josh <jhershbe@redhat.com>
(cherry picked from commit
bca831814105d7688024d9e56ce4ddc29c312ea7)
Lorand Jakab [Wed, 19 Apr 2017 18:40:20 +0000 (21:40 +0300)]
Prepare for checkstyle version upgrade
Checkstyle will be upgraded from 6.16 to 7.6.1 with [0]. This patch
fixes failres seen by the new version.
[0] https://git.opendaylight.org/gerrit/#/c/55227/
Change-Id: Ia84e1515810d162e0e813bdfeaec10721d06bba5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Anil Belur [Tue, 11 Apr 2017 01:26:30 +0000 (11:26 +1000)]
Update .gitreview to stable/carbon
Change-Id: I20304748203df8c04b26c18e65979229d48a20ad
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Isaku Yamahata [Fri, 17 Mar 2017 05:52:59 +0000 (22:52 -0700)]
transcriber: remove redundant code in l2gw
Change-Id: I44c48614c1b2fa2aa2268c0cecf275b7638e7e68
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 17 Mar 2017 04:58:40 +0000 (04:58 +0000)]
Merge "transcriber: qos policy rule"
Isaku Yamahata [Fri, 17 Mar 2017 02:29:49 +0000 (02:29 +0000)]
Merge "Neutron Model update"
Isaku Yamahata [Fri, 17 Mar 2017 01:58:35 +0000 (18:58 -0700)]
transcriber: qos policy rule
QosPolicyRuleBuilder is wrongly allocated.
It should be allocated per each rule.
Change-Id: Ib5f35c48e7933bbbfe133993f64abd7a5379286d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Ritu Sood [Tue, 7 Feb 2017 02:09:04 +0000 (18:09 -0800)]
Neutron Model update
This patch includes Neutron API/model changes being
introduced.
1) Status field to be moved to operational datastore
Breaking out the status field from this patch
for ease of review and merge process.
Link to status field patch
https://git.opendaylight.org/gerrit/#/c/51981/
2) Project id field is going to depreciate tenant id
https://lists.opendaylight.org/pipermail/neutron-dev/2016-December/001083.html
This fix addresses top level tenant-id used my most models.
Some models internally also use tenant-id in sub-fields. Those
cases will be addressed in Nitrogen.
3) revision number field to be added. This is a monotonic
counter that will be updated whenever an object is updated
on the neutron server.
Change-Id: I8a76fe5ff1147a9e4456c0713913377f266cec24
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 10 Jan 2017 02:22:55 +0000 (18:22 -0800)]
Karaf4 migration
Based on https://wiki.opendaylight.org/view/Karaf_4_migration
This patch try to implement karaf4 migration patch. not tested yet.
The some dependency needs fix.
Can odlparent/features-test be used with karaf4?
Change-Id: I24928524c478b5b4083ccfbd9deffba05826f65b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
Chandra Mohan [Tue, 7 Mar 2017 09:18:30 +0000 (14:48 +0530)]
updating neutron-qos yang file for Qos Rule Types to change the model from Config to Operational and incorporating the review comments.
Change-Id: Ib195c222f5009b190e4307c904517ad96ff27e22
Signed-off-by: chandrag <chandramohan.grandhi@tcs.com>
Isaku Yamahata [Mon, 6 Mar 2017 22:15:11 +0000 (22:15 +0000)]
Merge "Add missing <name> fields for pom.xml files"
Isaku Yamahata [Sat, 4 Mar 2017 00:17:32 +0000 (00:17 +0000)]
Merge "Bug 7848: Allow neutron port create with security disabled."
Isaku Yamahata [Sat, 4 Mar 2017 00:10:59 +0000 (00:10 +0000)]
Merge "Add missing <name> fields for pom.xml files"
Isaku Yamahata [Sat, 4 Mar 2017 00:05:06 +0000 (16:05 -0800)]
Add missing <name> fields for pom.xml files
The patchset of
b184367fef0217aa0466f86d6614cf821d74cf60
added name fields to pom.xml. Due to patch merge order,
neutron-hostconfig/vpp/pom.xml isn't updated.
This patch fixes it up by adding <name> fields to it.
Change-Id: I256390812a40fa2727fc2d33592aec047cafe8c5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Tomas Cechvala [Mon, 13 Feb 2017 17:19:30 +0000 (18:19 +0100)]
Hostconfig for VPP
L2 configuration is currently supported for VPP devices.
Vhostuser vif-type is used for VMs (endpoints).
Configurable fields:
- socket directory
- socket prefix
- vhostuser-mode (client, server)
ODL connects to VPP nodes via NETCONF. When a node is
recognized as VPP node based on its capabilitites
host configration is written to datastore.
Change-Id: I78b6ad2eeb3d1b11b09317f4c9be0e6878e71df8
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
Anil Belur [Fri, 3 Mar 2017 07:37:04 +0000 (17:37 +1000)]
Add missing <name> fields for pom.xml files
This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:
ODL :: <groupId> :: <artifactId>
This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522
Change-Id: I08fff282973944e135b981f98fcebcde156c7e60
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Isaku Yamahata [Fri, 3 Mar 2017 05:53:15 +0000 (05:53 +0000)]
Merge "Adding checkstyle checks to hostconfig"
Isaku Yamahata [Fri, 3 Mar 2017 03:40:34 +0000 (03:40 +0000)]
Merge "yang model: add service provider feature model"
Isaku Yamahata [Mon, 27 Feb 2017 23:04:24 +0000 (15:04 -0800)]
Bug 7848: Allow neutron port create with security disabled.
Add default parameters in test validation.
Change-Id: Id5fcf5701763d72274a96f1a0af29a7546bc24f8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Achuth Maniyedath <achuth.m@altencalsoftlabs.com>
Isaku Yamahata [Wed, 1 Mar 2017 04:47:16 +0000 (20:47 -0800)]
AbstractNeutronNorthbound: remove unused local variable
remove unused local variable, parameterizedType, in
AbstractNeutronNorthbound.
Change-Id: I7b77750abb3455b39ff3eeb636f1b9cc255ca2a6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Mon, 20 Feb 2017 16:24:38 +0000 (11:24 -0500)]
yang model: add service provider feature model
As ODL is starting to add more functionalities like port status update
for networking-odl, the negotiation between networking-odl and ODL
openstack service provider to keep compatibility.
networking-odl is supposed to work with multiple versions of ODL,
multiple instances of openstack service providers. So networking-odl
needs to know what neutron extensions/features is supported by
given ODL version/openstack service provider.
This patch defines a yang model for it so that networking-odl can
retrieve from ODL at start up and configure itself.
Change-Id: I90b6bbc3079559209fb444ab79cc88af6a2dc58a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Ritu Sood [Thu, 16 Feb 2017 02:26:46 +0000 (18:26 -0800)]
Adding checkstyle checks to hostconfig
Hostconfig directory is missing checkstyle checks.
Updated pom file to add checkstyle and also fixed
checkstyle issues.
Change-Id: Id0ff1226e3b23ebac521959de15da0331af7118a
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Isaku Yamahata [Mon, 13 Feb 2017 20:20:23 +0000 (12:20 -0800)]
model/neutron extension: add configuration string
Add configuration string to neutron-extension-attribute.
So that ODL openstack service provide can negotiate with networking-odl
about more details on each extension.
For example, neutron QoS API needs supported QoS rules.
key" "neutron:qos"
configuration: {"supported_rules_types": ["bandwidth-limit"...] }
Also neutron-extension can be used for general negotiation between
ODL and networking-odl. e.g. port::status update is supported etc.
key: "ODL:status-update"
configuration: ["network", "port", "router", ...]
TODO: coordinate/document key/configuration in central places.
Change-Id: I7ba7dc21ac0fda7fb40c5f44b99c3b3753c79b9d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Ritu Sood [Fri, 23 Dec 2016 03:34:08 +0000 (19:34 -0800)]
Move hostconfig functionality to Neutron Northbound
This patch moves hostconfig functionality from Netvirt
to NN project. The code is organized to support multiple
southbound implementations. This patch includes
support for hostconfig for OVS.
Change-Id: If428cd3e0c1c466342888f46f17a1916176f0fc6
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Isaku Yamahata [Wed, 1 Feb 2017 17:54:40 +0000 (10:54 -0700)]
gitignore: remove MANIFEST.MF
Now MANIFEST.MF is created under target directory.
There is no need to ignore MANIFEST.MF and MANIFEST that is not under
target/ directory should not be ignored.
Change-Id: If87003eb0fa38e78164df6ee36a9ed4471c35fcf
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 1 Feb 2017 15:03:06 +0000 (15:03 +0000)]
Merge "deploy-site.xml: update version"
Isaku Yamahata [Fri, 27 Jan 2017 00:03:28 +0000 (16:03 -0800)]
pom: create MANIFEST.MF under target directory
Somehow MANIFEST.MF is generated as src/main/resources/META-INF/MANIFEST.MF.
This causes that mvn clean doesn't remove it.
It's not usually expected. make manifestLocation property default to
be created under target directory.
Change-Id: Id5610e1c824805446fbff0e8cafa5c9a484f05d3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 25 Jan 2017 23:48:54 +0000 (15:48 -0800)]
deploy-site.xml: update version
Change-Id: I07991a89890e27d39e5304ad98277f27bbdf8ed3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Vishal Thapar [Sat, 14 Jan 2017 13:20:42 +0000 (18:50 +0530)]
Add support for Openstack Neutron Trunkport APIs
This adds the following:
1. Yang model for TrunkPort Openstack Neuton v2 extension
2. Implementation of API (spi, api and transcriber)
3. UTs for testing spi
4. ITs for E2E testing of API
External References:
https://blueprints.launchpad.net/neutron/+spec/vlan-aware-vms
http://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html
https://wiki.openstack.org/wiki/Neutron/TrunkPort
ODL Driver: https://review.openstack.org/#/c/421895/
Change-Id: I1428e44f93a5bc4507ad5b39c1f2f9f92540fab8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Isaku Yamahata [Wed, 11 Jan 2017 15:48:38 +0000 (15:48 +0000)]
Merge "neutorn-spi: more remove neutron prefix of field"
Isaku Yamahata [Tue, 10 Jan 2017 23:09:25 +0000 (15:09 -0800)]
neutorn-spi: more remove neutron prefix of field
The changeset of
a2f1a28cb8b6c226f49716434cd8ccc34c43eaa4
the change id of I81984a294b4601bfb18b24140d03d615dba1424a was
imcomplete somehow.This patch removes remaining neutron prefix in spi.
Change-Id: I935e2028fc436cd01e8eb930eb5811f4dca26575
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 10 Jan 2017 17:40:00 +0000 (09:40 -0800)]
NeutronLogger: minor code clean up
remove unnecessary methods in NeutronLogger
Change-Id: I72cd2ebc6093cd48d714ed4d11abb6a47405c65e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 14 Dec 2016 22:35:30 +0000 (14:35 -0800)]
apiece unchecked cast warning
Eliminate unchecked cast warnings.
In some places we have to use @SuppressWarnings("unchecked")
unfortunately.
Change-Id: Ibaaeebabe86ec645bc61d68389c611b0a0bdc399
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 10:16:06 +0000 (02:16 -0800)]
neutorn-spi: remove neutron prefix of field
field name of neutron spi doesn't prefix neutron.
The following three classes have the fields with neutorn prefix.
NeutronL2gateway, NeutronL2gatewayDevice, NeutronLoadBalancerListener
remove prefix of the fields of those classes For consistency.
Change-Id: I81984a294b4601bfb18b24140d03d615dba1424a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 09:19:12 +0000 (01:19 -0800)]
checkstyle: remove suppression
Now there is no need of suppression for checkstyle.
remove checkstyle-suppressions.xml.
Change-Id: I1fe08a85542f52fcd94bf76f369b66bd0d02def6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 09:04:13 +0000 (01:04 -0800)]
checkstyle: AbbreviationAsWordInName
fix AbbreviationAsWordInName and enable AbbreviationAsWordInName.
Change-Id: I6d0756598b7d2a000325b4986e2752aacfd30eb3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 06:49:06 +0000 (22:49 -0800)]
checkstyle: TypeName
eliminate TypeName violation and enable it.
Change-Id: I97af3891eafc965176fa34f17176b62d897122a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 05:05:58 +0000 (21:05 -0800)]
checkstyle: JavadocStyleCheck
fix JavadocStyleCheck and enable it.
Change-Id: I1689aebded15605474c3ef388e433a87577d190a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 04:57:57 +0000 (20:57 -0800)]
checkstyle: enable SummaryJavadoc
fix SummaryJavadoc and enable it.
Change-Id: I68a464c78aacbb54d54b198b267d616d228e7403
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 02:16:43 +0000 (18:16 -0800)]
checkstyle: enable JavadocTagContinuationIndentation
Eliminate the violation of JavadocTagContinuationIndentation and enable
it.
Change-Id: If854fa71db3115200f57faa8c06c0dd1e8995c0c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 02:08:10 +0000 (18:08 -0800)]
checkstyle: enable JavadocParagraph
Eliminate the violation of JavadocParagraph and enable it.
Change-Id: I1f114f516d96bf0d3f5530d92e876b788cd73af6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 01:56:50 +0000 (17:56 -0800)]
checkstyle: eliminate ConstantName violation
Eliminate ConstantName violation of checkstyle and enable it.
Change-Id: If124294de812c3b6f022edbe0d1540c78eeae2d8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 17 Dec 2016 00:48:58 +0000 (16:48 -0800)]
checkstyle: enable LocalVariableName
fix LocalVariableName violation of checkstyle and enable it.
Change-Id: I6945ac54f3851772cc848093c56111c142d0723d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 16 Dec 2016 23:43:06 +0000 (15:43 -0800)]
checkstyle: ParameterName
Fix PrameterName checkstyle violation and enable it.
Change-Id: I7f06123fcd1fb5a6db1f47672c788aeb521814ec
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 16 Dec 2016 20:31:56 +0000 (12:31 -0800)]
checkstyle: suppression to ignore files under target
the changeset of
f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a
in odlparent introduced new supression to ignore sources under
target. This patch catches up it.
Change-Id: I7f35dffea41dbfc939238db0014632a2cd44fa18
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 16 Dec 2016 23:06:18 +0000 (15:06 -0800)]
checkstyle: use our own checkstyle-suppressions.xml
The changeset of
f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a in odlparent
defines its own checktyle-suppressions.xml. so that neutron northbound
fails to build because unintented suppression rule is used.
Make it sure that intended supressions are used.
Change-Id: Ifb14d25e5b7b374515274ef9644e35fe64dde5a4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
wangqianyu [Tue, 29 Nov 2016 01:32:06 +0000 (09:32 +0800)]
BUG-7259: pool-attributes have wrong description
n neutron-lbaasv2.yang, the description of healthmonitor-id in
pool-attributes is as follow:
leaf healthmonitor-id {
type yang:uuid;
description "List of healthmonitors
associated with this pool.";
}
here, healthmonitor-id is not a list, so the description need to be modified
Change-Id: I69709af3585bf66c8a4e25a239bc3e071e9bc809
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>
wangqianyu [Tue, 15 Nov 2016 08:20:19 +0000 (16:20 +0800)]
BUG-7185 NeutronLoadBalancerListener has wrong xmlElement name
Fixes bug 7185
lb listener from openstack uses loadbalancers as xml key value,
so the XmlElement name of load_balancers in
NeutronLoadBalancerListener need to be changed to loadbalancers
Change-Id: Id05e4fedc9e516aca45f4c2fac4b3763ee9a1ed8
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>
Isaku Yamahata [Sat, 12 Nov 2016 23:07:14 +0000 (15:07 -0800)]
NeutornLogger: print data when node is deleted
Log data of deleted node.
Change-Id: I84ae522cb49453f3d5d2b7812aecfe00628fa9dd
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 19 Oct 2016 23:10:38 +0000 (23:10 +0000)]
Merge "Bug 6938 - Handle unknown protocol name as bad request"
Ryan Goulding [Wed, 19 Oct 2016 17:38:43 +0000 (13:38 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent
Change-Id: I36e42dac7ccc13f0f796bb95a28a6f30f141b05c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Ritu Sood [Tue, 18 Oct 2016 01:32:54 +0000 (18:32 -0700)]
Bug 6938 - Handle unknown protocol name as bad request
Fwaas, security group rule handled unknown protocol
name as internal server error. Changed that to respond
with bad request. lbaas ignored the wrong protocol field.
Also chaged that to respond with bad request.
Change-Id: I681d67b8704015b392ee811b0f4b1556a63b5809
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Anil Vishnoi [Thu, 6 Oct 2016 02:22:17 +0000 (19:22 -0700)]
Bug 6865 - Transcriber skips the uppercase protocol field
Networking-sfc sends protocol string in lowercase
(e.g tcp and not TCP), but neutron spi try to find
it using the uppercase and don't find it and
eventually ignore this field. To be consistent with
other API's, flow classifier will only accept lowercase
protocol name and return 400 (Bad Request) for any other
protocol string.
Change-Id: I204f58c9cf1cf13446122c8f818ce498866a2caf
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Ritu Sood [Thu, 22 Sep 2016 02:20:01 +0000 (19:20 -0700)]
Fix checkstyle issues related to exception handling
This is based on the Guidelines given here
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#IllegalCatch
Change-Id: I70f9841f706c8d5c38b0834dba04b79ad8fbfa71
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Isaku Yamahata [Thu, 6 Oct 2016 23:16:53 +0000 (23:16 +0000)]
Merge "sonar: Move this trailing comment on the previous empty line."
Isaku Yamahata [Thu, 6 Oct 2016 23:16:46 +0000 (23:16 +0000)]
Merge "sonar: use dedicated exception instead of RuntimeException"
pramod [Sat, 24 Sep 2016 08:39:23 +0000 (01:39 -0700)]
Bug 6796 - Fixes Priority bugs in integration-test
1.NeutronL2gatewayConnectionNorthbound.java:118,
EC_UNRELATED_TYPES, Priority: High
This method calls equals(Object) on two references of different class
types and analysis suggests they will be to objects of different
classes at runtime
2.NeutronL2gatewayNorthbound.java:116, EC_UNRELATED_CLASS_AND_INTERFACE
This method calls equals(Object) on two references, one of which is a
class and the other an interface,where neither the class nor any of
its non-abstract subclasses implement the interface.
3.NeutronRoutersNorthbound.java:102, EC_UNRELATED_TYPES - Same as 1st
Bug
Change-Id: I23cda778f807ba02179c7d9d4e682b9561a378d4
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>
Isaku Yamahata [Thu, 6 Oct 2016 18:00:27 +0000 (11:00 -0700)]
sonar: Move this trailing comment on the previous empty line.
remove trailing comment by moving it on the previous empty line.
Change-Id: I72d7e93dd4d60c4773b437c36368d3297e8154d4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 6 Oct 2016 17:56:54 +0000 (10:56 -0700)]
sonar: use dedicated exception instead of RuntimeException
use IllegalArgumentException instead of RuntimeException
Change-Id: I32c17078499ff3cfd17f2d3b445a3e1bdac99574
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 4 Oct 2016 02:30:48 +0000 (19:30 -0700)]
remove unused inUse method
Change-Id: I10053b258e899324c30fff836c9ebd88c2ef216c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 4 Oct 2016 00:15:03 +0000 (17:15 -0700)]
transscriber: consolidate createInstanceIdentifier(T item)
Consolidate InstanceIdentifier<T> createInstanceIdentifier(T item)
into AbstractNeutronInterface.
Change-Id: If6aedc24d9cc4a15cefa7c21ce3d00c51610c0f0
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 30 Sep 2016 07:46:05 +0000 (00:46 -0700)]
transcriber: consolidate createInstanceIdentifier()
This patch consolidate createInstanceIdentifier() into parent class.
Change-Id: I6acf69e2ac328bf71cff3efbd846a72db02df6a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 30 Sep 2016 06:17:28 +0000 (23:17 -0700)]
transcriber: refactor fromMd/toMd logic
Since there are several common fields like id, tenant_id, name,
admin_state_up status, factor out those common logic.
Change-Id: If5b11321769890d075eb6a331f1f013de4b5295a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 30 Sep 2016 06:10:59 +0000 (23:10 -0700)]
spi: consolidate common member
Since some fields are common to neutron resource, name, status, admin_state_up,
introduce common parent interfaces/classes to consolidate them.
Change-Id: Ie8b654010f0cf780eaa958b49d38b1ed72847961
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 4 Oct 2016 00:12:25 +0000 (17:12 -0700)]
AbstractNeutronNorthbound: make cast more accurate
Change-Id: I5cd28faedcbe037ae976e038f3f70ecae644f857
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 27 Sep 2016 04:37:26 +0000 (21:37 -0700)]
spi: consolidate extractFields logic
NeutronObject is common class to have id and tenant_id.
So consolidate extractFields logic to extract them into NeutronObject.
Change-Id: I1e79da6fca9824dbd0563fc09c2dd34843dd99ac
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 22 Sep 2016 18:52:10 +0000 (11:52 -0700)]
sonar: hide NeutronCRUDInterfaces construtor
The class is utility class to have only static method.
Hide public construct not to instantiate it.
Change-Id: Ib78e179c7ec540e0604f2be8c8be65400c1e6f82
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 22 Sep 2016 00:32:21 +0000 (00:32 +0000)]
Merge "Adds SFC Integration test cases"
pramod [Tue, 20 Sep 2016 03:00:06 +0000 (20:00 -0700)]
Adds SFC Integration test cases
Change-Id: Ie6844549f939123687226c3cbde0cd6239a85926
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>
Ritu Sood [Wed, 21 Sep 2016 02:03:38 +0000 (19:03 -0700)]
Checkstyle exception handling fix (Neutron-spi)
Fixing checkstyle violations in the neutron-spi
integration tests
Change-Id: Ic7a1ed9ea6b4c9362fa73df550825da9e34e00e8
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Sat, 17 Sep 2016 04:43:39 +0000 (21:43 -0700)]
Bug 6736: Fix incorrect destination ip prefix value
Value of destination ip prefix read from mdsal
is not correct
Change-Id: I712097aed98bf1d5db581de8d3a8b254065adbef
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Isaku Yamahata [Thu, 15 Sep 2016 09:17:22 +0000 (02:17 -0700)]
spi: NeutronCRUDInterfaces remove unused mothos
remove unused methods in NeutronCRUDInterfaces
Change-Id: I236ad8e294dc40a0fb7055faf56379f00b800d76
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 13 Sep 2016 15:50:29 +0000 (08:50 -0700)]
northbound: simplify neutron interface loading
Now subnets/ports/routers northbound doesn't need dependent
interface. So getNeutronInterface() can be removed.
Change-Id: I7a78ec35a0b7f2efa79840672e257cc7e5724457
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 9 Sep 2016 22:27:21 +0000 (22:27 +0000)]
Merge "Bug 6641: Fix ip_address in allowed_address_pairs info"
Sridhar Gaddam [Tue, 6 Sep 2016 10:46:02 +0000 (16:16 +0530)]
Bug 6641: Fix ip_address in allowed_address_pairs info
Change-Id: Id612243cbdc6ab8db8d66ce46ca2973a0effc0ee
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Isaku Yamahata [Wed, 7 Sep 2016 15:10:52 +0000 (15:10 +0000)]
Merge "Neutron-Logger: add final to public class"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:48 +0000 (15:10 +0000)]
Merge "transcriber: sprinkle final to public class"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:43 +0000 (15:10 +0000)]
Merge "northbound: code clean up"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:35 +0000 (15:10 +0000)]
Merge "neutron-spi: sprinkle final to concrete class"
Isaku Yamahata [Wed, 7 Sep 2016 15:03:52 +0000 (15:03 +0000)]
Merge "simplify NeutronTranscriberProvider"
Isaku Yamahata [Wed, 7 Sep 2016 15:03:46 +0000 (15:03 +0000)]
Merge "Add NeutronSubnetJAXBTest unit test"
Isaku Yamahata [Wed, 7 Sep 2016 08:16:18 +0000 (01:16 -0700)]
Neutron-Logger: add final to public class
Change-Id: I44806c78dc34e8fe2575441f28a774889ac0beda
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 7 Sep 2016 08:14:58 +0000 (01:14 -0700)]
transcriber: sprinkle final to public class
Change-Id: I48d6961a7e774957da1a4120c2ecb36045fee2d1
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 7 Sep 2016 08:04:06 +0000 (01:04 -0700)]
northbound: code clean up
- sprinkle final to public class
- remove unused variable, uriinfo
- misc improvements
Change-Id: Ied5692ef500a768949e7a010266953b097790d7f
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 7 Sep 2016 07:43:10 +0000 (00:43 -0700)]
neutron-spi: sprinkle final to concrete class
Change-Id: I73453299f8ce890309fc7df7c1147f39742d2659
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 3 Sep 2016 00:19:31 +0000 (17:19 -0700)]
simplify NeutronTranscriberProvider
remove unused variables to simplify NeutronTranscriberProvider.
Change-Id: I1d8e7ac5e9506d752ed725920282662d0d73e8d2
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 3 Sep 2016 00:02:55 +0000 (17:02 -0700)]
consolidate NeturonCRUDInterface.fetchNeturonCRUD logic
The logic are mostly same, consolidate them by generics.
Change-Id: I4a38de02b2a11f355581702a711fe9244d835701
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 2 Sep 2016 22:40:48 +0000 (15:40 -0700)]
northbound: make newNeutronRequest concrete method
By this change, about 120 lines are reduced.
Change-Id: Id4838b4e5109d92f01e18e611e869c27b56371e9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 2 Sep 2016 15:35:41 +0000 (15:35 +0000)]
Merge "sort out signature of extraceField method"
Isaku Yamahata [Thu, 1 Sep 2016 21:54:23 +0000 (14:54 -0700)]
Add NeutronSubnetJAXBTest unit test
Change-Id: I62ddd9e0e4ae83866e50e170695871e6891105f7
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 1 Sep 2016 16:21:33 +0000 (09:21 -0700)]
sort out signature of extraceField method
So far, the signature of extractField was not defined cleanly.
Define it clean and simplify convoluted code due to it.
Change-Id: I48387b8df50bd019a735e6272a3850adfd10b0d5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>