Bug 6236: Introduce "mdsal.skip.verbose" property, for build speed

This doesn't "fix" Bug 6236, but works around it - and gives us a low
hanging fruit build performance improvement.

If this change gets accepted, I would make the odlparent -Pq profile set
this to true by default.

In parallel, I'm trying to get a root cause fix in a future Xtend
version. (At which point this could be removed again.)

Change-Id: I108f401fa2fbca6f17a8b23cb098910c5a6021fb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 7064: yang-to-source error on description

Existing logic of formatToParagraph() method doesn't expect a case
when very first text sequence is longer than 80 characters
and crashes in wrong condition branch. This has been fixed and tested
for various inputs.

Change-Id: Iefeb2b4063335561f3277c3ee40b3d9a46c418dc
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

AssertDataObjects with LOG of diff

When running failing tests in CI on build (or simply local mvn CLI),
then the ComparisonFailure for large expected/actual objects, such as
flows, is very difficult to make sense of.

In the IDE one doesn't have this problem, because the JUnit view of IDEs
will interpret an ComparisonFailure and show a very clear side-by-side
comparison of expected VS actual.

This change introduces a LOG, in case of AssertDataObjects failure,
which prints a diff for the ComparisonFailure, which will make analysing
AssertDataObjects based test failures much easier on CI build.

Change-Id: I666fbceeb794f7b810a11c2efa8e33a51afc1b2d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 6859: Cleanup package names for mdsal-binding-generator-util module

The APIs are copied to new package.
Added deprecated annotation to the old api.

Change-Id: I4a9d6dd6ea78e16bdb1b86c9f9235b3db00db836
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>

target-ide/ support by resourceBaseDir using ${project.build.directory}

without explicitly setting this,
org.opendaylight.yangtools.maven.sal.api.gen.plugin.CodeGeneratorImpl
defaults to hard-coded target/generated-sources/spi for
META-INF/services/org.opendaylight.yangtools.yang.binding.YangModelBindingProvider
instead of target-ide.

Minor: Also add target-ide/ to .gitignore of this git repository.

Change-Id: I4155eb666dd6ef028dc2397e32c88cd50db4f0c6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 6859: Cleanup package names for mdsal-binding-generator-api module

Most packages still contain yangtools in the package name in mdsal which seems to be
a by-product of cleaning up of the Java Binding code from YANG Tools to md-sal.

The APIs are copied to new package.
Added deprecated annotation to the old api.
Deleted pkg org.opendaylight.yangtools.sal.binding.model.api.type.provider

Change-Id: Ic120a7ec1f85d8f604aa575047d8bd639630517b
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "Bug 6135: Java binding v1: IAE from provideTypeForLeafref"

This reverts commit a8795e3746f753c21bd09615bc2b582590b9db54.

Change-Id: I7135954d1f9af9579feebfa85681eb6a3439b3c7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 6135: Java binding v1: IAE from provideTypeForLeafref

added tests, fixed condition in isInnerType method

Change-Id: I5ed41b5be3daf68d6d0895c07f955fed2c076e7f
Signed-off-by: Filip Gregor <fgregor@cisco.com>

BUG-7013: do not rely on default character encoding

Generated java files should always be UTF8-encoded,
as that is what our maven settings enforce.

Therefore we cannot rely on JVM-default encoding, but
have to force file output to be UTF8.

Change-Id: Ie24f753fda3ab4d71ec951cf7b725b97678bae7a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Replace target/ by ${project.build.directory}/ to make target-ide/ possible

Change-Id: I32c4c0e8207f58b864e21054d12174ad45dc0e7f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-7009: fix invalid model

The test model is not valid, as it specifies an extension
argument while the extension definition does not allow arguments.

Change-Id: I2bae1ee5eb3dcf4b98875001b2b4a46f2723601b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5947: additional tests for mdsal project #12

Change-Id: Ied67c8b6c479e60ceb4fde54bbc9feeadc7d1be1
Signed-off-by: Filip Gregor <fgregor@cisco.com>
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: additional tests for dom-adapter #11

Change-Id: I290bd0e503b09aed2e24985a28df946292a4a4d0
Signed-off-by: Filip Gregor <fgregor@cisco.com>
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

New test utility AssertDataObjects

This adapts https://github.com/vorburger/xtendbeans to OpenDaylight.

That library can be used as-is for "normal" Java objects, such as Flow
beans, as seen e.g. in https://git.opendaylight.org/gerrit/#/c/42109/.

This change make it possible to use that library to compare actual
DataObject obtained from the DataBroker with expected objects in tests,
as illustrated e.g. in https://git.opendaylight.org/gerrit/#/c/44000/
(Those objects have a number of peculiarities which need adaption,
provided by the classes in this change.)

One can use AssertDataObjects.assertEqualBeans(Object expected, Object
actual)
WITHOUT ever writing any Xtend code, and WITHOUT any code generation,
and use this utility JUST to get a very readable text diff between two
object trees; this will look like shown in this presentation screenshot:
https://docs.google.com/presentation/d/1bnwj8CrFGo5KekONYSeIHySdkoXZiewJxkHcZjXnzkQ/edit#slide=id.g17d8ae4d92_0_150

It is ALSO possible, but not required, to use the text syntax shown (see
linked screenshot) to declare the expected object by copy/paste of that
syntax into an *.xtend source file (from which an Xtend Maven plugin
code
generates Java code), because that text "happens" (intentionally) to be
valid Xtend.

This last step is purely optional though, and while some downstream
projects may adopt this to define expected objects in a readable syntax,
others may not, and simply define their expected objects with normal
Java code and Builders (or reading them from XML, or whatever) - yet can
still use this this new utility - just for a great diff / comparison
kind of view, only.

This code has dependencies on yangtools, mdsal, plus a test
model for its self test - and the external xtendbeans library (which
should be considered like any of the 100s of other ext. deps. we have).

Change-Id: I34aac96bd13b936d6fb76a484a512081c18e0b11
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove augmentableToAugmentations maps

These maps are not needed, hence we can forgo creating and maintaining
them.

Change-Id: Ib366bc3d61d8aca7a6f5f881b8a7c8db30ce8c85
Signed-off-by: Robert Varga <rovarga@cisco.com>

Clean up apparently dead (and not thread safe) code

YangTemplate's private static Module is necessarily always null, so this
is dead code, and it should be perfectly safe, and clearer, to remove
this.

Full disclosure: I actually have absolutely no idea what writeIdentityNs
was originally good for, but don't think I'm breaking anything with this
clean up, because the way the code is now there is no way that this can
ever be anything else than null.

Change-Id: Ib08112c836efdc1c72443a5f93549a96f954dae8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 5947: additional tests for mdsal project #10

- added additional tests
- refactored some util classes
- properly fixed some issues and checkstyle validations

Change-Id: Ibd483985bfc5bed23d61c7c81695398abdd427ae
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 1411-5 #1: MDSAL Binding2 Generator Util

new constant definitions
change of variable initialization order
fixed equals method

Change-Id: I41f7cacc2e7e21f0ac69b7e8a0b682addc83b5b9
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Bug 5947: additional tests for binding-dom-codec #9

Change-Id: Ib9a3bdf105d673be7c2d52be5c9f9cfcd63409fb
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: additional tests for dom-adapter #7

Change-Id: Ic970ea7bccda9d4f82901fa93c92508065de35a9
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Bug 5947: additional tests for dom-adapter #6

Change-Id: If497e570342391c9d8aecf81bcd3cee24438f786
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Bug 6710 - Close ClusterSingletonServiceRegistration fix

Note: Closing process for CSSRegistration has to follow same
way as a lostLeadership and the main diferences between this
two ways is a not null MainEntityCandidate registration.

* fix using closeClusterSingletonGroup method
  - this method has to be use ONLY without active EOS listener
* fix closeResources method
  - MainEntityCandidate has to be close before lock.release
* fix removing actual CSSGroup instance from EOS listener map
  - close proces has to always finish with removing parth and
    we have to check guardEntityCandidate instece only. Because
    we don't get any aditional notif. from Eos without
    GuardEntityCandidate registration.
* add and modify test
* add async Test Case for SingletonServiceGroup

Change-Id: I15f89cbd43310b0a8e4b7ac78595eeaaa82a65ee
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Fixed some problems with GeneratorUtil

Change-Id: If496bb149f755d17610c93c0e828123dc9bbde9d
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Fix groupId to reflect org.opendaylight.mdsal

The merge job is currently broken because of that. It is failing to
deploy binding-aggregator because it doesn't have the correct groupId.
See https://jenkins.opendaylight.org/releng/job/mdsal-merge-carbon/23/console
for more details.

This issue was introduced with the clean up of the pom file that occured
here https://git.opendaylight.org/gerrit/#/c/45912/

Change-Id: Ia3cae6215547702467d42d604641ec46667bc488
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

Remove unused yang file - opendaylight-inmemory-datastore-provider.yang

This is probably something than came in when project were splitted up.

Change-Id: Ib05b1cad54bef6885a83966ec1d2b28dc88ab266
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

Fix checkstyle in mdsal-binding-dom-adapter

checkstyleViolationSeverity=error added
Fixed all CS errors. Code review comments are implemented.
Fixed the merge conflicts.

Change-Id: I8c2af744474a5ae6d28fb62b11ed0da65251825a
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Bug 5947: additional tests for dom-adapter #8

Change-Id: I92113a82940b8e61a57638aba2ca71cf822de023
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Cleanup pom.xml layout

This performs the long-overdue cleanup of build structure,
aligning it with ODL best pracitices and removing quite
a bit of crud in the process.

Change-Id: I04ac6a917928c1da286b8c4ec4e1c7cb66e9990b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not instantiate iterator for debugging

Logging the entire collection is more appropriate and also
faster when logging is disabled.

Change-Id: Ib3e44851bcedad1eaabad983c1ac45de6890eec2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Convert to using BatchedInvoker

Single-step invoker has been deprecated and this prevents
useless re-encapsulation.

Change-Id: I3f7dbe2b4ca4af37df9ab017eeddd9ff16803b61
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix javadoc warnings

The description for arguments was present twice, remove
the duplication.

Change-Id: I5cd19ff66184e0ec9a6d507e65db3e3d231362ff
Signed-off-by: Robert Varga <rovarga@cisco.com>

checkStyleViolationSeverity=error implemented for mdsal-binding-api module
Code review comments are implemented.

Change-Id: I925d71befa5806db4e7522c8009f5b125564adfe
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

checkStyleViolationSeverity=error implemented for mdsal-singleton-common-api and mdsal-singleton-dom-impl modules
Done implementing code review comments.

Change-Id: I09443eeb61b09844d1e6960e7ff480dcaaface9f
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Convert to using BatchedListenerInvoker

This will deliver all notifications in one go, leading to faster
flushing.

Change-Id: I7a5023fadbfc67a19348963c15ae332986cd18d8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5947: additional tests for dom-adapter #5

Change-Id: I236f1c92852665a0dab1c6d6f14b50ff31c4c600
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: additional tests for dom-broker and inmemory-datastore #4

Change-Id: I43af7e4dae33e8d7a5fd9c8c4c58afe747f3f7c3
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: additional tests for maven--sal-api-gen-plugin #3

Change-Id: I84d0d77f7e335f36ddf831ce63ae3095eb329513
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Remove mdsal-binding-util from features because it's only a pom file

Change-Id: I2271c644416d75223858a79796343770e7ee073e
Signed-off-by: Colin Dixon <colin@colindixon.com>

Move transaction-invariants into producer

Instead of re-calculating the context, cache most of the information
required in the InMemoryDOMDataTreeShardProducer, so it can be quickly
reused when creating transactions. This information is calculated when
a producer is created or when the sharding layout changes.

Change-Id: Id2bcab420cf6d1635aba6cd97bf68f1860533780
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add cursor lookup fast-path

Users will typically select one of the subtrees to create
cursor on, hence add a fast path which will perform a simple
lookup.

Change-Id: Ied0710a765edf8cdd4ebd7f2712f310f82f35b1a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix a raw type warning

Iterable should be qualified, fix that.

Change-Id: Icff504ab73c1cd180c6f50d239f1fe9630845de1
Signed-off-by: Robert Varga <rovarga@cisco.com>

Perform delegate cursor enter/exit first

Delegate may fail to perform the operation, which would leave
our stack inconsistent, leading to confusion if the user ignores
exceptions. Perform enter/exit on delegate first and only if it
succeeds proceed to update our stack.

Change-Id: If6ebfd9b530e9052a5dc8cab120a5d0c8317f937
Signed-off-by: Robert Varga <rovarga@cisco.com>

Move lookup check

We can use a precondition to make the code flow
more obvious.

Change-Id: Iaddfcfd4d49a91b6875a6f4803fed744ada63a85
Signed-off-by: Robert Varga <rovarga@cisco.com>

Eliminate ShardedDOMDataTreeWriteTransaction.doSubmit()'s return

Returned future is not used anywhere, hence we can easily remove it.

Change-Id: I4ead4da32d1c2658d5c88f01534b5452230068e7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix raw types

Fix eclipse warnings from raw types.

Change-Id: Iae0d43883cbcf8b084f2c7469796b9a7d80ba32f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make sure we optimize DOMDataTreeIdentifier

DOMDataTreeIdentifier inside a shard is heavily reused. Do not trust
the user to give us an optimized YangInstanceIdentifier but try
optimizing it.

Change-Id: I8a73b21562393a5f9100359d5ffaf3e2af057b6e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not use entrySet() where values() or keySet() suffices

Instead of forcing instatiation of entrySet() and using only
part of the provided data, use values() and keySet() based
on what we really need.

Change-Id: I0a9333b872f9c56e1fa4eddb985309741cf77fe8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not use ExecutorService unnecessarily

Executor is the interface we need, not ExecutorService. ExecutorServices
are more complex, and we do not care about shutting them down anyway.

So require only an Executor, letting callers to deal with its lifecycle,
which allows us to use more efficient MoreExecutors.directExecutor()
instead.

Change-Id: Ide57266cc1fac395e545b466bf3b5ad86dee7b2f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use ImmutableMap instead of Collections.emptyMap()

ImmutableMap behaves nicely when it meets copying and can
be checked for.

Change-Id: I2e0b52b8ea83c69e4ace3364904975b806a67aae
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not allow transaction creation with an empty shard map.

Change-Id: I445c43a5af430bb0b4838c2e77d155d5318e0bbb
Signed-off-by: Tomas Cere <tcere@cisco.com>

Switch to using StampedLock

Instead of using ReentrantReadWriteLock, use StampedLock,
which has better performance.

Change-Id: Ifb8c3c90fb05a37264e006acc7d94b4bde5d2893
Signed-off-by: Robert Varga <rovarga@cisco.com>

checkStyleViolationSeverity=error implemented for mdsal-eos-common-api, mdsal-eos-common-spi, mdsal-eos-dom-api
Code review comments are implemented.
Removed @SupressWarnings{"checkstyle:RedundantModifier"} for removing private modifier for enum constructor
Resolved merge conflicts for EntityOwnershipChangeState and EntityOwnershipChangeStateTest files.
Implement some more code review changes.

Change-Id: I215d564d2a9f647961a9b1915d466a7cfb5b0c00
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Remove public keyword

ShardDataModification is not a public class, no sense
in declaring its methods public.

Change-Id: I4d198ad16aa6cf02b28262ecc5b7a169cb99955c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Speed up InmemoryDOMDataTreeShardWriteTransaction's operations

SimpleOperation's apply() method can be updated to invoke hasNext()
only once for each iteration.

Change-Id: Id94f01428dd1c8b55b883371c9830d6d7209727a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Encapsulate ShardedDOMDataTreeProducer layout

This patch encapsulates all state related to sharding
layout into an inner class, so that this information
can be accessed concurrently.

Change-Id: If66a7ac5b574d612b31e7c52156b80580ef9f79a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Improve ShardedDOMDataTreeProducer locking

Making 'closed' a CAS-capable field allows us to check
state and transition to closed state without holding
the object's lock.

This allows associated critical sections to be reduced
to the extent as to make the reuse fast-path completely
lock-free.

Change-Id: I29bacebf5d37a38ea6b4cc641f43dc369cd9edcf
Signed-off-by: Robert Varga <rovarga@cisco.com>

Improve ShardedDOMDataTreeProducer locking

The path from backend was taking coarse lock even when not needed.
Explicitly annotate submitTransaction() as needing the lock being
held and push down its acquisition so we take it only after we
are certain we actually need it.

Change-Id: Icd1226796568829ea3735e6eec42677a79b9b3b5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Improve ShardedDOMDataTreeWriteTransaction performance

Make internal maps/collection immutable, as it really is
and forgo internal copying of their values in iterators.

Change-Id: Icb0e59d52464498fe87440467fec9095cc8d414e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize InMemoryDOMDataTreeShardProducer

All state transitions in this class are based on lock-free
algorithms -- compare-and-swap and retries on conflict.

Eliminate unneeded synchronized keywords, plus inline simple
single-use methods.

Change-Id: I87e22333bb6c3c4db324c5918481fe79d5da2592
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make test methods static

Test data construction can be static.

Change-Id: Ie20b88470d9dd62657f9e41b3eaf6904dc92e62d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix InMemory shard transaction chaining.

In case we had multiple transactions going after each other quickly
the next transaction might not observe the state of the previous transaction yet.
Fix this by reusing the DataTreeModification of the previous transaction.
Also introduce state transitions into InMemoryDOMDataTreeProducer so it
behaves more like a transaction chain.

Change-Id: I96c746c1b91ac9f6b87152dca612094c73c23387
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix warnings in AbstractDOMShardTreeChangePublisher

Raw types and potentially static method.

Change-Id: I271a7fe28df47dce6b8fd335a215d14c3f46b7b8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add batching of non-isolated transaction in ShardedDOMDataTreeProducer

Change-Id: If5ee94a6b2f58c6fd5a243f8784c8b56200b7343
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG-5561: retain SchemaContext order for bits

This patch reworks BitsCodec so it retains the bit order
defined in SchemaContext, which by extension means the values
coming from Binding objects should end up being sorted
by position.

Change-Id: Ice154dd7e38e6b213c281ddb492408f619e3a5f8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use lambdas for functional interfaces

Makes the code more concise.

Change-Id: I6b3ed4ebefbd72b63958a0b4db98129a4e35e317
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix redundancy in documentation of DOMStoreThreePhaseCommitCohort

Change-Id: Iaafbea0d5181856e5fdcd9674893848b5a8b69a5
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

Bug 5947: additional tests for binding-dom-adapter #3

Change-Id: I34c38d7088fbe05048e8403c971d83d3a75c8d68
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Fix deprecated Assert imports

junit.framework.Assert has been deprecated in favor of org.junit.Assert.

Change-Id: I7507a55d596ad8c03c4c9777c05a78ab3ceda710
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5947: additional tests for binding-dom-adapter #2

Change-Id: I3ce80097609761ec7d43a96d0a22d9f43d3a897d
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 6540 - HotFix for IsolatedLeader message handler

Change-Id: Icc495dbbbc5583ed68f162ace0e7f2ab12c498c3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Use a bounded blocking queue in InmemoryDOMDataTreeShards.

Change-Id: I72b02d9f77985ec80db87792424403b6960616a2
Signed-off-by: Tomas Cere <tcere@cisco.com>

checkStyleViolationSeverity=error implemented for mdsal-dom-inmemory-datastore
Changed the local variable indVal to index.
An unwanted folder was added accidentally, removed.
Code review comments are implemented.

Change-Id: Ie1736dbec9e00a49961a46c32f4433f60c211dc0
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Bug 5947: additional tests for binding-dom-adapter

- FutureSchema
- BindingDOMTransactionChainAdapter
- BindingDOMRpcImplementationAdapter
- BindingDOMRpcAdapterRegistration

Change-Id: I511d39671d6b32ae49a2c8dc58da1427e96c3207
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: yet another tests for binding-dom-adapter

Change-Id: I57abe83c9fc49beee81764977b3ae3528ee2dccc
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 1411-4: MDSAL Binding2 Generator Impl

- BindingGeneratorImpl decomposition proposal
- introduction for Twirl templates for Yang Snippets generation
- rather more templates, less logic, more content
- JUnit test - to be finished
- added several twirl templates for YANG
- review comments fixed
- apply https://git.opendaylight.org/gerrit/#/c/44939/ for spec v2

Change-Id: I79cb7e9c0d41c23408949dd5d4d40d572cc86652
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Implementing checkStyleViolationSeverity=error for mdsal-eos-binding-api module

Change-Id: Ic5526189f5a646a369d43676b287034c0f781ce5
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Implementing checkStyleViolationSeverity=error for mdsal-eos-binding-adaptor module

Change-Id: Ibb2d726a1d2e40be605ebef21deda5a03757d0b6
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Bug 5947: additional set of tests for binding-dom-adapter

- LazyDataTreeModification
- BindingDOMCursorAwareWriteTransactionAdapter

Change-Id: Ib5c592d15a3e80559f5c81c5e56b0e75a5e783b5
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

checkStyleViolationSeverity=error implemented for mdsal-dom-broker
Resolved the merge conflicts.
Implemented code review comments.
Implemented another set of code review comments.

Change-Id: I3eecb17342e4fd7f4736ca67bc57f01f91115c0f
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Bug 1411-3: MDSAL Binding2 Generator Util

- general util classes & methods
- generated type & builder classes
- Types & BindingTypes
- Annotations, Enumeration
- Method signature support
- Deviation/AnnotationType issue fixed
- Objects.hash() used in hashCode() methods
- review comments fixed

FIXME/TODO:
Binding2GeneratorUtil - implement rest of static methods, colon-dash issue
Binding2Mapping - implement rest of static methods, underscore issue

Change-Id: I9f602a893f6cbd2e9e30c6ca6dc3810e0c678d89
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Execute the ShardedDOMDataTreeTransaction.submit() async.

Change-Id: I7e8a59f03a6ed2f3e37d0aa31a2fc12b983644a8
Signed-off-by: Tomas Cere <tcere@cisco.com>

checkStyleViolationSeverity=error implemented for mdsal-dom-spi module

Resolved the merge conflicts. Implemented code review comments.
Removed empty lines within import sections of some files
Implemented some more code review comments.
Somebody had changed checkStyleViolationSeverity to warning, so it was ignoring the trailing white spaces.
Fixed the pom for dom-api and spi module + fix the code.

Change-Id: I1ea8b60c8b5910ea9f30963ada55ecbed3363a95
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make ShardCoordinationTasks public

These will be reused in controller so make them public.

Change-Id: I89fb776768d8e975fd744fd1daefc2d0bb3eaa3f
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 6413: Fix ipv4 and ipv6 patterns used by IpAddressNoZoneBuilder

due to vague regex definition there was no way to distinguish
if shorter ip address was ipv6 or ipv4 resulting in exception
added tests

Change-Id: Id81e26f018e718675fd58469204c7ad1b647a7b1
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Fixed Checkstyle violation errors in mdsal-dom-api module

Implemented code review comment. 2nd round code review comments are implemented.

Change-Id: Iaa93e0786c54d80aa8cba8289570dc281442a055
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-6028: check value types for encapsulation

This is a fast check to see if the argument matches expected
value class. If it does not it does not make sense to invoke
the serializer, as it will fail.

Change-Id: I4ca556fea057f2188fa1c34d303467565af38d5c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 1411: MDSAL Binding2 Generator API fix

Since we narrowed down schemaPath in DocumentedNode
to List, this needs to be reflected also in
GeneratedTypeBuilderBase class.

Change-Id: Id9edb2fef730bab24415878c85ccc74c4b8a1e9d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 6252

Add target/generated-sources/spi & yang/ as resource folders
Follow-up patch for Binding v2

Change-Id: I52822ca5ed5d468f8d62238133a212c9773ddffb
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 1411: MDSAL Binding2 Generator API Enumeration fix

- support for missing optional sub-statements of Enum statement added
- minor related Javadoc fixes

Change-Id: I45130065c183c4e0b6094fdb0a9d18fc9709caa7
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Fix NPE when creating a producer after shard was unregistered

Change-Id: I9f6728f4c885cc18d8adf8dc9d1c14e8c99977ef
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG-1411: MDSAL Binding2 Spec - comments/feedback fixed

- based on review by Martin Sunal

Change-Id: I7da6e1c35ffed18fe62c7d4092b1eb8557913762
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

BUG-1411 MDSAL Binding2 Generator API Enumeration fix

- missing getMappedName() method in Enumeration API

Change-Id: Ibcd79173745b14464614b494880d20b434070584
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Fix AbstractDOMShardTreeChangePublisher's initial data change event

Strip shard path from listener path, when reading initial data from non
root shard. Also add requirement on DOMStoreTreeChangePublisher
interface to send initial data change event to even when data does not
exist yet.

Change-Id: I90f3aa33764a4812703c37e91378a73270fe19a3
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

BUG-1411: MDSAL Binding2 Generator API small fix

- Enumeration import fix
- reflecting Yangtools API change - EnumPair.getValue() returns int now

Change-Id: I7148801e5b184e64294344f158483ca96cc58f56
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

.gitignore .factorypath created by m2e-apt

https://github.com/vorburger/opendaylight-eclipse-setup now bundles
https://github.com/jbosstools/m2e-apt, which creates .factorypath files
all over the place.

Change-Id: I0be119c2137f3bc1d7db3214230b7ce6651ae02a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

add target/generated-sources/spi & yang/ as resource folders

and remove src/main/yang as source folder

but obviously must keep Maven's default src/main/resources
(see https://lists.opendaylight.org/pipermail/release/2016-August/007788.html)

Bug: 6252
Change-Id: I66b5dcdebc88303fd2e3e25f16f5f362b135a13e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-6316: Fix Bit and EnumPair's position/value types

Follow-up patch for Yangtools API change:
https://git.opendaylight.org/gerrit/#/c/42855/

This solves issue with distibution-check jenkins job, where
EnumPair.getValue() returns Integer instead of correct int type.

Change-Id: I459364d17747e0adf10ec021a0bd9cc3e316726d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Use methodhandle instead of a lambda

Less text, same effect.

Change-Id: Ifa6d57f94d925268f116d95e2aac85290f133ed8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "Add target/generated-sources/spi & yang/ as resource folders"

This reverts commit af8757dcd1d4ea0c794877021406e15a12000cea.

Change-Id: Id61db4aa7a915e6054060c63b6f681d9a3c45511
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add target/generated-sources/spi & yang/ as resource folders

and remove src/main/yang as source folder

Bug: 6252
Change-Id: I5574716949d29b886855a233de1e0c005e4985eb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>