gowri [Wed, 30 Nov 2016 08:34:49 +0000 (14:04 +0530)]
Fcaps: changing alarm text parameter to be same while raising and clearing
Change-Id: I941aef182be4d3a1488399d8ea1eaa7432c707ff
Signed-off-by: gowri <gowri.r@ericsson.com>
Faseela K [Mon, 28 Nov 2016 05:39:56 +0000 (05:39 +0000)]
Merge "@deprecate DataStoreCache - it's more of a joke than a real cache IMHO"
Faseela K [Sat, 26 Nov 2016 12:16:48 +0000 (12:16 +0000)]
Merge "idmanager remove usage of @deprecated CacheUtil"
Michael Vorburger [Thu, 24 Nov 2016 20:08:38 +0000 (21:08 +0100)]
idmanager remove usage of @deprecated CacheUtil
Specifically, this also solves a problem in the
InterfaceManagerConfigurationTest (InterfaceManagerTest) related to
stale content surviving between tests in this cache, due to static (that
problem could have been "resolved" via CacheUtil.destroyCache() as well,
but this is much cleaner).
Because the IdManagerCacheCli cannot use the CacheUtil with static
methods anymore now, we introduce a simple IdManagerMonitor interface,
have IdManager implement that to expose the ConcurrentMap<String,
IdLocalPool> localPool, just as Map<String,String> so as to not leak the
IdLocalPool out of the implementation.
With a little bit of blueprint XML wiring magic, the IdManagerCacheCli
can lookup that IdManagerMonitor from the OSGi service registry, and do
the same as it did before.
FTR: I've manually non-regression tested this, and verified that
genius/karaf with this change still comes up without errors, and that
the "idmanager:show" command does not blow up when used.
Change-Id: I47b92ece98fae0bce4390472c18f6833b43e7843
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 24 Nov 2016 19:13:36 +0000 (20:13 +0100)]
@deprecate CacheUtil
For an example of how to simply replace this fairly useless utility
class with a ConcurrentHashMap in a project, please see the upcoming
next Gerrit doing that in idmanager.
Change-Id: I2c512aafba34a8eef83d3935c12f7048b96af471
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 24 Nov 2016 16:47:03 +0000 (17:47 +0100)]
De-static-ify idmanager IdUtils
As I've said before: "static is evil" ... ;-)
This isn't theory - but practice; in something like the new
InterfaceManagerTest (InterfaceManagerConfigurationTest), this static
leads to non-isolated tests - because it "leaks" state.
Change-Id: I2064ca59eba4fda5ec24e9c4c2e0dfae79a56d58
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Fri, 25 Nov 2016 10:36:13 +0000 (10:36 +0000)]
Merge "Bug 7230: tun_id from vxlan tunnel is incorrectly stored into gre key"
Maria Merida [Thu, 24 Nov 2016 13:19:37 +0000 (14:19 +0100)]
Bug 7230: tun_id from vxlan tunnel is incorrectly stored into gre key
"tun_id" should be "cleaned" (or set to 0) when the output is a L2GRE interface.
This way we prevent a wrong "tun_id" value from being copied into the gre key field of the packet.
Right now, "tun_id" value from vxlan tunnels between OVS is not cleaned before output the packet to the GRE interface. As a result, a wrong key is set in the output packet.
More information: https://bugs.opendaylight.org/show_bug.cgi?id=7230
This fix needs to go to stable/boron SR2
Change-Id: I946b135320b4a54ba1e77f91a506d72b475d4927
Signed-off-by: Maria Merida <maria.merida@ericsson.com>
Faseela K [Fri, 25 Nov 2016 05:19:58 +0000 (05:19 +0000)]
Merge "minor: idmanager UpdateIdEntryJob else block, for clarity when reading"
Michael Vorburger [Thu, 24 Nov 2016 16:04:24 +0000 (17:04 +0100)]
Fix buggy bad exception root cause logging in idmanager
Change-Id: I99fdc35e5e621f1f3149e9b5aff0ebc152700785
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 24 Nov 2016 18:01:26 +0000 (19:01 +0100)]
minor: idmanager UpdateIdEntryJob else block, for clarity when reading
Change-Id: I1d093bfd157134a9b9b68dc1922d2a62b0ac57cf
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 24 Nov 2016 18:46:01 +0000 (19:46 +0100)]
@deprecate DataStoreCache - it's more of a joke than a real cache IMHO
I see no evidence in the DataStoreCache code that it is "feeded by a
clustered data change listener" (quote from the original JavaDoc).
Change-Id: I8f51bde2e72a48f80e0dfcb9f60306ae2cc85305
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 24 Nov 2016 17:17:36 +0000 (18:17 +0100)]
idmanager Checkstyle enforcement preparation: Organize Imports & Tabs
incl. some other trivial automatic code formattings stuff, all low risk
incl. line length wrapping
Does not yet enforce Checkstyle, because there are a few things left to
tidy up, including reviewing Exception handling; that will come in
another future Gerrit, once this is merged.
Change-Id: Ic7d9f008ff9958b57a36cb8f0b8e1fddd3990c6e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 24 Nov 2016 15:56:05 +0000 (16:56 +0100)]
minor: Some very minor first clean up in IdManager
Change-Id: I693b60d89fd26ae36f5268fb137e2b945009801b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 24 Nov 2016 12:47:41 +0000 (12:47 +0000)]
Merge "Add utility apis"
Sridhar Gaddam [Mon, 7 Nov 2016 07:39:42 +0000 (13:09 +0530)]
Add utility apis
This patch implements the following utility apis.
1. API to check if the supplied ipAddress is IPv4 Address or IPv6
2. API that returns the corresponding ipPrefix based on the ipAddress
Change-Id: I975e23763d45ceef3598ac35970767555196efe7
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Faseela K [Thu, 24 Nov 2016 10:46:13 +0000 (10:46 +0000)]
Merge "OFTunnels: Convert ITM config to IFM"
Michael Vorburger [Thu, 24 Nov 2016 10:43:13 +0000 (10:43 +0000)]
Merge ".gitignore .fbExcludeFilterFile"
Stephen Kitt [Mon, 14 Nov 2016 17:37:31 +0000 (18:37 +0100)]
Tighten DefaultBatchHandler properties
* dataBroker, batchSize and batchInterval shouldn't be static.
* None of the properties should be public.
Change-Id: Ibd0ee0e35566824ea4aedfaa5766d5de8a830f95
Signed-off-by: Stephen Kitt <skitt@redhat.com>
David Suarez [Wed, 23 Nov 2016 23:46:26 +0000 (23:46 +0000)]
Merge "SingleTransactionDataBroker"
Michael Vorburger [Wed, 23 Nov 2016 13:01:00 +0000 (14:01 +0100)]
.gitignore .fbExcludeFilterFile
Change-Id: I92d9aef533fd001e243efa98aad8c34696efb80a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vishal Thapar [Wed, 23 Nov 2016 10:17:53 +0000 (15:47 +0530)]
OFTunnels: Convert ITM config to IFM
This change uses OFTunnels configuration in ITM to create tunnel
interfaces with remote-ip-flow option set.
Change-Id: I74f6b494d23137516608005a9b3cb96184031eb8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Wed, 23 Nov 2016 08:18:42 +0000 (13:48 +0530)]
OFTunnels: Update spec and itm-state.yang
One more addition made to itm-state.yang to optimize passing of of-tunnel
option from TransportZone configuration to Interface configuration. This
change eliminates need to do a DS read.
Spec also updated to reflect this addition.
Change-Id: I9396836294bf9d01573acbeddb6a35134610e63a
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Michael Vorburger [Thu, 17 Nov 2016 18:30:28 +0000 (19:30 +0100)]
SingleTransactionDataBroker
Change-Id: I9a88fe7672235057329968481b8f3438685b0859
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Mon, 21 Nov 2016 07:48:00 +0000 (07:48 +0000)]
Merge "Cleanup: keySet() never returns null"
David Suarez [Mon, 21 Nov 2016 07:47:21 +0000 (07:47 +0000)]
Merge "Cleanup Optional uses"
David Suarez [Mon, 21 Nov 2016 07:47:13 +0000 (07:47 +0000)]
Merge "Cleanup: use lambdas and method references"
Faseela K [Mon, 21 Nov 2016 07:30:21 +0000 (07:30 +0000)]
Merge "Addition of constants for ARP Responder"
Faseela K [Mon, 21 Nov 2016 06:51:16 +0000 (06:51 +0000)]
Merge "bug 7205 l2gw itm mesh is not getting built"
Faseela K [Fri, 18 Nov 2016 16:40:36 +0000 (22:10 +0530)]
Ignoring new interfacemanager tests added as component style tests.
Description : Unit test failures introduced after this.
Will be revisited
Change-Id: I2da3c03163f9e858aa236710d9982e5657f5da8c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
K.V Suneelu Verma [Fri, 18 Nov 2016 12:37:33 +0000 (18:07 +0530)]
bug 7205 l2gw itm mesh is not getting built
If there is default transport zone which is created as part of controller
start rpc call to mesh l2gw device to itm is failing.
Change-Id: I87b941976b42544e53a567cc8fb9264e9c6ba075
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
David Suarez [Fri, 18 Nov 2016 12:12:05 +0000 (12:12 +0000)]
Merge "Cleanup: remove unnecessary boxing/unboxing"
Faseela K [Fri, 18 Nov 2016 11:36:04 +0000 (11:36 +0000)]
Merge "Bug Fix: 7203 Wrong handling of binding service to a tunnel"
Vivek Srivastava [Fri, 18 Nov 2016 10:16:55 +0000 (10:16 +0000)]
Merge "Yang changes for OF Tunnels"
Vivek Srivastava [Fri, 18 Nov 2016 07:35:06 +0000 (07:35 +0000)]
Merge "Add matches and actions for OF Tunnels"
Jose Antonio Baena [Fri, 18 Nov 2016 06:42:42 +0000 (07:42 +0100)]
Bug Fix: 7203 Wrong handling of binding service to a tunnel
The current behaviour implemented for service binding to a tunnel interface is:
- In table 0, the first service bound
- In table 17, the rest of the services bound
When some service is already bound and a new service is going to be
bound and its priority is the highest, then this new service should be
bound in table 0, and the previous service that was bound in table 0
needs to be move to table 17. When the service is moved to table 17, the
priority is not being installed accordingly.
The error is that the entry created in the table 17 related to the service
that is being moved from table 0, has the priority of the new service
bound instead of the service moved from table 0.
This fix needs to go to stable/boron SR2’
Change-Id: Ic72164163371ebf47e61635f16a9d7d31a1875d2
Signed-off-by: Jose Antonio Baena <jose.antonio.baena@ericsson.com>
karthik.prasad [Wed, 16 Nov 2016 11:06:38 +0000 (16:36 +0530)]
Addition of constants for ARP Responder
Moving ARP Responder constants from Netvirt to MDSALUtil, genius.
Change-Id: I419c2bf7aeacc63e6ad641a736f9687bba526318
Signed-off-by: karthik.prasad <karthik.p@altencalsoftlabs.com>
Vivek Srivastava [Fri, 18 Nov 2016 06:25:34 +0000 (06:25 +0000)]
Merge "Spec for OF Tunnels"
Stephen Kitt [Thu, 17 Nov 2016 09:50:30 +0000 (10:50 +0100)]
Cleanup: keySet() never returns null
Map::keySet() never returns null, so this patch removes the
corresponding null checks. It also replaces key iteration by entry
iteration since that's more efficient (given that we need the values
in the loop).
Change-Id: I58bbce91cbe594fcfbb637e574c62e9f88408087
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 17 Nov 2016 09:30:00 +0000 (10:30 +0100)]
Cleanup Optional uses
* Use functional transforms where possible.
* Remove uses of Optional which are only null-checks (Optional.of()
immediately followed by .isPresent()).
* Use try-with-resources for transactions where appropriate (and
spotted during Optional cleanup).
Change-Id: I1198d10cceb806a6f3d4718bdd169cf746faf2f1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Thu, 17 Nov 2016 10:12:44 +0000 (10:12 +0000)]
Merge "Blueprint for idmanger, idPoolListener updated"
Stephen Kitt [Wed, 16 Nov 2016 10:37:05 +0000 (11:37 +0100)]
Cleanup: use lambdas and method references
Change-Id: I78cdb1b8135ff69ffacd1a869e4a106b4bb5735f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Wed, 2 Nov 2016 14:59:28 +0000 (15:59 +0100)]
InterfaceManagerTest as a new-style component/API/end2end test
Change-Id: I058b4cdeab4be2b01b4172a5376ad1fe4597ea27
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Wed, 16 Nov 2016 10:29:06 +0000 (11:29 +0100)]
Cleanup: remove unnecessary boxing/unboxing
Change-Id: I37ae49738b799daf7278e3027b142c0e48a65943
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Edwin Anthony [Tue, 15 Nov 2016 10:43:51 +0000 (16:13 +0530)]
Blueprint for idmanger, idPoolListener updated
Change-Id: Id279505538a50ea3afc177c92c2ea8037cbe2702
Signed-off-by: Edwin Anthony <n.edwin.anthony@ericsson.com>
Stephen Kitt [Mon, 14 Nov 2016 17:22:53 +0000 (18:22 +0100)]
Cleanup: simplify boolean expressions
* Avoid comparing with true or false.
* Instead of "if (boolean) { return true; } else { return false; }",
just "return boolean;".
* Simplify some conditional expressions.
Change-Id: I5bfa96750b6163a06e2f4ce0ee02879d98800330
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Thu, 1 Sep 2016 15:49:57 +0000 (21:19 +0530)]
Add matches and actions for OF Tunnels
OVS supports OF tunnels where tunnel source and dest IPs can also be set
with OF flows. This patch is first step to add support for OF Tunnels.
This adds following matches and actions:
Matches: nx_tun_src_ip, nx_tun_dst_ip
Actions: set_tunnel_src_ip, set_tunnel_dest_ip
Change-Id: I4e29f45a72f4326704b9d074153b082f9c3ce141
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Wed, 9 Nov 2016 09:54:57 +0000 (15:24 +0530)]
Spec for OF Tunnels
1. Added specification document for OF Tunnels
2. Linked spec to specs/index
Change-Id: I00b753eb396501bb244022890d8b0cccbbd6805b
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Fri, 11 Nov 2016 08:19:01 +0000 (13:49 +0530)]
Yang changes for OF Tunnels
This patch covers yang changes for OF Tunnels as captured in of-tunnels
spec document.
References
----------
https://git.opendaylight.org/gerrit/#/c/48156/
Change-Id: I619bd7daa77f384d172bd6e54cbcc2754200a99f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Dimple Jain [Sun, 23 Oct 2016 09:20:49 +0000 (14:50 +0530)]
Upstreaming BFD monitoring fixes
While performing monitoring toggle operation and interval updation,
ITM was not computing all possible tunnels where multiple subnets were
present.
ITM was considering only tunnels within the same subnet.
The fix is to compute all tunnels ie., tunnels between the subnets too.
Change-Id: Id80267f7da4faf3c09e8e405afca20a7dcc79b7b
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Stephen Kitt [Wed, 9 Nov 2016 16:25:18 +0000 (17:25 +0100)]
Cleanup: use plain String concatenation
This is the most efficient method of String construction nowadays for
straightfoward concatenation.
Change-Id: I1279ccb58c6cbdcb88ca3a66e768a7649a755651
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 9 Nov 2016 16:22:47 +0000 (17:22 +0100)]
Cleanup: various performance issues
* Use Collections.singletonList() instead of single-parameter
Arrays.asList()
* Remove redundant String::toString() and String::format() calls
Change-Id: I41f69b3f2adf085b1670a7e25f41642b2e6114f2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 9 Nov 2016 16:15:28 +0000 (17:15 +0100)]
Cleanup: remove unnecessary type casts
Change-Id: Ic55b47b3f945f5f97974e169ed35b8ece6fbded5
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 9 Nov 2016 16:13:36 +0000 (17:13 +0100)]
Cleanup: remove redundant type declarations
Java 7 and 8 have improved type inference a lot, many type parameters
are no longer necessary.
Change-Id: I89c2d8ecb05d67eabb0b8004b7e69b5e94b85337
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 9 Nov 2016 16:07:57 +0000 (17:07 +0100)]
Cleanup: remove redundant modifiers
* Replace <? extends Object> with <?>
* Remove public from interface members (they're public by default).
* Remove static and final from interface attributes (they're static
final by default).
* Remove unnecessary semi-colons.
* Remove private from enum constructors (they're private by default).
* Remove static from enum declarations (they're static by default).
Change-Id: I863d0cc1bba35562bf461b2f7a75abbe01a1ca33
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Thu, 10 Nov 2016 17:08:38 +0000 (17:08 +0000)]
Merge "move interface utilities from ElanUtils and undeprecate Genius IIM"
Faseela K [Thu, 10 Nov 2016 17:03:33 +0000 (17:03 +0000)]
Merge "Add egress split horizon drop flows for external interfaces"
Faseela K [Thu, 10 Nov 2016 17:02:59 +0000 (17:02 +0000)]
Merge "Refactor and checkstyle changes."
Michael Vorburger [Mon, 7 Nov 2016 15:56:34 +0000 (16:56 +0100)]
TestDataStoreJobCoordinator with waitForAllJobs() methods req. in tests
Change-Id: Id0b4087b3417bbe8098eac0322164fd5752292ab
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 10 Nov 2016 12:32:04 +0000 (12:32 +0000)]
Merge "Checkstyle compliance for DataStoreJobCoordinator, incl. clean JavaDoc"
Faseela K [Thu, 10 Nov 2016 12:31:37 +0000 (12:31 +0000)]
Merge "ClusteringUtils Collections.singletonList instead Lists.newArrayList()"
David Suarez [Wed, 9 Nov 2016 23:30:18 +0000 (00:30 +0100)]
Refactor and checkstyle changes.
Change-Id: Icdbb507c06e677ff0968105f26f717261af0fa65
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Vishal Thapar [Wed, 9 Nov 2016 15:04:13 +0000 (20:34 +0530)]
Add pipeline doc for Genius and dependent projects
1. Adds pipeline.rst to capture current OF Pipeline as used by genius and
projects using Genius for app-coexistence.
2. Links pipeline.rst to genius/index
Change-Id: Id0523ed3d4b8b27f86c1744d2123b1665818a59f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Faseela K [Wed, 9 Nov 2016 18:03:08 +0000 (18:03 +0000)]
Merge "Link specs to genius/index"
Alon Kochba [Wed, 9 Nov 2016 10:35:56 +0000 (12:35 +0200)]
move interface utilities from ElanUtils and undeprecate Genius IIM
Moving utilities currently in ElanUtils into genius.
Removing deprecate flag from InterfaceManager, since performance
issues were discovered with the RPC-only approach.
Change-Id: I9433820c876875b1a3f3cf5eed5de3bc26f14986
Signed-off-by: Alon Kochba <alonko@hpe.com>
Faseela K [Wed, 9 Nov 2016 17:26:16 +0000 (17:26 +0000)]
Merge "Migrate arputilimpl moudule to Blueprint."
Faseela K [Wed, 9 Nov 2016 17:25:56 +0000 (17:25 +0000)]
Merge "Blueprint migration for idmanager"
Vishal Thapar [Wed, 9 Nov 2016 15:57:17 +0000 (21:27 +0530)]
Link specs to genius/index
Change-Id: I6adae1833f6b37a15b88a69a0e0a19ca41ecb24c
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Faseela K [Wed, 9 Nov 2016 07:25:48 +0000 (07:25 +0000)]
Merge "Add template for design spec documents"
N Edwin Anthony [Mon, 7 Nov 2016 09:33:51 +0000 (15:03 +0530)]
Blueprint migration for idmanager
Change-Id: I38243b5944467a434ef4155b31d9817180409c7b
Signed-off-by: N Edwin Anthony <n.edwin.anthony@ericsson.com>
Vishal Thapar [Tue, 8 Nov 2016 19:14:08 +0000 (00:44 +0530)]
Add template for design spec documents
Refer: https://git.opendaylight.org/gerrit/#/c/47966/
Change-Id: If507ea67d5f896406fd2d631c932248e0ff0793b
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Tue, 8 Nov 2016 18:34:46 +0000 (00:04 +0530)]
Add .tox to .gitignore
Running tox in docs folder generates .tox as output directory.
Change-Id: I212732620540b2f862f9249324a61d1bf84bc490
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
David Suarez [Sun, 6 Nov 2016 15:53:03 +0000 (16:53 +0100)]
Migrate arputilimpl moudule to Blueprint.
Change-Id: I3b839233e00ebf6d8ce717ee03719fcef60a4a1a
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Faseela K [Tue, 8 Nov 2016 12:57:23 +0000 (12:57 +0000)]
Merge "BUG 6726 : Loss of traffic during ODL Cluster reboot"
karthik.prasad [Thu, 3 Nov 2016 13:19:29 +0000 (18:49 +0530)]
BUG 6726 : Loss of traffic during ODL Cluster reboot
Since all ARP Traffics are punted to controller, when controller reboots
the packets are lost. The changes fixes traffic loss during cluster
reboot by adding ARP flows on DPN.
The changes includes addition of all NICIRA ARP Extension Actions to
ActionType.java
PS1: Removed Tabs
PS2: Incorporation of review comments
PS3: Incorporation of review comments
PS5: Removed Deprecated method and also removed whitespace.
PS6: Removal of whitespace
PS7: Incorporation of review comments
Change-Id: Ida59553187ba20b10bbc4e08d20e491d5dd72200
Signed-off-by: karthik.prasad <karthik.p@altencalsoftlabs.com>
Michael Vorburger [Tue, 8 Nov 2016 11:09:42 +0000 (12:09 +0100)]
Add missing odl-infrautils-inject to features.xml
This is required as Genius is starting to use adopt
https://wiki.opendaylight.org/view/BestPractices/DI_Guidelines with
AbstractLifecycle e.g. in https://git.opendaylight.org/gerrit/#/c/47426/
and https://git.opendaylight.org/gerrit/#/c/48036/
Change-Id: I67f18b2c867c6db614cd576ca93fea783510d3ba
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vishal Thapar [Mon, 7 Nov 2016 16:23:04 +0000 (21:53 +0530)]
Add Docs for Genius
This patch just initializes sphinx for Genius
Refer: https://git.opendaylight.org/gerrit/#/c/39142/
Change-Id: Id851cd18a9f4d6c28f0995e7d7956b2c9e75f0d3
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Faseela K [Mon, 7 Nov 2016 15:33:58 +0000 (15:33 +0000)]
Merge "Prepare for enabling checkstyle fail on error"
Michael Vorburger [Mon, 7 Nov 2016 14:13:35 +0000 (15:13 +0100)]
Checkstyle compliance for DataStoreJobCoordinator, incl. clean JavaDoc
Change-Id: Ie60453350cfee5fa5f5abbfd2d7aa1820cc9f99f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 7 Nov 2016 13:14:41 +0000 (14:14 +0100)]
ClusteringUtils Collections.singletonList instead Lists.newArrayList()
This is clearer, shorter and AFAIK will save a little bit of memory,
because AFAIK an ArrayList will allocate at least DEFAULT_CAPACITY (10)
if not otherwise specified.
Also includes some otherwise unrelated minor ClusteringUtils CS cleanu.
Change-Id: I0ff8ab50702cc90696e45e5f3fcf2a8850690460
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 4 Nov 2016 19:00:20 +0000 (20:00 +0100)]
alarmmanager Checkstyle clean-up (incl. exception handling fixes)
Change-Id: I10a09756e4d89f4f9e573cfda82dee4456f32991
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Fri, 4 Nov 2016 18:03:58 +0000 (14:03 -0400)]
Prepare for enabling checkstyle fail on error
This patch adds the checkstyle plugin config to
fail on checkstyle errors. Uncomment the checkstyle.violationSeverity
line when ready to enable.
If just adding one bundle at a time rather than all the bundles using
the commons/parents, then copy the same plugin section to the bundle
poms and uncomment the severity. As all bundles are completed then
remove the bundle sections and just use the one in the commons/pom.xml.
Change-Id: I68919f619d84676c5c22a949283f9788dbd4da8e
Signed-off-by: Sam Hague <shague@redhat.com>
Alon Kochba [Tue, 1 Nov 2016 11:36:07 +0000 (13:36 +0200)]
Add egress split horizon drop flows for external interfaces
Add drop flows to egress dispatcher to drop packets originating from
an external interface, marked by SH metadata bit, if the packet is
being sent to an external interface.
Change-Id: I028bd5a795b35613bb27b61577a5056e9a109188
Signed-off-by: Alon Kochba <alonko@hpe.com>
Faseela K [Thu, 3 Nov 2016 09:04:38 +0000 (09:04 +0000)]
Merge "Add info to log message with ARP response details on transmit"
Alon Kochba [Tue, 1 Nov 2016 18:31:06 +0000 (20:31 +0200)]
Add info to log message with ARP response details on transmit
Change-Id: I1b09b27d7dea657da9085f8076ce4c2009f68e30
Signed-off-by: Alon Kochba <alonko@hpe.com>
Michael Vorburger [Wed, 2 Nov 2016 10:18:28 +0000 (11:18 +0100)]
Intro. @Inject @Singleton etc. in some helper services, for testability
This should not have any impact to real runtime code, and is hopefully
low risk. In particular, this alone does *NOT* yet actually exploit
these annotations for auto. generating blueprint XML (because I'm not
activating the blueprint-maven-plugin here, yet).
But adding these is useful already, because it allows these helper
services to be easily used in dependency injection via Guice in
Component Tests.
These annotation can however, later also be used by the
blueprint-maven-plugin - once the respective projects fully switch.
This change also includes a bunch of otherwise completely unrelated
automated formatting and code clean-up which happened automatically as I
was touching these files.
Change-Id: If1c3fe6d03f089bbeee0453742fe5cea8f4f098d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Wed, 2 Nov 2016 07:21:51 +0000 (07:21 +0000)]
Merge "BUG 6626 Packet IN handler thread in deadlock after high ARP rate"
Faseela K [Wed, 2 Nov 2016 07:13:43 +0000 (07:13 +0000)]
Merge "Bug 6836 - No access to external network"
Tali [Tue, 1 Nov 2016 15:18:04 +0000 (17:18 +0200)]
Bug 6836 - No access to external network
1) Additional race fix
2) Move future creation to be per worker
Change-Id: I02fe765021489c71a9c3549d2d41767c65578a50
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Sam Hague [Tue, 1 Nov 2016 20:52:29 +0000 (20:52 +0000)]
Merge "target-ide/ on .gitignore"
Faseela K [Tue, 1 Nov 2016 09:17:08 +0000 (09:17 +0000)]
Merge "Migrate Resource Manager service to BluePrint"
Michael Vorburger [Mon, 31 Oct 2016 17:37:52 +0000 (18:37 +0100)]
target-ide/ on .gitignore
Change-Id: I5006d521cc46191a3a88ec162e970ced453d424a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tali [Thu, 27 Oct 2016 11:05:18 +0000 (13:05 +0200)]
Bug 6836 - No access to external network
Upon first neutron network VLAN provider creation with a defined physnet
both VLAN trunk VLAN member are created for each compute node in the ietf-interface config DS.
As a result ietf-interface state for the VLAN member is attampted to be created simultaneously by
1) InterfaceConfigListener - triggered as a result of VLAN trunk creation in the config DS
2) VlanMemberConfigListener - triggered as a result of VLAN member creation in the config DS
Due to race condition in ietf-interface state for the VLAN memeber creation,
OptimisticLockFailedException can be sporadically get thrown and ietf-interface state
will not be added to the oper DS.
Suggested solution:
When renderers triggered by InterfaceConfigListener on the VLAN trunk call OvsInterfaceConfig*Helpers
to update VLAN member state, these jobs will be queued based on the trunk name to the DjC to prevent
concurrent write of VLAN member ietf-interface state with VlanMemberConfigListener
Change-Id: I0a89e73c6ff0acb9bdc369ab73e16df43e2f727b
Signed-off-by: Tali <tali.ben-meir@hpe.com>
David Suarez [Mon, 24 Oct 2016 08:26:37 +0000 (10:26 +0200)]
Migrate Resource Manager service to BluePrint
Migration of the resourcemanager-impl module to use BluePrint
framework.
Change-Id: I6b6ff7fa70fa4e1ba2831bcee74428658a4bd0d4
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Vivek Srivastava [Fri, 28 Oct 2016 09:09:34 +0000 (09:09 +0000)]
Merge "Bug 7048 - Update to OF port does not change 220 flow"
Faseela K [Fri, 28 Oct 2016 09:00:39 +0000 (09:00 +0000)]
Merge "Added postman collections for id-manager"
Faseela K [Thu, 27 Oct 2016 13:41:09 +0000 (19:11 +0530)]
Bug 7048 - Update to OF port does not change 220 flow
Description : Wrong instance identifier was being used for unbind service.
Also, DJC synchronization key for unbind service should be parent interface, rather
than interface-name, else this will cause race conditions while deleting 220 flow.
Change-Id: I632791ed131cab96e1967542c1fa7e18fa92c519
Signed-off-by: Faseela K <faseela.k@ericsson.com>
N Edwin Anthony [Fri, 28 Oct 2016 06:01:35 +0000 (11:31 +0530)]
Added postman collections for id-manager
Change-Id: I0ac1ca0c739aa436ffc2886308e6be220c327666
Signed-off-by: N Edwin Anthony <n.edwin.anthony@ericsson.com>
shlomi [Wed, 26 Oct 2016 15:50:26 +0000 (17:50 +0200)]
BUG 6626 Packet IN handler thread in deadlock after high ARP rate
use offerNotification instead of putNotification. this will reject messages over the queue limit
Change-Id: Ia43ce75a8a6e7e3b1ed9e90704e03656e7cfdc11
Signed-off-by: shlomi <shlomi.alfasi@hpe.com>
Vivek Srivastava [Thu, 27 Oct 2016 08:34:18 +0000 (08:34 +0000)]
Merge "Enhancing service binding logic to support more services"