Tom Pantelis [Wed, 13 Aug 2014 12:12:10 +0000 (12:12 +0000)]
Merge "Add exists method on DOMStoreReadTransaction and DOMDataReadTransaction"
Moiz Raja [Sun, 10 Aug 2014 23:18:33 +0000 (16:18 -0700)]
Add exists method on DOMStoreReadTransaction and DOMDataReadTransaction
Introducing this API does not impact clients as it is mostly internal.
One reason for adding this API is because of ensureParentsByMerge used in a couple of places
which keeps checking if a parent node exists by reading a node to figure out if it exists. This is
fine for the InMemoryDataStore but it can be terrible in a distributed data store where the shard
which contains the data is remote. All sorts of overhead is associated with a remote read including
serialization which can actually be pretty expensive.
Change-Id: Ib5be5f6dc60be683d7a04c81dad08c56cd5681f4
Signed-off-by: Moiz Raja <moraja@cisco.com>
Devin Avery [Tue, 12 Aug 2014 15:48:07 +0000 (15:48 +0000)]
Merge "Minor changes to config-persister to allow for karaf"
Ed Warnicke [Mon, 11 Aug 2014 02:43:06 +0000 (21:43 -0500)]
Minor changes to config-persister to allow for karaf
These minor changes expose a ConfigPusher service for use
by a config-persister-feature-adapter (to follow) that
can push configs attached to features.
Change-Id: I382d2ab578d19ea9c24afa521a9a5a047360fc50
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Devin Avery [Mon, 11 Aug 2014 14:05:57 +0000 (14:05 +0000)]
Merge "BUG 907 distinguish augmented nodes"
Jozef Gloncak [Tue, 15 Jul 2014 09:10:57 +0000 (11:10 +0200)]
BUG 907 distinguish augmented nodes
All nodes and their child contains also information about module from
which they comes from (module_name:node_name)
Change-Id: I7b146e820da1b5d3bdb62510a48e6845a78c80a2
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 5 Aug 2014 08:59:55 +0000 (10:59 +0200)]
BUG 1162 - problem to post list data
If last path arguments of instance identifier are list with keys then in
POST operation it is necessary to append it to instance identifier as
nodeWithKey.
This code was part of RestconfImpl but it was probably deleted
accidentaly.
Change-Id: I117cbcc39dcb97e8bc5ecc852ce2e9e7da7070cf
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Thu, 7 Aug 2014 06:09:50 +0000 (06:09 +0000)]
Merge "Fix test coverage not being reported in Sonar"
Ed Warnicke [Wed, 6 Aug 2014 19:21:31 +0000 (19:21 +0000)]
Merge "Remove old dependencies"
Robert Varga [Wed, 6 Aug 2014 05:45:21 +0000 (07:45 +0200)]
Fix test coverage not being reported in Sonar
Change-Id: Id8ff02a986b1bfdab01a481fcb11cef111757de9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 6 Aug 2014 15:52:19 +0000 (15:52 +0000)]
Merge "Optimilization the method datastoreNormalizedNodeToCompositeNode"
Tony Tkacik [Wed, 6 Aug 2014 14:54:41 +0000 (14:54 +0000)]
Merge "A little extra protection against nulls in ConfigPusher"
Tony Tkacik [Wed, 6 Aug 2014 12:10:12 +0000 (12:10 +0000)]
Merge changes If78d8143,Id8d04f24
* changes:
BUG-1281: eliminate thread-unsafe lookup
BUG-1281: make methods static
Jozef Gloncak [Wed, 6 Aug 2014 11:21:40 +0000 (13:21 +0200)]
Optimilization the method datastoreNormalizedNodeToCompositeNode
Origin method used schema context (which isn't necessary) and additionaly
doesn't cover all cases. + fixing of incorrect corresponding tests
Change-Id: Idbead2696de9102a202cad03c78f4a1a14a2d1d3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ed Warnicke [Wed, 6 Aug 2014 04:24:02 +0000 (23:24 -0500)]
A little extra protection against nulls in ConfigPusher
Change-Id: I4aab592b028b8336370c23924fcbf69858b7a6bd
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Robert Varga [Sun, 3 Aug 2014 13:39:11 +0000 (15:39 +0200)]
BUG-1281: eliminate thread-unsafe lookup
The URI/name lookup map was not safe when context was reloaded. Get rid
of it for now, as SchemaContext can maintain reasonably-fast lookups. At
the same time make sure we share codepaths as much as possible.
Change-Id: If78d8143e94446fe9b38da894611b1c8b61f57f3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 28 Jul 2014 20:02:40 +0000 (22:02 +0200)]
BUG-1281: make methods static
As it turns out ControllerContext has a few methods which do not touch
instance state -- make those static and fixup callers.
Change-Id: Id8d04f2426435528ee754f56b34f91d25a49d3ee
Signed-off-by: Robert Varga <rovarga@cisco.com>
Giovanni Meo [Mon, 4 Aug 2014 16:22:11 +0000 (18:22 +0200)]
Remove old dependencies
- Remove stale dependencies that prevent releasing of artifacts
- Remove unused flow-management-compatibility and
inventory-topology-compatibility modules
- Make sure that if a dependency is on module with a version defined
by a variable, lets specify the version in the dependency management
in common pom
- Replace in netconf-cli the reference from yang-data-json to
yang-data-composite-node because yang-data-json has been removed
- Removed whitespaces in config-netty-config that would cause
checkstyle issues downstream otherwise
Change-Id: I866e4b36e71c004b925bd181412ff4df91b3091f
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Jozef Gloncak [Tue, 5 Aug 2014 10:49:11 +0000 (12:49 +0200)]
Migrate to junit 4.11 - failing test
Corrected test which caused problems in
https://git.opendaylight.org/gerrit/#/c/9670/
Change-Id: Ife89b83bbc1d2df4dc34327e5f27ed47509a8b48
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Tue, 5 Aug 2014 15:18:02 +0000 (15:18 +0000)]
Merge "Fix failing IT tests"
Maros Marsalek [Tue, 5 Aug 2014 08:54:23 +0000 (10:54 +0200)]
Fix failing IT tests
- Binding Test Helper did not spefied object-cache as dependency
and it was already part of distribution
- API Doc plugin was using invalid YANG files for positive
test scenario.
Change-Id: I06c174408df6073d887f5c307cf1b70c34c442b1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Tue, 5 Aug 2014 10:09:13 +0000 (10:09 +0000)]
Merge "Fixed namespace of yang testing file."
Tony Tkacik [Mon, 4 Aug 2014 17:46:39 +0000 (19:46 +0200)]
Fixed typo in restconf, which caused classcast in datastore.
Change-Id: I51eb1fc2e4056dc84feb3b720c3ee844ee4ffdea
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Mon, 4 Aug 2014 14:11:50 +0000 (14:11 +0000)]
Merge "BUG 1162 - ensure data for all path arguments in datastore."
Jozef Gloncak [Mon, 4 Aug 2014 06:28:14 +0000 (08:28 +0200)]
BUG 1162 - ensure data for all path arguments in datastore.
Fixes
1) It is possible to specify path to data (including lists with
keys) via unexisting nodes and store payload data to this path.
Missing nodes in datastore are created before storing payload data.
2) InstanceIdentifier is now correctly created via
DataNormalizer.toNormalized()
Change-Id: If795a930015fef39a0029e808355d51357e2d5d5
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Martin Vitez [Mon, 4 Aug 2014 09:57:12 +0000 (11:57 +0200)]
Fixed namespace of yang testing file.
This test used 2 different yang files with same namespace, which is incorrect and can cause test fail later.
Change-Id: I87a78e36d1d8812bb92f71c82722f87559907423
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Robert Varga [Sun, 3 Aug 2014 11:31:05 +0000 (13:31 +0200)]
BUG-1473: update model.util.InstanceIdentifier users
Companion patch to https://git.opendaylight.org/gerrit/9622, updates
users to use the new name. Also make the code a tiny bit more readable.
Fixed conversion to checked Future.
Change-Id: If8da3639e656214713d3680951cd9ae724c5ad6f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Sun, 3 Aug 2014 18:14:29 +0000 (18:14 +0000)]
Merge "BUG-1281: share filters between instances"
Tony Tkacik [Sun, 3 Aug 2014 18:14:14 +0000 (18:14 +0000)]
Merge "BUG-1281: use SchemaContext lookups"
Tony Tkacik [Sun, 3 Aug 2014 18:10:03 +0000 (18:10 +0000)]
Merge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"
Robert Varga [Mon, 28 Jul 2014 19:53:51 +0000 (21:53 +0200)]
BUG-1281: share filters between instances
The filters are invariants, so lets share them accross instances and not
instantiate them each time we need them.
Change-Id: Ib632efe758c22bd782fca0536c2fe7e9c6e831c3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 28 Jul 2014 19:45:12 +0000 (21:45 +0200)]
BUG-1281: use SchemaContext lookups
SchemaContext provides efficient module lookup services. Use those
instead of homegrown versions.
Change-Id: I4406438b137c8742a5265036f84a66d7f0f441c0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jozef Gloncak [Mon, 30 Jun 2014 13:58:56 +0000 (15:58 +0200)]
BUG 1082 Migrate sal-rest-connector to Async Data Broker API
Rework of sal-rest-connector project to support Async Data Broker API
Change-Id: I73804418a04445b236d12693e493a11850dd94dd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ed Warnicke [Thu, 31 Jul 2014 23:19:46 +0000 (18:19 -0500)]
Moved all config subsystem config files to mvn projects.
Change-Id: I98f4ab29fd57b800d5c9272e866ead3519e09264
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Tony Tkacik [Fri, 1 Aug 2014 08:35:13 +0000 (08:35 +0000)]
Merge "ControllerContext.dataNodeChildByQName method refactoring"
Tony Tkacik [Fri, 1 Aug 2014 08:33:53 +0000 (08:33 +0000)]
Merge "Notificator create stream name method don't remove trailing slash"
Tony Tkacik [Fri, 1 Aug 2014 08:00:43 +0000 (08:00 +0000)]
Merge "BUG-868: Migrate to SchemaContextListener"
Jozef Gloncak [Fri, 25 Jul 2014 05:48:29 +0000 (07:48 +0200)]
ControllerContext.dataNodeChildByQName method refactoring
ControllerContext.dataNodeChildByQName() is used only in childByQName()
methods with DataNodeContainer input parameters:
- ContainerSchemaNode
- ListSchemaNode
- Module
Therefore child node of these DataNodeContainers can't be ChoiceCaseNode
(because it can be only child node of ChoiceNode)
and original branch >if (node instanceof ChoiceCaseNode)< couldn't be
executed.
I think that it was typo.
Change-Id: Ieb85ad8acaf047b47813542d8968c399a4e30b50
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Moiz Raja [Thu, 31 Jul 2014 14:19:12 +0000 (14:19 +0000)]
Merge "broken build - missing implementation of method getAnyXmlNodeSerializer"
Robert Varga [Sun, 9 Mar 2014 18:34:51 +0000 (19:34 +0100)]
BUG-868: Migrate to SchemaContextListener
SchemaServiceListener is deprecated, SchemaContextListener is its new
name. The class hierarchy allows for incremental migration.
Change-Id: I15d495d805eb7a08c3bcd3ab0cf8b5a8d2797db5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jozef Gloncak [Thu, 31 Jul 2014 13:47:40 +0000 (15:47 +0200)]
broken build - missing implementation of method getAnyXmlNodeSerializer
Change-Id: Ib7f22015462cb224e11c3c267cfbac7627eeb800
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 23 Jul 2014 11:12:20 +0000 (13:12 +0200)]
Notificator create stream name method don't remove trailing slash
Change-Id: I512879ce1b39b80b29a167147ef73e2ecef64afa
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ed Warnicke [Wed, 30 Jul 2014 12:05:21 +0000 (12:05 +0000)]
Merge "Serialization/Deserialization and a host of other fixes"
Moiz Raja [Thu, 10 Jul 2014 10:39:22 +0000 (03:39 -0700)]
Serialization/Deserialization and a host of other fixes
- Hande Cluster MemberUp and MemberRemoved events in ShardManager
- Cohort messages and close listener messages switched
to use protobuff
- Distributed Datastore switch messages to use protobuff
CreateTransaction
CreateTransactionReply
CreateTransactionChain
CreateTransactionChainReply distributed datastore messages
switched to protobuff
- ShardManager messages switch to protobuff
- DataChanged and other messages switch to protobuf in
distributed datastore
- Fixed few things found during testing
1. ShardStrategy - setting of configuration
2. NodeToNormalizedNodeBuilder - leaf node/leafsetentry node checks
3. DataChanged event - passing of scope instanceidentifier used during deserialization
- Introducing JMX MBeans for distributed datastore
-Fixed issues which were preventing remote Shards from talking to each other
- Fixed a number of issues related to deserialization
- Add distributed datastore to the build
- Switch from InstanceIdentifier to YangInstanceIdentifier
Change-Id: I0d15dc482cb2b0fb2170b1344bad9fa3b421e8e0
Signed-off-by: Moiz Raja <moraja@cisco.com>
Robert Varga [Tue, 29 Jul 2014 10:15:49 +0000 (12:15 +0200)]
BUG-1092: adjust to YangInstanceIdentifier
This is a compation to I1e30a0df93d8bfb891d047c58abcb117d4006c76,
adjusting the components to use the new name.
Change-Id: I615763240581e850f7752f82e44d752c8fceb169
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 29 Jul 2014 10:48:46 +0000 (10:48 +0000)]
Merge changes I1d768b2b,I9302e88a
* changes:
Fix identity-ref serialization in netconf.
BUG-1083 Netconf connector rework sal facade.
Tony Tkacik [Tue, 29 Jul 2014 09:29:39 +0000 (09:29 +0000)]
Merge changes Ifd28301d,I38220acb,I9bad24df
* changes:
WIP: Backwards compatible MountPointService
Fix children element lookup in XmlElement
Fix config attributes with same names for different modules.
Tony Tkacik [Tue, 29 Jul 2014 08:04:05 +0000 (08:04 +0000)]
Merge changes I442a0ee9,I11825b90
* changes:
Fix a typo
BUG-1281: call static methods
Maros Marsalek [Mon, 28 Jul 2014 08:33:33 +0000 (10:33 +0200)]
Fix identity-ref serialization in netconf.
Identity-ref attributes did not contain their namespace.
Change-Id: I1d768b2b59073d9fa322b66b002eddf39270bf17
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Fri, 25 Jul 2014 11:13:47 +0000 (13:13 +0200)]
Fix children element lookup in XmlElement
Change-Id: I38220acbfedf8f1b8554516f6abda4c1a16dd2ee
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Mon, 28 Jul 2014 19:31:45 +0000 (21:31 +0200)]
Fix a typo
Just a test name fix.
Change-Id: I442a0ee951475fb247eca4117ad61ed315a39dfc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 28 Jul 2014 19:11:36 +0000 (21:11 +0200)]
BUG-1281: call static methods
This is just a cleanup of warnings.
Change-Id: I11825b90b415c77074ff8684feaba918876e0c95
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 28 Jul 2014 15:05:01 +0000 (15:05 +0000)]
Merge "Wiring rest-connector with config subsytem."
Tony Tkacik [Mon, 28 Jul 2014 15:02:06 +0000 (15:02 +0000)]
Merge "Improve RESTCONF QName parsing speed"
Ed Warnicke [Thu, 24 Jul 2014 19:12:18 +0000 (14:12 -0500)]
Wiring rest-connector with config subsytem.
Change-Id: If826bb7352101833acd288b81cbcf7cec2f28b43
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:32:53 +0000 (06:32 +0200)]
Improve RESTCONF QName parsing speed
SchemaContext provides useful (and optimized) methods for looking up
modules. Eliminate home-grown version of findModuleByName(). Requires
https://git.opendaylight.org/gerrit/#/c/9351/ .
Change-Id: I4c4e07e23a614b46b01a87485965af0c066aa693
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 28 Jul 2014 08:56:53 +0000 (08:56 +0000)]
Merge "Optimize RESTCONF module/node parsing"
Tony Tkacik [Mon, 28 Jul 2014 08:56:39 +0000 (08:56 +0000)]
Merge "Improve RESTCONF thread safety when reconfiguring"
Tony Tkacik [Mon, 28 Jul 2014 08:56:15 +0000 (08:56 +0000)]
Merge "Allow getChildNodes() to become a Collection"
Robert Varga [Sat, 26 Jul 2014 04:41:44 +0000 (06:41 +0200)]
Optimize RESTCONF module/node parsing
Profiling has shown that the current implementations are still not upto
par with what they should be: 189 invocations of the two consumed 64ms,
with most of the time being spent splitting and iterating.
Given that the parsing operation is really simple, we can do much better
using String.indexOf() and String.substring().
Change-Id: I06ef0403edb2c8d12cbbc3c7909091e9efc5138e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:18:40 +0000 (06:18 +0200)]
Improve RESTCONF thread safety when reconfiguring
There is a race which could see us without a populated mapping while a
schemacontext change is underway. Use a immutablemap guarded by an
atomicreference to allow proper switching. Note that the fix is
incomplete, as the schema context needs to be replaced at the same time.
Change-Id: I7d64fae99a0bc0f7d1ec19f08450c1954cb7af97
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:06:52 +0000 (06:06 +0200)]
Allow getChildNodes() to become a Collection
Preparatory patch for yangtools change -- getChildNodes() will start
returning a Collection, not a Set.
Change-Id: Ie7255757e3f48465e3acd9e65764f1b79a3a9511
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Thu, 24 Jul 2014 11:43:09 +0000 (13:43 +0200)]
Make DOMMountPointService listenable
Change-Id: Ic44a4bf214f6f6a6d653627b6a62ab2f47bd9963
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Jozef Gloncak [Wed, 23 Jul 2014 11:55:21 +0000 (13:55 +0200)]
BUG 1144 - response 500 instead of 400
RestconfDocumentedException with error tag INVALID_VALUE (400) was caught and
wrapped to RestconfDocumentedException with error tag OPERATION_FAILED
(500)
Change-Id: I0ad75958e0d8e25d5bf1bdf7cbac5f855cc2b03d
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Jul 2014 07:06:11 +0000 (09:06 +0200)]
BUG 1379 - rpcs behind yang-ext:mount aren't always executed
new corrected behavior:
If rpc is from device behing yang-ext:mount and it doesn't exist in
controller then it is ALSO executed.
Change-Id: Ieebf2522b39cd42a8da57b05cf49e528c924f7ba
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 11:48:03 +0000 (13:48 +0200)]
Fixed incorrect XML test suites & Usage of removed API
Change in underlying YANG Tools codec, unvereded
that there were test-suites which did string
comparison for testing of XML responses and
any change in XML serialization (valid from
XML point-of-view) triggered this tests to
fail.
Reworked offending tests to use XML W3C Document
for testing instead of string comparison and regexes.
Change-Id: Ib6e35e8d2fe79275666235370d1dda461277a59f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 09:40:53 +0000 (09:40 +0000)]
Merge "BUG 1387 - degrade log output from info to debug"
Jozef Gloncak [Mon, 21 Jul 2014 08:48:29 +0000 (10:48 +0200)]
BUG 1387 - degrade log output from info to debug
Change-Id: Ia98ab154bb53cc3c43f42270a3bd6c65bd9dee65
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 08:08:41 +0000 (08:08 +0000)]
Merge "Bug 1239 - Clean up and refactor netconf-ssh client"
Tony Tkacik [Fri, 18 Jul 2014 09:07:03 +0000 (09:07 +0000)]
Merge "BUG-1384: YangStoreServiceImpl.refresh() should never block"
Tony Tkacik [Fri, 18 Jul 2014 07:33:35 +0000 (07:33 +0000)]
Merge "BUG-1365 Check if channel was closed when negotiation fails"
Robert Varga [Thu, 17 Jul 2014 14:19:32 +0000 (16:19 +0200)]
BUG-1384: YangStoreServiceImpl.refresh() should never block
As descirbed in the bug, we are seeing large amounts of contention on
the monitor when calling refresh(). Rework the safety such that the
refresh path does not block and perform checking for refresh in the
get() path, which is forced to retry should a refresh occur.
With this patch reported contention disappears completely and startup
time is improved by about 8 seconds on stock SP edition.
Change-Id: I4c6109d77324d3d1b700041b54a95dc346e3d372
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Tue, 15 Jul 2014 13:55:34 +0000 (15:55 +0200)]
BUG-1365 Check if channel was closed when negotiation fails
Also set state only if promise is not yet finished.
Replace custom EOM aggregator with implementation provided by netty.
Change-Id: Iffb740fff1512ca14efe58ed5112f74ce5e75c97
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Devin Avery [Wed, 16 Jul 2014 18:31:51 +0000 (18:31 +0000)]
Merge "Deprecated Rpcs and RpcErrors helper classes"
Tomas Olvecky [Thu, 26 Jun 2014 11:18:24 +0000 (13:18 +0200)]
Bug 1239 - Clean up and refactor netconf-ssh client
Remove commented and dead code in netconf-netty-util.
Move SshHandler to client package in order to make it package private.
Wrap OutputStream in SSHClientHandler with a buffer.
Remove VirtualSocketException as it was a workaround for
passing context without checking whether session was established.
Change-Id: I992d3b8ba2b2a58b69bd2e8be4ad0e4bdfa36c01
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Tue, 15 Jul 2014 09:36:11 +0000 (09:36 +0000)]
Merge "BUG-1317 BUG-1351 Fix duplicate connections from netconf connector"
Maros Marsalek [Mon, 14 Jul 2014 16:04:53 +0000 (18:04 +0200)]
BUG-1317 BUG-1351 Fix duplicate connections from netconf connector
Change-Id: I2c3135f3f84ef25f0005744c03003462c96812c1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Jozef Gloncak [Fri, 11 Jul 2014 08:26:07 +0000 (10:26 +0200)]
Apply style rules on whole sal-rest-connector
No changes in function of code, just formatting.
Change-Id: I52bf10a3b84fa61ec35c31145acbbc6b9bf349ec
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
tpantelis [Thu, 10 Jul 2014 06:49:07 +0000 (02:49 -0400)]
Deprecated Rpcs and RpcErrors helper classes
With the new RpcResultBuilder class, we can deprecate the Rpcs and
RpcErrors classes.
Also migrate all uses of the deprecated classes to RpcResultBuilder in
the controller code.
Change-Id: I86408bba0ce19e70c7d7a41555e94052e54e93f8
Signed-off-by: tpantelis <tpanteli@brocade.com>
Tom Pantelis [Fri, 11 Jul 2014 14:55:36 +0000 (14:55 +0000)]
Merge "BUG 1330 - list key counts|values diff in payload and URI"
Tony Tkacik [Fri, 11 Jul 2014 11:35:41 +0000 (11:35 +0000)]
Merge "Introducing simple merge strategy for config subsystem"
Tomas Olvecky [Wed, 9 Jul 2014 13:27:09 +0000 (15:27 +0200)]
Introducing simple merge strategy for config subsystem
MergeEditStrategy wasn't really merging.
Now it is, but only for ObjectName[].
However, since ObjectName[] is 90% of the interesting
cases, this should get us a long way.
This is needed to be able to handle reasonably
extension, with the ability to wire in multiple
extension modules independently, as we need to do
for things like OF extension.
Change-Id: Ieca579cbc6781d77f489f5f754490c8da8f65188
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Thu, 10 Jul 2014 08:04:31 +0000 (08:04 +0000)]
Merge "Bug 1341 - Make RESTConf websocket port configurable"
Jozef Gloncak [Thu, 10 Jul 2014 08:02:00 +0000 (10:02 +0200)]
BUG 1330 - list key counts|values diff in payload and URI
Adds validation whether list key counts or list key values are different
between payload and URI. It difference occures then
RestconfDocumentedException is raised.
Change-Id: I93aaa352cfb8daee298ebf16375cb70987328dbb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Richard Kosegi [Wed, 9 Jul 2014 13:31:05 +0000 (15:31 +0200)]
Bug 1341 - Make RESTConf websocket port configurable
Change-Id: I54f4bcadd864eb264b92f00b82b81489e9ebecf0
Signed-off-by: Richard Kosegi <rkosegi@cisco.com>
Tony Tkacik [Wed, 9 Jul 2014 09:09:32 +0000 (09:09 +0000)]
Merge "Bug 1293 - Switch packaging of config-util to bundle"
Tom Pantelis [Tue, 8 Jul 2014 18:19:55 +0000 (18:19 +0000)]
Merge "BUG 1204 - exception if multiple container node occures"
Ed Warnicke [Tue, 8 Jul 2014 13:36:07 +0000 (13:36 +0000)]
Merge "Add netconf-cli temporary files to .gitignore"
Jozef Gloncak [Tue, 24 Jun 2014 06:13:53 +0000 (08:13 +0200)]
BUG 1204 - exception if multiple container node occures
Container schema node + multiple data nodes ->
exception RestconfDocumentedException is raised.
List schema node + one data node (e. g. in json is specified as container
"list-name":{} and not "list-name":[{},{}...,{}] -> this is acceptable case because
list can have even only one entry.
Leaf schema node + multiple data nodes -> special check whether at
equal objects is everytime uniqe key. If it isn't so then
RestconfDocumentedException is raised. For Json specific JsonParser was
implemented which is catch duplicity at object level an time of parsing.
For XML this duplicity name check is done during normalization phase.
Change-Id: I0b544c015bcf817e82206276bd24c783093308d6
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tomas Olvecky [Tue, 8 Jul 2014 09:17:19 +0000 (11:17 +0200)]
Bug 1293 - Switch packaging of config-util to bundle
Add new bundle to the distribution - config-util, that was previously
packaged as regular jar and copied into where it was required.
Change-Id: I8a28b4a0b19e4dc6cbc2d71e60cf714cca188a84
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tomas Olvecky [Tue, 8 Jul 2014 09:11:40 +0000 (11:11 +0200)]
Add netconf-cli temporary files to .gitignore
Change-Id: Ic5eeab930ad0508a7e373b227d9a814ab4ae0010
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Devin Avery [Mon, 7 Jul 2014 11:04:56 +0000 (11:04 +0000)]
Merge "BUG 1016 - JSON|XML output with|without white chars"
Tony Tkacik [Fri, 4 Jul 2014 09:24:37 +0000 (09:24 +0000)]
Merge "BUG-692 Add log to config persister test."
Tony Tkacik [Fri, 4 Jul 2014 08:27:29 +0000 (08:27 +0000)]
Merge "Adding a method to process Identities in a YANG Model"
Maros Marsalek [Fri, 4 Jul 2014 08:04:15 +0000 (10:04 +0200)]
BUG-692 Add log to config persister test.
Change-Id: Id77d577b2d4ff30531ee5de7b401d21a84944511
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Fri, 4 Jul 2014 07:48:26 +0000 (07:48 +0000)]
Merge "BUG-1041 cli proposal #1"
Jozef Gloncak [Fri, 4 Jul 2014 06:54:34 +0000 (08:54 +0200)]
Adding a method to process Identities in a YANG Model
Change-Id: Ic07025c3c86d847d2882d80fa360e9a5978275df
Signed-off-by: Mayank Agarwal <mayagarw@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 25 Jun 2014 09:16:05 +0000 (11:16 +0200)]
BUG 1016 - JSON|XML output with|without white chars
Pretty print formating can be turned on for XML | JSON output via URI parameter
prettyPrint=true.
In other cases (prettyPrint=false, other value, missing
URI parameter...) XML | JSON output are returned as stream of characters
without white characters.
Example of URI:
http://localhost:8080/restconf/config/opendaylight-inventory:nodes?prettyPrint=true
Change-Id: I459c9663cdf8bfc78b8df67d7338a44d77c18a5c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Thu, 3 Jul 2014 14:36:35 +0000 (14:36 +0000)]
Merge "Bug 1290 - Swagger Documentation is failing to load - java script exception"
Robert Varga [Wed, 2 Jul 2014 20:32:07 +0000 (22:32 +0200)]
BUG-868: donot use deprecated call
WebSocketServerHandshakerFactory.sendUnsupportedVersionResponse() is the
replacement, so use it instead of
sendUnsupportedWebSocketVersionResponse().
Change-Id: I03116f09e757df9694ac077c9e82296eaf19de90
Signed-off-by: Robert Varga <rovarga@cisco.com>