netconf.git
9 years agoMerge "BUG-1617 Extract AuthProvider from netconf ssh"
Tony Tkacik [Thu, 28 Aug 2014 15:47:25 +0000 (15:47 +0000)]
Merge "BUG-1617 Extract AuthProvider from netconf ssh"

9 years agoMerge "BUG-1621 Fix reconnecting."
Tony Tkacik [Wed, 27 Aug 2014 15:11:16 +0000 (15:11 +0000)]
Merge "BUG-1621 Fix reconnecting."

9 years agoBUG-1621 Fix reconnecting.
Maros Marsalek [Wed, 27 Aug 2014 12:51:12 +0000 (14:51 +0200)]
BUG-1621 Fix reconnecting.

Netconf-connector did not reconnect after recent changes (Ssh mina integration)
SshHandler was in pipeline after listener in reconnect, thats why the listener received no event about session down.

Change-Id: Id39062f51bc3a0caf066ca49682a2acc837b06ef
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Bug 1616: Issues with using container and default values in config yang"
Moiz Raja [Tue, 26 Aug 2014 15:39:07 +0000 (15:39 +0000)]
Merge "Bug 1616: Issues with using container and default values in config yang"

9 years agoBUG-1617 Extract AuthProvider from netconf ssh
Maros Marsalek [Tue, 26 Aug 2014 14:53:07 +0000 (16:53 +0200)]
BUG-1617 Extract AuthProvider from netconf ssh

Change-Id: Ib6f47c0dca5b4b3604b639ae8bca3565f8dd934c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "BUG-1618 Handle pending writes in ssh netconfclient"
Tony Tkacik [Tue, 26 Aug 2014 14:09:48 +0000 (14:09 +0000)]
Merge "BUG-1618 Handle pending writes in ssh netconfclient"

9 years agoBUG-1618 Handle pending writes in ssh netconfclient
Maros Marsalek [Tue, 26 Aug 2014 11:46:32 +0000 (13:46 +0200)]
BUG-1618 Handle pending writes in ssh netconfclient

Change-Id: If4371860e81cf4153c4baaa8a9b0d3c45334ab5c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "BUG-1521 Increase test coverage of netconf-netty-util"
Tony Tkacik [Tue, 26 Aug 2014 07:37:44 +0000 (07:37 +0000)]
Merge "BUG-1521 Increase test coverage of netconf-netty-util"

9 years agoMerge "BUG-1568 Remove unused VirtualSocket"
Tony Tkacik [Tue, 26 Aug 2014 07:37:31 +0000 (07:37 +0000)]
Merge "BUG-1568 Remove unused VirtualSocket"

9 years agoMerge "BUG-1521 Netconf-monitoring test coverage raise"
Tony Tkacik [Tue, 26 Aug 2014 07:37:20 +0000 (07:37 +0000)]
Merge "BUG-1521 Netconf-monitoring test coverage raise"

9 years agoBUG-1521 Increase test coverage of netconf-netty-util
Maros Marsalek [Mon, 25 Aug 2014 15:14:11 +0000 (17:14 +0200)]
BUG-1521 Increase test coverage of netconf-netty-util

Change-Id: I962e16da8d4112b4ec6a1c90170be3036041eddd
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG-1568 Remove unused VirtualSocket
Maros Marsalek [Mon, 25 Aug 2014 15:13:36 +0000 (17:13 +0200)]
BUG-1568 Remove unused VirtualSocket

Change-Id: I75682c0ec0b0956ba04060cdbcdee32a53a459c9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG-1521 Netconf-monitoring test coverage raise
Maros Marsalek [Mon, 25 Aug 2014 13:07:50 +0000 (15:07 +0200)]
BUG-1521 Netconf-monitoring test coverage raise

Change-Id: Ibcbcd7df788c75879fa0c9a554125144aa5c1545
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "BUG-1568 Remove ganymed Ssh client adapter"
Ed Warnicke [Mon, 25 Aug 2014 11:15:10 +0000 (11:15 +0000)]
Merge "BUG-1568 Remove ganymed Ssh client adapter"

9 years agoMerge "BUG-1568 Ssh Handler for netconf client Mina implementation"
Ed Warnicke [Mon, 25 Aug 2014 11:14:59 +0000 (11:14 +0000)]
Merge "BUG-1568 Ssh Handler for netconf client Mina implementation"

9 years agoBUG-1568 Remove ganymed Ssh client adapter
Maros Marsalek [Mon, 25 Aug 2014 08:11:25 +0000 (10:11 +0200)]
BUG-1568 Remove ganymed Ssh client adapter

Change-Id: Id4ec6140df3e91fd8a219b03ceabca67732af568
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1568 Ssh Handler for netconf client Mina implementation
Maros Marsalek [Mon, 25 Aug 2014 08:01:47 +0000 (10:01 +0200)]
BUG-1568 Ssh Handler for netconf client Mina implementation

This implementation of Ssh Handler is asynchronous and based on Apache Mina SSHD.

+ Add Mina SSHD to distribution.

Change-Id: I51f51e2eb56b5f97a87c3d068ea90f8a44adca09
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Fix for possible NPE if Bundle is stopped."
Moiz Raja [Mon, 25 Aug 2014 04:56:54 +0000 (04:56 +0000)]
Merge "Fix for possible NPE if Bundle is stopped."

9 years agoBug 1616: Issues with using container and default values in config yang
tpantelis [Sat, 23 Aug 2014 13:51:00 +0000 (09:51 -0400)]
Bug 1616: Issues with using container and default values in config yang

Fixed issues as outlined in bug 1616.

Change-Id: I6170a6d25e2fb243d6526d15058057191058bb82
Signed-off-by: tpantelis <tpanteli@brocade.com>
9 years agoMerge "Bug 1586: Do not use JaxRS 2.0 unnecessarily"
Ed Warnicke [Thu, 21 Aug 2014 14:38:56 +0000 (14:38 +0000)]
Merge "Bug 1586: Do not use JaxRS 2.0 unnecessarily"

9 years agoMerge "BUG-1568 Getting rid of StreamGobller from netconf ssh client."
Tony Tkacik [Thu, 21 Aug 2014 09:09:01 +0000 (09:09 +0000)]
Merge "BUG-1568 Getting rid of StreamGobller from netconf ssh client."

9 years agoMerge "BUG-1541 Make EXI and clientConnectTimeout configurable in testtool."
Tony Tkacik [Thu, 21 Aug 2014 09:08:47 +0000 (09:08 +0000)]
Merge "BUG-1541 Make EXI and clientConnectTimeout configurable in testtool."

9 years agoMerge "Fix race condition in SSH NETCONF server"
Tony Tkacik [Thu, 21 Aug 2014 09:08:33 +0000 (09:08 +0000)]
Merge "Fix race condition in SSH NETCONF server"

9 years agoBug 1586: Do not use JaxRS 2.0 unnecessarily
Tony Tkacik [Thu, 21 Aug 2014 08:32:11 +0000 (10:32 +0200)]
Bug 1586: Do not use JaxRS 2.0 unnecessarily

As it turned out our container uses jax-rs 1.0 so we removed
unnecessarily call to 2.0 constructor.

Change-Id: I23c38871050c34d721b21369da5b162a18925a9d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBUG-1568 Getting rid of StreamGobller from netconf ssh client.
Maros Marsalek [Wed, 20 Aug 2014 13:11:35 +0000 (15:11 +0200)]
BUG-1568 Getting rid of StreamGobller from netconf ssh client.

We have another thread in SshClientAdapter that works as StreamGobller
http://www.ganymed.ethz.ch/ssh2/FAQ.html#blocking

Change-Id: I3f61b14cb22396d8b5898028bd83f62d98c6866d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "NETCONF scalability: share instances"
Tony Tkacik [Thu, 21 Aug 2014 07:20:59 +0000 (07:20 +0000)]
Merge "NETCONF scalability: share instances"

9 years agoMerge "BUG 932 - Swagger HTTP POST contains incorrect object"
Devin Avery [Wed, 20 Aug 2014 13:14:36 +0000 (13:14 +0000)]
Merge "BUG 932 - Swagger HTTP POST contains incorrect object"

9 years agoNETCONF scalability: share instances
Robert Varga [Wed, 20 Aug 2014 12:29:07 +0000 (14:29 +0200)]
NETCONF scalability: share instances

Scalability testing shows that the netconf session code:
- retains XML document reference
- does not reuse QName instances

Change-Id: I6b58355e3fa74d67872d665d0f8dc2d16abe156c
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1541 Make EXI and clientConnectTimeout configurable in testtool.
Maros Marsalek [Wed, 20 Aug 2014 11:28:34 +0000 (13:28 +0200)]
BUG-1541 Make EXI and clientConnectTimeout configurable in testtool.

Change-Id: I0152a78691b87a2d2674b0ecf0e4844f0ca9b35b
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoFix race condition in SSH NETCONF server
Maros Marsalek [Wed, 20 Aug 2014 09:32:44 +0000 (11:32 +0200)]
Fix race condition in SSH NETCONF server

Change-Id: I205a1670b30dcfad4230418c133fd87e069e15e6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG 932 - Swagger HTTP POST contains incorrect object
Jozef Gloncak [Wed, 16 Jul 2014 12:03:20 +0000 (14:03 +0200)]
BUG 932 - Swagger HTTP POST contains incorrect object

POST link now contains specific JSON structure which ends with POST suffix
and contains all containers and lists which are direct subchildren of
current node (URI link). It is list of possible objects which can be used
in POST request. Concretelly are these objects specified below this *POST
JSON object and are also all specified in Parameters section of GUI POST
URI link with ** prefix. Two stars (**) mean that only one of parameters
with ** prefix should be specified.

Change-Id: I3acdfd1f181fbef7cca0060d534b706d934bb1e3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoFix for possible NPE if Bundle is stopped.
Ed Warnicke [Tue, 12 Aug 2014 15:45:34 +0000 (10:45 -0500)]
Fix for possible NPE if Bundle is stopped.

Change-Id: Iaf1d44f8b600e69392452b74042812b35e8101de
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "Modifications to error handling in restconf"
Devin Avery [Mon, 18 Aug 2014 15:24:20 +0000 (15:24 +0000)]
Merge "Modifications to error handling in restconf"

9 years agoMerge "BUG-1541 Netconf device simulating testtool"
Ed Warnicke [Mon, 18 Aug 2014 15:20:04 +0000 (15:20 +0000)]
Merge "BUG-1541 Netconf device simulating testtool"

9 years agoMerge "BUG-1541 Extract AuthProvider interface"
Ed Warnicke [Mon, 18 Aug 2014 15:19:51 +0000 (15:19 +0000)]
Merge "BUG-1541 Extract AuthProvider interface"

9 years agoMerge "Fix precondition formatting"
Ed Warnicke [Mon, 18 Aug 2014 14:52:17 +0000 (14:52 +0000)]
Merge "Fix precondition formatting"

9 years agoBUG-1541 Netconf device simulating testtool
Maros Marsalek [Tue, 12 Aug 2014 13:31:27 +0000 (15:31 +0200)]
BUG-1541 Netconf device simulating testtool

Produces executable jar file.

The jar can simulate arbitrary number of netconf devices that listen on configured ports
Schemas are loaded from a provided folder
Can also generate ODL initial config files for started simulated devices to support testing with ODL distribution

Change-Id: I8fce73fa7c568a272c29073f26a4e8aafeebfd82
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG-1541 Extract AuthProvider interface
Maros Marsalek [Tue, 12 Aug 2014 13:30:57 +0000 (15:30 +0200)]
BUG-1541 Extract AuthProvider interface

Change-Id: I8df939b1c712fe85f3cd269df50b01ceee2d9538
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Bug 1503: RestconfError "data-missing" is error code 404."
Ed Warnicke [Fri, 15 Aug 2014 19:27:38 +0000 (19:27 +0000)]
Merge "Bug 1503: RestconfError "data-missing" is error code 404."

9 years agoBug 1503: RestconfError "data-missing" is error code 404.
Robert Varga [Tue, 12 Aug 2014 18:08:49 +0000 (20:08 +0200)]
Bug 1503: RestconfError "data-missing" is error code 404.

The base specification listed the error code to be 409, which is in
direct violation on HTTP. The restconf specification will be fixed in
the upcoming draft, meanwhile we are going for the new, sane behavior
regardless.

Change-Id: I7a6cf67a794f8348d746ba94b7de9580d0472a61
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoModifications to error handling in restconf
tpantelis [Wed, 13 Aug 2014 12:55:16 +0000 (08:55 -0400)]
Modifications to error handling in restconf

Modified error handling for read and write Tx to transfer to transfer
RpcError info from ReadFailedException and
TransactionCommitFailedException to the RestconfDocumentedException.

Change-Id: Ifb47f0cdfda5a11d53add9d7ef8fbe50954c0206
Signed-off-by: tpantelis <tpanteli@brocade.com>
9 years agoFix precondition formatting
Robert Varga [Thu, 14 Aug 2014 19:45:42 +0000 (21:45 +0200)]
Fix precondition formatting

Preconditions take String.format() arguments, not {} placeholders.

Change-Id: I6fe863e3954ccb0c6a861ec969691072933406a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-997 Use shared schema context factory in netconf-connector"
Ed Warnicke [Wed, 13 Aug 2014 13:43:31 +0000 (13:43 +0000)]
Merge "BUG-997 Use shared schema context factory in netconf-connector"

9 years agoMerge "Add exists method on DOMStoreReadTransaction and DOMDataReadTransaction"
Tom Pantelis [Wed, 13 Aug 2014 12:12:10 +0000 (12:12 +0000)]
Merge "Add exists method on DOMStoreReadTransaction and DOMDataReadTransaction"

9 years agoAdd exists method on DOMStoreReadTransaction and DOMDataReadTransaction
Moiz Raja [Sun, 10 Aug 2014 23:18:33 +0000 (16:18 -0700)]
Add exists method on DOMStoreReadTransaction and DOMDataReadTransaction

Introducing this API does not impact clients as it is mostly internal.

One reason for adding this API is because of ensureParentsByMerge used in a couple of places
which keeps checking if a parent node exists by reading a node to figure out if it exists. This is
fine for the InMemoryDataStore but it can be terrible in a distributed data store where the shard
which contains the data is remote. All sorts of overhead is associated with a remote read including
serialization which can actually be pretty expensive.

Change-Id: Ib5be5f6dc60be683d7a04c81dad08c56cd5681f4
Signed-off-by: Moiz Raja <moraja@cisco.com>
9 years agoMerge "Minor changes to config-persister to allow for karaf"
Devin Avery [Tue, 12 Aug 2014 15:48:07 +0000 (15:48 +0000)]
Merge "Minor changes to config-persister to allow for karaf"

9 years agoBUG-997 Use shared schema context factory in netconf-connector
Maros Marsalek [Mon, 4 Aug 2014 14:35:47 +0000 (16:35 +0200)]
BUG-997 Use shared schema context factory in netconf-connector

+ Fix disconnect by netconf-connector. Until now, the connection to remote device was still open even if initialization failed.

Change-Id: I23ee999c7898665498519abf19610deef3d410a3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMinor changes to config-persister to allow for karaf
Ed Warnicke [Mon, 11 Aug 2014 02:43:06 +0000 (21:43 -0500)]
Minor changes to config-persister to allow for karaf

These minor changes expose a ConfigPusher service for use
by a config-persister-feature-adapter (to follow) that
can push configs attached to features.

Change-Id: I382d2ab578d19ea9c24afa521a9a5a047360fc50
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "BUG 907 distinguish augmented nodes"
Devin Avery [Mon, 11 Aug 2014 14:05:57 +0000 (14:05 +0000)]
Merge "BUG 907 distinguish augmented nodes"

9 years agoBUG 907 distinguish augmented nodes
Jozef Gloncak [Tue, 15 Jul 2014 09:10:57 +0000 (11:10 +0200)]
BUG 907 distinguish augmented nodes

All nodes and their child contains also information about module from
which they comes from (module_name:node_name)

Change-Id: I7b146e820da1b5d3bdb62510a48e6845a78c80a2
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBUG 1162 - problem to post list data
Jozef Gloncak [Tue, 5 Aug 2014 08:59:55 +0000 (10:59 +0200)]
BUG 1162 - problem to post list data

If last path arguments of instance identifier are list with keys then in
POST operation it is necessary to append it to instance identifier as
nodeWithKey.

This code was part of RestconfImpl but it was probably deleted
accidentaly.

Change-Id: I117cbcc39dcb97e8bc5ecc852ce2e9e7da7070cf
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "Fix test coverage not being reported in Sonar"
Tony Tkacik [Thu, 7 Aug 2014 06:09:50 +0000 (06:09 +0000)]
Merge "Fix test coverage not being reported in Sonar"

9 years agoMerge "Remove old dependencies"
Ed Warnicke [Wed, 6 Aug 2014 19:21:31 +0000 (19:21 +0000)]
Merge "Remove old dependencies"

9 years agoFix test coverage not being reported in Sonar
Robert Varga [Wed, 6 Aug 2014 05:45:21 +0000 (07:45 +0200)]
Fix test coverage not being reported in Sonar

Change-Id: Id8ff02a986b1bfdab01a481fcb11cef111757de9
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Optimilization the method datastoreNormalizedNodeToCompositeNode"
Tony Tkacik [Wed, 6 Aug 2014 15:52:19 +0000 (15:52 +0000)]
Merge "Optimilization the method datastoreNormalizedNodeToCompositeNode"

9 years agoMerge "A little extra protection against nulls in ConfigPusher"
Tony Tkacik [Wed, 6 Aug 2014 14:54:41 +0000 (14:54 +0000)]
Merge "A little extra protection against nulls in ConfigPusher"

9 years agoMerge changes If78d8143,Id8d04f24
Tony Tkacik [Wed, 6 Aug 2014 12:10:12 +0000 (12:10 +0000)]
Merge changes If78d8143,Id8d04f24

* changes:
  BUG-1281: eliminate thread-unsafe lookup
  BUG-1281: make methods static

9 years agoOptimilization the method datastoreNormalizedNodeToCompositeNode
Jozef Gloncak [Wed, 6 Aug 2014 11:21:40 +0000 (13:21 +0200)]
Optimilization the method datastoreNormalizedNodeToCompositeNode

Origin method used schema context (which isn't necessary) and additionaly
doesn't cover all cases. + fixing of incorrect corresponding tests

Change-Id: Idbead2696de9102a202cad03c78f4a1a14a2d1d3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoA little extra protection against nulls in ConfigPusher
Ed Warnicke [Wed, 6 Aug 2014 04:24:02 +0000 (23:24 -0500)]
A little extra protection against nulls in ConfigPusher

Change-Id: I4aab592b028b8336370c23924fcbf69858b7a6bd
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBUG-1281: eliminate thread-unsafe lookup
Robert Varga [Sun, 3 Aug 2014 13:39:11 +0000 (15:39 +0200)]
BUG-1281: eliminate thread-unsafe lookup

The URI/name lookup map was not safe when context was reloaded. Get rid
of it for now, as SchemaContext can maintain reasonably-fast lookups. At
the same time make sure we share codepaths as much as possible.

Change-Id: If78d8143e94446fe9b38da894611b1c8b61f57f3
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1281: make methods static
Robert Varga [Mon, 28 Jul 2014 20:02:40 +0000 (22:02 +0200)]
BUG-1281: make methods static

As it turns out ControllerContext has a few methods which do not touch
instance state -- make those static and fixup callers.

Change-Id: Id8d04f2426435528ee754f56b34f91d25a49d3ee
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRemove old dependencies
Giovanni Meo [Mon, 4 Aug 2014 16:22:11 +0000 (18:22 +0200)]
Remove old dependencies

- Remove stale dependencies that prevent releasing of artifacts
- Remove unused flow-management-compatibility and
inventory-topology-compatibility modules
- Make sure that if a dependency is on module with a version defined
by a variable, lets specify the version in the dependency management
in common pom
- Replace in netconf-cli the reference from yang-data-json to
yang-data-composite-node because yang-data-json has been removed
- Removed whitespaces in config-netty-config that would cause
checkstyle issues downstream otherwise

Change-Id: I866e4b36e71c004b925bd181412ff4df91b3091f
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoMigrate to junit 4.11 - failing test
Jozef Gloncak [Tue, 5 Aug 2014 10:49:11 +0000 (12:49 +0200)]
Migrate to junit 4.11 - failing test

Corrected test which caused problems in
https://git.opendaylight.org/gerrit/#/c/9670/

Change-Id: Ife89b83bbc1d2df4dc34327e5f27ed47509a8b48
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "Fix failing IT tests"
Tony Tkacik [Tue, 5 Aug 2014 15:18:02 +0000 (15:18 +0000)]
Merge "Fix failing IT tests"

9 years agoFix failing IT tests
Maros Marsalek [Tue, 5 Aug 2014 08:54:23 +0000 (10:54 +0200)]
Fix failing IT tests

- Binding Test Helper did not spefied object-cache as dependency
  and it was already part of distribution
- API Doc plugin was using invalid YANG files for positive
  test scenario.

Change-Id: I06c174408df6073d887f5c307cf1b70c34c442b1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Fixed namespace of yang testing file."
Tony Tkacik [Tue, 5 Aug 2014 10:09:13 +0000 (10:09 +0000)]
Merge "Fixed namespace of yang testing file."

9 years agoFixed typo in restconf, which caused classcast in datastore.
Tony Tkacik [Mon, 4 Aug 2014 17:46:39 +0000 (19:46 +0200)]
Fixed typo in restconf, which caused classcast in datastore.

Change-Id: I51eb1fc2e4056dc84feb3b720c3ee844ee4ffdea
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "BUG 1162 - ensure data for all path arguments in datastore."
Tony Tkacik [Mon, 4 Aug 2014 14:11:50 +0000 (14:11 +0000)]
Merge "BUG 1162 - ensure data for all path arguments in datastore."

9 years agoBUG 1162 - ensure data for all path arguments in datastore.
Jozef Gloncak [Mon, 4 Aug 2014 06:28:14 +0000 (08:28 +0200)]
BUG 1162 - ensure data for all path arguments in datastore.

Fixes
1) It is possible to specify path to data (including lists with
keys) via unexisting nodes and store payload data to this path.
Missing nodes in datastore are created before storing payload data.
2) InstanceIdentifier is now correctly created via
DataNormalizer.toNormalized()

Change-Id: If795a930015fef39a0029e808355d51357e2d5d5
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoFixed namespace of yang testing file.
Martin Vitez [Mon, 4 Aug 2014 09:57:12 +0000 (11:57 +0200)]
Fixed namespace of yang testing file.

This test used 2 different yang files with same namespace, which is incorrect and can cause test fail later.

Change-Id: I87a78e36d1d8812bb92f71c82722f87559907423
Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoBUG-1473: update model.util.InstanceIdentifier users
Robert Varga [Sun, 3 Aug 2014 11:31:05 +0000 (13:31 +0200)]
BUG-1473: update model.util.InstanceIdentifier users

Companion patch to https://git.opendaylight.org/gerrit/9622, updates
users to use the new name. Also make the code a tiny bit more readable.

Fixed conversion to checked Future.

Change-Id: If8da3639e656214713d3680951cd9ae724c5ad6f
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-1281: share filters between instances"
Tony Tkacik [Sun, 3 Aug 2014 18:14:29 +0000 (18:14 +0000)]
Merge "BUG-1281: share filters between instances"

9 years agoMerge "BUG-1281: use SchemaContext lookups"
Tony Tkacik [Sun, 3 Aug 2014 18:14:14 +0000 (18:14 +0000)]
Merge "BUG-1281: use SchemaContext lookups"

9 years agoMerge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"
Tony Tkacik [Sun, 3 Aug 2014 18:10:03 +0000 (18:10 +0000)]
Merge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"

9 years agoBUG-1281: share filters between instances
Robert Varga [Mon, 28 Jul 2014 19:53:51 +0000 (21:53 +0200)]
BUG-1281: share filters between instances

The filters are invariants, so lets share them accross instances and not
instantiate them each time we need them.

Change-Id: Ib632efe758c22bd782fca0536c2fe7e9c6e831c3
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1281: use SchemaContext lookups
Robert Varga [Mon, 28 Jul 2014 19:45:12 +0000 (21:45 +0200)]
BUG-1281: use SchemaContext lookups

SchemaContext provides efficient module lookup services. Use those
instead of homegrown versions.

Change-Id: I4406438b137c8742a5265036f84a66d7f0f441c0
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG 1082 Migrate sal-rest-connector to Async Data Broker API
Jozef Gloncak [Mon, 30 Jun 2014 13:58:56 +0000 (15:58 +0200)]
BUG 1082 Migrate sal-rest-connector to Async Data Broker API

Rework of sal-rest-connector project to support Async Data Broker API

Change-Id: I73804418a04445b236d12693e493a11850dd94dd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMoved all config subsystem config files to mvn projects.
Ed Warnicke [Thu, 31 Jul 2014 23:19:46 +0000 (18:19 -0500)]
Moved all config subsystem config files to mvn projects.

Change-Id: I98f4ab29fd57b800d5c9272e866ead3519e09264
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "ControllerContext.dataNodeChildByQName method refactoring"
Tony Tkacik [Fri, 1 Aug 2014 08:35:13 +0000 (08:35 +0000)]
Merge "ControllerContext.dataNodeChildByQName method refactoring"

9 years agoMerge "Notificator create stream name method don't remove trailing slash"
Tony Tkacik [Fri, 1 Aug 2014 08:33:53 +0000 (08:33 +0000)]
Merge "Notificator create stream name method don't remove trailing slash"

9 years agoMerge "BUG-868: Migrate to SchemaContextListener"
Tony Tkacik [Fri, 1 Aug 2014 08:00:43 +0000 (08:00 +0000)]
Merge "BUG-868: Migrate to SchemaContextListener"

9 years agoControllerContext.dataNodeChildByQName method refactoring
Jozef Gloncak [Fri, 25 Jul 2014 05:48:29 +0000 (07:48 +0200)]
ControllerContext.dataNodeChildByQName method refactoring

ControllerContext.dataNodeChildByQName() is used only in childByQName()
methods with DataNodeContainer input parameters:
- ContainerSchemaNode
- ListSchemaNode
- Module
Therefore child node of these DataNodeContainers can't be ChoiceCaseNode
(because it can be only child node of ChoiceNode)
and original branch >if (node instanceof ChoiceCaseNode)< couldn't be
executed.
I think that it was typo.

Change-Id: Ieb85ad8acaf047b47813542d8968c399a4e30b50
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "broken build - missing implementation of method getAnyXmlNodeSerializer"
Moiz Raja [Thu, 31 Jul 2014 14:19:12 +0000 (14:19 +0000)]
Merge "broken build - missing implementation of method getAnyXmlNodeSerializer"

9 years agoBUG-868: Migrate to SchemaContextListener
Robert Varga [Sun, 9 Mar 2014 18:34:51 +0000 (19:34 +0100)]
BUG-868: Migrate to SchemaContextListener

SchemaServiceListener is deprecated, SchemaContextListener is its new
name. The class hierarchy allows for incremental migration.

Change-Id: I15d495d805eb7a08c3bcd3ab0cf8b5a8d2797db5
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agobroken build - missing implementation of method getAnyXmlNodeSerializer
Jozef Gloncak [Thu, 31 Jul 2014 13:47:40 +0000 (15:47 +0200)]
broken build - missing implementation of method getAnyXmlNodeSerializer

Change-Id: Ib7f22015462cb224e11c3c267cfbac7627eeb800
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoNotificator create stream name method don't remove trailing slash
Jozef Gloncak [Wed, 23 Jul 2014 11:12:20 +0000 (13:12 +0200)]
Notificator create stream name method don't remove trailing slash

Change-Id: I512879ce1b39b80b29a167147ef73e2ecef64afa
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "Serialization/Deserialization and a host of other fixes"
Ed Warnicke [Wed, 30 Jul 2014 12:05:21 +0000 (12:05 +0000)]
Merge "Serialization/Deserialization and a host of other fixes"

9 years agoSerialization/Deserialization and a host of other fixes
Moiz Raja [Thu, 10 Jul 2014 10:39:22 +0000 (03:39 -0700)]
Serialization/Deserialization and a host of other fixes

- Hande Cluster MemberUp and MemberRemoved events in ShardManager

- Cohort messages and close listener messages switched
to use protobuff

- Distributed Datastore switch messages to use protobuff
CreateTransaction
CreateTransactionReply
CreateTransactionChain
CreateTransactionChainReply distributed datastore messages
switched to protobuff

- ShardManager messages switch to protobuff

- DataChanged and other messages switch to protobuf in
distributed datastore

- Fixed few things found during testing
1. ShardStrategy - setting of configuration
2. NodeToNormalizedNodeBuilder - leaf node/leafsetentry node checks
3. DataChanged event - passing of scope instanceidentifier used during deserialization

- Introducing JMX MBeans for distributed datastore

-Fixed issues which were preventing remote Shards from talking to each other

- Fixed a number of issues related to deserialization

- Add distributed datastore to the build

- Switch from InstanceIdentifier to YangInstanceIdentifier

Change-Id: I0d15dc482cb2b0fb2170b1344bad9fa3b421e8e0
Signed-off-by: Moiz Raja <moraja@cisco.com>
9 years agoBUG-1092: adjust to YangInstanceIdentifier
Robert Varga [Tue, 29 Jul 2014 10:15:49 +0000 (12:15 +0200)]
BUG-1092: adjust to YangInstanceIdentifier

This is a compation to I1e30a0df93d8bfb891d047c58abcb117d4006c76,
adjusting the components to use the new name.

Change-Id: I615763240581e850f7752f82e44d752c8fceb169
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge changes I1d768b2b,I9302e88a
Tony Tkacik [Tue, 29 Jul 2014 10:48:46 +0000 (10:48 +0000)]
Merge changes I1d768b2b,I9302e88a

* changes:
  Fix identity-ref serialization in netconf.
  BUG-1083 Netconf connector rework sal facade.

9 years agoMerge changes Ifd28301d,I38220acb,I9bad24df
Tony Tkacik [Tue, 29 Jul 2014 09:29:39 +0000 (09:29 +0000)]
Merge changes Ifd28301d,I38220acb,I9bad24df

* changes:
  WIP: Backwards compatible MountPointService
  Fix children element lookup in XmlElement
  Fix config attributes with same names for different modules.

9 years agoMerge changes I442a0ee9,I11825b90
Tony Tkacik [Tue, 29 Jul 2014 08:04:05 +0000 (08:04 +0000)]
Merge changes I442a0ee9,I11825b90

* changes:
  Fix a typo
  BUG-1281: call static methods

9 years agoFix identity-ref serialization in netconf.
Maros Marsalek [Mon, 28 Jul 2014 08:33:33 +0000 (10:33 +0200)]
Fix identity-ref serialization in netconf.

Identity-ref attributes did not contain their namespace.

Change-Id: I1d768b2b59073d9fa322b66b002eddf39270bf17
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoFix children element lookup in XmlElement
Maros Marsalek [Fri, 25 Jul 2014 11:13:47 +0000 (13:13 +0200)]
Fix children element lookup in XmlElement

Change-Id: I38220acbfedf8f1b8554516f6abda4c1a16dd2ee
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoFix a typo
Robert Varga [Mon, 28 Jul 2014 19:31:45 +0000 (21:31 +0200)]
Fix a typo

Just a test name fix.

Change-Id: I442a0ee951475fb247eca4117ad61ed315a39dfc
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1281: call static methods
Robert Varga [Mon, 28 Jul 2014 19:11:36 +0000 (21:11 +0200)]
BUG-1281: call static methods

This is just a cleanup of warnings.

Change-Id: I11825b90b415c77074ff8684feaba918876e0c95
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Wiring rest-connector with config subsytem."
Tony Tkacik [Mon, 28 Jul 2014 15:05:01 +0000 (15:05 +0000)]
Merge "Wiring rest-connector with config subsytem."

9 years agoMerge "Improve RESTCONF QName parsing speed"
Tony Tkacik [Mon, 28 Jul 2014 15:02:06 +0000 (15:02 +0000)]
Merge "Improve RESTCONF QName parsing speed"

9 years agoWiring rest-connector with config subsytem.
Ed Warnicke [Thu, 24 Jul 2014 19:12:18 +0000 (14:12 -0500)]
Wiring rest-connector with config subsytem.

Change-Id: If826bb7352101833acd288b81cbcf7cec2f28b43
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoImprove RESTCONF QName parsing speed
Robert Varga [Sat, 26 Jul 2014 04:32:53 +0000 (06:32 +0200)]
Improve RESTCONF QName parsing speed

SchemaContext provides useful (and optimized) methods for looking up
modules. Eliminate home-grown version of findModuleByName(). Requires
https://git.opendaylight.org/gerrit/#/c/9351/ .

Change-Id: I4c4e07e23a614b46b01a87485965af0c066aa693
Signed-off-by: Robert Varga <rovarga@cisco.com>