Thanh Ha [Tue, 19 Jun 2018 13:39:44 +0000 (09:39 -0400)]
Merge remote-tracking branch 'genius/master'
Change-Id: If0d0fc38f472b584a82d3e47220275c041e39773
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 19 Jun 2018 13:39:11 +0000 (09:39 -0400)]
Move to srm
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 19 Jun 2018 13:37:04 +0000 (09:37 -0400)]
Move to tools
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Stephen Kitt [Thu, 7 Jun 2018 11:38:05 +0000 (13:38 +0200)]
Remove Genius version properties
This avoids the temptation of using them for parents.
Change-Id: I1753fa760a46fd14da5c907a7aa0bfbb2f08d19a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 31 May 2018 13:59:16 +0000 (15:59 +0200)]
Fixup Augmentable and Identifiable methods changing
This is a fixup of the change in binding codegen, adjusting:
- getKey() -> key()
- setKey() -> withKey()
- getAugmentation() -> augmentation()
Change-Id: I8e384b6d0f6c6bd81e96d71d3cbb81c89e4954a1
JIRA: TSC-101
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Michael Vorburger [Thu, 24 May 2018 12:26:52 +0000 (14:26 +0200)]
remove <version>${genius.version} from GAV
because this is inherited from <parent> and avoid this:
[WARNING] Some problems were encountered while building the effective model for org.opendaylight.genius:interfacemanager-shell:bundle:0.4.2-SNAPSHOT
[WARNING] 'version' contains an expression but should be a constant. @ org.opendaylight.genius:interfacemanager-shell:${genius.version}, /w/workspace/integration-multipatch-test-fluorine/patch_tester/genius/interfacemanager/interfacemanager-shell/pom.xml, line 22, column 14
Change-Id: Ibb8b91b06ef63fb8292e02503b4c711069650e1b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 30 Apr 2018 07:27:41 +0000 (12:57 +0530)]
TSC-99 Adjust to RPC method signature update
Change-Id: I1307120c6400e225a3e5e3e2344648ea5c7c5396
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Mon, 30 Apr 2018 07:27:41 +0000 (12:57 +0530)]
TSC-99 Adjust to RPC method signature update
Change-Id: I1307120c6400e225a3e5e3e2344648ea5c7c5396
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Thu, 12 Apr 2018 17:05:39 +0000 (19:05 +0200)]
remove un-used pax-cdi-api from tools-api
Change-Id: I72799ecfbf8cfca2e394abf4030df1f6fdbeec10
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 19 Apr 2018 12:59:20 +0000 (14:59 +0200)]
replace findbugs' @SuppressWarnings by @SuppressFBWarnings
Change-Id: Iebe8b04c1409a769e91ea545abcbc97e987b7794
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Sat, 21 Apr 2018 08:17:44 +0000 (10:17 +0200)]
Make new Genius' listeners testable
Make new Genius' listeners testable old ones by implementing the
ChainableDataTreeChangeListener interface.
Change-Id: Ia321ad95956eba717afb3de56c4ef4afb14e771a
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
David Suarez [Thu, 19 Apr 2018 19:17:02 +0000 (21:17 +0200)]
Move ChainableDataTreeListener to tools-api
Change-Id: I9401d9a623a0ac141d0f6d03bbf9ce2810da1462
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Michael Vorburger [Fri, 6 Apr 2018 19:28:51 +0000 (21:28 +0200)]
increase code quality in tools api/testutils by using infrautils' parent
Change-Id: I7485ce352b452cec2db19c5e726c9bb51438846c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
K.V Suneelu Verma [Wed, 11 Apr 2018 12:07:49 +0000 (17:37 +0530)]
add l2gw and dhcp for service recovery
Change-Id: Ia01f6c99016573802efce726396856dda2326138
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Stephen Kitt [Thu, 22 Mar 2018 17:24:32 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3
Change-Id: If99df255661c177c6424ee7eb7f77fdb00522d63
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 22 Mar 2018 17:24:32 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3
Change-Id: If99df255661c177c6424ee7eb7f77fdb00522d63
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Thu, 12 Apr 2018 17:00:16 +0000 (19:00 +0200)]
remove un-used org.osgi.core from tools-api
Change-Id: I34b353fedafe908baacd536c58a26670e2f09a4f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 12 Apr 2018 15:23:30 +0000 (20:53 +0530)]
wrong feature dependencies in newly added features.
Change-Id: Ie592de3ee8f6ba01c86e7d411dad8d5c411cf59c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Thu, 12 Apr 2018 15:23:30 +0000 (20:53 +0530)]
wrong feature dependencies in newly added features.
Change-Id: Ie592de3ee8f6ba01c86e7d411dad8d5c411cf59c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Fri, 6 Apr 2018 17:22:11 +0000 (19:22 +0200)]
make DataStoreMetrics package local instead of a publicly supported API
and, exceptionally, keep it copy/pasted into the old (mdsalutil) and new
place (genius.tools); this IMHO is, exceptionally, better than keeping
something public - hopefully the duplicate in the old package will be
removed soon-ish, anyway.
Change-Id: I997dbb6eeb702f010eaee1becea1a43b57d950b3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 6 Apr 2018 17:43:36 +0000 (19:43 +0200)]
remove test-jar from new tools-api artifact
This is not needed here, and before anyone creates a dependency to the
new (empty) attached test artifact by mistake, should be removed to
avoid any confusion.
A test-jar is only required if we need to publish src/test on Nexus.
This project does not even have a src/test; and even if it did, we would
only ever have tests for tools-api in it, not test utilities which other
projects would use - because we have the tools-testutils for that,
instead.
Change-Id: Ie1a3152386fee538eb812d52985a3ac17db8520b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Fri, 6 Apr 2018 22:55:46 +0000 (00:55 +0200)]
Migrate listener's methods
Migrate add, update and remove methods to use the new ones.
Change-Id: Ia53baaa5a2333168f2bd6983fda616fefb885b7d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Wed, 21 Mar 2018 12:43:48 +0000 (18:13 +0530)]
Moving datastore related utils from mdsalutil to new "genius.tools"
There are several requirements coming in where users are asking for a
simple feature with only datastore related utils. Currently all the utils
are parked in mdsalutil which has even openflowplugin related utils, and is embedded
in a heavier genius feature. This patch aims to move of these heavily used utils
to a new module, and add new features to expose the same.
Change-Id: I7d59273851c51b02fe43afcb1525c94ced1c5088
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 21 Mar 2018 12:43:48 +0000 (18:13 +0530)]
Moving datastore related utils from mdsalutil to new "genius.tools"
There are several requirements coming in where users are asking for a
simple feature with only datastore related utils. Currently all the utils
are parked in mdsalutil which has even openflowplugin related utils, and is embedded
in a heavier genius feature. This patch aims to move of these heavily used utils
to a new module, and add new features to expose the same.
Change-Id: I7d59273851c51b02fe43afcb1525c94ced1c5088
Signed-off-by: Faseela K <faseela.k@ericsson.com>
eswanit [Fri, 16 Mar 2018 09:05:10 +0000 (14:35 +0530)]
Service-Recovery: support for elan-interface entity type
instead of elan-instance entity type
Change-Id: I723bd2ac707bf8b34d869b9b7abfdea4b616c47a
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Stephen Kitt [Mon, 12 Mar 2018 16:39:57 +0000 (17:39 +0100)]
Clean up lambdas
Use method references and lambda expressions where appropriate.
Change-Id: Id329f3a6abc9d23678e6b5e4ce554778fc590c00
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Wed, 14 Mar 2018 16:42:35 +0000 (22:12 +0530)]
Make recoverableListenerMap maintain a queue of recoverableListeners.
This was a review comment from Michael which was not addressed on the
original patch
Change-Id: I14b7d9f4a92a4439cae40b4c4b23b7972f5468b4
Signed-off-by: Faseela K <faseela.k@ericsson.com>
sathwik boggarapu [Wed, 14 Mar 2018 12:41:04 +0000 (18:11 +0530)]
Fix logging issues in SRM
Change-Id: I89a5ff35903202d549a91a510f323856d78b1542
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>
Shashidhar Raja [Fri, 2 Mar 2018 06:28:17 +0000 (11:58 +0530)]
Service-Recovery: Support needed for ACL feature introduced in SRM
framework.
(a) srm-types.yang updated with 'netvirt-acl', 'netvirt-acl-interface' and
'netvirt-acl-instance' definitions to support ACL service and instance
recovery operations. 'netvirt-acl-interface' and
'netvirt-acl-instance' are the two instance recovery options supported.
(b) SrmRpcUtils.java and SrmCliUtils.java updated to add required ACL definitions
to the internal maps maintained to support recovery operations.
Change-Id: I4c91cd52e7595b92b494356dfa715dbdf15da3c5
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Naveen Kumar Verma [Wed, 28 Feb 2018 09:15:39 +0000 (14:45 +0530)]
Genius Specific Changes to support QoS with SRM
Adding QOS option as recoverable service & Qos policy as recoverable
instance.
Change-Id: I0e123bec31f663d8b6673b37c5858fbcc85b8b46
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>
Tom Pantelis [Fri, 23 Feb 2018 03:08:16 +0000 (22:08 -0500)]
Enable findbugs in commons binding-parent
Change-Id: I6b5f9341e564487e4f29a817e3e1471afa461730
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Faseela K [Fri, 23 Feb 2018 12:27:19 +0000 (17:57 +0530)]
SRM refactoring
Realized that some code that went in interface-manager for service
recovery can be reused across modules, and hence moving some of those
common utilities to srm.
Change-Id: I65dbb9b27bddbe11f7ca4a30a3a27838eef8cefc
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Tom Pantelis [Thu, 22 Feb 2018 23:00:47 +0000 (18:00 -0500)]
Fix findbugs violations in srm-shell
- Format string should use %n rather than \n
- Consider using Locale parameterized version of invoked method
Change-Id: Id3be0c9b70c104ec0a2214e28b347add451c873a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Belur [Mon, 26 Feb 2018 07:41:42 +0000 (17:41 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I87a5d8d5d22dc66190d3af950bd6f802004fc3cf
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Stephen Kitt [Thu, 14 Dec 2017 16:30:19 +0000 (17:30 +0100)]
Adjust for odlparent 3 / yangtools 2
Change-Id: I737d07fa781c7bdbc1fe069a6684f87cb459bafa
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 14 Dec 2017 16:08:50 +0000 (17:08 +0100)]
Adjust to odlparent 3 Checkstyle settings
Change-Id: I2a63188743ccddc74b4d87615efbb9fdf9cd9554
Signed-off-by: Stephen Kitt <skitt@redhat.com>
David Suarez [Fri, 10 Nov 2017 18:53:24 +0000 (19:53 +0100)]
Enforce findbugs
Change-Id: I38f169cb53790414488b5f67123b581c6397f07b
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Stephen Kitt [Wed, 8 Nov 2017 14:58:13 +0000 (15:58 +0100)]
Drop Karaf shell specifiers
We no longer need to support Karaf 3, and the karaf.shell
"[3.0.0,4.1)" declarations prevent us from upgrading to Karaf 4.1
(which is coming with odlparent 3).
Change-Id: If39706d860e67dabd33ce4fc84d046075eac9a33
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Thu, 27 Jul 2017 21:41:05 +0000 (03:11 +0530)]
SRM: Add implementation code
This adds the following:
1. RPC Implementation in impl and required util class
2. CLI for SRM as mentioned in spec.
3. Debug CLI to clear out SRM operDS.
These cover Work Items 3 and 4 of SRM Spec.
Change-Id: I04553678580ff53217c7757594cdd836aa8abfae
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Stephen Kitt [Wed, 27 Sep 2017 13:36:15 +0000 (15:36 +0200)]
Bump odlparent 2.0.4 to 2.0.5
Change-Id: Ib8a87ed7dc7550082fde3abab9891b2ee105eb1f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Wed, 20 Sep 2017 16:46:49 +0000 (22:16 +0530)]
Cleanup config-parent usage
Change-Id: Ic51def71c73210ed21969238538449b90e45b005
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Thu, 27 Jul 2017 21:41:05 +0000 (03:11 +0530)]
Initial bundle setup for SRM
This adds following:
1. Initial api, impl and shell bundles for ServiceRecoveryManager (SRM)
2. Adds them to genius features
3. Skeletal code for CLI and RPCs
Change-Id: Idcc7266ba0ba8680a23f50261ab4b9aae19f2ed7
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>