aaa.git
8 years agoFix javadoc formatting for SHA256Calculator 10/31910/1
Ryan Goulding [Mon, 28 Dec 2015 13:46:40 +0000 (08:46 -0500)]
Fix javadoc formatting for SHA256Calculator

Change-Id: Ie55998a88943b8d14184d6e0424a644ce9851858
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoAdds documentation to IdmLightConfig 02/31702/1
Ryan Goulding [Mon, 21 Dec 2015 14:13:31 +0000 (09:13 -0500)]
Adds documentation to IdmLightConfig

This is a formatting change to add documentation to IdmLightConfig.
This change extracts constants from magic strings.

Change-Id: I9f6c5efe8b073a11f6eb79b543856463374fcbb5
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to aaa-authz bundles 64/31664/2
Ryan Goulding [Mon, 21 Dec 2015 02:02:30 +0000 (21:02 -0500)]
Formatting applied to aaa-authz bundles

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: I918e68574cbcb3ebacdcd3556339219a5a21f7e4
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to features"
Ryan Goulding [Mon, 21 Dec 2015 01:41:23 +0000 (01:41 +0000)]
Merge "Formatting applied to features"

8 years agoMerge "Formatting applied to aaa's distribution-karaf bundle"
Ryan Goulding [Mon, 21 Dec 2015 01:33:51 +0000 (01:33 +0000)]
Merge "Formatting applied to aaa's distribution-karaf bundle"

8 years agoMerge "Formatting applied to aaa-shiro-act bundle"
Ryan Goulding [Mon, 21 Dec 2015 01:33:44 +0000 (01:33 +0000)]
Merge "Formatting applied to aaa-shiro-act bundle"

8 years agoMerge "Formatting applied to aaa-shiro bundle"
Ryan Goulding [Mon, 21 Dec 2015 01:27:47 +0000 (01:27 +0000)]
Merge "Formatting applied to aaa-shiro bundle"

8 years agoFormatting applied to features 63/31663/1
Ryan Goulding [Mon, 21 Dec 2015 01:26:51 +0000 (20:26 -0500)]
Formatting applied to features

Removed any tabs and innapropriate whitespace from feature
poms and features.xml files.

Change-Id: I50ad151f706115ccc5b2de28f9ca8b863b224a91
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to aaa's distribution-karaf bundle 62/31662/1
Ryan Goulding [Mon, 21 Dec 2015 01:19:03 +0000 (20:19 -0500)]
Formatting applied to aaa's distribution-karaf bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: I85d3fcd292f964fd5c02e455747e93a79660db88
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to aaa-shiro-act bundle 61/31661/1
Ryan Goulding [Mon, 21 Dec 2015 01:16:17 +0000 (20:16 -0500)]
Formatting applied to aaa-shiro-act bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: I81a9e2c09518108f2166de01ba5e974ac4e0170d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-authn-sts bundle"
Ryan Goulding [Mon, 21 Dec 2015 01:14:50 +0000 (01:14 +0000)]
Merge "Formatting applied to aaa-authn-sts bundle"

8 years agoMerge "Formatting applied to aaa-authn-sssd bundle"
Ryan Goulding [Mon, 21 Dec 2015 01:14:41 +0000 (01:14 +0000)]
Merge "Formatting applied to aaa-authn-sssd bundle"

8 years agoFormatting applied to aaa-shiro bundle 60/31660/1
Ryan Goulding [Mon, 21 Dec 2015 01:13:35 +0000 (20:13 -0500)]
Formatting applied to aaa-shiro bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: Ic9f6f70ce229c83e79bc7683e8591773396c5b6e
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-authn-store bundle"
Ryan Goulding [Mon, 21 Dec 2015 01:00:01 +0000 (01:00 +0000)]
Merge "Formatting applied to aaa-authn-store bundle"

8 years agoFormatting applied to aaa-authn-sssd bundle 56/31656/2
Ryan Goulding [Mon, 21 Dec 2015 00:33:20 +0000 (19:33 -0500)]
Formatting applied to aaa-authn-sssd bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: I638b8384e1b88508799dfaf27b62351c1915d904
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-authn-mdsal bundles"
Ryan Goulding [Mon, 21 Dec 2015 00:52:05 +0000 (00:52 +0000)]
Merge "Formatting applied to aaa-authn-mdsal bundles"

8 years agoFormatting applied to aaa-authn-sts bundle 58/31658/1
Ryan Goulding [Mon, 21 Dec 2015 00:50:43 +0000 (19:50 -0500)]
Formatting applied to aaa-authn-sts bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: Iad4cdcff1c356a4dc4199531e8d716521be62d21
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-authn-federation bundle"
Ryan Goulding [Mon, 21 Dec 2015 00:42:40 +0000 (00:42 +0000)]
Merge "Formatting applied to aaa-authn-federation bundle"

8 years agoFormatting applied to aaa-authn-store bundle 57/31657/1
Ryan Goulding [Mon, 21 Dec 2015 00:41:07 +0000 (19:41 -0500)]
Formatting applied to aaa-authn-store bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: I4aa68123fe0d014ab6d51845cc87cc038567effc
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-authn-keystone bundle"
Ryan Goulding [Mon, 21 Dec 2015 00:26:40 +0000 (00:26 +0000)]
Merge "Formatting applied to aaa-authn-keystone bundle"

8 years agoFormatting applied to aaa-authn-federation bundle 52/31652/3
Ryan Goulding [Sun, 20 Dec 2015 23:50:01 +0000 (18:50 -0500)]
Formatting applied to aaa-authn-federation bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: Id378fc5f086972a417886d1652e31a2170997f16
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to aaa-authn-mdsal bundles 55/31655/1
Ryan Goulding [Mon, 21 Dec 2015 00:22:48 +0000 (19:22 -0500)]
Formatting applied to aaa-authn-mdsal bundles

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: I0e2717e15c4ca27ce6c4161caf491958e8ab2777
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-authn-idpmapping"
Ryan Goulding [Mon, 21 Dec 2015 00:22:06 +0000 (00:22 +0000)]
Merge "Formatting applied to aaa-authn-idpmapping"

8 years agoFormatting applied to aaa-authn-keystone bundle 54/31654/1
Ryan Goulding [Mon, 21 Dec 2015 00:08:56 +0000 (19:08 -0500)]
Formatting applied to aaa-authn-keystone bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: I1e57066564f74b81b8fb84cf33dbfe96df833368
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-authn-basic"
Ryan Goulding [Mon, 21 Dec 2015 00:04:19 +0000 (00:04 +0000)]
Merge "Formatting applied to aaa-authn-basic"

8 years agoFormatting applied to aaa-authn-idpmapping 53/31653/1
Ryan Goulding [Mon, 21 Dec 2015 00:03:43 +0000 (19:03 -0500)]
Formatting applied to aaa-authn-idpmapping

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: I5551eec1ceed56281447453d8ed619b033deb541
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-authn bundle"
Ryan Goulding [Sun, 20 Dec 2015 23:59:53 +0000 (23:59 +0000)]
Merge "Formatting applied to aaa-authn bundle"

8 years agoFormatting applied to aaa-authn-basic 51/31651/1
Ryan Goulding [Sun, 20 Dec 2015 23:44:04 +0000 (18:44 -0500)]
Formatting applied to aaa-authn-basic

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: Icba7172edc67a0e8697e7d12aabcc0928573095d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to aaa-authn bundle 50/31650/1
Ryan Goulding [Sun, 20 Dec 2015 23:40:35 +0000 (18:40 -0500)]
Formatting applied to aaa-authn bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, reorganizing imports, and converting
all line endings to Unix-style.

Change-Id: If0e2ccad0eee789ecb6f81fb3a237e2f95886486
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to aaa-authn-api bundle 49/31649/1
Ryan Goulding [Sun, 20 Dec 2015 23:31:11 +0000 (18:31 -0500)]
Formatting applied to aaa-authn-api bundle

Fixes flagrant checkstyle violations.  This is done using
eclipse formatting, adding Logger where printStackTrace()
existed, and reorganizing any imports that were in the
wrong order.

Change-Id: Ia9f521d2e8715666b90347201a0c5abd9d4d275e
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Bug 4804 IDMLight REST endpoints do not redact the salt user field"
Sharon Aicler [Sun, 20 Dec 2015 19:20:12 +0000 (19:20 +0000)]
Merge "Bug 4804 IDMLight REST endpoints do not redact the salt user field"

8 years agoFormatting applied to aaa-h2-store package 12/31612/1
Ryan Goulding [Fri, 18 Dec 2015 17:22:35 +0000 (12:22 -0500)]
Formatting applied to aaa-h2-store package

Fixes checkstyle violations.  Deprecates and logger wrapper methods,
in favor of directly invoking LOG methods.

Change-Id: I4799b8be41ae7615fb15878a3302f7d13bda6a17
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 4804 IDMLight REST endpoints do not redact the salt user field 31/31531/4
Ryan Goulding [Thu, 17 Dec 2015 17:56:15 +0000 (12:56 -0500)]
Bug 4804 IDMLight REST endpoints do not redact the salt user field

Enforces redacted fields salt fields for IDMLight rest endpoints, since
exposing such information is a plausible security concern.   Abstracts several
helper methods to avoid code duplication.  Cleans up error reporting so error
messages are consistent among operations on the /auth/v1/users REST
endpoint.  Reformats several areas of code that do not align to AAA
checkstyle.  Adds much needed documentation on how to utilize the REST
endpoint.

Change-Id: I65319a34d1c0f0363fc2c73a6e872cdb296f9604
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to aaa-idmlight tests"
Ryan Goulding [Fri, 18 Dec 2015 01:45:54 +0000 (01:45 +0000)]
Merge "Formatting applied to aaa-idmlight tests"

8 years agoFormatting applied to aaa-idmlight tests 63/31563/1
Ryan Goulding [Fri, 18 Dec 2015 01:29:03 +0000 (20:29 -0500)]
Formatting applied to aaa-idmlight tests

Fixes formatting in test scripts.  Fixes PasswordHashTest
to throw Exception in setup instead of try/catch so the
test actually fails.

Change-Id: Icdc496b5ff560a3c6ff9d3afd292ff02a2c23993
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to AAAIDMLightModule 62/31562/1
Ryan Goulding [Fri, 18 Dec 2015 01:17:55 +0000 (20:17 -0500)]
Formatting applied to AAAIDMLightModule

Fixed checkstyle errors in AAAIDMLightModule.

Change-Id: Ie104eb3cf510880f37b34fe8e3196fd8ef11f30a
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to StoreBuilder"
Ryan Goulding [Fri, 18 Dec 2015 01:13:34 +0000 (01:13 +0000)]
Merge "Formatting applied to StoreBuilder"

8 years agoFormatting applied to StoreBuilder 59/31559/2
Ryan Goulding [Fri, 18 Dec 2015 00:03:44 +0000 (19:03 -0500)]
Formatting applied to StoreBuilder

This change tackles some vital formatting issues with StoreBuilder.  The
following is done to the IdmLightApplication class to promote clarity and conformance
to project style:

1) Add some detailed information to the class comment concerning the default installed
accounts.

2) Add TODO concerning what to do if "sdn" is deleted.  Implies that "sdn" could
be made a mandatory domain.

3) Format in eclipse by clicking "format".

4) Fix any errors reported by "mvn checkstyle:checkstyle".

No actual code or functionality changes were made.  This is strictly a
formatting related patch.

Change-Id: I09f45e529201d3eeaca94286f86e3dc06bf727c8
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to IdmLightApplication"
Ryan Goulding [Fri, 18 Dec 2015 00:37:57 +0000 (00:37 +0000)]
Merge "Formatting applied to IdmLightApplication"

8 years agoMerge "Bug 4809 Deprecate the versionhandler for AAA"
Ryan Goulding [Fri, 18 Dec 2015 00:13:38 +0000 (00:13 +0000)]
Merge "Bug 4809 Deprecate the versionhandler for AAA"

8 years agoFormatting applied to IdmLightApplication 57/31557/2
Ryan Goulding [Thu, 17 Dec 2015 23:35:56 +0000 (18:35 -0500)]
Formatting applied to IdmLightApplication

This change tackles some vital formatting issues with IdmLightApplication.  The
following is done to the IdmLightApplication class to promote clarity and conformance
to project style:

1) Move the class documentation comment to the right location.  Add some
detailed information to the class comment concerning different handlers.

2) Add CONSTANT documentation.

3) Format in eclipse by clicking "format".

4) Fix any errors reported by "mvn checkstyle:checkstyle".

5) Add a TODO to address the mismatch in MAX_FIELD_LENGTH between this
class and the Store classes, which assume 128 not 256.

No actual code or functionality changes were made.  This is strictly a
formatting related patch.

Change-Id: Id4fee54715f392830a97207f24fc9f7ca6880b60
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Formatting applied to IdmLightProxy"
Ryan Goulding [Fri, 18 Dec 2015 00:10:16 +0000 (00:10 +0000)]
Merge "Formatting applied to IdmLightProxy"

8 years agoFormatting applied to IdmLightProxy 58/31558/2
Ryan Goulding [Thu, 17 Dec 2015 23:51:27 +0000 (18:51 -0500)]
Formatting applied to IdmLightProxy

This change tackles some vital formatting issues with IdmLightProxy.  The
following is done to the IdmLightProxy class to promote clarity and conformance
to project style:

1) Add instance member documentation.

2) Add static initialization documentation

3) Add info logging to the "clearClaimCache()" method.

4) Format in eclipse by clicking "format".

5) Fix any errors reported by "mvn checkstyle:checkstyle".

6) Eliminate the "debug" logging method in favor of direct invocation.

No actual code or functionality changes were made.  This is strictly a
formatting related patch.

Change-Id: Iebd14af02f0a5ffa13c96839e24b29efec76c708
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 4809 Deprecate the versionhandler for AAA 56/31556/1
Ryan Goulding [Thu, 17 Dec 2015 23:19:50 +0000 (18:19 -0500)]
Bug 4809 Deprecate the versionhandler for AAA

AAA currently has a rest endpoint to display version information.  This REST
endpoint is:
1) out of date
2) largely unused to our knowledge
3) should be deprecated

This patch does the following:
1) Formats by clicking "format" in eclipse.
2) Fix any checkstyle violations.
3) Puts the class javadoc comment in the correct place
4) Adds an @Deprecated tag so the interface can be safely removed in Boron

Change-Id: I2195af6980dc08c4e445daa3cb29078a11821ad6
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to RoleHandler 53/31553/1
Ryan Goulding [Thu, 17 Dec 2015 23:12:10 +0000 (18:12 -0500)]
Formatting applied to RoleHandler

This change tackles some vital formatting issues with RoleHandler.  The
following is done to the RoleHandler class to promote clarity and conformance
to project style:

1) Move the class documentation comment to the right location.  Add some
detailed information to the class comment concerning how to use the REST
endpoints for RoleHandler.

2) Add function documentation comments explaining their responsibilities.

3) Format in eclipse by clicking "format".

4) Fix any errors reported by "mvn checkstyle:checkstyle".

No actual code or functionality changes were made.  This is strictly a
formatting related patch.

Change-Id: I7a8a9343792d5384b1639010918d2ed8ecdaaa6a
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoFormatting applied to DomainHandler 49/31549/3
Ryan Goulding [Thu, 17 Dec 2015 19:36:26 +0000 (14:36 -0500)]
Formatting applied to DomainHandler

This change tackles some vital formatting issues with DomainHandler.  The
following is done to the DomainHandler class to promote clarity and conformance
to project style:

1) Move the class documentation comment to the right location.  Add some
detailed information to the class comment concerning how to use the REST
endpoints for DomainHandler.

2) Add function documentation comments explaining their responsibilities.

3) Format in eclipse by clicking "format".

4) Fix any errors reported by "mvn checkstyle:checkstyle".

No actual code or functionality changes were made.  This is strictly a
formatting related patch.

Change-Id: Ie2d0ecff913afbceb280950e1a8d40a43a3958a0
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Bug 4766 AAA does not provide AuthN only LDAP capability"
Sharon Aicler [Wed, 16 Dec 2015 23:31:25 +0000 (23:31 +0000)]
Merge "Bug 4766 AAA does not provide AuthN only LDAP capability"

8 years agoMerge "Pull in dependencies from odlparent"
Ryan Goulding [Tue, 15 Dec 2015 15:24:52 +0000 (15:24 +0000)]
Merge "Pull in dependencies from odlparent"

8 years agoBug 4783 SQLException masked my IDMStoreException, making debugging impossible 55/31355/1
Ryan Goulding [Tue, 15 Dec 2015 15:06:02 +0000 (10:06 -0500)]
Bug 4783 SQLException masked my IDMStoreException, making debugging impossible

Adds logging to help actually debug StoreException(s), which are usually
caused by SQLException(s).  Propagates the entire throwable to IDMStoreException
instead of just the message, which is more useful for debugging.

Change-Id: I91fcb5513ea7d0dce055b4b02b6c2af4a07994f0
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 4768 AAA STS ServiceWireTask prone to IllegalStateException: BundleContext is... 99/31299/9
Ryan Goulding [Mon, 14 Dec 2015 20:34:28 +0000 (15:34 -0500)]
Bug 4768 AAA STS ServiceWireTask prone to IllegalStateException: BundleContext is no longer valid

ServiceWireTask is deprecated since it is prone to stale BundleContext.  The
functionality is replaced with an OSGi ServiceTracker and
ServiceTrackerCustomizer pair, which handles AAA activation and service loading
asynchronously.  This patch was inspired by this great work:
https://git.opendaylight.org/gerrit/#/c/31070/

Change-Id: Ief09dbd1a8c27805eb29a222dc062899fccffaa5
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 4773 Package uses conflict between authn and restconf 92/31292/1
Ryan Goulding [Mon, 14 Dec 2015 17:36:53 +0000 (12:36 -0500)]
Bug 4773 Package uses conflict between authn and restconf

Adds necessary annotation libraries from jsr305.

Change-Id: I4c7ead22e6aa100c2430061c35e449edaace6110
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 4766 AAA does not provide AuthN only LDAP capability 33/31233/2
Ryan Goulding [Sat, 12 Dec 2015 17:11:55 +0000 (12:11 -0500)]
Bug 4766 AAA does not provide AuthN only LDAP capability

Provides a wrapper to JndiLdapRealm (Shiro) for AuthN only LDAP integration.
From a security perspective, certain operators may not want to expose LDAP
grouping information to the controller.

Also, this change adds some more necessary documentation to shiro.ini
concerning configuration of Shiro-based AAA.  The documentation provides
examples of how to set up the different LDAP implementations.

Change-Id: Icb295ec40a4ab164111c39f5d6570549bf634fae
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoPull in dependencies from odlparent 03/31203/1
Stephen Kitt [Fri, 11 Dec 2015 16:32:23 +0000 (17:32 +0100)]
Pull in dependencies from odlparent

Drop Jersey dependencies from dependency management (this needs
jersey-test-framework-grizzly2 to be added to odlparent).

Switch from javax.servlet:servlet-api:2.5 to
javax.servlet.javax.servlet-api:3.0.1 (which is also OSGi compliant).

Change-Id: Ib1eca3d2fa2feac0cedafc8962f6c1f541855f10
Signed-off-by: Stephen Kitt <skitt@redhat.com>
8 years agoBug 4749 odl-aaa-shiro feature doesn't import some runtime dependencies 98/31098/4
Ryan Goulding [Wed, 9 Dec 2015 22:21:02 +0000 (17:21 -0500)]
Bug 4749 odl-aaa-shiro feature doesn't import some runtime dependencies

Imports the correct runtime dependencies so that ODL's Shiro wrapper
and Filtering works.  Also updates to use ${project.version} in the
appropriate places.

Change-Id: I2c9eb0fb111909b652a5d551dea238fbfe4d0f44
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoModify AAAIDMLightModule to use a ServiceTracker 70/31070/2
Tom Pantelis [Wed, 9 Dec 2015 08:28:02 +0000 (03:28 -0500)]
Modify AAAIDMLightModule to use a ServiceTracker

This replaces the thread that was spawned to busy wait for the IdmStore
service.

Change-Id: Ib90a92716725a7e9c94945f067f5029d0f06526d
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
8 years agoFix Bug 4723 StoreBuilder init times out 97/30997/5
Sharon Aicler [Tue, 8 Dec 2015 17:19:06 +0000 (09:19 -0800)]
Fix Bug 4723 StoreBuilder init times out

Removes StoreBuilder initialization call from IdmLightApplication constructor
to avoid blocking the main OSGi thread.  A separate thread called
StoreServiceLocator, which is spawned during IDMLightModule creation,
is used to track status of IIDMStore, the "pluggable" backing data store for
AAA identity management.  When the store is resolved, the thread invokes
StoreBuilder initialization code to handle initial creation of identity data.

Change-Id: I7cb91f2ed71712932e33188e3b4f6d2b9b0f1aa3
Signed-off-by: Sharon Aicler <saichler@cisco.com>
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoRevert Bug 4723 AAA StoreBuilder init times out too early 60/31060/1
Ryan Goulding [Wed, 9 Dec 2015 11:12:58 +0000 (06:12 -0500)]
Revert Bug 4723 AAA StoreBuilder init times out too early

This reverts commit 0f25e8c273c6297e4e88f8e2f335e08d0194c029.

Change-Id: I3d435e45290c3f6ac0c9163ada9130c6210687b0
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Bug 4741 AAA ServiceWireTask causes long running singleFeatureTest"
Sharon Aicler [Tue, 8 Dec 2015 19:28:05 +0000 (19:28 +0000)]
Merge "Bug 4741 AAA ServiceWireTask causes long running singleFeatureTest"

8 years agoBug 4741 AAA ServiceWireTask causes long running singleFeatureTest 92/30992/2
Ryan Goulding [Tue, 8 Dec 2015 16:33:06 +0000 (11:33 -0500)]
Bug 4741 AAA ServiceWireTask causes long running singleFeatureTest

Sets StoreServiceLocator thread to be a daemon thread.

Change-Id: I90b82e481bcc9f63991baa967fc62f7505d48fd9
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 4741 AAA ServiceWireTask causes long running singleFeatureTest 89/30989/1
Ryan Goulding [Tue, 8 Dec 2015 16:08:48 +0000 (11:08 -0500)]
Bug 4741 AAA ServiceWireTask causes long running singleFeatureTest

Makes ServiceWireTask thread daemon so it won't block.

Change-Id: I7082424acc7a574b40852feb7e856818813ee4f9
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 4732 Convert IDM Light to use config subsystem 38/30738/5
Sharon Aicler [Fri, 4 Dec 2015 21:32:32 +0000 (13:32 -0800)]
Bug 4732 Convert IDM Light to use config subsystem

Change-Id: I3800b15c4371c5acb7c9ae9b2af0c85412224d72
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agochange log message from 30s to 10m 28/30728/1
Jamo Luhrsen [Fri, 4 Dec 2015 17:13:24 +0000 (09:13 -0800)]
change log message from 30s to 10m

Change-Id: I848e0958a1e1b9548f74352fe0f1b929f53bd57f
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
8 years agoMerge "Bug 4723 AAA StoreBuilder init times out too early"
Ryan Goulding [Fri, 4 Dec 2015 15:45:36 +0000 (15:45 +0000)]
Merge "Bug 4723 AAA StoreBuilder init times out too early"

8 years agoBug 4723 AAA StoreBuilder init times out too early 20/30720/2
Ryan Goulding [Fri, 4 Dec 2015 15:19:50 +0000 (10:19 -0500)]
Bug 4723 AAA StoreBuilder init times out too early

AAA StoreBuilder will timeout if the backing data store isn't
loaded in 30s.  This is too short for some features.

Change-Id: I5c0c866b820bcf49e9592d620df69eefbb8dc2db
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Add Deprecated Tag to TokenAuthFilter"
Ryan Goulding [Fri, 4 Dec 2015 01:22:08 +0000 (01:22 +0000)]
Merge "Add Deprecated Tag to TokenAuthFilter"

8 years agoAdd Deprecated Tag to TokenAuthFilter 77/30677/1
Ryan Goulding [Fri, 4 Dec 2015 01:02:54 +0000 (20:02 -0500)]
Add Deprecated Tag to TokenAuthFilter

Change-Id: Ic70c61fd5b01563ba4bc1ca4d1631ec1026f2535
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoWiring Service for IDM Light 76/30676/1
Sharon Aicler [Fri, 4 Dec 2015 00:56:18 +0000 (16:56 -0800)]
Wiring Service for IDM Light

Change-Id: I644e16f137862a20febdbec3b69912fb23e8c9f4
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agoInherit version from parent 01/30401/2
Thanh Ha [Mon, 30 Nov 2015 19:35:24 +0000 (14:35 -0500)]
Inherit version from parent

Since the bundle is using the same version as the parent version we can
inherit it and clean up the pom a little. Some aaa artifacts are already
using this method so this patch just makes the remaining ones update for
consistency.

Change-Id: I7af809d24475f096fbcedacbed1f239ff76fecec
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoAdd the new config artifact to feature dependencies. 99/30399/2
Vratko Polak [Mon, 30 Nov 2015 19:02:10 +0000 (20:02 +0100)]
Add the new config artifact to feature dependencies.

AAA distribution job (and several downstream merge jobs)
are failing because they are unable to locate
org.opendaylight.aaa:aaa-h2-store:xml:config:0.3.0-SNAPSHOT
This is an attempt to fix that.

Also, the new config artifact is added to artifacts.

Change-Id: Id37064d6eb3eaf87778c0f7f3cec7cd9dcb463a3
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoMerge "Revert "Revert "BUG 4624: Use default domain when credentials dont provide...
Ryan Goulding [Mon, 30 Nov 2015 17:11:43 +0000 (17:11 +0000)]
Merge "Revert "Revert "BUG 4624: Use default domain when credentials dont provide one"""

8 years agoRevert "Revert "BUG 4624: Use default domain when credentials dont provide one"" 93/30393/1
Ryan Goulding [Mon, 30 Nov 2015 17:03:04 +0000 (17:03 +0000)]
Revert "Revert "BUG 4624: Use default domain when credentials dont provide one""

This reverts commit 7bc9064d9fca906e397afadef2ab86838402ceb0.

Change-Id: I3a0ac71bb37540a16a037d43c6b150266bc1c6a7
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoH2 Store converted to Config Subsystem 18/30318/2
Sharon Aicler [Sat, 28 Nov 2015 19:53:41 +0000 (11:53 -0800)]
H2 Store converted to Config Subsystem

Change-Id: I6400587b920f8558512b942889216f3c72e42a49
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agoHardwire Services in sts ServiceLocator 08/29608/3
Sharon Aicler [Thu, 12 Nov 2015 19:21:42 +0000 (11:21 -0800)]
Hardwire Services in sts ServiceLocator

Change-Id: Ia408c78484ee0183626437318c147d60979d204f
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agoApply comments for MDSAL Store 17/30317/2
Sharon Aicler [Sat, 28 Nov 2015 14:53:08 +0000 (14:53 +0000)]
Apply comments for MDSAL Store

This reverts commit 7050d9954aed918d6b6bca4ccaec803a33f83a1d.

Change-Id: I450370f72888a54790d2c3e1077adab96a22bc40
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agoRe-apply MD-SAL Data Store For AAA 15/30315/3
Sharon Aicler [Sat, 28 Nov 2015 14:50:55 +0000 (14:50 +0000)]
Re-apply MD-SAL Data Store For AAA

This reverts commit 56837b89838429e326b8f18312f66331fe85eb44.

Change-Id: Ic8ec33213fbd8a632ab4b37a25fb1266f2f35d4f
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agoMerge "Add OAuth2 Token to Shiro to maintain cross-version compatibility"
Ryan Goulding [Wed, 25 Nov 2015 18:27:47 +0000 (18:27 +0000)]
Merge "Add OAuth2 Token to Shiro to maintain cross-version compatibility"

8 years agoAdd OAuth2 Token to Shiro to maintain cross-version compatibility 10/30110/4
Ryan Goulding [Tue, 24 Nov 2015 03:09:30 +0000 (22:09 -0500)]
Add OAuth2 Token to Shiro to maintain cross-version compatibility

Adds a mechanism to authenticate OAuth2 tokens, similar to
TokenAuthFilter's implementation.

Change-Id: Idade3da6fc364e1635d8a92b37e617d5ca697821
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoRevert "MD-SAL Store for IDM" 41/30141/3
Ryan Goulding [Tue, 24 Nov 2015 14:27:04 +0000 (14:27 +0000)]
Revert "MD-SAL Store for IDM"

This reverts commit 4a4dcdb561819b4016b918516d3dddf116016d0b.

Change-Id: I27df1cad7fa1c5e67f89cc84ca403e96fb5999e9
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Revert "BUG 4624: Use default domain when credentials dont provide one""
Ryan Goulding [Tue, 24 Nov 2015 16:24:52 +0000 (16:24 +0000)]
Merge "Revert "BUG 4624: Use default domain when credentials dont provide one""

8 years agoMerge "Revert "MD-SAL Store applied Comments""
Ryan Goulding [Tue, 24 Nov 2015 16:24:23 +0000 (16:24 +0000)]
Merge "Revert "MD-SAL Store applied Comments""

8 years agoRevert "BUG 4624: Use default domain when credentials dont provide one" 43/30143/1
Ryan Goulding [Tue, 24 Nov 2015 14:28:52 +0000 (14:28 +0000)]
Revert "BUG 4624: Use default domain when credentials dont provide one"

This reverts commit 4e67c246552d8bb40d5090bc0f572df91cce84ac.

Change-Id: I389426f9f95e6d6c91bc2b300dfe257af992f571
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoRevert "MD-SAL Store applied Comments" 42/30142/1
Ryan Goulding [Tue, 24 Nov 2015 14:27:58 +0000 (14:27 +0000)]
Revert "MD-SAL Store applied Comments"

This reverts commit f429ddf8d4db71c40ca9957c52e4052b95cb10de.

Change-Id: Ifba2d2342cbb793d5bd20dff22b2a7c83629dcf9
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBUG 4624: Use default domain when credentials dont provide one 88/29588/2
Tomas Cere [Thu, 12 Nov 2015 10:32:56 +0000 (11:32 +0100)]
BUG 4624: Use default domain when credentials dont provide one

Change-Id: I28a76301b2a588dd52d686d76f7abcace036ee88
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoMerge "Enables TokenAuthRealm adapter to existing data stores"
Ryan Goulding [Sun, 8 Nov 2015 22:34:37 +0000 (22:34 +0000)]
Merge "Enables TokenAuthRealm adapter to existing data stores"

8 years agoMerge "MD-SAL Store applied Comments"
Ryan Goulding [Sun, 8 Nov 2015 22:19:15 +0000 (22:19 +0000)]
Merge "MD-SAL Store applied Comments"

8 years agoMD-SAL Store applied Comments 33/29333/2
Sharon Aicler [Thu, 5 Nov 2015 18:18:09 +0000 (10:18 -0800)]
MD-SAL Store applied Comments

Change-Id: Idc25ccc288767ee7d97681734a5a16b78689729f
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agoEnables TokenAuthRealm adapter to existing data stores 86/29386/2
Ryan Goulding [Fri, 6 Nov 2015 14:08:57 +0000 (09:08 -0500)]
Enables TokenAuthRealm adapter to existing data stores

Enables a new realm to check authentication against existing data
stores (IdM & MD-SAL).

Change-Id: I65bd61fe77afa09dd1c02ac37831c516b1cc8200
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoSwitch DefaultRBACRules to utilize lazy initialization 46/29346/2
Ryan Goulding [Thu, 5 Nov 2015 20:05:40 +0000 (15:05 -0500)]
Switch DefaultRBACRules to utilize lazy initialization

Change-Id: I6e8ecca904e2c64f6d977204f36b0f4c83275702
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 4588 aaa-authn-api causing stack overflow for sfc tests 40/29340/2
Ryan Goulding [Thu, 5 Nov 2015 19:05:40 +0000 (14:05 -0500)]
Bug 4588 aaa-authn-api causing stack overflow for sfc tests

Swaps out the logging library in favor of the l2switch library, so
that the classpath is not polluted with APIs that do not behave
well together.

Change-Id: I067cfa648904a339b572fc3cd77e326bfcc1a209
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "MD-SAL Store for IDM"
Ryan Goulding [Thu, 5 Nov 2015 15:18:47 +0000 (15:18 +0000)]
Merge "MD-SAL Store for IDM"

8 years agoMD-SAL Store for IDM 77/29077/1
Sharon Aicler [Sat, 31 Oct 2015 15:53:25 +0000 (08:53 -0700)]
MD-SAL Store for IDM

Change-Id: Ib44bf394616b5a471025a1d5b98ea3574f2e94f3
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agoFix aaa-shiro JDK8 compatibility 54/29054/1
Robert Varga [Sat, 31 Oct 2015 11:02:11 +0000 (12:02 +0100)]
Fix aaa-shiro JDK8 compatibility

Fixes how external links are documented.

Change-Id: I493476675aa7b4f36ca82d33c0469da5b1605fc7
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoRemove duplicate dependency 52/29052/1
Robert Varga [Sat, 31 Oct 2015 10:57:43 +0000 (11:57 +0100)]
Remove duplicate dependency

Maven warns about multiple entries in dependecies -- remove them to fix
the warning.

Change-Id: Ic1cfa942dd44fee9a17cf09020a5cd98b0f0547f
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMerge "Fix JDK8 compatibility"
Ryan Goulding [Fri, 30 Oct 2015 13:40:56 +0000 (13:40 +0000)]
Merge "Fix JDK8 compatibility"

8 years agoFix JDK8 compatibility 03/29003/1
Robert Varga [Fri, 30 Oct 2015 11:17:44 +0000 (12:17 +0100)]
Fix JDK8 compatibility

I355acae1ac6652eb15cbd83ce9b0fcdcb9cc8afc caused compilation regression
in CredentialAuth. Fix that.

Change-Id: Ic523cf60dbafc681962d19c7cdb67b17cef69f89
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoMerge "Revert "Bug 2515 - Jersey to support JAX-RS 2.0""
Ryan Goulding [Thu, 29 Oct 2015 20:21:57 +0000 (20:21 +0000)]
Merge "Revert "Bug 2515 - Jersey to support JAX-RS 2.0""

8 years agoRevert "Bug 2515 - Jersey to support JAX-RS 2.0" 70/28970/1
Ryan Goulding [Thu, 29 Oct 2015 18:02:41 +0000 (18:02 +0000)]
Revert "Bug 2515 - Jersey to support JAX-RS 2.0"

This reverts commit b1c7e0948abe0d62f130667ee98fd89b148a1009.

Change-Id: I4f1be95f9cab2f25a8309c305f8991a0faaccea2
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Bug 2515 - Jersey to support JAX-RS 2.0"
Ryan Goulding [Thu, 29 Oct 2015 14:32:46 +0000 (14:32 +0000)]
Merge "Bug 2515 - Jersey to support JAX-RS 2.0"

8 years agoRemove unnecessary synchronization locks in service locator 01/28801/1
Ryan Goulding [Mon, 26 Oct 2015 13:05:37 +0000 (09:05 -0400)]
Remove unnecessary synchronization locks in service locator

ServiceLocator instance variables are already volatile to ensure
consistency across threads.  Thus, synchronization locks aren't
needed, since reads and writes are already atomic.

Change-Id: I3eb3bdb4944ecd4ca8835b86ca35f67682130e4e
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "DataEncrypter Unit Test and remove previous changes"
Ryan Goulding [Mon, 26 Oct 2015 01:13:57 +0000 (01:13 +0000)]
Merge "DataEncrypter Unit Test and remove previous changes"