epgoraj [Wed, 31 Aug 2016 09:50:38 +0000 (15:20 +0530)]
BUG: 6582 copying DHCP service config file to etc/..config
Change-Id: Icaf6e9e9f18f70b74d98dcfbbbc6ba2b5f0531ad
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Shlomi [Wed, 31 Aug 2016 22:16:08 +0000 (01:16 +0300)]
BUG 6598 listen to a change on BridgeRefEntry
in cases a bridge is created without dpnId the creation of TZ fails. we need to re-try when the entry is updated.
Change-Id: Ifc808b8895911df69703adf4122828a7056a0d6e
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>
Stephen Kitt [Thu, 1 Sep 2016 08:19:27 +0000 (08:19 +0000)]
Merge "fix security groups IT"
Sam Hague [Thu, 1 Sep 2016 00:54:03 +0000 (20:54 -0400)]
fix security groups IT
Change-Id: I6cb9b226ed15241cb206e412352e9af02ef5a766
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 1 Sep 2016 00:26:57 +0000 (00:26 +0000)]
Merge "Bug 6592: Adding output to group of external network when using NAPT"
Sam Hague [Wed, 31 Aug 2016 20:11:34 +0000 (20:11 +0000)]
Merge "Bug 6509 - External network group tables removal is not working - indirect type"
Sam Hague [Wed, 31 Aug 2016 20:05:51 +0000 (20:05 +0000)]
Merge "Reduce IPv6 Periodic Unsolicited RA timer interval"
Josh [Wed, 24 Aug 2016 18:30:09 +0000 (20:30 +0200)]
Fix DMAC flows for Vlan E/W provider
This fix addresses two bugs related only in that
they both prevent vlan provider networks from
working:
1) Wrong (remote) dmac flows generated for Vlan provider networks
https://bugs.opendaylight.org/show_bug.cgi?id=6583
2) Mac learning in vlan provider networks clobbers static flows with wrong flows
https://bugs.opendaylight.org/show_bug.cgi?id=6584
The fix for the (1) is to test if the net is
of type vlan and then retrieve the correct action.
The fix for (2) is to simply disable configuration
of remote dmac flows when the interface from whence
entered the unknown smac is a vlan or flat network
provider interface.
Change-Id: Id3431e94d96dac5230679fcb70fe0a79efbd96a4
Signed-off-by: Josh <jhershbe@redhat.com>
Koby Aizer [Wed, 24 Aug 2016 22:40:49 +0000 (01:40 +0300)]
Fix NPE when updating vpnInterface
Change-Id: Ib7c3a8ab804947d018fc21c2fedcbf8894346c03
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>
Sridhar Gaddam [Wed, 31 Aug 2016 17:32:04 +0000 (23:02 +0530)]
Reduce IPv6 Periodic Unsolicited RA timer interval
In some situations it was noticed that flow programming is taking
some time. Due to this, the Router Soliciation requests from the
VMs are not punted to the controller (VMs are able to acquire IPv6
address only upon arrival of unsolicited Router Advts from the ODL
controller). Currently the periodic unsolicited RA interval is set
to 5 mins. This patch reduces the interval to 60 seconds to mitgate
such situations.
In a future patch, we would enhance the periodic RA interval to an
updated algorithm which will provide a better user experience.
Change-Id: I2eb4061b487cfa709ef02b7d093481799294adb3
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sam Hague [Wed, 31 Aug 2016 16:26:05 +0000 (16:26 +0000)]
Merge "BUG: 6569 Exceptions thrown while removing mac-entries"
Sam Hague [Wed, 31 Aug 2016 16:23:25 +0000 (16:23 +0000)]
Merge "aclservice Java @Inject etc. instead of XML for "inner" wiring"
Tomer [Mon, 29 Aug 2016 09:33:44 +0000 (12:33 +0300)]
Bug 6592: Adding output to group of external network when using NAPT
https://bugs.opendaylight.org/show_bug.cgi?id=6592
Change-Id: I40b40f5f65c177b3a77a3206c95a4720ed0e66de
Signed-off-by: Tomer <tomer.pearl@hpe.com>
yair [Wed, 31 Aug 2016 09:10:31 +0000 (12:10 +0300)]
Bug 6509 - External network group tables removal is not working - indirect type
Change external network group tables type to All instead of Indirect
This is a workaround fix to the 6509
https://bugs.opendaylight.org/show_bug.cgi?id=6509
The real cause for the bug will be solve in Openflowplugin in the future
https://bugs.opendaylight.org/show_bug.cgi?id=6492
Change-Id: I8bb48a644e6d815f1fe52588aef6ddc668df4956
Signed-off-by: yair <yair.zinger@hpe.com>
epgoraj [Wed, 31 Aug 2016 09:41:53 +0000 (15:11 +0530)]
BUG: 6569 Exceptions thrown while removing mac-entries
Change-Id: I40b3ad8865994f9481dedff3c14074dc55c9db9e
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Andre Fredette [Wed, 31 Aug 2016 03:28:33 +0000 (03:28 +0000)]
Merge "Fixes the SSH drop from DHCP namespace"
Sam Hague [Tue, 30 Aug 2016 21:12:28 +0000 (21:12 +0000)]
Merge "correct default prootcol handling in stateless ACL"
Sam Hague [Tue, 30 Aug 2016 21:12:05 +0000 (21:12 +0000)]
Merge "Bug 6559: Create TZ for routed networks"
Aswin Suryanarayanan [Tue, 30 Aug 2016 16:59:17 +0000 (22:29 +0530)]
Fixes the SSH drop from DHCP namespace
1)Changed netvirt neutron DCL to match the neutron object
representation.
2)Changed the TCP_SYN rule per to make it per port. Added IPv6 SYN drop
rule.
Change-Id: I94cef12de99f87b156e54cc07d7ea135a1549522
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Sam Hague [Tue, 30 Aug 2016 16:23:50 +0000 (16:23 +0000)]
Merge "Fixed the use of index NwConstants"
Sam Hague [Tue, 30 Aug 2016 16:23:40 +0000 (16:23 +0000)]
Merge "Bug 6486: add security-group-mode options"
Slava [Tue, 30 Aug 2016 10:15:44 +0000 (13:15 +0300)]
Bug 6559: Create TZ for routed networks
Change-Id: Id3fda9454b5c73aaa6c5de696036309a8cc0f53b
Signed-off-by: Slava <slava.radune@hpe.com>
Slava [Thu, 25 Aug 2016 12:25:39 +0000 (15:25 +0300)]
correct default prootcol handling in stateless ACL
Change-Id: I0f87bfc77bd8c2d44fb4f8c522486779138a9df2
Signed-off-by: Slava <slava.radune@hpe.com>
Sam Hague [Tue, 30 Aug 2016 12:39:45 +0000 (12:39 +0000)]
Merge "Fix Checkstyle violations (formatting only, no real changes)"
Sam Hague [Tue, 30 Aug 2016 12:33:06 +0000 (12:33 +0000)]
Merge "Bug 6556 - Fix to send the first unsolicited RA message for a Router interface"
yair [Thu, 25 Aug 2016 09:52:16 +0000 (12:52 +0300)]
Fixed the use of index NwConstants
There was a change to support L2 before L3
https://git.opendaylight.org/gerrit/#/c/43126/
Change the use of constnats to the new way of work
Change-Id: I493e80fac8c49d667cf7d9a498d0f7a82892b687
Signed-off-by: yair <yair.zinger@hpe.com>
Sam Hague [Mon, 29 Aug 2016 21:30:15 +0000 (17:30 -0400)]
Bug 6486: add security-group-mode options
Change-Id: I62d46b4fec6f2e406b319972a068671647330477
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Mon, 29 Aug 2016 19:14:11 +0000 (12:14 -0700)]
Bug 6555 - Translation layer skip the RSP creation API call
Change-Id: Id02c7efed8d78960c7b74c813980b42a88335143
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
kalaiselvik [Mon, 29 Aug 2016 09:48:01 +0000 (15:18 +0530)]
Bug 6556 - Fix to send the first unsolicited RA message for a Router interface
On creation of the router interface, the 1st unsolicited RA is sent before
the association of the subnets with the interface. So the RA packet was not
transmitted as no valid gateway address was available for the interface.
The unsolicited RA is tranmitted after network/subnet association.
Change-Id: Ifcf8e0dbe395070ff2a1731b9cf2c151ed024e9d
Signed-off-by: kalaiselvik <Kalaiselvi_K@Dell.com>
Michael Vorburger [Mon, 29 Aug 2016 10:59:42 +0000 (12:59 +0200)]
Fix Checkstyle violations (formatting only, no real changes)
All of changes made here are purely "formatting", and none change code
behaviour in any way. This should thus be safe to merge ASAP.
Change-Id: I9214f254426aae90b20d31c73422363ca69b177e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Fri, 26 Aug 2016 21:04:45 +0000 (21:04 +0000)]
Merge "fix checkstyle for NetvirtIT"
Sam Hague [Fri, 26 Aug 2016 20:42:40 +0000 (16:42 -0400)]
fix checkstyle for NetvirtIT
Change-Id: I51517f242d063ab2b68be692a96cf7c7b24bfec8
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 26 Aug 2016 19:55:32 +0000 (19:55 +0000)]
Merge "Fix broken legacy NetvirtIT"
Sam Hague [Fri, 26 Aug 2016 19:55:16 +0000 (19:55 +0000)]
Merge "add missing exception throws for ElanUtils"
Sam Hague [Fri, 26 Aug 2016 19:55:09 +0000 (19:55 +0000)]
Merge "Add two node IT"
Sam Hague [Fri, 26 Aug 2016 18:57:08 +0000 (18:57 +0000)]
Merge "fix garp packet out creation"
Sam Hague [Fri, 26 Aug 2016 18:52:59 +0000 (14:52 -0400)]
Fix broken legacy NetvirtIT
Change-Id: I60cd9814190a162302b6bad15348010f63c9324b
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 26 Aug 2016 17:47:56 +0000 (13:47 -0400)]
add missing exception throws for ElanUtils
Change-Id: Ib3e941d3985719406399ba64b589bec0e1fa98f9
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 26 Aug 2016 17:39:21 +0000 (13:39 -0400)]
Add two node IT
Change-Id: Idd5aa1cf2be711420d96938769a293a1822b7407
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 26 Aug 2016 16:31:45 +0000 (16:31 +0000)]
Merge "Fix bugs related to wrong exception handling"
Michael Vorburger [Fri, 19 Aug 2016 16:50:13 +0000 (18:50 +0200)]
aclservice Java @Inject etc. instead of XML for "inner" wiring
Some of the painfully hand-written, and often wrong and
out-of-sync with code, ODL Blueprint XML can be automatically generated
by the blueprint-maven-plugin from annotations in Java code.
This has two main advantages: 1. less XML to hand write (wrong
sometimes), and maintain; 2. easy to get a DI framework (blueprint or
another one..) to inject classes - great e.g. for more upcoming end2end
style tests.
Change-Id: Ifb86b00de680bec8ca494519225a55a7a1e6fbb1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Fri, 26 Aug 2016 13:19:14 +0000 (13:19 +0000)]
Merge "elanmanager CLI console commands impl should never catch Exception (II)"
Sam Hague [Fri, 26 Aug 2016 11:39:55 +0000 (11:39 +0000)]
Merge "Fixes Bug 6514"
Sam Hague [Fri, 26 Aug 2016 11:38:53 +0000 (11:38 +0000)]
Merge "Bug 6532: Fix ACL IPv6 VM to VM communication on same network"
Sam Hague [Fri, 26 Aug 2016 01:16:55 +0000 (01:16 +0000)]
Merge "Removing Blind imports across the module"
Sam Hague [Fri, 26 Aug 2016 01:12:58 +0000 (01:12 +0000)]
Merge "Gratitious ARP handling added in ARP cache feature of L3VPN"
Sam Hague [Fri, 26 Aug 2016 01:11:28 +0000 (01:11 +0000)]
Merge "Fix NPE in FloatingIpGarpHandler.sendGarpOnInterface"
Sam Hague [Fri, 26 Aug 2016 01:11:23 +0000 (01:11 +0000)]
Merge "VpnPortIpToPort Listener for ELAN"
Shlomi [Thu, 25 Aug 2016 22:53:11 +0000 (01:53 +0300)]
fix garp packet out creation
Change-Id: I4dd681f5f8a42070c49654dd6a27587046892ef0
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>
Stephen Kitt [Thu, 25 Aug 2016 12:02:20 +0000 (12:02 +0000)]
Merge "Move odl-netvirt-openstack-it to IT bundle"
Aswin Suryanarayanan [Wed, 24 Aug 2016 14:00:22 +0000 (19:30 +0530)]
Fixes Bug 6514
The AclInterface cache was getting cleaned on a interface state change.
Now it will be cleaned up only on port delete.
Change-Id: Ia7fbb3fa77055271bed4ccad1d0155ce1615f309
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Sridhar Gaddam [Thu, 25 Aug 2016 10:35:19 +0000 (16:05 +0530)]
Bug 6532: Fix ACL IPv6 VM to VM communication on same network
This patch programs the necessary flows in the ACL (Stateful version)
to allow IPv6 VM to VM communication on the same network.
Change-Id: I1fa4bf5210c1ebfe73658800796f2c53ec88441f
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Gobinath [Thu, 18 Aug 2016 05:18:33 +0000 (10:48 +0530)]
Gratitious ARP handling added in ARP cache feature of L3VPN
As a part of the ARP cache feature of L3VPN, a timer runs once the ARP of an enterprise host is learned and is cleared as soon as this timer expires. When this host sends ARP packets(GARP for instance),the ARP cache timeout has to be reset again. Handling for it has been added.
Change-Id: I6411448c85fa739ba513b9ceff3fef4c6536108d
Signed-off-by: Gobinath <gobinath@ericsson.com>
Ravit Peretz [Thu, 25 Aug 2016 08:24:43 +0000 (11:24 +0300)]
Fix NPE in FloatingIpGarpHandler.sendGarpOnInterface
Change-Id: I03ecf452559649391ffee5b3597ef9cf95479224
Signed-off-by: Ravit Peretz <ravit.peretz@hpe.com>
eceghkl [Wed, 24 Aug 2016 05:31:30 +0000 (11:01 +0530)]
VpnPortIpToPort Listener for ELAN
* Listens to VpnPortIpToPortListener changes
* Add SMAC and DMAC flows
* Update ELAN operational DS
Change-Id: I70280b5b4e1560e9725015d54f2345401d66f432
Signed-off-by: eceghkl <manu.b@ericsson.com>
Sam Hague [Wed, 24 Aug 2016 21:56:05 +0000 (21:56 +0000)]
Merge "Bug 6515: Fix NPE for an IPv6 subnet without gateway"
Sam Hague [Wed, 24 Aug 2016 20:40:45 +0000 (20:40 +0000)]
Merge "BUG-6455 - passing of OvsdbInventoryService dependency to the constructor is not required"
Sam Hague [Wed, 24 Aug 2016 19:23:33 +0000 (15:23 -0400)]
Move odl-netvirt-openstack-it to IT bundle
Change-Id: I6041e27ee2ef8ec213b2301981c9a15364175448
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 24 Aug 2016 19:25:23 +0000 (19:25 +0000)]
Merge "Fix boron rc1 build by removing netvirt-it-utils"
Bertrand [Wed, 24 Aug 2016 19:08:36 +0000 (12:08 -0700)]
BUG-6455 - passing of OvsdbInventoryService dependency to the constructor is not required
Follow up to patch https://git.opendaylight.org/gerrit/#/c/44572/1
Change-Id: I3d7ed1af1e4745dceac90bc3b3f275d68bad2860
Signed-off-by: Bertrand <bertrand.low@hcl.com>
Sam Hague [Wed, 24 Aug 2016 17:59:59 +0000 (17:59 +0000)]
Merge "BUG-6455 - due to blueprint migration, the order in which the respective ConfigActivator.start() methods is called for Netvirt and Netvirt-Providers is now random. This could cause timing issues where dependencies are not yet loaded when modules like NetVirt starts up. We need to inject the dependency of OvsdbInventoryService for NetvirtProviders so that NetvirtProviders has that service loaded before it starts."
Sam Hague [Wed, 24 Aug 2016 12:29:59 +0000 (08:29 -0400)]
Fix boron rc1 build by removing netvirt-it-utils
Change-Id: I0661c19bbbfdc53ef59f1ab01f489c90e80d3c48
Signed-off-by: Sam Hague <shague@redhat.com>
Sridhar Gaddam [Wed, 24 Aug 2016 10:02:03 +0000 (15:32 +0530)]
Bug 6515: Fix NPE for an IPv6 subnet without gateway
This patch addresses the exception in ipv6service when a IPv6
subnet is created without the gateway_ip.
Change-Id: Ibfa71e1775e15a51e717557ad080634d46d1220c
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sam Hague [Tue, 23 Aug 2016 21:26:47 +0000 (21:26 +0000)]
Merge "Netvirt - Neutron QoS rate limit support"
Bertrand [Tue, 23 Aug 2016 17:05:12 +0000 (10:05 -0700)]
BUG-6455 - due to blueprint migration, the order in which the respective ConfigActivator.start() methods is called for Netvirt and Netvirt-Providers is now random.
This could cause timing issues where dependencies are not yet loaded when modules like NetVirt starts up.
We need to inject the dependency of OvsdbInventoryService for NetvirtProviders so that NetvirtProviders has that service loaded before it starts.
Change-Id: I431554dbd76c9cad71e6d49916a8eb9e4d456f71
Signed-off-by: Bertrand <bertrand.low@hcl.com>
Sam Hague [Tue, 23 Aug 2016 20:53:43 +0000 (20:53 +0000)]
Merge "Bug 6473: Fix for CSIT SSH issue."
Sam Hague [Tue, 23 Aug 2016 17:55:33 +0000 (17:55 +0000)]
Merge "Fixed the vpninstance creation"
Sam Hague [Tue, 23 Aug 2016 17:55:22 +0000 (17:55 +0000)]
Merge "Refactor aclservice to for all the acl types to inherit the same abstract class"
Sam Hague [Tue, 23 Aug 2016 16:43:58 +0000 (16:43 +0000)]
Merge "Change the register that is used in acl learn actions"
yair [Mon, 22 Aug 2016 13:54:27 +0000 (16:54 +0300)]
Fixed the vpninstance creation
The vpn instance was created in the NeutronVpnManager and there was a bug.
It could not create it without the external gateway info.
Should now create it after external gateway info creation
Change-Id: I203693ca69a48d06b69bb8acc9868a899371fcea
Signed-off-by: yair <yair.zinger@hpe.com>
Slava [Mon, 22 Aug 2016 11:58:30 +0000 (14:58 +0300)]
Refactor aclservice to for all the acl types to inherit the same abstract class
Depends on:
https://git.opendaylight.org/gerrit/#/c/44453
Change-Id: I7bb81dc1249a4fcf2684bad879198be00aff0be4
Signed-off-by: Slava <slava.radune@hpe.com>
bharathi.m [Wed, 24 Aug 2016 00:15:29 +0000 (20:15 -0400)]
Bug 6473: Fix for CSIT SSH issue.
* If security rules created with CIDR as 0.0.0.0/0 in TCP Custom rules
it creates nw_dst=0.0.0.0 because of this behavior TCP packets are
getting dropped.
* Fix: If CIDR created with 0.0.0.0/0, nw_dst and nw_src will be
removed from table 40 and table 90.
Change-Id: I82fdfa49d4da545619259572de8e0d2f571107b1
Signed-off-by: bharathi.m <bharathi.m@hcl.com>
Sam Hague [Tue, 23 Aug 2016 12:20:23 +0000 (12:20 +0000)]
Merge "Add support for using kernel modules with docker for IT"
Sam Hague [Tue, 23 Aug 2016 12:19:03 +0000 (12:19 +0000)]
Merge "BUG-6495 BC Grp wrong for E/W VLAN provider net"
Slava [Tue, 23 Aug 2016 09:52:48 +0000 (12:52 +0300)]
Change the register that is used in acl learn actions
Change-Id: I72e7d285cbd914ea3ed5392553b0a91323b50cde
Signed-off-by: Slava <slava.radune@hpe.com>
Suraj Ranjan [Tue, 23 Aug 2016 07:36:07 +0000 (13:06 +0530)]
Removing Blind imports across the module
This commit removes blind imports across the netvirt module.
Change-Id: I3b6d70cd6e83384eaf54f2a2f97495ae47df9e49
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Sam Hague [Mon, 22 Aug 2016 20:46:47 +0000 (20:46 +0000)]
Merge "Fix IndexOutOfBoundsException when a port with IPv6 address is deleted"
Sam Hague [Mon, 22 Aug 2016 20:46:40 +0000 (20:46 +0000)]
Merge "Addition of BgpAlarms"
Sam Hague [Mon, 22 Aug 2016 03:50:35 +0000 (23:50 -0400)]
Add support for using kernel modules with docker for IT
This enabled support for using the kernel modules with Docker containers. Also the default seucity-group-mode is set to transparent until the proper support for stateful and stateless are included in the IT.
Use the following commands to test netvirt from the netvirt/vpnservice directory:
1. Using DockerOvs in userspace
mvn -nsu -f it/pom.xml verify -Pintegrationtest -Dovsdb.controller.address=172.17.0.1 -Dit.test=NetvirtIT#testNeutronNet -Dovsdb.userspace.enabled=yes -Dsgm=transparent
2. Using DockerOvs with kernel modules.
mvn -nsu -f it/pom.xml verify -Pintegrationtest -Dovsdb.controller.address=172.17.0.1 -Dit.test=NetvirtIT#testNeutronNet -Dsgm=transparent
3. Using an externally started Docker container (or vm)
mvn -nsu -f it/pom.xml verify -Pintegrationtest -Dovsdb.controller.address=172.17.0.1 -Dit.test=NetvirtIT#testNeutronNet -Dovsdb.userspace.enabled=yes -Dsgm=transparent -Dovsdbserver.ipaddress=127.0.0.1 -Dovsdbserver.port=6641
Use the following commands to test legacy netvirt from the netvirt/openstack directory:
mvn -nsu -f net-virt-it/pom.xml verify -Pintegrationtest -Dovsdb.controller.address=172.17.0.1 -Dit.test=NetvirtIT#testNeutronNet -Dovsdb.userspace.enabled=yes
mvn -nsu -f net-virt-it/pom.xml verify -Pintegrationtest -Dovsdb.controller.address=172.17.0.1 -Dit.test=NetvirtIT#testNeutronNet
mvn -nsu -f net-virt-it/pom.xml verify -Pintegrationtest -Dovsdb.controller.address=172.17.0.1 -Dit.test=NetvirtIT#testNeutronNet -Dovsdb.userspace.enabled=yes -Dovsdbserver.ipaddress=127.0.0.1 -Dovsdbserver.port=6641
Change-Id: I9e8fac1fa25d9e55f763f66bc87984ebab8738d3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 22 Aug 2016 19:20:23 +0000 (19:20 +0000)]
Merge "BUG-6501: avoid NPE if sgm isn't defined"
Sam Hague [Mon, 22 Aug 2016 19:17:16 +0000 (19:17 +0000)]
Merge "BUG 6489: Routes to InterVpnLink not advertised on BGP"
Sridhar Gaddam [Mon, 22 Aug 2016 15:41:30 +0000 (21:11 +0530)]
Fix IndexOutOfBoundsException when a port with IPv6 address is deleted
This patch avoids the following exception.
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
at java.util.ArrayList.rangeCheck(ArrayList.java:653)[:1.8.0_101]
at java.util.ArrayList.get(ArrayList.java:429)[:1.8.0_101]
at *netvirt.neutronvpn.NeutronPortChangeListener.addPortToSubnets(NeutronPortChangeListener.java:552)
at *.netvirt.neutronvpn.NeutronPortChangeListener.handleNeutronPortUpdated(NeutronPortChangeListener.java:355)
<SNIP>
Change-Id: If9de109b22dde15da07dcd9284b8525ffba2b6fb
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Suraj Ranjan [Mon, 22 Aug 2016 09:00:39 +0000 (14:30 +0530)]
BUG 6489: Routes to InterVpnLink not advertised on BGP
+ Missing functionality: when a route pointing to an interVpnLink
endpoint is added/removed to a Neutron Router, CSC must advertise
the prefix. The nexthop(s) for the BGP are the DPNs where the
endpoint of the InterVpnLink was instantiated
+ Moves some InterVpnLink utility methods from VpnUtil.java to
InterVpnLinkUtil.java
+ Changes some return values to Optional.
Change-Id: I9e671b34400151099e501d26a8a7839c7730d0b7
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Stephen Kitt [Mon, 22 Aug 2016 15:00:51 +0000 (17:00 +0200)]
BUG-6501: avoid NPE if sgm isn't defined
System.getProperty("sgm") returns null if the system property isn't
defined, which throws a NullPointerException on the equals() call.
Inverting the equals() avoids this.
Change-Id: I6060d07a1958ab60de9e816cdfdbe477e4503cf2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Wed, 17 Aug 2016 13:23:09 +0000 (15:23 +0200)]
Fix bugs related to wrong exception handling
see discussion in thread "Re: [netvirt-dev] Exception Handling in
elanmanager-impl" on netvirt-dev@lists.opendaylight.org. Checkstyle
raised these, and is right.
This resolves all Checkstyle related violations related to IllegalCatch.
Change-Id: Ie826b4688cd4b5dee8e0f33e98542319093cfa8c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Chintan Apte [Mon, 22 Aug 2016 07:42:26 +0000 (13:12 +0530)]
Addition of BgpAlarms
Change-Id: I14071695fa0ed858627b0bb1ea16e90ae2188cdc
Signed-off-by: Chintan Apte <chintan.apte@ericsson.com>
Slava [Mon, 22 Aug 2016 06:19:55 +0000 (09:19 +0300)]
Learn Security Groups bug fixes
Change-Id: I0d0b93847520b349c9e5c6a1ef05d6ddce62adb6
Signed-off-by: Slava <slava.radune@hpe.com>
Sam Hague [Mon, 22 Aug 2016 12:44:58 +0000 (12:44 +0000)]
Merge "Fix bug wherein console commands would not work with Karaf ssh session"
Josh [Mon, 22 Aug 2016 12:40:54 +0000 (14:40 +0200)]
BUG-6495 BC Grp wrong for E/W VLAN provider net
As per the explanation in the bug, this group
is configured twice and one of these times is
broken for VLAN and only works for VxLan.
Easy way to solve this it to only call the second
method when the network type is VxLan. That's
what this patch does. Would be better if this
group was configured in one place, coherently.
Change-Id: Ia5d8f003d2f591b6a3d366928683c9e1a3515eb6
Signed-off-by: Josh <jhershbe@redhat.com>
epgoraj [Mon, 22 Aug 2016 07:47:04 +0000 (13:17 +0530)]
Fix bug wherein console commands would not work with Karaf ssh session
Change-Id: I672e5498cc5d8be2e3d6d3d08e1c72f73bf597c8
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Abhinav Gupta [Fri, 19 Aug 2016 08:27:20 +0000 (13:57 +0530)]
Bug 6477 - Fixes dissc of rtr from VPN & VPNPortFixedIpToPort
1. Fix to ensure adjacencies are deleted properly for learnt routes upon
dissociation.
2. Refactor to reduce reads/writes/builders
3. Added synchronization on interfacename for Arp and NeutronVPN while
updating vpninterface-adjacencies.
4. Fix in remove FibManager to not call leakRouteIfNeeded for non-BGP
routes
5. Renamed ArpRemoveCacheTask and ArpAddCacheTask classes to have proper name.
6. Eliminated reads upon DS deletes for VpnPortIPToPortData DS.
Change-Id: Ib6580c71cbce6451d411e1c5f030582225830b4d
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Sam Hague [Sun, 21 Aug 2016 19:34:33 +0000 (19:34 +0000)]
Merge "Use node conn info remote ip for sff"
Sam Hague [Sun, 21 Aug 2016 17:46:04 +0000 (17:46 +0000)]
Merge "Copy default aclservice-config.xml to etc/...config"
Sam Hague [Fri, 19 Aug 2016 21:41:05 +0000 (17:41 -0400)]
Use node conn info remote ip for sff
Change-Id: I789e650fb465bc2f8123cd021c242d315320c906
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 21 Aug 2016 01:42:58 +0000 (21:42 -0400)]
Copy default aclservice-config.xml to etc/...config
Change-Id: I13c3f7618830c8864a1c3cd1a91bba4c7efe7989
Signed-off-by: Sam Hague <shague@redhat.com>
Koby Aizer [Sun, 21 Aug 2016 14:13:24 +0000 (17:13 +0300)]
Fix read of VpnPortipToPort to read from Operational
In patchset https://git.opendaylight.org/gerrit/#/c/43719/
VpnPortipToPort is written operational DS.
This commit fixes NatUtil/SubnetGwMacChangeListener to read from
the updated location.
Change-Id: I7045c9bff47ef0bde7fc3e9a9d8a3b526e54e125
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>
Slava [Thu, 11 Aug 2016 12:04:10 +0000 (15:04 +0300)]
Handle learn security groups
Change-Id: I9d3385502a1e902ba6dd1a034927595d04b54ee8
Signed-off-by: Slava <slava.radune@hpe.com>
Suraj Ranjan [Sat, 20 Aug 2016 07:34:10 +0000 (13:04 +0530)]
BUG 6487: Extra routes to IVpnLink endpoint not in FIB
+ LportTag range for InterVpnLink endpoints has changed to a range of
[170001..270000]. Those values does not fit in a uint16 attribute
+ Also applies a bit of refactoring to reduce the duplication of code
as much as possible
+ It also aligns the system properties names to the ones defined
in sdnc repository
Apart from above bug fix this commit also deals with:
1> Fixes in metadata writing
2> InterVpnLink Active even if VPN not exists
Change-Id: Iafe72a651153a7ca48e68748c6b7b271541e835c
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Andre Fredette [Sat, 20 Aug 2016 17:38:14 +0000 (17:38 +0000)]
Merge "Bug 6486 - Add waits for IT Utils"
Sam Hague [Sat, 20 Aug 2016 16:31:31 +0000 (12:31 -0400)]
Bug 6486 - Add waits for IT Utils
Change-Id: I315706be5e216d23de4f4a0d037cd272b698f734
Signed-off-by: Sam Hague <shague@redhat.com>