Tony Tkacik [Tue, 28 Apr 2015 12:31:22 +0000 (14:31 +0200)]
Bumped Checkstyle to 6.1.1 to be in sync with Maven plugin.
Checkstyle checks needs to be in sync with Checkstyle maven
plugin due to static final constants, which were not
preserved between 2.14 and 2.15 which resulted in
NullPointerExceptions.
Change-Id: I043a9b8bf196b44636f3496e5fd65efce9eccc80
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Fri, 24 Apr 2015 08:37:21 +0000 (10:37 +0200)]
Bumped model versions to .8-SNAPSHOT
Change-Id: I1b1c6c3fcd875795f2b8cab1d4146b25c87ee7e7
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Thu, 23 Apr 2015 10:03:12 +0000 (10:03 +0000)]
Bumped Yangtools by minor version.
Change-Id: I0c357c757ed78607982abfbf788433e16c88835c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Thu, 23 Apr 2015 19:37:19 +0000 (19:37 +0000)]
Merge "Bug 2363, Bug 2205. Beta version of LeafRefContext tree computation"
Peter Kajsa [Wed, 4 Feb 2015 09:06:09 +0000 (10:06 +0100)]
Bug 2363, Bug 2205. Beta version of LeafRefContext tree computation
beta version of DataTree leafrefs values validation
Currently works (Bug 2363):
- LeafRefContext tree build with all relations:
- isReferencing/ hasReferencingChild
- isReferenced/ hasReferencedChild
- leafref target node -> leafref source nodes
- validation of LeafRef Path and Predicates syntax according to RFC6020
specification
- parsing of all LeafRef Path components (i.e.: LeafRef absolute/relative
target path, path Predicates, key path expressions) into LeafRefPath
instance
- pack of utils methods over LeafRefContext tree
- a couple of simple tests
Currently works (Bug 2205):
- validation of LeafRefs values and LeafRefs targets for WRITE, MERGE and
DELETE operations
- leafref path predicates evaluation (also multiple)
Currently known issues (Bug 2363):
- improve leafref identification, also for cases when type of the leaf is
typedef -> typedef -> etc.. -> leafref
- handle also choices without case
- questionable issue is, whether it is necessary to merge referencing and
referencedBy subtrees under the root context (currently are not)
- in equals method check also for predicates equality
- test the solution
Currently known issues (Bug 2205):
- handle also UnkeyedLists
- perfrom further testing
- increase unit tests coverage
- add tests for special cases.
Change-Id: Id873fb446fe40855993fe00e6a56f82d3daee491
Signed-off-by: Peter Kajsa <pkajsa@cisco.com>
Gregor Zatko [Thu, 23 Apr 2015 06:58:18 +0000 (08:58 +0200)]
Bug 2366: new parser API extensions support implemented
Change-Id: Ic8b25287a5e79b6c95e40eb65f7f305e9ba41145
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Gregor Zatko <gzatko@cisco.com>
Robert Varga [Thu, 23 Apr 2015 13:01:20 +0000 (15:01 +0200)]
Expose YangInstanceIdentifier.EMPTY
Quite a few users have custom-made versions of this field. Expose it as
an API element.
Change-Id: I2e77b6bc7751b8e4be92df139c9b1cf782328414
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 22 Apr 2015 15:33:37 +0000 (17:33 +0200)]
SchemaAwareApplyOperation.checkDeleteApplicable() can be static
This method does not touch local state, so make it static.
Change-Id: I973fb25e4989c7969ddb5df18e2d683d2cbc15ef
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 22 Apr 2015 15:32:47 +0000 (17:32 +0200)]
Dump the modification which fails to produce a root node
For CDS implementation, there seems to be a bug where we fail to create
an appropriate changeset. Also be sure to send debug on how the
candidate is being applied.
Change-Id: Ie0eccd831169ff42c002851633926713dba20c74
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 23 Apr 2015 10:27:19 +0000 (12:27 +0200)]
Fixed thread-safety issue in YANG parser.
Change-Id: I9a83ecb316528ee99bc1905ea1d2e7e3f61f11e3
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Wed, 22 Apr 2015 18:28:43 +0000 (18:28 +0000)]
Merge "Fix missing format placeholder"
Tony Tkacik [Wed, 22 Apr 2015 18:28:10 +0000 (18:28 +0000)]
Merge "Add parser support for non-strict schema lookup."
Tony Tkacik [Wed, 22 Apr 2015 18:25:56 +0000 (18:25 +0000)]
Merge "Introduce InstanceIdToNodes into yang-data-impl"
Gregor Zatko [Wed, 22 Apr 2015 13:56:11 +0000 (15:56 +0200)]
Sonar issues clean-up
Change-Id: I9267a5e8dc8347f04a04977043b558369e35670b
Signed-off-by: Gregor Zatko <gzatko@cisco.com>
Tony Tkacik [Wed, 22 Apr 2015 15:54:40 +0000 (15:54 +0000)]
Merge "tests for arguments parsing parsing Augment in Uses (except extensions)"
Tony Tkacik [Wed, 22 Apr 2015 15:53:39 +0000 (15:53 +0000)]
Merge "Fix ifelse curly braces"
Tony Tkacik [Wed, 22 Apr 2015 15:52:02 +0000 (15:52 +0000)]
Merge "Fixing findbugs"
Maros Marsalek [Tue, 21 Apr 2015 12:15:19 +0000 (14:15 +0200)]
Introduce InstanceIdToNodes into yang-data-impl
This utility class transforms instance identifier into a normalized node
structure. Suitable for netconf/restconf protocols.
Change-Id: Ib91afe858ee1d5871dd20222b4a8dba56664df73
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tomas Cere [Wed, 22 Apr 2015 14:44:02 +0000 (16:44 +0200)]
Add parser support for non-strict schema lookup.
If parsers are in non-strict mode they will ignore parsing
any node that fails schema lookup.
Change-Id: I61fa05a2607477a7378952d8a88283f2ca98a13c
Signed-off-by: Tomas Cere <tcere@cisco.com>
Tony Tkacik [Wed, 22 Apr 2015 13:26:57 +0000 (13:26 +0000)]
Merge changes I7c9bd36f,I09573668
* changes:
Add a revisionless QName constructor
Fix DataTreeCandidateNode API definition
Gregor Zatko [Wed, 22 Apr 2015 08:42:32 +0000 (10:42 +0200)]
tests for arguments parsing
parsing Augment in Uses (except extensions)
Change-Id: I331f97cc38d8a060c24d76f482e42618ee046316
Signed-off-by: Gregor Zatko <gzatko@cisco.com>
Debalina Ghosh [Tue, 21 Apr 2015 21:15:35 +0000 (14:15 -0700)]
Fix ifelse curly braces
Change-Id: I174644fd63e25ae0a499908ef60b683407e78185
Signed-off-by: Debalina Ghosh <debalina.ghosh@hp.com>
Robert Varga [Tue, 21 Apr 2015 15:44:34 +0000 (17:44 +0200)]
Fix missing format placeholder
The modification is not logged because we are missing the %s
placeholder.
Change-Id: I8dd1b72a3fe1dde516cad063996731964c1fac29
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 21 Apr 2015 08:52:12 +0000 (08:52 +0000)]
Merge "Bug 2900: Fixed incorrect instanceof check in xml codec."
Tony Tkacik [Tue, 21 Apr 2015 08:34:29 +0000 (08:34 +0000)]
Bug 2900: Fixed incorrect instanceof check in xml codec.
Change-Id: I4b48f73458b8876271ce8ee219f9babd05ec632b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 21 Apr 2015 08:05:53 +0000 (08:05 +0000)]
Merge "change to interface"
Tony Tkacik [Tue, 21 Apr 2015 07:47:16 +0000 (07:47 +0000)]
Merge "Sonar issues clean-up"
Debalina Ghosh [Thu, 16 Apr 2015 21:25:05 +0000 (14:25 -0700)]
Fixing findbugs
Change-Id: I153b8f990b79b3600d40ac239b5930fabb1f9f63
Signed-off-by: Debalina Ghosh <debalina.ghosh@hp.com>
Debalina Ghosh [Fri, 17 Apr 2015 17:47:06 +0000 (10:47 -0700)]
change to interface
Change-Id: Id16a68b5486e334c01341a646a9e83bb0407272c
Signed-off-by: Debalina Ghosh <debalina.ghosh@hp.com>
Debalina Ghosh [Fri, 17 Apr 2015 18:49:59 +0000 (11:49 -0700)]
Findbugs for yang parser impl util
Change-Id: I82f976de66bb3806f0f8d35ab77ca19cdad87b40
Signed-off-by: Debalina Ghosh <debalina.ghosh@hp.com>
Robert Varga [Sat, 18 Apr 2015 21:31:38 +0000 (23:31 +0200)]
Add a revisionless QName constructor
We already provide a string-based constructor, but that requires a valid
revision date. A QNameModule does not require a revision, which is
reflected by other factory methods. Add a two-string factory method,
which does not take a revision argument.
Change-Id: I7c9bd36fc972a843b6b45ef972400a8f77f9c9b0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 20 Apr 2015 13:40:36 +0000 (15:40 +0200)]
Fix DataTreeCandidateNode API definition
The javadocs for getDataBefore() and getDataAfter() were switched. Also
add @Nonnull annotations to express the intent to users.
Change-Id: I0957366830f43f0c02e69ae7bddfabe018955bef
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 20 Apr 2015 13:25:03 +0000 (15:25 +0200)]
Bug 2900: Fixed incorrect dispatch for unkeyed list parser.
Change-Id: I3a15b79fd1973736fa0443099f1e7572b78663c1
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Martin Ciglan [Mon, 20 Apr 2015 12:13:23 +0000 (14:13 +0200)]
Sonar issues clean-up
Change-Id: Ic1b3a836efc17f6f589238be26ece2bd08ebcc0a
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Robert Varga [Sat, 18 Apr 2015 18:36:18 +0000 (20:36 +0200)]
BUG-3018: introduce DataTreeCandidateNodes
This is a utility class for various DataTreeCandidate-related
operations. One of them is a method to transform a NormalizedNode into a
DataTreeCandidate which behaves as if that node was freshly written into
an empty DataTree.
Change-Id: Id8126a68f3bf35092bd8630358eb258d65c61d36
Signed-off-by: Robert Varga <rovarga@cisco.com>
Debalina Ghosh [Wed, 15 Apr 2015 19:13:32 +0000 (12:13 -0700)]
Remove ununsed variable
Change-Id: I942cb8d25f4afeea0a488131b326232923d87022
Signed-off-by: Debalina Ghosh <debalina.ghosh@hp.com>
Robert Varga [Thu, 16 Apr 2015 11:51:13 +0000 (11:51 +0000)]
Merge "Bug 2999: Use normalized type in creation of simple JSON codecs."
Tony Tkacik [Thu, 16 Apr 2015 11:10:33 +0000 (13:10 +0200)]
Bug 2999: Use normalized type in creation of simple JSON codecs.
Change-Id: I9c3fc6412fb96f513967a950540725a6c4886cad
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Thu, 16 Apr 2015 10:59:03 +0000 (10:59 +0000)]
Merge "Bug 2362 - Milestone: Basic constraints validation"
Robert Varga [Thu, 16 Apr 2015 09:11:31 +0000 (09:11 +0000)]
Merge "Direct schema node lookup in SchemaUtils"
Maros Marsalek [Mon, 13 Apr 2015 15:58:31 +0000 (17:58 +0200)]
Direct schema node lookup in SchemaUtils
SchemaUtils.findSchemaForChild now looks up child schema node
directly by querying the parent schema node and uses the
iterative/recursive lookup as fallback.
This is a performance improvement that bypasses the recursive
lookup if possible.
Change-Id: I888e767310713efd42428ef58caf959651643f49
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Vishal Thapar [Tue, 14 Apr 2015 12:40:19 +0000 (18:10 +0530)]
workaround for BUG: 2974
Suggested workaround for bug2974 is to add
yang-types revision to ietf-interfaces.yang
This change imports latest revision as well as
changes the dependency to ietf-yang-type-
20130715
Change-Id: If0ad60b435ae311db656d1a7e49402bc3ef6bb2f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Tony Tkacik [Wed, 15 Apr 2015 13:51:34 +0000 (13:51 +0000)]
Merge "Bug 2997: Fixed instanceof checks to use interfaces"
Gregor Zatko [Wed, 15 Apr 2015 10:45:19 +0000 (12:45 +0200)]
Bug 2366 - Effective statements impl for new yang parser.
- added implementation of effective statements and integration to
yang-model-api
- added implementation and tests of augment declared statement and AugmentUtils
Change-Id: Ifc39ce971cd3efd5bb00f3f4f25dbd791ee65c38
Signed-off-by: Peter Kajsa <pkajsa@cisco.com>
Signed-off-by: Gregor Zatko <gzatko@cisco.com>
Tony Tkacik [Wed, 15 Apr 2015 08:18:51 +0000 (10:18 +0200)]
Bug 2997: Fixed instanceof checks to use interfaces
JSONCodecFactory used instanceof checks for conrete
implementation classes instead of checks for
interfaces describing behaviour.
Change-Id: Ib8a0b259b993a52bd661ac33db6ae91308f46774
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Martin Ciglan [Tue, 14 Apr 2015 14:31:07 +0000 (16:31 +0200)]
Bug 2366 - new parser API - implementation of declared statements
- added integration between ANTL4 parsing YANG file and new parser
- added test to demonstrate it
- added implementation of yang statements and their definitions resp. support
classes
- added implementation of effective statements and integration to yang.model.api
- added effective build implementation and unit tests of effective build
- added new namespaces
- added new utils and parsing methods
- added simple unit tests
Bugfixing:
- fix of phases switching bugs on two places
- fix of argument parsing before parent ctx assigment (NPE on null parent)
- fix of values retrieval from sourceLocal and treeScoped namespaces
- fix of tryToComplete method in SourceSpecificContext class. Method did not
return correct progress result although everything was resolved
correctly
Change-Id: I5d6acc69bb877b26403d69e276ed5c578e9bd4d9
Signed-off-by: Peter Kajsa <pkajsa@cisco.com>
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Gregor Zatko <gzatko@cisco.com>
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Jan Hajnar [Fri, 6 Feb 2015 14:26:34 +0000 (15:26 +0100)]
Bug 2362 - Milestone: Basic constraints validation
* added validator class for min and max elements constraint
* added validation method calls from NormalizedNodeContainerModificationStrategy and
UnkeyedListModificationStrategy
* added tests
Change-Id: I384837f1a2a6dc730b824d509f7080df7408fd3f
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 14 Apr 2015 10:38:31 +0000 (10:38 +0000)]
Merge "Bug 2362: Make sure JSON and XML codecs are not losing constraints."
Tony Tkacik [Mon, 13 Apr 2015 16:48:43 +0000 (18:48 +0200)]
Bug 2984 - Added Missing space separator for list keys in yin format
Change-Id: Ibb943777604f61dde20bb84fce2a7f13c38333c7
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Mon, 13 Apr 2015 09:27:14 +0000 (09:27 +0000)]
Merge "BUG-1485: deprecate length/range methods"
Robert Varga [Mon, 13 Apr 2015 09:18:48 +0000 (09:18 +0000)]
Merge "Bug 1260: Implemented Binding Caching Codec"
Robert Varga [Mon, 13 Apr 2015 08:40:23 +0000 (08:40 +0000)]
Merge "Bug 2374 - YANG Binding: Added support for AugmentationHolder interface"
Robert Varga [Wed, 18 Mar 2015 17:20:15 +0000 (18:20 +0100)]
BUG-1485: deprecate length/range methods
These methods leak the internals of how constraints are enforced. No
outside parties should rely on them, so lets mark them deprecated. If we
do not get reports of use, we should be removing them in a future
release.
Change-Id: I128c5abe5c894a4808ff30dcebd6af42d8f682cb
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 8 Apr 2015 17:41:05 +0000 (19:41 +0200)]
Bug 1260: Implemented Binding Caching Codec
Implemented Bidning Caching Codec which maintains
API-user configured cache of serialized data
from Bidning to NormalizedNode.
These cached data are used in subsequent serializations
in order to not allocate new NormalizedNodes for
logically equivalent data.
Change-Id: Iafaed957453569c3e8ecfbb2aed333f3a1fd418f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Jan Hajnar [Thu, 9 Apr 2015 11:41:43 +0000 (13:41 +0200)]
Bug 2964 - ClassCastException when querying -
controller-config/yang-ext:mount/config:modules
* added test for bugfix
Change-Id: I4d82b982471559b3bfc7ce81cce65f91d831aab3
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Robert Varga [Sat, 11 Apr 2015 20:22:50 +0000 (22:22 +0200)]
Fix enum members' name
Enumeration members are supposed to be capitalized as normal constants.
Fix that before the API is widely used.
Change-Id: I1d0632e9491bd79047d1f71f2a906c498cdd0ad6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 11 Apr 2015 20:40:02 +0000 (22:40 +0200)]
Do not declare RuntimeExceptions as thrown
Fix a bunch of sonar warnings around declaring runtime exceptions.
Change-Id: I6e8267e29ef6c0d3f2d220531ca656ff564331ec
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 11 Apr 2015 15:11:12 +0000 (17:11 +0200)]
Squash declared types
Rather than binding to particular implementation, make sure we use an
interface.
Change-Id: Ibecbc00a42d1c37339c5f965f6c1c5a63fa24d7f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 11 Apr 2015 15:03:58 +0000 (17:03 +0200)]
Fix constant names
Constants should have capitalized names. Fixes a few sonar warnings.
Change-Id: I600b482a817055784874e91f9cb8c5b06b948302
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Fri, 10 Apr 2015 09:44:58 +0000 (09:44 +0000)]
Merge "BUG-2962: add DataTreeTip interface and implement it"
Tony Tkacik [Thu, 9 Apr 2015 07:59:57 +0000 (09:59 +0200)]
Bug 2362: Make sure JSON and XML codecs are not losing constraints.
Change-Id: I9b3659f46438f1ad06ef86e2df33b7e963db40bc
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Fri, 10 Apr 2015 08:34:20 +0000 (08:34 +0000)]
Merge "Bug 2362: Added pattern validation for string types."
Robert Varga [Fri, 10 Apr 2015 08:33:19 +0000 (08:33 +0000)]
Merge "Extracted remaining codecs to protected classes."
Jan Hajnar [Thu, 9 Apr 2015 13:36:13 +0000 (15:36 +0200)]
Bug 2964 - ClassCastException when querying -
controller-config/yang-ext:mount/config:modules
* fixed referenced identity ref json serialization
Change-Id: Idab6accec5e5c0846f0d6dbb637d8a2806cc5df2
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Tony Tkacik [Thu, 9 Apr 2015 12:33:42 +0000 (12:33 +0000)]
Merge "Make sure LOOKUP is a proper constant"
Tony Tkacik [Thu, 9 Apr 2015 12:33:21 +0000 (12:33 +0000)]
Merge "Remove unneeded final modifiers"
Tony Tkacik [Thu, 9 Apr 2015 12:33:03 +0000 (12:33 +0000)]
Merge "Remove unused imports"
Tony Tkacik [Thu, 9 Apr 2015 12:32:56 +0000 (12:32 +0000)]
Merge "Fix modifier ordering"
Tony Tkacik [Wed, 8 Apr 2015 09:01:31 +0000 (11:01 +0200)]
Bug 2362: Added pattern validation for string types.
Change-Id: Icea2e7cfa87bd746e6da99e6908ab959d6356fd3
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Wed, 8 Apr 2015 07:46:21 +0000 (09:46 +0200)]
Extracted remaining codecs to protected classes.
Change-Id: I1cf9413b8971ae8c2cd51e7995aae537f6705767
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Thu, 9 Apr 2015 11:23:22 +0000 (13:23 +0200)]
Make sure LOOKUP is a proper constant
Change-Id: I684ead0df12bdc5c012f8a20e04f4508c5bbb429
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 9 Apr 2015 11:19:08 +0000 (13:19 +0200)]
Remove unneeded final modifiers
Static methods are implicitly final, no need to declare them as final.
Change-Id: Ia3b085ce0e4cde46952d1b4afc6c908fdec4a506
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 9 Apr 2015 11:14:14 +0000 (11:14 +0000)]
Merge "Bug 2960 - Yang Data Codec Gson: failed to lookup prefix when serializing identityref type"
Robert Varga [Thu, 9 Apr 2015 11:13:30 +0000 (13:13 +0200)]
Remove unused imports
Change-Id: Ic63dcc4e1dbd25a667ac48195bf6e7af7ec28709
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 9 Apr 2015 11:11:05 +0000 (13:11 +0200)]
Fix modifier ordering
JLS specifies annotations need to to come before other modifiers, of
which visbility should be first.
Change-Id: I754ef08c13256647d024c121e75fd3617ef6d064
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 7 Apr 2015 19:09:01 +0000 (21:09 +0200)]
BUG-2962: add DataTreeTip interface and implement it
DataTreeTip forms a point where a modification can be applied to. This
interface can be implemented by DataTreeCandidate instances (as
DataTreeCandidateTip), so users can prepare a sequence of modifications
for commit without actually applying them.
Change-Id: Ic772fa9b813105f3731c6b7cea45b629f9137de1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jan Hajnar [Thu, 9 Apr 2015 07:49:06 +0000 (09:49 +0200)]
Bug 2964 - ClassCastException when querying -
controller-config/yang-ext:mount/config:modules
* added recursive call to parseXml if baseType is leafref (otherwise
identityref and instnce identifier values were not serialized
correctly)
Change-Id: Ie17f8cff1b7bb59e541996a277ff6dfefa30a375
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Robert Varga [Wed, 8 Apr 2015 22:55:45 +0000 (22:55 +0000)]
Merge "Fixed incorrect signature in NotificationListenerInvoker"
Tony Tkacik [Wed, 8 Apr 2015 17:42:29 +0000 (19:42 +0200)]
Fixed incorrect signature in NotificationListenerInvoker
Change-Id: I01e54f6193e54b1488a506ae47d24ba8c808281a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Wed, 8 Apr 2015 16:34:00 +0000 (16:34 +0000)]
Merge "Bug 2362: Wired integer value validating codec."
Jan Hajnar [Wed, 8 Apr 2015 11:38:04 +0000 (13:38 +0200)]
Bug 2960 - Yang Data Codec Gson: failed to lookup prefix when
serializing identityref type
* added module qname as an input to JSONStringIdentityrefCodec, if no
prefix is specified this module qname is used for value deserialization.
Change-Id: I260eac6104cc8474008dd5eab23990408f86687e
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Tony Tkacik [Tue, 7 Apr 2015 15:02:06 +0000 (17:02 +0200)]
Bug 2362: Wired integer value validating codec.
Wired integer value validating codecs and fixed
tests which were using incorrect values.
Change-Id: If8fa1da1ec456049460e2b72477c0b0a86a4830d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Wed, 8 Apr 2015 11:13:43 +0000 (11:13 +0000)]
Merge "BUG-2955: Fix error reporting for wrong YangInstanceIdentifier"
Robert Varga [Tue, 7 Apr 2015 14:38:00 +0000 (16:38 +0200)]
BUG-2955: Fix error reporting for wrong YangInstanceIdentifier
As turns out, attempting to load the wrong value will be reported via
UncheckedExecutionException, which we failed to account for. Make sure
we also catch this type and convert it into an Optional.absent() -- that
will trigger callers to properly report an IllegalArgumentException.
Change-Id: I50441cce4be94a2ef0fcf12591c6ec0e437f1084
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 5 Mar 2015 19:09:52 +0000 (20:09 +0100)]
Moved DerivedTypes to yang-model-util
Derived* types make more sense and are more usable
if present in yang-model-util instead of yang-model-export.
Their presence in yang-model-util allows for better reuse
and simplification of code dealing with yang-types.
Change-Id: I259325f830d7e8d0095c0cfbfe3c0a5a450d05a1
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Wed, 8 Apr 2015 09:09:00 +0000 (09:09 +0000)]
Merge "BUG 2908 - Unable to read data from netconf northbound loopback connection."
Tomas Cere [Fri, 27 Mar 2015 15:32:19 +0000 (16:32 +0100)]
BUG 2908 - Unable to read data from netconf northbound loopback connection.
In case of a model with multiple revisions, read from mount-point can
fail due to schema node lookup from the wrong revision of a module.
Fixed so findFirstChild in schemaUtils returns newest revision.
Change-Id: I269f35767696364e761d3c3bf245b22830f0f850
Signed-off-by: Tomas Cere <tcere@cisco.com>
Tony Tkacik [Tue, 7 Apr 2015 14:46:38 +0000 (16:46 +0200)]
Bug 2362: Added range validation as last part of deserialization.
Change-Id: I801aa22f868a13c098686aa077c46a378af8dfe4
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 7 Apr 2015 14:10:31 +0000 (16:10 +0200)]
Moved implementation of (U)Int* codecs to separate classes
Change-Id: I589eff7a961d19486529f5d2b5dbc5433988b931
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 7 Apr 2015 13:11:20 +0000 (15:11 +0200)]
Introduced AbstractIntegerStringCodec.
All integer codecs were implementing deserialization in
same fashion - detect number format and actual deserialization.
This patchset introduces common abstract class which
does this same and concrete classes only implement construction
of objects.
Change-Id: I03433a2de54b08b3c23967f4f25f5ba465da0a34
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 7 Apr 2015 09:32:07 +0000 (09:32 +0000)]
Merge "Bug 2909 - Gson codec lost correct type"
Robert Varga [Thu, 2 Apr 2015 17:20:18 +0000 (19:20 +0200)]
BUG-2939: fixup dynamic nodes to cover overwrites
Promote inner classes to their proper equivalents. Perform proper lazy
comparison to cover all possible scenarios where the user might
want to examine terminal nodes in greater depth. This is done by
tracking presence of before/after data and fudging appropriate
modification types.
We make sure to not run equals() on the data, as that may introduce very
steep costs -- an overwrite with the same value is still reported as a
full write, not as unmodified.
Change-Id: I0df100a74cfa82ceddeefcfae0ca2a011c608e08
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 2 Apr 2015 14:21:46 +0000 (14:21 +0000)]
Merge "Fixed NPE in BindingCodecTree#getSubtreeCodec(YangInstanceIdentifier)"
Tony Tkacik [Thu, 2 Apr 2015 13:35:03 +0000 (15:35 +0200)]
Fixed NPE in BindingCodecTree#getSubtreeCodec(YangInstanceIdentifier)
Change-Id: If77807004779ce6ade106f1bacc9918f98f996ee
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Thu, 2 Apr 2015 12:39:22 +0000 (14:39 +0200)]
Bug 2939: Lazily expanded CandidateNode for writes and deletes
Introduced Lazily expanded CandidateNodes for writes and deletes
which does not have before or after state and ModificationType
is same for whole subtree.
Change-Id: Ib26774f9a5e76428fefb35e1d053dad95e8752cf
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Thu, 2 Apr 2015 12:27:26 +0000 (14:27 +0200)]
Bug 2393: Extracted CandidateNode from InMemoryDataTreeCandidate
Change-Id: I4941ec32f22456be1411bd7703acac401d81d3de
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Tue, 31 Mar 2015 21:44:08 +0000 (23:44 +0200)]
Do not embed java-concurrent-hash-trie-map
The package is a full OSGi bundle, no need to inline it in the user
anymore.
Change-Id: I9560ab80f07769c77a75b9c99043b8dc694ab2a8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 31 Mar 2015 21:14:43 +0000 (23:14 +0200)]
BUG-869: remove unneeded null check
Instanceof checks for null implicitly, no need to be explicit.
Change-Id: I2f378567c34fa7ba7adcf8a6c369c2aa6221badf
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 31 Mar 2015 21:11:08 +0000 (23:11 +0200)]
BUG-869: kill more sonar warnings
Empty statement, mis-ordered annotations and keywords, unneeded
keywords.
Change-Id: I88a7ba62b5fe22cda96a1b5243a2ae4968c31ab3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 31 Mar 2015 20:55:31 +0000 (22:55 +0200)]
BUG-869: remove public modifier
Public is implied for all methods in an interface, do not specify it
explicitly.
Change-Id: Ic673b60111f9ecf62a6242d3bedf8607036a3403
Signed-off-by: Robert Varga <rovarga@cisco.com>