netconf.git
8 years agobuilder class for path creating 53/36053/4
miroslav.kovac [Thu, 10 Mar 2016 14:30:10 +0000 (15:30 +0100)]
builder class for path creating

Paths can be created with new path creator class
instead of using constant strings.

Change-Id: Icae8b65fc43f2a12f044f075279fd3ccb009074e
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
8 years agoMerge "Remove unused aaa dependency from netconf-connector feature pom.xml"
Tomas Cere [Fri, 1 Apr 2016 08:17:59 +0000 (08:17 +0000)]
Merge "Remove unused aaa dependency from netconf-connector feature pom.xml"

8 years agoRemove unused aaa dependency from netconf-connector feature pom.xml 71/36971/1
Ryan Goulding [Thu, 31 Mar 2016 15:16:22 +0000 (11:16 -0400)]
Remove unused aaa dependency from netconf-connector feature pom.xml

Removes the features-aaa dependency as it is not needed.

Change-Id: Ia6892bc8b6ae03ca9d648dfae340cf185b1c9c8a
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 5638 switch netconf to use odl-aaa-shiro isntead of odl-aaa-authn 59/36959/1
Ryan Goulding [Thu, 31 Mar 2016 14:13:09 +0000 (10:13 -0400)]
Bug 5638 switch netconf to use odl-aaa-shiro isntead of odl-aaa-authn

odl-aaa-authn has very limited uses now, since odl-aaa-shiro has
included most of its features by default.  Switch netconf to use
odl-aaa-shiro instead of odl-aaa-authn, to get most up to date
aaa implementation.  odl-aaa-authn should be deprecated in a
separate patch.

Change-Id: I3ca039efb607bef6c657937d0471e0b63a01b35b
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Optimize NetconfMonitoringServiceImpl getSchemaForCapability"
Tomas Cere [Tue, 29 Mar 2016 14:32:06 +0000 (14:32 +0000)]
Merge "Optimize NetconfMonitoringServiceImpl getSchemaForCapability"

8 years agoMerge "Add support for notification subtree filter"
Tomas Cere [Tue, 29 Mar 2016 13:46:11 +0000 (13:46 +0000)]
Merge "Add support for notification subtree filter"

8 years agoMerge "Add support to RESTCONF to dynamically specify Filters"
Tomas Cere [Tue, 29 Mar 2016 13:22:53 +0000 (13:22 +0000)]
Merge "Add support to RESTCONF to dynamically specify Filters"

8 years agoMerge "Reimplement NetconfDevice schema setup without recursion"
Tomas Cere [Tue, 29 Mar 2016 13:00:37 +0000 (13:00 +0000)]
Merge "Reimplement NetconfDevice schema setup without recursion"

8 years agoMerge "change to static function"
Tomas Cere [Tue, 29 Mar 2016 12:12:33 +0000 (12:12 +0000)]
Merge "change to static function"

8 years agoMerge "Revert "Add PasswordCredentialAuth interface""
Maros Marsalek [Mon, 21 Mar 2016 11:48:28 +0000 (11:48 +0000)]
Merge "Revert "Add PasswordCredentialAuth interface""

8 years agoMerge "Bug 5475 - File descriptor leak on netconf connector reconnects"
Tomas Cere [Mon, 21 Mar 2016 10:03:04 +0000 (10:03 +0000)]
Merge "Bug 5475 - File descriptor leak on netconf connector reconnects"

8 years agoRevert "Add PasswordCredentialAuth interface" 89/36489/1
Tomas Cere [Mon, 21 Mar 2016 09:57:30 +0000 (09:57 +0000)]
Revert "Add PasswordCredentialAuth interface"

This reverts commit 57bfaf2a0146d33a9a504b5a48c5525916a44b79.

Change-Id: I5516089a829fb9b76586289080f78c7343366f21
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoAdd support to RESTCONF to dynamically specify Filters 56/36456/1
Ryan Goulding [Tue, 15 Mar 2016 14:17:36 +0000 (10:17 -0400)]
Add support to RESTCONF to dynamically specify Filters

This change builds of work that the AAA team took on to help add dynamicism to
RESTCONF.  The javax.servlet-api specifies a means to define chains of Filter(s)
in front of a web Servlet.  However, configuration of filters is not supported, and
there is no easy existing mechanism to add Filters to a prebuilt ODL
distribution.  The issue involves the fact that Jersey Servlets define Filter
chains within web.xml, which is static and included inside of the odl-restconf
bundle.  This makes it very hard (if not impossible due to lack of
DynamicImport-Package declarations in restconf's pom) to alter the web.xml file
after compilation.

AAA added a filter called CustomFilterAdapter, which recreates the javax
filter chain-of-responsibility pattern.  The dynamic filter chain functionality
has very little to no overhead if left unused, but could be used to add
Filter implementations that allow for enhanced logging of HTTP/S requests/
replies, as well as other various functions.  This aids in debugging real
world deployments, as well as enables enhanced Accounting and Auditing
of the controller.

This functionality has been raised as vital by members of the AG.

Change-Id: Ib81ebdd0ab7de72d75cbbc90124656a3666cacba
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoBug 5475 - File descriptor leak on netconf connector reconnects 92/36192/5
adetalhouet [Thu, 17 Mar 2016 23:08:15 +0000 (19:08 -0400)]
Bug 5475 - File descriptor leak on netconf connector reconnects

Do not start the SshClient each time the AsyncSshHandler is instantiated.

http://mail-archives.apache.org/mod_mbox/mina-users/201603.mbox/%3CCAA66TprZd754Ry8wMYgS7kOJc8%3DvZNP3MA41VYZyVi_oQSv6yw%40mail.gmail.com%3E

Change-Id: If239f87ea4ff707f564f7f10e4f50481033f77fd
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
8 years agoMerge "Update fixme comments"
Tomas Cere [Fri, 18 Mar 2016 14:51:45 +0000 (14:51 +0000)]
Merge "Update fixme comments"

8 years agoMerge "Remove unneeded todos and fixmes"
Tomas Cere [Fri, 18 Mar 2016 14:51:10 +0000 (14:51 +0000)]
Merge "Remove unneeded todos and fixmes"

8 years agoMerge "Add description to northbound notification yang files"
Tomas Cere [Fri, 18 Mar 2016 14:50:08 +0000 (14:50 +0000)]
Merge "Add description to northbound notification yang files"

8 years agoUpdate fixme comments 36/36436/1
Andrej Mak [Fri, 18 Mar 2016 12:06:17 +0000 (13:06 +0100)]
Update fixme comments

NetconfBaseOps - remove, source node is and has to be wrapped in a choice
CreateSubscription - update comment
MonitoringToMdsalWriter - issue not present anymore

Change-Id: Ied963c7888dc17c352bd942c4176c1de38fd8c73
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoOptimize NetconfMonitoringServiceImpl getSchemaForCapability 66/35866/5
Andrej Mak [Mon, 7 Mar 2016 10:20:16 +0000 (11:20 +0100)]
Optimize NetconfMonitoringServiceImpl getSchemaForCapability

Update mappedModulesToRevisionToSchema only on capability change,
so getSchemaForCapability doesn't need to compute it every time
it's called.

Change-Id: I059085d45c988b58b1379f87c4a5162014b81624
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAdd support for notification subtree filter 32/36432/2
Andrej Mak [Fri, 18 Mar 2016 10:31:44 +0000 (11:31 +0100)]
Add support for notification subtree filter

Change-Id: Ieae248057d890071c6ac5b05b22f1a05a0a98b0c
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agonetconf-testtool, autoconfiguration through restconf and topology model 65/35065/9
miroslav.kovac [Fri, 19 Feb 2016 11:36:30 +0000 (12:36 +0100)]
netconf-testtool, autoconfiguration through restconf and topology model

It starts all the devices, creates a restconf request and
sends PUT request to odl which sends us some response.
It also gives us time of how long did it take to configure
all the devices. All this can be done synchronously or
asynchronously.

Change-Id: I3c9bfc23b538d934809ddf3664fe024af65ec6ef
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
8 years agochange to static function 54/36254/3
miroslav.kovac [Tue, 15 Mar 2016 15:09:57 +0000 (16:09 +0100)]
change to static function

Function get in TestingNetconfClient is static.

Change-Id: Ic6973b7afdffc1fdde10c20a2bc6a1ebedf8f0fd
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
8 years agoMerge "Use java 8 DateTimeFormatter in NetconfServerSession"
Tomas Cere [Thu, 17 Mar 2016 12:49:24 +0000 (12:49 +0000)]
Merge "Use java 8 DateTimeFormatter in NetconfServerSession"

8 years agoMerge "Refactor NetconfEventSource"
Tomas Cere [Thu, 17 Mar 2016 12:33:56 +0000 (12:33 +0000)]
Merge "Refactor NetconfEventSource"

8 years agoAdd PasswordCredentialAuth interface 68/35768/4
miroslav.kovac [Thu, 3 Mar 2016 13:38:55 +0000 (14:38 +0100)]
Add PasswordCredentialAuth interface

Prevents warnings during compilation since CredentialAuth is generic.

Change-Id: I368ecf4d03dca65da331c5fd81f2ac7c94d5972e
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
8 years agoMerge "Avoid relying on the timezone"
Maros Marsalek [Thu, 17 Mar 2016 10:12:19 +0000 (10:12 +0000)]
Merge "Avoid relying on the timezone"

8 years agoRemove unneeded todos and fixmes 58/35258/4
Andrej Mak [Tue, 23 Feb 2016 14:24:07 +0000 (15:24 +0100)]
Remove unneeded todos and fixmes

AbstractNetconfTopology - default values should not be stored
ClusteredNetconfTopology - default values should not be stored
BaseTopologyManager - we want to keep successful connection alive
KeepaliveSalFacade - if anything fails we log the exception and reconnect
NetconfDeviceRpc - no need
NetconfMonitoringServiceTestImpl - test is already implemented in another package
NetconfTopology - no need
TransactionProvider - now, every session is nicely isolated

Change-Id: I019c0697172089add16c114b2aa1b8b19e949b28
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoRefactor NetconfEventSource 84/36184/3
Andrej Mak [Mon, 14 Mar 2016 10:37:48 +0000 (11:37 +0100)]
Refactor NetconfEventSource

Change-Id: I83e2d89c1b06abb757e941df3312108e2c6c2031
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoBUG 5413 - RestPerfClient: Hang on java.util.concurrent.CancellationException. 73/35973/3
Jakub Morvay [Wed, 9 Mar 2016 10:35:51 +0000 (11:35 +0100)]
BUG 5413 -  RestPerfClient: Hang on java.util.concurrent.CancellationException.

Make timeout for executing requests customizable via parameter --timeout.
Check for cancelled tasks.

Change-Id: I73256bb52d8056f3345621b9a57a0dd3b9cbdfb5
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
8 years agoMerge "Remove outdated todos"
Tomas Cere [Fri, 11 Mar 2016 10:03:25 +0000 (10:03 +0000)]
Merge "Remove outdated todos"

8 years agoMerge "Add javadoc link in LoginPassword"
Tomas Cere [Fri, 11 Mar 2016 10:03:00 +0000 (10:03 +0000)]
Merge "Add javadoc link in LoginPassword"

8 years agoMerge "Code cleanup: unify writeNormalizedNode functionality"
Tomas Cere [Fri, 11 Mar 2016 09:42:35 +0000 (09:42 +0000)]
Merge "Code cleanup: unify writeNormalizedNode functionality"

8 years agoMerge "Use transaction chain in SalNodeWriter"
Tomas Cere [Fri, 11 Mar 2016 09:38:40 +0000 (09:38 +0000)]
Merge "Use transaction chain in SalNodeWriter"

8 years agoMerge "Add netconf message to error info"
Tomas Cere [Fri, 11 Mar 2016 09:37:59 +0000 (09:37 +0000)]
Merge "Add netconf message to error info"

8 years agoMerge "Remove outdated fixme"
Tony Tkacik [Wed, 9 Mar 2016 10:04:11 +0000 (10:04 +0000)]
Merge "Remove outdated fixme"

8 years agoAdd netconf scale-util 87/35887/2
Tomas Cere [Mon, 7 Mar 2016 16:34:56 +0000 (17:34 +0100)]
Add netconf scale-util

Change-Id: I37fd698794d94c48d3c91b4533385c425651d075
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoRemove outdated todos 11/35911/1
Andrej Mak [Tue, 8 Mar 2016 07:45:16 +0000 (08:45 +0100)]
Remove outdated todos

Change-Id: I6ea10b4f3d183d0c0479e811c81e8bcc8987540b
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoBug 4964: Akka 2.4.1 version bump 41/35441/2
Tom Pantelis [Fri, 26 Feb 2016 02:52:27 +0000 (21:52 -0500)]
Bug 4964: Akka 2.4.1 version bump

The akka/scala version definitions are now in odlparent so removed the
local definitions.

Change-Id: I62cdf60aa1277e4cebebd614fd64b90661d2b8d3
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
8 years agoReimplement NetconfDevice schema setup without recursion 61/35861/1
Andrej Mak [Mon, 7 Mar 2016 07:39:40 +0000 (08:39 +0100)]
Reimplement NetconfDevice schema setup without recursion

Change-Id: I2a41f9a46b8d545efa2c854b024f3a8b9707afa9
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAdd description to northbound notification yang files 82/35782/1
Andrej Mak [Fri, 4 Mar 2016 11:59:33 +0000 (12:59 +0100)]
Add description to northbound notification yang files

Change-Id: Ia781f407d25a320ccb8d8d0ac7dfd005d85b25c2
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAdd netconf message to error info 76/35776/1
Andrej Mak [Fri, 4 Mar 2016 11:19:23 +0000 (12:19 +0100)]
Add netconf message to error info

Change-Id: I04acab3aaf1203cdbcd4c14ce0919e0796ec1448
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAdd javadoc link in LoginPassword 66/35766/1
Andrej Mak [Fri, 4 Mar 2016 09:30:26 +0000 (10:30 +0100)]
Add javadoc link in LoginPassword

Change-Id: I0e3e5fc53c9906c84dcdb89c48e92c4d6ffcaa3b
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoRemove outdated fixme 72/35672/1
Andrej Mak [Thu, 3 Mar 2016 08:57:48 +0000 (09:57 +0100)]
Remove outdated fixme

fixme is outdated, because method registerNotificationListener
can't handle notification streams

Change-Id: I04ca099afa2a573c669846d1a19f273fe39fe40c
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAvoid relying on the timezone 27/35627/1
Stephen Kitt [Wed, 2 Mar 2016 20:51:35 +0000 (12:51 -0800)]
Avoid relying on the timezone

new Date(0) returns 1970-01-01 GMT, so running this test with a
default timezone West of GMT fails (the YANG revision is 1969-12-31).
Initialising the date using Calendar avoids this.

Change-Id: Ib335f370f18f28e041509210e8eb1467a489862c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
8 years agoCode cleanup: unify writeNormalizedNode functionality 38/35238/4
Andrej Mak [Fri, 19 Feb 2016 13:13:54 +0000 (14:13 +0100)]
Code cleanup: unify writeNormalizedNode functionality

Change-Id: Ib33ff258cf55bd7381eccd95364d40c60c463dad
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoMerge "Fix EXI fidelity parsing"
Tomas Cere [Wed, 2 Mar 2016 02:54:57 +0000 (02:54 +0000)]
Merge "Fix EXI fidelity parsing"

8 years agoUse java 8 DateTimeFormatter in NetconfServerSession 67/35567/1
Andrej Mak [Tue, 1 Mar 2016 09:32:05 +0000 (10:32 +0100)]
Use java 8 DateTimeFormatter in NetconfServerSession

Change-Id: If20cd4584a914ec7e54043fe317b9a467b0ad1a5
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoReference yangtools via feature instead of bundles. 63/35563/1
Andrej Mak [Tue, 1 Mar 2016 08:02:39 +0000 (09:02 +0100)]
Reference yangtools via feature instead of bundles.

Change-Id: Ib653fe160dd6806c9b44e8eb64c589e6eed308b7
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoUse transaction chain in SalNodeWriter 39/35039/5
Andrej Mak [Thu, 18 Feb 2016 14:45:42 +0000 (15:45 +0100)]
Use transaction chain in SalNodeWriter

Change-Id: Ida9a129e1f78207f6e00078b83cf802610cde316
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoMerge "More netconf-topology module unit tests"
Tomas Cere [Thu, 25 Feb 2016 13:33:19 +0000 (13:33 +0000)]
Merge "More netconf-topology module unit tests"

8 years agoMore netconf-topology module unit tests 40/35140/7
Jakub Morvay [Tue, 9 Feb 2016 10:32:26 +0000 (11:32 +0100)]
More netconf-topology module unit tests

Change-Id: Ia21f9c94a28c037b38b7f9ed006bdf514ff3f272
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
8 years agoUse SchemaOrderedNormalizedNodeWriter from yangtools. 26/35326/3
Andrej Mak [Tue, 23 Feb 2016 07:50:28 +0000 (08:50 +0100)]
Use SchemaOrderedNormalizedNodeWriter from yangtools.

Change-Id: I005d05d40bb0d505b0a8d8056ee8f945223fbbbc
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAdd javadoc for messagebus-netconf 04/35204/2
Andrej Mak [Mon, 22 Feb 2016 14:51:03 +0000 (15:51 +0100)]
Add javadoc for messagebus-netconf

Change-Id: I02d2e432f10ae52886ba186da5e5f3bd0aef5438
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoFix EXI fidelity parsing 35/35135/5
Robert Varga [Sat, 20 Feb 2016 16:10:34 +0000 (17:10 +0100)]
Fix EXI fidelity parsing

The fidelity elements are stored in a container, look them up in it.

Change-Id: I94c4f11ce469d9c1316a561facb9b269dc47d27a
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
8 years agoRemove opendaylight directory 94/35194/1
Robert Varga [Mon, 22 Feb 2016 13:43:36 +0000 (14:43 +0100)]
Remove opendaylight directory

Move netconf/restconf components to toplevel.

Change-Id: I15c972dbf74209ce6dd7cfad1965441b5d427bb8
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
8 years agoFix netconf-connector-config groupId 93/35193/1
Robert Varga [Fri, 19 Feb 2016 20:52:55 +0000 (21:52 +0100)]
Fix netconf-connector-config groupId

The groupId got changed by accident, fix that up.

Change-Id: Ifdbd0d2e2bd8aae943768ff06d041327f259eb00
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
8 years agoMerge "Added initial design documentation for clustering."
Tomas Cere [Mon, 22 Feb 2016 13:23:45 +0000 (13:23 +0000)]
Merge "Added initial design documentation for clustering."

8 years agoAdded initial design documentation for clustering. 52/27052/8
Tony Tkacik [Wed, 16 Sep 2015 14:57:14 +0000 (16:57 +0200)]
Added initial design documentation for clustering.

Change-Id: I24e6054b31f633e0bdde81ff2493fb418912fb8e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoRework netconf build wiring 24/35124/14
Robert Varga [Fri, 19 Feb 2016 20:52:55 +0000 (21:52 +0100)]
Rework netconf build wiring

This cleans up the dependecies between build units, speeding up the
build process and removing unneeded directives.

Change-Id: I5a2e63132808c0bfe80c71327fe362672ac1e1d5
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
8 years agoBump powermock to 1.6.4 88/35188/1
Robert Varga [Mon, 22 Feb 2016 12:17:03 +0000 (13:17 +0100)]
Bump powermock to 1.6.4

powermock 1.5 is not compatible with mockito 1.10.x, bump it up.

Change-Id: I1eaf35458707554d274733bd5850b31ee146e321
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
8 years agoFix a few warnings 26/35126/3
Robert Varga [Sat, 20 Feb 2016 01:18:50 +0000 (02:18 +0100)]
Fix a few warnings

Do not instantiate DocumentImpl
Add generic type arguments
Make a method static

Change-Id: I0a7cc2450c48693f375da0287eafd379a99a200a
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
8 years agoAdd unit test for netconf-messagebus 83/34883/5
Andrej Mak [Thu, 18 Feb 2016 09:48:33 +0000 (10:48 +0100)]
Add unit test for netconf-messagebus

Change-Id: I610efbd044f99aa359614bc90c11c70bcf5c23c7
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAdd ietf-type-util to netconf-api feature 98/35098/2
Tomas Cere [Fri, 19 Feb 2016 14:30:41 +0000 (15:30 +0100)]
Add ietf-type-util to netconf-api feature

Change-Id: Ia464341b7291145554f8c2b4566c3320ee644663
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoMerge "Fix netconf-messagebus join-topic"
Tomas Cere [Fri, 19 Feb 2016 14:37:26 +0000 (14:37 +0000)]
Merge "Fix netconf-messagebus join-topic"

8 years agoMerge "Add NetconfDeviceSalProvider.MountInstance unit test"
Tomas Cere [Fri, 19 Feb 2016 10:43:30 +0000 (10:43 +0000)]
Merge "Add NetconfDeviceSalProvider.MountInstance unit test"

8 years agoFix netconf-messagebus join-topic 60/34760/3
Andrej Mak [Tue, 16 Feb 2016 14:35:28 +0000 (15:35 +0100)]
Fix netconf-messagebus join-topic

NetconfEventSource - notification pattern is already regex
NotificationTopicRegistration - fix checkNotificationPath()

Change-Id: I69c756f322677eb339d9602da456090619bfc75e
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoUse NormalizedNodeInputOutput to get the writer/reader we need 49/35049/2
Tomas Cere [Fri, 19 Feb 2016 09:40:17 +0000 (10:40 +0100)]
Use NormalizedNodeInputOutput to get the writer/reader we need

Change-Id: I774e5677fd3c31afc6c43860e8839d43f549c843
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoMerge "BUG 5269: Allow capability override in topology"
Tony Tkacik [Wed, 17 Feb 2016 09:32:43 +0000 (09:32 +0000)]
Merge "BUG 5269: Allow capability override in topology"

8 years agoMerge "Bug 5346: Add odl-config-netty to odl-netconf-client"
Tony Tkacik [Tue, 16 Feb 2016 16:09:29 +0000 (16:09 +0000)]
Merge "Bug 5346: Add odl-config-netty to odl-netconf-client"

8 years agoMerge "Delete unused classes in mdsal-netconf-monitoring"
Tomas Cere [Tue, 16 Feb 2016 13:36:23 +0000 (13:36 +0000)]
Merge "Delete unused classes in mdsal-netconf-monitoring"

8 years agoMerge "BUG-5269 Enable device capabilities override"
Tomas Cere [Tue, 16 Feb 2016 13:32:44 +0000 (13:32 +0000)]
Merge "BUG-5269 Enable device capabilities override"

8 years agoMerge "Add mdsal-netconf-monitoring unit test."
Tomas Cere [Tue, 16 Feb 2016 12:23:41 +0000 (12:23 +0000)]
Merge "Add mdsal-netconf-monitoring unit test."

8 years agoMerge "Add unit tests for sal-netconf-connector"
Tomas Cere [Tue, 16 Feb 2016 11:55:34 +0000 (11:55 +0000)]
Merge "Add unit tests for sal-netconf-connector"

8 years agoBug 5346: Add odl-config-netty to odl-netconf-client 44/34744/1
Vratko Polak [Mon, 15 Feb 2016 14:12:46 +0000 (15:12 +0100)]
Bug 5346: Add odl-config-netty to odl-netconf-client

Feature odl-netconf-client applies 01-netconf.xml config file,
which expects capabilities provided by config file 00-netty.xml
from odl-config-netty feature. But odl-config-netty is not part of
odl-config-all feature, so it needs to be specified directly.

Also, added more specific capability dependency to 01-netconf.xml
and updated dependencies for netconf features pom.xml

Change-Id: Idb8aa24e7adeecd1d6a7d9bee8fb0d8006828831
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
8 years agoBUG 5269: Allow capability override in topology 68/34668/1
Tomas Cere [Mon, 15 Feb 2016 13:06:29 +0000 (14:06 +0100)]
BUG 5269: Allow capability override in topology

Previous patch was for cfg subsystem configuration only,
this adds the ability to override devices capabilites
to netconf connectors configured through topology.

Also fix typo in UserPreferences.

Change-Id: Icea2ab162424e4490c7c33be16f4ab14cc4ae1ab
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoBUG-5269 Enable device capabilities override 92/32192/7
Maros Marsalek [Wed, 6 Jan 2016 14:49:19 +0000 (15:49 +0100)]
BUG-5269 Enable device capabilities override

So far, merge was the dafult strategy. From now on, override
is also possible.

Useful when it's necessary to completely replace device models
with user/app models.

Change-Id: I4b1bb68b8257e4a6889f54f7be0e6baee5d7617d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
(cherry picked from commit 552cd5ad81b9cda47978e34414ccf3a80e84f872)

8 years agoAdd mdsal-netconf-monitoring unit test. 59/34659/1
Andrej Mak [Mon, 15 Feb 2016 08:15:17 +0000 (09:15 +0100)]
Add mdsal-netconf-monitoring unit test.

Change-Id: Ib34fb86047416feb533df7f4c0975432419ac453
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoBUG-3934 Don't omit updated data from notification 49/34549/1
Maros Marsalek [Wed, 10 Feb 2016 15:08:51 +0000 (16:08 +0100)]
BUG-3934 Don't omit updated data from notification

Change-Id: Ifa17cbe53084ee3e6d6357bd7805bfd1bf1a5b8a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
(cherry picked from commit dd372317e81e9a545b1a7d70e6e1db319ec2e3f3)

8 years agoAdd ietf-netconf-monitoring-extension to base schema 42/34542/1
Andrej Mak [Fri, 12 Feb 2016 11:08:38 +0000 (12:08 +0100)]
Add ietf-netconf-monitoring-extension to base schema

Monitoring extension must be present in base schema context
to be able to call get-schema to download models from device.

Change-Id: Idcfa7295dd0b5fe29cb26b560f6d058ee6a08f70
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAdd NetconfDeviceSalProvider.MountInstance unit test 37/34537/1
Andrej Mak [Fri, 12 Feb 2016 09:33:34 +0000 (10:33 +0100)]
Add NetconfDeviceSalProvider.MountInstance unit test

Change-Id: Idf300271b07c14e838d9e5f8d0af0035828ec451
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoMerge "Bug 4100 - Extend sal-netconf-connector base schema context"
Tomas Cere [Fri, 12 Feb 2016 09:02:26 +0000 (09:02 +0000)]
Merge "Bug 4100 - Extend sal-netconf-connector base schema context"

8 years agoMerge "bug 5096 Clean up transaction in case of failure"
Tomas Cere [Fri, 12 Feb 2016 09:00:24 +0000 (09:00 +0000)]
Merge "bug 5096 Clean up transaction in case of failure"

8 years agoBug 2806 - Immediate and infinite reconnect attempts during negotiation 07/34407/4
Jakub Morvay [Thu, 4 Feb 2016 10:19:09 +0000 (11:19 +0100)]
Bug 2806 - Immediate and infinite reconnect attempts during negotiation

Set connection to success, after successful netconf negotiation.

Change-Id: Id044b618c3f996d4e93df2a2537ea7e905717477
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
8 years agoBug 4100 - Extend sal-netconf-connector base schema context 58/33758/6
Andrej Mak [Fri, 29 Jan 2016 10:09:35 +0000 (11:09 +0100)]
Bug 4100 - Extend sal-netconf-connector base schema context

In case, that device supports notifications, but doesn't provide
model for them, model from BaseSchema in NetconfMessageTransformer
will be used as fallback.

Change-Id: Ib058ea07a8a457dd83ed98c6d91e21976a0d8ffb
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoAdd unit tests for sal-netconf-connector 72/34372/3
Andrej Mak [Wed, 10 Feb 2016 08:21:19 +0000 (09:21 +0100)]
Add unit tests for sal-netconf-connector

Change-Id: I3bf4981042e61587bcec6e9ac122a5a7a9bba99c
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agobug 5096 Clean up transaction in case of failure 89/34089/3
Andrej Mak [Thu, 4 Feb 2016 15:03:54 +0000 (16:03 +0100)]
bug 5096 Clean up transaction in case of failure

In case of transaction fail, clean up failed transaction,
so it is posible to start new. Add more detailed error message.

Change-Id: I2ea39cc37994175974108cbf8e1afdbd9a3a2282
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoDelete unused classes in mdsal-netconf-monitoring 35/33535/3
Andrej Mak [Mon, 25 Jan 2016 15:45:54 +0000 (16:45 +0100)]
Delete unused classes in mdsal-netconf-monitoring

Delete unused class and replace anonymous class in
NetconfMdsalMonitoringMapperModule with static nested class.

Move duplicated code from NetconfMonitoringOperationServiceFactory and NetconfMdsalMonitoringMapperModule to abstract class AbstractNetconfOperationServiceFactory

Change-Id: Ic1d5122cfb6c51a72a244ec26e73d94f61777cc8
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoMerge "Extract duplicated code to superclass"
Maros Marsalek [Wed, 10 Feb 2016 08:32:00 +0000 (08:32 +0000)]
Merge "Extract duplicated code to superclass"

8 years agoNetconf-topology module unit tests 11/34311/8
Jakub Morvay [Tue, 9 Feb 2016 10:32:26 +0000 (11:32 +0100)]
Netconf-topology module unit tests

Change-Id: I8258ce4973758ef20d503712147e34ee78a1cd95
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
8 years agoMerge "Fix tests according to review comments."
Maros Marsalek [Tue, 9 Feb 2016 14:49:43 +0000 (14:49 +0000)]
Merge "Fix tests according to review comments."

8 years agoFix tests according to review comments. 22/34322/1
Andrej Mak [Tue, 9 Feb 2016 13:39:15 +0000 (14:39 +0100)]
Fix tests according to review comments.

https://git.opendaylight.org/gerrit/#/c/33949/
https://git.opendaylight.org/gerrit/#/c/33972/
https://git.opendaylight.org/gerrit/#/c/33849/

Change-Id: I4c9119bfe19d1c60ca61e0e40832bcf444b7463d
Signed-off-by: Andrej Mak <andmak@cisco.com>
8 years agoMerge "BUG 5089: Fix incorrect slave schema repo behaviour"
Maros Marsalek [Tue, 9 Feb 2016 13:06:47 +0000 (13:06 +0000)]
Merge "BUG 5089: Fix incorrect slave schema repo behaviour"

8 years agoMerge "Ignore netconf tools from sonar report"
Maros Marsalek [Tue, 9 Feb 2016 12:22:41 +0000 (12:22 +0000)]
Merge "Ignore netconf tools from sonar report"

8 years agoMerge "NetconfOperationRouterImpl unit test."
Maros Marsalek [Tue, 9 Feb 2016 12:17:45 +0000 (12:17 +0000)]
Merge "NetconfOperationRouterImpl unit test."

8 years agoMerge "Add AggregatedNetconfOperationServiceFactory unit test."
Maros Marsalek [Tue, 9 Feb 2016 11:57:00 +0000 (11:57 +0000)]
Merge "Add AggregatedNetconfOperationServiceFactory unit test."

8 years agoMerge "Move NetconfHelloMessage to netconf-api"
Maros Marsalek [Tue, 9 Feb 2016 11:24:11 +0000 (11:24 +0000)]
Merge "Move NetconfHelloMessage to netconf-api"

8 years agoMerge "NetconfMonitoringServiceImpl unit test"
Maros Marsalek [Tue, 9 Feb 2016 10:48:03 +0000 (10:48 +0000)]
Merge "NetconfMonitoringServiceImpl unit test"

8 years agoBUG 5089: Fix incorrect slave schema repo behaviour 59/34259/1
Tomas Cere [Mon, 8 Feb 2016 12:49:11 +0000 (13:49 +0100)]
BUG 5089: Fix incorrect slave schema repo behaviour

Need to use the correct schema repo in slave schema providers.
Introduced by the patch for BUG 4577.

Change-Id: Iba64841ba0f2f875f4da455cb3025266cf7b6c5e
Signed-off-by: Tomas Cere <tcere@cisco.com>
8 years agoMerge "Remove obsolete FIXMEs"
Tony Tkacik [Mon, 8 Feb 2016 09:29:26 +0000 (09:29 +0000)]
Merge "Remove obsolete FIXMEs"

8 years agoBug 5175: RPC called on mount point not being correctly handled when multiple revisio... 83/33983/1
adetalhouet [Wed, 3 Feb 2016 14:04:40 +0000 (09:04 -0500)]
Bug 5175: RPC called on mount point not being correctly handled when multiple revision-date coexist

 The ControllerContext#toQname was just looking for module using the module name. In scenarios where you have multiple revision for the same module, the method was returning the latest schema. This fix is to retreive the schema based on the revision date

Change-Id: Ie1f3ae1b6c4e6fd7133f64f3f5e7c8899c42db5a
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>