Jozef Gloncak [Mon, 30 Jun 2014 13:58:56 +0000 (15:58 +0200)]
BUG 1082 Migrate sal-rest-connector to Async Data Broker API
Rework of sal-rest-connector project to support Async Data Broker API
Change-Id: I73804418a04445b236d12693e493a11850dd94dd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Moiz Raja [Thu, 31 Jul 2014 14:19:12 +0000 (14:19 +0000)]
Merge "broken build - missing implementation of method getAnyXmlNodeSerializer"
Jozef Gloncak [Thu, 31 Jul 2014 13:47:40 +0000 (15:47 +0200)]
broken build - missing implementation of method getAnyXmlNodeSerializer
Change-Id: Ib7f22015462cb224e11c3c267cfbac7627eeb800
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ed Warnicke [Wed, 30 Jul 2014 12:05:21 +0000 (12:05 +0000)]
Merge "Serialization/Deserialization and a host of other fixes"
Moiz Raja [Thu, 10 Jul 2014 10:39:22 +0000 (03:39 -0700)]
Serialization/Deserialization and a host of other fixes
- Hande Cluster MemberUp and MemberRemoved events in ShardManager
- Cohort messages and close listener messages switched
to use protobuff
- Distributed Datastore switch messages to use protobuff
CreateTransaction
CreateTransactionReply
CreateTransactionChain
CreateTransactionChainReply distributed datastore messages
switched to protobuff
- ShardManager messages switch to protobuff
- DataChanged and other messages switch to protobuf in
distributed datastore
- Fixed few things found during testing
1. ShardStrategy - setting of configuration
2. NodeToNormalizedNodeBuilder - leaf node/leafsetentry node checks
3. DataChanged event - passing of scope instanceidentifier used during deserialization
- Introducing JMX MBeans for distributed datastore
-Fixed issues which were preventing remote Shards from talking to each other
- Fixed a number of issues related to deserialization
- Add distributed datastore to the build
- Switch from InstanceIdentifier to YangInstanceIdentifier
Change-Id: I0d15dc482cb2b0fb2170b1344bad9fa3b421e8e0
Signed-off-by: Moiz Raja <moraja@cisco.com>
Robert Varga [Tue, 29 Jul 2014 10:15:49 +0000 (12:15 +0200)]
BUG-1092: adjust to YangInstanceIdentifier
This is a compation to I1e30a0df93d8bfb891d047c58abcb117d4006c76,
adjusting the components to use the new name.
Change-Id: I615763240581e850f7752f82e44d752c8fceb169
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 29 Jul 2014 10:48:46 +0000 (10:48 +0000)]
Merge changes I1d768b2b,I9302e88a
* changes:
Fix identity-ref serialization in netconf.
BUG-1083 Netconf connector rework sal facade.
Tony Tkacik [Tue, 29 Jul 2014 09:29:39 +0000 (09:29 +0000)]
Merge changes Ifd28301d,I38220acb,I9bad24df
* changes:
WIP: Backwards compatible MountPointService
Fix children element lookup in XmlElement
Fix config attributes with same names for different modules.
Tony Tkacik [Tue, 29 Jul 2014 08:04:05 +0000 (08:04 +0000)]
Merge changes I442a0ee9,I11825b90
* changes:
Fix a typo
BUG-1281: call static methods
Maros Marsalek [Mon, 28 Jul 2014 08:33:33 +0000 (10:33 +0200)]
Fix identity-ref serialization in netconf.
Identity-ref attributes did not contain their namespace.
Change-Id: I1d768b2b59073d9fa322b66b002eddf39270bf17
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Fri, 25 Jul 2014 11:13:47 +0000 (13:13 +0200)]
Fix children element lookup in XmlElement
Change-Id: I38220acbfedf8f1b8554516f6abda4c1a16dd2ee
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Mon, 28 Jul 2014 19:31:45 +0000 (21:31 +0200)]
Fix a typo
Just a test name fix.
Change-Id: I442a0ee951475fb247eca4117ad61ed315a39dfc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 28 Jul 2014 19:11:36 +0000 (21:11 +0200)]
BUG-1281: call static methods
This is just a cleanup of warnings.
Change-Id: I11825b90b415c77074ff8684feaba918876e0c95
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 28 Jul 2014 15:05:01 +0000 (15:05 +0000)]
Merge "Wiring rest-connector with config subsytem."
Tony Tkacik [Mon, 28 Jul 2014 15:02:06 +0000 (15:02 +0000)]
Merge "Improve RESTCONF QName parsing speed"
Ed Warnicke [Thu, 24 Jul 2014 19:12:18 +0000 (14:12 -0500)]
Wiring rest-connector with config subsytem.
Change-Id: If826bb7352101833acd288b81cbcf7cec2f28b43
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:32:53 +0000 (06:32 +0200)]
Improve RESTCONF QName parsing speed
SchemaContext provides useful (and optimized) methods for looking up
modules. Eliminate home-grown version of findModuleByName(). Requires
https://git.opendaylight.org/gerrit/#/c/9351/ .
Change-Id: I4c4e07e23a614b46b01a87485965af0c066aa693
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 28 Jul 2014 08:56:53 +0000 (08:56 +0000)]
Merge "Optimize RESTCONF module/node parsing"
Tony Tkacik [Mon, 28 Jul 2014 08:56:39 +0000 (08:56 +0000)]
Merge "Improve RESTCONF thread safety when reconfiguring"
Tony Tkacik [Mon, 28 Jul 2014 08:56:15 +0000 (08:56 +0000)]
Merge "Allow getChildNodes() to become a Collection"
Robert Varga [Sat, 26 Jul 2014 04:41:44 +0000 (06:41 +0200)]
Optimize RESTCONF module/node parsing
Profiling has shown that the current implementations are still not upto
par with what they should be: 189 invocations of the two consumed 64ms,
with most of the time being spent splitting and iterating.
Given that the parsing operation is really simple, we can do much better
using String.indexOf() and String.substring().
Change-Id: I06ef0403edb2c8d12cbbc3c7909091e9efc5138e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:18:40 +0000 (06:18 +0200)]
Improve RESTCONF thread safety when reconfiguring
There is a race which could see us without a populated mapping while a
schemacontext change is underway. Use a immutablemap guarded by an
atomicreference to allow proper switching. Note that the fix is
incomplete, as the schema context needs to be replaced at the same time.
Change-Id: I7d64fae99a0bc0f7d1ec19f08450c1954cb7af97
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:06:52 +0000 (06:06 +0200)]
Allow getChildNodes() to become a Collection
Preparatory patch for yangtools change -- getChildNodes() will start
returning a Collection, not a Set.
Change-Id: Ie7255757e3f48465e3acd9e65764f1b79a3a9511
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Thu, 24 Jul 2014 11:43:09 +0000 (13:43 +0200)]
Make DOMMountPointService listenable
Change-Id: Ic44a4bf214f6f6a6d653627b6a62ab2f47bd9963
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Jozef Gloncak [Wed, 23 Jul 2014 11:55:21 +0000 (13:55 +0200)]
BUG 1144 - response 500 instead of 400
RestconfDocumentedException with error tag INVALID_VALUE (400) was caught and
wrapped to RestconfDocumentedException with error tag OPERATION_FAILED
(500)
Change-Id: I0ad75958e0d8e25d5bf1bdf7cbac5f855cc2b03d
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Jul 2014 07:06:11 +0000 (09:06 +0200)]
BUG 1379 - rpcs behind yang-ext:mount aren't always executed
new corrected behavior:
If rpc is from device behing yang-ext:mount and it doesn't exist in
controller then it is ALSO executed.
Change-Id: Ieebf2522b39cd42a8da57b05cf49e528c924f7ba
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 11:48:03 +0000 (13:48 +0200)]
Fixed incorrect XML test suites & Usage of removed API
Change in underlying YANG Tools codec, unvereded
that there were test-suites which did string
comparison for testing of XML responses and
any change in XML serialization (valid from
XML point-of-view) triggered this tests to
fail.
Reworked offending tests to use XML W3C Document
for testing instead of string comparison and regexes.
Change-Id: Ib6e35e8d2fe79275666235370d1dda461277a59f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 09:40:53 +0000 (09:40 +0000)]
Merge "BUG 1387 - degrade log output from info to debug"
Jozef Gloncak [Mon, 21 Jul 2014 08:48:29 +0000 (10:48 +0200)]
BUG 1387 - degrade log output from info to debug
Change-Id: Ia98ab154bb53cc3c43f42270a3bd6c65bd9dee65
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 08:08:41 +0000 (08:08 +0000)]
Merge "Bug 1239 - Clean up and refactor netconf-ssh client"
Tony Tkacik [Fri, 18 Jul 2014 09:07:03 +0000 (09:07 +0000)]
Merge "BUG-1384: YangStoreServiceImpl.refresh() should never block"
Tony Tkacik [Fri, 18 Jul 2014 07:33:35 +0000 (07:33 +0000)]
Merge "BUG-1365 Check if channel was closed when negotiation fails"
Robert Varga [Thu, 17 Jul 2014 14:19:32 +0000 (16:19 +0200)]
BUG-1384: YangStoreServiceImpl.refresh() should never block
As descirbed in the bug, we are seeing large amounts of contention on
the monitor when calling refresh(). Rework the safety such that the
refresh path does not block and perform checking for refresh in the
get() path, which is forced to retry should a refresh occur.
With this patch reported contention disappears completely and startup
time is improved by about 8 seconds on stock SP edition.
Change-Id: I4c6109d77324d3d1b700041b54a95dc346e3d372
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Tue, 15 Jul 2014 13:55:34 +0000 (15:55 +0200)]
BUG-1365 Check if channel was closed when negotiation fails
Also set state only if promise is not yet finished.
Replace custom EOM aggregator with implementation provided by netty.
Change-Id: Iffb740fff1512ca14efe58ed5112f74ce5e75c97
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Devin Avery [Wed, 16 Jul 2014 18:31:51 +0000 (18:31 +0000)]
Merge "Deprecated Rpcs and RpcErrors helper classes"
Tomas Olvecky [Thu, 26 Jun 2014 11:18:24 +0000 (13:18 +0200)]
Bug 1239 - Clean up and refactor netconf-ssh client
Remove commented and dead code in netconf-netty-util.
Move SshHandler to client package in order to make it package private.
Wrap OutputStream in SSHClientHandler with a buffer.
Remove VirtualSocketException as it was a workaround for
passing context without checking whether session was established.
Change-Id: I992d3b8ba2b2a58b69bd2e8be4ad0e4bdfa36c01
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Tue, 15 Jul 2014 09:36:11 +0000 (09:36 +0000)]
Merge "BUG-1317 BUG-1351 Fix duplicate connections from netconf connector"
Maros Marsalek [Mon, 14 Jul 2014 16:04:53 +0000 (18:04 +0200)]
BUG-1317 BUG-1351 Fix duplicate connections from netconf connector
Change-Id: I2c3135f3f84ef25f0005744c03003462c96812c1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Jozef Gloncak [Fri, 11 Jul 2014 08:26:07 +0000 (10:26 +0200)]
Apply style rules on whole sal-rest-connector
No changes in function of code, just formatting.
Change-Id: I52bf10a3b84fa61ec35c31145acbbc6b9bf349ec
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
tpantelis [Thu, 10 Jul 2014 06:49:07 +0000 (02:49 -0400)]
Deprecated Rpcs and RpcErrors helper classes
With the new RpcResultBuilder class, we can deprecate the Rpcs and
RpcErrors classes.
Also migrate all uses of the deprecated classes to RpcResultBuilder in
the controller code.
Change-Id: I86408bba0ce19e70c7d7a41555e94052e54e93f8
Signed-off-by: tpantelis <tpanteli@brocade.com>
Tom Pantelis [Fri, 11 Jul 2014 14:55:36 +0000 (14:55 +0000)]
Merge "BUG 1330 - list key counts|values diff in payload and URI"
Tony Tkacik [Fri, 11 Jul 2014 11:35:41 +0000 (11:35 +0000)]
Merge "Introducing simple merge strategy for config subsystem"
Tomas Olvecky [Wed, 9 Jul 2014 13:27:09 +0000 (15:27 +0200)]
Introducing simple merge strategy for config subsystem
MergeEditStrategy wasn't really merging.
Now it is, but only for ObjectName[].
However, since ObjectName[] is 90% of the interesting
cases, this should get us a long way.
This is needed to be able to handle reasonably
extension, with the ability to wire in multiple
extension modules independently, as we need to do
for things like OF extension.
Change-Id: Ieca579cbc6781d77f489f5f754490c8da8f65188
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Thu, 10 Jul 2014 08:04:31 +0000 (08:04 +0000)]
Merge "Bug 1341 - Make RESTConf websocket port configurable"
Jozef Gloncak [Thu, 10 Jul 2014 08:02:00 +0000 (10:02 +0200)]
BUG 1330 - list key counts|values diff in payload and URI
Adds validation whether list key counts or list key values are different
between payload and URI. It difference occures then
RestconfDocumentedException is raised.
Change-Id: I93aaa352cfb8daee298ebf16375cb70987328dbb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Richard Kosegi [Wed, 9 Jul 2014 13:31:05 +0000 (15:31 +0200)]
Bug 1341 - Make RESTConf websocket port configurable
Change-Id: I54f4bcadd864eb264b92f00b82b81489e9ebecf0
Signed-off-by: Richard Kosegi <rkosegi@cisco.com>
Tony Tkacik [Wed, 9 Jul 2014 09:09:32 +0000 (09:09 +0000)]
Merge "Bug 1293 - Switch packaging of config-util to bundle"
Tom Pantelis [Tue, 8 Jul 2014 18:19:55 +0000 (18:19 +0000)]
Merge "BUG 1204 - exception if multiple container node occures"
Ed Warnicke [Tue, 8 Jul 2014 13:36:07 +0000 (13:36 +0000)]
Merge "Add netconf-cli temporary files to .gitignore"
Jozef Gloncak [Tue, 24 Jun 2014 06:13:53 +0000 (08:13 +0200)]
BUG 1204 - exception if multiple container node occures
Container schema node + multiple data nodes ->
exception RestconfDocumentedException is raised.
List schema node + one data node (e. g. in json is specified as container
"list-name":{} and not "list-name":[{},{}...,{}] -> this is acceptable case because
list can have even only one entry.
Leaf schema node + multiple data nodes -> special check whether at
equal objects is everytime uniqe key. If it isn't so then
RestconfDocumentedException is raised. For Json specific JsonParser was
implemented which is catch duplicity at object level an time of parsing.
For XML this duplicity name check is done during normalization phase.
Change-Id: I0b544c015bcf817e82206276bd24c783093308d6
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tomas Olvecky [Tue, 8 Jul 2014 09:17:19 +0000 (11:17 +0200)]
Bug 1293 - Switch packaging of config-util to bundle
Add new bundle to the distribution - config-util, that was previously
packaged as regular jar and copied into where it was required.
Change-Id: I8a28b4a0b19e4dc6cbc2d71e60cf714cca188a84
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tomas Olvecky [Tue, 8 Jul 2014 09:11:40 +0000 (11:11 +0200)]
Add netconf-cli temporary files to .gitignore
Change-Id: Ic5eeab930ad0508a7e373b227d9a814ab4ae0010
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Devin Avery [Mon, 7 Jul 2014 11:04:56 +0000 (11:04 +0000)]
Merge "BUG 1016 - JSON|XML output with|without white chars"
Tony Tkacik [Fri, 4 Jul 2014 09:24:37 +0000 (09:24 +0000)]
Merge "BUG-692 Add log to config persister test."
Tony Tkacik [Fri, 4 Jul 2014 08:27:29 +0000 (08:27 +0000)]
Merge "Adding a method to process Identities in a YANG Model"
Maros Marsalek [Fri, 4 Jul 2014 08:04:15 +0000 (10:04 +0200)]
BUG-692 Add log to config persister test.
Change-Id: Id77d577b2d4ff30531ee5de7b401d21a84944511
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Fri, 4 Jul 2014 07:48:26 +0000 (07:48 +0000)]
Merge "BUG-1041 cli proposal #1"
Jozef Gloncak [Fri, 4 Jul 2014 06:54:34 +0000 (08:54 +0200)]
Adding a method to process Identities in a YANG Model
Change-Id: Ic07025c3c86d847d2882d80fa360e9a5978275df
Signed-off-by: Mayank Agarwal <mayagarw@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 25 Jun 2014 09:16:05 +0000 (11:16 +0200)]
BUG 1016 - JSON|XML output with|without white chars
Pretty print formating can be turned on for XML | JSON output via URI parameter
prettyPrint=true.
In other cases (prettyPrint=false, other value, missing
URI parameter...) XML | JSON output are returned as stream of characters
without white characters.
Example of URI:
http://localhost:8080/restconf/config/opendaylight-inventory:nodes?prettyPrint=true
Change-Id: I459c9663cdf8bfc78b8df67d7338a44d77c18a5c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Thu, 3 Jul 2014 14:36:35 +0000 (14:36 +0000)]
Merge "Bug 1290 - Swagger Documentation is failing to load - java script exception"
Robert Varga [Wed, 2 Jul 2014 20:32:07 +0000 (22:32 +0200)]
BUG-868: donot use deprecated call
WebSocketServerHandshakerFactory.sendUnsupportedVersionResponse() is the
replacement, so use it instead of
sendUnsupportedWebSocketVersionResponse().
Change-Id: I03116f09e757df9694ac077c9e82296eaf19de90
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 2 Jul 2014 19:14:47 +0000 (21:14 +0200)]
BUG-1281: optimize JSON codec
Multiple optimizations made in one go:
- do not use string concatenation for LOG.debug()
- do not use string concatenation in Preconditions.checkState()
- methods which do not need state are made static
- use chars instead of strings where possible
- do not instantiate ArrayList needlessly to access first element in a set
- optimize namespace/localname parsing by not using String.split()
- use Charset constant instead of charset name
Change-Id: If1c4ea50d7d1d2aae4f52d1dc68ff79b901208b0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 2 Jul 2014 18:28:52 +0000 (20:28 +0200)]
BUG-1281: Optimized CompositeNodeWrapper
When wrapping entries, we know how many we will need, so let the
ArrayList know that.
Change-Id: Ic2fc4ef451a5cdc11a8dfebccaf5a1c605e6e66d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 2 Jul 2014 19:28:46 +0000 (21:28 +0200)]
BUG-1281: optimize ListenerAdapter
TransformerFactory should be reused, so that's what we're doing here.
Here we do not cache the transformer, as we are called from datastore
thread, which has essentially no business in this. Same goes for
DocumentBuilderFactory.
Also, the transformation to RFC3339 timestamp was compiling the same
regex over and over, so compile it once and reuse it.
Change-Id: Ia66f42fa123bbb4f86b396520757d9bc28f7b9d2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 2 Jul 2014 19:00:03 +0000 (21:00 +0200)]
BUG-1281: cache TransformerFactory and Transformer
The code used to instantiate a TransformerFactory for each individual
request, where a single factory can be shared between threads as long as
it is not reconfigured.
As a futher optimization, we also create a thread-local cache for
transformers, as they can be use for multiple transformations.
Change-Id: I836148208be62f66cb6b509b0746e9fb92a569f0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 3 Jul 2014 10:49:32 +0000 (10:49 +0000)]
Merge "BUG-1281: optimize ControllerContext"
Tony Tkacik [Thu, 3 Jul 2014 10:49:20 +0000 (10:49 +0000)]
Merge "BUG-1275: drop a marker for follow-up"
Tony Tkacik [Thu, 3 Jul 2014 10:49:05 +0000 (10:49 +0000)]
Merge "BUG-868: Fix a warning in EmptyNodeWrapper"
Devin Avery [Thu, 3 Jul 2014 10:04:07 +0000 (06:04 -0400)]
Bug 1290 - Swagger Documentation is failing to load - java script
exception
Fixed how we generated the json model representing yang union types
Fixed json model naming for nested container types.
To validate:
1) deploy fix, and load http://localhost:8080/apidoc/explorer.
2) Verify the page loads and you can expand
opendaylight-inventory:nodes.
3) Search for "node-connector" and expand a node-connector definition.
Verify that the "port-number" type says "integer or string".
Change-Id: I8aae18ba4805c3ee57cbb655807af4f15ee61756
Signed-off-by: Devin Avery <devin.avery@brocade.com>
Robert Varga [Wed, 2 Jul 2014 19:57:11 +0000 (21:57 +0200)]
BUG-1281: optimize ControllerContext
- use a single instanceof of Splitter
- do not instantiate unneeded collections
- static methods should be static
- do not use string concat in LOG.error()
- do not use String.split()
Change-Id: I16d2232ab2f9ee86f64f7abc95d9b7ce073f0c22
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 2 Jul 2014 20:26:33 +0000 (22:26 +0200)]
BUG-1275: drop a marker for follow-up
This class duplicates a lot of code from yangtools, so a proper middle
ground needs to be found. Drop a FIXME: so we do not forget.
Change-Id: I001c2fae9dbc1d9a13c8e91bb04ad9f3f22eaf1b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 2 Jul 2014 18:29:30 +0000 (20:29 +0200)]
BUG-868: Fix a warning in EmptyNodeWrapper
Simple use of deprecated method to implement the same method. Add
@Deprecated marker to silence the warning.
Change-Id: I274e7afdecdd9ece5b0b8809ad1fee53abbafef3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 2 Jul 2014 15:00:54 +0000 (15:00 +0000)]
Merge "BUG-692 Improve log message when negotiation fails"
Tony Tkacik [Wed, 2 Jul 2014 14:13:27 +0000 (14:13 +0000)]
Merge "BUG-868: remove InstanceIdentifier.getPath() users"
Tony Tkacik [Wed, 2 Jul 2014 14:13:14 +0000 (14:13 +0000)]
Merge changes I38344133,Ib209ceed,I3f643034,I2f4ed366
* changes:
BUG-868: getChildren() has been superseded by getValue()
BUG-868: mark inherited methods as deprecated
BUG-868: remove deprecated use of QName constructors
BUG-868: do not use deprecated InstanceIdentifier methods
Maros Marsalek [Wed, 11 Jun 2014 14:13:03 +0000 (16:13 +0200)]
BUG-1041 cli proposal #1
Generic model based cli for netconf servers.
Command are defined with yang language.
Change-Id: I9da0c764a92707d6ede3853bae021d9df01755d7
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 1 Jul 2014 16:18:44 +0000 (18:18 +0200)]
BUG-868: remove InstanceIdentifier.getPath() users
getPath() has been deprecated. Remove the easily call sites to
getPathArguments().
Change-Id: I2058627301404e28b58851c27d8d8117f48a7b9d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 1 Jul 2014 15:41:16 +0000 (17:41 +0200)]
BUG-868: mark inherited methods as deprecated
These methods are deprecated by the specifying class and we use them
internally. Mark them as deprecated, silencing the warnings.
Change-Id: Ib209ceed988e6407e833e16fafb69c54e350bf75
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 1 Jul 2014 15:38:34 +0000 (17:38 +0200)]
BUG-868: remove deprecated use of QName constructors
Direct instantiation of QName is deprecated, so remove references to
them.
Change-Id: I3f64303469fc655e2adfdac72377bce38439ab78
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 1 Jul 2014 15:21:37 +0000 (17:21 +0200)]
BUG-868: do not use deprecated InstanceIdentifier methods
This removes the use of the deprecated constructor and some of the
getPath() call sites in favor of getPathArguments() and
InstanceIdentifier.create()/.node() methods.
Change-Id: I2f4ed36645408c6f780031d848af829cbe2a40d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Wed, 2 Jul 2014 09:05:28 +0000 (11:05 +0200)]
BUG-692 Improve log message when negotiation fails
Change-Id: I767094a86d989f9c3eb074928b890391d6e53783
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Tue, 1 Jul 2014 16:49:17 +0000 (18:49 +0200)]
Bug 762: Fixed bug in CsSnToXmlTest java.
Change-Id: I5d3621a189bd5609772bf19c1130b13e0a5e53e4
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 1 Jul 2014 09:18:26 +0000 (09:18 +0000)]
Merge "BUG 1211 - deletion non existing target returns 500"
Tony Tkacik [Mon, 30 Jun 2014 08:09:36 +0000 (08:09 +0000)]
Merge "Bug:1253 - Fix NPE in config pusher"
Maros Marsalek [Tue, 24 Jun 2014 11:54:57 +0000 (13:54 +0200)]
BUG-874 Remove rolback cabaility advertised by config netconf
The rollback on error option is not supported by the netconf server endpoint for config subsystem therefore it cannot advertise rollback on error capability.
If it is present in message, the rpc will fail.
Change-Id: If32113aa77d9ef5d614b143741d1d04fbdc0d22d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Jozef Gloncak [Tue, 17 Jun 2014 11:22:24 +0000 (13:22 +0200)]
Bug 484 - Anyxml in sal-rest-connector
- RestconfImpl: handled AnyXmlSchemaNode
- JsonMapper: handled AnyXmlSchemaNode
- CnSnToJsonBasicDataTypesTest: added test cases for anyxml.
This commit depends (therefore is commited as draft) on commits:
- Add Anyxml normalized node to yang-data-api -
https://git.opendaylight.org/gerrit/#/c/7771/1
- Implementation of Anyxml builder -
https://git.opendaylight.org/gerrit/#/c/8061/
Change-Id: Ib3da88cc6af96d98d139f7c1bbc94408ef9e814d
Signed-off-by: tpantelis <tpanteli@brocade.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tomas Olvecky [Fri, 27 Jun 2014 09:38:37 +0000 (11:38 +0200)]
Bug:1253 - Fix NPE in config pusher
Add better error message when ConfigSnapshotHolder contract is voilated.
Fix
org.opendaylight.controller.config.persist.storage.file.xml.model.ConfigSnapshot
to return empty set instead of null in getCapabilities()
Change-Id: I9783cccbe53ae69e322e1d5660ad1f3b52b007fa
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Jozef Gloncak [Tue, 24 Jun 2014 12:29:50 +0000 (14:29 +0200)]
BUG 1211 - deletion non existing target returns 500
It is checked whether data at specified path exists (via method
readConfigurationData). If it isn't so then HTTP response returning code
is set to 200.
Change-Id: I0c0f51c144ffc430ac5bcef118f485f84ae25207
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Wed, 25 Jun 2014 09:51:20 +0000 (09:51 +0000)]
Merge "Bug:1238 - Revert changes to SshClientAdapter."
Tony Tkacik [Wed, 25 Jun 2014 09:48:07 +0000 (09:48 +0000)]
Merge "BUG 1179 - rpcResult = false but response 200"
Jozef Gloncak [Mon, 23 Jun 2014 08:59:15 +0000 (10:59 +0200)]
BUG 1179 - rpcResult = false but response 200
Case for case when collection of errors is returned was added to
RestPostOperationTest.
Change-Id: Iea6c830d957001b01996e2640d8869105cf805ca
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tomas Olvecky [Tue, 24 Jun 2014 10:57:14 +0000 (12:57 +0200)]
Bug:1238 - Revert changes to SshClientAdapter.
Fix bug introduced in
412e6b4 by reverting back to previous state.
Also fix a resource leak in writeImpl.
Change-Id: If43741071d1471280491888078f342bc33269c5f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Tue, 24 Jun 2014 09:08:25 +0000 (09:08 +0000)]
Merge "Bug 1176: Lower log level when netconf ssh connection fails"
Tony Tkacik [Tue, 24 Jun 2014 07:34:49 +0000 (07:34 +0000)]
Merge "BUG 484 - XmlReader improve readability"
Tony Tkacik [Tue, 24 Jun 2014 07:18:05 +0000 (07:18 +0000)]
Merge "Fix netconf ssh client"
Vaishali Mithbaokar [Thu, 19 Jun 2014 21:48:44 +0000 (14:48 -0700)]
But 1129: Removing hard coded versions from MD-SAL
Change-Id: Ic4ea06f1fd644808946dd5111d38152d19b9bf35
Signed-off-by: Vaishali Mithbaokar <vmithbao@cisco.com>
Ed Warnicke [Mon, 23 Jun 2014 20:17:53 +0000 (20:17 +0000)]
Merge "BUG 1129:Removed hard coded version from netconf project as part of the automated release changes for controller"
Tony Tkacik [Mon, 23 Jun 2014 15:48:17 +0000 (15:48 +0000)]
Merge "BUG-961 Fix Resource leak error from netty."
Jozef Gloncak [Mon, 16 Jun 2014 11:43:38 +0000 (13:43 +0200)]
BUG 484 - XmlReader improve readability
- XmlReader - improve readibility of methods isSimple(Composite) node by
extracting common logic to method skipCommentsAndWhitespace.
The change comes from patch set
https://git.opendaylight.org/gerrit/#/c/7337/9
which was originally commited by Tom Pantelis. In this commit is selected
only one change which doesn't relate with BUG 484
Change-Id: Icef852da20e8f624b4bc3d61e334d88f4766474d
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Mon, 23 Jun 2014 08:18:59 +0000 (10:18 +0200)]
Bug 1231 - fix of broken tests in sal-rest-connector
Dummy values were added to places where null values as SchemaPath were
presented.
Change-Id: I1a7d109ec4b9dfa24ef77adfc7aa9ccff74482c1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>