bgpcep.git
9 years agoMerge "Fixed various small bugs found by Findbugs plugin."
Robert Varga [Sat, 26 Jul 2014 15:09:14 +0000 (15:09 +0000)]
Merge "Fixed various small bugs found by Findbugs plugin."

9 years agoMerge "Add defensive checks when looking up attributes"
Dana Kutenicsova [Sat, 26 Jul 2014 08:36:49 +0000 (08:36 +0000)]
Merge "Add defensive checks when looking up attributes"

9 years agoFixed various small bugs found by Findbugs plugin. 35/9335/3
Dana Kutenicsova [Fri, 25 Jul 2014 21:27:46 +0000 (23:27 +0200)]
Fixed various small bugs found by Findbugs plugin.

Change-Id: I343625bdb9efd2c0ffdfc12f6c0c9119f377041c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge changes I6723f9e0,Iab4269dc
Dana Kutenicsova [Fri, 25 Jul 2014 15:05:42 +0000 (15:05 +0000)]
Merge changes I6723f9e0,Iab4269dc

* changes:
  BUG-731: registration no longer throw exceptions
  Improve message writing performance

9 years agoBUG-1287 : fixed pcep/programming configs. 18/9318/2
Dana Kutenicsova [Fri, 25 Jul 2014 13:07:38 +0000 (15:07 +0200)]
BUG-1287 : fixed pcep/programming configs.

Change-Id: Ia202bf4afdcc152e3862d007781123774abef4fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-731: registration no longer throw exceptions 17/9317/1
Robert Varga [Fri, 25 Jul 2014 12:43:46 +0000 (14:43 +0200)]
BUG-731: registration no longer throw exceptions

Since the registrations do not throw them, we can simplify our code,
ridding us of a warning.

Change-Id: I6723f9e09d7419f768f80affea0708439f34c8df
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoImprove message writing performance 64/9264/3
Robert Varga [Wed, 23 Jul 2014 16:00:47 +0000 (18:00 +0200)]
Improve message writing performance

The advice is to use the context for writing, so let's do precisely
that.

Change-Id: Iab4269dc140f4bfe22753e421feccf8cbe7bce78
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoReport IllegalArgument instead of IllegalState 08/9108/4
Robert Varga [Thu, 17 Jul 2014 09:16:43 +0000 (11:16 +0200)]
Report IllegalArgument instead of IllegalState

This is wrong input, not internal state.

Change-Id: I8a0d459a308f309229cf55955be3a77604d47a1d
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-1287: migrate pcep-topology-provider"
Dana Kutenicsova [Thu, 24 Jul 2014 15:30:07 +0000 (15:30 +0000)]
Merge "BUG-1287: migrate pcep-topology-provider"

9 years agoBUG-1394: do not read in tight loops 75/9275/4
Robert Varga [Thu, 24 Jul 2014 03:25:17 +0000 (05:25 +0200)]
BUG-1394: do not read in tight loops

We want to make sure we give writes a chance to complete before reading
again. Lower the amount of processing we do per loop to a single
message.

Change-Id: Iecf029afd2c2ae0288c5c483569e9acff7545a64
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1287: migrate pcep-topology-provider 75/9075/7
Milos Fabian [Mon, 21 Jul 2014 06:25:30 +0000 (08:25 +0200)]
BUG-1287: migrate pcep-topology-provider

-fixed config tests
-ParserToSalTest uses AbstractDataBrokerTest

Change-Id: I93f20d32cce9fbd6dead2a0b181d4852f41181db
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-1287: migrate programming-impl 76/9076/8
Milos Fabian [Sun, 20 Jul 2014 14:45:27 +0000 (16:45 +0200)]
BUG-1287: migrate programming-impl

-fixed config tests to use new md-sal configuration
-ProgrammingServiceImplTest uses AbstractDataBroker test instead of mocked DataBroker

Change-Id: I6b0b110c9a61253f8ab17b6ca9f7fb44bf218460
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "BUG-1394: add traces"
Dana Kutenicsova [Wed, 23 Jul 2014 08:33:08 +0000 (08:33 +0000)]
Merge "BUG-1394: add traces"

9 years agoAdd defensive checks when looking up attributes 89/9189/3
Robert Varga [Mon, 21 Jul 2014 08:37:22 +0000 (10:37 +0200)]
Add defensive checks when looking up attributes

Lookup of attributes is made more hardened, so we do not lose prefixes,
but only attributes in things go south.

Also adds an explicit argument check for null objectType to track down a
NPE we have been hitting.

Change-Id: I2eacc5c66cac747e1ebeb9d88367dcd1e4ea9281
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1394: add traces 62/9162/3
Robert Varga [Fri, 18 Jul 2014 15:24:18 +0000 (17:24 +0200)]
BUG-1394: add traces

It seems that when we are processing a PCRpt, the request should already
be in the queue, but we are failing to find it. This should not occur,
so let's add some traces to pinpoint it.

Change-Id: I5c8ee574ab1c95fc25d465374a26a944ecc0b2ce
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMigrate to use tcpmd5 code in its new place 87/9187/5
Robert Varga [Sun, 20 Jul 2014 22:22:22 +0000 (00:22 +0200)]
Migrate to use tcpmd5 code in its new place

The TCP-MD5 has been bigrate into its own project and thus lives in new
artifacts, new packages and under a different version. This patch
removes the code from BGPCEP repository and points all callsites to the
new place.

Change-Id: Ic061ba419dd350f32eb7e212fdb6a8cbff243673
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoAlways set the list of uncleaned instructions 28/9228/1
Robert Varga [Tue, 22 Jul 2014 11:52:54 +0000 (13:52 +0200)]
Always set the list of uncleaned instructions

Change-Id: Idbcc7b2d1c69d406ab0d34493d75a48da35aa111
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Rework BGP timers to work with channel"
Dana Kutenicsova [Mon, 21 Jul 2014 18:24:11 +0000 (18:24 +0000)]
Merge "Rework BGP timers to work with channel"

9 years agoRework BGP timers to work with channel 64/9164/6
Robert Varga [Fri, 18 Jul 2014 16:30:44 +0000 (18:30 +0200)]
Rework BGP timers to work with channel

Since netty channel gives us scheduling capabilities, there is simply no
need for an external timer.  So let's get rid of it and simplify our
code.

Change-Id: If6b7f84dbb953fc1766a6ddceb8411abcf1dc442
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-1389 : fixed removing of LSP by checking remove flag in SRP-id 95/9195/2
Dana Kutenicsova [Mon, 21 Jul 2014 09:22:03 +0000 (11:22 +0200)]
BUG-1389 : fixed removing of LSP by checking remove flag in SRP-id

Change-Id: I3788157c04a10b6052bb379907fc7cb0d250887c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Rework PCEP timers to work on channel"
Dana Kutenicsova [Mon, 21 Jul 2014 14:58:16 +0000 (14:58 +0000)]
Merge "Rework PCEP timers to work on channel"

9 years agoFixed failing build after yangtools update (List fields are by default not null). 99/9199/2
Dana Kutenicsova [Mon, 21 Jul 2014 12:56:04 +0000 (14:56 +0200)]
Fixed failing build after yangtools update (List fields are by default not null).
- added checks for empty

Change-Id: I1a6eb2481f85ce895e2c17a229b11cf8f0ba2fc4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoRework PCEP timers to work on channel 63/9163/5
Robert Varga [Fri, 18 Jul 2014 15:41:59 +0000 (17:41 +0200)]
Rework PCEP timers to work on channel

This has the nice property that netty will ensure thread safety, e.g. we
do not have to synchronize channel lifecycle events anymore.

Change-Id: I37ddd71b6cca8210573e767966032885a7678669
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Bug-194: Deleted jni-cfg artifact."
Robert Varga [Fri, 18 Jul 2014 16:32:56 +0000 (16:32 +0000)]
Merge "Bug-194: Deleted jni-cfg artifact."

9 years agoMerge "Bug-1370: Support for four-octet AS number capability only."
Dana Kutenicsova [Fri, 18 Jul 2014 08:02:13 +0000 (08:02 +0000)]
Merge "Bug-1370: Support for four-octet AS number capability only."

9 years agoBug-194: Deleted jni-cfg artifact. 36/9136/2
Milos Fabian [Wed, 16 Jul 2014 12:24:46 +0000 (14:24 +0200)]
Bug-194: Deleted jni-cfg artifact.

Dependency removed from integration SP dist.:
https://git.opendaylight.org/gerrit/#/c/9125/

Change-Id: Icc9cde348df549795dd79f15b549ab9a6091f8cb
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-1370: Support for four-octet AS number capability only. 06/9106/4
Milos Fabian [Thu, 17 Jul 2014 08:43:32 +0000 (10:43 +0200)]
Bug-1370: Support for four-octet AS number capability only.

-Both BGP speaker and peer, must advertise "support for four-octet AS number capability", to establish connection.

Change-Id: I2998e20439c12aca4e1a31660260d52f5d4963b5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-731 : removed some sonar warnings 14/9114/1
Dana Kutenicsova [Thu, 17 Jul 2014 11:34:48 +0000 (13:34 +0200)]
BUG-731 : removed some sonar warnings

Change-Id: I4b1a5cdd7a12acca6b86eebd384066fc918ff2e4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-194: Explicitly include yang file and services in bundle. 02/9102/4
Milos Fabian [Thu, 17 Jul 2014 05:46:41 +0000 (07:46 +0200)]
Bug-194: Explicitly include yang file and services in bundle.

Change-Id: Id207403ecbd2ef0e2e77690a6272d21a5f5ef19f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "Revert "Bug 1205 - AS path segment value encoded by 2 bytes""
Dana Kutenicsova [Thu, 17 Jul 2014 07:02:31 +0000 (07:02 +0000)]
Merge "Revert "Bug 1205 - AS path segment value encoded by 2 bytes""

9 years agoMerge "Bug-194: Moved tcpmd5/jni-cfg to tcpmd5/jni"
Robert Varga [Wed, 16 Jul 2014 17:16:43 +0000 (17:16 +0000)]
Merge "Bug-194: Moved tcpmd5/jni-cfg to tcpmd5/jni"

9 years agoRevert "Bug 1205 - AS path segment value encoded by 2 bytes" 82/9082/1
Milos Fabian [Wed, 16 Jul 2014 13:50:53 +0000 (15:50 +0200)]
Revert "Bug 1205 - AS path segment value encoded by 2 bytes"

This reverts commit d4f23f2d138b7bf0f1e1d2b61b5720749daf207f.

Change-Id: Iaa6e1d467630ba4bc32d9b67db6f09150d46d914
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoAdd missing tcpmd5-controller-config .project file 53/9053/2
Robert Varga [Wed, 16 Jul 2014 10:57:39 +0000 (12:57 +0200)]
Add missing tcpmd5-controller-config .project file

Change-Id: I55e7ad85cf9c0e35b3b39dfe2121081301d9308e
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-194: Moved tcpmd5/jni-cfg to tcpmd5/jni 59/9059/2
Milos Fabian [Wed, 16 Jul 2014 11:48:19 +0000 (13:48 +0200)]
Bug-194: Moved tcpmd5/jni-cfg to tcpmd5/jni

-moved cfg yang model and java files
-preserved minimalistic pom.xml in tcpmd5/jni-cfg

Change-Id: Ifee8463c33376a9da076dcc9297452d506e47897
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "Fixed PCEP activator. Fixed ExcludeRouteObject type."
Robert Varga [Wed, 16 Jul 2014 10:59:50 +0000 (10:59 +0000)]
Merge "Fixed PCEP activator. Fixed ExcludeRouteObject type."

9 years agoFixed PCEP activator. 51/9051/1
Dana Kutenicsova [Wed, 16 Jul 2014 08:26:33 +0000 (10:26 +0200)]
Fixed PCEP activator.
Fixed ExcludeRouteObject type.

Change-Id: I77229dab5b92457fd425a489178e6d8b60a3282f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-194: Fixed BGPCEP initail configurations. 47/9047/2
Milos Fabian [Wed, 16 Jul 2014 08:00:23 +0000 (10:00 +0200)]
Bug-194: Fixed BGPCEP initail configurations.

Change-Id: I030c2996fdd2f4d2371247ee166bda0e86b66cba
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-194: Deleted BGPCEP config artifacts. 28/9028/2
Milos Fabian [Fri, 11 Jul 2014 08:35:36 +0000 (10:35 +0200)]
Bug-194: Deleted BGPCEP config artifacts.

Change-Id: Id3d921dd86951388212c1d732043ef6a445bc1f5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "Bug-1370: Reads message body bytes as well as exception is thrown during parsing."
Robert Varga [Wed, 16 Jul 2014 07:27:12 +0000 (07:27 +0000)]
Merge "Bug-1370: Reads message body bytes as well as exception is thrown during parsing."

9 years agoBug-612: Added check - before subobjects are serialized. 76/8976/2
Milos Fabian [Mon, 14 Jul 2014 07:22:42 +0000 (09:22 +0200)]
Bug-612: Added check - before subobjects are serialized.

Change-Id: I1ec19c5529bc85c6dadb02f0e7979db447fcf48b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-731 Fix sonar warnings present in code for BUG-338 10/9010/3
Maros Marsalek [Tue, 15 Jul 2014 08:50:58 +0000 (10:50 +0200)]
BUG-731 Fix sonar warnings present in code for BUG-338

Change-Id: I9c3b34f0fbdefd6174ce59c97968746ba3886b98
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "BUG-1025 : use correct YANG syntax to avoid yangtools warnings."
Robert Varga [Tue, 15 Jul 2014 19:39:26 +0000 (19:39 +0000)]
Merge "BUG-1025 : use correct YANG syntax to avoid yangtools warnings."

9 years agoMerge "BUG-1025 : removed logs that pollute log file"
Robert Varga [Tue, 15 Jul 2014 19:39:05 +0000 (19:39 +0000)]
Merge "BUG-1025 : removed logs that pollute log file"

9 years agoMerge "BUG-1199 : fixed incorrect parsing of Error message."
Robert Varga [Tue, 15 Jul 2014 19:38:36 +0000 (19:38 +0000)]
Merge "BUG-1199 : fixed incorrect parsing of Error message."

9 years agoBug-1370: Reads message body bytes as well as exception is thrown during parsing. 27/9027/1
Milos Fabian [Tue, 15 Jul 2014 14:25:13 +0000 (16:25 +0200)]
Bug-1370: Reads message body bytes as well as exception is thrown during parsing.

Change-Id: I661d598ec662c7445aec93d56229eae3e67e1bd2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-194: Fixed bundle exports. 26/9026/1
Milos Fabian [Tue, 15 Jul 2014 15:05:18 +0000 (17:05 +0200)]
Bug-194: Fixed bundle exports.

Change-Id: Ib7b8adcca0cb552c97aac313171259eb98a8ca77
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-1025 : use correct YANG syntax to avoid yangtools warnings. 23/9023/1
Dana Kutenicsova [Tue, 15 Jul 2014 14:21:20 +0000 (16:21 +0200)]
BUG-1025 : use correct YANG syntax to avoid yangtools warnings.

Change-Id: Ic47bfb0d5fddd09c62ce271e8c48b2e31893c5a8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-1025 : removed logs that pollute log file 20/9020/2
Dana Kutenicsova [Tue, 15 Jul 2014 13:48:39 +0000 (15:48 +0200)]
BUG-1025 : removed logs that pollute log file

Change-Id: Ia37f75d5427dc5102011ade1eeb427660a625510
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-1199 : fixed incorrect parsing of Error message. 19/9019/3
Dana Kutenicsova [Tue, 15 Jul 2014 12:39:32 +0000 (14:39 +0200)]
BUG-1199 : fixed incorrect parsing of Error message.

Change-Id: I6227b82a34ae0efd6d0626bc1eef5a58e89031a8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-670: enable reporting of PCEP errors"
Dana Kutenicsova [Tue, 15 Jul 2014 13:06:27 +0000 (13:06 +0000)]
Merge "BUG-670: enable reporting of PCEP errors"

9 years agoBUG-670: enable reporting of PCEP errors 67/8367/10
Robert Varga [Thu, 26 Jun 2014 12:26:07 +0000 (14:26 +0200)]
BUG-670: enable reporting of PCEP errors

Adds a place where errors reported by a PCC can be stored and fills it
when a PCUpd request results in a failure.

Change-Id: Id235effcf6069b66b9f3f3cae19d0cb495ee332f
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-194: Moved bgp configuration artifacts. 56/8856/8
Milos Fabian [Wed, 9 Jul 2014 12:00:00 +0000 (14:00 +0200)]
Bug-194: Moved bgp configuration artifacts.

-moved yang models and java files
-added required dependencies and plugins
-uniformed yang models file name
-configuration artifacts left with minimal pom.xml

Change-Id: Iae53875bcd940163687e238becff319767c320b4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-194: Moved pcep configuration artifacts 55/8855/7
Milos Fabian [Tue, 8 Jul 2014 07:20:04 +0000 (09:20 +0200)]
Bug-194: Moved pcep configuration artifacts

-moved yang modules and java files
-added reqired maven dependencies and plugins
-uniformed config yang modules name
-moved stateful parsers extensions from pcep-impl, to avoid cyclic dependencies
-configuration artifacts left with minimalistic pom.xml file

Change-Id: I40d9628ff1d1b63bf3f2457dec4b0bfb0b11293e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "Bug-194: Moved tcp-md5 configuration artifacts"
Robert Varga [Sun, 13 Jul 2014 15:35:59 +0000 (15:35 +0000)]
Merge "Bug-194: Moved tcp-md5 configuration artifacts"

9 years agoMerge "Bug-194: Moved topology configuration artifacts"
Robert Varga [Sun, 13 Jul 2014 15:14:39 +0000 (15:14 +0000)]
Merge "Bug-194: Moved topology configuration artifacts"

9 years agoMerge "Bug-194: Moved programming configuration artifacts"
Robert Varga [Sun, 13 Jul 2014 15:11:56 +0000 (15:11 +0000)]
Merge "Bug-194: Moved programming configuration artifacts"

9 years agoMerge "BUG-730 : added test for pcep-spi registry."
Robert Varga [Sun, 13 Jul 2014 15:06:40 +0000 (15:06 +0000)]
Merge "BUG-730 : added test for pcep-spi registry."

9 years agoBUG-1199 : fixed small mistake in Pcerr, added a test 02/8902/3
Dana Kutenicsova [Thu, 10 Jul 2014 15:36:17 +0000 (17:36 +0200)]
BUG-1199 : fixed small mistake in Pcerr, added a test

Change-Id: I89e5812a66d711951f78a60473e06f0a1eabaf9e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-1199 : fixed incorrect parsing of RSVP tlv 01/8901/3
Dana Kutenicsova [Thu, 10 Jul 2014 15:34:15 +0000 (17:34 +0200)]
BUG-1199 : fixed incorrect parsing of RSVP tlv

Change-Id: If8f1a1fe283e3254b27075c75871af5b5cfefb5c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-730 : added test for pcep-spi registry. 68/8968/3
Dana Kutenicsova [Sat, 12 Jul 2014 21:41:19 +0000 (23:41 +0200)]
BUG-730 : added test for pcep-spi registry.

Change-Id: I54c8097a49e12dfe22d48a967dedcbcba7abd8f5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-194: Moved tcp-md5 configuration artifacts 54/8854/4
Milos Fabian [Tue, 8 Jul 2014 12:00:23 +0000 (14:00 +0200)]
Bug-194: Moved tcp-md5 configuration artifacts

-moved yang modules and java files
-added required dependencies and plugins

Change-Id: Ie7fbd80036cbb30c04d5b491d0995cf27786968b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-194: Moved topology configuration artifacts 53/8853/4
Milos Fabian [Tue, 8 Jul 2014 10:15:36 +0000 (12:15 +0200)]
Bug-194: Moved topology configuration artifacts

-moved yang files
-renamed yang module
-added required dependencies
-left configuration artifact with minimal pom.xml

Change-Id: I4483544800c942b072aad833769bfb52ae2ea64b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-194: Moved programming configuration artifacts 52/8852/5
Milos Fabian [Tue, 8 Jul 2014 08:21:23 +0000 (10:21 +0200)]
Bug-194: Moved programming configuration artifacts

-moved yang modules and java files
-uniformed config yang modules name
-left configuration artifacts with minimal pom.xml

Change-Id: I1cc2734dc3e9ff320f614e31bd1b14c97ba2130d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "BUG-731 : extracted parts of long methods to separate methods - added test"
Robert Varga [Sun, 13 Jul 2014 13:29:25 +0000 (13:29 +0000)]
Merge "BUG-731 : extracted parts of long methods to separate methods - added test"

9 years agoMerge "Fixed incorrect parsing of Linklocal/remote link identifier."
Robert Varga [Sun, 13 Jul 2014 13:27:58 +0000 (13:27 +0000)]
Merge "Fixed incorrect parsing of Linklocal/remote link identifier."

9 years agoBUG-730 : added tests for pcep-spi. 55/8955/1
Dana Kutenicsova [Fri, 11 Jul 2014 21:55:22 +0000 (23:55 +0200)]
BUG-730 : added tests for pcep-spi.

Change-Id: I52b8b15cf8d2105f870213be1fe7c4b406a73524
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-731 : extracted parts of long methods to separate methods 94/8894/1
Dana Kutenicsova [Thu, 10 Jul 2014 12:35:08 +0000 (14:35 +0200)]
BUG-731 : extracted parts of long methods to separate methods
- added test

Change-Id: I3e8eaf642d9dd9f9f14501455cc69d1f87a4801b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoFixed incorrect parsing of Linklocal/remote link identifier. 93/8893/1
Dana Kutenicsova [Thu, 10 Jul 2014 12:27:22 +0000 (14:27 +0200)]
Fixed incorrect parsing of Linklocal/remote link identifier.

Change-Id: I28da0b76b991b619da98f4772469dd5db18d9f02
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-338 Allow incomming BGP connections. 95/8495/10
Maros Marsalek [Fri, 4 Jul 2014 13:05:06 +0000 (15:05 +0200)]
BUG-338 Allow incomming BGP connections.

Added BGPPeerRegistry that holds all configured BGP peers.
Client/Server SessionNegotiators retrieve BGPPeers(SessionListeners) from the BGPPeerRegistry.
Added StrictBGPPeerRegistry (default implementation of BGPPeerRegistry) that allows only 1 session with BGP peer. If second session is being established, the registry drops either already established or new BGP session (depending on higher source BGP ID).

Added 2 config attributes to BGPPeer:
- initiate connection: true to start BGP connection from ODL. False if just configure BGP peer to accept session from remote device.
- peer registry: dependency on BGPPeerRegistry. Peer registers itself into this registry.

* new attributes are optional to preserve backwards compatibility.

Change-Id: I2f7a606db5196fed49094d49efbb570c4d0fbecb
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "BUG-1287: migrate tests to new APIs"
Dana Kutenicsova [Tue, 8 Jul 2014 13:00:00 +0000 (13:00 +0000)]
Merge "BUG-1287: migrate tests to new APIs"

9 years agoMerge "Bug-731: pcep Tlv serializers - fixed sonar issues"
Dana Kutenicsova [Tue, 8 Jul 2014 12:51:22 +0000 (12:51 +0000)]
Merge "Bug-731: pcep Tlv serializers - fixed sonar issues"

9 years agoMerge "Bug-731: fixed segment-routing sonar issues."
Dana Kutenicsova [Tue, 8 Jul 2014 12:50:57 +0000 (12:50 +0000)]
Merge "Bug-731: fixed segment-routing sonar issues."

9 years agoBug-731: pcep Tlv serializers - fixed sonar issues 83/8783/3
Milos Fabian [Tue, 8 Jul 2014 08:52:13 +0000 (10:52 +0200)]
Bug-731: pcep Tlv serializers - fixed sonar issues

-no need to check for null before an insteadof
-fixed precondition checks in Tlv serializers

Change-Id: I8727f83beb713c427c0337b9058c00490631b1e8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-731: fixed segment-routing sonar issues. 29/8729/3
Milos Fabian [Mon, 7 Jul 2014 10:59:23 +0000 (12:59 +0200)]
Bug-731: fixed segment-routing sonar issues.

Change-Id: Ie6e120f38ebf036fc09cb601d9c46a572cdffe7e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-730 : cleaned up bgp-parser-impl 07/8707/6
Dana Kutenicsova [Sun, 6 Jul 2014 15:43:56 +0000 (17:43 +0200)]
BUG-730 : cleaned up bgp-parser-impl

Change-Id: I478cc65158c58a7e92adce3de17dc265de779034
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-730 : added tests to bgp-parser-api 06/8706/6
Dana Kutenicsova [Sun, 6 Jul 2014 13:52:30 +0000 (15:52 +0200)]
BUG-730 : added tests to bgp-parser-api

Change-Id: I4b90b646610262cb4ff51b9cf68177eb8113c12c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-730 : refactor bgp-linkstate 04/8704/8
Dana Kutenicsova [Sun, 6 Jul 2014 07:14:08 +0000 (09:14 +0200)]
BUG-730 : refactor bgp-linkstate

Change-Id: I8a3bac4cb3c3aeaf7b310fbfb4a00a4eb332524b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-730 : added test for bgp/concepts"
Robert Varga [Mon, 7 Jul 2014 18:53:18 +0000 (18:53 +0000)]
Merge "BUG-730 : added test for bgp/concepts"

9 years agoMerge "Fixed segment-routing formating."
Dana Kutenicsova [Mon, 7 Jul 2014 09:48:22 +0000 (09:48 +0000)]
Merge "Fixed segment-routing formating."

9 years agoMerge "Bug-612: fix segment-routing serializers"
Dana Kutenicsova [Mon, 7 Jul 2014 09:47:26 +0000 (09:47 +0000)]
Merge "Bug-612: fix segment-routing serializers"

9 years agoMerge "Bug-612: ietf-stateful07 serializers - improved code defense."
Dana Kutenicsova [Mon, 7 Jul 2014 09:47:12 +0000 (09:47 +0000)]
Merge "Bug-612: ietf-stateful07 serializers - improved code defense."

9 years agoMerge "Bug-612: ietf-stateful02 serializers - improved code defense"
Dana Kutenicsova [Mon, 7 Jul 2014 09:46:34 +0000 (09:46 +0000)]
Merge "Bug-612: ietf-stateful02 serializers - improved code defense"

9 years agoMerge "Bug-612: Base PCEP serializers - more defensive code"
Dana Kutenicsova [Mon, 7 Jul 2014 09:43:43 +0000 (09:43 +0000)]
Merge "Bug-612: Base PCEP serializers - more defensive code"

9 years agoMerge "Bug-612: Added ByteBufWriteUtil class"
Dana Kutenicsova [Mon, 7 Jul 2014 09:42:16 +0000 (09:42 +0000)]
Merge "Bug-612: Added ByteBufWriteUtil class"

9 years agoFixed segment-routing formating. 24/8724/1
Milos Fabian [Mon, 7 Jul 2014 09:07:02 +0000 (11:07 +0200)]
Fixed segment-routing formating.

-replaced deprecated method call in configuration test

Change-Id: I6f5359e2850a81909c5e519666322463ec00db60
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-612: fix segment-routing serializers 22/8722/2
Milos Fabian [Mon, 7 Jul 2014 09:06:14 +0000 (11:06 +0200)]
Bug-612: fix segment-routing serializers

Change-Id: I1013c09e62c48a4276d6dadd9cd7029e10c9d7a2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-612: ietf-stateful07 serializers - improved code defense. 20/8720/2
Milos Fabian [Fri, 4 Jul 2014 09:00:22 +0000 (11:00 +0200)]
Bug-612: ietf-stateful07 serializers - improved code defense.

-check mandatory arguments
-set zeros for missing arguments

Change-Id: Iad53dba351aaa7080b660644562782d95bf6bb16
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-612: ietf-stateful02 serializers - improved code defense 19/8719/2
Milos Fabian [Wed, 2 Jul 2014 18:09:05 +0000 (20:09 +0200)]
Bug-612: ietf-stateful02 serializers - improved code defense

-check mandatory arguments
-set zeros for missing arguments

Change-Id: I073064da0e3528407b57de5080fbc8a7ed9bd745
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-612: Base PCEP serializers - more defensive code 55/8555/4
Milos Fabian [Wed, 2 Jul 2014 13:15:51 +0000 (15:15 +0200)]
Bug-612: Base PCEP serializers - more defensive code

-check mandatory arguments
-set zeros for missing arguments

Change-Id: I02cf0b4c220846f2c8a9cfe3e9d4bd82bad72fa5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-612: Added ByteBufWriteUtil class 33/8533/10
Milos Fabian [Mon, 30 Jun 2014 09:02:49 +0000 (11:02 +0200)]
Bug-612: Added ByteBufWriteUtil class

-ByteBuf's write methods utility - writes value if not null, otherwise zeros.

Change-Id: Ie3609df888e83dffb69bf9a5da78a3a1ca4ce91d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-730 : added test for bgp/concepts 00/8700/5
Dana Kutenicsova [Sat, 5 Jul 2014 14:48:18 +0000 (16:48 +0200)]
BUG-730 : added test for bgp/concepts

Change-Id: Iab4ed56bf829b2ddfbcf1a675bdec44de9fc2020
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-1287: migrate tests to new APIs 99/8699/2
Robert Varga [Sat, 5 Jul 2014 12:26:12 +0000 (14:26 +0200)]
BUG-1287: migrate tests to new APIs

Removes the use of deprecated config/yang APIs.

Change-Id: I16714c9721be3da4b41855143ea6df1e7966c2bd
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-611 : cleaned up advertized/withdrawn routes."
Robert Varga [Mon, 7 Jul 2014 08:07:53 +0000 (08:07 +0000)]
Merge "BUG-611 : cleaned up advertized/withdrawn routes."

9 years agoMerge "BUG-731 : clean up BGP parsing/serializing"
Robert Varga [Mon, 7 Jul 2014 08:00:16 +0000 (08:00 +0000)]
Merge "BUG-731 : clean up BGP parsing/serializing"

9 years agoMerge "integration tests - fixed unresolved bundle"
Dana Kutenicsova [Mon, 7 Jul 2014 07:55:36 +0000 (07:55 +0000)]
Merge "integration tests - fixed unresolved bundle"

9 years agointegration tests - fixed unresolved bundle 18/8718/1
Milos Fabian [Mon, 7 Jul 2014 05:58:01 +0000 (07:58 +0200)]
integration tests - fixed unresolved bundle

-"util" bundle requires "concepts"

Change-Id: I627f43133693d2443566517dd60c652e00805894
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-611 : cleaned up advertized/withdrawn routes. 98/8698/4
Dana Kutenicsova [Sat, 5 Jul 2014 11:40:24 +0000 (13:40 +0200)]
BUG-611 : cleaned up advertized/withdrawn routes.

Change-Id: I2757f36a5c53d1a1eaac54b43d64dced5c38e69a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-731 : clean up BGP parsing/serializing 97/8697/4
Dana Kutenicsova [Sat, 5 Jul 2014 11:34:36 +0000 (13:34 +0200)]
BUG-731 : clean up BGP parsing/serializing

Change-Id: I3da91b14a582c4c5af79e99ac4a6c0cfe95c67ac
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-611 : cleaned up NextHop parsing/serializing. 96/8696/2
Dana Kutenicsova [Sat, 5 Jul 2014 11:23:17 +0000 (13:23 +0200)]
BUG-611 : cleaned up NextHop parsing/serializing.

Change-Id: I6d162d6665721a6574a00f6125b679dbf43d902d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-611 : updated tests for serialization 89/8689/3
Dana Kutenicsova [Fri, 4 Jul 2014 16:50:20 +0000 (18:50 +0200)]
BUG-611 : updated tests for serialization
- fixed few minor bugs

Change-Id: I92ac52865fa1b4c26884e73871244ea16697a834
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>