Sam Hague [Wed, 19 Apr 2017 18:26:47 +0000 (14:26 -0400)]
add odl-sfc-genius to odl-netvirt-sfc
Change-Id: I2512b14e15210bda5e5b8339621ea8a7b2b02f13
Signed-off-by: Sam Hague <shague@redhat.com>
Brady Johnson [Tue, 18 Apr 2017 13:50:13 +0000 (15:50 +0200)]
BUG 8240 - Fix odl-netvirt-sfc dependent features
- Needed to install odl-sfc-openflow-renderer instead of
odl-sfc-provider in order to bring in all the needed
SFC features.
Change-Id: Id83d65c5b67214a826ff903cf48efeeca61aa99a
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
karthikeyan [Sat, 8 Apr 2017 17:21:57 +0000 (22:51 +0530)]
Bug 8188: L3VNI without configured UC handled for EVPN
Problem Description:
==================
L3VNI without configured in Internet VPN needs to be handled for EVPN in
NAT feature.
Currently Internet(External) VPN with L3VNI use case only handled for
external VXLAN network (EVPN) in NAT feature.
Internet(External) VPN without L3VNI use case also needs to be handled for
external VXLAN in NAT feature. Since Openstack Operator may configure L3VNI or
may not configure L3VNI.
Solution:
=========
Unconfigured of L3VNI value in Internet(External) VPN, will carve-out
the L3VNI value from OpenDaylight VXLAN VNI Pool to use SNAT and DNAT
flows.
The following UCs are handled based on the L3VNI configured/unconfigured
for GRE and VXLAN provider type.
Ext-Net-Type || Internet-VPN-L3VNI || External and Internal VXLAN uses
===============================================================================
GRE Configured Ignore L3VNI, allocate VNI from pool and
use it for Intra-DC only
--------------------------------------------------------------------------------
GRE Not Configured A VNI taken from ODL Pool and used for
Intra-DC communication
---------------------------------------------------------------------------------
VXLAN Configured Internet-VPN-L3VNI used for both
Intra-Inter-DC communication
---------------------------------------------------------------------------------
VXLAN Not Configured A VNI taken from ODL Pool and used for both intra-
inter-DC communication
---------------------------------------------------------------------------------
Note: If VNI value is unable to get from ODL VNI Pool, router-id will be
used as tunnel-id for external network provider type as VXLAN
Change-Id: I3c3f21e026303edf7eb2ad88bfd33622523085f0
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
Alon Kochba [Tue, 18 Apr 2017 17:07:17 +0000 (20:07 +0300)]
Bug 8241: Fix openstack-sfc ACLs IllegalArgumentException
Fix ace port range to be set only if mandatory lower port
is specified, otherwise we hit an exception.
Change-Id: Ic6206394e4255653a837c2b57cefc538555eefa4
Signed-off-by: Alon Kochba <alonko@hpe.com>
cgowdru [Mon, 10 Apr 2017 11:46:26 +0000 (17:16 +0530)]
ADDED INFO logs for tempest issue DEBUG
Change-Id: I25cb78056fbc6b7cbd372ac7565c21472e2c3060
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>
gobinath [Mon, 10 Apr 2017 03:26:59 +0000 (08:56 +0530)]
Bug 8170 - Loadbalancing nexthop group not updated after VM deletion
Issue:
When the last nexthop present in a DPN is deleted, the loadbalancing next
hop group is not updated. The group still contains the bucket pointing to
the deleted nexthop.
Fix:
There was an error while retrieving the endpointIpaddress for the DPN in
method getEndpointIpAddressForDPN. There was an error in converting the
IpAddress object to string. Appropriate conversion is used now.
Change-Id: I86cc77bd69446881d2ab669471f3142845e4d549
Signed-off-by: gobinath <gobinath@ericsson.com>
Sam Hague [Sat, 15 Apr 2017 01:13:54 +0000 (21:13 -0400)]
Set copyright for sfc translator back to Brocade
Change-Id: I576ff1dfe9c97cde540c1a56f77a857fb32e43eb
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 14 Apr 2017 12:05:20 +0000 (08:05 -0400)]
Remove .0 from model.bgp.version
The version bump script ancorrectly added a .0 to the version.
This was a problem as during this same time the vpnservice-features
was using the value without the .0 from a different patch, so they
were not consistent.
Change-Id: I38c47898bdf706ccb0f89ce76209cbbbbb8540d8
Signed-off-by: Sam Hague <shague@redhat.com>
Yakir Dorani [Thu, 6 Apr 2017 08:52:51 +0000 (11:52 +0300)]
Bug 8166: Acl interfaces are not set and cached correctly
The acl interface can exist in the cache before an interface
was assigned one. This can happen via the AclInterfaceStateListener.
Also, an interface ID should be set when a new entry is created.
Change-Id: I3e882582731eb273da533ac15dd2c8cc7f27ffe2
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
Sam Hague [Wed, 12 Apr 2017 18:45:04 +0000 (14:45 -0400)]
Use ArpConstants from arputil
Depend-on: https://git.opendaylight.org/gerrit/54890
This avoids duplicating constants and also helps to
break cyclics.
Change-Id: I76689a97d1131d13cffa382bbf4d07d7a3d19044
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
40f3c94a3068d45b5fda6b38500dbce07aadca44)
Sam Hague [Thu, 13 Apr 2017 13:17:36 +0000 (09:17 -0400)]
Name all blueprint.xml file consistently
Change-Id: I7497339a96ff0f76f11e3f3c9937f57b6993169c
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
c553537cee52a74b78e2ca68c568ae548a941ebb)
Vratko Polak [Thu, 13 Apr 2017 10:04:51 +0000 (12:04 +0200)]
Fix model-bgp version
Change-Id: I419cbebf5df5d38501cf3793aba5ecd806c7f25c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Janki [Wed, 5 Apr 2017 15:16:33 +0000 (20:46 +0530)]
Bug 8162 - NPE at org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.onSubnetAddedToVpn
Change-Id: I2936a473841b995a496c76064249a2bb9bd96354
Signed-off-by: Janki <jchhatba@redhat.com>
Sam Hague [Wed, 12 Apr 2017 21:02:09 +0000 (17:02 -0400)]
Cleanup unused dependencies
Change-Id: I98eb44130f247108589db3aedf4e015b76ce03c1
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 12 Apr 2017 19:26:25 +0000 (15:26 -0400)]
add interface for VpnFootprintService
This is another attempt to reduce cyclics.
Change-Id: I29acdc7fa4c681c24b0cafc8430716f189bd7be1
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 12 Apr 2017 23:28:29 +0000 (19:28 -0400)]
Remove legacy utils from new netvirt
Change-Id: I43a183b689846924ac8344117bfa59cae0457a4a
Signed-off-by: Sam Hague <shague@redhat.com>
Akash Kumar Sahu [Wed, 12 Apr 2017 10:47:22 +0000 (16:17 +0530)]
Bug 8014 - L2Gw connectivity not working
Tunnel creation issue as cache were not populated properly
Fixed .
Change-Id: I7613afe762f0a865275c3fc492045ef4d035ba84
Signed-off-by: Akash Kumar Sahu <a.k.sahu@ericsson.com>
Sam Hague [Wed, 12 Apr 2017 22:07:13 +0000 (18:07 -0400)]
Remove utils.config
Change-Id: Iaf232a25f055b26e392d337e85a2b15409b9c03d
Signed-off-by: Sam Hague <shague@redhat.com>
Brady Johnson [Mon, 10 Apr 2017 09:27:10 +0000 (11:27 +0200)]
BUG 8193 - Fix Netvirt classifier egress service port binding
- The Netvirt classifier egress service should bind on egress
ports, not ingress ports like it does now.
- Since its not possible to know all the possible egress ports
to bind on before-hand, the egress classifier service will
bind on all switch ports. It will only process NSH packets
and return all others to the egress dispatcher.
- Also in this patch, when the SFF is on the same bridge as
the classifier, the egress classifier will resubmit the
packets directly to the SFF instead of going through the
ingress dispatcher, since we dont know the correct ingress
port to use for the SFF.
- Updated OpenFlow13ProviderTest to reflect the change to the
egress classifier resubmit.
- Changes from code review comments
- Final changes to make sure the egress binding is working.
Now using getDpnInterfaceList RPC to get the switch ports
to bind to.
Change-Id: I97bc38722064738ee22b8ddbc7163bc5dc3dd276
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Sam Hague [Mon, 10 Apr 2017 17:40:04 +0000 (13:40 -0400)]
Cleanup version properties
Change-Id: I15c3131032866d0094b7f34ac7e4c85cfe139665
Signed-off-by: Sam Hague <shague@redhat.com>
ruby -v [Wed, 12 Apr 2017 09:29:19 +0000 (14:59 +0530)]
Bug 8105: IllegalArgumentException in getSrcIp fix
1. reading IP and ARP payload was wrong, which is fixed by getting payload from
deserialised ethernet data based on IPv4 or ARP, getPayload will return
the right payload as the offsets are maintained in Packet based on
type of payload.
2. IllegalArgumentException was for payload type IPv4 where
getSourceAddress method will return of type int, and
NWUtil.toStringIpAddress will accept input as byte.
The same was working fine with payload type ARP as
getSenderProtocolAddress return byte.
3. Tested these changes by creating 2 ports in neutron network, delete 1
port and send ping packets from deleted port to the other port.
First ARP packet hit and was able to retrieve IP address properly, and
then data traffic hit and was able to retrieve IP address.
Change-Id: I16af2e18e2c857a5529f4ffef1caf9da014d521f
Signed-off-by: Riyazahmed D Talikoti <riyazahmed.d.talikoti@ericsson.com>
Anil Belur [Tue, 11 Apr 2017 01:45:45 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I9934b7eaaf36c6726e0f8e6700aca63421f03b5c
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
eupakir [Mon, 3 Apr 2017 13:32:53 +0000 (19:02 +0530)]
BUG 8140 : Elect nodes for subnetroute on control path reboot
When a physical switch on the cloud management network in the cloud is
rebooted, it results in disconnection of datapath-nodes from the ODL
controller. Under such conditions, the subnetRoute is removed from all
the DPNs.
However, once the physical switch comes back up after reboot, the
datapath-nodes are all getting reconnected to the ODL controller. During
this time in a scaled environment, the subnetRoute flow rules aren't
getting reapplied to the datapath-nodes. This is because the election
process fails in figuring out a designated datapath-node for hosting
subnetroute, thereby the subnetRoute is not getting reconfigured on all
the datapath-nodes.
Co-Authored-By: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Change-Id: I4e2770a658e9d3b0c68fc52227845ed8546ecb97
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Sam Hague [Mon, 10 Apr 2017 16:09:40 +0000 (12:09 -0400)]
cleanup checkstyle to pull from parent poms
Change-Id: If1a78a39696a64a29ad57f56978450a1b06a947c
Signed-off-by: Sam Hague <shague@redhat.com>
Josh [Sun, 26 Mar 2017 09:15:08 +0000 (12:15 +0300)]
Bug-8053 OVS Bridge other_config:hwaddr not preserved for nodes not in config DS
1) Make sure to retain operational DS other_configs for existing bridges
2) Set other_config:datapath-id for all bridges already in operational. This
is important to guarantee dpid does not change even for bridges where the
other_config:hwaddr or other_config:datapath_id vals are not set.
DEPENDS ON: https://git.opendaylight.org/gerrit/53856
Change-Id: I5aa792262230655bf753045290666c73aaa4096b
Signed-off-by: Josh <jhershbe@redhat.com>
Brady Johnson [Fri, 7 Apr 2017 07:30:03 +0000 (09:30 +0200)]
UT for SfcProvider and NetvirtProvider
- Added SfcProviderTest.java
- Added NetvirtProviderTest.java
- modified pom.xml to add ConstantSchemaAbstractDataBrokerTest
Change-Id: If8f9a7f3e87725d279566531df4b2b431abdb417
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Faseela K [Sun, 9 Apr 2017 18:23:07 +0000 (23:53 +0530)]
Minor code cleanup in ELAN
Change-Id: I15e80fd1d38b6a4cb96d1c947bddbc1a68bf4180
Signed-off-by: Faseela K <faseela.k@ericsson.com>
karthikeyan [Fri, 7 Apr 2017 09:40:17 +0000 (15:10 +0530)]
Bug 8001: Data validation failed for path CSIT TCs
Problem Description:
====================
On external network update or internet VPN update NAT code will trigger
the ExternalRoutersListener.update() to handle the updated changes
in NAT feature. During this invocation, for getting NAPT switch-id is
retrieved from the "router-to-napt-switch" DS. After retrieved the NAPT
switch-id from the DS, it contains the value as "0". There is no check for
NAPT switch-id validation.
clrRtsFromBgpAndDelFibTs() method is invoked with passing NAPT switch-id
as "0" value is throwing the data validation exceptions.
Solution:
===========
As part of this issue fix, invoked NAPT Switch selection if dpnId value is
"null" or "0" from "router-to-napt-switch" DS then go for electing new
Napt switch for existing router. This will resolve the data validation
exception. Since clrRtsFromBgpAndDelFibTs() method is never invoked with
NAPT switch-id as "0".
Change-Id: I851c4049397369871616834f59aff1eb16ce4472
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
eupakir [Thu, 6 Apr 2017 08:47:56 +0000 (14:17 +0530)]
Bug 8165 - Learnt IP route does not reappear on DC-GW after OVSRestart
On OVS Restart, a learnt IP will have to be deleted by Liveness
Monitor, and then re-learnt once the OVS comes up.
But this IP was not learned again.
Cyclic events were getting spawned while processing removal of
Learnt IPs. This was causing deletion of re-learnt IPs.
Change-Id: I17b87fef05de8d3eb51f2a4720df98ff647e8937
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Tali [Thu, 6 Apr 2017 08:56:25 +0000 (11:56 +0300)]
Bug 8020 - Conflicting modification on VpnInterface creation for router-interface in newton
Change-Id: I918174b829075c571414bf82c40936cc950af630
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Michael Vorburger [Thu, 6 Apr 2017 10:03:37 +0000 (12:03 +0200)]
Fix erroneous space in DhcpAllocationPoolRemoveJob import statement
This shows up as "red ink" (error) in Eclipse as a Checkstyle violation.
I'm not sure why the CLI mvn Checkstyle does not fail forr this - it may
be a subtle difference between the exact version of Checkstyle
internally used by the Eclipse plugin and the one used by the Maven
build.
Change-Id: I3dacb8d5c6f6eb689bfadf034c2e1db7f30ce76f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
karthikeyan [Tue, 4 Apr 2017 07:44:18 +0000 (13:14 +0530)]
Bug 8145 - DNAT to DNAT traffic is getting failed for 2nd FIP for EVPN/VNI
Problem Description:
====================
DNAT to DNAT traffic (Different Hypervisor) is getting failed for 2nd FIP
VM for VXLAN and GRE Networks.
Consider 2 FIP VMs are booted on single DPN.
When disassociation/remove of 1st FIP VM, 2nd FIP VM traffic for DNAT to
DNAT is getting failed.
When remove 1st FIP it will remove the flow 36->25 entry. Hence DNAT to
DNAT communication is not happening.
This issue is existing for VXLAN and GRE (L2_L3_VNI Based Forwarding)
external provider type networks only.
Solution:
===========
For EVPN_RT5 and L2-L3 VNI based forwarding, uses "l3vni" value as
tunnel_id in the INTERNAL_TUNNEL_TABLE (table=36). If mutiple FIPs are
existing in the single DPN, each remote tunnel_id will be setting with
same "l3vni" value. Hence removing one FIP is causing the problem
with other DNAT traffic. To avoid this problem added the fix for removing
the flow INTERNAL_TUNNEL_TABLE (table=36) -> PDNAT_TABLE (table=25) to
check if any FIP is existing on the given DPN. If not exist then only will
remove the flow table36->25.
Change-Id: I410035b4d160a22ac016a6de3fce219010e6c1f3
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
eceghkl [Fri, 17 Mar 2017 06:06:43 +0000 (11:36 +0530)]
Tunnel Interface State Handling for extra routes
* Handle interface state changes for tunnel
* Handles add and delete event
* Add/remove nhList from vrfentrylistener based on event
Depends-On: I1b40ce3ea8b73707295e86ae9d4ddddf15716b2e
Change-Id: I3c091a538d201ff4f4accc04d5fb35bee482de4d
Signed-off-by: eceghkl <manu.b@ericsson.com>
Brady Johnson [Wed, 5 Apr 2017 17:48:04 +0000 (19:48 +0200)]
UT for Netvirt SFC classifier
- Added AclMatchesTest.java
- Added OpenFlow13ProviderTest.java
- Changes to remove DataBroker from OpenFlow13ProviderTest as suggested by Michael Vorburger
- Minor changes were made to OpenFlow13Provider to expose constants used in creating
flows so that OpenFlow13ProviderTest can verify they were set accordingly.
- Flushed out a bug in OpenFlow13Provider thanks to the UT: The flowId
was not being set correctly in createEgressClassifierFilterVxgpeNshFlow
- Flushed out a bug in OpenFlow13Utils thanks to the UT: The inport
NodeConnectorId was not being set correctly in addMatchInPort.
Change-Id: I950422eea7a8f0ee9aab9b14cd2ea877bceba8d8
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Somashekar Byrappa [Fri, 3 Feb 2017 10:26:39 +0000 (15:56 +0530)]
Bug 7730: Traffic drop in ACL during port update for AAP
Issue: ARP flows in ACL tables are missing if AAP with same MAC is updated
Fix:
+ For AAP case, changed the order of programming flows to delete and add
instead of add and delete flows.
+ For port update, programming ARP flows is handled separately.
- For egress, deletion of ARP flow is skipped if AAP is updated for same
MAC.
- For ingress, no action required as ARP flow has match for lport
tag only. MAC is not used here.
Change-Id: I6c814468d80a601e127c813ee1897f9ed18315bf
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Aswin Suryanarayanan [Sat, 8 Apr 2017 08:45:33 +0000 (14:15 +0530)]
Added Nat Config in vpn-service feature pom.
Change-Id: Id09a72bd02bd4f82f9cdf4c28a291eb3bd52924a
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Aswin Suryanarayanan [Sat, 8 Apr 2017 07:36:14 +0000 (13:06 +0530)]
Set update-strategy to none.
Check [1] for more info.
https://git.opendaylight.org/gerrit/#/c/54103/
Change-Id: I773f11962bf9bf0240fb53391ea84341caf56b15
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Brady Johnson [Fri, 31 Mar 2017 00:53:26 +0000 (02:53 +0200)]
Final changes for netvirt sfc classifier
- correctly obtain egress port from genius
- minor changes from previous code review
- Bugs tracked to be fixed in subsequent versions:
BUG 8127
BUG 8128
BUG 8129
- Rebased
- BUG 8128 turned out to be a configuration error of mine.
IPv4 matching works just fine.
- BUG 8128 has been closed.
- Removed Legacy Netvirt flow utils usage.
- BUG 8129 is partially addressed. Removed legacy netvirt flow utils,
but in order to remove FlowBuilder usage, several changes to Genius
will be needed, and will be done in a separate patch.
- minor fix for flow deletion
- made the ACL flow key more unique
- Check for the Vxgpe option on tunnel ports
Change-Id: I9ba1853222ae72d7e70f4aa192284bb46f6c7d32
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Aswin Suryanarayanan [Tue, 28 Mar 2017 15:42:09 +0000 (21:12 +0530)]
Added a new config parameter for selecting SNAT.
The default is set to controller mode.
The controller mode is disabled wherever applicable when conntrack is
selected.
When conntrack is selected new HA framework is used by default. The
controller mode continue to use the existing HA.
Change-Id: I00bb3ccda43cf382d6f2047298c4b25c82c73194
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 6 Apr 2017 14:38:38 +0000 (10:38 -0400)]
Update neutronvpn to use Singleton
Change-Id: Iaf1b94c06bfb69e98f13a71d4a5782293f777692
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 6 Apr 2017 03:45:50 +0000 (23:45 -0400)]
Update natservice to use Singleton
Change-Id: I547755f19f4ad76699988c4db417f749453d89ab
Signed-off-by: Sam Hague <shague@redhat.com>
eswanit [Thu, 6 Apr 2017 08:04:02 +0000 (13:34 +0530)]
Adding a check for elan-Interface removal
Change-Id: I8e782a22525848b149d5094ffdd6b842ec966f69
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Miguel Perez [Fri, 7 Apr 2017 08:57:33 +0000 (10:57 +0200)]
Bug 8108: Fix for NPE in Cloud-SC's VrfListener
+ I think all stream()+map() should be reviewed to avoid these
kind of Exceptions
Change-Id: I8f96483c20c14995f5fd9d0bf700a4c8e40b4735
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Michael Vorburger [Thu, 6 Apr 2017 16:00:51 +0000 (18:00 +0200)]
Untangle bad class design: OpenFlow13Provider does not use DataBroker
It's generally best practice to not "reach over" through other services
to obtain injected services, but just let each class have (final) fields
with all of its dependant services.
In this particular case, the OpenFlow13Provider does not need to have a
DataBroker, so it's best to keep this simpler. This makes writing unit
tests for OpenFlow13Provider more clear; for example, in
https://git.opendaylight.org/gerrit/#/c/54376/.
Change-Id: I3924275c246ffca2da259a2f696a51282eab486a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Gowri R [Thu, 6 Apr 2017 06:33:34 +0000 (12:03 +0530)]
Updating the display-bgp-config command
To display the newly added options for BGP Multipath feature
Change-Id: I758a5e3700730355ef2efa9f5cb7bf8724f8c69c
Signed-off-by: Gowri R <gowri.r@ericsson.com>
Stephen Kitt [Thu, 6 Apr 2017 13:04:34 +0000 (15:04 +0200)]
Bug 7633: add K4 features to artifacts
Change-Id: Id9b9191968430623632fdba6b9d359c2fc42493b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Shai Haim [Wed, 5 Apr 2017 09:22:56 +0000 (12:22 +0300)]
update DHCP spec according to the desired feature capabilities
Change-Id: Icdfb529d15f40c688dada4695ea75abbb189037e
Signed-off-by: Shai Haim <shai.haim@hpe.com>
Sam Hague [Thu, 6 Apr 2017 13:35:00 +0000 (09:35 -0400)]
Update fibManager to use Singleton
Change-Id: I08fbbcc7bd3a9c35063ce31c0ad22e85934c94c9
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 6 Apr 2017 14:10:41 +0000 (10:10 -0400)]
Update cloud-servicechain to use Singleton
Change-Id: I4f83907c7b19749816bfeb92f664650a5ea705e6
Signed-off-by: Sam Hague <shague@redhat.com>
Abhinav Gupta [Thu, 6 Apr 2017 15:04:32 +0000 (20:34 +0530)]
Disabling enforce-openstack-semantics flag
Change-Id: I39ef5563b9bc5ac9b04a7723253ab7b6bf468eee
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Alon Kochba [Thu, 6 Apr 2017 13:57:39 +0000 (16:57 +0300)]
Bug 8025: Correct non-NAPT to NAPT tunnel ID
As part of the vni-based-l2-l3-nat changes, the tunnel
used was changed but the packet out sent should use the
same tunnel ID for NAPT to work from a VM on a non-NAPT
switch.
Change-Id: I7ee2b526531beb84ececd78acf79a42d6177f7ab
Signed-off-by: Alon Kochba <alonko@hpe.com>
Stephen Kitt [Thu, 6 Apr 2017 13:51:22 +0000 (15:51 +0200)]
Fix natservice-impl for Karaf 4
Change-Id: I92ae9307e5001d8b5527d98b95b0c005b87c38da
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Thu, 6 Apr 2017 00:38:54 +0000 (20:38 -0400)]
Update dhcpservice to use Singleton
Change-Id: I6c24c7fd1a354a8ca7e4e69c99ac529f851717fd
Signed-off-by: Sam Hague <shague@redhat.com>
Tomer Pearl [Wed, 5 Apr 2017 14:36:43 +0000 (17:36 +0300)]
External networks subnetroute fix
Commit [1] changed the VpnSubnetRouteHandler APIs from using
yang based notifications to listening on subnetmap changes
from the datastore.
Subnetmap entities for subnets in Flat/VLAN external networks don't have a
vpn-name assigned to them, which caused a null pointer exception in
VpnSubnetRouteHandler after [1]
In this change, subnetmap is assinged a vpn-name, for subnets in
external Flat/VLAN networks, which is the subnet id itself.
[1] https://git.opendaylight.org/gerrit/#/c/53878/
Change-Id: Ic7593a5f59aa389f19729c5c5701fd9e1e02eea0
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>
Michael Vorburger [Wed, 5 Apr 2017 20:39:15 +0000 (22:39 +0200)]
Remove statemanager's ConfigStateManager
now that all of netvirt is using blueprint
This class (ConfigStateManager) does not seem to be used anywhere.
Change-Id: I9d861f04824bf1faf71a61000fed41e273dd7316
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Wed, 5 Apr 2017 21:35:29 +0000 (17:35 -0400)]
Update ipv6service to use Singleton
Change-Id: I0dbedeadd30f44f2364bb7e3cd06291472415a12
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 5 Apr 2017 19:40:25 +0000 (15:40 -0400)]
update AclLiveStatistics to use Singleton
Change-Id: I80fb8821531ac1246265838017818fc8f8240048
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Wed, 5 Apr 2017 21:40:50 +0000 (23:40 +0200)]
statemanager StateManager @Singleton with @Inject instead of <bean> XML
https://wiki.opendaylight.org/view/BestPractices/DI_Guidelines
Change-Id: I9c5607b1eba5bcb9bf74b234a64c7583a272f09d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Aswin Suryanarayanan [Wed, 5 Apr 2017 09:33:35 +0000 (15:03 +0530)]
Command line added to display the current NAPT switches configured.
Change-Id: I45ab13e78f51dae1b6ca1ce1589a073a36239359
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Stephen Kitt [Wed, 29 Mar 2017 07:48:15 +0000 (09:48 +0200)]
Bug 7633: Karaf 4 vpnservice-it features
Change-Id: I6b26687059c5fc94ce41c0abdab75ea6cffb95f9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vyshakh Krishnan CH [Wed, 5 Apr 2017 09:20:48 +0000 (14:50 +0530)]
Bug 7607 : Bgp route not getting sync-up with fib
Problem:
ODL bgp route not getting sync-up with fib table
Analysis and Fix:
In BGPManger, configs are replayed to quagga in BGP reactor.
BGP reactor gets trigered whenever ebgp.yang data model gets added.
on configuring a VPN also ebgp gets added and replay is called. But no bgp
configs are there to replay. Now when BGP config is added later, no replay
will happen and routes will be missed
So moving the config replay to ASID reactor.
Change-Id: I1cef1415759267ebfe96ac9fbc28cf84b58577ed
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Stephen Kitt [Tue, 28 Mar 2017 12:25:42 +0000 (14:25 +0200)]
Bug 7633: Karaf 4 vpnservice features
Change-Id: I74b33b43100fdd5fccdb5e05f07983f0da69b628
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Manuel Buil [Tue, 4 Apr 2017 11:54:07 +0000 (13:54 +0200)]
Correct errors in specs
The new classifier description had some typos and errors
Change-Id: I98a98c3e77e15ec55f0392b33029bfc6ad8c22ae
Signed-off-by: Manuel Buil <mbuil@suse.com>
Alon Kochba [Tue, 4 Apr 2017 13:18:21 +0000 (16:18 +0300)]
Use correct metadata value for remote ACL
Add a utility to extract the correct metadata
value for writing and matching the remote ACL ID
according to the metadata mask.
Change-Id: I89c7551b133d9d2eaf4436164c9ace8b866c5cf4
Signed-off-by: Alon Kochba <alonko@hpe.com>
Janki [Tue, 4 Apr 2017 14:39:47 +0000 (20:09 +0530)]
Bug 8154 - log error for an extra-route if localNextHopInfo is unavailable
As per the comments on this patch https://git.opendaylight.org/gerrit/#/c/53459,
log an error when localnexthopinfo == null for extra-route
Signed-off-by: Janki <jchhatba@redhat.com>
Change-Id: I6667dde66027228446eff1b45a0b825c9329e606
Stephen Kitt [Mon, 27 Mar 2017 15:17:14 +0000 (17:17 +0200)]
Bug 7633: Karaf 4 sfc-translator features
Change-Id: Ie4629e75cc0abad36d768799f24ecb90f789fd32
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Periyasamy Palanisamy [Tue, 4 Apr 2017 09:28:31 +0000 (14:58 +0530)]
Bug 8023: returning if StateTunnelList is not internal
While handling add DCN for StateTunnelList in ELAN, making sure it doesn't
process DCN for external tunnel.
Change-Id: I7d0ccd073a26a40756e1fc6cdb6139cc1d460e81
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
eceghkl [Wed, 8 Mar 2017 11:18:59 +0000 (16:48 +0530)]
Fixes for extraroute deletion
* This contains fixes during extra route deletion and nova
delete
* The fix includes complete clean up of
-extraroute-rds container.
-vpn-to-extraroute container
-operational adjaceny container.
Change-Id: I1b40ce3ea8b73707295e86ae9d4ddddf15716b2e
Signed-off-by: eceghkl <manu.b@ericsson.com>
Signed-off-by: gobinath <gobinath@ericsson.com>
Guy Regev [Mon, 3 Apr 2017 12:04:14 +0000 (15:04 +0300)]
Use mask on reg6 metadata
Change-Id: Ifb6885af5f9b823ceaa964a3af8df4fb12342173
Signed-off-by: Guy Regev <guy.regev@hpe.com>
karthikeyan [Mon, 3 Apr 2017 06:19:18 +0000 (11:49 +0530)]
Bug 8137: Missing log entries in many places for NAT feature
Fixing the missing log entries for NAT feature. This will not impact any traffic.
Just to ensure in TRACE log to capture all the missing parameters.
Change-Id: Ie638a967502ed6a64c924f0499af77fb4c98bf41
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
Periyasamy Palanisamy [Mon, 27 Mar 2017 06:44:14 +0000 (12:14 +0530)]
Bug 8023 adding trace logs
Adding trace logs to find out root cause for not programming remote dmac
and bc group for auto tunnel configuration
Change-Id: Ifd7433d0b0d1d0d385ac7b940d024729846062c1
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Periyasamy Palanisamy [Mon, 3 Apr 2017 06:15:17 +0000 (11:45 +0530)]
Bug 7866 fixing remote bc group and mac learning
* Updating remote BC group correctly for VLAN provider networks
* catching exception while parsing ip address from packet ins.
otherwise, it would ignore the packet-in and mac learning doesn't happen
Change-Id: I07cac591706f631360d7dc96bfba1a8732aedfd6
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Shankar M [Mon, 3 Apr 2017 06:55:32 +0000 (12:25 +0530)]
reading the bgp_sdnc_mip, sdnc_bgp_mip from custom.properties instead of
platform dependent cluster.conf
Change-Id: I4c1c00c99126fcc9306a880ddedd5db613683fcc
Signed-off-by: Shankar M <shankar.m@ericsson.com>
Shlomi [Mon, 3 Apr 2017 14:01:09 +0000 (17:01 +0300)]
add missing acl in federation routed rpc
Change-Id: Icc0d58f606345601c069c1ab7687d85fd551432e
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>
Shashidhar Raja [Mon, 3 Apr 2017 14:17:55 +0000 (19:47 +0530)]
8121: Exception in SG Acl while SFC acl is created/modified
- Updated ACL event listener to act on the event only if it has
SecurityRuleAttr augmentation
Change-Id: I61f4a03b4624848c6d1210ff240c35a1e7a81034
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Jose-Santos Pulido Garcia [Mon, 3 Apr 2017 15:10:03 +0000 (17:10 +0200)]
Add UTest BgpRouterAddNeighborTest
'BgpRouter.addNeighbor' is no longer a simple wrapper around
'BgpConfigurator.Client.createPeer' so a small UT has been
added to check 'createPeer' and 'setPeerSecret' are called
properly.
Changelog:
- BgpRouter.java: new protected factory method
'makeTestingRouter'.
- BgpRouterAddNeighborTest.java: new UT class with the
following tests: 'addNeighbor_noPass_happyCase',
'addNeighbor_wPass_happyCase',
'addNeighbor_noPass_createPeerFails',
'addNeighbor_wPass_createPeerFails', and
'addNeighbor_wPass_setPeerSecretFails'.
Change-Id: I851aa55a3aba6bd60e29fee3d9d190337317a6f3
Signed-off-by: Jose-Santos Pulido Garcia <jose.santos.pulido.garcia@ericsson.com>
Suraj Ranjan [Sat, 11 Mar 2017 14:37:57 +0000 (20:07 +0530)]
Subnet-Route support for L3VPN Over VxLAN
This review includes the code changes to support the subnet-route feature
for EVPN RT5
Change-Id: I216da6fa446eaabff03be152865126a5cd663665
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Miguel Perez [Wed, 29 Mar 2017 16:12:08 +0000 (18:12 +0200)]
Refactor InterVpnLink. Part ONE
+ This is the first of a series of commits that intend to
split this bigger one [1] into smaller so that it's easier
to review.
[1] https://git.opendaylight.org/gerrit/#/c/48599/
Change-Id: Ib29066c63d96026d57d83b079dc490bfc07c3328
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Alon Kochba [Wed, 29 Mar 2017 11:53:54 +0000 (14:53 +0300)]
ACLs separate priority pools for allow/deny
To support mixing of Allow and Deny ACEs, we need to
define separate pools, where the higher range is allocated
to the ACEs with behavior matching the default behavior.
Depends-On: https://git.opendaylight.org/gerrit/#/c/53894/
Change-Id: I83ca5a1a57f73971117aa766ae00cc9e22d8d197
Signed-off-by: Alon Kochba <alonko@hpe.com>
Yakir Dorani [Sun, 2 Apr 2017 10:21:56 +0000 (13:21 +0300)]
Bug 8135: Potential NPE in subnet route packet handler for subnetmap
Check for nulls when handling the subnetmap and some more minor fixes.
Change-Id: Iee9705073dc1f21fff5dee50e63cfbfd45ff86d1
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
eswanit [Tue, 21 Mar 2017 05:58:07 +0000 (11:28 +0530)]
Fixing the 'error writing to datastore' in
CSIT.
* updated unbindService method
* added DJC in update method for elan-instance
Change-Id: Iea0bd63a124fe0f13934cd906b0fb191aeeda5f2
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
cgowdru [Wed, 8 Mar 2017 01:36:12 +0000 (07:06 +0530)]
Using InternetVPN Vni for Intra-DC communication
Description :
When Enforce Openstack Semantics is enabled, then VNI will be carved
out from the VNI pool per External-VPN and will be used as tun_id for
Intra-DC communication.else label generated per external-ip will be
used as default.
Change-Id: I72b53886fdd2c5f3d84f6329e9cf647e0a7556c8
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>
Shlomi [Sun, 2 Apr 2017 14:59:07 +0000 (17:59 +0300)]
Ignore ACL unitests that fail on timing
https://git.opendaylight.org/gerrit/#/c/53002/ introduced sleeps in
unitests, causing netvirt compilation to sporadically fail.
Opened bug to handle properly:
https://bugs.opendaylight.org/show_bug.cgi?id=8136
Change-Id: Id840735142f6f574085c6899088ed32dfbfef891
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>
Stephen Kitt [Mon, 27 Mar 2017 15:15:50 +0000 (17:15 +0200)]
Bug 7633: Karaf 4 net-virt-sfc features
This patch needs the SFC Karaf 4 features.
Change-Id: Ice3961292a92d50d7c47a92211f9fbd7e7ac0fdb
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Abhinav Gupta [Thu, 23 Mar 2017 10:09:53 +0000 (15:39 +0530)]
Remove subnetroute notifications, listen directly on snmap events
To make subnetroute engine support populating subnet-op-data at all times,
and not just be specific for non-ext-net BGPVPNs, two subsequent changes
are required.
1. Remove 2 hops to act on snmap events by eliminating notifs.
2. To populate subnet-op-data for all cases via add/remove/update, and
trigger subnetroute only for non-ext-net BGPVPNs.
This review handles part (1) of the problem.
Change-Id: Iae78416ddf2d8f365f0a954304e5bafa5cdc8bbc
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Periyasamy Palanisamy [Tue, 28 Mar 2017 07:18:06 +0000 (12:48 +0530)]
Making ELAN to use StateTunnelList listener
* Currently ELAN uses Interface state DCN for tunnel events to program
remote DMAC and BC group when VxLAN tunnel is created later. So making it
to use listen StateTunnelList
* This change would be useful when ITM supports multiple VxLAN tunnels and
avoid race conditions
Change-Id: Idce3dd3a548b95feadf43fbe2c1311c3fafdb70a
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Miguel Perez [Thu, 30 Mar 2017 16:05:06 +0000 (18:05 +0200)]
Refactor InterVpnLink. Part TWO
+ This change is independent from the other ones. Basically
it changes some classes to retrieve data from the Cache instead
of directly from MD-SAL
+ Removes some methods from InterVpnLinkUtil that are no longer
needed.
Change-Id: I2ce86770730abe3e670f8ccdf19202f79fb71a25
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Tali [Wed, 22 Mar 2017 20:42:19 +0000 (22:42 +0200)]
Add custom policy ACL matches
Depends-On: https://git.opendaylight.org/gerrit/#/c/54004/
Change-Id: I1a1fa604e0d35ef84e1464c2fdaf7272e71b4da7
Signed-off-by: Tali <tali.ben-meir@hpe.com>
cgowdru [Fri, 3 Mar 2017 14:50:29 +0000 (20:20 +0530)]
Router VNI as tun_id from Non-NAPT to NAPT
Description :
When Enforce Openstack Semantics is enabled, then VNI will be carved
out from the VNI pool per router and will be used as tun_id.
else router_id will be used by default(if Router is over L3VPNOverVXLAN
then RouterLport tag will be used as per EVPN)
Change-Id: I75bb483a75e82aea9d8613f434ff97943619bd18
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>
Akash Kumar Sahu [Mon, 20 Mar 2017 10:25:27 +0000 (15:55 +0530)]
Bug 7599 -hwvtep ucast mac consumption improvement
Adding DPN cache to make getting invoved DPN's faster instead of reading
from data store in case of each Mac added.
Change-Id: Ie8751453ca98961c410dfaeaf89ab345c26a5160
Signed-off-by: Akash Kumar Sahu <a.k.sahu@ericsson.com>
eupakir [Tue, 14 Mar 2017 12:43:11 +0000 (18:13 +0530)]
Extra routes support for L3VPN Over VxLAN
Code changes to handle extra-routes for L3VPN Over VxLAN (EVPN RT5).
Change-Id: I3b5b8bcea04f1f946225b23f16e146fa16f82d4b
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Brady Johnson [Wed, 29 Mar 2017 15:55:47 +0000 (17:55 +0200)]
Plugin provider functionality
- The plugins provide the renderers with the
necessary functionality to be able to render
- Converted back to Genius MDSALUtil
- Fixed a few issues in ClassifierUpdate and related classes
Change-Id: I85e23b0058a12fd795689791cac35efcffffe125
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Sam Hague [Thu, 30 Mar 2017 17:38:20 +0000 (13:38 -0400)]
Add statistics-config.xml to initial resources
Change-Id: I45f5c5813a222558afe8c2e22d81024c31bc3e32
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 30 Mar 2017 16:59:54 +0000 (12:59 -0400)]
Add neutronvpn-config.xml to initial resources
Change-Id: I9cb221e6aa747a62467c7fd46e41e023a8b2bee5
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 30 Mar 2017 16:44:03 +0000 (12:44 -0400)]
Add vpnmanager-config.xml to initial resources
Change-Id: Ice1b0e2aae0a144f4d7d203c6c8c3939db68dd60
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 30 Mar 2017 13:28:32 +0000 (09:28 -0400)]
Set update-strategy to none for all configs
The default update strategy is to restart the bundles
when any config is changed. No bundles support that
so disable that behavior until it is supported.
Change-Id: Id6fa794be768a4c9c1e213eaf20f5556bf0585c7
Signed-off-by: Sam Hague <shague@redhat.com>
Slava Radune [Tue, 28 Feb 2017 12:44:13 +0000 (14:44 +0200)]
Implement remote ACL indirection table
Implementation of remote ACL indirection as described in spec:
https://git.opendaylight.org/gerrit/#/c/51462
Change-Id: Ifaccd2bab13c8b16eed2d1a17dd54cfa87f70ee3
Signed-off-by: Slava Radune <slava.radune@hpe.com>
Vinh Nguyen [Sun, 5 Mar 2017 03:49:54 +0000 (19:49 -0800)]
Bug 7922 - Use counter to keep track of duplicate flow entries
Problem: Single flow entry associated with two more security rules
incorrectly deleted when one of the security rule is deleted.
Fix: Use counter to keeps track of duplicate security rules
in a particular VM. The counter is maintained in the flow cookie.
When writing a security flow, the flow counter is incremented
if the flow already exists, otherwise the flow cookie is set to '1'.
When removing a security flow, if the counter value is '1',
the flow is removed from the node, otherwise the flow counter is
decremented.
This changeset also:
- reversed some previous partial fixes for the same problem.
- refactor common Acl Service to AbstractAclService
- reformat/clean up code
Change-Id: Idfec36fa47c88db76a8382f8fcbc65c4100e9e6e
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
Yakir Dorani [Thu, 16 Feb 2017 11:26:35 +0000 (13:26 +0200)]
Send ARP requests for PNFs with unresolved MACs.
In internal VPN scenario, when packets are sent to an PNF with an unresolved MAC,
ARP requests should be sent from a specific switch.
There are two cases:
1. Tenant network - The destination IP belongs to a subnet in a tenant network.
The arp should be sent from the designated switch of the destination subnet.
2. External network - The destination IP belongs to a subnet the external network.
The arp should be sent from the NAPT switch.
Change-Id: I496339337085c7d832fd87cf1894f858860bbae9
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
Depends-On: https://git.opendaylight.org/gerrit/53546
Tali [Sun, 19 Mar 2017 16:14:49 +0000 (18:14 +0200)]
Egress policy service binding and policy table miss flows
Change-Id: I56b9bee5d794832b68f1522f502dcc169c1f0ab2
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Code Review / netvirt.git / log