Sam Hague [Mon, 16 Nov 2015 02:30:18 +0000 (02:30 +0000)]
Merge "Listen config DS then push configuration to switch"
Sam Hague [Mon, 16 Nov 2015 02:29:55 +0000 (02:29 +0000)]
Merge "Bug 4641 - openstack.net-virt-sfc-features fail to find artifacts"
Sam Hague [Mon, 16 Nov 2015 01:59:10 +0000 (20:59 -0500)]
Bug 4641 - openstack.net-virt-sfc-features fail to find artifacts
Change-Id: Iccc0c5d817db0014842f5e7023b173c67af728e2
Signed-off-by: Sam Hague <shague@redhat.com>
Peng Zhang [Thu, 12 Nov 2015 03:01:04 +0000 (11:01 +0800)]
Listen config DS then push configuration to switch
Patch Set 1:
1. Add skeletal code for command pattern to push configuration to switch, function TBD.
2. Implement LogicalSwitchUpdateCommand.
Patch Set 2:
1. Fix whiteapce issues.
2. Add 'logical-switch-managed-by' for logical-switch-attribute in hwvtep.yang.
3. Use hcm.getConnetionInstance(node) added in https://git.opendaylight.org/gerrit/#/c/29599.
Patch Set 3:
1. Fix LOG severities and delete some TODOes.
2. Use HwvtepSchemaConstats.databaseName for Hwvtep database name.
Change-Id: I0fe5dafdf9ecfa91ee8c757c4b694a50e6cbed35
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>
Sam Hague [Sat, 14 Nov 2015 06:20:12 +0000 (06:20 +0000)]
Merge "rework sfc flows 2"
Sam Hague [Sat, 14 Nov 2015 06:06:58 +0000 (06:06 +0000)]
Merge "Patch Set 1: Add postman collection for HwvtepSouthbound"
Sam Hague [Sat, 14 Nov 2015 05:44:31 +0000 (00:44 -0500)]
rework sfc flows 2
Change-Id: I9cb93d19d54cd7bcf7d93ab82e17dbe7579cafb3
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Fri, 13 Nov 2015 17:11:12 +0000 (17:11 +0000)]
Merge "Security Groups: Added support for ICMP, ALL ICMP and Others protocol Change-Id: Iedc3061ccaf03f21b9a39da8a4b8b27c4baea6f0 Signed-off-by: raveek <raveek@hp.com>"
Flavio Fernandes [Fri, 13 Nov 2015 10:53:05 +0000 (10:53 +0000)]
Merge "Fixed possible null point exception in node manager entries update code"
Peng Zhang [Thu, 12 Nov 2015 15:13:05 +0000 (23:13 +0800)]
Patch Set 1:
Add postman collection for HwvtepSouthbound
Patch Set 2:
Add brief introduction in README
Patch Set 3:
Change to multi-line version
Patch Set 4:
Fix whitespace issues
Patch Set 5:
Fix whitespace issues: a trailing space missed
Patch Set 6:
recheck
Change-Id: If7a764ca56ced4316aa04ff8538bf12849d60dd9
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>
Sam Hague [Fri, 13 Nov 2015 04:22:28 +0000 (04:22 +0000)]
Merge "add rsp option"
Sam Hague [Fri, 13 Nov 2015 04:19:47 +0000 (04:19 +0000)]
Merge "added getConnectionInstance by Node"
Sam Hague [Fri, 13 Nov 2015 03:48:16 +0000 (22:48 -0500)]
add rsp option
Change-Id: Idd0410436861ccc13ad581e42e75ea793102e3ad
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Fri, 13 Nov 2015 01:57:50 +0000 (01:57 +0000)]
Merge "UT for remaining classes in ovsdb.southbound.ovsdb.transact"
Flavio Fernandes [Fri, 13 Nov 2015 01:57:00 +0000 (01:57 +0000)]
Merge "Declare expected exceptions"
Flavio Fernandes [Fri, 13 Nov 2015 01:55:59 +0000 (01:55 +0000)]
Merge "Avoid logging stacktraces for schema version mismatches"
Anil Vishnoi [Fri, 13 Nov 2015 01:47:23 +0000 (07:17 +0530)]
Fixed possible null point exception in node manager entries update code
Change-Id: Iac231117e592f23c6e1362b71e76ae13d6c98a40
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Flavio Fernandes [Thu, 12 Nov 2015 23:47:28 +0000 (23:47 +0000)]
Merge "Bug 4611: null pointer exception while processing interface event"
Anil Vishnoi [Tue, 10 Nov 2015 20:50:37 +0000 (02:20 +0530)]
For controller initiated connection, there is race condition
while disconnecting the device from controller, that does
not allow one of the non-owner southbound instance to disconnect
the device from the plugin. Race condition was occuring because
OvsdbConnectionInstance was not stored in the internal cache
at correct point in control flow.It gets added when EntityOwnershipChange
event happens, so when data change event for disconnection occured,
it requires OvsdbConnectionInstance to be in cache to disconnect
from the device, but OvsdbConnectionInstance was not in the cache
becuse EntityOwnershipService event was not recieved by that non-owner instance.
Conflicts:
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionManager.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/SouthboundProvider.java
Change-Id: I3861b5f2907d08709a3bd1aa4f4ecfbfd444351d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Sam Hague [Thu, 12 Nov 2015 20:29:33 +0000 (20:29 +0000)]
Merge "rework sfc flows"
Sam Hague [Thu, 12 Nov 2015 17:30:30 +0000 (12:30 -0500)]
rework sfc flows
Change-Id: I1789ce135a8b08de4c4321fdd69cec73bc4a638c
Signed-off-by: Sam Hague <shague@redhat.com>
Vishal Thapar [Thu, 12 Nov 2015 15:13:23 +0000 (20:43 +0530)]
added getConnectionInstance by Node
This is required for https://git.opendaylight.org/gerrit/#/c/29575/
Change-Id: Iceab17399b973dab7c1fbf47d21af6989aa2f49e
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sam Hague [Wed, 11 Nov 2015 21:25:06 +0000 (21:25 +0000)]
Merge "workaround for sfc part 2"
Sam Hague [Wed, 11 Nov 2015 20:53:10 +0000 (15:53 -0500)]
workaround for sfc part 2
Change-Id: Ib733682492ede0985dae97bbe3add80b359add1f
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 11 Nov 2015 05:20:09 +0000 (05:20 +0000)]
Merge "add rest of sfc flows"
Sam Hague [Wed, 11 Nov 2015 04:54:04 +0000 (23:54 -0500)]
add rest of sfc flows
Change-Id: I44629e889705c4e7f6a21c3655addee9670bc8c5
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 10 Nov 2015 20:47:15 +0000 (20:47 +0000)]
Merge "workaround for sfc"
Sam Hague [Tue, 10 Nov 2015 17:11:10 +0000 (12:11 -0500)]
workaround for sfc
Change-Id: I46b22b084627f95c1e478b1cf004681d21d4595c
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Tue, 10 Nov 2015 16:56:35 +0000 (11:56 -0500)]
Bug 4611: null pointer exception while processing interface event
Acl service needs to handle cases when port security info is not available.
Patch set 2: add unit test
Change-Id: I788d31e4f0001fcf70caa59086d432b01178de1b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Stephen Kitt [Tue, 10 Nov 2015 08:47:34 +0000 (09:47 +0100)]
Avoid logging stacktraces for schema version mismatches
Change-Id: Ic3db3d3526491bb488d396be64adc9e41e09a3d6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 10 Nov 2015 08:46:13 +0000 (09:46 +0100)]
Declare expected exceptions
@Test supports declaring (and verifying) expected exceptions, let's
use that instead of manually detecting the exceptions.
Change-Id: Iafe26c2c566ebdfe7616a864d5e6c60d3b2b7fe2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Rashmi Pujar [Mon, 9 Nov 2015 17:58:55 +0000 (12:58 -0500)]
UT for remaining classes in ovsdb.southbound.ovsdb.transact
Change-Id: I7dfd78209e770c28a7ced22cea9308c5c9fe7ee8
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
raveek [Tue, 3 Nov 2015 07:55:21 +0000 (13:25 +0530)]
Security Groups: Added support for ICMP, ALL ICMP and Others protocol
Change-Id: Iedc3061ccaf03f21b9a39da8a4b8b27c4baea6f0
Signed-off-by: raveek <raveek@hp.com>
Sam Hague [Mon, 9 Nov 2015 04:21:33 +0000 (04:21 +0000)]
Merge "Added command patterns to update OperDS"
Sam Hague [Mon, 9 Nov 2015 03:21:15 +0000 (22:21 -0500)]
initial framework for sfc workaround and IT tests
Change-Id: I94a4a40659fb4f0a1ecc815a7d132ffcadd991de
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 9 Nov 2015 03:19:43 +0000 (22:19 -0500)]
update exports for ServiceHelper
Change-Id: I7d7e97b5860dbaca87877d95759fe550a62855e8
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 8 Nov 2015 16:22:28 +0000 (11:22 -0500)]
Add config for selecting provider
Change-Id: I5597573fa2cafd2e7db4d444fc51030adf478f7c
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 8 Nov 2015 15:14:29 +0000 (10:14 -0500)]
Rework provider interface to allow different providers
Change-Id: Iaa36bc040e82005c3a8d419e23ad9ac8696c1215
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sat, 7 Nov 2015 02:11:42 +0000 (21:11 -0500)]
Add SfcClassifier to pipeline
Change-Id: I7de504449435678020efc3aca290897adada42ab
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Fri, 6 Nov 2015 23:17:52 +0000 (23:17 +0000)]
Merge changes I4a8650ae,Ie2e119fd,Ic2acced7,Ieeb5ae5b,I2f7b6f8f
* changes:
Fixed wildcarded imports
Fixed NPE in md-sal secutiry groups to neutron security group conversion.
Removed Flow id caches that is being used to check
Populate the Node Cache at the controller start/restart.
Repopulate router, port and floating ip related caches These caches can create a problem in a cluster environment where node goes down and rejoin the cluster. All the caches will be clear on restart, and if newly join node become master instance, it can break the functionality. This patch is re-populating all the required caches
Anil Vishnoi [Fri, 6 Nov 2015 22:37:33 +0000 (04:07 +0530)]
Fixed wildcarded imports
Change-Id: I4a8650aefddd0455e55d005a2ffd017a34d64293
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Wed, 4 Nov 2015 18:17:46 +0000 (23:47 +0530)]
Fixed NPE in md-sal secutiry groups to neutron security group conversion.
Change-Id: Ie2e119fdc24168f2ab4df26332244586c644912f
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Sat, 31 Oct 2015 04:50:31 +0000 (10:20 +0530)]
Removed Flow id caches that is being used to check
if flow is already installed or deleted. Now it will
install flow irrespective of whether the flow already
installed or not. It won't really do installation of
flow again, because if you write same data again, it's
going to be no-op. These caches create issues if new node
with same ovsdb ip:port connects the controller, but the
openflow bridge is different.
Change-Id: Ic2acced7a9a006e6e04afba6fea22aaf0620f134
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Sat, 31 Oct 2015 00:21:08 +0000 (05:51 +0530)]
Populate the Node Cache at the controller start/restart.
This cache can be removed fully, but if we do that, we need
to make read call to the data store, where we will have to
read the whole topology tree, that can put some load on the
md-sal data store, and it might not be negligible in case of
clustered data store.
Change-Id: Ieeb5ae5ba01839b34aefe7d3916c6bdd0fb14808
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Sat, 31 Oct 2015 00:21:08 +0000 (05:51 +0530)]
Repopulate router, port and floating ip related caches
These caches can create a problem in a cluster environment
where node goes down and rejoin the cluster. All the caches
will be clear on restart, and if newly join node become master
instance, it can break the functionality. This patch is re-populating
all the required caches
Change-Id: I2f7b6f8f8871eb7c6fc7c96d9e4e121adbf5c950
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Sam Hague [Thu, 5 Nov 2015 21:17:09 +0000 (21:17 +0000)]
Merge "Fix the feature name of hwvtepsouthbound in ./hwvtepsouthbound-karaf/pom.xml"
Sam Hague [Thu, 5 Nov 2015 21:03:11 +0000 (21:03 +0000)]
Merge "Extend southbound-it testDpdkSwitch() to test all the OVS-DPDK interface types [dpdk,dpdkr,dpdkvhostuser..]"
Vishal Thapar [Wed, 4 Nov 2015 03:55:39 +0000 (09:25 +0530)]
Added command patterns to update OperDS
1. Command pattern for Global and PhysicalSwitch
2. Update OperDS with Global and PhysicalSwitch tables
Patchset2:
Added skeletal code more command pattern classes, functionality TBD.
Handle updation of instance iid on connect/connected
Patchset3:
Clear Operational DataStore when switch disconnects
Add PhysicalSwitchRemove command
Change-Id: I519c28a59edcd3a99ac5fadfda420b65edb85abb
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sam Hague [Thu, 5 Nov 2015 15:10:01 +0000 (10:10 -0500)]
More changes for SFC
Change-Id: I1e6b52b9726d6fe85ccde01a57bdb927821690ca
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 5 Nov 2015 15:09:21 +0000 (10:09 -0500)]
Fix utils exports
Change-Id: I0032fd368af59e23cecb26736b0e34723df58a0f
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 5 Nov 2015 15:08:55 +0000 (10:08 -0500)]
Modify NSH MatchUtils
Change-Id: I85057e96b399dea8d9f09d087da6014dc780ac8c
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 5 Nov 2015 15:07:38 +0000 (10:07 -0500)]
Add Flow utils
Change-Id: I120391618945908c358c4da4728ad0c5243c721f
Signed-off-by: Sam Hague <shague@redhat.com>
Peng Zhang [Thu, 5 Nov 2015 03:47:13 +0000 (11:47 +0800)]
Fix the feature name of hwvtepsouthbound in ./hwvtepsouthbound-karaf/pom.xml
Change-Id: I994bc48981ec43cf206e07a9ac877ed1e356fe92
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>
Praveen Mala [Tue, 3 Nov 2015 01:43:29 +0000 (20:43 -0500)]
Extend southbound-it testDpdkSwitch() to test all the OVS-DPDK interface types [dpdk,dpdkr,dpdkvhostuser..]
Change-Id: Iab6532b33fe1d2eb0ab61c1434e9560fdb7b530f
Signed-off-by: Praveen Mala <praveen.mala@intel.com>
Sam Hague [Wed, 4 Nov 2015 01:48:46 +0000 (01:48 +0000)]
Merge changes If2ef6c5c,I4b8e0a28
* changes:
Fix nsh flow
fix for missing sfc feature
Sam Hague [Tue, 3 Nov 2015 13:09:17 +0000 (08:09 -0500)]
Fix nsh flow
Change-Id: If2ef6c5c6986ca42e7a753a1e43202dd5cb4bfcc
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 4 Nov 2015 00:03:17 +0000 (19:03 -0500)]
fix for missing sfc feature
Change-Id: I4b8e0a28c3dcca1f2809ca820f77be479dbe236c
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 3 Nov 2015 23:31:25 +0000 (23:31 +0000)]
Merge "Use config for hwvtepsouthbound"
Vishal Thapar [Mon, 2 Nov 2015 12:12:54 +0000 (17:42 +0530)]
Use config for hwvtepsouthbound
This is counterpart to https://git.opendaylight.org/gerrit/27578
Patchset2:
Remove null check for ovsdbConnection in handleOwnershipChange. Since this
is always non-null, we end up not starting OVSDBManager for hwvtep.
Change-Id: I8900794cf4f75b837fd6efb406f18addc9cfe3a0
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Rashmi Pujar [Tue, 3 Nov 2015 16:12:49 +0000 (11:12 -0500)]
UT for ovsdb.southbound transact package
4. TerminationPointCreateCommand.java
5. TerminationPointUpdateCommand.java
Change-Id: I7647196548b676ada6a4fa902f60f7e71644901c
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Stephen Kitt [Mon, 2 Nov 2015 13:52:01 +0000 (14:52 +0100)]
Inline variables
Change-Id: I7999f158b755eb9b0a71bd38d3e065cc766f45a7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 13:26:13 +0000 (14:26 +0100)]
Drop redundant type information
Change-Id: I030f911f2e699266b6f85af7a0185a4714e34fb1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 13:17:23 +0000 (14:17 +0100)]
Fix up loops
Use foreach loops instead of explicit Iterators.
Use switch statements instead of mutually-exclusive if statements.
Change-Id: I2239a2f119686efc65ae062a95b4edbda99c5ded
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 12:16:48 +0000 (13:16 +0100)]
Boxing/unboxing clean-up
Change-Id: I9c0b9386a5befc58e0a93ad654e9fb8a8531e7bd
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 10:12:12 +0000 (11:12 +0100)]
Full <> clean-up
Change-Id: I23ce78b0cb4d2f253bc2d0ea8fe4833ff099e8b2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 10:03:41 +0000 (11:03 +0100)]
Remove unused imports
Change-Id: Icdbeac2764322aebe8c903b5cc23fa3295b61d49
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 09:40:15 +0000 (10:40 +0100)]
Remove redundant semi-colons
Change-Id: I4a9d36022a333d90c2b3fc716d9aca9334c15a66
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 09:39:39 +0000 (10:39 +0100)]
Drop redundant "public" for interfaces
Change-Id: I5761423745aa72adc7434f82e9ed076d842e2ddc
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 09:37:00 +0000 (10:37 +0100)]
Clean up enums
enums are static, and their constructors private, by default.
Change-Id: I6be729d10fa2e81b87a5a4afcc91ed1a30e3ea97
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 08:35:30 +0000 (09:35 +0100)]
Clean up collections
Use interfaces instead of concrete implementations where appropriate.
Use the Java 7 <> operator.
Avoid Lists.newArrayList() if new ArrayList<>() is sufficient.
Change-Id: I70ebe6ebc7c79f8d742fdd71fc6419461a7aaa65
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 2 Nov 2015 07:56:15 +0000 (08:56 +0100)]
Use SLF4J instead of printStackTrace()
Change-Id: I0bcf68f963cdbaaac5de3e919c14134d2420ef35
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Sun, 1 Nov 2015 18:12:00 +0000 (18:12 +0000)]
Merge "Add back the proper NetvirtSfc flows"
Sam Hague [Sun, 1 Nov 2015 14:33:16 +0000 (09:33 -0500)]
Add back the proper NetvirtSfc flows
Change-Id: I26fe692c95b14c8b4baa7aa575a233feb4337914
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 1 Nov 2015 01:20:58 +0000 (01:20 +0000)]
Merge "Ovsdb-UI : Change icon and attempt to fix invisible vxlan"
Sam Hague [Sun, 1 Nov 2015 01:18:53 +0000 (01:18 +0000)]
Merge "Added support for remote security group update. 1)When a new port is created/deleted with a security group, all the ports which has that security group as a remote security group, will be updated. 2)Refactored IngressAclService,EgressAclService for supporting remote security group update."
Sam Hague [Sun, 1 Nov 2015 01:16:30 +0000 (01:16 +0000)]
Merge "Add DataTreeChangeListener, user connections"
Stephen Kitt [Fri, 30 Oct 2015 17:15:22 +0000 (18:15 +0100)]
SouthboundIT: merge the test generation code
Change-Id: I86354ce41a78749578e93827e35dc23659e1588d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 30 Oct 2015 16:40:35 +0000 (17:40 +0100)]
SouthboundIT: use a common builder for the input values
Change-Id: I7af0b37eda67554ce28cbcabae16fcf62260432b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 30 Oct 2015 15:20:34 +0000 (16:20 +0100)]
SouthboundIT: drop test case 4
As implemented, test case 4 is equivalent to test case 3. Modifying
test case 4 so it matches the documentation (i.e., setting the value
but not the key) just causes errors in MD-SAL because key-less values
are not allowed. This patch drops test case 4 entirely.
Change-Id: Id52eeddd1c7a1660a1da3ce82e31ac7295bff635
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 30 Oct 2015 13:39:34 +0000 (14:39 +0100)]
Avoid an NPE in OvsdbNodeRemoveCommand
In some cases (perhaps only test code)
ovsdbNodeAugmentation.getManagerEntry() returns null; this patch adds
a test to avoid the resulting NPE.
Change-Id: If545d3e4478deb91703029d8226957c5c61d2125
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 30 Oct 2015 09:25:56 +0000 (10:25 +0100)]
SouthboundIT: make the tests uniform
All the CRUD tests should be similar; fix all the NPE handling and
adjust the tests so they are all used. This is a precursor to merging
all the tests using helper classes.
Change-Id: Ie616bed00304ddc780b85f0bd0d0f550bb4645f2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 28 Oct 2015 17:46:01 +0000 (18:46 +0100)]
SouthboundIT: use an explicit class describing test-cases
Change-Id: Ice5b8e281465be6bcf733ceafa6dbe673eb8f35c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 28 Oct 2015 17:03:25 +0000 (18:03 +0100)]
Revert SouthboundIT multi-threading and refactor
Running the tests in ExecutorService-managed threads masks a number of
errors which leave the target OVSDB in an inconsistent state. This
patch reverts the multi-threading and subsequent refactor, while
preserving some of the later changes (notably the Jacoco activation).
The multi-threading and testcase-refactoring will be re-done as
follow-up patches.
Change-Id: I9d534509f772afd75877d230cf4e2dc4654fab85
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Thu, 29 Oct 2015 03:23:29 +0000 (03:23 +0000)]
Merge "Fix netvirtsfc flows"
Sam Hague [Thu, 29 Oct 2015 01:49:16 +0000 (21:49 -0400)]
Fix netvirtsfc flows
Change-Id: Ife49b9150dcb99fb3097b0fe175d8e9355bdf527
Signed-off-by: Sam Hague <shague@redhat.com>
Maxime Millette-Coulombe [Thu, 22 Oct 2015 19:33:44 +0000 (15:33 -0400)]
Ovsdb-UI : Change icon and attempt to fix invisible vxlan
- Change the icon for ones more appropriate.
- Attempt to solve the invisible vxlan when using
a "triange" vxlan topology.
- Change the logical dialog to be "half-static".
The position will be set one time and will keep the
last given instead of trying to appear near the related node.
Change-Id: I1bdd92a5b97c9f8638c5415391c02f3deb6d168a
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>
Anil Vishnoi [Wed, 28 Oct 2015 11:20:14 +0000 (16:50 +0530)]
Bug 4546 - Southbound plugin throws java.lang.IllegalStateException
while shutting down and loops forever
Change-Id: I71812a3cb008e43cfa5b0f9ce331fb2623983332
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Aswin Suryanarayanan [Tue, 20 Oct 2015 21:38:48 +0000 (03:08 +0530)]
Added support for remote security group update.
1)When a new port is created/deleted with a security group, all the
ports which has that security group as a remote security group, will be
updated.
2)Refactored IngressAclService,EgressAclService for supporting remote
security group update.
Change-Id: I16e83f77f3ccc19a4d5ecd800e39881643ec752a
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Sam Hague [Tue, 27 Oct 2015 13:31:47 +0000 (13:31 +0000)]
Merge "UT for ovsdb.southbound transact package"
Sam Hague [Mon, 26 Oct 2015 23:32:07 +0000 (23:32 +0000)]
Merge "Adding code to test the all the supportted interfaces by OVS-DPDK [dpdk, dpdkr, dpdkvhostuser,....others]"
Praveen Mala [Wed, 21 Oct 2015 20:44:04 +0000 (16:44 -0400)]
Adding code to test the OVS-DPDK datapath type: netdev
Change-Id: I599df4f0f910a1e7e18ee230ac562cbea6ac3b03
Signed-off-by: Praveen Mala <praveen.mala@intel.com>
Sam Hague [Mon, 26 Oct 2015 21:49:37 +0000 (17:49 -0400)]
Ensure startOvsdbManager is called
Change-Id: I5055c376f05c8deb22b6d90a14e79c9f36c0b5d7
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 26 Oct 2015 13:47:07 +0000 (09:47 -0400)]
Fixup minor net-virt-it exceptions
Change-Id: I9ad3ff17a0df0d792261b460c657b56c43eac168
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 25 Oct 2015 12:22:53 +0000 (08:22 -0400)]
fix southbound-api exports
Change-Id: I910fd48fc0dcc8eb01036d3f0633425f071c803b
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sat, 24 Oct 2015 01:26:53 +0000 (21:26 -0400)]
cleanup netvirtsfc api exports
Change-Id: I46041aba4aa09c86557b2cfafb82c596a5917ed8
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 23 Oct 2015 19:43:02 +0000 (15:43 -0400)]
Remove unused LibraryProvider
Change-Id: I83ce77556a2c8e587278ec713f08a5d4fa4ba795
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Wed, 23 Sep 2015 16:25:39 +0000 (18:25 +0200)]
Use config for southbound (take 2)
Remove unused/commented code
ConfigActivator is gone completely.
The multi-threading tests in SouthboundIT are limited to a single
thread to get the tests to pass for now (we need to handle
connections/disconnections properly).
Change-Id: I544a2d4f802c1ccdfe9593a0722ad0e0c8f27139
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Rashmi Pujar [Fri, 23 Oct 2015 19:09:25 +0000 (15:09 -0400)]
UT for ovsdb.southbound transact package
1. TransactInvokerImpl.java
2. TransactCommandAggregator.java
3. TransactUtils.java
Change-Id: If360ba8f07a9715ff60225809fbc987afba59516
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Sam Hague [Fri, 23 Oct 2015 15:57:24 +0000 (15:57 +0000)]
Merge "Correctly determine the parameterised type"
Flavio Fernandes [Fri, 23 Oct 2015 04:53:22 +0000 (04:53 +0000)]
Merge "Parse the port number in setup()"