Tomas Slusny [Mon, 21 Aug 2017 06:47:47 +0000 (06:47 +0000)]
Merge "Fix checkstyle"
Tomas Slusny [Mon, 21 Aug 2017 06:46:21 +0000 (06:46 +0000)]
Merge "Remove deprecated CheckedFuture."
Jozef Bacigal [Mon, 21 Aug 2017 06:45:44 +0000 (06:45 +0000)]
Merge "Move extension implementation from API to impl"
Jozef Bacigal [Tue, 15 Aug 2017 06:58:07 +0000 (08:58 +0200)]
Fix checkstyle
- on openflowplugin.api
- set default checkstyle to error instead of warning to prevent new checstyle violations
Change-Id: I0e539639b95d9f2d417aa10a576419211f110083
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 14 Aug 2017 07:53:08 +0000 (09:53 +0200)]
Remove deprecated CheckedFuture.
Change-Id: Ica92197df035bffc032e27e0805816a1a8e264a8
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
gobinath [Tue, 11 Jul 2017 10:24:22 +0000 (15:54 +0530)]
Bug 8902 - Changes in FRM for Reconciliation Framework
Change-Id: Id063eb8be61396113d0b10fabb43f0d64d02f6a8
Signed-off-by: gobinath <gobinath@ericsson.com>
Jozef Bacigal [Thu, 17 Aug 2017 13:05:10 +0000 (13:05 +0000)]
Merge "Bump reconciliation"
Robert Varga [Thu, 17 Aug 2017 11:03:55 +0000 (13:03 +0200)]
Fix version reference
This component has not been adjusted to reflect version bump,
fix that.
Change-Id: I9702ef9dbc9b56faf9ef43d6ad7565da1bbaf0f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Gobinath [Thu, 17 Aug 2017 09:30:42 +0000 (15:00 +0530)]
Bump reconciliation
Change-Id: Ic35a2543fbb3864134bd11860ef7d889f47882e2
Signed-off-by: Gobinath <gobinath@ericsson.com>
Prasanna Huddar [Thu, 17 Aug 2017 06:08:44 +0000 (06:08 +0000)]
Merge "Bug 8902 - Reconciliation Framework changes"
Tomas Slusny [Thu, 10 Aug 2017 10:47:51 +0000 (12:47 +0200)]
Move extension implementation from API to impl
Currently, some parts of openflowjava extension implementation is
located in API and not in implementation project as it should be, so
move this code from api to implementation.
Change-Id: I85b6f75f4c6bc23bf1944061bcfec339f189cb1e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Thanh Ha [Mon, 14 Aug 2017 17:35:49 +0000 (13:35 -0400)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I6d7ff6cf68d043fc4dc2cfc4a26f59fda21818fa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Tomas Slusny [Fri, 11 Aug 2017 00:16:34 +0000 (00:16 +0000)]
Merge "Bump odlparent 2.0.2 to 2.0.4"
Stephen Kitt [Tue, 8 Aug 2017 16:14:14 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4
Change-Id: I168975753b4ea7728eb361f7ef7803fbb970f64b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Jozef Bacigal [Wed, 9 Aug 2017 09:00:10 +0000 (09:00 +0000)]
Merge "Update unit tests pt2"
Jozef Bacigal [Wed, 9 Aug 2017 09:00:00 +0000 (09:00 +0000)]
Merge "Update unit tests"
Tomas Slusny [Tue, 8 Aug 2017 10:48:42 +0000 (12:48 +0200)]
Remove unused code from He design
See also: bug 8656
Change-Id: Ib1657f519587e6ec463bf1f2af2e50ccd3b727e5
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 7 Aug 2017 10:17:03 +0000 (12:17 +0200)]
Update unit tests pt2
- Add unit tests for single layer sal services
- Add some missing unit tests for device context
- Add unit test for mastership service delegate
- Fix sal table service for single layer
See also: bug 8607
Change-Id: I4f850ee83f82d98e1b66ac467ca08a1b963de3c1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 24 Jul 2017 15:44:48 +0000 (17:44 +0200)]
Update unit tests
Add unit tests for:
- Arp target transport address serializer
- Packet in message deserializer
- All serializers for multipart request messages
- All serializers for table feature properties and match fields in table
features
- Configuration service and OpenFlowProviderConfigImpl
- Device initializers (OF10 and OF13)
- Single-layer direct statistics
- Request context and input utils
Remove custom comparators for sorting of actions and instructions and
use OrderComparator.build() instead. Also, add missing sorting of table
feature instructions and actions properties.
See also: bug 8607
Change-Id: I83e0ad9a3469c80f4fa45df4de78c1e0fd53954b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Gobinath [Mon, 10 Jul 2017 09:15:25 +0000 (14:45 +0530)]
Bug 8902 - Reconciliation Framework changes
Changes related to the Reconciliation Framework are done in this patch.
The APIs needed to be implemented by the services registering to the
Reconciliation framework are present in the interface
ReconciliationNotificationListener.The APIs to register the service to
Reconciliation framework and the APIs to start the reconciliation /
cancellation of the ongoing reconciliation of a node are present in
ReconciliationManager.
Change-Id: I8bd1845db8b86f4a4314977e05c6b699592f5658
Signed-off-by: gobinath <gobinath@ericsson.com>
Tomas Slusny [Mon, 7 Aug 2017 07:14:16 +0000 (07:14 +0000)]
Merge "Bug 8873 - Bundle based reconciliation to enable bundling of messages"
eeiillu [Tue, 18 Jul 2017 05:13:00 +0000 (10:43 +0530)]
Bug 8873 - Bundle based reconciliation to enable bundling of messages
Change-Id: Ida09badca9a16619fec6e6f293042956ce8ec4e4
Signed-off-by: eeiillu <suja.t@ericsson.com>
Tomas Slusny [Thu, 3 Aug 2017 05:52:20 +0000 (05:52 +0000)]
Merge "Bug 8882 - With conntrack SNAT communication with PNF fails "
Jozef Bacigal [Tue, 1 Aug 2017 10:50:56 +0000 (12:50 +0200)]
Change return type of events
- remove callback from onDevicePrepared
- added ListenableFuture as return type for events
- added many tests
- small fixes found on test run
Change-Id: Id18bd669589e11a8526bdb77d70ef73df737039c
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 31 Jul 2017 12:01:05 +0000 (14:01 +0200)]
Reconciliation framework binding point improvements
- added tests for mastership service manager
- removed factory managed instantiated direct thought blueprint service
- reconciliation framework returns registration, can be closed directly
- hide explicit unregister method from manager to prevent confuse the consumer
- exception thrown after second reconciliation framework try to register
- reconciliation framework doesn't need register mastership service for disconnect
- added new event for device disconnect into reconciliation framework events
Change-Id: I19f7fdd528e453388f69c34e3669488d4d52644b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 1 Aug 2017 19:11:06 +0000 (19:11 +0000)]
Merge "Remove logback related stuff"
Jozef Bacigal [Tue, 1 Aug 2017 10:15:55 +0000 (10:15 +0000)]
Merge "Lower logging level of FRM reconciliation process"
Tomas Slusny [Tue, 1 Aug 2017 07:31:12 +0000 (09:31 +0200)]
Lower logging level of FRM reconciliation process
Change most of logging to match logging of OpenFlowPlugin sal services
(add and deletion and failures are logged on debug levels) to remove
unnecessary clutter from logs.
Change-Id: I6ae82c8a5125cf2ef35f4b2039f5d31d3f341948
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 31 Jul 2017 15:03:59 +0000 (17:03 +0200)]
Remove missing inPort in PacketIn error
Make new PacketIn message handler behave like old one, and that is that
when there was no inPort, we just set null ingress for packet in
notification.
See also: bug 8772
Change-Id: Ia108f4c732c32a5ebfc22d50c0c63bb93bde71e4
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Aswin Suryanarayanan [Fri, 28 Jul 2017 12:13:40 +0000 (17:43 +0530)]
Bug 8882 - With conntrack SNAT communication with PNF fails
Added support for load metadata action.
Change-Id: Ia1b0454a4aeccd9a04cecb59b50f516264bddb3e
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Fri, 28 Jul 2017 06:41:31 +0000 (12:11 +0530)]
Remove logback related stuff
as discussed on https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001262.html
openflowplugin-it appears to be completely broken anyway, and is not in build
Change-Id: Ic52d5d38754f2692415788d364969d42eadff1e0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tomas Slusny [Thu, 27 Jul 2017 10:35:31 +0000 (10:35 +0000)]
Merge "Remove config knob for reconciliation framework"
Jozef Bacigal [Tue, 25 Jul 2017 10:47:51 +0000 (12:47 +0200)]
Remove config knob for reconciliation framework
Change-Id: I601a28bd55006f5ae74399794a4fd756fb2bc3f0
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Mon, 24 Jul 2017 15:49:45 +0000 (17:49 +0200)]
Close CSS registration in separate thread
Instead of sending initialization of CSS in separate thread,
do closing of registration in separate thread and only in case
we are closing the registration during initialization, to prevent
CSS freezes. Also, when closing CSS service, add checks for connection
state to prevent closing context when connection is already RIP.
See also: bug 8805
Change-Id: I0759f7913937c897f41899a87b699989cdfe4abc
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Fri, 21 Jul 2017 11:40:25 +0000 (13:40 +0200)]
Exctract onDevicePrepared to interface
- In the previous implementation the client was able to register
many of reconciliation frameworks as a mastership service.
This may lead to broken code where each registration of
mastership service could implement own onDevicePrepared.
- Issue with configuration parameter isUsingReconciliationFramework
solved by putting this status into statistics context constructor.
- Removed depricated deviceInfo.getLOGvalue from statistics.
Change-Id: I3691a3cf5eb755671f756815dd99ac2d637f1298
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 11 Jul 2017 07:57:23 +0000 (09:57 +0200)]
Extract mastership blueprint service
Change-Id: I87180a1705c25cb51e9d71e1083e48cd4e52683c
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 11 Jul 2017 07:26:44 +0000 (09:26 +0200)]
Mastershipchange service implementation.
Change-Id: I9ca11e05100a2369ae4a91f1232b4f14435a11f6
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 10 Jul 2017 08:42:25 +0000 (10:42 +0200)]
Mastership service provider API
- create new API for mastership listener
- rename MastershipChangeListener to ContextChainMastershipWatcher
Change-Id: I45e919494039180df895602b6536af37f679cb58
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Fri, 7 Jul 2017 13:15:09 +0000 (15:15 +0200)]
Fix context chain initialization and SLAVE change
- Merge ContextChain and LifecycleService
- Let ClusterSingletonService handle stopping of mastership services in
closeServiceInstance method
- Store cluster singleton initialization future and process it
synchronously in case we are closing
- Cancel device initialization future if we got timeout
- Handle initialization chain order in ContextChain instead of storing
each next phase in contexts
- Remove SLAVE task from scheduler in case we acquired SLAVE role
already
- Prevent adding exactly same auxiliary connection twice to list of
auxiliary connections in ContextChain
- When SLAVE role is obtained from cluster singleton service, notify
MastershipChangeListener about it
- Log exceptions from handshake as warning instead of error (as only
problem is that device gets disconnected and reconnected, what is not
critical)
- In case context chain is still closing and we receive new connection,
drop the connection and let context chain finish closing
See also: bug 8805
Change-Id: If14da19899087018c5e6cc42d195af43c1e89bfd
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 17 Jul 2017 07:40:35 +0000 (07:40 +0000)]
Merge "Remove He-design inventory manager"
Jozef Bacigal [Thu, 13 Jul 2017 07:57:44 +0000 (07:57 +0000)]
Merge changes from topics 'bug/8836', 'bug/8772'
* changes:
Fix match extensions deserialization
Add missing augmentations for extensions
Bail out earlier on alien message
Tomas Slusny [Wed, 12 Jul 2017 11:28:03 +0000 (13:28 +0200)]
Fix match extensions deserialization
Fix transformation of match extensions for different match types during
deserialization so they will not be lost during this process.
Resolves: bug 8836
Change-Id: If089a72759a26b764479e58ea112b3a1a062c90e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Wed, 12 Jul 2017 09:00:55 +0000 (09:00 +0000)]
Merge "Upgrade to odlparent 2.0.2"
Tomas Slusny [Wed, 12 Jul 2017 08:24:58 +0000 (10:24 +0200)]
Add missing augmentations for extensions
- Add apply actions augmentations for nodes->node->table->flow
->instructions to action convertors for nicira extensions
- Add new packet in message augmentations to match convertors for nicira
extensions
See also: bug 8772
Change-Id: I93fd2b05c5b699f6a31e960761da1d8e51a26939
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 10 Jul 2017 10:49:22 +0000 (12:49 +0200)]
Bail out earlier on alien message
Add boolean return to onAlienMessage method that shoudl return true if
alien message was successfully processed. In this case, do not try to
process received OfHeader message as it was processed in alien message
listener to prevent errors when alien message is received when dependant
project is for example gathering statistics.
See also: bug 8772
Change-Id: I2cd50412a6837d61ddbcc1053702b69a7882efc5
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Tue, 11 Jul 2017 12:35:46 +0000 (14:35 +0200)]
Remove He-design inventory manager
See also: bug 8656
Change-Id: If11d9c79abe4f31b85d1bcb2d68a82042cf93dd0
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Tue, 11 Jul 2017 12:13:41 +0000 (12:13 +0000)]
Merge "Remove He-design statistics manager"
Tomas Slusny [Tue, 11 Jul 2017 11:53:57 +0000 (13:53 +0200)]
Upgrade to odlparent 2.0.2
Change-Id: I4d30033a9fd7495c2f75d88ace3d8f25c23e8eba
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Tue, 11 Jul 2017 08:01:39 +0000 (08:01 +0000)]
Merge "BUG-8607: Fix issues in checkstyle enforcement for module openflowplugin-common"
Jozef Bacigal [Mon, 3 Jul 2017 11:45:17 +0000 (13:45 +0200)]
Remove He-design statistics manager
See also:Bug8656
Change-Id: Ie7f2be3af703303691a31aa40eaae31d4ea35eb9
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
David Suarez [Fri, 16 Jun 2017 21:49:38 +0000 (23:49 +0200)]
BUG-8607: Fix issues in checkstyle enforcement for module
openflowplugin-common
- Copyright section
- Line lengths
- JavaDoc
- Formatting
- Enforcement in pom.xml
Change-Id: Ic10c58b7c79760bf9079b53860831cddd7508951
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Tomas Slusny [Tue, 27 Jun 2017 08:49:28 +0000 (10:49 +0200)]
Remove config subsystem from OpenFlowJava
- Remove config subsystem from OpenFlowJava, because it was replaced
by blueprint and it is already removed from OpenFlowPlugin
See also: bug 8747
Change-Id: I9057c3614a47fd19cc797f1f1e299f8d265110a6
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 26 Jun 2017 14:34:09 +0000 (16:34 +0200)]
Integrate OpenFlowJava into OpenFlowPlugin build
- Integrate OpenFlowJava artifacts building into OpenFlowPlugin maven
build
- Merge openflowjava-artifacts with openflowplugin-artifacts
- Remove odl-openflowjava-all feature, because it was unused and
contained only odl-openflowjava-protocol
- Change org.opendaylight.openflowjava groupId to
org.opendaylight.openflowplugin.openflowjava
- Move sample-client to OpenFlowPlugin samples and fix missing license
headers in sample-client
Resolves: bug 8747
Change-Id: I5cff2e93bcbe00aa7543a03c990aa4d61b0878b8
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 26 Jun 2017 11:41:54 +0000 (13:41 +0200)]
Merge OpenFlowJava repository into OpenFlowPlugin
Merge OpenFlowJava into OpenFlowPlugin repository to decrease the
logistics related to the OpenFlow southbound development.
Merged OpenFlowJava HEAD is
https://git.opendaylight.org/gerrit/gitweb?p=openflowjava.git;a=commit;h=
76c83901c7a265e0d00c537d34f3f093c636129c
Old OpenFlowJava repo will serve just for archival purposes.
Detailed informations about this change and mailing lists thread:
https://lists.opendaylight.org/pipermail/openflowplugin-dev/2017-June/007276.html
Resolves: bug 8747
Change-Id: Ic5202e1b3781bb9b02b04683df32468a9f0d8571
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 10 Jul 2017 07:09:23 +0000 (07:09 +0000)]
Merge "ONF Bundles sample application"
Tomas Slusny [Thu, 29 Jun 2017 13:15:36 +0000 (15:15 +0200)]
Add single-layer deserializer for PacketIn msg
Add single-layer deserializer for PacketIn message received from device
to OpenFlowPlugin to prevent deserialization errors when deserializing
PacketIn with single-layer-serialization enabled.
Resolves: bug 8772
Change-Id: I995af3114b808fec1ab214b7b8489c1932861ea5
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 3 Jul 2017 16:45:12 +0000 (16:45 +0000)]
Merge "BUG-8607: Fix issues in checkstyle enforcement for module bulk-o-matic"
Jozef Bacigal [Mon, 3 Jul 2017 10:34:14 +0000 (12:34 +0200)]
Solves compilation error
Change-Id: I41f964260c216fe3ee417c9d874cb58177f4596d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Wed, 28 Jun 2017 11:02:00 +0000 (13:02 +0200)]
Fix NPE in ConnectionContextImpl
- When we receive port status message, in some cases nodeId can be null,
so when logging, get nodeId safely and in case it is null, just log
"null"
- When we are closing outbound queue, log value of nodeId or null in
case nodeId is null
Resolves: bug 8762
Change-Id: Ifda277fd298f7d30fd5e94f07a94e67813971029
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Tue, 27 Jun 2017 07:31:08 +0000 (09:31 +0200)]
Fix statistics polling on parameter
Fix value of statistics polling parameter to not be always
false and to be actually loaded from new configuration
service.
See also: bug 8705
Change-Id: I5d71c4f75a2b0dadc0551a8e763b9e4e36e647d1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
David Suarez [Tue, 23 May 2017 22:27:36 +0000 (00:27 +0200)]
BUG-8607: Fix issues in checkstyle enforcement for module bulk-o-matic
- Copyright section
- Change variables and methods names
- Remove redundant modifiers
- Order imports
- Line lengths
- Declare some static constants properly
- Enforcement in pom.xml
Change-Id: I288ef46a01e5795081d28466ab7a4b9d896a4aa5
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Tomas Slusny [Mon, 19 Jun 2017 12:45:35 +0000 (14:45 +0200)]
Encapsulate OpenFlowPlugin configuration
- Stop sending configuration to OpenFlow managers in long constructors
and send just aggregated configuration in one class
- Add ability to register configuration listener to configuration
service
- Separate configuration service from OpenFlowPluginProviderImpl
- Fix FRM configuration breaking OpenFlowPlugin configuration by trying
to load configuration from openflowplugin.cfg directly, what is only
accesible to main OpenFlowPlugin project by creating configuration
service and passing it to FRM
- Add missing 'disable-reconciliation' flag to FRM yang config, and use
default values from YANG file for FRM configuration
Resolves: bug 8705
Change-Id: I791925bb1964c9eb5a9f1db77fcc25f6425f053f
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 26 Jun 2017 07:23:37 +0000 (07:23 +0000)]
Merge "Report (TCP) port number for switches"
Tomas Slusny [Thu, 25 May 2017 13:26:44 +0000 (15:26 +0200)]
Fix context chain closing
- Close and create EOS registration correctly when closing context
chain holder and creating context chain holder.
- Cancel running scheduled task on context chain holder termination
- Always remove device from DS when we was not able to propagate roles,
not only when we have this device already in context chain map
- Add toleration for adding context chains to queue
- Wait for registration of RPC services before fully granting mastership
for context chain
- Close transaction chain manager on device context close
- Remove unnecessary auxiliary connection gathering in device context
(because this was moved to context chain)
- Fix closing of TxChain when DeviceContext is closed when activating tx
chain manager but not enabling submit transaction (do not try to submit
data)
- Unregister RPC registrations on RpcContext close
- Do not close ClusterSingletonServiceRegistration during
ClusterSingletonService initialization, to prevent freeze of
ClusterSingletonServiceGroup, send it to separate thread
- Prevent propagating of connection closed event twice (add checks for
RIP connection state)
- Fix ignored tests
- Remove getter for table statistics boolean from DeviceContext and just
send it to DeviceInitializer
- Close all RPC contexts when RPC manager is closed
- Do not reschedule statistics one more time when context chain is
closed
Resolves: bug 8668
Change-Id: Ifa8c492486c17a73eccd760fc610a435ef6a42ed
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Wed, 17 May 2017 05:23:39 +0000 (07:23 +0200)]
Fix "stale" state after controller disconnected.
See also: Bug 8411
Change-Id: If5bf24f34a87ef0a7d5514b1c655a42508889724
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 22 Jun 2017 09:33:10 +0000 (11:33 +0200)]
Report (TCP) port number for switches
Write also port number to datastore for OpenFlow switches.
Resolves: bug 2188
Change-Id: I15054b55907b4f15b1567b21f5fa2d35ad416579
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Thu, 22 Jun 2017 15:53:13 +0000 (17:53 +0200)]
Remove config subsystem remains
- Remove what was left from config subsystem from project, as everything
was moved to Blueprint already.
- Cleanup artifacts POM, remove references to config subsystem config
files
Resolves: bug 8728
Change-Id: Ic6adcbc333e816aa15b546e44536d23c8ef4125b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Thu, 22 Jun 2017 08:18:15 +0000 (10:18 +0200)]
Bump to odlparent 2.0.0
- removed feature with dlux dependency
Change-Id: I14db1f6d17624ba890bc1ed6491dfc91876d6a40
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 22 Jun 2017 07:04:32 +0000 (07:04 +0000)]
Merge "Fix checkstyle API."
Tomas Slusny [Tue, 20 Jun 2017 10:44:44 +0000 (12:44 +0200)]
Move Nicira extensions to blueprint
- Add blueprint xmls for OpenFlowPlugin nicira extensions
- Remove CSS-related files from nicira extensions projects
- Stop copying CSS-related xmls during feature installations
Resolves: bug 8718
Change-Id: I115e59b87620f9be60ea9d1d48c9dccbc9c03031
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Tue, 20 Jun 2017 12:55:06 +0000 (14:55 +0200)]
Fix checkstyle API.
Change-Id: Ia25e794c95722f9ff9bf60393bbd18d803296581
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Mon, 19 Jun 2017 08:35:02 +0000 (08:35 +0000)]
Merge "Bug 8647: remove odl-dlux-core as artifact POM"
Jozef Bacigal [Mon, 19 Jun 2017 07:23:30 +0000 (07:23 +0000)]
Merge "Ensure that statistics gathering is terminated"
Stephen Kitt [Fri, 9 Jun 2017 10:11:12 +0000 (12:11 +0200)]
Bug 8647: remove odl-dlux-core as artifact POM
odl-dlux-core is used in dependency management as an artifact POM, but
it isn’t. Removing the declaration is fine since the actual dlux
dependencies specify the version to use.
Change-Id: I83598feb8175d674616a3a3f25c0d52ca1739664
Signed-off-by: Stephen Kitt <skitt@redhat.com>
miroslav.macko [Mon, 29 May 2017 09:41:49 +0000 (11:41 +0200)]
ONF Bundles sample application
- Add group and flows using ONF bundles implementation
Change-Id: Iba0be279a5219947bcd69f7e91eefab6d8d5212f
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Tomas Slusny [Thu, 15 Jun 2017 13:18:39 +0000 (13:18 +0000)]
Merge "Fix connection when slave role request is unsupported"
Tomas Slusny [Thu, 15 Jun 2017 13:15:53 +0000 (13:15 +0000)]
Merge "Fix port update"
Tomas Slusny [Thu, 15 Jun 2017 13:04:30 +0000 (13:04 +0000)]
Merge "Fix 'INPORT' keyword in port field"
miroslav.macko [Wed, 14 Jun 2017 12:06:30 +0000 (14:06 +0200)]
Fix port update
- Update yang models. Add grouping common port with mask.
- Use config mask in the PortConvertor and PortMessageSerializer.
- Update unit tests.
Resolves: bug 4747
Change-Id: If558fea34f86c026ca45ba2853107c2cd82c7f50
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Thu, 8 Jun 2017 13:29:56 +0000 (15:29 +0200)]
Fix connection when slave role request is unsupported
- Allow the switch connection when OFPRRFC_UNSUP is received
- Set feature exception for getGenerationIdFromDevice RPC error
- Add unit test
Resolves: bug 7664
Change-Id: If8d7d045fb516f55346333cc7e60d0ccb2135efd
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Tomas Slusny [Thu, 15 Jun 2017 12:16:22 +0000 (12:16 +0000)]
Merge "Fix SwitchIdleEvent echo request-reply xid"
Jozef Bacigal [Fri, 9 Jun 2017 10:30:27 +0000 (12:30 +0200)]
Fix 'INPORT' keyword in port field
- also fix NPE in serialization by using wrong port number
Enumeration from opeflow java yang files is correct used keyword 'IN_PORT'.
Openflowplugin with the wrong translation (getString instead of getName) used the
keyword 'INPORT'. This fix use the correct name from enumeration but allow use
the legacy 'INPORT' keyword for next release.
Also prevent to throw NPE by using wrong keyword in port field.
Change-Id: If8b3d301d73169fd158a546a233928ab0c65d1c3
Fix: Bug 2095
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 16 May 2017 08:12:18 +0000 (10:12 +0200)]
Ensure that statistics gathering is terminated
Store current statistics gathering future for cancellation instead of
settable future, so we can cancel it when we need to (there is no point
in cancelling settable future other than preventing more statistics
running, but current in-progress statistics gathering will still try
to finish).
Cancel statistics gathering also when become slave.
Resolves: bug 8635
Change-Id: If221a34901b08f8923ae5321a51abd00f4b047b1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 14 Jun 2017 14:15:09 +0000 (16:15 +0200)]
Add Karaf 4 distribution, fix initial config
- Add Karaf 4 distribution for testing to distribution/karaf4.
This distribution will replace current distribution/karaf
after support for Karaf 3 will be removed.
- Fix using Karaf 3 shell commands dependencies, and use
correct ones based on Karaf version specified in distribution
- Fix copying of initial configuration file (wrong path of config
.xml, was `src/main/features/features.xml` but corrected it to
`src/main/feature/feature.xml`)
Resolves: bug 8693
Change-Id: I9d65f9a369e1f7750724a432e37cef944f9dcfb4
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Thanh Ha [Wed, 14 Jun 2017 14:24:33 +0000 (14:24 +0000)]
Merge "Migrate to odlparent 1.9.0"
Thanh Ha [Tue, 13 Jun 2017 20:26:51 +0000 (16:26 -0400)]
Migrate to odlparent 1.9.0
Change-Id: I9d504715f4d75d636ffb9fb1b338221cd836927b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
David Suarez [Fri, 2 Jun 2017 16:23:48 +0000 (18:23 +0200)]
BUG-8607: Replace logger and log by LOG
Replace logger and log by LOG to follow the
OpenDaylight recommendations [1].
[1]
https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices
Change-Id: I77ef621927ba05417736d24c18c6659c7f504917
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Jozef Bacigal [Tue, 13 Jun 2017 06:34:19 +0000 (08:34 +0200)]
Fix SwitchIdleEvent echo request-reply xid
- changed static Long to static Xid
Change-Id: Ib6540078c8143ce6fbe53a4cf379a0b285d53a1e
Solves: Bug-4422
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Mon, 12 Jun 2017 13:26:55 +0000 (13:26 +0000)]
Merge "Fix onSwitchIdleEvent echo request-reply xid"
Jozef Bacigal [Mon, 12 Jun 2017 07:43:41 +0000 (07:43 +0000)]
Merge "HeaderDeserializer and HeaderSerializer for codecs"
Jozef Bacigal [Mon, 5 Jun 2017 11:08:27 +0000 (13:08 +0200)]
Fix onSwitchIdleEvent echo request-reply xid
Solves: Bug-4422
Change-Id: I879e9e6aaf560da486767a68a7e2f015db5a7d95
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 1 Jun 2017 13:53:30 +0000 (15:53 +0200)]
HeaderDeserializer and HeaderSerializer for codecs
Implement HeaderDeserializer and HeaderSerializer for nicira
match codecs.
Resolves: bug 4862
Change-Id: Ia3dbbf622460ecfa3b6a2c48e94e432294a08c0e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 5 Jun 2017 15:47:51 +0000 (17:47 +0200)]
Close OpenFlowPluginProvider during shutdown
- Call close method on OpenFlowPluginProvider during shutdown
- Close all created managers, thread pool and timer during shutdown
- Remove unused notification service
- Remove warning when unknown property is loaded on start (because of
recent FRM changes)
Resolves: bug 8598
Change-Id: Ib5a4f84ea1fa0c957b90ef216346eb85aec81ad0
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Thanh Ha [Fri, 9 Jun 2017 23:09:43 +0000 (19:09 -0400)]
Migrate to odlparent 1.8.0-Carbon
Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.
Change-Id: I7e90ac5f5e9cbe5e2304f3c8711101547a740b98
Jira: RELENG-159
RT: 41406
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Jozef Bacigal [Mon, 5 Jun 2017 14:50:47 +0000 (16:50 +0200)]
Stop reschedule stat. after device disconnected
Resolves: Bug-7940
Change-Id: Ida42676ec5bf6f06fb47837c0532878976eed442
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Fri, 2 Jun 2017 10:29:55 +0000 (12:29 +0200)]
Fix sample-consumer compilation error
Remove deprecated DataBrokerService that was probably removed from
sample-consumer code.
Change-Id: Ief90c7a5ddca7dd08de390ccf6dedc98c20078c1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Thu, 1 Jun 2017 11:07:09 +0000 (13:07 +0200)]
Fix auxiliary connections
See also: Bug-6755
Change-Id: If4964c1a0f07bfdd8104c7254f4b4484fd42d81e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 1 Jun 2017 11:16:32 +0000 (11:16 +0000)]
Merge "Improve flow collection"
Tomas Slusny [Thu, 1 Jun 2017 08:10:28 +0000 (08:10 +0000)]
Merge "Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation"
Jozef Bacigal [Thu, 1 Jun 2017 08:08:31 +0000 (08:08 +0000)]
Merge "Make create-parents in bulk-o-matic not required"