Robert Varga [Thu, 24 Sep 2020 11:21:30 +0000 (13:21 +0200)]
Fix migration warnings in openflowjava-util
We have some use of legacy widened types, fix them up.
JIRA: OPNFLWPLUG-1099
Change-Id: I1266a79d5957f4ae1009258593447f0cadfff40c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 24 Sep 2020 11:18:34 +0000 (13:18 +0200)]
Remove deprecated ActionSerializerKey constructor
Legacy widened-type constructor is not used anywhere, remove it.
Change-Id: Ib1b4225657c5bba3455e2b7edbf53a659b02ce40
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 24 Sep 2020 11:15:02 +0000 (13:15 +0200)]
Remove deprecated ExperimenterActionSerializerKey constructor
This constructor is using widened Long argument and is not used
anywhere, remove it.
Change-Id: I41ef92b1957657c50d1bb5be7a0ca985851b5bf0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Thu, 24 Sep 2020 06:42:05 +0000 (06:42 +0000)]
Merge "Refactor AbstractOxmMatchEntryDeserializer"
Arunprakash D [Thu, 24 Sep 2020 06:41:03 +0000 (06:41 +0000)]
Merge "AbstractOxmMatchEntryDeserializer should be an OFDeserializer"
Robert Varga [Tue, 22 Sep 2020 15:46:58 +0000 (17:46 +0200)]
Bump MRI projects
This patch adopts:
- odlparent-7.0.6
- infrautils-1.8.1
- yangtools-5.0.6
- mdsal-6.0.5
- controller-2.0.4
Change-Id: I56ec950e030e1cb67bb697df85703c8d76dfa95a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 20:02:28 +0000 (22:02 +0200)]
Refactor AbstractOxmMatchEntryDeserializer
All subclassses of AbstractOxmMatchEntryDeserializer follow the same
deserializer pattern. Make sure we eliminate useless getters and
streamline the implementation accordingly.
JIRA: OPNFLWPLUG-1102
Change-Id: I2417ce9f58f7f97acfab91a93d4c346ece3b1208
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 17:55:07 +0000 (19:55 +0200)]
AbstractOxmMatchEntryDeserializer should be an OFDeserializer
All subclasses already also implement OFDeserializer, centralize
that connection.
JIRA: OPNFLWPLUG-1102
Change-Id: I4105e6b71937f43bd649c26aaf4d2cb7f476590e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 17:40:10 +0000 (19:40 +0200)]
Make VersionAssignableFactory implement OFDeserializer
All subclasses are implementing OFSerializer, hence it makes sense
to encode this in the base class. This ends up sharing the offset
of the implementation.
JIRA: OPNFLWPLUG-1102
Change-Id: I53342f0f0ec5ffe37440ee29f6e06c20be5add5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 17:08:44 +0000 (19:08 +0200)]
Fix warnings around SimpleRpcListener
SimpleRpcListener has generic arguments, fix warnings pointing out
unparameterized use.
Change-Id: Ia0a4bd398eddb81bfac1e6459249be685e95d931
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 17:06:27 +0000 (19:06 +0200)]
Remove an unneeded cast
We have a superfluous cast, remove it.
Change-Id: Id325d5b4c1593241a156e6f4560c10ae0bfc6501
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 16:57:27 +0000 (18:57 +0200)]
Eliminate AbstractEmptyActionDeserializer subclasses
Method dispatch works on particular class implementation and
individual per-type subclasses are not bringing anything to the
table.
Change AbstractEmptyActionDeserializer to a final
EmptyActionDeserializer and use its instances to perform duties
previously held by its subclasses.
JIRA: OPNFLWPLUG-1102
Change-Id: I3e1e03a498a15808cf2538fcca651c6c258e07f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 16:50:46 +0000 (18:50 +0200)]
Use ActionContstants in ActionDeserializerInitializer
Rather than using a plain constants, use symbolic names so that we
can neatly cross-reference users.
JIRA: OPNFLWPLUG-1102
Change-Id: I106798adbf77f7e9a9e917b72707ae76b49bae94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Fri, 18 Sep 2020 05:52:50 +0000 (05:52 +0000)]
Merge "Eliminate AbstractEmptyActionSerializer subclasses"
Arunprakash D [Fri, 18 Sep 2020 05:47:54 +0000 (05:47 +0000)]
Merge "Add AbstractEmptyActionSerializer"
Arunprakash D [Fri, 18 Sep 2020 05:39:07 +0000 (05:39 +0000)]
Merge "Make AbstractActionSerializer.serialize() final"
Arunprakash D [Fri, 18 Sep 2020 05:35:56 +0000 (05:35 +0000)]
Merge "Refactor AbstractActionSerializer"
Arunprakash D [Thu, 17 Sep 2020 04:30:36 +0000 (04:30 +0000)]
Merge "Refactor AbstractInstructionSerializer"
Robert Varga [Wed, 2 Sep 2020 16:32:26 +0000 (18:32 +0200)]
Eliminate AbstractEmptyActionSerializer subclasses
Method dispatch works on particular class implementation and
individual per-type subclasses are not bringing anything to the
table.
Change AbstractEmptyActionSerializer to a final
EmptyActionSerializer and use its instances to perform duties
previously held by its subclasses.
In order to aid debugging, we customize its toString() to list
the code being handled.
JIRA: OPNFLWPLUG-1102
Change-Id: Icf7176a62bde41d036c9251ed6e347a85aaa35ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 16:18:10 +0000 (18:18 +0200)]
Add AbstractEmptyActionSerializer
Similar to AbstractEmptyActionDeserializer, we can centralize
common body reads in a single class, eliminating duplicate code.
JIRA: OPNFLWPLUG-1102
Change-Id: I91e02ac81d7f631bc7237e4ea770fad40ca5eb0d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 16:09:10 +0000 (18:09 +0200)]
Make AbstractActionSerializer.serialize() final
We want to reduce the number of megamorphic calls in the serialization
path. Rather than overriding the serialize() method in abstract base
class and call into it, make sure the base class calls out to subclasses
to serialize the body.
This reduces the number of serialize() implementations, peeling common
code into the caller. It also makes it clear there are opportunities
to further reduction.
JIRA: OPNFLWPLUG-1102
Change-Id: I0cb421be9f84fd278039a07107254bfac9ddd9a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 15:48:58 +0000 (17:48 +0200)]
Refactor AbstractActionSerializer
Current structure is causing multiple megamorphic invocations in
the serialization paths. This first step eliminates
getType()/getLength() methods, storing their values in the object
instead.
JIRA: OPNFLWPLUG-1102
Change-Id: Ie806a6a4a011b9235c9b47005927cfc5704f018b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 15:20:35 +0000 (17:20 +0200)]
Refactor AbstractInstructionSerializer
AbstractInstructionSerializer can be made more efficient with
inlining types -- which means we will issue a simple read/load
instead of having to go through virtual dispatch.
JIRA: OPNFLWPLUG-1102
Change-Id: I8c325718715a928a1b24fc75a6de11a6b80eada1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Thanh Ha [Tue, 11 Aug 2020 19:28:57 +0000 (15:28 -0400)]
Bump conf.yaml versions to Silicon
Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ic81fabcf98bf798b92dc08f5d77dc72486f2c549
Dheenadayalan.b [Thu, 13 Aug 2020 08:08:50 +0000 (13:38 +0530)]
OPNFLWPLUG-1105 : Fix for get-active bundle DOMRpcImplementationNotAvailableException
description: GetActive Bundles failed with "No implementation of RPC AbsoluteSchemaPath" exception even after the path registered successfully.
Issue Observered when multiple Switches connected to controller, and some of them were restarted.
During restart previous bundle rpc registrations are overwritten.
Fix done as registrations are stored and retrieved using map.
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>
Change-Id: I4de90445db2f5b29e4fefb2d5bd296cdcd73af8a
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>
Arunprakash D [Tue, 15 Sep 2020 10:24:41 +0000 (10:24 +0000)]
Merge "Refactor AbstractActionDeserializer"
Somashekhar Javalagi [Tue, 21 Apr 2020 05:06:04 +0000 (10:36 +0530)]
OPNFLWPLUG-1089 : Enable matching of a range of tcp/udp-source/destination-ports per flow
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I047fd49aa60f0a9e951eef9f55b0104931a15679
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>
Robert Varga [Wed, 2 Sep 2020 14:34:31 +0000 (16:34 +0200)]
Refactor AbstractActionDeserializer
Looking at AbstractActionDeserializer, we can increase performance
of parseHeader() by eagerly instantiating choice/header objects.
JIRA: OPNFLWPLUG-1102
Change-Id: Ia71bb2d865eaf83627945b1a7039a0978b76be80
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 13:03:11 +0000 (15:03 +0200)]
Remove EncodeConstants.SIZE_OF_{BYTE,SHORT,INT,LONG}_IN_BYTES
These constants are exposed since Java 8 as
{Byte,Short,Integer,Long}.BYTES use them from there instead of
brewing our own.
Change-Id: I3a47659f136165d54f3f97315b0911cc7feaec6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Thu, 10 Sep 2020 08:26:55 +0000 (08:26 +0000)]
Merge "Remove OFConstants.SIZE_OF_LONG_IN_BYTES"
Arunprakash D [Thu, 10 Sep 2020 07:16:07 +0000 (07:16 +0000)]
Merge "Change OFConstants.OFPCML_NO_BUFFER to Uint16"
Arunprakash D [Thu, 10 Sep 2020 06:25:24 +0000 (06:25 +0000)]
Merge "Fix a modernizer warning"
Arunprakash D [Thu, 10 Sep 2020 06:19:56 +0000 (06:19 +0000)]
Merge "Migrate most of openflowplugin to use Uint types"
Arunprakash D [Thu, 10 Sep 2020 06:16:15 +0000 (06:16 +0000)]
Merge "Migrate openflowplugin tests to use Uint types"
Arunprakash D [Thu, 10 Sep 2020 05:11:59 +0000 (05:11 +0000)]
Merge "Fix a raw type warning"
Arunprakash D [Thu, 10 Sep 2020 05:11:23 +0000 (05:11 +0000)]
Merge "Fix javadoc reference"
Arunprakash D [Thu, 10 Sep 2020 05:07:25 +0000 (05:07 +0000)]
Merge "openflow devices are getting disconnected from Controller, sending OFPBFC_BAD_ID error reply"
Arunprakash D [Thu, 10 Sep 2020 04:09:42 +0000 (04:09 +0000)]
Merge "Fix uint warnings in sample-bundles"
Arunprakash D [Thu, 10 Sep 2020 04:08:15 +0000 (04:08 +0000)]
Merge "Fix for openflow devices not connecting to controller"
Arunprakash D [Wed, 9 Sep 2020 15:55:03 +0000 (15:55 +0000)]
Merge "Fix deprecation warnings in learning-switch"
Arunprakash D [Wed, 9 Sep 2020 15:53:33 +0000 (15:53 +0000)]
Merge "Do not parse string multiple times"
Arunprakash D [Wed, 9 Sep 2020 15:51:45 +0000 (15:51 +0000)]
Merge "Remove unneeded boxing"
Arunprakash D [Wed, 9 Sep 2020 15:50:59 +0000 (15:50 +0000)]
Merge "Mark static methods"
dheenadayalan b [Wed, 19 Feb 2020 12:12:05 +0000 (17:42 +0530)]
Fix for openflow devices not connecting to controller
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: I641997a74f5b5081366fcaa1fe9a56b6d1c67f5d
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>
Arunprakash D [Wed, 9 Sep 2020 15:47:10 +0000 (15:47 +0000)]
Merge "GetFlowNodeCache cli"
Arunprakash D [Wed, 9 Sep 2020 15:44:11 +0000 (15:44 +0000)]
Merge "Inventory status check"
Somashekhar Javalagi [Thu, 28 Mar 2019 08:32:34 +0000 (14:02 +0530)]
openflow devices are getting disconnected from Controller,
sending OFPBFC_BAD_ID error reply
Change-Id: I0a13ef1ab35057d9306532f5c0f8c06a1d0db572
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Arunprakash D [Wed, 9 Sep 2020 12:20:55 +0000 (12:20 +0000)]
Merge "Update active committers info"
Shweta Chaturvedi [Wed, 30 Jan 2019 05:52:42 +0000 (11:22 +0530)]
Inventory status check
Change-Id: I68698582247dbd9d9ad38c24c555fb8512e1dcb8
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Shweta Chaturvedi [Fri, 3 Apr 2020 15:17:42 +0000 (20:47 +0530)]
GetFlowNodeCache cli
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I81c5f411a50a91dba08b8e6d46555faf36c6aa7a
Shweta Chaturvedi [Thu, 6 Dec 2018 04:58:05 +0000 (10:28 +0530)]
Increase flow and group dtcn listener changes
Change-Id: Ibfac8b245f1a1b39a6ee58a7fa6e391386fdb0d2
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
D Arunprakash [Tue, 8 Sep 2020 10:49:48 +0000 (16:19 +0530)]
Update active committers info
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: I0bfec2355d23fde4b9ffd824cd97348746a82115
Robert Varga [Wed, 2 Sep 2020 12:56:34 +0000 (14:56 +0200)]
Remove OFConstants.SIZE_OF_LONG_IN_BYTES
This is simple value which matches Long.BYTES, remove it.
Change-Id: I1a32cb7c05e81c9fd3ed0b09634232e8fe0aa758
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 12:50:18 +0000 (14:50 +0200)]
Change OFConstants.OFPCML_NO_BUFFER to Uint16
We are using this constant only for builders, change it to Uint16
so that we skip any conversion.
JIRA: OPNFLWPLUG-1099
Change-Id: Ie59302d05b8ce3d2cad91f30c84038a05cd1e651
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 12:46:44 +0000 (14:46 +0200)]
Migrate most of openflowplugin to use Uint types
Migrate production code to use non-widened values. There are a few
methods left out, as they seem to be performing lossy conversion,
which needs to be investigated separately.
JIRA: OPNFLWPLUG-1099
Change-Id: I7bd10498557396f96a6ec0baf9dccc7b8186b28f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 12:12:46 +0000 (14:12 +0200)]
Migrate openflowplugin tests to use Uint types
Migrate test code to use non-widened values. Production code will
be migrated separately.
JIRA: OPNFLWPLUG-1099
Change-Id: I6723d1f1660a18cd6bc634dac0d91a9cd9199dd9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 10:01:44 +0000 (12:01 +0200)]
Fix a raw type warning
Add a simple wildcard to suppress a warning around raw type.
Change-Id: I7469b88fc4371cf2954cf9dd2688dfedb70fcf23
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 10:01:25 +0000 (12:01 +0200)]
Fix javadoc reference
This is simple copy&paste error, fix it up.
Change-Id: If6266671ebca0e94331bd00d4643971d984bd5ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 09:56:05 +0000 (11:56 +0200)]
Fix uint warnings in sample-bundles
There are a few users here, migrate them to fix warnings.
JIRA: OPNFLWPLUG-1099
Change-Id: I7228b0d0f33ad2e2fb0a72d398ffd1499bf8957b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 09:40:58 +0000 (11:40 +0200)]
Fix deprecation warnings in learning-switch
Convert use of both legacy lists as well as widened types,
eliminating deprecation warnings.
JIRA: OPNFLWPLUG-1099
Change-Id: I6a5d994a96f37a7342517e4adc133d4f8579cc30
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 09:06:11 +0000 (11:06 +0200)]
Do not parse string multiple times
This code block is a simple switch, really, if not even something
simpler.
Change-Id: Ibc4614c6e5f48691e2f8fdfaa1ebc312b7500c94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 08:58:31 +0000 (10:58 +0200)]
Remove unneeded boxing
Use of Integer creates a box-and-unbox operation when coupled
with parseInt() and switch(), just use a plain int.
Change-Id: I62b9d925edf44a22422d14b00b0f413e83ccaf6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 2 Sep 2020 08:59:50 +0000 (10:59 +0200)]
Mark static methods
A number of methods can be made static, make sure they are marked
as such.
Change-Id: Ie8c90c693fea0d873cec8412e6014b8ab56b7b7a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 15:11:20 +0000 (17:11 +0200)]
Migrate test-provider to Uint types
There is a multitude of use of legacy compatibility methods, migrate
them in one go.
JIRA: OPNFLWPLUG-1099
Change-Id: Ibbf23fe87bd1e078921619d944f1b4729b5d593d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 14:16:29 +0000 (16:16 +0200)]
Fixup warnings in openflowplugin-extension-onf
There are a few warnings about raw types and static methods. Fix
them up, improving BundleAddMessageConverter implementation.
Change-Id: If55353cacc4653e01428aad64aaf5a7cce947606
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 14:42:52 +0000 (16:42 +0200)]
Migrate test-common user of deprecated methods
We are using some deprecated Uint- and List-related methods, migrate
to their replacements.
JIRA: OPNFLWPLUG-1099
Change-Id: If4c960c795b49f191ad1644f21fd61464b706135
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 14:09:44 +0000 (16:09 +0200)]
Migrate openflowplugin-extension-onf to use Uint types
There are a few references to old methods in the tests, migrate
them. We do not migrate production code yet, so we have
cross-testing.
JIRA: OPNFLWPLUG-1099
Change-Id: If2a98ede1f661896be80ef43b815910817c59d16
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 14:36:48 +0000 (16:36 +0200)]
Migrate test-extension to use Uint types
There are a few users of legacy methods, migrate them.
JIRA: OPNFLWPLUG-1099
Change-Id: I5e5e41549095e5208fada718202b7a12f4dcc6b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 14:04:13 +0000 (16:04 +0200)]
Mark ConntrackConvertor methods static
There are two utility methods which can be static, mark them as
such to improve clarity.
Change-Id: I54620d97a22b69d8808e1f60d32641b87aa6195f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 14:01:18 +0000 (16:01 +0200)]
Migrate openflowplugin-extension-nicira to use Uint types
There are a few references to old methods in the tests, migrate
them. We do not migrate production code yet, so we have
cross-testing.
JIRA: OPNFLWPLUG-1099
Change-Id: Ib43111cbb3ab8cb8941c76068fb5c23021f1dd0b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 13:50:46 +0000 (15:50 +0200)]
Migrate openflowplugin-extension-eric to use Uint types
There are a few references to old methods in the tests, migrate
them. Since we are in the area, also clean up Mockito/Assert
references.
JIRA: OPNFLWPLUG-1099
Change-Id: I6649244c2366f993e9672f0ce423eade8372d428
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 13:46:18 +0000 (15:46 +0200)]
Remove unused Joiner/Splitter
MatchUtil is no longer using these fields, remove them.
Change-Id: I699d09b5e89969e5615fa9f981bdf8f3615d4459
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 13:33:43 +0000 (15:33 +0200)]
Migrate openflowjava-extension-nicira tests to Uint types
This migrates tests to use Uint types, fixing warnings there while
keeping production code unmodified.
JIRA: OPNFLWPLUG-1099
Change-Id: I3c834253abe207d815528bacd6a5cae7499cfe67
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 12:46:58 +0000 (14:46 +0200)]
Fix raw types in openflowjava-extension-nicira test
We have a few warnings here, fix them up.
Change-Id: Ie0aa8ae6f73a8c282e85cf24acd126052dab05cf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Mon, 7 Sep 2020 07:20:41 +0000 (07:20 +0000)]
Merge "Clean up EricExtensionsRegistratorTest"
Arunprakash D [Mon, 7 Sep 2020 07:19:51 +0000 (07:19 +0000)]
Merge "Use Uint types in openflowjava-extension-eric"
Arunprakash D [Mon, 7 Sep 2020 07:19:14 +0000 (07:19 +0000)]
Merge "Fix raw type warnings in openflowjava-extension-eric test"
Arunprakash D [Mon, 7 Sep 2020 07:18:47 +0000 (07:18 +0000)]
Merge "Remove LLDPDiscoveryUtils.macToString()"
Arunprakash D [Mon, 7 Sep 2020 07:18:24 +0000 (07:18 +0000)]
Merge "Migrate topology-lldp-discovery to use Uint types"
Arunprakash D [Mon, 7 Sep 2020 07:17:55 +0000 (07:17 +0000)]
Merge "Migrate table-miss-enforcer to use Uint types"
Arunprakash D [Mon, 7 Sep 2020 07:14:14 +0000 (07:14 +0000)]
Merge "Cleanup ReconciliationServiceImpl"
Arunprakash D [Mon, 7 Sep 2020 07:11:59 +0000 (07:11 +0000)]
Merge "Migrate notification-supplier to use Uint types"
Arunprakash D [Mon, 7 Sep 2020 07:01:40 +0000 (07:01 +0000)]
Merge "Fix various warnings"
Arunprakash D [Mon, 7 Sep 2020 06:57:38 +0000 (06:57 +0000)]
Merge "Use Assert.assertThrows()"
Arunprakash D [Mon, 7 Sep 2020 06:56:46 +0000 (06:56 +0000)]
Merge "Migrate Mockito methods"
Arunprakash D [Mon, 7 Sep 2020 06:55:20 +0000 (06:55 +0000)]
Merge "Migrate fr-sync to use Uint types"
Arunprakash D [Mon, 7 Sep 2020 06:53:57 +0000 (06:53 +0000)]
Merge "Fix use of raw types in fr-sync"
Arunprakash D [Mon, 7 Sep 2020 06:53:31 +0000 (06:53 +0000)]
Merge "Migrate forwardingrules-manager to uint types"
Arunprakash D [Mon, 7 Sep 2020 06:51:51 +0000 (06:51 +0000)]
Merge "Added RFC 8040 URL, JSON payloads in flow examples"
Robert Varga [Wed, 2 Sep 2020 23:18:55 +0000 (01:18 +0200)]
Fix a modernizer warning
Use a plain concatenation instead of a StringBuffer, which
the modernizer warns against.
Change-Id: Ic22c88b2c56637ff8e2b346ad487e86c456489cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 12:28:28 +0000 (14:28 +0200)]
Clean up EricExtensionsRegistratorTest
We want to use static imports of Mockito methods, plus we want to
use them from non-deprecated locations (ArgumentMatchers).
Change-Id: I0c3e96b892656c7f399d8ae20aa6c28991dfb13d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 12:25:05 +0000 (14:25 +0200)]
Use Uint types in openflowjava-extension-eric
A few tests are referencing old type-widened data types, fix that
up.
JIRA: OPNFLWPLUG-1099
Change-Id: Ifab04353aac232a0f17800c377d0752611981f24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 12:23:44 +0000 (14:23 +0200)]
Fix raw type warnings in openflowjava-extension-eric test
We should be using proper type parameters to retain type safety.
Change-Id: I48c1483135c0fa7674a65498d6e10960ee31bb72
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 12:17:36 +0000 (14:17 +0200)]
Remove LLDPDiscoveryUtils.macToString()
This method is inefficient and not used anywhere. Remove it to keep
our code clean.
Change-Id: Id81bf1c32e9cbdeea281a6fcd840ffb634ea387f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 12:15:46 +0000 (14:15 +0200)]
Migrate topology-lldp-discovery to use Uint types
There are a few callers of legacy methods here, migrate them.
Change-Id: Ie8f552be5fb8c6a0d8bcef04dc7db7327a9edae7
JIRA: OPNFLWPLUG-1099
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 11:51:59 +0000 (13:51 +0200)]
Migrate table-miss-enforcer to use Uint types
There are a few callers of legacy methods here, migrate them.
Eclipse is also flagging Map.get(0) as unlikely -- which is accurate
and means the test is not verify things completely.
JIRA: OPNFLWPLUG-1099
Change-Id: I47ddec6b39a6e0f789d4da1c88bf9e00832d7150
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 11:27:55 +0000 (13:27 +0200)]
Cleanup ReconciliationServiceImpl
The first hint here is the raw ConcurrentHashMap, which turns out
to be immediately overwritten in constructor. After this is fixed
it becomes obvious the field is actually final, not volatile.
Further investigation shows we can improve use of RpcErrorBuilder,
making the code a lot simpler.
Change-Id: I89bc14a6f30f7903d8e54d496e3899b290a03705
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 31 Aug 2020 11:16:33 +0000 (13:16 +0200)]
Migrate notification-supplier to use Uint types
There are a few callers of legacy methods here, migrate them.
JIRA: OPNFLWPLUG-1099
Change-Id: Ibee194f83afa4f54fc76c5c4cbefea957d749017
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Dhiraj Sharma [Mon, 22 Jun 2020 14:02:21 +0000 (19:32 +0530)]
Added RFC 8040 URL, JSON payloads in flow examples
used sphinx code-tabs
Signed-off-by: Dhiraj Sharma <dhiraj.8.sharma@gmail.com>
Change-Id: I8f7cb6dbe85dc2c199f3de94d8c7aaea31725473
Robert Varga [Sun, 30 Aug 2020 22:02:05 +0000 (00:02 +0200)]
Fix various warnings
We can make methods static and do not have to specify generic
arguments. Fix these Eclipse-reported notices.
Change-Id: Ia5825d6c7a48cec489266b162605f7e3984f4a2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Code Review / openflowplugin.git / log