Fix license header violations in transcriber

Change-Id: I07795552f643b85ea26c5e8e652ecbeeebee49e8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in northbound-api

Change-Id: I68ba43112a5d31c45bbf9398fdf1316b477f0edc
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in neutron-spi

Change-Id: I9d8c6990cc29091a0fe829369d8462600a9713c5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove subnet concurrent hash map

This code removes subnet's concurrent hash map and fixes
some issues uncovered in the network interface code.
In addition, it puts back an implementation of getPortsInSubnet,
the removal of which broke ovsdb-netvirt

Change-Id: I250fcb53e404fa1deec655b1f2192aafc2fb8c36
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Make NN more transparent, part III

Remove unused imports, methods, fields and annotations

Change-Id: Id06fef86635a7e07651ac3a16fee71df5d994ba3
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Make NN more transparent, part II"

Merge "BUG #4044 binding:host_id is string, not UUID"

Make NN more transparent, part II

This patch removes all hidden tracking code
previously used by NN as that is already
handled by Neutron (DRY principle)

Change-Id: I9c4041f334d65f7007b68eb7a14eb57a0c08bb9e
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Make NN more transparent, part I"

Fix create of LBaaS pool members

LBaaS pool members should be created by POST,
not PUT.

Change-Id: I8ba68031f6869c7f2fd1d5528e713b623eca0fd1
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Make NN more transparent, part I

This is the first patch in a series to make NN more
transparent.  Invoking DRY, this patch removes all
checks that Neutron performs.

Change-Id: If2493267dfbeaf278420cc443d6ae7d29384b743
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

BUG #4044 binding:host_id is string, not UUID

The attributes of ML2 binding extension, binding:host_id, is string.
By default, the host id is determined by gethostname.
It causes the following exception.

> java.lang.IllegalArgumentException: Supplied value "ls" does not match required pattern "^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$"
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
>         at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid.<init>(Uuid.java:44)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.toUuid(AbstractNeutronInterface.java:100)
>         at org.opendaylight.neutron.transcriber.NeutronPortInterface.toMd(NeutronPortInterface.java:227)
>         at org.opendaylight.neutron.transcriber.NeutronPortInterface.toMd(NeutronPortInterface.java:55)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.updateMd(AbstractNeutronInterface.java:75)
>         at org.opendaylight.neutron.transcriber.NeutronPortInterface.updatePort(NeutronPortInterface.java:182)
>         at org.opendaylight.neutron.northbound.api.NeutronPortsNorthbound.updatePort(NeutronPortsNorthbound.java:473)[373:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at sun.reflect.GeneratedMethodAccessor210.invoke(Unknown Source)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.7.0_79]
>         at java.lang.reflect.Method.invoke(Method.java:606)[:1.7.0_79]
>         at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1511)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1442)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)[196:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)[196:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)[196:com.sun.jersey.servlet:1.17.0]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)[159:org.apache.geronimo.specs.geronimo-servlet_3.0_spec:1.0.0]
>         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.Server.handle(Server.java:370)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:982)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1043)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at java.lang.Thread.run(Thread.java:745)[:1.7.0_79]

Change-Id: Ic61ba6188ebec597cee55cc34e231690a995daa6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Make MDSAL delete synchronous"

Merge "Explicitly set git-review branch to master"

Make MDSAL delete synchronous

Before this patch the future returned by read and put
transactions was wrapped in a get to render the result
synchronous (this is necessary to support Neutron).
Apply this pattern to the future returned by the
delete transaction.

This allows the negative get network test post delete
to work again, so re-enable it.

Change-Id: I2443a07869114ae466549de5f5f03132f5d3bdf1
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Explicitly set git-review branch to master

Change-Id: I612df26f4b37c6eb44cafe296dca8e393eee03b4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove concurrenthashmap from networks... part II

Negative network E2E fetch test after delete has
been commented out as a to do to work out timing...

Change-Id: I253e13f470ddb49d378ad978b1930ab506bd87ee
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Remove concurrenthashmap from networks part I

Add method for reading from mdsal.

Change-Id: I5b0f5efceb8733674b922798b724ae6f5a2f845d
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

cleanup yang model, part VII

Ensure that extensions are included properly and
that augmented MD-SAL objects are properly filled in

Change-Id: Ie986c1638082986fd5ed684e2639939625252b25
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Update yang to catch lost pieces in part VI

These are needed to allow part VII to merge

Change-Id: If7ce638c9be7a38f3afb7d00eb546e4a3551c1b2
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean up yang model - Part VI

Enumerations are not extendable and unions lead to code
that isn't in the normal place.  Remove unions and replace
enumerations with identities/identityrefs as the latter are
extendable.

Change-Id: I1aabd1b4fc59415a5ac8de4df758cd9d1fa756cb
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

Top-level yang file defining identities.

Identities defined for:
- protocol
- probe
- direction
- ip version

Patch set 1: proposal
Patch set 2: desired implementation
Patch set 3: remove whitespaces

Change-Id: I186cd2576ccc0bf78a2c90a472859e4647710d5b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

Clean up yange model - Part V

replace attrs with attributes in securty group, subnets
and vpnaas groupings

Change-Id: Ibaa03b8265f0e2fcb46cb2ee55b47e2b66fc8194
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean up yang model - Part IV

Use attributes instead of attrs in grouping names for
metering and port objects.

Change-Id: I673f0ba5f047e7a5414a5d34b846bb0fea669b25
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Clean up yang model... Part III"

Merge "Add vlan-transparent and mtu attributes to Network pojo"

Merge "Remove duplicated lines in transcriber"

Clean up yang model... Part III

Replace attrs with attributes in L3 and LBaaS model groupings.
This causes some of transcriber project to be rewritten :-(

Change-Id: I5bcba88aedfb3b0a626e104bcd48d9c469b06381
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Clean up yang model part II"

Merge "Run IT tests via per-class static methods."

Clean up yang model part II

Replace attrs with attributes in binding and fwaas groupings

Change-Id: I3cee90332395e2884c70c3e87cb35d9e1d76f585
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "BUG 4015 test_create_floating_ip_specifying_a_fixed_ip_address fails"

Merge "Clean up yang model - Part I"

Clean up yang model - Part I

Replace attrs with attributes on base and admin groups

Change-Id: I912510da4f9f5912e473be428b80aa98a1b82043
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

BUG 4015 test_create_floating_ip_specifying_a_fixed_ip_address fails

tempest.api.network.test_floating_ips.FloatingIPTestJSON.
test_create_floating_ip_specifying_a_fixed_ip_address
fails to create floating ip as follows.

an external network with an ipv4 subnet + an ipv6 subnet is created.
Then, it tries to create floating ip. ODL returns bad request to neutron.

When creating/updating floating ip and attaching interface to router
subnets needs to exist.
The check is done by the number of subnets != 1.
But it should be done the number of ipv4 subnet == 0.

> Traceback (most recent call last):
>   File "tempest/api/network/test_floating_ips.py", line 181, in test_create_floating_ip_specifying_a_fixed_ip_address
>     fixed_ip_address=self.ports[1]['fixed_ips'][0]['ip_address'])
>   File "tempest/services/network/json/network_client.py", line 188, in create_floatingip
>     return self._create_resource(uri, post_data)
>   File "tempest/services/network/json/network_client.py", line 109, in _create_resource
>     resp, body = self.post(req_uri, req_post_data)
>   File "/opt/stack/tempest/.venv/local/lib/python2.7/site-packages/tempest_lib/common/rest_client.py", line 256, in post
>     return self.request('POST', url, extra_headers, headers, body)
>   File "/opt/stack/tempest/.venv/local/lib/python2.7/site-packages/tempest_lib/common/rest_client.py", line 636, in request
>     resp, resp_body)
>   File "/opt/stack/tempest/.venv/local/lib/python2.7/site-packages/tempest_lib/common/rest_client.py", line 747, in _error_checker
>     raise exceptions.ServerFault(resp_body, message=message)
> tempest_lib.exceptions.ServerFault: Got server fault
> Details: Request Failed: internal server error while processing your request.

Change-Id: I9b4fa7c959e52c386cab25d6ac9ab64e1fc8a607
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Add vlan-transparent and mtu attributes to Network pojo

Partially addresses Bug #3824

Change-Id: Icdcefbf850f830be47b62115898ae9d2cb104e03
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Remove duplicated lines in transcriber

Change-Id: I377fc2ff00f750b4a2642419713550fe7cbb88c1
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Run IT tests via per-class static methods.

Rather than define IT cases in the container class,
define them in static methods in each class.  That way
adding new tests to a class involves a single touch point.

Change-Id: Ic6509682906b4387e69db742972ef918a127ca1e
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Add more router tests"

Merge "Add host routes to subnet create IT case."

Add more router tests

Note: this also includes changes to PortTests and
PortInterface objects related to making router tests
work.

Again, this is *NOT* a candidate for stable/lithium
as it changes the semantics of update from an update
passing a delta change to openstack passing the
updated object.

Change-Id: Iaccbafa430affb338fb260dc58eb40f81fb6c158
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Update poms with sonar IT report information

Transcriber and model poms do not inherit from odl-parent,
so they need sonar.jacoco.itReportPath explicitly set

Change-Id: I5268d87f1276035e076c77e92df74987810d198c
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Add host routes to subnet create IT case.

To ensure that host route class methods are covered by IT.

Change-Id: I846a98e24008dd5a4b5b928e3a3205ac84e9c92f
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Integrate md-sal port model and add more port E2E tests"

Merge "Clean up code issues caused by transcriber refactoring"

Integrate md-sal port model and add more port E2E tests

Again, this change is *NOT* a candidate for stable/lithium as
it changes both the sematics of port update *and* it changes
the device-id portion of the yang model from uuid to flat
string.

Change-Id: Ic95d5c4e3125bcd31aecc48f13e8a2e0a2b2720f
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean up unused local variables from transcriber

Change-Id: Ifb8a6ff27152590c28e36d0ca23092e344a85354
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean up code issues caused by transcriber refactoring

Remove unused imports and no need to throw Exception
in added static methods

Change-Id: Idcbf04191052e2c9f52372bd606d1fca2b2a4186
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Add additional subnet E2E tests."

Merge "Clean up overlong start method in Activator"

Clean up overlong start method in Activator

Parcel it out as static methods in each class to make
the pattern more scalable.

Change-Id: I9743b880645219c364f363c662c38416afa20595
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Add additional subnet E2E tests.

Side effects of this are to change the semantics of the
updateSubnet operation, so this change is *not* a
candidate for backport to stable/lithium, even though
it is adding test cases.

Change-Id: I8547b613f8618298b289924f7e7f71540a96f6f3
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Ensure that exceptions are either logged or thrown

This avoids losing exception context...

Change-Id: Iadce03ccf23c496f3ddc8921599432eb9d81dddb
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Code cleanup: use collection interfaces in declarations

Replace HashMap with Map and HashSet with Set in
variable declarations

Change-Id: I364d3673351a273b84ab0daef8bc0a59ecda63d8
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Clean up collapsable if statements"

Code cleanup: remove unused local variables

In addition, in NeutronPort class, remove potential NPE
by reordering comparison with static strings.

Change-Id: Ia00a7be4dbacfd1807b81786ae4436f6e89e65cd
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean up collapsable if statements

Change-Id: I019fa5d09467fe2323ae86c8260e25dacb475758
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean up minor code issues

Remove unused imports and get public/final ordering
correct.

Change-Id: I718360db0a12d88514263fb2e03edbcacf0a9f5e
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Clean code issues in NeutronSubnetIPAllocationPool"

Clean code issues in NeutronSubnetIPAllocationPool

Address the following issues:
1. Rename the class itself (contains underscore)
2. Rename methods that contain underscore
3. Ensure caught exceptions are logged

Also change dependent classes impacted by 1 and 2

Change-Id: I287140b7c5921ca6b0a4f9938e39f0d9f9ed99a8
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean issues in NeutronUtil and PaginateRequestFactory

Fix the following code issues in these two classes:
1. Declare them final.
2. Correct method names
3. Don't assign values to parameters

Change-Id: Ic647e8c197b158bc5b884abb6c05ab9d90eb76fb
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "build failure of neutron"

Add more neutron network IT cases

This patch is a cadidate for cherry picking to stable/lithium.
However, it changes the semantics of the canNetworkBeUpdated
part of the INetworkAware interface and so before we change
that, we need to communicate with other projects.

Change-Id: Ie9c3774fb98ebdb044d9523477bc0fb3112beaba
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Remove commented code blocks"

Merge "Hide constructor of utility classes"

Merge "Add braces on else blocks"

Merge "Fix field naming in NeutronVPNServiceInterface"

Merge "Clean up unnecessary object allocation"

Merge "Clean code in NeutronPort class"

Merge "Fix mac_regex constant name and type"

Merge "Fix inefficient string buffering "

Remove commented code blocks

Change-Id: Ib6b6d327f020d1cfee59abf81e043882f96af9b2
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Hide constructor of utility classes

From squid:
"Utility classes, which are a collection of static members,
are not meant to be instantiated. Even abstract utility
classes, which can be extended, should not have public constructors.

Java adds an implicit public constructor to every class
which does not define at least one explicitly. Hence,
at least one non-public constructor should be defined."

Change-Id: Ibc83dfbf6f1777acccd41e89ef5a371eabfa51d4
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Add braces on else blocks

Found two else blocks without braces...

Change-Id: Icd537c7c72ff79fcb1ac2a11c15ec75cbd960edf
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Fix field naming in NeutronVPNServiceInterface

Change-Id: Id018b0a965385249e0a8fb7c3e74f212a8011dc2
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean up unnecessary object allocation

NeutronSecurityRuleInterface used new Integer to instantiate
objects where Integer.valueOf is more friendly

Change-Id: I98daea7364462f283cee840ab3ce48e430f9ddfc
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Clean code in NeutronPort class

Remove two instances of local variables hiding
class variables and fix a type definition as an
implementation rather than an interface.

Change-Id: I3d70e0af7ffa99e2d2f26a650bc44237c64a5397
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Fix mac_regex constant name and type

Change-Id: Icf6e46bad90d1f45af0e6b28237e52066472e003
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Fix inefficient string buffering

Don't combine arguments in NeutronSubnet_IPAllocationPool

Change-Id: Ibc24747fb08bc9072bca30847ed6f5ec79f8467c
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Remove unused field from NeutronTranscriberProvider

Change-Id: I89897d74e455237b2097cc16e985a4b0709b20f7
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

build failure of neutron

Building with -DskipITs or -DskipTests leads to a failure when
/neutron/integration/test/target/site does not exist.

Change toplevel antrun move directives to not fail on error
as this error is not critical

Change-Id: If64c53ada8414d82c9fd389d0d754bb219764e12
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Consolidate duplicated code from transcriber classes"

Merge "Remove @deprecation from FWaaS classes"

Remove @deprecation from FWaaS classes

FWaaS is not going away in Liberty, so related classes need to hang
around.

Change-Id: Ie9c338a110d42db3cf1ce3513e4012ea5bcd266a
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Consolidate duplicated code from transcriber classes

The AbstractNeutronInterface allows us to consolidate the overwrite
method that was part of multiple classes in transcriber

Change-Id: Ifee0936649d91cb086c2894a9a054ee031b64782
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Change NeutronCRUDInterfaces class from static

This change is intended to make it easier to scale when we
start adding extensions by not requiring code to call static
methods in NeutronCRUDInterfaces

Change-Id: I5b6bb03e992e7ec51fc236b6cccf2876e7b61cf9
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Create custom checkstyle rules for NN

There are some rules in ODL parent checkstyle that
are annoying - this patch allows us to set our own
for some of them

Change-Id: I4045988200508c4976290a526e7d2ee504c58e25
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Adapting reporting approach to work with maven goal order

Because maven goals are set to "clean install", that means
the top level project has to move the IT reports from the
integration test project to itself.

Change-Id: Id7c09fd020739ef335e9ca63df2c3322c22d147a
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Fix code duplication in report to sonar

The patch that got IT reporting working had the nasty
side effect of doubling the LoC reported by sonar
for the module. This patch rearranges things to
fix that and report IT results for each of the modules,
rather than from the IT module.

Change-Id: Ied75efa67ce8843c6650d3a04a333586bf35c747
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "neutron-secgroups.yang: update model for security group"

neutron-secgroups.yang: update model for security group

- neutron security group accepts protocol as integer.
  It's defined as uint8.
- neutron security group defines port as uint16 since
  its port number of UDP/TCP.
  There is no point to define it as uint32.

Change-Id: I6fe01623ad07800a663fbd871dcfb030b9eef098
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Yet another attempt at IT reporting to Sonar

Change-Id: Ic133322d05988ef535890dc2508186f674ac20f7
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Remove model classes from sonar reporting

Change-Id: I53e21a1fb8c4b2dc21c12a3ff73be6fc86143d19
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Try to fix IT reporting to sonar via parameter set

Change-Id: Id25d1578f91fe9abf6ccb4525b4f4b70e3270ce1
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Try #2 to bring IT to sonar

Change-Id: I184b79ec199bf6cc868151287f1e3cb296cd1359
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Bringing IT back on line with reporting to sonar"

Merge "pyang: missing key in neutron port attribute"

Bringing IT back on line with reporting to sonar

Change-Id: Id149e1759e6468c0a9f5bc1111609ba0aadc59be
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Change ut and surefire configuration back to default

Also remove it via failsafe for now

Change-Id: I45c72a59b0885b451fa3237444ff187026f6d168
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

pyang: missing key in neutron port attribute

This patch fixes the following error by pyang.
ip version is missing for extra dhcp attribute and add key statement.

> neutron.yang:42: error: the list at "neutron.yang:42 (at neutron-ports.yang:54)" needs at least one key because it is used as config

Change-Id: Ie2ae3661799fc2b7179f028c4a586a1593e23c69
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>