ovsdb.git
7 years agoBug 5555: Exception during operations on ReadWriteTransaction 90/44090/2
K.V Suneelu Verma [Tue, 16 Aug 2016 17:23:48 +0000 (22:53 +0530)]
Bug 5555: Exception during operations on ReadWriteTransaction

An IllegalStateException can be happened during operations on
ReadWriteTransaction. This was resulting in system not being able to
process any southbound ovsdb events, since the code didn't handle this
exception.

Change-Id: I24ab3acc01fd5fb4d9380ccc8bcc7d332738d242
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
7 years agoBump versions by 0.1.0 for next dev cycle 38/43438/1
Thanh Ha [Mon, 8 Aug 2016 21:50:19 +0000 (17:50 -0400)]
Bump versions by 0.1.0 for next dev cycle

Change-Id: Ic49b3af15fcadabc68d88eb0c891bf6c36eff192
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoMerge "Bug 6352 - [SR3] RPC timeout in JsonRPCEndpoint is not configurable"
Sam Hague [Mon, 8 Aug 2016 18:02:08 +0000 (18:02 +0000)]
Merge "Bug 6352 - [SR3] RPC timeout in JsonRPCEndpoint is not configurable"

7 years agoBug 6352 - [SR3] RPC timeout in JsonRPCEndpoint is not configurable 76/43276/3
Anil Vishnoi [Sun, 7 Aug 2016 02:23:41 +0000 (19:23 -0700)]
Bug 6352 - [SR3] RPC timeout in JsonRPCEndpoint is not configurable

Change-Id: I4d35c64d61a6732441a942abd4a766551506f2d5
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoSwitch from yangtools to mdsal binding APIs 08/43108/4
Robert Varga [Thu, 4 Aug 2016 10:35:26 +0000 (12:35 +0200)]
Switch from yangtools to mdsal binding APIs

This reflects the move of these interfaces from yangtools
to mdsal.

Change-Id: I5532deea7396104a4a850124f9a0ca21c8f275af
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "added support for switch/port fault status for hwvtep schema changes."
Anil Vishnoi [Fri, 5 Aug 2016 21:12:39 +0000 (21:12 +0000)]
Merge "added support for switch/port fault status for hwvtep schema changes."

7 years agoMerge "Docker-compose files for hwvtep IT, ovs 2.4/2.5"
Anil Vishnoi [Thu, 4 Aug 2016 21:12:08 +0000 (21:12 +0000)]
Merge "Docker-compose files for hwvtep IT, ovs 2.4/2.5"

7 years agoMerge changes from topic 'move-karaf-parent'
Anil Vishnoi [Thu, 4 Aug 2016 19:47:30 +0000 (19:47 +0000)]
Merge changes from topic 'move-karaf-parent'

* changes:
  Bug 6278: Switch to use odlparent's karaf-parent
  Bug 6278: Switch to use odlparent's karaf-parent

7 years agoadded support for switch/port fault status for hwvtep schema changes. 72/42772/4
ENIAGUA [Fri, 29 Jul 2016 09:18:15 +0000 (14:48 +0530)]
added support for switch/port fault status for hwvtep schema changes.

Change-Id: I2e66a9dc8f71393168daf0f14e7f1563c4fae1ed
Signed-off-by: ENIAGUA <nishchya.gupta@ericsson.com>
7 years agoDocker-compose files for hwvtep IT, ovs 2.4/2.5 52/43052/3
Josh [Wed, 3 Aug 2016 16:04:22 +0000 (18:04 +0200)]
Docker-compose files for hwvtep IT, ovs 2.4/2.5

Change-Id: Id1b38786f78ee9f9b22e6168c99d9ac3988fc678
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoMerge "Bug 6278: Switch to use odlparent's karaf-parent"
Anil Vishnoi [Thu, 4 Aug 2016 00:12:23 +0000 (00:12 +0000)]
Merge "Bug 6278: Switch to use odlparent's karaf-parent"

7 years agoMerge "Bug 6278: Switch to use odlparent's karaf-parent"
Anil Vishnoi [Thu, 4 Aug 2016 00:12:08 +0000 (00:12 +0000)]
Merge "Bug 6278: Switch to use odlparent's karaf-parent"

7 years agoBug 6278: Switch to use odlparent's karaf-parent 64/43064/1
Ryan Goulding [Wed, 3 Aug 2016 16:38:16 +0000 (12:38 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: I0052370159e7a061bc7aa2566907549b8c416208
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agobug-6326 Modify config, not operational version 79/42979/3
Josh [Tue, 2 Aug 2016 15:15:31 +0000 (17:15 +0200)]
bug-6326 Modify config, not operational version

pull bridge from config before modifying
+ only write controllers that don't already exist

Change-Id: I6f6d2a9fa33459988da8450065714ec86eab5781
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoMerge "Bug 5951 - Termination point config reconciliation"
Anil Vishnoi [Mon, 1 Aug 2016 19:29:47 +0000 (19:29 +0000)]
Merge "Bug 5951 - Termination point config reconciliation"

7 years agoBug 5951 - Termination point config reconciliation 07/42807/2
Vinh Nguyen [Fri, 17 Jun 2016 19:06:01 +0000 (12:06 -0700)]
Bug 5951 - Termination point config reconciliation

Add termination point configuration reconciliation logic
to southbound plugin.

When the OVS switch connects to the ODL, the list of all bridge
and termination point configurations in the config datastore
is obtained. We then listens for any new bridge creations in the
operational DS. If the newly created bridge is in the above described
list, termination point reconciliation is triggered for that bridge.

This is the solution for reconciliation scenarios #5 and #7 in:
https://wiki.opendaylight.org/view/OVSDB_Integration:OVSDB_SB_Reconciliation

Change-Id: Ie0fc8bcbd12a5c1dd763a580db7097a4afd7e01a
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
7 years agoAdd various methods to SouthboundUtils 93/42693/5
Josh [Thu, 28 Jul 2016 11:13:33 +0000 (13:13 +0200)]
Add various methods to SouthboundUtils

These are required by netvirt for vlan
and tunnel support

Change-Id: Ied88f25ca4c22babaedb95bc2bea9190f41d3d29
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoMerge "Add getTerminationPointOfBridge method to SouthboundUtils"
Anil Vishnoi [Fri, 29 Jul 2016 19:27:34 +0000 (19:27 +0000)]
Merge "Add getTerminationPointOfBridge method to SouthboundUtils"

7 years agoMerge "Bug 6304 - Regression in Connection reconciliation functionality"
Vishal Thapar [Fri, 29 Jul 2016 08:34:05 +0000 (08:34 +0000)]
Merge "Bug 6304 - Regression in Connection reconciliation functionality"

7 years agoBug 6304 - Regression in Connection reconciliation functionality 57/42757/1
Anil Vishnoi [Fri, 29 Jul 2016 04:35:07 +0000 (21:35 -0700)]
Bug 6304 - Regression in Connection reconciliation functionality

After enabling the checkstyle, we start catching the
specific exceptions rather then catching all the exception
using Exception. During the retry, connection task encounters
ConnectionException, but nobody catches that exception and
it kills the reconciliation thread, so it does not retry
the connection after first attempt. This patch fixes this
issue and handles the ConnectionException properly.

Change-Id: I0e1f71ea6fa550df484ade9036f7dfe6c9dfa57e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoBug 6284 - Cancellation exceptions during operation execution 75/42675/3
Anil Vishnoi [Thu, 28 Jul 2016 07:27:13 +0000 (00:27 -0700)]
Bug 6284 - Cancellation exceptions during operation execution

Change-Id: Icacfa535dc4ac3aa146ab73d363a9888542e3a8e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoBug 6278: Switch to use odlparent's karaf-parent 63/43063/1
Ryan Goulding [Thu, 28 Jul 2016 16:03:55 +0000 (12:03 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: Ib10f2a4ddeeda607890145cbe277d72c4ebf3d6e
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoBug 6278: Switch to use odlparent's karaf-parent 26/42726/1
Ryan Goulding [Thu, 28 Jul 2016 16:03:28 +0000 (12:03 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: Iafc12b95e41de5b043648149be9eade00773f82b
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoBug 6278: Switch to use odlparent's karaf-parent 25/42725/1
Ryan Goulding [Thu, 28 Jul 2016 16:02:51 +0000 (12:02 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: I0781e8ae2b14af68e32d3048fe17370cca276425
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoAdd getTerminationPointOfBridge method to SouthboundUtils 10/42710/1
Oded Shvartz [Thu, 28 Jul 2016 12:59:23 +0000 (15:59 +0300)]
Add getTerminationPointOfBridge method to SouthboundUtils

instead of duplicating the method for the new netvirt project
the method was added to SouthboundUtils.

Change-Id: Idda2640c80fbbb96a03a5f4f248ccb87ed1c65a2
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>
7 years agoBUG-6136 - Southbound plugin throws IllegalStateException when add bridge config... 32/42332/2
vinoth [Wed, 22 Jun 2016 13:47:20 +0000 (19:17 +0530)]
BUG-6136 - Southbound plugin throws IllegalStateException when add bridge config via POST.
   * Checking isPresent() while reading a OvsdbBridgeAugumentation value.

Change-Id: I1ac53efca678c9e40f46f5e86595b0c1d9e8bc62
Signed-off-by: vinoth <m.vinoth@hcl.com>
7 years agoMerge "Checkstyle fixes (to be enforced)"
Sam Hague [Sat, 23 Jul 2016 19:26:23 +0000 (19:26 +0000)]
Merge "Checkstyle fixes (to be enforced)"

7 years agoMerge "Add support for setting the db schema version"
Sam Hague [Sat, 23 Jul 2016 13:58:13 +0000 (13:58 +0000)]
Merge "Add support for setting the db schema version"

7 years agoAdd support for setting the db schema version 42/42342/2
Sam Hague [Fri, 22 Jul 2016 01:38:49 +0000 (21:38 -0400)]
Add support for setting the db schema version

The db schema was a field in the ovsdb.yang but it was never copied
from the ovsdb to mdsal.

Also removed IT test code that was getting the schema version
via connecting to the ovsdb nodes.

Change-Id: Id7a49f9832c27eec746aeff9d190e9295dbd3244
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoCheckstyle fixes (to be enforced) 44/42344/2
Michael Vorburger [Fri, 22 Jul 2016 21:05:19 +0000 (23:05 +0200)]
Checkstyle fixes (to be enforced)

preparing for https://git.opendaylight.org/gerrit/#/c/41305/ with:
  * Utility classes should have private constructor
  * potential future problems re. hidden fields
  * inner assignments

Change-Id: I616414ed56e468910167a790b5e67a6807600f37
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoFixes for HwvtepSouthboundIT to run 35/42335/1
Sam Hague [Fri, 22 Jul 2016 19:28:49 +0000 (15:28 -0400)]
Fixes for HwvtepSouthboundIT to run

Change-Id: I12adb6221e18fd5d80c9b053c4f03b7d1d79b730
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoCheckstyle fixes for ovsdb test dirs 26/42326/2
Sam Hague [Fri, 22 Jul 2016 16:56:54 +0000 (12:56 -0400)]
Checkstyle fixes for ovsdb test dirs

Change-Id: I96d5843f9b26463f89e54992aea34b2438b571d4
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoFix more Sonar (soon Checkstyle) constant name 49/42249/4
Michael Vorburger [Thu, 21 Jul 2016 16:08:28 +0000 (18:08 +0200)]
Fix more Sonar (soon Checkstyle) constant name

Change-Id: I503e402c80d57c946805385ac542b992eed1cf8a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoBug 6185 - southbound system tests failing when 13/42113/3
Anil Vishnoi [Tue, 19 Jul 2016 19:43:56 +0000 (12:43 -0700)]
Bug 6185 - southbound system tests failing when
run with all other compatible OpenDaylight features.

This patch fixes following issues related to library
connection handling
*.* If any non-ovsdb device (e.g. openflow) sends a
connection request to ovsdb, library does not throw
error message, rather it holds the channel and wait
for timeout.
*.* In the above case, it also publishes the connect/disconnect
notification up to the plugin.
*.* HwvtepConnectionInstance and OvsdbConnectionInstance
is implementing OvsdbClient interface from library, that
is not required. Echo service should be done by the library
and not by the plugin logic code.
*.* RPC Future objects were not cleaned by library,
and that's leaking the memory.
*.* In case of no echo response, library dosn't fail
the respective rpc future object.

Change-Id: If7b26594b057465d0c08638857bdcb76857705e1
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoCheckstyle enforcement for library 71/41271/3
Michael Vorburger [Mon, 4 Jul 2016 12:26:09 +0000 (14:26 +0200)]
Checkstyle enforcement for library

Following relaxation of rule in odl-parent to have JavaDoc not even
enforced on annotation types

Change-Id: I05b27d56062b7d57928eb2f04eb538cdbf482e72
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoReduce IT logging 97/42097/1
Sam Hague [Tue, 19 Jul 2016 21:21:50 +0000 (17:21 -0400)]
Reduce IT logging

Change-Id: Ic86cca7fcd8bfa9829041dd3abd37fa276cde44f
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoMerge "checkstyle fixes for library"
Anil Vishnoi [Tue, 19 Jul 2016 15:19:11 +0000 (15:19 +0000)]
Merge "checkstyle fixes for library"

7 years agoUse StandardCharsets instead of Guava 77/41977/2
Robert Varga [Mon, 18 Jul 2016 14:23:03 +0000 (16:23 +0200)]
Use StandardCharsets instead of Guava

Use of Guava's Charsets for recent Java versions is deprecated.

Change-Id: Iefdaca294dbbcfbcd0a9b97074dd4612f348cfa7
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agocheckstyle fixes for library 33/41933/2
Sam Hague [Sun, 17 Jul 2016 19:58:03 +0000 (15:58 -0400)]
checkstyle fixes for library

Change-Id: If68706ed7cf2bb2c605f4e2b3894c273f57643d3
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoMerge "Add methods to SouthboundUtils for ElanService"
Sam Hague [Mon, 18 Jul 2016 12:10:43 +0000 (12:10 +0000)]
Merge "Add methods to SouthboundUtils for ElanService"

7 years agoFix docker compose ps command 53/41953/1
Oded Shvartz [Mon, 18 Jul 2016 09:10:57 +0000 (12:10 +0300)]
Fix docker compose ps command

Changed docker-compose ps command to use -f <yamlFile>.
This change is necessary after moving the docker-compose.yml file
on the netvirt project to resources folder.

Change-Id: Ibdfde4180519341ada5b105096f85cd2be77964b
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>
7 years agoAdd methods to SouthboundUtils for ElanService 46/41946/2
Josh [Mon, 18 Jul 2016 07:43:53 +0000 (09:43 +0200)]
Add methods to SouthboundUtils for ElanService

Methods are required for creating bridges, etc,
for external physical networks. See:
https://git.opendaylight.org/gerrit/#/c/41925/

Change-Id: I707e8fc5298890a886352dcc90a86159b9f3236c
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoFix IT failure when not running DockerOvs docker 27/41927/1
Josh [Sun, 17 Jul 2016 14:53:27 +0000 (16:53 +0200)]
Fix IT failure when not running DockerOvs docker

Change-Id: If94a12f0ace958609bf135aa639128423a513228
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoBug 5938 - Updated the logging 19/41919/1
ananthip [Mon, 11 Jul 2016 13:49:10 +0000 (09:49 -0400)]
Bug 5938 - Updated the logging

Change-Id: I429f71d27ca751b5a53808defca98a1bbb983977
Signed-off-by: ananthip <ananthip@hcl.com>
7 years agoMerge "Upgrade ietf-{inet,yang}-types to 2013-07-15"
Thanh Ha [Wed, 13 Jul 2016 16:49:49 +0000 (16:49 +0000)]
Merge "Upgrade ietf-{inet,yang}-types to 2013-07-15"

7 years agoFixed check-style error caused by odl parents check-style patch 83/41683/1
Anil Vishnoi [Mon, 11 Jul 2016 22:42:55 +0000 (15:42 -0700)]
Fixed check-style error caused by odl parents check-style patch

Odl parent merged following patch to enable check-style for
generic exception:
https://git.opendaylight.org/gerrit/#/c/41304/

That broke OVSDB because OVSDB project has check-style enabled locally

Change-Id: I2c1a8b162fb79e033b4c833f1f12cb402477cb0e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoUpgrade ietf-{inet,yang}-types to 2013-07-15 20/40820/2
Lorand Jakab [Thu, 23 Jun 2016 23:07:50 +0000 (18:07 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: I2a8143ec58e9c2b174fe532d7d65e8f198f3ea78
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Fix potential future problems re. hidden fields"
Anil Vishnoi [Fri, 8 Jul 2016 03:55:22 +0000 (03:55 +0000)]
Merge "Fix potential future problems re. hidden fields"

7 years agoFix potential future problems re. hidden fields 11/41311/2
Michael Vorburger [Mon, 4 Jul 2016 22:49:50 +0000 (00:49 +0200)]
Fix potential future problems re. hidden fields

None of these changes actually really change code semantics, it does
what it does today, but is hopefully clearer.

Found by Checkstyle.

Change-Id: Ie8a231a9d203ed911c0ea3d9f41eec225af6f270
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoCheckstyle clean-up src/test/java of southbound-impl 66/40966/5
Michael Vorburger [Tue, 28 Jun 2016 20:58:30 +0000 (22:58 +0200)]
Checkstyle clean-up src/test/java of southbound-impl

Change-Id: I4646877449a09d85779d35e85ce565a620818435
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "BUG 6130 - process only qos and queue creates and updates"
Anil Vishnoi [Fri, 8 Jul 2016 02:16:40 +0000 (02:16 +0000)]
Merge "BUG 6130 - process only qos and queue creates and updates"

7 years agoBUG 6130 - process only qos and queue creates and updates 91/41091/2
Eric Multanen [Thu, 30 Jun 2016 08:04:51 +0000 (01:04 -0700)]
BUG 6130 - process only qos and queue creates and updates

Fixes issue where all qos or queue entries - including ones
that had not changed - for an ovsdb node were getting ovsdb
transactions sent to the ovs node when a qos or queue was
created or updated.

This patch only creates ovsdb transactions for qos or queue
entries that have been created or updated.

Change-Id: Ie9eef13deae768dbdc16d6ab2a35e353c1aba6bf
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoFix Sonar (soon Checkstyle) constant name 98/41298/2
Michael Vorburger [Mon, 4 Jul 2016 18:31:30 +0000 (20:31 +0200)]
Fix Sonar (soon Checkstyle) constant name

Change-Id: Ida7d2484956e88883f9da4cc59154d527e637bfd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Fix Sonar (soon Checkstyle) TrailingComment"
Anil Vishnoi [Wed, 6 Jul 2016 08:20:24 +0000 (08:20 +0000)]
Merge "Fix Sonar (soon Checkstyle) TrailingComment"

7 years agoFix Checkstyle "Utility classes should not have (visible) constructor" 10/41310/1
Michael Vorburger [Mon, 4 Jul 2016 22:45:15 +0000 (00:45 +0200)]
Fix Checkstyle "Utility classes should not have (visible) constructor"

Change-Id: Ide9e8ee132cf2c6124dba049966a77a3a385a080
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoFix Sonar (soon Checkstyle) TrailingComment 96/41296/1
Michael Vorburger [Mon, 4 Jul 2016 17:32:29 +0000 (19:32 +0200)]
Fix Sonar (soon Checkstyle) TrailingComment

Change-Id: Ic961c8ae27060cb7ba034ca7a4ffff668d982e58
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Fix ALOTOF Checkstyle violation, and switch over to enforcement."
Sam Hague [Sat, 2 Jul 2016 20:14:22 +0000 (20:14 +0000)]
Merge "Fix ALOTOF Checkstyle violation, and switch over to enforcement."

7 years agoMerge "Schema changes for 1.7.0 support"
Sam Hague [Sat, 2 Jul 2016 19:54:10 +0000 (19:54 +0000)]
Merge "Schema changes for 1.7.0 support"

7 years agoMerge "hwvtep yang changes for 1.4.1"
Sam Hague [Sat, 2 Jul 2016 19:53:30 +0000 (19:53 +0000)]
Merge "hwvtep yang changes for 1.4.1"

7 years agoMerge "Bug 5938 - Improve the logging."
Sam Hague [Sat, 2 Jul 2016 19:43:36 +0000 (19:43 +0000)]
Merge "Bug 5938 - Improve the logging."

7 years agoFix ALOTOF Checkstyle violation, and switch over to enforcement. 67/40967/5
Michael Vorburger [Tue, 28 Jun 2016 21:25:09 +0000 (23:25 +0200)]
Fix ALOTOF Checkstyle violation, and switch over to enforcement.

They're all minor formatting kind of things.

Change-Id: I91a391c2b4d6fd7562872bf0d8349e0531991a82
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Checkstyle clean-up invalid license headers containing Authors."
Sam Hague [Sat, 2 Jul 2016 19:20:48 +0000 (19:20 +0000)]
Merge "Checkstyle clean-up invalid license headers containing Authors."

7 years agoMerge "Bug 5938 - Updated the logging."
Sam Hague [Sat, 2 Jul 2016 19:16:58 +0000 (19:16 +0000)]
Merge "Bug 5938 - Updated the logging."

7 years agoMerge "Bug:5938 Updated Log messages."
Sam Hague [Sat, 2 Jul 2016 19:14:22 +0000 (19:14 +0000)]
Merge "Bug:5938 Updated Log messages."

7 years agoBug 5938 - Improve the logging. 36/41236/2
ananthip [Mon, 27 Jun 2016 12:54:58 +0000 (08:54 -0400)]
Bug 5938 - Improve the logging.

Change-Id: Ic13692f262ec783982c6ae2e259bb44dbe647ffa
Signed-off-by: ananthip <ananthip@hcl.com>
7 years agoBug 5938 - Updated the logging. 23/41223/1
ananthip [Wed, 29 Jun 2016 14:10:39 +0000 (10:10 -0400)]
Bug 5938 - Updated the logging.

Change-Id: I933a9f75ce87a4769c22f194eb06d39e1f669477
Signed-off-by: ananthip <ananthip@hcl.com>
7 years agoSchema changes for 1.7.0 support 26/40926/3
Vishal Thapar [Tue, 28 Jun 2016 11:21:28 +0000 (16:51 +0530)]
Schema changes for 1.7.0 support

This adds the following:
1. ACL.java for ACL table
2. ACLEntry.java for ACL_entries table
3. Reference to ACL table entry in LogicalRouter
4. Reference to ACL table entry in PhysicalPort
5. Add tunnel-key to PhysicalLocator
6. Add other-config to multiple classes as per 1.5.1 an 1.7.0
7. Add replication_mode to LogicalSwitch

Change-Id: I0af839a9792890d5a6b753b8e26fb3ffcc1678de
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
7 years agoCheckstyle clean-up invalid license headers containing Authors. 61/40961/5
Michael Vorburger [Tue, 28 Jun 2016 18:56:42 +0000 (20:56 +0200)]
Checkstyle clean-up invalid license headers containing Authors.

incl. some automated clean-up actions which I make Eclipse do autom.

This is part of a set of changes that are required in order to be able
to enable Checkstyle enforcement for src/test/java as well globally, see
https://git.opendaylight.org/gerrit/#/c/40957/

Change-Id: I37d19d5826135006ff94608ce703d5cc054333fb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agohwvtep yang changes for 1.4.1 71/40771/3
Vishal Thapar [Thu, 23 Jun 2016 13:20:14 +0000 (18:50 +0530)]
hwvtep yang changes for 1.4.1

This adds following to yang:

1. Logical_Router
2. Arp_sources local and remote
3. ACL and ACL Entries
4. Logical_Binding_Stats
5. Fault status for switch and port

Change-Id: If5089785aceb035101b630ce009bb6523c37b3b8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
7 years agoAdd list of contributors 90/40990/1
Stephen Kitt [Wed, 29 Jun 2016 07:47:21 +0000 (09:47 +0200)]
Add list of contributors

This was produced by looking at all the git sign-offs, and matching
where necessary with Gerrit identities.

Change-Id: Ifc3abee21dad9a13415c8902aadffd043603ae00
Signed-off-by: Stephen Kitt <skitt@redhat.com>
7 years agoMerge "Bug 4790 - 'ifindex' column from Interface table on OVS"
Anil Vishnoi [Wed, 29 Jun 2016 06:02:45 +0000 (06:02 +0000)]
Merge "Bug 4790 - 'ifindex' column from Interface table on OVS"

7 years agoUse logger instead of System.out.println (found by Checkstyle) 70/40970/1
Michael Vorburger [Tue, 28 Jun 2016 21:33:46 +0000 (23:33 +0200)]
Use logger instead of System.out.println (found by Checkstyle)

Change-Id: I2aa3f02cea16ba48c51bbeccc4b7de2cae58d461
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoBug 4790 - 'ifindex' column from Interface table on OVS 01/39801/10
Rashmi Pujar [Thu, 2 Jun 2016 21:36:56 +0000 (17:36 -0400)]
Bug 4790 - 'ifindex' column from Interface table on OVS

Change-Id: I66f7a15a36a7c877cdeb3ca6accf761b16a7a962
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
7 years agoBug:5938 Updated Log messages. 07/40907/1
ananthip [Wed, 22 Jun 2016 16:14:57 +0000 (12:14 -0400)]
Bug:5938 Updated Log messages.

Change-Id: I58da3c0d26f03faa8facdfebb06eca17d4b37246
Signed-off-by: ananthip <ananthip@hcl.com>
7 years agoBUG 5746 - Ovasb QoS and Queue enhancements part 2 30/40830/1
Eric Multanen [Sat, 25 Jun 2016 05:42:30 +0000 (22:42 -0700)]
BUG 5746 - Ovasb QoS and Queue enhancements part 2

Fixes 3 integration test errors.  2 errors due to bug
in the new Queue code.  The other error was in the integration
test code as a result of the model changes.

Also, added support to set the qos-id and queue-id based
on the presence of the 'opendaylight-qos-id' and
'opendaylight-qeueue-id' external-id values.  These
external-id keys were placed in the qos and queue
tables respectively by the original qos and queue
plugin support. The corresponding value was the
id value for the row entry used by the md-sal.

The updated qos and queue model enhancement code
use the 'opendaylight-iid' key and stores the
corresponding instance identifier for the qos or
queue object.  Support for using the previous
external-id keys provides backward compatiblity
when connecting to OVS hosts which contain qos
and queue entries created using the older plugin.

Change-Id: Ifd97b1f41a497cadd1060365122cae1fd7cbfe84
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
7 years agoMerge "Bug 5721 - br-int not created in clustered setup"
Anil Vishnoi [Thu, 23 Jun 2016 23:23:44 +0000 (23:23 +0000)]
Merge "Bug 5721 - br-int not created in clustered setup"

7 years agoMerge "Fixing sonar bug 1)Add a private constructor to hide the implicit public one...
Anil Vishnoi [Thu, 23 Jun 2016 23:05:06 +0000 (23:05 +0000)]
Merge "Fixing sonar bug 1)Add a private constructor to hide the implicit public one. 2)removing the block of commented-out lines as part of code cleanup"

7 years agoBug 5721 - br-int not created in clustered setup 41/40541/2
vinh.nguyen [Tue, 17 May 2016 17:47:49 +0000 (10:47 -0700)]
Bug 5721 - br-int not created in clustered setup

When the OVS node is hard-reset in PASSIVE mode, it takes
up to 3 minutes for the controler to detect the connection is gone.
During this time, new connection request from the same node arrives.
The latter connection request causes
CandidateAlreadyRegisteredException because the former connection
has not been cleaned up properly.

This patch fixes the issue by making sure that all stale connections
from the same node are properly cleaned up before processing new
connection request. When a new connection request arrives
all connections from same node are pinged. The pings cause
the stale netty connections to close due to IOException.
Those have not been closed after a timeout will be closed
programmatically. New connection request is then processed after
all stale connections are cleaned up in the OvsdbConnectionService

Change-Id: I8bbce8a81b9850704278220b4b75d2ab21cb34c6
Signed-off-by: vinh.nguyen <vinh.nguyen@hcl.com>
7 years agoFixing sonar bug 92/40792/1
Praveen Mala [Thu, 23 Jun 2016 22:10:04 +0000 (18:10 -0400)]
Fixing sonar bug
1)Add a private constructor to hide the implicit public one.
2)removing the block of commented-out lines as part of code cleanup

Change-Id: Ib9d5f550d6168bff5d02c865568821af1be88ffc
Signed-off-by: Praveen Mala <praveen.mala@intel.com>
7 years agoovsdb enable checkstyle on error 68/40768/3
Sam Hague [Wed, 22 Jun 2016 21:18:15 +0000 (17:18 -0400)]
ovsdb enable checkstyle on error

Change-Id: Ie3105f3cac8b0db4762c68df36c650f6cefdca00
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoMerge changes from topic 'blueprint'
Anil Vishnoi [Thu, 23 Jun 2016 06:01:27 +0000 (06:01 +0000)]
Merge changes from topic 'blueprint'

* changes:
  Add blueprint wiring to library
  Add blueprint wiring for southbound
  Add blueprint wiring for hwvtepsouthbound

7 years agoAdd blueprint wiring to library 37/40637/5
Alexis de Talhouët [Tue, 21 Jun 2016 21:46:12 +0000 (17:46 -0400)]
Add blueprint wiring to library

Change-Id: Ieb404cc0ada8fef56f9ce63ec04ffbb40029a47e
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for southbound 39/40639/4
Alexis de Talhouët [Tue, 21 Jun 2016 22:39:49 +0000 (18:39 -0400)]
Add blueprint wiring for southbound

Change-Id: I6e5cea49f584cc93a2842533287e950eadfabb40
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoBUG 5945: Tunnel updates through Genius not working 97/40697/1
Vishal Thapar [Wed, 22 Jun 2016 12:37:46 +0000 (18:07 +0530)]
BUG 5945: Tunnel updates through Genius not working

When creating tunnels through Genius, bridge information is present only
in operational and not in config. So any data chages that come in will not
have any augmentation. This was fixed as part of BUG 4644 but changes for
DataTreeListener refactored the code and this scenario was missed.

Change-Id: Ie4982d887e555a40984a5f4ff1211b785fe5ee6d
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
7 years agoMerge "BUG 5746 - Ovsdb QoS and Queue model enhancements"
Anil Vishnoi [Wed, 22 Jun 2016 00:46:58 +0000 (00:46 +0000)]
Merge "BUG 5746 - Ovsdb QoS and Queue model enhancements"

7 years agoAdd blueprint wiring for hwvtepsouthbound 38/40638/2
Alexis de Talhouët [Tue, 21 Jun 2016 22:03:17 +0000 (18:03 -0400)]
Add blueprint wiring for hwvtepsouthbound

Change-Id: I973476d85f890f701b2b668dcebef61372e7aa58
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoRemove verbose logging in TransactUtils 57/40557/1
Sam Hague [Mon, 20 Jun 2016 18:24:58 +0000 (14:24 -0400)]
Remove verbose logging in TransactUtils

The two logs removed are repeated constantly for every transaction and don't add much value since this is a utility.

Change-Id: I8d66c9b87e42ad93f3f91da1a5a76e9cb70e12f6
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoMerge "Bug:5938 Added log message for OvsdbDataTreeChangeListener."
Sam Hague [Mon, 20 Jun 2016 10:21:39 +0000 (10:21 +0000)]
Merge "Bug:5938 Added log message for OvsdbDataTreeChangeListener."

7 years agoMerge ".gitignore .factorypath created by m2e-apt"
Anil Vishnoi [Mon, 20 Jun 2016 07:00:58 +0000 (07:00 +0000)]
Merge ".gitignore .factorypath created by m2e-apt"

7 years agoMerge "Patch set 2 ------------ 1. Break this up into 2 patches, as Sam suggested...
Anil Vishnoi [Mon, 20 Jun 2016 06:51:12 +0000 (06:51 +0000)]
Merge "Patch set 2 ------------ 1. Break this up into 2 patches, as Sam suggested. This patch will add new schema dependencies and fix ovsdb code to handle ovsdb node when both schemas are present."

7 years agoBug:5938 Added log message for OvsdbDataTreeChangeListener. 87/40487/2
ananthip [Thu, 16 Jun 2016 17:10:33 +0000 (13:10 -0400)]
Bug:5938 Added log message for OvsdbDataTreeChangeListener.

Change-Id: I4ae256f2564055bac0d79abb275d1f3f371c128f
Signed-off-by: ananthip <ananthip@hcl.com>
7 years ago.gitignore .factorypath created by m2e-apt 22/40522/1
Michael Vorburger [Sun, 19 Jun 2016 15:58:46 +0000 (17:58 +0200)]
.gitignore .factorypath created by m2e-apt

https://github.com/vorburger/opendaylight-eclipse-setup now bundles
https://github.com/jbosstools/m2e-apt, which creates .factorypath files
all over the place.

Change-Id: I34a8edc9a0a4cd65f5e273014a232c0cba106c51
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Support for IT Ping feature"
Anil Vishnoi [Fri, 17 Jun 2016 23:05:16 +0000 (23:05 +0000)]
Merge "Support for IT Ping feature"

7 years agoPatch set 2 61/40261/2
Victor Pickard [Mon, 13 Jun 2016 22:51:17 +0000 (18:51 -0400)]
Patch set 2
------------
1. Break this up into 2 patches, as Sam
suggested. This patch will add new schema
dependencies and fix ovsdb code to handle
ovsdb node when both schemas are present.

2. Only create transaction handlers for
Open-vSwitch database.

3. Revert change to hwvtepsouthbound-it/pom.xml,
so that hwvtepIT test are skipped, until
docker image is published that contains
both Open_vSwitch and hardware_vtep schemas.
See TODO itmes below.

4. Next patch will address items in TODO below.

When the ovsdb node has other schemas, such as
hardware_vtep, the code was creating transaction
handlers for hardware_vtep database, which the ovsdb
code cannot handle.

With this change, all IT tests pass when running
docker image loaded with both Open_vSwitch schema
and hardware_vtep schema.

Additionally, all IT tests pass when running docker
image loaded with only Open_vSwitch schema.

TODO
----
1. Publish docker image that has support for both schemas.

2. Replace assumes in hardware vtep IT to asserts if/when
hardware_vtep schema is not present.

3. Enable HwvtepSouthboundIT tests, in hwvtepsouthbound-it/pom.xml.

4. Sam suggested additional testing to ensure that both ovsdb southbound
and hwvtep southbound can connect at same time to ovsdb node running
both schemas.

5. Confirm deployment model when both schemas are present on
ovsdb node.

Patch set 1
-----------
Add hardwarevtep schema to pom and features.xml.

With these changes, and my docker image with both
ovsschema and hardwarevtep schema(to be published),
library/it tests pass, as well as hwvtepsouthbound-it
tests pass.

Change-Id: I94d24d524dcafaa38c69d129190ea29140efd5c9
Signed-off-by: Victor Pickard <vpickard@redhat.com>
7 years agoMake SchemaVersionMismatchException logging consistent 54/40454/2
Sam Hague [Thu, 16 Jun 2016 14:37:23 +0000 (10:37 -0400)]
Make SchemaVersionMismatchException logging consistent

The logging for the exception was not consistent: The log level varied,
the output varied and the logging of the stack trace varied.

Now a single utility method is called for the log. The level is set
to debug, same text, and the exception message rather than the trace
is logged. In all cases these are not errors because it is expected
that different schema versions may not have support for some columns.

Change-Id: I29ef9d30e2044483da1dfd9dc573d13715d222f1
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoSupport for IT Ping feature 59/40359/2
Josh [Wed, 15 Jun 2016 09:10:37 +0000 (11:10 +0200)]
Support for IT Ping feature

Change-Id: I12860f66d0abcd521bd07756232ede9ccdebfc60
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoBUG 5746 - Ovsdb QoS and Queue model enhancements 72/36772/11
Eric Multanen [Fri, 25 Mar 2016 16:06:29 +0000 (09:06 -0700)]
BUG 5746 - Ovsdb QoS and Queue model enhancements

Update the QoS and Queue model to improve managability
of QoS and Queue tables via MD-SAL config model.

Adds code to update operational md-sal using updated
model.

Adds code to allow creation of queue and qos in same
transaction and assign queue to the qos row via
named-uuid.

QoS and Queue entries can be managed by ODL ID
values instead of needing to know the operational
UUID value.

Adds code to support assignment of QoS to port
by MD-SAL QoS ID.

Adds a QoS entry list to the termination point
model so updates and delete operations can be made
directly on the list instead of updating the
termination point.

Support for ingress policing rate and burst configuration
for interfaces is added.

Includes updated Postman examples.

v2 - clarify some logic based on comment feedback
     add additional qos types: linux-sfq, linux-codel
       linux-fq_codel, egress-policer
v3 - rebase, whitespace
v4 - address review comments
v5 - Changes to address review comments:
     Use a queue-ref (instance identifier instead
       of queue-id in the qos queue list.
     Use a qos-ref (instance identifier instead
       of qos-id in the port qos list.
     Use a key of '1' for the single item port qos list.
     Add instance identifer to the external-ids column
       of the qos and queue tables instead of just id
       value.  Use key of 'opendaylight-iid'.
     Updated the postman collection to account for changes
     Clarified the  comment and code of method
       bytesToHexString in TransactUtils.java.

Still to do:
- update unit tests
- update integration tests

Change-Id: I71ac462afe5a881c621fad9a3c5603e1aab8d021
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
7 years agoremoved unused imports in HwvtepSouthboundUtil.java, 'org.opendaylight.controller... 21/40321/1
Patrick Roanhouse [Tue, 14 Jun 2016 18:43:40 +0000 (14:43 -0400)]
removed unused imports in HwvtepSouthboundUtil.java,  'org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException' and org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepLogicalSwitchAttributes'.

Change-Id: Ia3afae16031f1d43e5c4ccfc54913d636cf4facb
Signed-off-by: Patrick Roanhouse <Patrick.M.Roanhouse@intel.com>
7 years agoMerge "Bug 5976 - Thread leak when connecting/disconnecting ovs nodes"
Sam Hague [Tue, 14 Jun 2016 14:35:32 +0000 (14:35 +0000)]
Merge "Bug 5976 - Thread leak when connecting/disconnecting ovs nodes"

7 years agoMerge "Remove OvsdbDataChangeListener"
Sam Hague [Tue, 14 Jun 2016 12:05:17 +0000 (12:05 +0000)]
Merge "Remove OvsdbDataChangeListener"