D Arunprakash [Fri, 13 Jan 2017 10:50:49 +0000 (16:20 +0530)]
RPC opendaylight-direct-statistics:get-flow-statistics not taking nicira
extension match
Added new MatchPath RPCFLOWSSTATISTICS_FLOWANDSTATISTICSMAPLIST_MATCH.
This will differentiate between the augment model between notification and
rpc.
Change-Id: If80ff86522ba406577b15c4a3d8a30ee364001db
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
(cherry picked from commit
49b53da651c4159841f5e9701df22cbe7e5984e7)
Shuva Jyoti Kar [Wed, 18 Jan 2017 08:38:57 +0000 (08:38 +0000)]
Merge "Bug7485 Make statistics poller parameters configurable." into stable/boron
Robert Varga [Fri, 13 Jan 2017 09:03:20 +0000 (10:03 +0100)]
BUG-5222: do not pull in odl-mdsal-xsql
xsql is deprecated, buggy and never was meant for production
use. Do not pull it in.
Change-Id: Id534d17150a940ffad7f7c757146bca46fa1a923
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit
5b61abe19fce14040eddb8c70bd3a53d1c987a1e)
Sai MarapaReddy [Wed, 4 Jan 2017 18:27:21 +0000 (20:27 +0200)]
Bug7485 Make statistics poller parameters configurable.
Currently the the time intervals used for polling the statistics
are harcoded. (basicTimerDelay, maximumTimerDelay).
This patch helps makes parameters more configurable by defining
current default values in yang. Using BluePrint extensions user
can now configure the parameters without changing the source code.
Change-Id: Ic2d694351ee968a6f360e7a218aa17e69c5e9035
Signed-off-by: Sai Marapareddy <sai.marapareddy@gmail.com>
Slava Radune [Tue, 20 Dec 2016 14:55:21 +0000 (16:55 +0200)]
Bug 7071: adding support for fin-timeout
Add support for serialization/deseralization and encoding/decoding of fin-timeout action.
This action currently is created using the learn action, so we nead only deseralization/decoding way (when flow statistics is sent to odl),
but this patch suppors also the other way of insalling flows from odl, in case it will be needed in the future.
Change-Id: I061100fab61e8d3398fddde98e76493a5afef468
Signed-off-by: Slava Radune <slava.radune@hpe.com>
(cherry picked from commit
1bd4c2b474f6301f9e9282cfc728e714a73fc21e)
Tali [Wed, 4 Jan 2017 18:27:21 +0000 (20:27 +0200)]
Bug 7481 - Flows with nicira actions get corrupted after cluster failure
Change-Id: I7fe988b54af3823e0fad672f1f3c5d7750c9095a
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Shuva Jyoti Kar [Fri, 23 Dec 2016 10:03:07 +0000 (10:03 +0000)]
Merge "Bug 7335 - Flow update rejected by switch generates faulty flow entry in operational DS" into stable/boron
epgoraj [Thu, 27 Oct 2016 11:22:18 +0000 (16:52 +0530)]
BUG:6997 supporting OXM_OF_MPLS_LABEL in nicira extensiona
Description : currently under nicira-extension, MPLS support is not
present in nicira Move action. Mainly in ECMP use-case we need to use
mpls_label under nicira_move_action type. The mpls_label will be using as
example ( move:NXM_NX_REG1[0..19]->OXM_OF_MPLS_LABEL[] )
Change-Id: Ia497b963f30bf9ffcd09430db8ed85661a64859f
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
(cherry picked from commit
d24260189065b6620af4f6829b91313c0a681c6d)
Sai Marapareddy [Tue, 20 Dec 2016 23:42:51 +0000 (15:42 -0800)]
Bug 7415 Reducing the severity of the log message
Whenever there is a change in configuration of l2switch,
bundle refresh happens. When bundles refresh, openflowplugin
pushes the same flow. Changing the severity of of the exception
to warning since it is expected to have a flow with same id.
Change-Id: I69874d14b83053edc97b6d299c8fdb05d7ccdd8c
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>
Jozef Bacigal [Tue, 20 Dec 2016 13:49:21 +0000 (13:49 +0000)]
Merge "Add LOG.isDebugEnabled to add performance." into stable/boron
Jozef Bacigal [Tue, 20 Dec 2016 13:49:13 +0000 (13:49 +0000)]
Merge "Improve class with lambdas. Change wrong parameters and variables." into stable/boron
Jozef Bacigal [Tue, 20 Dec 2016 13:49:05 +0000 (13:49 +0000)]
Merge "Split long lines (>120)" into stable/boron
Jozef Bacigal [Tue, 20 Dec 2016 13:48:59 +0000 (13:48 +0000)]
Merge "Remove unused imports, repair checkstyle first sentence." into stable/boron
Anil Belur [Tue, 20 Dec 2016 04:20:12 +0000 (14:20 +1000)]
Bumping versions by 0.0.1 for next dev cycle
Change-Id: I923c53fef2d3ec12757cea39285decaf46bac906
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Jozef Bacigal [Fri, 2 Dec 2016 11:39:47 +0000 (12:39 +0100)]
Add LOG.isDebugEnabled to add performance.
- one more lambda expression
- test checkstyle corrections
Change-Id: I8973f765394a80d0291b9c203e37f6f8242cac3b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 2 Dec 2016 11:24:26 +0000 (12:24 +0100)]
Improve class with lambdas.
Change wrong parameters and variables.
- checkstyle issues
Change-Id: If7552c83e0f6aac6ac332cdbc592c7f5b6ff4fe3
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 2 Dec 2016 11:14:40 +0000 (12:14 +0100)]
Split long lines (>120)
- checkstyle warning
Change-Id: Iea5fb2c8e572c2f675528ad1aee33099905fe523
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 2 Dec 2016 08:50:59 +0000 (09:50 +0100)]
Remove unused imports, repair checkstyle first sentence.
Change-Id: Ib77770af56584577aeaf7efb7bd47200fd54fb65
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Anil Vishnoi [Sat, 10 Dec 2016 08:53:11 +0000 (00:53 -0800)]
Bug 7335 - Flow update rejected by switch generates
faulty flow entry in operational DS
When flow update request comes to plugin, it cleans up
the flow hashmap for the updated flow, but it does not
clean up the flow with the assumption that in the next
statistics cycle, this stale flow in operational data
store will be overwritten by the new modified flow,
but as reported in the issue, if installation of modified
flow fails, it will leave the stale flow in the data store.
Change-Id: I47905f980aabc83134c6eccfbf0655d48e71484b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Shuva Jyoti Kar [Thu, 8 Dec 2016 08:39:43 +0000 (08:39 +0000)]
Merge "Revert the functional behavior change introduced through" into stable/boron
Anil Vishnoi [Wed, 7 Dec 2016 20:14:43 +0000 (12:14 -0800)]
Revert the functional behavior change introduced through
https://git.opendaylight.org/gerrit/#/c/47138/3
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: I0b8fc5b1e0763bb2b91302647037e1153fd41dc1
Jozef Bacigal [Mon, 5 Dec 2016 11:06:05 +0000 (11:06 +0000)]
Merge "Bug 6820 - Implement SalExperimenterMpMessageService" into stable/boron
Jozef Bacigal [Mon, 5 Dec 2016 11:04:53 +0000 (11:04 +0000)]
Merge "BUG-6890:Flow-Removed Notification configuration" into stable/boron
yunyunhan [Tue, 1 Nov 2016 18:40:15 +0000 (02:40 +0800)]
Bug 6820 - Implement SalExperimenterMpMessageService
Change-Id: Ibfbdea25957b8259a6b5070fb0598172d44108bc
Signed-off-by: yunyunhan <han.yunyun@zte.com.cn>
(cherry picked from commit
2dec517931a2fb352b5391197f2baa305460ad91)
Vinh Nguyen [Fri, 18 Nov 2016 23:03:39 +0000 (15:03 -0800)]
Bug 7209 - Null Pointer Exception in LearnCodecUtil when add learn flow for ipv6
The exception caused by using ByteBuf::readShort
(valid range: -32,768 32,767) for ipv6 etherType '0x86dd'
The fix is to use ByteBuf::readUnsignedShort
Change-Id: I238535565a66692b5d4dbe39b8cb7809867f3cde
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
Shuva Kar [Thu, 10 Nov 2016 05:47:23 +0000 (11:17 +0530)]
BUG-6890:Flow-Removed Notification configuration
Changing the flag to enable/disable flow removed
notification.
Currently the flow-removed notification is controlled by the flag
notification-flow-removed-off which is on by default(value set to false).
However this logic being double-negative causes some confusion to the
end-user. Thus modifying the flag to enable-flow-removed-notification
and setting it to true by default.
The associated logic involved at oyther places have been modified as
well as a part of this commit.
Change-Id: I1452de6e3e72030608c89168f19328d9c6aa8f1c
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jamo Luhrsen [Wed, 9 Nov 2016 18:55:13 +0000 (10:55 -0800)]
lower log level when stats come before flow is written to deviceflowregistry
Change-Id: Ib24b9e97c86b2d1a24610204b61fcf9237871f0e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Shuva Jyoti Kar [Wed, 9 Nov 2016 10:16:34 +0000 (10:16 +0000)]
Merge "Bug 7058 - [Helium Plugin]Stats collection issue when controller disconnect the device" into stable/boron
Tomas Slusny [Thu, 27 Oct 2016 12:35:19 +0000 (14:35 +0200)]
Implement SalExperimenterMpMessageService
Add missing implementation for experimenter multipart message
RPC service and register it as routed RPC implementation
Resolves: bug 6820
Change-Id: I5646f93dd6375b729e995a9e60e6d688f1508559
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
cf84afd05137e68dcda33f88ae30312b649d79a9)
Colin Dixon [Mon, 3 Oct 2016 15:43:08 +0000 (17:43 +0200)]
Improve cleanup after device disconnected event
- Ensure that all contexts are removed from managers at once
at end of disconnect chain right before unregistration from
cluster singleton service
- Prevent closing some services multiple times during device
disconnect chain
- Prevent some NPEs in DeviceInitializationUtils what was caused
by connecting and disconnecting device with no time in between
- Unify all openflow managers to implement OFPManager interface
- Ensure that when we will fail to set device to SLAVE we will wait
until device is removed from operational DS and then continue
Resolves: bug 6672
See also: bug 6710, bug 5271
Actual work done by Tomas Slusny. Colin Dixon merely fixed a merge
conflict.
Change-Id: I3845c7d2a9147125b185d3abcc3fc8dd63ba5da8
Depends-On: I15f89cbd43310b0a8e4b7ac78595eeaaa82a65ee
Co-author: Tomas Slusny <tomas.slusny@pantheon.sk>
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Signed-off-by: Colin Dixon <colin@colindixon.com>
(cherry picked from commit
4a89e389589676a2b6975096ba721cd4c354e1bd)
Jozef Bacigal [Fri, 4 Nov 2016 13:20:23 +0000 (13:20 +0000)]
Merge "Bug 7011 - Race condition in statistics collection related transaction chain handling" into stable/boron
Shuva Jyoti Kar [Fri, 4 Nov 2016 13:12:17 +0000 (13:12 +0000)]
Merge "Optimize port number lookups" into stable/boron
Shuva Jyoti Kar [Fri, 4 Nov 2016 13:11:27 +0000 (13:11 +0000)]
Merge "BUG-6890: Statistics-polling configuration" into stable/boron
Anil Belur [Fri, 4 Nov 2016 00:39:20 +0000 (10:39 +1000)]
Bumping versions by 0.0.1 for next dev cycle
Change-Id: I85a05ba2c9ea0ab3971e7a9930b3f26aa5cc41cb
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Anil Vishnoi [Fri, 28 Oct 2016 15:58:06 +0000 (17:58 +0200)]
Bug 7058 - [Helium Plugin]Stats collection issue when controller disconnect the device
Change-Id: I50164bf9c3f09097d211b9f40a3f2325dee38d45
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Shuva Kar [Mon, 24 Oct 2016 16:21:06 +0000 (21:51 +0530)]
BUG-6890: Statistics-polling configuration
Changing the current flag to enable/disable statistics
polling.
Currently the statistics polling is controlled by the flag
is-statistics-polling-off which is off by default(value set to false).
However this logic being double-negative causes some confusion to the
end-user. Thus modifying the flag to is-statistics-polling-on and setting
it to true by default.
The associated logic involved at oyther places have been modified as
well as a part of this commit.
Change-Id: Ia9a027433611912c11ff0f3166aa6f68efdc6913
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Tomas Slusny [Thu, 27 Oct 2016 08:33:32 +0000 (10:33 +0200)]
Optimize port number lookups
- Remove unnecessary OpenflowPortsUtil#init() and
OpenflowPortsUtil#close() methods and add static constructors
instead, so BiMaps will be initialized only when really needed,
and we do not need to call OpenflowPortsUtil#init() method
everywhere
- Cache inverse port BiMaps in OpenflowPortsUtil to greatly reduce
lookup time in these BiMaps in some methods
- Try to use more short version instead of deprecated
OpenflowVersion to reduce deprecation and to reduce
memory use (less conversions from OpenflowVersion to short)
- Use proper MAX port constant when finding max port number
- Simplify some conditions in OpenflowPortsUtil
- Use proper OF_URI_PREFIX contant in InventoryDataServiceUtil
Resolves: bug 7046
Change-Id: I1ea033963fb48416d004398e2ee72909231aaea6
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
7acab16585770656cf65a826a4bbd9eee31a8822)
Anil Vishnoi [Sat, 22 Oct 2016 12:22:14 +0000 (05:22 -0700)]
Bug 7011 - Race condition in statistics collection related transaction chain handling
Change-Id: Iabc18b2814bf2f49bb6159f0bb8f9f55eda2e07d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
miroslav.macko [Mon, 24 Oct 2016 09:14:37 +0000 (11:14 +0200)]
Fix direct statistics
- Initialize statistics gathering
Resolves: bug 7007
Change-Id: I0970b3c690f0771dbd1637405e3064a984b1ef4c
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
(cherry picked from commit
02eedd8c320e6b9ff7bfafc7cda61e1c963c46bd)
Abhijit Kumbhare [Mon, 24 Oct 2016 05:18:35 +0000 (05:18 +0000)]
Merge "BUG-6890: Edit to cfg file reflecting that statistics collection is turned on by default" into stable/boron
Abhijit Kumbhare [Mon, 24 Oct 2016 05:17:56 +0000 (05:17 +0000)]
Merge "BUG-6890:" into stable/boron
Anil Vishnoi [Sat, 22 Oct 2016 10:56:16 +0000 (10:56 +0000)]
Merge "Remove RoleManager and RoleContext" into stable/boron
miroslav.macko [Tue, 18 Oct 2016 17:06:30 +0000 (19:06 +0200)]
Fix flow matching function
- If flow is not present in DeviceFlowRegistry,
don't write to operational DS.
- Update SalFlowService "update" method
- Update Unit tests
Resolves: bug 6917
Change-Id: If07e94be2d2e8564a2d39d88aec0ea5ea6ac7d19
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
(cherry picked from commit
91cacc74cf40c5fbe27ca912cdf78a27f1e40dd6)
Jozef Bacigal [Mon, 17 Oct 2016 10:25:32 +0000 (12:25 +0200)]
Remove RoleManager and RoleContext
- no more functionality for role manager (after Singleton changes)
- all remain functionality from role-mng and ctx were moved to device-mgn and ctx
Change-Id: I1cc1ef23c45da7b9a4288194caa7f88f7534e409
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Shuva Kar [Tue, 18 Oct 2016 11:31:06 +0000 (17:01 +0530)]
BUG-6890: Edit to cfg file reflecting that statistics
collection is turned on by default
Change-Id: I8a97cb11b1b98189a04daed50961b4a912113749
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Kar [Mon, 17 Oct 2016 08:57:59 +0000 (14:27 +0530)]
BUG-6890:
Fix to provide default values for configurable parameters by
handling the NumberFormatException in case the configurable
parameters are either null or absent
Change-Id: Idb37565167778a900732df2dfef428847b0efd3b
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jozef Bacigal [Thu, 20 Oct 2016 13:19:28 +0000 (13:19 +0000)]
Merge "Optimize LLDP packet check" into stable/boron
GauravBhagwani [Thu, 13 Oct 2016 08:09:34 +0000 (13:39 +0530)]
Bug: 6930 Notiifcation-suppliers was broken
Review contains changes required for making notification-supplier as per
Blueprint Injection method
- Removed Config Subsystem parts - Yang, Config XML, Modules/ModuleFactory
- Added Blueprint XML for notification-supplier
- Removed Config Dependency from features Pom
- Removed references to Config XML
Change-Id: Ifbdcb21140903a668ad0b8dd6e2df666b7e3e37f
Signed-off-by: GauravBhagwani <gaurav.bhagwani@ericsson.com>
Shuva Kar [Mon, 17 Oct 2016 05:55:36 +0000 (11:25 +0530)]
BUG-6890: Updated the cfg file with detailed description
of usage
Change-Id: Ibe772a29107296cb96cf4aa48c1d3cb2dee4f3b2
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Kar [Mon, 10 Oct 2016 08:40:27 +0000 (14:10 +0530)]
BUG-6890: Enabling statistics collection through a config
parameter in openflowplugin.cfg
Change-Id: If7dbedd50d7f23a075c53279654e36d33b212867
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Kar [Mon, 10 Oct 2016 08:27:43 +0000 (13:57 +0530)]
BUG-6890: Enabling echo timout configurable through
config file
Change-Id: I3ff729b418809e8342a491ac6ab2a102f5a1ffe5
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Kar [Mon, 10 Oct 2016 07:11:03 +0000 (12:41 +0530)]
BUG-6890: Enabling barrier configurability through
cfg file
Change-Id: Iaada857a439c7774c6e31c27cc7be1b26c68ad1b
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
miroslav.macko [Fri, 7 Oct 2016 09:19:57 +0000 (11:19 +0200)]
Optimize LLDP packet check
Deserialize only LLDP packets.
See also: bug 1462
Change-Id: Ibdd2f3eb0dfe784fd235e51a591da64971c2afd3
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
(cherry picked from commit
10922cdfdcbc4c14456cd6a387468e11bb9b802e)
miroslav.macko [Mon, 3 Oct 2016 16:07:15 +0000 (18:07 +0200)]
Bug 6745 SimplifiedOperationalListener optimation
- optimize processNodeModification method
- update test
Change-Id: I941a84bff4322c2b2b64f8404791ec6d00a9d200
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
(cherry picked from commit
40b60339e5e8aeb07e782f8c34b5c2ef50da56ab)
Andrej Leitner [Wed, 28 Sep 2016 12:45:46 +0000 (14:45 +0200)]
Bug 6745 Do not skip first data for reconciliation
- we can accept first modification since all statistics
are intentionally collected in one step on startup
- added test
- updated comments
Change-Id: I94590fb268accb0237260a09d184c2cecd1fb324
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Wed, 28 Sep 2016 07:17:40 +0000 (09:17 +0200)]
Create SemaphoreKeeper inside decorators
Change-Id: I29fb2da53d32b331459a4492ca15a4081ea79195
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
(cherry picked from commit
191d8581d6e34829141ee7c44c6e05e98379b86d)
Andrej Leitner [Tue, 27 Sep 2016 12:13:29 +0000 (14:13 +0200)]
Bug 6745 Improve compression queue locking and handle InterruptedException
- compression queue could be locked per device and not for every change
since there is only one entry per device in it
- IE handled in one place
Change-Id: Ic28b448d619c663757f391e7a443b28c8f6a871d
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Tue, 27 Sep 2016 10:00:43 +0000 (10:00 +0000)]
Merge "Add finals and move thread name constant to provider" into stable/boron
Andrej Leitner [Tue, 27 Sep 2016 06:59:17 +0000 (08:59 +0200)]
Revert "Bug 6745 Do not ignore syncup return value"
This reverts commit
df561a83c33b7af9818d8d0d0e8e6b00f7a37a93.
Change-Id: I9133264ba297bf4293a50e26e1d2e1051df1f093
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Mon, 26 Sep 2016 14:24:18 +0000 (16:24 +0200)]
Add finals and move thread name constant to provider
- add onDTC annotations
- code cleanup
Change-Id: I585d08e67138805672d19293892358205650c998
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Mon, 26 Sep 2016 15:32:16 +0000 (15:32 +0000)]
Merge "Bug 6745 Set compression semaphore to fair" into stable/boron
Jozef Bacigal [Mon, 26 Sep 2016 15:32:06 +0000 (15:32 +0000)]
Merge "Bug 6745 Do not ignore syncup return value" into stable/boron
Jozef Bacigal [Mon, 26 Sep 2016 15:31:59 +0000 (15:31 +0000)]
Merge "Bug 6745 Remove thread renaming and unnecessary logging" into stable/boron
Jozef Bacigal [Mon, 26 Sep 2016 14:55:47 +0000 (14:55 +0000)]
Merge "Bug 6745 Fix replacing in compression queue" into stable/boron
Andrej Leitner [Mon, 26 Sep 2016 10:55:43 +0000 (12:55 +0200)]
Bug 6745 Set compression semaphore to fair
- prevent changing the order of incoming changes
Change-Id: If7df69334b2ff8217986cd933e25463cb6e90171
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Mon, 26 Sep 2016 09:40:18 +0000 (11:40 +0200)]
Bug 6745 Do not ignore syncup return value
Change-Id: Ide811a0db0d684dc3b37ea3f6707d779162cb87f
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Mon, 26 Sep 2016 08:05:36 +0000 (10:05 +0200)]
Bug 6745 Remove thread renaming and unnecessary logging
- change name format for thread pool
- remove thread renaming and useless logging
- remove duplicit time logging
- update return values
Change-Id: I78abca1870d278c162a7f717ff800dd37c1d4234
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Mon, 26 Sep 2016 08:29:26 +0000 (10:29 +0200)]
Bug 6745 Fix replacing in compression queue
When there were more changes in a row on startup it could happend
that the first syncup entry (config-operational) was not updated
but replaced with following config-config changes. Therefore we need
to update syncup entry in compression queue everytime when new config
diff is comming (not only if config-config entry resides there).
Change-Id: I9d73fb348f5e1ace1b138052bcd2a5614946efa9
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Tomas Slusny [Mon, 26 Sep 2016 08:34:02 +0000 (10:34 +0200)]
Write SwitchFeatures to operational datastore
Ensures that SwitchFeatures are written to operational
datastore during device initialization in Lithium design.
Fixes: bug 6764
Change-Id: Ib32f15b73febe4d9115884d418bfe87b8e716635
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
(cherry picked from commit
d9f1912971b382f39e55635d19922d9e269c103d)
Andrej Leitner [Wed, 21 Sep 2016 12:34:38 +0000 (14:34 +0200)]
Remove excessive (trace) logging in FRS
- removed not so necessary logging + some updates
- added some finals
- simplify statements
Change-Id: I0db57a38a45efd6bb8334a9f05cdba991bff556d
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Thu, 22 Sep 2016 08:37:02 +0000 (08:37 +0000)]
Merge "Fix translation to *packet.received.MatchBuilder" into stable/boron
Anil Vishnoi [Wed, 21 Sep 2016 07:09:30 +0000 (07:09 +0000)]
Merge "BUG-6118: making the OFentityListener aware of the InJeopardy() flag" into stable/boron
Shuva Jyoti Kar [Wed, 21 Sep 2016 06:53:48 +0000 (06:53 +0000)]
Merge "Bug 6633 : NXM_OF_IN_PORT support in openflowplugin" into stable/boron
Jozef Bacigal [Wed, 21 Sep 2016 06:52:37 +0000 (06:52 +0000)]
Merge "ClusterSingletonService cleaning FRM/FRS" into stable/boron
Jozef Bacigal [Wed, 21 Sep 2016 06:45:13 +0000 (06:45 +0000)]
Merge "Bug 6749: Set the openflow connection config at xml file" into stable/boron
Jozef Bacigal [Wed, 21 Sep 2016 06:42:10 +0000 (06:42 +0000)]
Merge "Update comments and imports after DataChangeListener changes" into stable/boron
Tomas Slusny [Tue, 20 Sep 2016 07:22:45 +0000 (09:22 +0200)]
Fix translation to *packet.received.MatchBuilder
Fix incorrect cast of *flow.MatchBuilder to
*packet.received.MatchBuilder in Helium plugin, what
was causing PacketInTranslator to be broken.
Fixes: bug 6456
Change-Id: I9e42402a3599dd2e0a91381019c4ca86e8294aa2
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Tue, 20 Sep 2016 09:11:16 +0000 (11:11 +0200)]
Create DeviceMasterShipManager before forwarders
This prevents NPE when forwarder receives DataTreeChange
event faster thatn DeviceMasterShipManager is created.
Fixes: bug 6459
Change-Id: Ifb9d4520b58d9f5fc265934968386641c60772ef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Chetan A G [Tue, 6 Sep 2016 04:21:48 +0000 (09:51 +0530)]
Bug 6633 : NXM_OF_IN_PORT support in openflowplugin
Description : OVS split-horizon logic will drop pkts by default if value
of in_port and out_port is same. But, if we have two vlan-trunk member
VM for which trunk interface is same, the connectivity between these two
VM cannot be established as OVS drops such packets. So, it is required to
override the value of in_port so that split_horizon check is bypassed.
Nicra NXM_OF_IN_PORT support is required in order to achieve this. The
in_port value will be overrriden using load(ex:
load:0->NXM_OF_IN_PORT[]).
Change-Id: Ica0a1b2da27fc189b8906462a4420473215a22af
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Andrej Leitner [Mon, 19 Sep 2016 16:40:43 +0000 (18:40 +0200)]
Update comments and imports after DataChangeListener changes
Change-Id: Ic8174cc2627deb12d48f6d41444f2e9b4dc60406
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
(cherry picked from commit
049ffd00ea4e24fe3fb3d4f6abeaf51390ddd316)
melserngawy [Fri, 16 Sep 2016 21:15:51 +0000 (17:15 -0400)]
Bug 6749: Set the openflow connection config at xml file
Set the openflow connections (default and legacy) inital configuration
to xml file to be able to change it after starting the distribution
The openflow TLS configuration was missing in the blueprint,
add it with default values
Change-Id: Iad34bd3d7e237da52fe3193c4ad6d6ff2141358c
Signed-off-by: melserngawy <melserngawy@inocybe.com>
Tomas Slusny [Tue, 13 Sep 2016 06:26:15 +0000 (08:26 +0200)]
Fix connection closing before initialization
Check if connection is fully initialized when closing
objects created during initialization phase to prevent
NPEs, what can cause incorrect close of connection
and later program unstability.
Also, increase timeout to propagate role to 10 seconds
in case of slower machine.
Resolves: bug 5271
See also: bug 6672
Change-Id: I0f009edf5fe3b382e2bfee64f72036ba599ccc5d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jozef Bacigal [Mon, 19 Sep 2016 12:35:55 +0000 (12:35 +0000)]
Merge "Bug 6665 Clean code" into stable/boron
Jozef Bacigal [Mon, 19 Sep 2016 12:35:38 +0000 (12:35 +0000)]
Merge "SONAR TD - StatisticsContextImpl, StatisticsManagerImpl" into stable/boron
Jozef Bacigal [Mon, 19 Sep 2016 12:34:41 +0000 (12:34 +0000)]
Merge "Update comments around flat-batch service" into stable/boron
Jozef Bacigal [Mon, 19 Sep 2016 12:34:30 +0000 (12:34 +0000)]
Merge "Update old links in code to deprecated DataChangeListener" into stable/boron
Jozef Bacigal [Mon, 19 Sep 2016 12:34:17 +0000 (12:34 +0000)]
Merge "Convert OF samples to use DTCL instead of DCL" into stable/boron
Jozef Bacigal [Mon, 19 Sep 2016 12:34:08 +0000 (12:34 +0000)]
Merge "Convert openflowplugin-it to use DTCL instead of DCL" into stable/boron
Jozef Bacigal [Thu, 8 Sep 2016 14:56:30 +0000 (16:56 +0200)]
Bug 6665 Clean code
Change-Id: Ia87a66c37f906a3351f3a982209f6778f7c8a311
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Andrej Leitner [Tue, 30 Aug 2016 13:16:51 +0000 (15:16 +0200)]
ClusterSingletonService cleaning FRM/FRS
Change-Id: I7c9a31ccab5b7b79b318cc7b59742aa5652e41f8
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Mon, 19 Sep 2016 08:26:14 +0000 (08:26 +0000)]
Merge "Bug 6665 - Fix switches scalability" into stable/boron
Tomas Slusny [Tue, 19 Jul 2016 12:51:28 +0000 (14:51 +0200)]
SONAR TD - StatisticsContextImpl, StatisticsManagerImpl
- Reduced cyclomatic complexity of
StatisticsContextImpl.chooseStat
- Reduced cyclomatic complexity of
StatisticsManagerImpl.pollStatistics
- Fixed naming of instance fields to match
'^[a-z][a-zA-Z0-9]*$' expression
Change-Id: Ieb9d06cda534b01240ba2a952c927667ece5565b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
(cherry picked from commit
5c853ea0a399706a0a475638f9c542945a993bd9)
Jozef Bacigal [Mon, 19 Sep 2016 08:23:42 +0000 (08:23 +0000)]
Merge "Bug 6542 FRS - prevent concurrent reconciliation node config add" into stable/boron
Andrej Leitner [Tue, 13 Sep 2016 12:16:26 +0000 (14:16 +0200)]
Update comments around flat-batch service
Change-Id: I62f3ccbf38fd6f5aeb830e55c5f60923c6f8e8da
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Wed, 14 Sep 2016 14:39:28 +0000 (16:39 +0200)]
Convert openflowplugin-it to use DTCL instead of DCL
Change-Id: I8a3f3b690bef5d29dcd9b51e243bd83ad5c501c6
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Wed, 14 Sep 2016 14:25:50 +0000 (16:25 +0200)]
Convert OF samples to use DTCL instead of DCL
Change-Id: I53eebe8672996ed4351240a8c649e6c2815e8a0c
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Tue, 13 Sep 2016 12:57:50 +0000 (14:57 +0200)]
Update old links in code to deprecated DataChangeListener
- update old links to DataChangeListener in comments, logs,
names of variables since DataTreeChangeListener is already used
- optimize imports and cleanup
Change-Id: I20f3359f5f7c4bbd3af844bc45506a5575c98285
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Thu, 8 Sep 2016 09:25:30 +0000 (11:25 +0200)]
Bug 6665 - Fix switches scalability
- Stop gathering services if going to be slave or disconected
- Duplicate code removed in role context
- Lifecycle service LOG info cleaning
- Propagate close even if we are in close state
- NPE in statistics manager
- Test correction
Change-Id: Iaad1a8ed4abc3d39014713ca018d6357f8a95267
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Anil Belur [Thu, 15 Sep 2016 23:17:50 +0000 (09:17 +1000)]
Bumping versions by 0.0.1 for next dev cycle
Change-Id: If04c10d7c9a489faec364428265f5a979dadcd70
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Shuva Kar [Tue, 28 Jun 2016 15:52:31 +0000 (21:22 +0530)]
BUG-6118: making the OFentityListener aware of the InJeopardy() flag
Change-Id: I8e489b9afd7f433b924e009fe8ba64166b7c146e
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>