groupbasedpolicy.git
9 years agoClassifiers - implementation changes. 04/17204/16
Tomas Cechvala [Thu, 26 Mar 2015 23:03:29 +0000 (16:03 -0700)]
Classifiers - implementation changes.
This commit solves bug 2883.

Change-Id: I1b5b886734833bd30129c71be78eb3a5af4387a8
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
9 years agoAdded java code formatter and formatting of opflex java files 75/17575/1
Martin Sunal [Wed, 1 Apr 2015 18:04:30 +0000 (20:04 +0200)]
Added java code formatter and formatting of opflex java files

Java formatter is added groupbasedpolicy/commons/cleanCode/eclipse-java-clean-code-style.xml
Contributors should use this java formatter. It ensures the same look and feel of a code over GBP project.
Java files in opflex renderer have been formatted by this formater.

How to set formatter in Eclipse:
Window -> Preferences
          -> Java
             -> Code Style
                -> Formmater: Import...(eclipse-java-clean-code-style.xml)

Signed-off-by: Martin Sunal <msunal@cisco.com>
9 years agoMerge "Move utility function to common place."
Keith Burns [Wed, 1 Apr 2015 14:23:40 +0000 (14:23 +0000)]
Merge "Move utility function to common place."

9 years agoremove printStackTrace calls from EndpointManager.java and OpenstackGbpEndpoint.java... 11/17511/1
Tony Klink [Wed, 1 Apr 2015 01:08:47 +0000 (18:08 -0700)]
remove printStackTrace calls from EndpointManager.java and OpenstackGbpEndpoint.java and replace with error logging.

Change-Id: Ieed6f892cd75b064610ba53bf6b00764fecdfe92
Signed-off-by: Tony Klink <tony.klink@intel.com>
9 years agoMerge "Marked OpenstackGBP API Deprecated, cleaned up minor todos at same time, ready...
Thomas Bachman [Sun, 29 Mar 2015 15:41:22 +0000 (15:41 +0000)]
Merge "Marked OpenstackGBP API Deprecated, cleaned up minor todos at same time, ready for TODO sprint."

9 years agoScope change for OfTable. 07/17207/2
Thomas Bachman [Fri, 27 Mar 2015 01:08:09 +0000 (21:08 -0400)]
Scope change for OfTable.

The OfTable class provides protected acces to OpenFlow Overlay
renderer classes for the Flow Tables (e.g. SourceMapper,
DestinationMapper, et. al.). This limits access to just
the Flow Table classes themselves. This patch moves that
to a separate class with private members and public getters
so that the state can be accessed by any class that has the
new object (e.g. Action classes will use this in future patches).

Change-Id: I21aefa959c97453cdfa8f7f5b668f468dfd7aa5d
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoMove utility function to common place. 49/17149/2
Thomas Bachman [Thu, 26 Mar 2015 11:56:58 +0000 (07:56 -0400)]
Move utility function to common place.

The utility function is helpful byeond just the flow
table use cases.

Change-Id: If1578fe6dd680b956d1be5bb6609987cdbaff2ad
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoImplementing portrange in L4Classifier. 28/15828/10
Keith Burns (alagalah) [Wed, 25 Mar 2015 23:30:10 +0000 (16:30 -0700)]
Implementing portrange in L4Classifier.

Renaming createUdpMatches and createTcpMatches arguments.

Change-Id: I386283e833a2b4986057563f8b7db6a9ed4f2347
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoRevert "Implementation of IP address classifier. Functionality is blocked by bug... 33/17133/1
Tomas Cechvala [Wed, 25 Mar 2015 21:53:42 +0000 (21:53 +0000)]
Revert "Implementation of IP address classifier. Functionality is blocked by bug 2866."

This reverts commit d62684b701f0a0e94861bb889680979705350c8c.

Change-Id: I1cf3e0654fc3520d129383de8e85a41934664f02
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
9 years agoMarked OpenstackGBP API Deprecated, cleaned up minor todos at same time, ready 83/17083/1
Keith Burns (alagalah) [Wed, 25 Mar 2015 04:02:33 +0000 (21:02 -0700)]
Marked OpenstackGBP API Deprecated, cleaned up minor todos at same time, ready
for TODO sprint.

Change-Id: Ic87fc3d6146464cc4cfde3ba470a45f2cd83f5b3
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoImplementation of IP address classifier. 64/16764/5
Tomas Cechvala [Wed, 18 Mar 2015 12:54:02 +0000 (13:54 +0100)]
Implementation of IP address classifier.
Functionality is blocked by bug 2866.

Change-Id: Iec272e5422c9f4002064c04446f2ec1cd99752e9
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoMerge "Added support for multiple Actions."
Keith Burns [Mon, 23 Mar 2015 16:20:27 +0000 (16:20 +0000)]
Merge "Added support for multiple Actions."

9 years agoAdded support for multiple Actions. 20/16520/2
Thomas Bachman [Mon, 9 Mar 2015 14:13:37 +0000 (10:13 -0400)]
Added support for multiple Actions.

This patch adds support for using multiple actions
in the OpenFlow Overlay renderer.

Change-Id: I07e8e80a9012db378e765478751d175cae29a82b
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoShared Endpoint RPC for multiple render 14/15814/8
Yapeng Wu [Thu, 26 Feb 2015 20:19:34 +0000 (15:19 -0500)]
Shared Endpoint RPC for multiple render

This patch allows multiple renderers to share Endpoints RPC registration.
This is needed to allow multiple renderers to run together, allowing them
to access Endpoints store concurrently. The solution idea is to have
endpoint RPC registration as singleton. Each renderer then needs to
supply this singleton object with its Endpoint specific augmentation.
Upon endpoint registration RPC call, the singleton then loops over all
renderers to build all augmentations.

Change-Id: I0fe8bee6d8e92ffd2c3268009336da587cb497fc
Co-Authored-By: Khal Al-Zoubi <khalalzoubi@gmail.com>
Co-Authored-By: Yapeng Wu <yapengwu@gmail.com>
Signed-off-by: Yapeng Wu <yapengwu@gmail.com>
9 years agoMerge "Adding NSH Matches and Actions."
Keith Burns [Thu, 19 Mar 2015 02:55:20 +0000 (02:55 +0000)]
Merge "Adding NSH Matches and Actions."

9 years agoMerge "Adding feature for OpFlex Renderer."
Keith Burns [Thu, 19 Mar 2015 02:38:23 +0000 (02:38 +0000)]
Merge "Adding feature for OpFlex Renderer."

9 years agoAdding feature for OpFlex Renderer. 95/16795/1
Thomas Bachman [Thu, 19 Mar 2015 01:04:13 +0000 (21:04 -0400)]
Adding feature for OpFlex Renderer.

This adds the OpFlex renderer feature, allowing it to be
loaded and run.

Change-Id: I0d2446674c759ef9f69011bee7cc7fc55442774d
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoIntegrated with SFC to make RPC call. 21/16521/2
Thomas Bachman [Fri, 27 Feb 2015 20:42:35 +0000 (15:42 -0500)]
Integrated with SFC to make RPC call.

This calls the SFC the RPC to get the Rendered Service Path (RSP).
This will be migrated in a coming patch, but provides the demonstration
of GBP making the SFC RPC call.

Change-Id: I4dc6acf042a3cb70853f39e7469dd21cc504bca6
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoAdding NSH Matches and Actions. 23/16523/2
Thomas Bachman [Sat, 14 Mar 2015 20:21:56 +0000 (16:21 -0400)]
Adding NSH Matches and Actions.

This adds support for OpenFlow Matches and Actions
for NSH fields (NSI, NSP) to FlowUtils.

Change-Id: I9f3a0f49e0a4b658a4b6c4e8a8fe79a882c179e8
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoFix for neutron issue - use karaf-parent 57/16057/1
Ed Warnicke [Thu, 5 Mar 2015 03:04:13 +0000 (19:04 -0800)]
Fix for neutron issue - use karaf-parent

This patch should fix the neutron issues being seen.

Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRemove errant checkin of Unit Tests. 87/15787/2
Thomas Bachman [Thu, 26 Feb 2015 12:39:01 +0000 (07:39 -0500)]
Remove errant checkin of Unit Tests.

A previous gerrit erroneously checked in these unit
tests, as they already exist under the groupbasedpolicy
main directory/bundle.

This patch also adds the directory used only for unit
testing in the ofoverlay renderer to .gitignore.

Change-Id: Iead96518c7bdff119fa0502a821a98e4cc914d3e
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoMerge "Increased coverage of InheritanceUtilsTest."
Thomas Bachman [Thu, 26 Feb 2015 11:25:03 +0000 (11:25 +0000)]
Merge "Increased coverage of InheritanceUtilsTest."

9 years agoMerge "Yang errors fixes: - fixed keys - restored 'config true' state in references...
Thomas Bachman [Wed, 25 Feb 2015 16:17:13 +0000 (16:17 +0000)]
Merge "Yang errors fixes: - fixed keys - restored 'config true' state in references - changed 'config false' to 'true' in subject-feature-definitions"

9 years agoMerge "Separating renderers into features."
Keith Burns [Wed, 25 Feb 2015 14:49:38 +0000 (14:49 +0000)]
Merge "Separating renderers into features."

9 years agoIncreased coverage of InheritanceUtilsTest. 11/15711/2
Tomas Cechvala [Wed, 25 Feb 2015 10:22:51 +0000 (11:22 +0100)]
Increased coverage of InheritanceUtilsTest.

Change-Id: Ie6182a32231b76dc549d813078f67776e783810f
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
9 years agoYang errors fixes: 65/15665/4
Konstantin Blagov [Tue, 24 Feb 2015 11:51:43 +0000 (12:51 +0100)]
Yang errors fixes:
- fixed keys
- restored 'config true' state in references
- changed 'config false' to 'true' in subject-feature-definitions

Change-Id: Idc509de204d72d4db30f26a0048ecd9fb3ed00c8
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>
9 years agoSeparating renderers into features. 40/15540/8
Thomas Bachman [Thu, 19 Feb 2015 20:39:09 +0000 (15:39 -0500)]
Separating renderers into features.

This patch separates the renderers into their own bundles,
and makes them their own features. This allows per-renderer
installation. This is needed in the near-term in order to
allow multi-renderer development to progress. The renderers
may be combined into a single bundle later, once we've worked
out how multiple renderers can coexist completely.

Change-Id: If15992174ef98298a75a3dc5c4d47d22f207dccb
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoadded target-ide to .gitignore 06/15706/1
Martin Sunal [Wed, 25 Feb 2015 09:02:10 +0000 (10:02 +0100)]
added target-ide to .gitignore

Signed-off-by: Martin Sunal <msunal@cisco.com>
9 years agoAdded range type to subject-feature-definition/parameter 51/15651/4
Konstantin Blagov [Tue, 24 Feb 2015 09:01:49 +0000 (10:01 +0100)]
Added range type to subject-feature-definition/parameter

Change-Id: If770711b5c947024d0a20227f445dbc12a65eb00
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>
9 years agoMerge changes I4fa379a3,I0c63e69a
Keith Burns [Wed, 25 Feb 2015 05:15:53 +0000 (05:15 +0000)]
Merge changes I4fa379a3,I0c63e69a

* changes:
  Remove <repositories> section for contrail
  Remove <repositories> and <pluginRepositories> sections

9 years agoRemove <repositories> section for contrail 01/15701/1
Thanh Ha [Wed, 25 Feb 2015 05:01:12 +0000 (00:01 -0500)]
Remove <repositories> section for contrail

The contrail repo is mirrored by nexus.opendaylight.org so we should be
pulling from our mirror.

Change-Id: I4fa379a354f97eca18afc45d173baade27bd85da
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoSFC+GBP Integration 21/15521/3
Reinaldo Penno [Fri, 20 Feb 2015 03:43:48 +0000 (19:43 -0800)]
SFC+GBP Integration

Change-Id: I2669235bd39249eca1e5488517284f2d7c748794
Signed-off-by: Reinaldo Penno <rapenno@gmail.com>
9 years agoRemove <repositories> and <pluginRepositories> sections 00/15700/1
Thanh Ha [Wed, 25 Feb 2015 04:56:10 +0000 (23:56 -0500)]
Remove <repositories> and <pluginRepositories> sections

It is recommended that developers and servers configure this locally via
settings.xml.

https://lists.opendaylight.org/pipermail/discuss/2015-January/004482.html

Change-Id: I0c63e69a70b72b3b1994af57d17e3db89e3c7d46
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoMerge "SwitchManager: getSwitchState() should not return null"
Keith Burns [Wed, 25 Feb 2015 04:07:57 +0000 (04:07 +0000)]
Merge "SwitchManager: getSwitchState() should not return null"

9 years agoSome thoughts for SFC Integration. 55/15255/9
Thomas Bachman [Fri, 13 Feb 2015 13:27:32 +0000 (08:27 -0500)]
Some thoughts for SFC Integration.

This patch is just meant to kick off some initial thinking
about what an SFC/GBP integration might look like. It creates
a manager that listens for ActionInstance updates, then gets
the ActionDefinition that it references to see if the action
name is meant to direct to a Service Function Chain, and if
so, uses the chain name provided in the ActionInstance to
make the call into SFC to get the RendereredServicePath, by
name.

Change-Id: I8fbc5082c697d96d737b784a431cc484534ce715
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoSwitchManager: getSwitchState() should not return null 28/15628/2
Isaku Yamahata [Mon, 23 Feb 2015 19:27:49 +0000 (11:27 -0800)]
SwitchManager: getSwitchState() should not return null

getSwitchState method populates switch state to switches in thread-safe
way. When race occurred, it should return already populated one.
The callers of it, updateSwitch and updateSwitchConfig, access the result
without null check. This is found by code review.
This semantics is same to other similar helper methods, getEPNGSet(),
getConfdGroupOrdinal(), getContextOrdinal().

Change-Id: I88d03a8f0b0109921377bc1fd4628a072c6b0552
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
9 years agoFix build after openflowplugin merge. 32/15632/2
Thomas Bachman [Mon, 23 Feb 2015 20:27:42 +0000 (15:27 -0500)]
Fix build after openflowplugin merge.

This fixes a build breakage caused by a merge in the openflowplugin project
which enabled flow programming models/features.

This patch also re-enables the single-feature-test that
was broken when moving this from yangtools to odlparent.

Lastly, this patch removes the OpenContrail feature from
automatic startup (we're migrating to per-renderer features
in a subsequent patch).

Change-Id: I09382b2cef32efbd542d45c070280e1963858c80
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoDo not override netty version 44/15544/1
Robert Varga [Fri, 20 Feb 2015 12:05:25 +0000 (13:05 +0100)]
Do not override netty version

odlparent defines it to 4.0.24, no need to redefine it as an older one.

Change-Id: I4f300c9f0802b6a4dff3c6fcbe8831d9fa7c3805
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoThis commit includes OpenContrail OC Renderer support. 76/14676/3
RajaniS [Wed, 18 Feb 2015 06:26:11 +0000 (11:56 +0530)]
This commit includes OpenContrail OC Renderer support.

Change-Id: Ie650b1223fab200fe68229a91405ec7e54bc1157
Signed-off-by: RajaniS <srivastava.rajani@tcs.com>
9 years agoMerge "IndexTenant: resolveSubnet() should not return null"
Keith Burns [Fri, 13 Feb 2015 17:50:41 +0000 (17:50 +0000)]
Merge "IndexTenant: resolveSubnet() should not return null"

9 years agoIndexTenant: resolveSubnet() should not return null 74/15174/1
Isaku Yamahata [Wed, 11 Feb 2015 22:18:31 +0000 (14:18 -0800)]
IndexTenant: resolveSubnet() should not return null

As the comment of the method says, it shouldn't return null.
Instead it should return empty set.

Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
9 years agoAdded NPE check on Endpoint portName. 09/15009/1
Keith Burns (alagalah) [Sat, 7 Feb 2015 02:50:14 +0000 (18:50 -0800)]
Added NPE check on Endpoint portName.

Change-Id: Ic88a4fa0019cc061b4b4faf5af60a1e19fa0f5d1
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoAdding endpoint registration using port-name. 45/14945/3
Keith Burns (alagalah) [Thu, 5 Feb 2015 21:56:37 +0000 (13:56 -0800)]
Adding endpoint registration using port-name.

Change-Id: I00921958116a805fdbad541b6f391ea6b5197a72
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoFix build by referencing correct dependencies. 12/14912/1
Thomas Bachman [Thu, 5 Feb 2015 12:22:15 +0000 (07:22 -0500)]
Fix build by referencing correct dependencies.

This patch fixes a broken build by pulling in the
correct version of PAX exam. It also migrates the
karaf container from 3.0.1 to 3.0.2.  This fix should
eventually be replaced by a patch that converts to the
pom/project structure, as per the ODL "best practices"
that is defined in the archetype.

Change-Id: Ia626643c2cdb2bedc2b9df08cc267a8aa9902ad1
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoChanges to support OpFlex RFC Updates. 90/13890/18
Thomas Bachman [Tue, 2 Dec 2014 17:24:48 +0000 (12:24 -0500)]
Changes to support OpFlex RFC Updates.

This commit updates the OpFlex renderer to support the changes
that were made to the RFC draft.

Change-Id: Ie85b653c3c3e597993426a213c8dbb03949043bc
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoFixed overwrite of tenant policy. 68/14268/2
Thomas Bachman [Tue, 20 Jan 2015 01:03:23 +0000 (17:03 -0800)]
Fixed overwrite of tenant policy.

The existing script would overwrite any policy from tenant
and below, because of the URL used. This patch only adds
to the tenant list, instead of overwriting the whole thing.

Change-Id: Ia077b45a883fdd2d11cdd5775c28da6da7fb1a97
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoFixed bug with router-ARP flows where code was in wrong IF scope. 97/14197/2
Keith Burns (alagalah) [Thu, 15 Jan 2015 22:52:37 +0000 (14:52 -0800)]
Fixed bug with router-ARP flows where code was in wrong IF scope.

Change-Id: I4f26e9979ada2a40b29eeac1bc653eff17497fee
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoUse NXMs defined in openflowplugin. 89/14289/2
Thomas Bachman [Tue, 20 Jan 2015 14:41:39 +0000 (09:41 -0500)]
Use NXMs defined in openflowplugin.

Group Based Policy was using Nicira extensions defined in
the OVSDB project. These extensions have migrated to the
OpenFlow plugin. This patch removes the reference to the
OVSDB project, and adds the reference to the OpenFlow plugin
project.

Change-Id: I27845139039e70eae4f976eddbc495a83759aa0d
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoSet root pom.xml <name> for Sonar 60/14060/1
Thanh Ha [Fri, 9 Jan 2015 21:40:15 +0000 (16:40 -0500)]
Set root pom.xml <name> for Sonar

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: Ied468b9eb75207116e51469ac9a8c9e34fce958b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoAdded unregister RPC for openstack-endpoint which also removes standard endpoint. 96/13896/6
Keith Burns (alagalah) [Fri, 2 Jan 2015 22:24:48 +0000 (14:24 -0800)]
Added unregister RPC for openstack-endpoint which also removes standard endpoint.

Change-Id: I2ab7027a5f8bbac007cb0b2772f2aa500f404bb2
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoAdded OpenStack GBP support: 20/13820/1
Keith Burns (alagalah) [Mon, 22 Dec 2014 17:48:46 +0000 (09:48 -0800)]
Added OpenStack GBP support:
1. Added DHCP DORA flow to Table0
2. Added check that Group exists before adding group action to Table2

Change-Id: I38b294a1b7cbcb744100de67ac57569182b19f09
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years ago0. Created Yang, Features, and basic code structure 54/13554/2
Keith Burns (alagalah) [Fri, 5 Dec 2014 00:05:37 +0000 (16:05 -0800)]
0. Created Yang, Features, and basic code structure
1. Refactored endpoint translation code
2. Added checks for if neutron "tap" arrives before EP/PT registration
3. Fixed various NPEs

Change-Id: I0843a88d47f90800892e7b39fe4cc6e3033ace32
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoFix unit tests and code to support schema-enforcement by yangtools. 14/13214/3
Thomas Bachman [Fri, 28 Nov 2014 21:23:38 +0000 (16:23 -0500)]
Fix unit tests and code to support schema-enforcement by yangtools.

A recent change in yangtools requires fixing tests and code
that did not honor the schema required by the yang data type.
This patch fixes those errors.  This also addresses an incomplete
UUID that was added in a previous patch to the use-cases.

Change-Id: I783f597de12fe1810e6e67d6345e4467fe7db065
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years ago1. Modified testOfOverlay and odl-gbp to support multiple contracts 56/12956/4
Keith Burns (alagalah) [Wed, 19 Nov 2014 17:50:46 +0000 (09:50 -0800)]
1. Modified testOfOverlay and odl-gbp to support multiple contracts
2. Added use-cases directory for use-case config files
3. Cleaned up comments

Change-Id: I54e9a4693ad7cb5de28c74ab59954e24eed03a3c
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years ago- Added docker functionality and removed mininet from POC (infrastructure_launch... 91/12391/1
Keith Burns (alagalah) [Thu, 30 Oct 2014 21:51:39 +0000 (14:51 -0700)]
- Added docker functionality and removed mininet from POC (infrastructure_launch, infrastructure_config)
- Removed policy definition from within odl_gbp and pused to separate policy_config file. Also made necessary
changes to odl_gbp, testOfOverlay to facilitate that and the removal of mininet
- Added helper scripts.

Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoDocker based POC exactly same as mininet. More changes to come. 45/12345/1
Keith Burns (alagalah) [Wed, 29 Oct 2014 18:40:46 +0000 (11:40 -0700)]
Docker based POC exactly same as mininet. More changes to come.

Change-Id: I91c6413a7e9fd681166b9a4ed21be1cb9e7b916a
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoExecutor cleanup. 74/12174/1
Thomas Bachman [Wed, 22 Oct 2014 21:12:56 +0000 (17:12 -0400)]
Executor cleanup.

Fixed OpflexConnectionService to use the same executor as
the other classes, passed in the constructor.

Change-Id: I3ce971de7bbab0be468e6b64ef5e91a21e07e7d8
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoSubscriptions and Notifications for Endpoint Registry and Policy Repository 16/10016/8
Thomas Bachman [Fri, 15 Aug 2014 11:45:00 +0000 (11:45 +0000)]
Subscriptions and Notifications for Endpoint Registry and Policy Repository

Adding subscription and notification for Endpoints and Policies. Added the
Policy Unresolve message, allowing agents to unsubscribe to policies. Also
fixed excessive whitespace.

Change-Id: I7ef120071bc19acac006c34943adc6b440e7f7f7
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoBUG 2112: Workaround for missing flows in POC demo. 09/12109/1
Thomas Bachman [Tue, 21 Oct 2014 14:03:43 +0000 (07:03 -0700)]
BUG 2112: Workaround for missing flows in POC demo.

This is an update for BUG 2112 -- it adds comments explaining the
change and configures the vswitch to support 1.0, 1.2, and 1.3.

Change-Id: Ifdcdbfe3110e6ed63f69ea232126174a546a1a89
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoCommented testOfOverlay scripts. 79/11979/3
Keith Burns (alagalah) [Wed, 15 Oct 2014 14:24:54 +0000 (07:24 -0700)]
Commented testOfOverlay scripts.

Change-Id: I1681fa94b4f1d3c7f6bb491b01514f36753fbc8f
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoIncrementing versions by 0.1.0 for post-Helium master branch 88/11888/1
Thomas Bachman [Fri, 10 Oct 2014 11:49:42 +0000 (04:49 -0700)]
Incrementing versions by 0.1.0 for post-Helium master branch

Change-Id: Ic461adb4a4cc8b42f28341ae9dabed88911b9ca4
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoBUG 2112: Workaround for missing flows in POC demo. 12/11712/1
Thomas Bachman [Wed, 1 Oct 2014 23:02:42 +0000 (16:02 -0700)]
BUG 2112: Workaround for missing flows in POC demo.

When the POC demo is run, one of the vSwitches occasionally
is missing some of its flows, due to a problem in the openflowplugin.
This commit introduces a workaround to avoid this problem and allow
the demo to work.

Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
Change-Id: I0f7dca025b30b032d68ee1bd83d0e82966efa2df

9 years agoBug: #2105: Proof of Concept still using port 8080 (non-Karaf) instead of port 8181. 26/11626/1
Keith Burns (alagalah) [Sat, 27 Sep 2014 14:50:21 +0000 (07:50 -0700)]
Bug: #2105: Proof of Concept still using port 8080 (non-Karaf) instead of port 8181.

Change-Id: Ib6f65293f03f0b1defab65e9b3d2f639bb948b96
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
9 years agoMerge "Adding a .gitreview file"
Rob Adams [Thu, 25 Sep 2014 21:44:58 +0000 (21:44 +0000)]
Merge "Adding a .gitreview file"

9 years agoBUG 2087: Fix GBP POC demo scripts 84/11584/2
Thomas Bachman [Thu, 25 Sep 2014 14:50:08 +0000 (07:50 -0700)]
BUG 2087: Fix GBP POC demo scripts

The scripts didn't provide Basic Auth in the REST calls, and now that
AAA is part of controller, these need to be added.

Change-Id: I089bc3d0cebb57fb3bdac4affa50a274d0aad06b
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoAdding a .gitreview file 29/11529/1
Colin Dixon [Wed, 24 Sep 2014 13:41:05 +0000 (08:41 -0500)]
Adding a .gitreview file

This enables easy use of the git review command documented on the wiki here:
https://wiki.opendaylight.org/view/Git-review_Workflow

Change-Id: I2c7373cae2d56e07a5a6da2930a2c471f469c5cd
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoBUG-1769: Controller project no longer supports non-karaf distributions. 57/10957/2
Thomas Bachman [Tue, 9 Sep 2014 10:00:42 +0000 (10:00 +0000)]
BUG-1769: Controller project no longer supports non-karaf distributions.

This adds a project-local karaf distribution build, so that users can
check out the Group Based Policy and run it with just the controller
build.

Change-Id: Ide0775827bf0951c32b9eefea5c8742c2745d0b0
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoMerge "BUG 1898: Fix NPE exception in SwitchManager."
Keith Burns [Tue, 16 Sep 2014 02:32:51 +0000 (02:32 +0000)]
Merge "BUG 1898: Fix NPE exception in SwitchManager."

9 years agoBUG 1899: Fix NPE in PolicyManager. 22/11222/1
Thomas Bachman [Tue, 16 Sep 2014 02:06:58 +0000 (19:06 -0700)]
BUG 1899: Fix NPE in PolicyManager.

Change-Id: I987530f6aef0dc8d6be677864929bf1339c8881b
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoBUG 1898: Fix NPE exception in SwitchManager. 20/11220/1
Thomas Bachman [Tue, 16 Sep 2014 00:51:33 +0000 (17:51 -0700)]
BUG 1898: Fix NPE exception in SwitchManager.

Change-Id: I0fa2607f85ad3b361761e6915ac6574e7ad24de5
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoAdding karaf files to project. 94/10494/3
Thomas Bachman [Fri, 29 Aug 2014 10:10:15 +0000 (10:10 +0000)]
Adding karaf files to project.

These changes allow the project to be built and tested using karaf locally
in the distribution/karaf directory (mvn clean install, followed by cd to
target/assmbly/bin and running ./karaf).

Change-Id: I0717f9cbdab46d7973f8c861fcb3916394352f84
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoFix for change in OpenFlow plugin project configuration file. 96/10796/1
Thomas Bachman [Thu, 4 Sep 2014 13:25:30 +0000 (13:25 +0000)]
Fix for change in OpenFlow plugin project configuration file.

The openflowplugin project requires a change to configure the
transport protocol. This brings in the latest version of the
configuration file from the openflowplugin project.

Change-Id: I2fbcd255855eba02418981ddf0cb1e431468db50
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoSwitchManager switch update NPE fix 44/10244/1
Adam Brcek [Mon, 25 Aug 2014 11:46:58 +0000 (13:46 +0200)]
SwitchManager switch update NPE fix

When new switch is discovered, NPE can be thrown when nodeConnectors is
null.

Signed-off-by: Adam Brcek <abrcek@cisco.com>
9 years agoAdd some unit tests for conditions 43/10043/1
Rob Adams [Mon, 18 Aug 2014 20:04:05 +0000 (13:04 -0700)]
Add some unit tests for conditions

Change-Id: I42d17f849a40bdffcbb9071a7d6724e6acf800b4
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoFix broken build caused by premature merge 83/9983/1
Rob Adams [Fri, 15 Aug 2014 16:14:55 +0000 (09:14 -0700)]
Fix broken build caused by premature merge

Change-Id: Ida599739180505cb97f2b6f88d1d07605a542a9d
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoMerge "Tweak subnets so that subnets attached to parent forwarding contexts will...
Rob Adams [Fri, 15 Aug 2014 15:52:16 +0000 (15:52 +0000)]
Merge "Tweak subnets so that subnets attached to parent forwarding contexts will properly reply to the ARP requests for the virtual router IP address."

9 years agoTweak subnets so that subnets attached to parent forwarding contexts 66/9966/3
Rob Adams [Thu, 14 Aug 2014 23:54:59 +0000 (16:54 -0700)]
Tweak subnets so that subnets attached to parent forwarding contexts
will properly reply to the ARP requests for the virtual router IP
address.

Change-Id: Ibc639d2bfe0e397aa7e746adf99d61f30dd4dc78
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoMerge "Added support for OpFlex Endpoint Registry messages."
Keith Burns [Mon, 11 Aug 2014 21:32:19 +0000 (21:32 +0000)]
Merge "Added support for OpFlex Endpoint Registry messages."

9 years agoMost basic features now working, including: 72/9672/10
Rob Adams [Fri, 1 Aug 2014 00:50:10 +0000 (17:50 -0700)]
Most basic features now working, including:
    * Bridging and routing within and across endpoint groups
    * Respond to ARP sent to the virtual router IP
    * Add nicira extension support where possible/required.
      * Sets up Nicra group actions in the group table to set tunnel
        destination and tunnel ID
      * Sets sepg, scg, depg, dcg, fd, bd, and vrf into registers
    * Enforces policy configured by contract
    * Adds a simple test script to test OF overlay with mininet

Change-Id: Ieb4633a529d529c4b3586bc8cd6d046bcad84725
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoImplement group table 01/9501/4
Rob Adams [Wed, 30 Jul 2014 16:59:37 +0000 (09:59 -0700)]
Implement group table

* Still need to add actions to send to group table for L2 broadcast/multicast
* Still need unit test for group table

Change-Id: I062436fa22ebd5703424f96b22098c5801c0ae4b
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoModify build after breakage caused by JaCoCo. Unfortunately requires 00/9800/2
Rob Adams [Thu, 7 Aug 2014 21:39:32 +0000 (14:39 -0700)]
Modify build after breakage caused by JaCoCo.  Unfortunately requires
switching to JaCoCo.

Change-Id: Ie47aaf10d079e39a1c0a97788f07212aba91952f
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoAdded support for OpFlex Endpoint Registry messages. 25/9725/2
Thomas Bachman [Thu, 31 Jul 2014 13:35:14 +0000 (13:35 +0000)]
Added support for OpFlex Endpoint Registry messages.

This adds support for Endpoint Declaration and Endpoint Request
messages. It converts between OpFlex semantics to the semantics
needed by the Endpoint Registry.

Change-Id: Ic9c869e549ad3f70a5089ad2c9218754726aa1f4
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoFix error in OpFlex test 74/9674/1
Rob Adams [Mon, 4 Aug 2014 21:45:56 +0000 (14:45 -0700)]
Fix error in OpFlex test

Change-Id: Ia25c2bedfdcf9d57f5d033d74e5cc8f7e99daf1b
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoRemoved OpFlex domain scoping. 16/9516/3
Thomas Bachman [Wed, 30 Jul 2014 20:19:05 +0000 (20:19 +0000)]
Removed OpFlex domain scoping.

There will only be a single OpFlex domain, so the domain
is brought out to a top-level configuration item (and is
no longer a list of domains) and brings the Discovery Definitions
back to the top level.

Change-Id: I688335d5b6b6c6980fcec40480d5e9ba4809faf1
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoImplement generation of policy enforcement table 16/9416/3
Rob Adams [Mon, 28 Jul 2014 22:18:55 +0000 (15:18 -0700)]
Implement generation of policy enforcement table

 * Refactor policy resolver semantics to provide the right APIs
 * Keep track of condition groups
 * Create rudimentary framework for generating rules from classifiers.

Change-Id: I044a3268bcd15aa0bc2ea072a73e7d74c72da5ad
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoAdded sending of Identity Request when clients connect. 81/9381/1
Thomas Bachman [Thu, 24 Jul 2014 19:33:22 +0000 (19:33 +0000)]
Added sending of Identity Request when clients connect.

The request messages also lacked initialization of their method
inside the constructor.

Change-Id: I8cd9b5d41ff37a998713a70d81f9a616fa485eea
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years ago* Port to use the new submit() API call rather than commit(). 09/9209/2
Rob Adams [Mon, 21 Jul 2014 16:49:18 +0000 (09:49 -0700)]
* Port to use the new submit() API call rather than commit().
* Fix warning caused by spurious SupressWarning
* Additional unit tests
* Tweaks to destination mapper table
* Fix policy model bug with duplicate name

Change-Id: I5bfc612ea78a1d9ff46d8d83a9ddc0d464cf13ac
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoMerge "Added MO object serialization and deserialization."
Rob Adams [Mon, 21 Jul 2014 16:56:04 +0000 (16:56 +0000)]
Merge "Added MO object serialization and deserialization."

9 years agoAdded MO object serialization and deserialization. 76/9176/1
Thomas Bachman [Fri, 18 Jul 2014 16:48:43 +0000 (16:48 +0000)]
Added MO object serialization and deserialization.

This adds the ManagedObject POJO to the relevant OpFlex RpcMessage
objects, along with unit tests for them.

This commit also addresses some compiler warnings, and adds back
in the OpflexConnectionService unit tests (added code to select
available server socket within a range).

Change-Id: I1a664fa0aec700554691b7dcc49aa65828721f5c
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoFinish implementing most of the destination mapper table (at least as 73/9173/1
Rob Adams [Sat, 19 Jul 2014 00:43:07 +0000 (17:43 -0700)]
Finish implementing most of the destination mapper table (at least as
far as I can without extensions)

Change-Id: I03500d8c17687844207d009e421e7b62b8d7c4db
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoMore work toward writing the flow correctly 65/9165/1
Rob Adams [Fri, 18 Jul 2014 16:49:43 +0000 (09:49 -0700)]
More work toward writing the flow correctly

* Add beginnings of destination mapper table
* Add some additional configuration information for switches
* Additional tests

Change-Id: I41142b49897e213aec2a00cf53233e0634b0d909
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoAdded support for OpFlex domains. 53/9153/2
Thomas Bachman [Thu, 17 Jul 2014 07:14:22 +0000 (07:14 +0000)]
Added support for OpFlex domains.

This adds domains to the scoping of OpFlex servers and
messages.

This patch also moves the OpFlex-specific messages to
their own package, and adds fixes for using concrete
typing for Futures.

Change-Id: I67a9cfeebb5d40490cfa02780cf7c9b3d2acfb74
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoAdd source mapping table and refactor/simplify flow table 60/8960/3
Rob Adams [Sat, 12 Jul 2014 00:14:41 +0000 (17:14 -0700)]
Add source mapping table and refactor/simplify flow table
Add simple scheme for allocating ordinals for use in the forwarding
plane to map to egs, bds, fds, etc.
Add tests for source mapper and port security tables

Change-Id: If4054a128cb0de921a492524bbf02aa1245ce158
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoMerge "Backed out OpflexConnectionService unit tests -- they were using localhost...
Rob Adams [Thu, 10 Jul 2014 17:08:06 +0000 (17:08 +0000)]
Merge "Backed out OpflexConnectionService unit tests -- they were using localhost sockets, which result in intermittent failures for UT."

9 years agoOnward! 05/8905/1
Rob Adams [Thu, 10 Jul 2014 16:41:15 +0000 (09:41 -0700)]
Onward!

* Add a lot of infrastructure around passing the right sets of events around
* Get writing to a single table working: the port security table
* Add license headers everywhere
* Needs lots of tests

Change-Id: I39f4fa538d9acf6470b00a5dd5a9563c53649851
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoFix bugs/warnings found by FindBugs in OpFlex code 09/8809/1
Rob Adams [Tue, 8 Jul 2014 16:56:24 +0000 (09:56 -0700)]
Fix bugs/warnings found by FindBugs in OpFlex code

Change-Id: If302f59c63c754e7af5b04ec40fbd1b152d1e624
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoBacked out OpflexConnectionService unit tests -- they 13/8813/1
Thomas Bachman [Tue, 8 Jul 2014 13:55:24 +0000 (13:55 +0000)]
Backed out OpflexConnectionService unit tests -- they
were using localhost sockets, which result in intermittent
failures for UT.

Tests will be reintroduced once a more suitable set of
UTs is reworked.

Change-Id: I5449fa02d583372416d73621ef2c9b7c93906efb
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoAddition of OpFlex server configuration and message support. 71/8771/2
Thomas Bachman [Tue, 24 Jun 2014 22:22:51 +0000 (22:22 +0000)]
Addition of OpFlex server configuration and message support.

Added configuration of Opflex servers based on changes in
configuration state.

Initial pass at support for the various OpFlex messages
(NB: some of this will change with a later patch that supports
direct serialization/deserialization of messages into the objects,
rather than going through a normalized JsonNode).

Change-Id: I8c5784342656bb8beb48eeec65be547f63d04af0
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
9 years agoImplement endpoint registry augments 63/8563/1
Rob Adams [Wed, 2 Jul 2014 16:50:15 +0000 (09:50 -0700)]
Implement endpoint registry augments
Some minor tweaks to endpoint model from Martin

Change-Id: I4b972748fafffd90de9a499fbdda5ac65bcfa565
Signed-off-by: Rob Adams <readams@readams.net>
9 years agoWork toward OF overlay renderer. 21/8521/1
Rob Adams [Tue, 1 Jul 2014 23:15:32 +0000 (16:15 -0700)]
Work toward OF overlay renderer.

* Create distribution directory (probably temporary until Karaf) to
  make running easier
* Move endpoint-provider-impl into renderer so that it can be
  augmented
* Stubbed or basic implementations of most of the overlay renderer.

Change-Id: I0c7972c8529d6a93d419915c82918a660935d6ac
Signed-off-by: Rob Adams <readams@readams.net>