BUG-592: use new InstanceIdentifier APIs

This patch gets rid of deprecation warnings stemming from changes to
InstanceIdentifier APIs. These have been optimized to elide as many
list copies as possible and expose utility functions which are very
useful for building temporary instance identifier objects. We attempt to
use them as much as possible.

Change-Id: I7cd8e116eaf2080974ba6d943279f6586298ca50
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-634: add connecticity test suite

This patch adds two tests, which test both the positive (matching key)
and negative (mismatched key) scenarios.

Change-Id: Ibee31baa126a54d9cff4d905febad46a812bea21
Signed-off-by: Robert Varga <rovarga@cisco.com>

Easier felix switch

Adjust the comment block such that it is easier to switch to felix for
debugging purposes.

Change-Id: I0207cd1be5158172af5148a5960551aed580aed3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make sure tests are run in a deterministic order

This simple patch makes sure our order of tests is deterministic and
repeatable. Unit tests should generally be nice and cleanup after
themselves, but that is not always the case and having the ability to
re-create reported conditions is more important than speed.

Change-Id: I51c756a21916e533dd0271db4f6f9e82963f06aa
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-634: Rework KeyAccess to work on maps

This fixes an invalid assumptions about how the TCPMD5 API works. It
turns out each FD has a detabase of various keys on a per-address basis,
so we really need to promote the single key into a map of keys.

Also fixes a bundle misconfiguration which prevented it from being
useful in OSGi environment.

Change-Id: Idcbb26383b4e787d7eb8d5d2ce183f5c5a782b2e
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-634: add tcpmd5-nio tests

This adds basic tests to the NIO package. These validate correct
operation of MD5ChannelOptions and MD5SocketChannel.

Change-Id: Ic8667416cc575730a814b83ae39a88335b9e611d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Randomized port number for PCEPTopologyProviderModule instance in PCEPTopologyProviderModuleTest.

Change-Id: Id362d0d9d6b775ddab3ce376dca78f81b97647fe
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 474 - Added missing config junit tests.

-added config tests in BGP's modules:
-linkstate-config
-parser-spi-config
-topology-provider-config
-rib-spi-config

-created AbstractRibImplModuleTest:
-abstract test class contains mocked md-sal stuff and methods for creating related config module instances
-test classes, where RIBImplModule is injected, or tested directly, should extends this abstract class

-added config tests in PCEP's modules:
-ietf-stateful07
-impl-config (parser modules)
-spi-config
-topology-provider-config
-tunnel-provider-config

-changed dead-timer-value and keep-alive-timer-value type from uint16 into uint8 in pcep-session-proposal-factory config modules

-added config tests in Programming's modules:
-impl-config

-added AbstractInstructionSchedulerTest abstract test class:
-contains mocked md-sal stuff and methods for creating related config module instances
-tests classed, where InstructionSchedulerImplModule is injected, or directly tested, should extends this abstract class

-fixed config tests dependency management

-other minor fixes

Change-Id: I7a439eafb80fd52c4363058d498a3de62129542b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "Bug 498 - Fixed PCEP and BGP testtools"

BUG-634: add tcpmd5-api tests

Introduce basic tests for API utility classes.

Change-Id: Ic87581edb2d0a9ed767176c23df681b5f14dcaa2
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-634: rework packaging

First we split out tcpmd5-api component, which contains the basic
interfaces and classes.

Second we rename tcpmd5-core to tcpmd5-nio to better reflect the fact
this is the binding to java.nio package. We also introduce
DefaultKeyAccessFactoryFactory, which provides a facade to selecting the
best-functioning KeyAccessFactory.

Third we introduce NativeSupportUnavailableException to indicate when
the native support library fails to load/initialize.

Finally we fix invalid javaChannel() reference in tcpmd5-netty, which
should have been called on the superclass.

Change-Id: I1243189ab728abecc473b3aa5a38e9e167b80aad
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-634: Rework getKey() implementation

As it turns out, getsockopt(TCP_MD5SIG) is not implemented, which means
we cannot read back the key associated with the channel. This patch
makes sure we cache in the KeyAccess layer and removes the unused native
method.

Change-Id: I941c60afa7380ffddd5745f0e71286e6fcabcdcc
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-634: Fix .so not being included in the .jar"

Merge "BUG-634: Fix JNI bugs"

Bug 498 - Fixed PCEP and BGP testtools

-added missing registration of extension parsers/serializers
-refactored ServiceLoaderBGPExtensionProviderContext - BGPExtensionProviderContext hold as a singleton

Change-Id: Idc5991a017c9bbc7550a1d4170f88f2086fd6416
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-634: Fix .so not being included in the .jar

This patch ensures the native dynamic library is included in the
tcpmd5-jni jar file. Also changes packaging to bundle, implements proper
library loading and adds a unit test to validate basic functions.

Change-Id: I966ef49723de25ae05f75f719a2e0169d161f773
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-634: Fix JNI bugs

This patch fixes issues discovered while implementing testcases:

- Fix handlers not being retained
- Fix failure to lookup LoggerFactory.getLogger()
- Remove getsockopt(TCP_MD5SIG), as it is not implemented in Linux
- Fix key removal mechanics
- Make sure struct tcp_md5sig contains the address

Change-Id: Id7185a33d00e794c9c2bfa1a7c4a9bf685a2ed59
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-509 Specify ordering in lists

It turns out we need explicit markers for lists where the order of
things is important. This adds such annotations to PCEP object lists.

Change-Id: Ifb695910c93bf65b154ecf86acee5ce99279eb2e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix warnings about overridden versions

We specify versions in dependencyManagement, no need to repeat them
here.

Change-Id: Id72c8b1c47e3b665ad32e5dc9da9491addfef161
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-472: Fix IT breakage from downstream

Change-Id: If6db3f9443289175889574f4ea8a122ddc390629
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-509: Fix topology not being augmented"

BUG-731: use IllegalArgumentException

This gets rid of non-descriptive RuntimeException in favor of
IllegalArgumentException.

Change-Id: Idd4f3452eb0a2b2ea7235fdfe5545490209e9993
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: do not declare Exception

These exceptions are specified by the super method. We have no use for
them, so follow sonar and remove them.

Change-Id: I67ad3d5764e92eba337da5ca0ab58d4bb5dbd215
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: remove unused field

This filed is no longer used. Remove it and get rid of the warning.

Change-Id: Iced3c01061ca28ec5c889a905db8e5840f47793c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-509: Fix topology not being augmented

The new datastore is picky about augmentations. More precisely it is
thorough in checking that the data destined to a particular adddress is
supposed to be there according to schema.

This is most noticable when a Binding-Aware application uses groupings,
as tthe Binding Specification does not discern between the individual
grouping instantiations -- allowing applications to easily attach
augmentations to a grouping instance and then use it in a context where
that augmentation has not been made.

This patch fixes one such instance, as reported by the following:

Caused by: java.lang.IllegalArgumentException: Supplied QName (urn:opendaylight:params:xml:ns:yang:pcep:crabbe:initiated:00?revision=2014-01-13)initiation is not valid according to schema container stateful
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:119) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation.fromSchemaAndPathArgument(DataNormalizationOperation.java:497) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$DataContainerNormalizationOperation.getChild(DataNormalizationOperation.java:226) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:165) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:144) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:185) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:144) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:185) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:144) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:185) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:144) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:182) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizationOperation$CompositeNodeNormalizationOpertation.normalize(DataNormalizationOperation.java:144) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizer.toNormalized(DataNormalizer.java:88) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizer.toNormalized(DataNormalizer.java:63) ~[na:na]
        at org.opendaylight.controller.md.sal.binding.impl.BindingToNormalizedNodeCodec.toNormalizedNode(BindingToNormalizedNodeCodec.java:57) ~[na:na]
        at org.opendaylight.controller.md.sal.binding.impl.BindingToNormalizedNodeCodec.toNormalizedNode(BindingToNormalizedNodeCodec.java:51) ~[na:na]
        at org.opendaylight.controller.md.sal.binding.impl.AbstractForwardedTransaction.doPutWithEnsureParents(AbstractForwardedTransaction.java:107) ~[na:na]
        at org.opendaylight.controller.md.sal.binding.impl.ForwardedBackwardsCompatibleDataBroker$ForwardedBackwardsCompatibleTransacion.putOperationalData(ForwardedBackwardsCompatibleDataBroker.java:218) ~[na:na]
        at org.opendaylight.controller.md.sal.binding.impl.ForwardedBackwardsCompatibleDataBroker$ForwardedBackwardsCompatibleTransacion.putOperationalData(ForwardedBackwardsCompatibleDataBroker.java:195) ~[na:na]
        at org.opendaylight.bgpcep.pcep.topology.provider.AbstractTopologySessionListener.onSessionUp(AbstractTopologySessionListener.java:153) ~[na:na]
        at org.opendaylight.bgpcep.pcep.topology.provider.AbstractTopologySessionListener.onSessionUp(AbstractTopologySessionListener.java:58) ~[na:na]
        at org.opendaylight.protocol.pcep.impl.PCEPSessionImpl.sessionUp(PCEPSessionImpl.java:391) ~[na:na]
        at org.opendaylight.protocol.framework.AbstractProtocolSession.handlerAdded(AbstractProtocolSession.java:51) ~[na:na]
        at io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:484) [bundlefile:4.0.17.Final]
        ... 24 common frames omitted

Change-Id: Ie9d160a3a66c39ca3b4a86c50127c9b9080f2e6f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Fixed write of uptodate to explicitly set routes."

Fixed dissapearance of links because of metric value not present.

Change-Id: Ibad22fee30a57f343ba1e3d52867fc0806bdc9f9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

RSVP Error code in stateful02 updated actally reflect stateful02 draft.

Change-Id: I349910316608bbb95bccbe0fc43ddb5d88ca9042
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-670 : stateful07 now displaying LSP related errors in RESTCONF

Change-Id: Ia036d0fa962f919b47b772c8b04d45cc87afceef
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed write of uptodate to explicitly set routes.

Generated copy constructors does not do full
copy of provided class, only of common super type
fields, so it lead to ommision of routes.

Added workaround which explicitly copies routes
from original Tables TO to newly constructed.

Change-Id: I875284016cffecd84ede841c54feef776e981921
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Added unit tests to MesaageRegistry.

Change-Id: I8f7b9072ef9305cf8cfb30c420f3d8e95876a8c3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Added unit tests for bgp-parser-api.

Change-Id: Ifdd15e880a695d705f5689d0d3e7b48bce78cc25
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Added tests for LinkstateAdjRIBsIn.

Change-Id: I488fddbf57730af587c29937fe146f2850329ea0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Remove final keyword from Stateful02LspObjectParser class definition, to be the class extensible.

Change-Id: Ie4be02f2ca02ea02e6333a6e8f4df55de2a351b2
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-64 : refactor BGP parser to use ByteBuf

Change-Id: Ibbd892d29fe709facaf06cf03273ee0ceea174a9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 467 - Reconnect strategy configuration deleted from bgp/rib-impl-config

-fixed RIBImplModuleTest
-fixed bgp initial configuration
-fixed integration tests

Change-Id: I2909d8ca47911de525d4201c8d858f8225cf0192
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "Increase the service lookpu timeout"

Increase the service lookpu timeout

This should fix the intermittent errors we have been seeing.

Change-Id: Ia8244cefa2602cb616f4ffabb4f218b76cec697b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Prepare for InstanceIdentifier change

InstanceIdentifier.getPathArguments() will have its return changed.
Prepare by using getPath() instead. Also fixes a warning about using raw
Future.

Change-Id: Idf7f2c4acc6cd4b77c2666ceede87f3cd465f9a3
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-604 : Holdtimer value now calculated as the lower from local/remote session prefs.

Change-Id: I08bb324fec9816cd9110c24601a322c982810303
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-594 : added check for AS numbers beyond 2B range.

Change-Id: I30f870191dfccc5996b5fcb0b78400b4690a46be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Make sure we set the key in the linkstate route entry

This fixes a missing key when storing the link state route. In order to
make it efficient, we need to pass back the InstanceIdentifier which
will be holding that entry. This also has the nice property of
increasing efficiency for IPv4/IPv6 routes by reusing the route key.

Change-Id: I777594feb283a7e5874da5cf8eaf6a97af49f1ab
Signed-off-by: Robert Varga <rovarga@cisco.com>

netconf-client is no longer needed by persister

Change-Id: I7cb0390231eb41a93103146465b4746ec1ecb11e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Reduce logback dependency scope to test

There's no need to have it compile.

Change-Id: I7ab37e2f6b2f72b96210561df0dd8acabd05d11f
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-64 : initial rewrite, MessageRegistry.

Change-Id: I6aaeb69545f05204c7de3399ce95fa061960e0fa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Do not build JNI unconditionally

This patch introduces the "jni" profile, which triggers build of JNI
artifacts. This fixes the build on non-Linux machines, where the JNI
stuff will be pulled from nexus.

Change-Id: I2ca973b4b3067ac05a7297339c21c23581fd3dea
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove another distributionManagement

Change-Id: Icef92503e7edcafd7a6911529908b26db7707e71
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Initial code drop of Netty.io integration"

BUG-64 : initial rewrite, LabelRegistry.

Change-Id: Ie40b980cd3745a6674aa43b7403a36b9074754e7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed delegate predefined value.

Change-Id: I61954d1022e136a7e59840c9358465c7c51a0858
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-64 : initial rewrite, ObjectRegistry.

Change-Id: I92764b8f0c44cab1b5b5c83f60f3153be873afda
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Remove unused distributionManagement sections"

Remove unused distributionManagement sections

Change-Id: I5fbd37a261c79ae56616c5439239d4d4c28c3705
Signed-off-by: Robert Varga <rovarga@cisco.com>

Move AbstractVendorSpecificTlvParser from pcep-spi to pcep-impl.

Change-Id: Ie3c622d9effc7454af387ad1607467d56a97b526
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Initial code drop of Netty.io integration

This is binding glue allows for integration of the base TCP-MD5 code
with Netty.io library.

Change-Id: Id574736e4f3f8e21f75e79591190120b4495943b
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

Fix bgpcep distribution after yangstore was removed.

Also fix RIBImplModuleTest which should work with yang parser directly.

Change-Id: Ib10eef8d3bc6e06abbd6ae0b42f7a612bff3bd8b
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>

Merge "Initial support for RFC2385"

Fix logging.bridge file location in config.ini .

Change-Id: Ic2713ce4543df977dafd89caa5323eec574ce611
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>

BUG-64 : initial rewrite, EROSubobjectRegistry.

Change-Id: I3d8e8f6d23ae112c5f4cc045030fb71f0a4d5316
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix TimedReconnectStrategyFactory - optional parameters must be objects not simple types.

Change-Id: I8078f4824587f6d1bfd7d2046cc8c403289272b1
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-64 : initial rewrite, RROSubobjectRegistry.

Change-Id: I02b515720c62228ce382e39a11252b8fde0dd33b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-64 : reformat TlvRegistry, to skip using getType method.

Change-Id: If3dd450f148e255357eb11d230b94cb7ab058da8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-64 : initial rewrite, XROSubobjectRegistry.

Change-Id: I845831d51830433dd88a881b63e215baeef0a7c8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Session reconnect strategy updated to factory.

Change-Id: I57ba847641609198492cfb6c361564f003d6af27
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Fixed integration-tests: add missing bundle.

Change-Id: I7dfe93eafaa913dfef247ce4b01c529cdd26d35c
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "BUG-444: Refactored BGP-RIB configuration modules tests."

BUG-444: Refactored BGP-RIB configuration modules tests.

-Added tests for BGPTableTypeImplModule
-Fixed validations in RIBImplModule

Change-Id: Iaaba1f6ceb52858d6b54c0b52774dab3b39596ad
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Initial support for RFC2385

This brings the ability to manipulate TCP MD5 key attached to a channel
if the underlying operating system supports it.

In order to talk to the underlying OS, we rely on Java Native Interface
(JNI), which contains OS-specific system calls. Currently only Linux is
supported.

Since the JRE libraries insulate Java code from the underlying details,
we also need to muck around implementation-private information within
Channel classes. Currently only openjdk and Oracle JRE is supported.

Change-Id: I664106a96da20ff47ecb71d7b541fe6eb0e056b1
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>

Moved some abstract classes up one package.

Change-Id: Iaaa494519276d2ce1f9993b81bc73b286cc17619
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Removed sonar warning by making variables private.

Change-Id: I9bd06a7c23515977de0d9dd79acc02c4e81e5dd8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Added definition of vendor-specific tlv into pcep-types. Added abstract vs-tlv parser."

Merge "Do not hard-code HashedWheelTimer"

Added definition of vendor-specific tlv into pcep-types.
Added abstract vs-tlv parser.

Change-Id: I62f920f1db35161fe7fa37645f2a7318eaa434af
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Display all arguments when updating LSP.

Change-Id: Ic1af266e00de12b6d3000981a57af2a003dc97d9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Add all argument object to Pcupd.

Change-Id: I641a464269a5633447358289769eb3fd24114b78
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Force resynchronization of all LSPs on update

This makes sure we get all the LSPs flushed onto MD-SAL correctly.

Change-Id: Ia7b99741bd90f79c2f494269459308a901135b26
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-444: Refactor pcep configuration modules tests."

BUG-444: Refactor pcep configuration modules tests.

Change-Id: Ic7945108248ff9ff6f0ab0e7231e60e9b929e6db
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Do not hard-code HashedWheelTimer

This patch moves out the HashedWheelTimer from BGPDispatcherImpl and
allows it to be configured. Additionally the default configuration is
updated to reuse the global timer.

Change-Id: I09019da9e60c06ba10753344d5434294abec41cc
Signed-off-by: Robert Varga <rovarga@cisco.com>

Re-activate cleanup

Change-Id: Ie8a75ef6424dad1828336b5c897e685a7d902226
Signed-off-by: Robert Varga <rovarga@cisco.com>

Removed final modifier, so that LSPA parser can be extended.

Change-Id: I4e962d88cf512a23573b0b7de2472c17e51841fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Split pcep configuration to parser and provider.

Change-Id: Ie9899635a341eff05464269f0f68fcfb80ac9b65
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix RIBImplModuleTest to work after default modules in sal are removed.

Commit http://git.opendaylight.org/gerrit/5496 will break this test, this commit fixes it.

Change-Id: Id198e77c2e5374c83e4a6e27df68c73b24bf9bb4
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>

Do not degrate remote BGP identifier into a bytearrray

Change-Id: I6bb3bf64445c6956adea6794f24d7fc538724d36
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-353: add remote-as awareness

This adds the configuration knob for the remote AS. Furthermore it adds
validation of the AS advertizement during negotiation. Drive-by fixes
include introduction of buildErrorNotify() and rename of fields inside
BGPObjectComparator for clarity.

Change-Id: Ie60e0633d84a8a6a239517600e4666dee2a0d3ed
Signed-off-by: Robert Varga <rovarga@cisco.com>

Rework BGP configuration

This patch reworks the structure of BGP configuration so that it follows
the logical organization of the RIB.

The core change is the creation of BGPPeer as a full-blown configuration
item. This encapsulates the previous proposal configuration and has the
inverse relationship with the RIB: the RIB is its dependency and it
pulls things like the local AS and BGP identifier from it.

Futher improvement is the introduction of bgp-table-type, which allows
explicit listing of tables which should be advertized in the BGP Open
message as well as specification of which tables should be tracked in
the local RIB.

Change-Id: I905759a3d9e780394579238d48ff0aee009a5544
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

BGPCEP distribution package cleanup

Removed ad-sal with all dependendent bundles
Removed NB applications, Openflow, odl web, netconf-ssh

Change-Id: I47b4ad7a3b0ad2a724c0156c9f7654f7a9d794cb
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>

Use sendMessage() from AbstractSessionNegotiator

AbstractSessionNegotiator now exposes sendMessage(), which aside from
issuing a writeAndFlush() also makes sure the message leaves the socket
and fails negotiation otherwise. Let's use that throughout our
negotiators, as that will harden them in race conditions.

Change-Id: Ice6995bc3a0121bef219268ac18cdb885118d1a1
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-430: Split off the various proposals

This creates the proper structure for per-revision proposals.

Change-Id: Ie17588a35cebc0a2557e7f9f3cfdbf98069d4aa5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Switch to using ListenerRegistration from yangtools

Yangtools concepts have been updated to mmatch our ListenerRegistration
semantics, so there's no reason to keep it around. Migrate our code and
remove it from our concepts.

Also remove Immutable interface. It has been deprecated and unused --
again, yangtools concepts carry the equivalent interface.

Change-Id: I28e5b4e06df0e0b39f808768763c341ad166e352
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bump config and netconf versions to 0.2.5-SNAPSHOT, bump ietf-yang-types, opendaylight-l2-types.

Change-Id: I9400f1e43d7e8b053c614d120bc4a764bdf1e726
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>

Merge "Update copied 00-netty.xml with name enforcing of 'netty-global-event-executor' to 'singleton'."

More tests for stateful02 module.

Change-Id: I8a191ee66c0ffb0b762e7753a1ca3408d5768fa3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Update copied 00-netty.xml with name enforcing of 'netty-global-event-executor' to 'singleton'.

Change-Id: Ibe4882b83ace8cbad230375cbb9d3786128e134f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>

Cleaned up concepts.

Change-Id: Ifba0889a6c063eecc172ec01db22582ac0bf38b1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix tests in rib-impl-config to use 'singleton' name for global event executor.

Change-Id: Ic9609026145edd2850dd9ac7266eb43c83a97b1a
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>

Merge changes I9c2aaa2e,Ia94bce78,I3a84c6c8

* changes:
  Fixed NPE and updated logging.
  Fixed update tunnel hanging.
  Set proposal to default stateful02 session proposal.

Fixed NPE and updated logging.

Change-Id: I9c2aaa2e35dad85ceccdeeb0a2fec704538ab43c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed update tunnel hanging.

Change-Id: Ia94bce78d4de8ca31a2c363c364bae39f6c71e5b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Make sure to set the LSP name

This may have contributed to LSPs not being visible.

Change-Id: I8c97c0787c00453fb5f80e96291fffce7cfff8b8
Signed-off-by: Robert Varga <rovarga@cisco.com>