bump maven-remote-resources-plugin 1.5 to 1.6.0

Bumps [maven-remote-resources-plugin](https://github.com/apache/maven-remote-resources-plugin) from 1.5 to 1.6.0.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-remote-resources-plugin)
- [Commits](https://github.com/apache/maven-remote-resources-plugin/compare/maven-remote-resources-plugin-1.5...maven-remote-resources-plugin-1.6.0)

Change-Id: I971714196d4bc981493256fb6213288fc67d4ba5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump javassist to 3.24.0-GA

There are no explicit release notes, the changes are at:

https://github.com/jboss-javassist/javassist/compare/rel_3_23_1_ga...rel_3_24_0_ga

Most notable is the fix for Powermock-induced CME and Java 11 support.

Change-Id: I4fb6330def0219e59bdf88ea9e66e04c33b45f4e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 14da2a040c899f49a6ba4e89b41879101f123727)

Disable explicit GCs by default

This adds -XX:+DisableExplicitGC to the JVM options, so that explicit
calls to System.gc() are no longer taken into account. They’re
counter-productive anyway on modern JVMs.

Change-Id: If6cc12a80897e2cd6c394f639e4f4a63c17db031
JIRA: ODLPARENT-175
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 00bb263998ed09085d9a5ff2cf28cd0faa929f8e)

Support building without zip archives

The build can be configured to skip zip or tar.gz archives (or even
both). Currently if zip archives are disabled, the build fails since
features-test expects a zip archive; this patch allows either a zip or
a tar.gz to be used, depending on what's built.

If both are disabled the build will fail unless it can retrieve a
matching archive from a repository. The nominal configuration is still
to build both.

JIRA: ODLPARENT-174
Change-Id: I858810767bcca452eebf52107ee76be129f85192
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit e4fd130962346a3c7863db28566cfcedf4460315)

Upgrade netty to 4.1.31

https://netty.io/news/2018/10/30/4-1-31-Final.html

Change-Id: I747867eb6bb3b64ee7725328064119a8af9665ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9814c4ee8fd592b44fd08c0543c3748d0b026418)

Add javax.activation:activation to exclusions

Karaf provides version 1.1.1 of this from its boot classpath,
hence we should never emit references to it.

Change-Id: I3585e9aa56afcc7f22c6139ba6404221d3142f88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start 3.1.5-SNAPSHOT

Change-Id: I009211c1f88bf7730127e0102fa500109e3deb57
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add release notes for 3.1.4

Change-Id: Iea3cc3c8a3010e38cc0d7cd89cea62be790aac47
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump jackson to 2.8.11.20180608

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.8.10
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.8.11

plus micropatches mentioned in
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.8

Change-Id: I0614317a62cecb10e66633106981e55b1cf108c6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add JAXB handling for Java 11

JAXB modules have been removed from Java 11, hence applications
using them need to declare a dependency on them. These modules
are provided on Karaf's boot classpath, hence we should be filtering
them from features.

Change-Id: I92a2b349c50caaa61d390ed0860901597a6b32f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 728b7979ce62d15b7df35f4c79d51b68c3e2c44f)

Bump Netty 4.1.29 → 4.1.30

Release notes: https://netty.io/news/2018/09/28/4-1-30-Final.html

Change-Id: Idf372327a62f811262bf0eb6415dd5dbd6be8f8e
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit ba6e1d2e5b89977b56005fd16b779cf896e99ba2)

Bump netty to 4.1.29

http://netty.io/news/2018/08/24/4-1-29-Final.html

Change-Id: I823b1e779761702a3098c09ba690644dcf6fe0de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit cebabfd1474706084ac126072eb891d94d191292)

Bump netty to 4.1.28

http://netty.io/news/2018/05/14/4-1-25-Final.html
http://netty.io/news/2018/07/10/4-1-26-Final.html
http://netty.io/news/2018/07/11/4-1-27-Final.html
http://netty.io/news/2018/07/27/4-1-28-Final.html

Change-Id: Ibe92ba9f0a508906c40e5af971d3402554d2ed48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5f8d6f674920b3572ce779b0fafeeca19e4c047e)

Bump netty to 4.1.24

http://netty.io/news/2018/04/04/4-1-23-Final.html
http://netty.io/news/2018/04/19/4-1-24-Final.html

Change-Id: I6eb7d1362e7574c12239faa63d31d53a37391c6c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 0a91d2fd6acf6ade4e313283afc372b7b07b298f)

Revert "Revert "Bump Javassist to 3.23.1GA""

This reverts commit ec97d276712cacc6d98545988975a9e2a63164d0.
mdsal was fixed to avoid the issue preventing us from upgrading.

Change-Id: I1a4a653632ad5d550d67f177c609905e25cb7929
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Bump Javassist to 3.23.1GA"

This reverts commit 8f19c29b16a70e570fe9e9426599ea5dfcec0025, which
breaks mdsal.

Change-Id: I0dff5768fac76f47734127b3d0d7e5df302f2b52
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Make annotations optional

JSR-305 annotations are strictly optional to resolve, as they do not
affection production funcionality. Make sure we mark them as such,
which prevents downstreams failing with newer JDK.

Change-Id: I869e0c84f9762e2abfb10b994890fe98cdb850ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ddc896b8438bffe28a861548eb537912543755cb)

Skip spotbugs in quick profile

This adds the knob to disable spotbugs on quick builds.

Change-Id: I021907289c853b5d322095149e97ffc312c4cb01
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 279447eec8601394cac61411b088d886615ba6bf)

Cleanup findbugs+JDK9 profile

Adding findbugs configuration in build invokes the plugin even
when the project is not using it. Instead of doing that, simply
define findbugs.skip property.

Change-Id: I6c979a12af77a1f17f6ef525a96befe5d016f4d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump scala to 2.12.7

https://github.com/scala/scala/releases/tag/v2.12.7

Change-Id: Ida44a1b4da509efebea36ec1fd218dcc865af9c1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8b502392d519618c8825f868d296ff9441179391)

Remove jre.properties

We should not be overriding this file and consume upstream. We
can get the exports via extra packages.

JIRA: ODLPARENT-168
Change-Id: I04c5f2862afe38215ce4e9787c6c0c4a15874adc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2987afb1d4f8aab5eff9531b04a7eda5719bc040)

Correct 3.1.3 version number in release notes

Change-Id: I16cdd8fe389c9518d918c48ec924cac61a262405
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add support for ed25519 keys in SSHD

This adds the optional support of ed25519 keys. This also requires
leaking sun.security.x509 package from the boot classpath.

JIRA: ODLPARENT-160
Change-Id: I194cdbf2716da099fe5790df3fca5f9e25d6a77f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 81d220e830bf25b6aec953aa4f992fd1c28d892a)

Add odl-apache-sshd feature

This is packaging of Apache SSHD, which needs to be co-managed
with karaf, as it is also using it. At this point karaf and us
are separated by a major version, so this is a simple exercise.

JIRA: ODLPARENT-158
Change-Id: Iceef03542bfba365a968572b58bef2d6c7ed1018
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b612b2eb27297d5f32f4c215f250fa6803963b95)

Bump karaf to 4.1.6 and jetty to 9.3.24

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12342748

https://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00113.html
https://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00115.html
https://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00121.html

Change-Id: Iaa87d5c141b9f7202649681bcfe1abb9a3c69920
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Javassist to 3.23.1GA

https://github.com/jboss-javassist/javassist/issues/165
https://github.com/jboss-javassist/javassist/issues/171

Change-Id: I6ebb2e837a8acffdc3a5cc9830d0a1b9d2c0d375
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Apply upstream fix for Xtend plugin 2.14"

This reverts commit 2fd94013e237cc405a7e6c1767c50d3aef12add4.  The
previous fix, only involving equinox.common, is more reliable.

Change-Id: I44263b9170b86790d5b3c3255a0f5ed2add7c5e2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to BouncyCastle 1.60

Release notes: http://bouncycastle.org/releasenotes.html

This includes fixes for CVE-2018-1000180 and CVE-2018-1000613.

Change-Id: I798d49208f443cfed954244998eedb7e40e70753
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit fd9b8dc1b851a4a560e0acdb7aac6a0941541d37)

Start 3.1.4-SNAPSHOT

Change-Id: I03a475d5f8153c6cb33f5be420e7f3bedcee3968
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Apply the upstream fix for Xtend Maven plugin 2.14

The real fix is to specify the version of jdt.core instead of
equinox.common.

JIRA: ODLPARENT-156
Change-Id: I43d083695d5feed0635cd583462214e2681f1f22
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 3.1.3

Change-Id: Ia01ec710339b81a0a0a3427316573272999d249f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix xtend-maven-plugin

xtend-maven-plugin (really, xtend-core) has bad set of dependencies,
as it pulls an ancient core (3.8.0) and new plugins (to the point of
fetching new ones as they become available).

Since their certification authority expired in February, new artifacts
use one different certificate. This coupled with the fact there is
a split package involved leads to different parts of the package having
different keys -- leading to an reactor-shattering SecurityException.

Change-Id: Id443f229f105ea65c7adc4b09e3e25338075b59d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add missing odl-jackson-2.8 declaration

This feature should be declared in artifacts, do that.

Change-Id: I64eef278f2798ab2a2e8123ca8a6ddab69dd97e2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start 3.1.3-SNAPSHOT

Change-Id: I8426339bfbe51594ee9c03630cda43821eedeea3
Signed-off-by: Stephen Kitt <skitt@redhat.com>

ODL Parent 3.1.2 release notes

Change-Id: Ic7738e0980f5966079801060cd842b29bd14d019
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump xtend to 2.14.0

This fixes xtend invocation on JDK9+.

https://github.com/eclipse/xtext/blob/website-master/xtend-website/_posts/releasenotes/2018-05-23-version-2-14-0.md
https://github.com/eclipse/xtext/blob/website-master/xtext-website/_posts/releasenotes/2018-05-23-version-2-14-0.md

This patch has been compile-tested with maven-3.3.9 and mdsal, and
seems to work okay.

Change-Id: Idf4e830de8e54f4caa0cf3bc7decc6c88ce84135
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disable findbugs on JDK9+

Findbugs cannot run on JDK9, disable it.

Change-Id: Ic565e6a4ab44ca5902d06a47ef38220bbb3d4f90
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disable spotbugs on JDK10+

Our version of spotbugs cannot handle JDK10 and later and we cannot
upgrade it because newer versions require maven-3.5. Disable spotbugs
when building with JDK10+.

Change-Id: Ie07ea565b0230e5fc3a46234366f52cd9381024d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix javadoc warning with JDK9+

JDK9 has introduced support for HTML5 javadocs and the doclet
emits a warning about not being sure how to interpret javadocs.

Fix this by specifying html4 on JDK9+.

Change-Id: I1d2bfa82918b220e6154cd825e602548f4450567
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-javadoc-plugin to 3.0.1

<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12342283>

Change-Id: Ib952ca3472033c876596d14aa1ade1d1877ada58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b95f329b3939e71896ab624f75e3580c8a672de6)

Disable SFT test in Java 9 JVM

We are using karaf-4.1.x, which means we are not JVM-9 ready,
hence running SFT should be disabled. This also fixes compilation
with JDK9, so that odlparent will pass 'mvn clean install'.

Change-Id: I86a88e60b4f75ffe1504c0837f0b09db578f8d4c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Bump truth from 0.40 to 0.41"

This reverts commit 9eb45f9ed43c8fba691b58a79f65f0c51be6e597.

Google Truth 0.41 needs Guava 25.

Change-Id: Ia0c200e7d758465a34ba45f275db1ed8c725135e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump truth from 0.40 to 0.41

Bumps [truth](https://github.com/google/truth) from 0.40 to 0.41.
- [Release notes](https://github.com/google/truth/releases/tag/release_0_41)

Change-Id: I03522e0052bc7995a85097f56ea67696c6f07881
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump sevntu-checkstyle-maven-plugin 1.27.0-1.29.0

https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.28.0
https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.29.0

Change-Id: I0481f2091da68717a3a26c18c8d82dd07079e1ae
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit c55f1f2ec9cc3c648683921630dd22811496af50)

Bump sevntu-checkstyle to 1.27

https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.25.0
https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.26.0
https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.27.0

Change-Id: Ifdc5c6c3d8f499893997af2258dbf0672a42b2b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ae83730319a9afe97d4a67c11049d039835c94f8)

Revert "Bump Immutables.org from 2.5.6 to 2.6.0"

This reverts commit e32f04540f44a6ac4b8b1f069666e7924d80d668.

The upgrade to 2.6.0 is a breaking upgrade (varargs are handled
differently).

Change-Id: I3931ca5f081e12293c4b642df0c30d4c8574fac6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

add org.osgi.compendium to single-feature-parent

fixes SFT bug
java.lang.ClassNotFoundException:
org.osgi.service.resolver.ResolutionException

This now really fixes it (I've reproduced and verified it);
whereas the earlier Ifaa39b35d1975ccd2aec15f6ed56191637f43d73
actually had not.

Change-Id: Iebf8e8c7c72b787f8858d469944aef716b4c2830
JIRA: ODLPARENT-136
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

remove SingleFeatureTest's old INFO log config

because since we switched to log4j2 that has no more effect anyway:

  log4j.logger.org.opendaylight.odlparent.featuretest=INFO

because all properties must by log4j2.* and this is the default anyway:

  log4j2.rootLogger.level=INFO

Change-Id: Ic934a4d4ff7bf9d565ff88669c8f1a7607566368
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

remove SingleFeatureTest log4j.rootLogger override

because since we switched to log4j2 that has no more effect anyway:

  log4j.rootLogger=INFO, stdout, osgi\:*

because all properties must by log4j2.* and this is the default anyway:

  log4j2.rootLogger.level=INFO

Change-Id: I0b6755403668d6723b036ba1532fe5e89f437df2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

add com.sun.management to jre.properties

JIRA: INFRAUTILS-41
Change-Id: Ic80a16b21b1e4ac9460f5493e2e6b1ce22204a7b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump org.eclipse.jdt.annotation 2.1.0 → 2.1.150

Change-Id: Ifa7bb2136273659d8f9daab2f6a4ef4f1052674e
Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 0f6f2d34e4f3599cf6c8fc4e8b4166bf95bbb1cf)

Bump scala-parser-combinators to 1.0.7

https://github.com/scala/scala-parser-combinators/releases/tag/v1.0.7

Change-Id: Id221cf4e9700d24b52ef0be34047bde28b68446b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump scala to 2.12.6

https://github.com/scala/scala/releases/tag/v2.12.6

Change-Id: Ie3c281606b6c4b63cec6d9be50fc86cb72a3dd2f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Provide better traces with invalid URLs

When a feature or bundle contains an invalid URL (or missing URL), the
resulting plugin error is rather inscrutable. This attempts to improve
the situation by indicating which feature is at fault.

Change-Id: If235349f5dcc6a73e5f77a97123feae43bc2eef2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 158af99fbc1a3aa904a3f92852d51eb5c3c7ecb9)

Bump jacoco-maven-plugin from 0.8.0 to 0.8.1

https://github.com/jacoco/jacoco/releases/tag/v0.8.1

Change-Id: Ie232b96256facf7fd6429a52fbd252077703b473
Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit f11f5064af71692c690caa0a9d841fc56ac85b06)

Bump gson from 2.8.2 to 2.8.5

Bumps [gson](https://github.com/google/gson) from 2.8.2 to 2.8.5.
- [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/gson/compare/gson-parent-2.8.2...gson-parent-2.8.5)

Change-Id: Ia5205c86a58a2fbd08d2bb5f82abe6f07532fa5e
Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 85b4fce2bb56a0f61b75db66789d3c0b1c6daf56)

Bump Guava 23.6 to 23.6.1

Commit log: https://github.com/google/guava/compare/v23.6...v23.6.1

This addresses CVE-2018-10237 (and only that).

Change-Id: I41e9fd17f8edad70f1501807966201e4f0b6aff6
JIRA: ODLPARENT-155
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 1b3a506244b751f6d74a7a9747daeef2b7b950b7)

add org.apache.karaf.scr.management to whitelist

to fix spurious SingleFeatureTest (SFT) failures

see ODLPARENT-144; although unclear why this suddenly fails now

Change-Id: Ife9bdf0d94b028048cd6321e8fbdc5ec554a8bdb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit d2592a999d7f30a3758439867a30e8e4afc9af69)

Bump truth from 0.36 to 0.40

Bumps [truth](https://github.com/google/truth) from 0.36 to 0.40.
- [Release notes](https://github.com/google/truth/releases)
- [Commits](https://github.com/google/truth/commits)

Change-Id: I46b8efd37c9503ebf1f5d49019bec873f91cba3b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 121e382265c5aa94f3e1f7190278e13894d47c43)

Bump Immutables.org from 2.5.6 to 2.6.0

https://github.com/immutables/immutables#260-2018-05-19

https://github.com/immutables/immutables/milestone/68?closed=1

Thanks to https://dependabot.com for notifying me about this.

Change-Id: I2a01d7a0c11834b747a5a77d23df9d95b7477b9c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit e655666433e4d1978eb3bcec7334c74dc7619dea)

remove redundancy in SingleFeatureTest

The aries.quiesce, aries.blueprint, equinox customizations
are already part of OpenDaylight's base Karaf customization.

see https://lists.opendaylight.org/pipermail/odlparent-dev/2018-April/001830.html

Change-Id: I4c89cddf07b5e144e9dc3cd21e4a7275f42815f8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 396c31096c11df0a3517a035b1758badcbd0cbc8)

Disable more null-related FindBugs checks

These produce false-positives with Guava 23.6+. This effectively
neuters null-pointer analysis using FindBugs unfortunately (but is
necessary to avoid having lots of irrelevant @SuppressFBWarnings
statements throughout the project).

Change-Id: I10445789b1266b8636fae1ae1130d7e64e0f67b3
JIRA: ODLPARENT-146
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add jersey-client to odl-jersey-1

The Jersey feature needs to include the client.

Change-Id: Ifa9d3d5a7b6ffe46bb4c20c68740178b85cbecbc
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 57078d53bf5337cc9292ee801680aae9eb6e7b5d)

Bump versions to 3.1.2-SNAPSHOT

This is a follow-up after 3.1.1 release: bump versions to next
development version.

Change-Id: I6f0b0da8a14d09afa7cd82d68f521ee6f489e5a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

SingleFeatureTest preserves target/SFT/karaf.log

see issue for background; reason why, and impact

Issue: ODLPARENT-148
Change-Id: I15eeac652057fabb0dbc161e554dbe81164ebe0a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump EclipseLink Moxy JAXB impl 2.6.2 → 2.7.1

see https://www.eclipse.org/eclipselink/releases/2.7.php

Issue: NEUTRON-160
Change-Id: I38f0285643ca0a1aea99a5e7f9e2b158bb86168c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 931bbd6fd9794dd6777da38741d598e9ac8da920)

remove ovsdb config from custom.properties

Change-Id: Ic3f4762c8f92ebcc958a80cec01fbda5749544af
Issue-ID: NETVIRT-434
Issue-ID: ODLPARENT-34
Signed-off-by: Sam Hague <shague@redhat.com>

ODLPARENT-137: restore the opendaylight prompt

In Karaf 4.1 and later, it turns out that the prompt defined in the
branding is overridden by the shell initialisation script,
etc/shell.init.script, which defines its own prompt. This patch adds
our own version of that script which disables the override.

Thanks to Guillaume Nodet for figuring out where the override was
coming from, and to Michael Vorburger for the initial investigation!
See https://issues.apache.org/jira/browse/KARAF-5570 for details.

Change-Id: I22410cb0425ab5b8a3f6e7c410fbb76587f9f973
Signed-off-by: Stephen Kitt <skitt@redhat.com>

ODLPARENT-146: disable NP_NONNULL_PARAM_VIOLATION

Guava 23.6 switched from @Nullable to @NullableDecl, which causes
false positives in FindBugs’ ``NP_NONNULL_PARAM_VIOLATION`` rule;
we’re disabling the rule for now.

Change-Id: I135c90930ff7e8a2203da46e3106ed69c570f1c1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Switch <issueManagement> from Bugzilla to JIRA

Change-Id: I432548aa2a3c7a3c3850a6a419abb24751d1ebef
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit d8cfe538057d1ca67ffa0650efd9c7cf53cd0dac)

Start 3.1.1

Change-Id: Ic305070ca8de18c486e542960f5e221eedd64a0f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Sync checkstyle/karaf-branding versions

We had two old references to 3.0.0-SNAPSHOT, bump them to
3.1.0-SNAPSHOT.

Change-Id: I25cc4214a9354b78262c2061e9dfe6c42ff7b83b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit a6e88fabdcf4a13a05a4710223504f2243c3078d)

Add 3.1.0 release notes

Change-Id: Ia77f26ac993219bcf7b90dfbad6cd254ea07d89d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add 3.0.3 release notes

Change-Id: Ia19badf04234d5a03ef2e7d18ffe4db835b7a0be
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 07de5fbcfc958ca416c1f2317ac4ed58050f6a94)

Bump lmax-disruptor to 3.3.10

https://github.com/LMAX-Exchange/disruptor/releases/tag/3.3.8
https://github.com/LMAX-Exchange/disruptor/releases/tag/3.3.9
https://github.com/LMAX-Exchange/disruptor/releases/tag/3.3.10

Change-Id: I4a6001aa3a82e98f3fa6f849ca6442bb44eadea8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump javassist to 3.22.0

https://github.com/jboss-javassist/javassist/compare/rel_3_21_0_ga...rel_3_22_0_ga

Change-Id: Iae54ca698e04a55bfdfbcc6fd24ed46e9af1b647
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.22

http://netty.io/news/2018/02/05/4-0-56-Final-4-1-21-Final.html
http://netty.io/news/2018/02/21/4-1-22-Final.html

Change-Id: If7688af77baf5d9e1a3289d1cf5f42b0abf6f34e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump scala to 2.12.5

http://www.scala-lang.org/news/2.12.5

Change-Id: I6a9fddc5ca58822367c146ec2d2cc547e61d7e7b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.11

https://akka.io/blog/news/2018/02/28/akka-2.5.11-released

Change-Id: Ida5ba9a519ec7336f32521e259d587b8cca3e57d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-jackson-2.8

This a package containing a pre-configured jackson software package.

Change-Id: I459cfda5fb147b21a1e5339360fac06522307fbc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add an OWASP profile for vulnerability checking

This builds on the full dependency-check project, adding a -Powasp
option which checks all our published third-party dependencies against
the NVD database. This currently doesn’t fail the build.

Change-Id: I204f2c427c545a636cf2310b5902c8a4e4bcf873
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit db892d6b856098bf079d536d3fd9c4d2ff45b26a)

Bump jacoco to 0.8.0

https://github.com/jacoco/jacoco/releases/tag/v0.8.0

Change-Id: Ibca747463e8c568bdc48147999f3d6f232ff6599
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7f56e62cf7e36c5fffddf34fe38fadae9bed5323)

Exclude jsr250-api from enunciate-core-annotations

to fix this (correct) complaint from ClasspathHellDuplicatesCheckRule:

file:/.../javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar
overlaps with
file:/.../jre/lib/rt.jar
- total overlapping classes: 6 - different classloaders.

Change-Id: I6306d604d6b105f064e0e8f7f765a9af1ca7c11c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 877769ddb864b4bff31abbbea386a07007237f17)

Bump akka to 2.5.10

https://akka.io/blog/news/2018/02/23/akka-2.5.10-released

Change-Id: I10d598a96e4a08078e10551517cee7f3882fc49d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8cd7db350256591e351ef994fce96ff75a140ee1)

Bump akka to 2.5.9 and typesafe config to 1.3.2

This is a major feature/preview release, the notes are at:
https://akka.io/blog/news/2017/09/28/akka-2.5.6-released
https://akka.io/blog/news/2017/11/17/akka-2.5.7-released
https://akka.io/blog/news/2017/12/08/akka-2.5.8-released
https://akka.io/blog/news/2018/01/11/akka-2.5.9-released-2.4.x-end-of-life

https://github.com/typesafehub/config/blob/master/NEWS.md

Also align aeron/agrona versions to match:
https://github.com/real-logic/Agrona/releases/tag/0.9.6
https://github.com/real-logic/Agrona/releases/tag/0.9.7
https://github.com/real-logic/Agrona/releases/tag/0.9.8
https://github.com/real-logic/Agrona/releases/tag/0.9.9
https://github.com/real-logic/Agrona/releases/tag/0.9.10
https://github.com/real-logic/Agrona/releases/tag/0.9.11
https://github.com/real-logic/Agrona/releases/tag/0.9.12

https://github.com/real-logic/aeron/releases/tag/1.3.0
https://github.com/real-logic/aeron/releases/tag/1.4.0
https://github.com/real-logic/aeron/releases/tag/1.5.0
https://github.com/real-logic/aeron/releases/tag/1.5.1
https://github.com/real-logic/aeron/releases/tag/1.5.2
https://github.com/real-logic/aeron/releases/tag/1.6.0
https://github.com/real-logic/aeron/releases/tag/1.7.0

Change-Id: I3bb94b6c33004366799f1c85f89fae61e3c6c6ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6ae8daf14863ced92b92044d317517ac7991af73)

Bump git-commit-id-plugin from 2.2.2 to 2.2.4

https://github.com/ktoso/maven-git-commit-id-plugin/releases/tag/v2.2.3
https://github.com/ktoso/maven-git-commit-id-plugin/releases/tag/v2.2.4

Change-Id: I3890a63b83434751e39f1a3bccd9c0727c317715
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5b70bbd2797d887c126b8d0927a1a47b131934be)

add modernizer.skip to -Pq

I'm adding https://github.com/gaul/modernizer-maven-plugin/
to infrautils in Id85737d789efb7ee07c8c7a34bdac39d8a96e076,
and cannot figure out how to get Maven to merge an additional
property in a profile, so why don't we just have this in
odlparent already?  Some day modernizer-maven-plugin could
be in odlparent.

Change-Id: Id270c4a7f363eb4a0557810526e17043cac326e8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Configure findbugs-slf4j

This patch, based on I60b127526ccc057d37ef900b7502f4ea84517d8a, adds
an exclusion for SLF4J_LOGGER_SHOULD_BE_NON_STATIC so that child
projects can enable findbugs-slf4j without running into it.

Change-Id: Ife56905e14bc4771f8a7460907fdb768c3de3471
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Configure git review for 3.1.x

Change-Id: Ie28d2c7d71e55d0b95653bcad31f66838d401219
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump BouncyCastle to 1.59

https://www.bouncycastle.org/releasenotes.html, most notably fixes
CVE-2017-13098.

Change-Id: Ifb3c972f5c41722850249168d36b6ab669c7e4d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 42350b3745d9f382c807d80d8c5e0d98698bf31e)

Bump Karaf 4.1.4 → 4.1.5

Release notes: http://karaf.apache.org/download.html#container-415

Change-Id: I4af39685f9f5c69a0f5fa5b22f1035dcef0936ba
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit e560a47cc4dc0379ac47fb0f231dc2a3c26a14d9)

AAA-147: Upgrade Jolokia to 1.5.0

Upgrades Jolokia to 1.5.0.  This version provides the ability to
delegate authentication for Jolokia to AAA, centralizing control
of AAA mechanisms.

Change-Id: Ic545ca2ad966e4ecee030bcaa6cfd3163c6dd606
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
(cherry picked from commit b72bdc95df80bb964460a948c1ad0e3a93200638)

bundle-test-lib should be a bundle

This prevents the jar from being wrapped by users.

Change-Id: Ib2c2198dc2acca072f5c1dede8a85ca4d1b15963
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit afc1ccc1bc2e840855d1478c8e51299d72631e72)

ignore web.xml and BP *.xml in duplicate-finder

This avoids duplicate classpath errors when running the
duplicate-finder-maven-plugin on projects depending on ODL Karaf feature
artifacts (such as odl-netvirt-openstack), which will typically have
dependencies on several web related OSGi bundles that include
WEB-INF/web.xml, and allow any org/opendaylight/blueprint/*.xml,
not just autowire.xml.

Change-Id: Iacfb820d44febdcf20eafd99cf549e023ff47df9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 0323e77d4ca4827ea756693b8c0f03bf1aa7c5fd)

Remove <scope>test from mycila

This allows odlparent-based projects to use Guice with Mycila more
easily in non-test related Java environments, such as in a pure JSE
opendaylight.simple (POC).

As per the original commit message when Mycila was first added to
odlparent, there is still no intention of using it (or Guice) in our
standard deployment model of running ODL in OSGi.  Therefore, this
contribution does still not include an OSGi MANIFEST.MF for Mycila,
nor a Karaf wrap feature for it, as we still do not need that.

Change-Id: I1f5586bd1dcf8d12756e33f4b74c4326b924058d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit f48bc51f9dd2ae64b16cd94bbaeb1867eaef2934)

Add ThreeTen-Extra

This provides a number of useful date/time classes, on top of the new
features in Java 8. See http://www.threeten.org/threeten-extra/ for
details. (Inspired by I044c092a662f2b38ebc3f53a371c3c801ca0192c.)

Change-Id: Ib73744ec639d80e96b16f013ca8a75a99b1c2e3a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit e91e7bcb9f3d41266958060efbe229dd45388a4f)

Bump findbugs-maven-plugin from 3.0.4 to 3.0.5

even though we're aiming for SpotBugs, it doesn't hurt to do a minor
version bump on the findbugs-maven-plugin, as we'll have to maintain it
for a while anyway until everything is switched to SpotBugs and we can
remove it.

Change-Id: I23a3aa939a30084157de5defcb5b9f09e762dea1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 394b3ac20ce45f67b8ea174047d7ef53eb734ab0)

Bump commons-lang3 3.6 → 3.7

Release notes:
http://www.apache.org/dist/commons/lang/RELEASE-NOTES.txt

Change-Id: Idcc2eccbc22420d578511f4017e2098ace9b9bd0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 7891: Place provided features to featuresBoot

Specifically, org.apache.sshd/sshd-core/0.14.0 is excluded,
thus "ssh" feature has to be always installed.

Without this, distribution4-check with odl-netconf-mdsal
in integration fails at installing boot features, because
org.opendaylight.netconf.netty-util depends on sshd-core bundle,
which is only activated by "ssh" feature
(as any ODL feature drops that dependency,
because of exclusions in feature parents).

Change-Id: Ic1d3b19981fccca9c320a5079aaf9e2eadf09397
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit d7cd41b97dc9081f7375af08ef5da07542f9b5c1)
(cherry picked from commit 9aab526b610c09880359f8bee0cb6b3c9a44494b)

Exclude leveldb-api from odl-akka-leveldb-0.7

to fix this (correct) complaint from ClasspathHellDuplicatesCheckRule:

file:/.../org/iq80/leveldb/leveldb-api/0.7/leveldb-api-0.7.jar overlaps
with
file:/.../leveldbjni/leveldbjni-all/1.8-odl/leveldbjni-all-1.8-odl.jar
- total overlapping classes: 13 - same classloader ! This is an ERROR!

Change-Id: I929fb28606a8f6456747229ac2ceee6a90a9f04e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit a16ccdc6a4f74e98c46cdd346577f5ae61cd6699)