Tomas Cere [Mon, 24 Oct 2016 10:02:58 +0000 (10:02 +0000)]
Merge "Add unit tests for sal-netconf-connector transactions"
Tomas Cere [Mon, 24 Oct 2016 07:35:34 +0000 (07:35 +0000)]
Merge "Remove old clustered netconf topology implementation"
Alexis de Talhouët [Fri, 21 Oct 2016 21:22:53 +0000 (17:22 -0400)]
Add logging in tx facade along with the RemoteDeviceId
Change-Id: I0e30376d65ff734ff3dc34809554b961a013a15b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Fri, 21 Oct 2016 20:37:48 +0000 (16:37 -0400)]
Add the RemoteDeviceId at the begining of the log
So it's easier to grep and find things related to one netconf
connector, and also, to keep things consistent with how it's
already done in sal-netconf-connector
Change-Id: I29ee41c699de8287fd6e00f3a04cacb3d17c5fd1
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Fri, 21 Oct 2016 20:28:39 +0000 (16:28 -0400)]
Move SubmitFailedReply in the appropriate package
SubmitFailedReply is a transaction related message, hence
should resides under the .transactions package
Change-Id: I7b95f664c88ce2525a742d5543ab562cae709d2b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Fri, 21 Oct 2016 20:28:11 +0000 (16:28 -0400)]
Remove unused imports
Change-Id: I8079b664133e88a3b35f21a3c41e84e890a8ff46
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Fri, 21 Oct 2016 20:26:02 +0000 (16:26 -0400)]
Use SerializationUtils to (de)serialize NormalizedNode and YangInstanceIdentifier
Controller CDS implementation provide utility method for this,
we can re-use them, as it appears it's keeping a ThreadLocal
holding NormalizedNodeDataOutput instance
Change-Id: Ia106f33d04f937ac8dacf89cb6837a157eee8ae1
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Fri, 21 Oct 2016 19:46:13 +0000 (15:46 -0400)]
Add serialVersionUID to all java.io.Serializable messages
Change-Id: I4928273c0d65e782162d099ddbae36a0c9fe1c63
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Fri, 21 Oct 2016 19:21:54 +0000 (15:21 -0400)]
Update netconf-topology-singleton.xml file formatting
- Inline the closing statement
- Rename to bean to be more accurate
Change-Id: I2e2052b7b86b12139b2573c0e3828730cc8d606d
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Jakub Morvay [Fri, 21 Oct 2016 11:22:39 +0000 (13:22 +0200)]
Remove old clustered netconf topology implementation
Since new netconf clustering implementation resides in
netconf-topology-singleton module, old implementation is not needed
anymore. This patch gets rid of it.
Change-Id: I99ba7baced099bd5431a4014378d4ab3b22d93ba
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Rudolf Brisuda [Fri, 7 Oct 2016 09:44:23 +0000 (11:44 +0200)]
Bug 6714 - Use singleton service in clustered netconf topology
Implemented clustered netconf topology with using clustered
singleton service.
Change-Id: I0e71a9934a70c6bce8eeab0644a5bd05c5548a8c
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
Ivan Hrasko [Fri, 21 Oct 2016 13:38:38 +0000 (15:38 +0200)]
Fix tests after merging Change 47121 to Yangtools
Change-Id: I4bafce0972da4e83fe4575517b5e95808bb21caf
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Vratko Polak [Thu, 20 Oct 2016 15:25:00 +0000 (17:25 +0200)]
Add xml config dependency to features pom
Configfile added here [0] also needs to be listed as pom dependency,
otherwise distribution-check would fail.
Also added to netconf-artifacts.
[0] https://git.opendaylight.org/gerrit/#/c/44243/10/features/netconf/src/main/features/features.xml
Change-Id: If016aadb03154d83ddd0afa680e8d1d8acd88217
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Tomas Cere [Thu, 20 Oct 2016 13:02:06 +0000 (13:02 +0000)]
Merge "Add more unit tests for sal-netconf-connector"
Tomas Cere [Thu, 20 Oct 2016 13:01:27 +0000 (13:01 +0000)]
Merge "Bug 6023 - Adress for config subsystem netconf endpoint is not configurable"
Andrej Mak [Thu, 20 Oct 2016 07:19:39 +0000 (09:19 +0200)]
Add more unit tests for sal-netconf-connector
Change-Id: I76df3726b4c99c93c3ab98edcf0e7aca94d99b79
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Rudolf Brisuda [Wed, 17 Aug 2016 12:03:04 +0000 (14:03 +0200)]
Bug 6023 - Adress for config subsystem netconf endpoint is not configurable
- added NetconfConfigurationActivator for loading ManagedService
- updating configuration from karaf netconf.cfg file
- edited NetconfTCPActivator, NetconfSSHActivator for run with
cfg values
Change-Id: I5069a9f307a9a9b7c2d79723dc6c1cca0b2cc201
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
Andrej Mak [Wed, 19 Oct 2016 08:24:36 +0000 (10:24 +0200)]
Add unit tests for sal-netconf-connector transactions
Change-Id: I49cbfacd1c41cb531f6fb003110721ae9cbccf0f
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Tomas Cere [Tue, 18 Oct 2016 10:53:24 +0000 (10:53 +0000)]
Merge "Bug 4868 - Extend netconf-node-topology model to distinguish user overriden capabilities from device reported capabilities"
Tomas Cere [Tue, 18 Oct 2016 08:53:43 +0000 (08:53 +0000)]
Merge "Bug 6936 - Fix post request"
Rudolf Brisuda [Mon, 15 Aug 2016 12:46:14 +0000 (14:46 +0200)]
Bug 4868 - Extend netconf-node-topology model to distinguish user overriden capabilities from device reported capabilities
- changed model and corresponding data bindings and imports, updated tests
Change-Id: I0c9dd78c0bf2c4485f27c0049909a04c6155e718
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
Rudolf Brisuda [Fri, 16 Sep 2016 11:05:24 +0000 (13:05 +0200)]
netconf-notifications-api unit tests added
Change-Id: I02d2bbabb6e5fabb8f45a89c9233a0e763636596
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
miroslav.kovac [Thu, 13 Oct 2016 06:26:51 +0000 (08:26 +0200)]
Bug 6936 - Fix post request
When post request sends data which already exist, it response with
data already exist.
Change-Id: I2ea60dfe4b8aa4236fbec0fd73b64a6f146146ee
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Rudolf Brisuda [Mon, 19 Sep 2016 15:51:23 +0000 (17:51 +0200)]
netconf-console unit tests added
Change-Id: I3975e0740935dbbe6bc65f6e3ea3febf56507f39
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
Tomas Cere [Thu, 13 Oct 2016 08:38:28 +0000 (08:38 +0000)]
Merge "Bug 6679 - api explorer creates false examples"
Tomas Cere [Thu, 13 Oct 2016 08:36:31 +0000 (08:36 +0000)]
Merge "Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes"
Tomas Cere [Thu, 13 Oct 2016 08:35:55 +0000 (08:35 +0000)]
Merge "Bug 6746 - Restconf: Not working GET operation on mount points"
Tomas Cere [Thu, 13 Oct 2016 08:34:24 +0000 (08:34 +0000)]
Merge "Implement TesttoolParams.toString() via reflection"
Ivan Hrasko [Fri, 23 Sep 2016 11:33:13 +0000 (13:33 +0200)]
Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes
- solution for Restconf draft17
- make mount point service available when identifier is parsed
- added unit tests
Change-Id: Ie3c5cdc9cbcb10360ac9d0a082eab52efba75674
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
miroslav.kovac [Mon, 10 Oct 2016 16:53:01 +0000 (18:53 +0200)]
Bug 6679 - api explorer creates false examples
Api explorer created false examples when yang has two data nodes with
same name in different containers or lists. It compared name of data
nodes rather than whole path to the data node which result to creting
examples of same types even if they should be different.
Fix examples by comparing the path to data node rather than just name
of the node.
Change-Id: I6f73fb37985fc78ad67ecc466ebfdfe569d7cd8d
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Ivan Hrasko [Mon, 19 Sep 2016 14:22:53 +0000 (16:22 +0200)]
Bug 6746 - Restconf: Not working GET operation on mount points
- support for reading data on mount points
- improved merge for config and state data:
when identifiers for data in config and state are the same
then merge must by done at one level down, otherwise state
overrides config or vice versa
- identiers are parsed to identifiers context with reference
to mount points when data are behind mount point
- adapted and added unit tests
Change-Id: Iacc45946cc284ae8936f600f5af522926d39c216
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Jakub Toth [Wed, 5 Oct 2016 13:33:07 +0000 (15:33 +0200)]
Bug 6848 - update url pattern of restconf from 16 to 17
Change-Id: I41882d048a3aede5f4c47c3e160537f7a31a1fab
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Wed, 5 Oct 2016 12:56:08 +0000 (14:56 +0200)]
Bug 6848 - repackage providers for jersey+create xml
and json reader for restconf draft17
*fix tests
*rename tests part from draft11 to draft17
Change-Id: I1315bb693eccc34c78f07ea0acbf45f6ff972455
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Andrej Mak [Tue, 4 Oct 2016 09:08:58 +0000 (11:08 +0200)]
Implement TesttoolParams.toString() via reflection
Change-Id: I2222fcf8b5d95a343f107ed3acd557fbfdf40f42
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Andrej Mak [Tue, 11 Oct 2016 06:20:17 +0000 (08:20 +0200)]
Fix compilation failure caused by DocumentedException refactoring
Change-Id: I4742760b4afba103af577efc5ffe5905a8255127
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Andrej Mak [Tue, 4 Oct 2016 13:54:18 +0000 (15:54 +0200)]
Add unit test for NetconfConnectorModule
Change-Id: I865ab9edd5e056579c92aa1436cda8da032dc1e7
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Tomas Cere [Fri, 7 Oct 2016 13:46:32 +0000 (13:46 +0000)]
Merge "Add missing Netconf node fields"
Tomas Cere [Fri, 7 Oct 2016 13:39:34 +0000 (13:39 +0000)]
Merge changes from topic 'Upgrade ietf-restconf draft16 to draft17'
* changes:
Bug 6848 - upgrade XML media type
Bug 6848 - upgrade namespace of notification container
Bug 6848 - Renaming to draft17
Tomas Cere [Fri, 7 Oct 2016 11:50:31 +0000 (11:50 +0000)]
Merge "Use BDD style mocking everywhere if used once."
Tomas Cere [Fri, 7 Oct 2016 10:21:43 +0000 (12:21 +0200)]
Do a proper disconnect when deleting a connector.
Change-Id: I1abba51e331eb1f019e5f2fe741f3836f840aae1
Signed-off-by: Tomas Cere <tcere@cisco.com>
Jakub Toth [Tue, 4 Oct 2016 06:54:46 +0000 (08:54 +0200)]
Bug 6848 - upgrade XML media type
Change-Id: I16b959a4f325468836477c60d094a1e7473de9e1
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Tue, 4 Oct 2016 06:48:07 +0000 (08:48 +0200)]
Bug 6848 - upgrade namespace of notification container
Change-Id: I6f50832bc94d809d5ba354ceb17dfdecc0b181bd
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Mon, 3 Oct 2016 13:48:08 +0000 (15:48 +0200)]
Bug 6848 - Renaming to draft17
Change-Id: Ib76f9f0ed4e86a4e9cc15d82fd4ede5040964969
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Andrej Mak [Wed, 5 Oct 2016 11:24:11 +0000 (13:24 +0200)]
Add missing Netconf node fields
Change-Id: I2128f4ddfc19fabb07ddae9f30e7bfceef3b7c56
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Jakub Toth [Tue, 4 Oct 2016 12:02:06 +0000 (14:02 +0200)]
Fix close() in provider
*added condition on get() from handler
Change-Id: I45c89c44585dc1e5e3ae685eba8d6033ea2e171f
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Tomas Cere [Tue, 4 Oct 2016 11:58:28 +0000 (11:58 +0000)]
Merge "Bug 6635: Correct WriteRunningTx behavior"
Tomas Cere [Tue, 4 Oct 2016 11:08:32 +0000 (13:08 +0200)]
Use BDD style mocking everywhere if used once.
Change-Id: Ie8a67f7ef8b07037d37e4813e0afe2908707c1d5
Signed-off-by: Tomas Cere <tcere@cisco.com>
Andrej Mak [Tue, 27 Sep 2016 07:18:19 +0000 (09:18 +0200)]
Remove duplicated code
Spawning network connector via config subsystem now
only creates Netconf node from provided values
and writes it to the topology. Topology handles
the rest of mountpoint creation.
Change-Id: I443ca5c6668bf56d8e79cfe83aaa9d76af3b9d50
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Tomas Cere [Tue, 4 Oct 2016 08:41:05 +0000 (08:41 +0000)]
Merge "Check Testool YANG filenames for revision"
Tomas Cere [Tue, 4 Oct 2016 08:40:43 +0000 (08:40 +0000)]
Merge "Bug 6099 - ControllerContext#addKeyValue ignores key type when key is derived type from instance-identifier"
Tomas Cere [Tue, 4 Oct 2016 08:39:27 +0000 (08:39 +0000)]
Merge "PATCH transaction JUnit test"
matus.kubica [Wed, 7 Sep 2016 12:22:44 +0000 (14:22 +0200)]
PATCH transaction JUnit test
Test patch operations with JUnit and Mockito
Merge some tests to one testing method
Rename tests
Add negative test
Check if MERGE makes put transaction on nonexistent data
Change-Id: I2d3529cd649a81a34017f3a9f5014e0f62c9773b
Signed-off-by: matus.kubica <Matus.Kubica@pantheon.tech>
Jakub Toth [Mon, 12 Sep 2016 13:30:06 +0000 (15:30 +0200)]
Bug 6099 - ControllerContext#addKeyValue ignores key type when key is derived
type from instance-identifier
* added instance identifier support as value
* JUnit test added
Change-Id: I4f6a070b5814ef2a33b68534d887745a099712c8
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Andrej Mak [Fri, 16 Sep 2016 12:27:49 +0000 (14:27 +0200)]
Bug 6635: Correct WriteRunningTx behavior
WriteRunningTx sends edit-config rpcs only after submit,
not after every put or merge as it was before.
Change-Id: I88268fa812b13a0718114d74ec1c44ce4d3d26b3
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Ivan Hrasko [Tue, 27 Sep 2016 12:32:33 +0000 (14:32 +0200)]
Bug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound NETCONF
- dataSchemaNode can contains multiple childs with the same name,
thus when looking for child also namespace has to be compared
- added unit tests
Change-Id: I922e96fd2aea686c27ad4683ef7366c6718486c3
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Fri, 2 Sep 2016 14:01:32 +0000 (16:01 +0200)]
Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes
- distinguish between operation on server or on mount point
- when operates on server then use global schema context and
data broker
- when operates on mount point then use schema context and
broker from mount point
- if broker on mount point is missing then PATCH operation fails
with global error
- contains unit tests
Change-Id: I97135a467209fcb4a5782d1c2677f482b842ff8a
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
ykq [Thu, 29 Sep 2016 03:36:54 +0000 (11:36 +0800)]
Bug 6797 - Fix deadlock on cached schema-changed notifications
Add an atomic state in NetconfDeviceCommunicator to improve the state
transition of close operation, to avoid deadlock while multiple threads
are doing the close.
Change-Id: I2f2c41b86b724eba78a74bfb96c0b499dc7f79a3
Signed-off-by: ykq <yin.kangqian@zte.com.cn>
Tomas Cere [Thu, 29 Sep 2016 15:24:05 +0000 (15:24 +0000)]
Merge "Move sal-remote to sal-rest-connector"
Tomas Cere [Thu, 29 Sep 2016 11:51:09 +0000 (11:51 +0000)]
Merge "netconf-api simple unit test added"
Tomas Cere [Thu, 29 Sep 2016 11:47:16 +0000 (11:47 +0000)]
Merge "mdsal-notification simple unit test added"
Tomas Cere [Thu, 29 Sep 2016 11:46:48 +0000 (11:46 +0000)]
Merge "sal-netconf-connector unit tests added"
Tomas Cere [Thu, 29 Sep 2016 11:17:02 +0000 (11:17 +0000)]
Merge "Bug 6681: Fix md-sal netconf edit-config behavior"
Tomas Cere [Wed, 28 Sep 2016 14:19:18 +0000 (14:19 +0000)]
Merge "Remove use of controller/checkstyle.xml (use odl-parent's new Checkstyle)"
Andrej Mak [Wed, 21 Sep 2016 10:11:00 +0000 (12:11 +0200)]
Bug 6681: Fix md-sal netconf edit-config behavior
Check for existence of mixin map node. If it doesn't exist,
create it. Only then write map entry.
Before this patch if user tried to create map entry,
but parent mixin map node didn't exist, edit config failed.
Change-Id: I4004a66100eb4e0d0918005c54b06fdebc8ea6dd
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Rudolf Brisuda [Fri, 19 Aug 2016 13:38:24 +0000 (15:38 +0200)]
sal-netconf-connector unit tests added
Change-Id: If01df83d92eb38106a634ea6c246fc76b6999d2d
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
Tomas Cere [Fri, 23 Sep 2016 11:55:53 +0000 (11:55 +0000)]
Merge "yanglib unit tests added"
Alexis de Talhouët [Tue, 23 Aug 2016 22:24:07 +0000 (18:24 -0400)]
Move sal-remote to sal-rest-connector
This module is only used by sal-rest-connnector bundle,
moreover, it is intended to create notification stream
and/or register a data change event which is done using
RESTCONF, thus it make sense to move it to the appropriate
project.
I beleive this is a leftover of the migration that happened
when controller was splitted out..
Change-Id: Ie23fa2fa48cffe3bc395b814b86e70befd4a684a
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Tomas Cere [Fri, 23 Sep 2016 11:48:09 +0000 (11:48 +0000)]
Merge "netconf-notifications-impl unit tests added"
Rudolf Brisuda [Fri, 23 Sep 2016 11:13:54 +0000 (13:13 +0200)]
config-netconf-connector unit test added
Change-Id: I871d24097801f2bbaff9c984710ea8636d80f609
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
Rudolf Brisuda [Fri, 16 Sep 2016 12:54:21 +0000 (14:54 +0200)]
netconf-notifications-impl unit tests added
Change-Id: I2a73ca3962cfa663d4dfa7dd2035a878f090d54f
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
Rudolf Brisuda [Tue, 20 Sep 2016 09:06:51 +0000 (11:06 +0200)]
yanglib unit tests added
Change-Id: I27054db37b52c1ef5a0fc8e79777e78b84932aae
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
Rudolf Brisuda [Fri, 23 Sep 2016 09:04:54 +0000 (11:04 +0200)]
mdsal-notification simple unit test added
Change-Id: Iabf4f59f80ab28871c2fa340a24eb0954dc8fa99
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
Matus.Kubica [Wed, 21 Sep 2016 16:11:26 +0000 (18:11 +0200)]
Check Testool YANG filenames for revision
Check Yang files, if its name contains revision date
Replace original name without revision with name in format xxx-yyy@2000-01-01
Change-Id: Icb123cc0f173295fe98c7913ce376e805ddbb9b1
Signed-off-by: Matus.Kubica <Matus.Kubica@pantheon.tech>
Tomas Cere [Thu, 22 Sep 2016 13:05:17 +0000 (13:05 +0000)]
Merge "Address TODOs: use NetconfRpcFutureCallback for RPC callback"
miroslav.kovac [Tue, 20 Sep 2016 09:00:19 +0000 (11:00 +0200)]
Add Unit test for bug fix 5998 and 5997
Change-Id: I0e3ea4d2da47327473d0f74e1945b9c19103a141
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
miroslav.kovac [Wed, 14 Sep 2016 09:34:46 +0000 (11:34 +0200)]
Bug 5997 - Fix put and post body examples
Change-Id: I1b13bc2128b9dd3924a69c0cb29ad09b0ec132dc
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Rudolf Brisuda [Tue, 20 Sep 2016 13:09:46 +0000 (15:09 +0200)]
netconf-api simple unit test added
Change-Id: I2bd0e90a1590b65a88bdb3629c1737066fb8bdb8
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
Tomas Cere [Thu, 22 Sep 2016 08:31:42 +0000 (08:31 +0000)]
Merge "Bug 5998 - fix operations request example body"
Tomas Cere [Thu, 22 Sep 2016 08:30:50 +0000 (08:30 +0000)]
Merge "Add final where needed"
Tomas Cere [Thu, 22 Sep 2016 08:28:01 +0000 (08:28 +0000)]
Merge "Clean-up mdsal-netconf-connector"
Tomas Cere [Thu, 22 Sep 2016 08:19:25 +0000 (08:19 +0000)]
Merge "Clean-up config-netconf-connector"
Alexis de Talhouët [Tue, 13 Sep 2016 19:46:33 +0000 (15:46 -0400)]
Address TODOs: use NetconfRpcFutureCallback for RPC callback
Change-Id: I89645c47a97ef808101c683d2f78a5dd7c5c421b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Wed, 14 Sep 2016 22:55:26 +0000 (18:55 -0400)]
Clean-up mdsal-netconf-connector
- add FIXME to address duplicated code
- remove unsed API
- remove iner generic type
- use lambda when possible
- reduce visibility of param when possible
Change-Id: Id0ce780026c20ab67d3621b7162653606235634c
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Wed, 14 Sep 2016 22:14:01 +0000 (18:14 -0400)]
Clean-up config-netconf-connector
- add final and/or this when possible
- remove infer generic type
- use method reference
Change-Id: I43d7a3f3cc0ec576dd6f44b0abc0c766e0003a6f
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Wed, 14 Sep 2016 22:30:55 +0000 (18:30 -0400)]
Clean-up models/* pom files
- Remove unecessary dependencies
Change-Id: Id957c8b29d7a25e878bf759062ef5dd5786ecacc
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
miroslav.kovac [Tue, 13 Sep 2016 15:38:05 +0000 (17:38 +0200)]
Bug 5998 - fix operations request example body
Change-Id: I4e5d56a58527b48d32836f25e74b12a1a0aad703
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
miroslav.kovac [Tue, 13 Sep 2016 15:41:34 +0000 (17:41 +0200)]
Add final where needed
Change-Id: I4d0856a611f4fea5a9994fd375454d3fc14998b6
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Tomas Cere [Wed, 21 Sep 2016 13:07:34 +0000 (13:07 +0000)]
Merge "Fix broken ApiDocGeneratorTest"
miroslav.kovac [Wed, 21 Sep 2016 11:22:42 +0000 (13:22 +0200)]
Fix broken ApiDocGeneratorTest
Patch https://git.opendaylight.org/gerrit/#/c/43500/ changed
the way constraints are handled in yangtools which causes
the faiure of EdgeTest in ApiDocGeneratorTest.
Change-Id: I455d924b69aee0a6cd6304be27656d44a62e6c73
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Tomas Cere [Wed, 21 Sep 2016 10:44:25 +0000 (10:44 +0000)]
Merge "Clean-up mdsal-netconf-notification"
Tomas Cere [Wed, 21 Sep 2016 10:34:49 +0000 (10:34 +0000)]
Merge "Add missing copyright to pom files"
Tomas Cere [Wed, 21 Sep 2016 10:33:40 +0000 (10:33 +0000)]
Merge "Do not loose cause when wrapping DocumentedException in NetconfDocumentedException"
Tomas Cere [Wed, 21 Sep 2016 10:25:20 +0000 (10:25 +0000)]
Merge "mdsal-netconf-notification unit tests added"
Jakub Toth [Thu, 8 Sep 2016 09:04:01 +0000 (11:04 +0200)]
Bug 6664 - upgrade draft15 to draft16 - change media types
* for XML - yang-data -> yang-data-xml
Change-Id: I56c8cc5439d962ca7a54c931965ccb519f0f0617
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Thu, 8 Sep 2016 08:35:25 +0000 (10:35 +0200)]
Bug 6664 - upgrade draft15 to draft16 - renaming
Change-Id: Iaaefc58f8615f8ef16ba538d23576ea852be1064
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Alexis de Talhouët [Thu, 15 Sep 2016 20:56:58 +0000 (16:56 -0400)]
Do not loose cause when wrapping DocumentedException in NetconfDocumentedException
DocumentedException has a constructor allowing to define the Throwable/Exception,
but the wrapping done in NetconfDocumentedException is loosing this information.
This patch makes sure we propagate the exception correctly.
Change-Id: Icf8bd3f71e5e781e0358c2219f3083ea455dfb32
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Thu, 15 Sep 2016 15:36:17 +0000 (11:36 -0400)]
Add missing copyright to pom files
Change-Id: Ia6b3a64ad08669952e98883bbb2dcb85d2c41a6b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Thu, 15 Sep 2016 12:19:18 +0000 (08:19 -0400)]
Clean-up mdsal-netconf-notification
- remove infer generic type
Change-Id: If0d6fe6f76d4a2c85de45345900464d545dffbaf
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Michael Vorburger [Wed, 14 Sep 2016 15:38:00 +0000 (17:38 +0200)]
Remove use of controller/checkstyle.xml (use odl-parent's new Checkstyle)
Change-Id: I65dccf0501dfe7c1fa480338ca0890c494a239bc
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Alexis de Talhouët [Tue, 13 Sep 2016 19:29:37 +0000 (15:29 -0400)]
Wrap throwable in NetconfDocumentedException for AbstractWriteTx
Change-Id: Ie7e70224d7505a243a428eb9cc4561a604175f5e
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Code Review / netconf.git / log