Robert Varga [Mon, 1 Sep 2014 10:27:15 +0000 (12:27 +0200)]
Kill trailing whitespace
Change-Id: If8e0ee748fb3f595f2e3e39ef40800fd35d317d8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 1 Sep 2014 09:07:03 +0000 (09:07 +0000)]
Merge changes I8a672b0e,I8f0a22a8,I2192d909
* changes:
BUG-1440: use a precondition instead of a throw
BUG-1440: remove open-coded Multimap
BUG-1440: improve CompositeNodeDataWithSchema
Tony Tkacik [Mon, 1 Sep 2014 08:43:57 +0000 (08:43 +0000)]
Merge changes I0bc3b486,I67f2ca3e,Ie591417d,I01acd9f9,I8e1526a6,I0876d878,I0ed71b9c,I0697d018,I2750f089,I48183547
* changes:
BUG-1440: add documentation and update API
BUG-1440: add documentation
BUG-1440: speed up LoggingNormalizedNodeStreamWriter
BUG-1441: implement XMLStreamNormalizedNodeStreamWriter
BUG-1440: fix a few typos
BUG-1440: speedup namespace/localname splitting
BUG-1440: speedup namespace resolution
BUG-1440: cache codecs
BUG-1440: remove unused imports
BUG-1440: include gson codec in feature
Robert Varga [Sun, 31 Aug 2014 13:47:14 +0000 (13:47 +0000)]
Merge "BUG-869: minor changes to improve code readability in TypeDefinitionAwareCodec"
Robert Varga [Sun, 31 Aug 2014 08:46:07 +0000 (10:46 +0200)]
BUG-1440: use a precondition instead of a throw
Removes string concat in exception text and makes the code more
readable.
Change-Id: I8a672b0e355b61119db3e48bc290853bbc78a429
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 20 Aug 2014 15:17:02 +0000 (17:17 +0200)]
Bug 1443: Make sure that LazyDataObject hashCode computation is consistent
Change-Id: Ib430dabc445975c02d6176e23e4fb9c85b43f906
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Sun, 31 Aug 2014 00:21:28 +0000 (02:21 +0200)]
BUG-1440: remove open-coded Multimap
The code is completely equivalent with what Guava's Multimap provides,
so let's just use that.
Change-Id: I8f0a22a89c4c31a62f16ebd970f940cfc04af2ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 30 Aug 2014 21:42:57 +0000 (23:42 +0200)]
BUG-1440: add documentation and update API
Cleans up the API defition, making it slightly easier to understand.
Change-Id: I0bc3b486ec6bc88eea226a6fe39a346775b9e2bc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 30 Aug 2014 21:54:37 +0000 (23:54 +0200)]
BUG-1440: improve CompositeNodeDataWithSchema
- Hide internal state, making fields final
- Preserve field order in augmentations
- Use preconditions and simplify checks
- Emit correct child sizing hints
- Speed up predicate/augmentation builder
Change-Id: I2192d9093aa3909a960f4172468d971d2fd51aec
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 30 Aug 2014 21:19:06 +0000 (23:19 +0200)]
BUG-1440: add documentation
Change-Id: I67f2ca3e03216afeb8a4b80105d72347c5a4719c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 30 Aug 2014 21:04:28 +0000 (23:04 +0200)]
BUG-1440: speed up LoggingNormalizedNodeStreamWriter
Precompute indent string as we go, saving some object instantiations.
Change-Id: Ie591417d28066140e99d7718d19d926d1e863d1f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 28 Aug 2014 15:17:37 +0000 (17:17 +0200)]
BUG-1441: implement XMLStreamNormalizedNodeStreamWriter
Introduces a direct NormalizedNode/XMLStreamWriter binding component.
Change-Id: I01acd9f9d9e8c70b3f4cbe796ae2f948073f94f4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 30 Aug 2014 20:42:59 +0000 (22:42 +0200)]
BUG-1440: fix a few typos
Change-Id: I8e1526a67a746006e9c6200d68ca26303846c547
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 30 Aug 2014 18:36:07 +0000 (20:36 +0200)]
BUG-1440: speedup namespace/localname splitting
Instead of using splitters, perform just normal lookups.
Change-Id: I0876d8784c35e1911985293c010afcdf8484793e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 30 Aug 2014 18:09:45 +0000 (20:09 +0200)]
BUG-1440: speedup namespace resolution
Use char lookup instead of string.
Change-Id: I0ed71b9c317cafe3847680cb861136cd0258499e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 30 Aug 2014 18:03:02 +0000 (20:03 +0200)]
BUG-1440: cache codecs
Building a codec up is a bit expensive, so let's cache the objects while
we're decoding them.
Change-Id: I0697d018fe3937b8caf97518fd7a5d22ba832c51
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 28 Aug 2014 09:33:59 +0000 (11:33 +0200)]
BUG-1440: remove unused imports
These were leftover by previous changes.
Change-Id: I2750f0895fd7fbccb419167eb8e474fc18d26234
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 27 Aug 2014 06:16:02 +0000 (08:16 +0200)]
BUG-1440: include gson codec in feature
This updates the feature file to include the yang-data-codec-gson.
Change-Id: I48183547ba70a5f3d866dd9e5e694863d0607a2a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 21:47:37 +0000 (23:47 +0200)]
Remove explicit final keywords
These context use the filan modifier needlessly, so remove them to get
rid of sonar warnings.
Change-Id: I1ec3133c3978b0cfaa31c74ba57393ff9973ddc6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 21:30:55 +0000 (23:30 +0200)]
Compare booleans via equals()
Fixes a sonar warning.
Change-Id: Ifd39bfb8318b406365901117647be581d18ef9e7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 21:26:53 +0000 (23:26 +0200)]
IdentifiableItemCodec should be a static inner class
Headline really says it all. There is no reason for
IdentifiableItemCodec to be non-static.
Change-Id: I713625dbea7201a9f11d5431d81584528ddb74aa
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 21:26:13 +0000 (23:26 +0200)]
Do not use String.toString()
It is obviously not needed. Fixes a sonar warning.
Change-Id: I944acc591793520c62907f90924fc0d730646d49
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 21:20:38 +0000 (23:20 +0200)]
Improve UnionType.toString()
Do not create itermediate string just to pass it into a StringBuilder.
Fixes a sonar warning.
Change-Id: I424c1686bd919255d306c1934cb67779b7a07f52
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 21:15:35 +0000 (23:15 +0200)]
Make sure to use exception chaining
Preserving the original exception is critical for finding the root
cause, so let's keep it available via getCause(). Fixes a sonar warning.
Change-Id: I1315d228df13460a76be3e3dd6a97d03ed1723a6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 21:12:08 +0000 (23:12 +0200)]
Fix ObjectCacheFactory thread safety
The global factory instance needs to be volatile to guarantee proper
visibility. Also fix a sonar warning about field naming.
Change-Id: Ia0fd50d7a2a6210dbda1c1e2f0615ac05512eb64
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 21:06:21 +0000 (23:06 +0200)]
Uint16 shared instance should be final
Reported by sonar.
Change-Id: I3b33c1d65db865c3bfebf4e455044b3d5a941397
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 28 Aug 2014 15:05:29 +0000 (17:05 +0200)]
Simplify YangInstanceIndentifier references
Change-Id: I272b332b87f05ef03c27f0e38256c64a70dd92f4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 14:59:18 +0000 (16:59 +0200)]
Fix SchemaPath.legacyPath visibility
Thread safety is not assured without legacyPath being volatile.
Change-Id: I7e69777cb4af6b3bc359a0a2b218ecdba433f369
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 29 Aug 2014 20:54:16 +0000 (20:54 +0000)]
Merge "BUG-576: fixed possible null pointer dereference in BindingGeneratorImpl"
Robert Varga [Fri, 29 Aug 2014 20:52:17 +0000 (20:52 +0000)]
Merge "BUG-1433: augmentation field visibility changed to default"
Tony Tkacik [Fri, 29 Aug 2014 20:47:04 +0000 (20:47 +0000)]
Merge "Bug 1446: Add new concurrent classes for tracking stats"
Robert Varga [Fri, 29 Aug 2014 20:40:46 +0000 (20:40 +0000)]
Merge "BUG-869: removed redundant check for null before an instanceof"
Robert Varga [Fri, 29 Aug 2014 20:23:26 +0000 (20:23 +0000)]
Merge "BUG-869: added proper handling of nullable parameter"
Robert Varga [Fri, 29 Aug 2014 20:04:40 +0000 (20:04 +0000)]
Merge "Fix to feature files to include ietf-yang-types-
20130715"
Ed Warnicke [Thu, 28 Aug 2014 20:39:21 +0000 (15:39 -0500)]
Fix to feature files to include ietf-yang-types-
20130715
ietf-yang-types-
20130715 was missing from feature:
odl-yangtools-models
Change-Id: Idb6c6cd2b3377e8f3c18bd1e4b1dd665f00d2642
Signed-off-by: Ed Warnicke <eaw@cisco.com>
tpantelis [Thu, 7 Aug 2014 21:32:09 +0000 (17:32 -0400)]
Bug 1446: Add new concurrent classes for tracking stats
TrackingLinkedBlockingQueue
A LinkedBlockingQueue that tracks the largest queue size foridebugging.
CountingRejectedExecutionHandler
A RejectedExecutionHandler that delegates to a backing RejectedExecutionHandler
and counts the number of rejected tasks.
DurationStatsTracker
Class that calculates and tracks time duration statistics.
Change-Id: I1b7bbb45301d8cf682a5de5d51cc64727e3139dc
Signed-off-by: tpantelis <tpanteli@brocade.com>
Tony Tkacik [Thu, 28 Aug 2014 16:19:22 +0000 (16:19 +0000)]
Merge "Bug 1505 - Provide test coverage for binding-data-codec using sal-test-model"
Tony Tkacik [Thu, 28 Aug 2014 15:03:20 +0000 (15:03 +0000)]
Merge "Hotfix for gson test."
Tony Tkacik [Thu, 28 Aug 2014 14:42:09 +0000 (14:42 +0000)]
Merge "BUG-869: avoid String repetition in RestRestconfService."
Tony Tkacik [Thu, 28 Aug 2014 14:41:41 +0000 (14:41 +0000)]
Merge "BUG-576: fixed invalid key used to search map of modules."
Tony Tkacik [Thu, 28 Aug 2014 14:40:15 +0000 (14:40 +0000)]
Merge "BUG-576: fixed bug in AbstractSchemaRepository.removeSource"
Tony Tkacik [Thu, 28 Aug 2014 14:39:35 +0000 (14:39 +0000)]
Merge "BUG-576: added support for handling nested groupings in code generator."
Tony Tkacik [Thu, 28 Aug 2014 14:39:09 +0000 (14:39 +0000)]
Merge "BUG-576: fixed invalid if conditions in LazyGeneratedCodecRegistry."
Lukas Sedlak [Thu, 28 Aug 2014 14:10:27 +0000 (16:10 +0200)]
Hotfix for gson test.
Test had to be modified prior to internal use of hash sets. Test relied on retrieving first item from
parsedData values. That lead to test failure on various platforms. Now test should run without problems.
Change-Id: Icaa920645c0e12bc922eef131b89e27d7a6b213f
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
Tony Tkacik [Thu, 28 Aug 2014 12:18:31 +0000 (12:18 +0000)]
Merge "BUG-576: fixed test sources loading in YangModuleInfoCompilationTest."
Tony Tkacik [Thu, 28 Aug 2014 11:50:24 +0000 (11:50 +0000)]
Merge "BUG-869: removed useless null check from DataValidationException.checkListKey"
Martin Vitez [Thu, 28 Aug 2014 11:44:54 +0000 (13:44 +0200)]
BUG-869: avoid String repetition in RestRestconfService.
Change-Id: I5dee877114166842dbbbf3596970e0cea55b7686
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Thu, 28 Aug 2014 09:46:25 +0000 (11:46 +0200)]
BUG-869: removed useless null check from DataValidationException.checkListKey
Null check is useless because
1. it is already performed in call to overloaded checkListKey
2. value is already dereferenced and if it were null a NullPointerException would have occurred
Expression 'if (isLegal == false)' simplified to 'if (!isLegal)'.
Change-Id: I7bf332e99e35d283726e439caf1d2a39a17df932
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Tony Tkacik [Thu, 28 Aug 2014 10:43:01 +0000 (10:43 +0000)]
Merge "BUG-1590: introduce PathArgument.toRelativeString() and use it"
Martin Vitez [Thu, 28 Aug 2014 10:24:17 +0000 (12:24 +0200)]
BUG-869: minor changes to improve code readability in TypeDefinitionAwareCodec
- String.format should use %n rather than \n
- removed redundant call to String.toString on known non-null object
Change-Id: Iac2506041184852c1e1e12bab787d1eefef1358b
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Thu, 28 Aug 2014 10:01:38 +0000 (12:01 +0200)]
BUG-869: removed redundant check for null before an instanceof
No need to check for null before an instanceof, the instanceof keyword returns false when given a null argument.
Change-Id: Ib572460a5972406a6a27347f73e19d27109f994c
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Thu, 28 Aug 2014 09:40:48 +0000 (11:40 +0200)]
BUG-576: fixed bug in AbstractSchemaRepository.removeSource
Change-Id: If91f1877c1bcd17eab3f547dbe4dc6613421a129
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Thu, 28 Aug 2014 09:25:57 +0000 (11:25 +0200)]
BUG-869: replaced inefficient use of keySet with entrySet in XmlUtils
Change-Id: Ib665da6c15b6906e6eb220fd0ec53b7ecfbba04f
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Thu, 28 Aug 2014 09:03:39 +0000 (11:03 +0200)]
BUG-576: fixed invalid if conditions in LazyGeneratedCodecRegistry.
1. fixed check to 'previous instanceof DataNodeContainer' - this check always return true
2. fixed incorrect equals parameter: expected URI but was QName
Change-Id: Ib67ac5b1fc87296bcaa117e9bf1d5f04185c367b
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Jan Hajnar [Thu, 21 Aug 2014 13:07:33 +0000 (15:07 +0200)]
Bug 1505 - Provide test coverage for binding-data-codec using
sal-test-model
* added test yang modules to bindig-test-model
* added tests for serialization/deserialization of normalized nodes and
paths to binding-data-codec
Change-Id: Ibdf24dd9e51281be488fb40481a79d6f086a2115
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Robert Varga [Wed, 27 Aug 2014 16:37:08 +0000 (16:37 +0000)]
Merge "Fixed incorrect instanceof in yang-data-operations."
Martin Vitez [Wed, 27 Aug 2014 08:42:57 +0000 (10:42 +0200)]
BUG-576: fixed test sources loading in YangModuleInfoCompilationTest.
Fixed test to parse File sources with relative test.
Change-Id: I4af05166a2c26cf4a3f673b1651ac28c717dd43e
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Tony Tkacik [Wed, 27 Aug 2014 14:19:24 +0000 (14:19 +0000)]
Merge "Bug 1630: Updated normalized to binding codec to exclude LeafSetEntryNode."
Tony Tkacik [Wed, 27 Aug 2014 14:12:44 +0000 (16:12 +0200)]
Bug 1630: Updated normalized to binding codec to exclude LeafSetEntryNode.
Change-Id: I8d921ed8d03e19a3fb9868ef9a0a8ebecb02563c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Wed, 27 Aug 2014 14:08:47 +0000 (14:08 +0000)]
Merge "Fixed merge job breakage."
Tony Tkacik [Wed, 27 Aug 2014 13:39:17 +0000 (15:39 +0200)]
Fixed merge job breakage.
Change-Id: I981e5e70e8798492403ef14c9d7af091145765d0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Wed, 27 Aug 2014 13:23:55 +0000 (13:23 +0000)]
Merge "BUG-869: reworked check for integer value."
Tony Tkacik [Wed, 27 Aug 2014 13:10:11 +0000 (13:10 +0000)]
Merge "ModifiedNode instantiation improvement."
Tony Tkacik [Wed, 27 Aug 2014 13:09:47 +0000 (13:09 +0000)]
Merge "Bug 1258: Implement DataTree partial indexing"
Robert Varga [Wed, 27 Aug 2014 12:15:28 +0000 (14:15 +0200)]
BUG-1630: fix warning message format
The bug has been reasolved by change
I4a35ff27725dab7f35b83ae1bcc6d728a313bd1c, this patch just fixes the
message format.
Change-Id: Ic77f0675c8adb1c6d2ba29ea555335e7eaba4a34
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 27 Aug 2014 12:09:12 +0000 (12:09 +0000)]
Merge "BUG-650: add missing bypass"
Tony Tkacik [Wed, 27 Aug 2014 11:19:25 +0000 (11:19 +0000)]
Merge "BUG-650: improve toYangInstanceIdentifier() speed"
Robert Varga [Wed, 27 Aug 2014 10:29:55 +0000 (12:29 +0200)]
BUG-650: add missing bypass
ChoiceNode is not representable either, so check for it early. Also
eliminate the FIXME, now that we are in the clear about what needs to
happen. Finally log offending class in warning, so we can track it down.
Change-Id: I4a35ff27725dab7f35b83ae1bcc6d728a313bd1c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 27 Aug 2014 10:28:15 +0000 (10:28 +0000)]
Merge "Pre-cache child node set"
Lukas Sedlak [Wed, 27 Aug 2014 09:11:08 +0000 (09:11 +0000)]
Merge "Bug 1443: Added support for misplaced augmentations."
Tony Tkacik [Tue, 26 Aug 2014 14:35:19 +0000 (16:35 +0200)]
Fixed incorrect instanceof in yang-data-operations.
Intended check was to check for AugmentationIdentifier,
AugmentationNode was incorrectly checked.
Change-Id: Ice6f31407c1b8f0bb2400685730324503cd05e44
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 26 Aug 2014 11:35:22 +0000 (13:35 +0200)]
Bug 1443: Added support for misplaced augmentations.
Binding Specification reuses elements inside groupings
as part of normal data tree. Augmentations and augmented
cases could be copied by user using copy builders
and may be used at incorrect place, where augmentation
with same data is present.
Binding Data Codec will treat this augmentations as
same, if augmentation definining same data subtree
is present at real location.
Change-Id: Ie232ef9b5e5bbe84f5562bfce612d8ea03b9a9a5
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Tue, 26 Aug 2014 20:06:01 +0000 (22:06 +0200)]
BUG-650: improve toYangInstanceIdentifier() speed
This removes a superfluous call to getCodecContextNode(), since that
call is already performed by the InstanceIdentifierCodec.
Change-Id: I2077e70517adf6795f805b6c37c0a7e29b4fb9e5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 26 Aug 2014 19:55:22 +0000 (21:55 +0200)]
BUG-650: clarify BindingNormalizedNodeSerializer API contract
Non-representable YangInstanceIdentifiers are properly reported via a
null return instead of raising an undocumented IllegalArgumentException.
Also does some implementation house-cleaning geared towards performance,
as ArrayList gives better locality.
Change-Id: Iea4717c19587fd2cc1e403aae4c5967811240e9a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 26 Aug 2014 18:42:17 +0000 (20:42 +0200)]
Remove unused arguments from UnionTypeCodec.loader()
The two codecs passed in were unused, so remove them, fix the callsite
and remove the useless warnings suppression.
Change-Id: Ib3d052109303c1c18f9a4d58d2eafeefea37caba
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 26 Aug 2014 18:39:29 +0000 (20:39 +0200)]
UnionTypeCodec should not throw raw Exception
This is a callable, and we know what types of exceptions can be thrown,
so get rid of the implied sonar warning.
Change-Id: Iab62d6749cd1d33096297c2072e02c42ddebd878
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 26 Aug 2014 18:30:56 +0000 (18:30 +0000)]
Merge "BUG-865: removed use of deprecated YangInstanceIdentifier.getPath method"
Robert Varga [Tue, 26 Aug 2014 18:29:06 +0000 (18:29 +0000)]
Merge "Bug 1505 - Added test model and instance identifier test for augmentations"
Martin Vitez [Tue, 26 Aug 2014 15:30:45 +0000 (17:30 +0200)]
BUG-576: added support for handling nested groupings in code generator.
Failing example (causing NullPointerException):
container foo {
grouping bar {}
uses bar;
}
Added call to resolve groupings before resolving uses.
Change-Id: I171b3bbdd26feaf67c3488a55e7d9e3b6ec4a915
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Robert Varga [Sun, 24 Aug 2014 21:48:20 +0000 (23:48 +0200)]
Pre-cache child node set
Tracing has shown this method gets called ~5.7M times, contributing to
some 10% bootup time. Pre-cache the set of nodes to speed things up.
Change-Id: I20bf25b55a4c52a725c160d7d52c6cdd8ce4dfa0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Lukas Sedlak [Tue, 26 Aug 2014 14:24:18 +0000 (16:24 +0200)]
ModifiedNode instantiation improvement.
Every instance of ModifiedNode will contain children with hash map instance based on Modified Node ordering. Now if ModifiedNode
will cary Ordered Children LinkedHashMap will be used otherwise ordinary HashMap will be used. This should improve performance
during validation process.
Change-Id: I83dfe70a02ca5f4a6a25c4b5ebe38debad16e46b
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
Lukas Sedlak [Tue, 5 Aug 2014 14:05:48 +0000 (16:05 +0200)]
Bug 1258: Implement DataTree partial indexing
Now the TreeNode elements are instantiated lazily per applyWrite/applyMerge/applySubtreeChange operations.
Implemented createTreeNode in TreeNodeFactory to create non recursively single node instance in TreeNode
Renamed create to createTreeNodeRecursively.
Added benchmarks project directly into the root of yangtools project.
Benchmarks project contains benchmark for testing performance of InMemoryDataTree implementation.
Tool used for benchmarks is JHM.
Change-Id: I70c9745fc9ed8751c643d9bd3e9d58be10aa4a0e
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
Tony Tkacik [Tue, 26 Aug 2014 14:19:50 +0000 (14:19 +0000)]
Merge "BUG-869: description field in BitsType made static"
Tony Tkacik [Tue, 26 Aug 2014 14:07:21 +0000 (14:07 +0000)]
Merge "BUG-865: removed UnknownType class"
Tony Tkacik [Tue, 26 Aug 2014 14:06:56 +0000 (14:06 +0000)]
Merge "BUG-869: avoid unused constructor parameter namespace in YangModelDependencyInfo.ModuleDependencyInfo"
Tony Tkacik [Tue, 26 Aug 2014 14:06:46 +0000 (14:06 +0000)]
Merge "BUG-869: simplified if expressions as suggested by Sonar."
Tony Tkacik [Tue, 26 Aug 2014 14:06:22 +0000 (14:06 +0000)]
Merge "BUG-869: fixed code style violations in TypeProviderImpl reported by Sonar"
Martin Vitez [Tue, 26 Aug 2014 13:22:25 +0000 (13:22 +0000)]
Merge "Fix for features - added missing dependency"
Robert Varga [Wed, 20 Aug 2014 15:58:15 +0000 (17:58 +0200)]
BUG-1590: introduce PathArgument.toRelativeString() and use it
This patch introduces a new method, toRelativeString(), which does the
same thing as toString(), but takes into account previous path argument
and does not emit namespace if it matches the previous namespace.
Change-Id: Ia75c7cbf4a2fd7639a7c991e5b8242bd5f2a439a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 26 Aug 2014 11:33:02 +0000 (13:33 +0200)]
Bug 1505 - Added test model and instance identifier test for augmentations
Added binding-test-model, which contains models for unit testing
and integration testing of binding runtime components such as binding-data-codec.
Change-Id: Ib8219252eec5c2e1b4ddda806bea7367b7c41f9b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 12:17:27 +0000 (14:17 +0200)]
BUG-865: removed use of deprecated YangInstanceIdentifier.getPath method
Change-Id: I4f95e92173cc062deeea5ca0174a110126f43613
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Ed Warnicke [Tue, 26 Aug 2014 12:02:12 +0000 (07:02 -0500)]
Fix for features - added missing dependency
There was a missing dependency in the features/pom.xml
In some circumstances, it was causing downstream breakage.
This patch fixes that.
Change-Id: I8d2c98b4812084dd131055bcecbb57a4871c09ba
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 11:48:28 +0000 (13:48 +0200)]
BUG-869: reworked check for integer value.
Change-Id: I65b34369eeb546cd8f1716b2b7adfd25232ddece
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 11:28:58 +0000 (13:28 +0200)]
BUG-576: fixed possible null pointer dereference in BindingGeneratorImpl
Possible null pointer dereference of resultTOBuilder.
Change-Id: I5f50f1ca0fb19d7310e5278f8f6915e6dd180723
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 11:11:04 +0000 (13:11 +0200)]
BUG-576: fixed invalid key used to search map of modules.
Removed useless null check when searching for grouping.
Change-Id: Ifd8c05560a2ea6377eb3118f03466af1176666c9
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 10:51:54 +0000 (12:51 +0200)]
BUG-869: added proper handling of nullable parameter
Argument of Function.apply method is marked as Nullable, but previous implementation assumed it
as nonnull parameter.
Change-Id: Ifc49803443d7cc71e7ff7f062f30119840519377
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 09:23:47 +0000 (11:23 +0200)]
BUG-869: description field in BitsType made static
Change-Id: Idbd7886fd641ff2a2fdc8fa7f6921e3f0e0c7db2
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 10:33:42 +0000 (12:33 +0200)]
BUG-869: fixed code style violations in TypeProviderImpl reported by Sonar
Change-Id: Ica2e34c2157c48f44227f66042fff444fd56105a
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 10:17:19 +0000 (12:17 +0200)]
BUG-866: improved test resource loading
Change-Id: I479299cacf0b2070fac6325a0d0165362ee0d0fa
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Martin Vitez [Tue, 26 Aug 2014 09:18:45 +0000 (11:18 +0200)]
BUG-865: removed UnknownType class
UnknownType class is no longer used in yangtools.
Change-Id: I726db6d1b26a7c552967a9ffc5dd5dd1cfe0e93b
Signed-off-by: Martin Vitez <mvitez@cisco.com>