Applying the Helium SR4 release patch

Change-Id: I2757d5f79767991ae34c2d40a9c0c57b834e9902
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug-3780: Fixed 41-bgp-example init config file

bgp-peer was referring to incorrect bgp-rib service type

Change-Id: I5b5dfc94bc073677e9fe4c7fe495cff573b1a2b0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 740ff1b91e4a51ae25d6dfac174da56d0a61c1d6)

BUG-3892 : added ordered-by user statement to clusterIds

Without this statement, LeafSet does not guarantee the order
of clusterIds. We need to maintain the order as our clusterId
needs to be first when advertising routes.

Change-Id: Ic5d7ca2fb514a31cffc958a8a69ee3f57e3d2636
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 76030203e1a77b98917dec2e567bb4c889e4c7d1)

BUG-3419 : fix shutdown of modules

Turns out each extension when it's closed calls
stop() on their Activators. This nulls registration
list. But when the Activator itself is shut down,
it also calls its stop() method invoking an
IllegalStateException.

Change-Id: I3887cc687489e9e441224265f0e85baf6928aaee
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit bc7abb1c1b16a8a395003bfbbf6f299f4fef4c2d)

Bug 2959 - wrong result for selecting high local pref

- corrected condition by selecting best path with higher local pref

Signed-off-by: Ladislav Borak <lborak@cisco.com>
Change-Id: Ifcc3a7a14e345d4b9ba7aff0f4fdf41885800fab

Bumping versions by 0.0.1 after the Helium SR3 release

Change-Id: Id69faf1afc47ab5471493dee3341d5bc85c614d1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Applying the Helium SR3 release patch

Change-Id: Ic86789dbf111de03bb10db8bd0dcd7b031f66767
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-2712: do not hold lock while updating future

SettableFuture will call any and all registrants, which could
potentially lead to AB/BA deadlocks. with ProgrammingServiceImpl. Issue
the call to set outside a synchronized block.

Change-Id: Iddb268d2157256466b597aaef78002b4f474a149
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit b1b0924b465bf92172d4b1cb18c6da330a98111f)

Added synchronized to close().

Change-Id: Ie975458b918dd17dd7e2a0e4fb52edc0cc577904
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix unsynchronized access to TransactionChain

The background resynchronization task instantiated transactions without
holding RIBImpl lock, leading to:

Exception in thread "Thread-29" java.lang.IllegalStateException: Previous transaction DOM-OPER-1298 is not ready yet
        at com.google.common.base.Preconditions.checkState(Preconditions.java:176)
        at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl$Allocated.getSnapshot(DOMStoreTransactionChainImpl.java:68)
        at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl.getSnapshot(DOMStoreTransactionChainImpl.java:111)
        at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl.newReadWriteTransaction(DOMStoreTransactionChainImpl.java:131)
        at org.opendaylight.controller.md.sal.dom.broker.impl.AbstractDOMForwardedTransactionFactory.newReadWriteTransaction(AbstractDOMForwardedTransactionFactory.java:206)
        at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.slowAllocateTransaction(PingPongTransactionChain.java:127)
        at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.allocateTransaction(PingPongTransactionChain.java:144)
        at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.newReadWriteTransaction(PingPongTransactionChain.java:295)
        at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.newWriteOnlyTransaction(PingPongTransactionChain.java:326)
        at org.opendaylight.controller.md.sal.binding.impl.BindingTranslatedTransactionChain.newWriteOnlyTransaction(BindingTranslatedTransactionChain.java:77)
        at org.opendaylight.protocol.bgp.rib.impl.RIBImpl$1.run(RIBImpl.java:125)
        at java.lang.Thread.run(Thread.java:745)

Change-Id: I8b5b34f313dbd1b2584ea73aef37fb6e5c6b5120
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 4fa6575c890501ef7e6016e65add3dc80d353f57)

PCEP add-lsp RPC: propagate TLVs from input to initiate message.

Change-Id: Iaf9d010f178feec90f349e389c5b8f39bc2cba19
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "Bug-2631 - Fixed BGP connection collision detection" into stable/helium

Bug-2631 - Fixed BGP connection collision detection

-have to examine all connections, in OpenConfirm state
-before, only fully established connections were examined
-connections are kept in map
-remove connection from map, when session goes down
-avoids https://bugs.opendaylight.org/show_bug.cgi?id=2109
-brings dependency of BGPSessionImpl on BGPPeerRegistry
-fixed bgp-identifier conversion to long

Change-Id: I700e8e5a0fb0874731ab2fe013cd7853e44428da
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bumping versions by 0.0.1 after the Helium SR2 release

Change-Id: I818c58ca970735be105970b0ea67df8e60163951
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Applying the Helium SR2 release patch

Change-Id: I552ab7f2378b262c206f3ab0b685355535102483
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-2475: Fix keepalives not being sent

As it turns out, we failed to update channel configuration when MD5 keys
were not specified.

Change-Id: I5c2a5983c0797d032bb058974aac82254b554041
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Revert "Bug-865: modified BGPCEP config tests"" into stable/helium

Revert "Bug-865: modified BGPCEP config tests"

Required patch in upstream project was reverted, because it introduced runtime / compile-time breakage for some of projects.

This reverts commit 33ab3ab3d4bcae307185ab69c681ba1627371c76.

Change-Id: I692e9531d5def0663be78d3404b673c05c9cf8dc
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Fix a potential deadlock in BGPSession

In a two-session scenario, it is possible to arrive at a ABBA deadlock,
where we acquire locks:

Thread 1      Thread 2
--------      --------
Session A     Session B

RIB
              RIB <-- blocks waiting for Thread 1

Session B <-- blocks waiting for Thread 2

The lock is being held only for scheduling a task on Thread 2, which a
thread-safe operation, so we can simply remove the need to take the lock
in Thread 1.

Change-Id: I4e55d3228a48790b2f19eef12ce1b54fd57955a0
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fixed synchronization.

Change-Id: I2ae6bcaddfac6fd7555a8b418542cb4f5417f7a1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 896673218bdc05b7dd7a639bc135817e5088456f)

Bug-865: modified BGPCEP config tests

-edited config tests to reflect changes in binding-broker config module
https://git.opendaylight.org/gerrit/#/c/13018/

Change-Id: Ibdf28b9df4908500e178453b727f35c7e9b93243
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 41459e25b9ba7e9ae458bfb76027a29bd9bcb995)

BUG-2534 : fixed M processing in SR

Change-Id: If1147d6c4c0f07e87199c06c531b70e5ae1226ae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Set root pom.xml <name> for Sonar" into stable/helium

BUG-2568 : fixed generated EORs

Change-Id: I225b8aa7a1741f7c472715567e6157df42b6d69f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit afb392da82ae72a9f12c5c527bc2f86ab7b154ca)

Set root pom.xml <name> for Sonar

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: I138f89f0d90dfc512ec6e521b2c35c6f67152c43
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-2559 : Added forgotten SLRG attribute to linkstate-topology output.

Change-Id: I5c19cb5f60a4955f1e1f5ad16aec3067401a93d0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2157: Fix missing programming models

This fixes the hanging tests, since the RPC registration process
requires the models to be present.

Change-Id: I2f986821a610e2664305c0f49f5ce19e7ba660b8
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 04012e8960bcf91abbe58c607e8f68d116ca0f3f)

Disable to create duplicate (with same IP Address) PCEP sessions.

Session ref. entries stored in bi-map were identifed by byte array (raw IP Address of client),
casuing that already existing session in bi-map were not look-up properly => allowing to create duplicate sessions.
Changed type of bi-map's key to wrapper of byte array.

Fixed also removing of session refs. from map on channel close. Turned bi-map to map, since inverse map is not used anymore.

pcc-mock is reusing this code - need to create session negotiator factory per pcc.

Change-Id: I85670b083b6ea832f8b9a4891c812845174f03ff
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Added key to list of advertized tables to be compliant with 6020.

Change-Id: I24f37cadad003de8f27c51eea0d0e5ec70a1bd74
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2208: Added ability to configure keepalive and deadtimer

-d, --deadtimer <0..255> (optional, default 120) - DeadTimer value in seconds
-ka, --keepalive <0.255> (optional, deafult 30) - KeepAlive timer value in seconds

Change-Id: I1fcc983f96793853d719ed8c5aaa241e848801b4
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 2492: LinkstateAdjRIBsIn.removeRoutes accepts null routes.

http://tools.ietf.org/html/rfc4760#section-4
does not explicitly forbid MP_UNREACH_NLRI without any
Withdrawn Routes in it, so if statement is added
to handle withdrawnRoutes == null case.
(Patch compiles, but misses a unit test.)

Change-Id: Ie880f9c81d6a3773e4b33dea164d8bab3b6ee248
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

BUG-1953 : adjust ISO system identifier

Change-Id: Ia71d4f2e07f21e1cb30c87cf7d4c3802b4d970f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2448 : added more defensive lookup to node & link attributes

Change-Id: I2feb75c1a178df0eeffe8e234072eafa3628bd6a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2208: Mocked PCC can connect to multiple PCEs.

-input argument "--remote-address" can handle multiple
ip addresses (separated by comma).

Change-Id: I9e32781b9ced77d6351b4d681ed7677e357b039e
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2208: On session-up reported LSPs have one hop path.

-all reported LSPs have common tunnel endpoint + one hop path (ERO with one ipv4-prefix subobject)

Change-Id: Ib358bccce79e4e41020dddecfcf5476c010fc8fe
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2423: LSP Identifiers TLV in PCEP-SR PCRpt messsage

-LSP Identifier TLV is not included in LSP object of PCRpt
message for PCEP segment routing

-since building of PCEP topology depends on LSP Identifier,
lets put fake LSP Identifier (use PLSP ID value)

Change-Id: Idb0ec249a11f343c6071e6bf286fa2cb6f91940f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2436: PCEP segment-routing - take F and S flag into account

-if F flag is set, NAI value is ommited
-if S flag is set, SID value is ommited

Change-Id: Ia92680c77af0a6f8b1406de4723e9e9174479a4c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 87e629b4ad88887bc356700ff15d261dbe405d74)

Bug-1953: Fix bgpcep tests

-ipv4/6 prefixes must contain mask

Change-Id: I93c4ce30e98f5a0cd5fa8ba86a39129ee837d800
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 1dcca9cd957ec7a0ea17765b58cf07db12e0f251)

Merge "BUG-2283 : workaround in programming-impl" into stable/helium

BUG-2283 : workaround in programming-impl

Change-Id: Ibff71c25a5106e1cff96feb8a1429caa54735825
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Synchronize close methods in RIB and topology provider to avoid closing conflicts.

Change-Id: I758e55c932500189aead22dd858af140a93d3667
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit e8720b80736a53313a01c0381601d3a5ea43a170)

Merge "Bug 2398: AbstractTopologyBuilder() to put() with createParents." into stable/helium

Merge "BUG-2400 : Memory optimizations for AS-Path and Origin attributes" into stable/helium

Merge "BUG-2109 : remove also sessionId when bgp session is closed" into stable/helium

Bug 2398: AbstractTopologyBuilder() to put() with createParents.

Change-Id: I96bd59ce75a09ddcde6460327a131b46b61744d9
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit 99db6cbbad01ec7c97419f822a7c74979ca644bb)

BUG-2400 : Added forgotten MAX_MSG_PER_READ option to BGP.

Change-Id: I690f2043a4c8a4d4ee9c48bf64c8841b1a704b16
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 0138d06f4c7ead1a472f846e4721df97fce15f3c)

BUG-2400 : Memory optimizations for AS-Path and Origin attributes

- AS-Path: minimized empty lists
- Origin: reusing Origin container

Change-Id: I424169873ad1bfae0e3cd928bf285f59c70141ec
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 6954a433170a38623f5e7621f0821d6cfcb6c6be)

BUG-2109 : remove also sessionId when bgp session is closed

Change-Id: I8f086b35ac3f75d9da04de37c0d88e465822077b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 2fcfb689f55acd054033b08d837c7a2c239342b1)

BUG-2383: lower default candidate allocation

Rather than allocating the default of 16 entries, we force the HashMap
to allocate a lower number of entries. While this is not a complete
solution, it lowers the memory overhead significantly.

Change-Id: Ic3afe36381930d567ee7523856b3d3959c013459
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Read-only transactions were not being closed" into stable/helium

Read-only transactions were not being closed

We have failed to close read-only transactions, which can lead to resource
starvation.

Change-Id: I62dbf6b6409a65f279b01c3bb5b2238ffa6febc8
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2109 : clear BGP session after it was already initialized

Change-Id: Ib70a725b948892a2a887a941bdcb4e8dcfdb80eb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix for NPE in OSPF, when forwarding address is not set.

Change-Id: Iff310eee0a5c4c9a34971b6cf5d958d8ed5004e2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2299: allow PCEP extensions to be reconfigured

The trigger here is a change in the extensions cause the corresponding
context to be re-created from scratch, which leads to the topology
manager to being re-created. This patch implements instance reuse by
adding proper activator hooks.

Change-Id: I5f114b81ceeb26a3943afc4bd2f0c34b678ff029
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bumping versions by 0.0.1 after the Helium.1 release

Change-Id: Id057ef606aa695d126a169238590991153c582c2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Applying the Helium.1 release patch

Change-Id: Ic0f26b8414883ae813e57fc8af67e0d8200d8e72
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 2204: pcc-mock now allows zero LSPs per PCC.

Also, 127.0.0.1 is new default remote address,
and condition on number of command line arguments is removed.

Change-Id: I78491a52d60df954b35a2689a5746bcb59eb2ebd
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Merge "Bug-2171: pcc-mock - logging level configuration" into stable/helium

BUG-2201 : fixed Ipv4/Ipv6 AdjRibsIn to use correct class

Change-Id: Ic7b274857ee55aa7b46db0e2e114d271e33225d0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 18abe5459dd86d4d402f9801f69109541a2ee7c3)

Bug-2171: pcc-mock - logging level configuration

+ Default logging level is INFO
+ New optional command line parametter --log-level <LEVEL>
+ Varied level of log statement

-other minor fixes:
+ SymbolicPathName contains ingress IP address too.
     + Fixed issue with ByteBuffer sometimes exceeding String size.

Change-Id: Id1ded1c75d2dfc173d88c8372d7ce7e621a19aab
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2167: Enable pcc-mock to be bindable to differnet source addresses.

Change-Id: I72fdb8af053dc9bd6b6cb2d2c4a97173266b3916
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-2109 : cleaned BGP sessions on session closed.

Added proper close from BGP peer. Negotiation failed method now called from both sub and superclass.

Change-Id: I83e922df826c7fbb9130ca637d2dfe99d3e93a27
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Incrementing versions by 0.0.1 for post-helium stability branch

Change-Id: Ie141e9ee19d1e1729865955a86d549dfdd84ec41
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Changing .gitreview to use the stable/helium

Change-Id: I69eb9fe4af1add1f9545c1977ad2a503cf23d91f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Applying the Helium release patch for BGPCEP

Change-Id: I43ca3345de02810e0280dde69be9e8d0583aff8d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2115 : added zero subcode to BGP CEASE Notify message to avoid NPE

Change-Id: I6102d73e9bd3ff86f2238f1af249cee3094711b2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2082: fix TCPMD5 dependency" into stable/helium

BUG-2082: fix TCPMD5 dependency

This installs proper reference to TPCMD5 feature, as provided by
companion patch (*https://git.opendaylight.org/gerrit/#/c/11575/).

Change-Id: I9c475fa2fb5ab58f1e69fdf000866fe345ff4e35
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-1931: do not override junit version" into stable/helium

BUG-1931: do not override junit version

Change-Id: I400f6172d2ff561ef8d1db96dfb2c8fe92e74b8a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Bug 1924: harmonize commons-codec versions in features.xml" into stable/helium

Bug 1921: Remove override of guava version in features/

Change-Id: I424334140f43c5020f37f1c42004c4f312ad12b4
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Bug 1924: harmonize commons-codec versions in features.xml

Change-Id: I033fc658973491317401fd17ed4d684af1f7c2ed
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Merge "Bug-730: Add PCEPDispatcher test."

Merge "Bug-730: Add GracefulCapabilityHandler test."

Merge "Bug-1809: Fix GracefulCapabilityHandler."

Bug-730: Add PCEPDispatcher test.

Change-Id: I182c25e8c958a143014d00d7e80b2d7267550884
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-730: Add GracefulCapabilityHandler test.

Change-Id: I8f6aedf08f2e13d37a2de2738efdf9f87190151b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-730 : added null checks to tests to increase branch coverage

Change-Id: I2dc01d2c3cedc8af32f85cfc482c4466bdc6f597
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-1809: Fix GracefulCapabilityHandler.

Change-Id: I2ce874d2558595db0ec0e09b530b703b8d59c13d
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-730: Add pcep-segment-routing tests.

Change-Id: I1b0337613823baf63b171f1d59949dfa7913aba6
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-730: Added bgp-rib-impl tests

Change-Id: I68363e2308dcac1d152e6b0ba4ee094e890afa48
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "Clean up dependencies."

Merge "Bug-730: Test Vendor-Information object/tlv in message/object"

Bug-730: Test Vendor-Information object/tlv in message/object

Change-Id: I726bf160eaa64799b660aeff907204c1b0f3a356
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-730: Utils' private constructor tests.

Change-Id: I36b11c115fdf9496f23fba03d3108d5ac759085a
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-1771: Private constuctors in utility static classes throws UnsupportedOperationException

Change-Id: I2acfccfeec9179bb109b46ae5c77e986e914fd98
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Clean up dependencies.

Change-Id: Iae745beef2447f0303975fedfb150528adbe02c7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-730: Added pcep-stateful07 parsers tests.

Change-Id: Iaa0ca04383e4e0429904d458997c3c62b5574978
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "BUG-730 : increasing branch coverage"

BUG-730 : increasing branch coverage

Change-Id: I3ea5792ba36e73cefe38ae41ebcad21fe1f36fa1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-730: Added pcep-tunnel-provider tests

Change-Id: I8fd1fda206609979aa620f5245dcc5d493f10a8a
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-1741: Fix read/write operations

Change-Id: I77c6ddef5ce38a8284eaa8f39a04cac9eda90a10
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-1717 Rename duplicate node(bgp-id) from config yang for bgp-rib-impl

Change-Id: I0443cb684fccaf76dcf56bd9abd67e6f52e54c29
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Remove duplicate dependency declarations"

Merge "BUG-1736: remove wrong artifact reference"

Remove duplicate dependency declarations

Change-Id: I1e566dd794e3cfbd6e59adb4e4306330f3c5b356
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-1736: remove wrong artifact reference

Remove old -config artifacts and all references to them. Also make sure
we unmask the final field so that our mucking with it actually works.

Change-Id: I50d3ab589c855e71273ce23cb29022ba678b8b7f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug-1737 - Advertize Segment-routing PATH-SETUP-TYPE in SRP

Change-Id: I7c952d9a03dc1febbac3b8ff499794c1ed2cdc56
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-730 : added tests for rib-impl

Change-Id: I65fe04fe824ee5bb595e6b8e13bc73f408b30fac
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>