Robert Varga [Thu, 7 May 2015 17:19:11 +0000 (19:19 +0200)]
Lower fast-path locking in RpcContext
Instead of acquiring the lock three times, perform common operations
under the lock and then follow-up without it.
- fixed typo
Change-Id: Ie5b3f5cdd388c54f170e2a742855a6e654094994
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Robert Varga [Thu, 7 May 2015 16:24:24 +0000 (18:24 +0200)]
Cleanup BaseCallback
The fields should be private and final, so clean them up, making the
lifecycle much easier to understand.
Change-Id: I54b029ded933f2f56da6559b0991e2fdd7d5a91d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 7 May 2015 16:11:37 +0000 (18:11 +0200)]
Fix null check
Preconditions.checkNotNull() was not used correctly. Fix that up.
Change-Id: I31582fd72365e4ad7c457f4e7cba4286bf133782
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 7 May 2015 15:54:53 +0000 (17:54 +0200)]
Lower the size of deviceContext synchronized block
The synchronized block is needlessly large, slowing things down with
unrelated transitions happening.
Change-Id: I700ba58f567c592a611fd50f94cf27594385f865
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Bobak [Thu, 7 May 2015 14:07:55 +0000 (16:07 +0200)]
Fixed Scariest level bugs from findbugs.
Change-Id: I22b51dd31887c9c61a049b7c06835f082fd7fd4f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 7 May 2015 07:22:45 +0000 (09:22 +0200)]
optimized usage of registry
Change-Id: I9f7a551e172cb932af0f7b13d4c47f0a30db59d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 7 May 2015 07:18:36 +0000 (09:18 +0200)]
optimized removal request context from registry
Change-Id: I0f73d5abe4dd15e525725a6f4ceec3f57f387b26
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 7 May 2015 07:14:48 +0000 (09:14 +0200)]
TranslatorLibrary holds translators in synchronized structure
Change-Id: I2fbbba39bbfa67937af7306ea63ce85005aa1f9c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 7 May 2015 07:14:17 +0000 (09:14 +0200)]
hash usage optimized
Change-Id: Ie84d00786e0e2f74a45c20dfdec52f7f1c11e3ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 7 May 2015 07:08:15 +0000 (09:08 +0200)]
all device registries holds its data in synchronized lists
Change-Id: I4e47ea5d7ec0f46595d97771d3a0b40ace5ae88c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Tony Tkacik [Wed, 6 May 2015 14:01:49 +0000 (16:01 +0200)]
Added threadpool to droptest.
Droptest was stealing MD-SAL threads to do its work,
which actually make it dependable on MD-SAL thread count.
Droptest nows own own threadpool - so it should not be affected
by number of threads in MD-SAL.
Change-Id: I6ecf05e6b6f02b5790044888cf03642d7587d413
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
michal rehak [Wed, 6 May 2015 13:32:14 +0000 (13:32 +0000)]
Merge "code cleanup"
Martin Bobak [Wed, 6 May 2015 10:24:53 +0000 (12:24 +0200)]
code cleanup
- removed unused imports and commented lines
Change-Id: I4b47b032536a45bf93289e6f7a008dc43dd2027f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 6 May 2015 11:45:03 +0000 (13:45 +0200)]
fixed logging output
Change-Id: I6e54da6e6b5be0b187fba0539e7a2c777c82af37
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Wed, 6 May 2015 09:15:18 +0000 (09:15 +0000)]
Merge "BUG-3129 NPE in flowHash"
Martin Bobak [Wed, 6 May 2015 08:19:08 +0000 (10:19 +0200)]
BUG-3129 NPE in flowHash
- tableId and priority are mandatory
- flowCookie will fallback to default (0) value
Change-Id: I9bf082178847544f1672b294b5461ea192e6b16f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Wed, 6 May 2015 08:37:23 +0000 (08:37 +0000)]
Merge "bug 3126 - shift to new notification service"
Martin Bobak [Tue, 5 May 2015 16:11:35 +0000 (18:11 +0200)]
sanitized transaction operations
- put and delete are wrapped inside of try-catch
this way data still will be lost but next operation
can be scheduled
- added some more logging
Change-Id: I91b161603db994ef9a2b4879ddae78d8f8bee919
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Tue, 5 May 2015 17:40:53 +0000 (17:40 +0000)]
Merge "added transaction commit time expenses"
Martin Bobak [Tue, 5 May 2015 16:10:13 +0000 (18:10 +0200)]
added transaction commit time expenses
- hooking callback on checked future reterned by tx.submit()
Change-Id: I09f8bad1284b0fa58464460a8a64d5e445ed3543
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
michal rehak [Tue, 5 May 2015 17:08:21 +0000 (17:08 +0000)]
Merge "scheduled transaction submit skipped when tx empty"
michal rehak [Tue, 5 May 2015 17:01:08 +0000 (17:01 +0000)]
Merge "bug 3118 - statistics polling should react on datastore operation time"
Martin Bobak [Tue, 5 May 2015 12:13:55 +0000 (14:13 +0200)]
scheduled transaction submit skipped when tx empty
- separated counter and tx-submit-switch
- improved scheduling of submit
- skipped useless submits
Change-Id: I49fd60e38e3351d3f2d9cb2a28e84db7c8a13a9d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Mon, 4 May 2015 15:43:04 +0000 (17:43 +0200)]
bug 3126 - shift to new notification service
Change-Id: Id25983e139b521075a21d579fe12afd9db2b9363
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 5 May 2015 14:00:25 +0000 (16:00 +0200)]
bug 3118 - statistics polling should react on datastore operation time
- also cleaned up unused dependencies in StatisticsContextImpl
Change-Id: I55c0ab6f5cd74bd0e5e64229b876d03ee63378d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 5 May 2015 15:53:22 +0000 (17:53 +0200)]
fixed flow hash equals
- getters delivered default zero/null values
- updated unit tests
Change-Id: I5806678ce0d047fd25356d9278cdd7f8f1d0351c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Tue, 5 May 2015 15:54:07 +0000 (15:54 +0000)]
Merge "Write to operational DS response of update-table rpc."
michal rehak [Tue, 5 May 2015 14:29:54 +0000 (14:29 +0000)]
Merge "removed unused method"
Jozef Gloncak [Tue, 5 May 2015 05:33:32 +0000 (07:33 +0200)]
Write to operational DS response of update-table rpc.
Write table features which were received as RPC response to
operational datastore (replace all corresponding data in datastore)
Change-Id: I615a26775019f4c79f292e0a95f3c1ac0ca9f116
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 5 May 2015 11:33:19 +0000 (13:33 +0200)]
BUG 3119 - Empty flow statistics for OFv10.
During building body of multipart request for flow statistics wildcards were missing.
Change-Id: Ib2e3658a342b991f0c5550780bbea72cccc8d7d1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Martin Bobak [Tue, 5 May 2015 11:10:58 +0000 (13:10 +0200)]
removed unused method
Change-Id: Iadfdb55f25e0760add08438a2e30b21569c48458
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Tue, 5 May 2015 08:25:58 +0000 (08:25 +0000)]
Merge "BUG 3114 - Fixed NPE in table features reconciliation."
Jozef Gloncak [Mon, 4 May 2015 17:48:29 +0000 (19:48 +0200)]
BUG 3114 - Fixed NPE in table features reconciliation.
Change-Id: I6bf31f4ab08f9ccde0a1266f833626bce77444f4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Martin Bobak [Mon, 4 May 2015 14:39:00 +0000 (16:39 +0200)]
fix removed tables for OF-1.0
- empty tables must be written after device description message
is processed (and written into flowCapableNode - above tables)
Change-Id: Ia052caa103f51e578406cfc8f8128c5a26b99f12
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Mon, 4 May 2015 08:44:31 +0000 (08:44 +0000)]
Merge "process flows statistics in one commit tx only when device is synchronized"
michal rehak [Mon, 4 May 2015 08:35:24 +0000 (08:35 +0000)]
Merge "Adding test for updating table-features."
michal rehak [Mon, 4 May 2015 08:30:51 +0000 (08:30 +0000)]
Merge "Speedup local karaf distro."
Martin Bobak [Mon, 4 May 2015 08:08:58 +0000 (10:08 +0200)]
process flows statistics in one commit tx only when device is synchronized
Change-Id: I1d3490686445836299e3058a3102889e5c67549c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Jozef Gloncak [Mon, 4 May 2015 06:45:52 +0000 (08:45 +0200)]
Adding test for updating table-features.
Added test for testing writting table-features to operational datastore
via FRM.
Reverting test for FlowListenerTest (currently TableForwarder isn't listening
on changes on node Table (also flow changes were caught) but on TableFeatures.
Therefore original test which tested direct equality on transaction DOM-xxx ID
can by again applied.
Change-Id: Iabf27ab01d0f11095af65e45374dba581c1656f7
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Mon, 4 May 2015 07:34:02 +0000 (09:34 +0200)]
Speedup local karaf distro.
- by removing odl-restconf boot feature
Change-Id: I716469f96208d84a5f6dbf7ed9dff668725d0e91
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Thu, 30 Apr 2015 06:00:28 +0000 (08:00 +0200)]
sal-table:update-table rpc (service) implementation
According to yang this rpc should return only xid. In SalTableServiceImpl
is obtained data as OFPT_MULTIPART_REPLY type OFPMP_TABLE_FEATURES
which can be used to return more meaningful output (instead just xid)
Change-Id: I8a448fadab2884f8e2bd8518c69e50dc83102573
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Thu, 30 Apr 2015 13:44:10 +0000 (13:44 +0000)]
Merge "lower log severity to warn where appropriate"
michal rehak [Thu, 30 Apr 2015 13:43:49 +0000 (13:43 +0000)]
Merge "avoid flow number oscilation by deleting and writing flow stats in single commit tx"
Martin Bobak [Thu, 30 Apr 2015 10:10:23 +0000 (12:10 +0200)]
avoid flow number oscilation by deleting and writing flow stats in single commit tx
Change-Id: I863e6b2e86a43cb5bfcde23dc99a44288a670b19
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 30 Apr 2015 12:33:22 +0000 (14:33 +0200)]
lower log severity to warn where appropriate
- decreade log contamination
Change-Id: I311ebdba69ab44af20bb8dd1261d4a0db94af7d2
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Thu, 30 Apr 2015 12:37:54 +0000 (12:37 +0000)]
Merge "Improving logging in DeviceContext and MultiMsgCollector."
Jozef Gloncak [Wed, 29 Apr 2015 12:12:42 +0000 (14:12 +0200)]
Improving logging in DeviceContext and MultiMsgCollector.
Change-Id: I82a72d384e651798d29e8997a8dfd90449d819a0
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Thu, 30 Apr 2015 10:55:38 +0000 (12:55 +0200)]
Replace Table with TableFeatures in FRM.
Changes in flows caused also calling TableForwader (and SalTableService)
because listener was registered on Table which contains Flow.
This change changed listener directly to TableFeatures node.
Change-Id: I8ab25d0cb7f671599622870b40d5182583d937f2
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jamo Luhrsen [Wed, 29 Apr 2015 21:21:05 +0000 (14:21 -0700)]
moving message to LOG instead of print to karaf console
Change-Id: I5b275ee2a3090649cc6826cafa77cd116ad538f6
Signed-off-by: Jamo Luhrsen <james.luhrsen@hp.com>
Martin Bobak [Wed, 29 Apr 2015 19:42:20 +0000 (21:42 +0200)]
added success logging to retry looper
Change-Id: I1cbc25b279da8484aaa0f04d7e4283c5443f221f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 19:44:00 +0000 (21:44 +0200)]
StatiststicsContext is removed from registry when corresponding device context is closed
Change-Id: I792beebe71919f11d3e2140197d7ab2439cfad0f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 18:41:18 +0000 (20:41 +0200)]
FlowHash computation enhanced
Change-Id: I6bd100e80579f022c53fbfe1e0906cd3d1333a75
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 16:12:09 +0000 (18:12 +0200)]
DeviceContext is not closed by statistics manager when connection status is HANDSHAKING||TIMEOUTING
- device context is added to list of candidates for gathering statistics and removed next time
when connection is closed and statistics gathering is not successful
Change-Id: I48571e4e9d630352f13fde66e086fbe293bfd133
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 15:55:21 +0000 (17:55 +0200)]
chatty log switched to trace level
Change-Id: Iac1a995451d115cf719c952622b365a64d66876f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 15:55:01 +0000 (17:55 +0200)]
Added device connection status information to throwable
Change-Id: I9af26e095e6f8a8550bd52bc44349591fd9774aa
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 15:54:17 +0000 (17:54 +0200)]
StatisticsManager closes device context when connection not in STATE working
Change-Id: I61c0fbb7c05dc3e723867e67710e88348f3bf567
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 12:32:01 +0000 (14:32 +0200)]
fix npe in BarrierTaskBuider
Change-Id: I2b11ccb47619c29d81bcacc04c616df493b5ad99
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Wed, 29 Apr 2015 19:32:41 +0000 (19:32 +0000)]
Merge "BarrierTaskBuilder cleanup - moved method to right place"
michal rehak [Wed, 29 Apr 2015 19:32:01 +0000 (19:32 +0000)]
Merge "changed approach to device context synchronization"
michal rehak [Wed, 29 Apr 2015 19:27:47 +0000 (19:27 +0000)]
Merge "RpcContext doesn't hold referrence to DeviceContext anymore"
michal rehak [Wed, 29 Apr 2015 19:25:44 +0000 (19:25 +0000)]
Merge "RpcContext doesn't need to provide DeviceContext"
Timotej Kubas [Wed, 29 Apr 2015 08:32:31 +0000 (10:32 +0200)]
fixing of10 issue in MatchUtil
Change-Id: I406cefad80f19be511b343c3e82c48d907a19aea
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 11:46:14 +0000 (13:46 +0200)]
BarrierTaskBuilder cleanup - moved method to right place
Change-Id: If52d29af2b89b88000476d02645e501f911ef523
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 11:25:23 +0000 (13:25 +0200)]
changed approach to device context synchronization
Change-Id: I3708d526e12a9646690db3bfa9e7d69dc52ba8f5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 11:19:51 +0000 (13:19 +0200)]
RpcContext doesn't hold referrence to DeviceContext anymore
Change-Id: Ia8a576221dde95d149f0ea8c10024f3153284bde
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 29 Apr 2015 10:55:41 +0000 (12:55 +0200)]
RpcContext doesn't need to provide DeviceContext
Change-Id: I618e8c2485f33b70fc43a5afcb0abe0905f251c1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Wed, 29 Apr 2015 12:03:00 +0000 (12:03 +0000)]
Merge "Support for Table Features"
Jozef Gloncak [Tue, 28 Apr 2015 12:41:06 +0000 (14:41 +0200)]
Support for Table Features
FlowListenerTest.java - removed equals which checks concrete transaction ID.
If changes are done on flow also TableForwarder is notified because listener is
listening on subtree changes. Therefore can happend that sometimes changes in
table are processed before changes in flow and therefore is generated transaction
ID DOM-2 instead DOM-1.
Change-Id: I3570c03fda0b532833c85bae01ed4a10cc14a2d2
Signed-off-by: HemaTG <hema.gopalkrishnan@ericsson.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Wed, 29 Apr 2015 10:38:10 +0000 (10:38 +0000)]
Merge "Barrier implementation."
Timotej Kubas [Mon, 27 Apr 2015 10:50:39 +0000 (12:50 +0200)]
Fixed aggregated statistics
- fixed service for requesting/receiving aggregated statistics
from device
Change-Id: I1a1d0537e3405b2cd1303b2581f5ca83b318544b
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Jozef Gloncak [Fri, 24 Apr 2015 08:08:36 +0000 (10:08 +0200)]
Barrier implementation.
Implementation of service FlowCapableTransactionService. Concretely sendBarrier method.
Change-Id: I75a4a5f82d0943bcbaf7f888e035715d67fafcd9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Wed, 29 Apr 2015 04:07:54 +0000 (04:07 +0000)]
Merge "TxChaingManager logging changed to warning"
michal rehak [Wed, 29 Apr 2015 04:06:03 +0000 (04:06 +0000)]
Merge "removed unwanted requests map initialization"
michal rehak [Wed, 29 Apr 2015 04:05:13 +0000 (04:05 +0000)]
Merge "added initial waiting for mdsal in topologyManager"
michal rehak [Wed, 29 Apr 2015 04:04:08 +0000 (04:04 +0000)]
Merge "added initial waiting for mdsal in dropTest"
michal rehak [Tue, 28 Apr 2015 19:14:00 +0000 (19:14 +0000)]
Merge "added initial waiting for mdsal in tableMissEnforcer"
Martin Bobak [Tue, 28 Apr 2015 17:35:36 +0000 (19:35 +0200)]
TxChaingManager logging changed to warning
Change-Id: Ibae2db6b9a4eedf2f323323d9f5e67a46f0a5a5c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 17:22:53 +0000 (19:22 +0200)]
removed unwanted requests map initialization
Change-Id: I77e94a45ece999a33c6ec2ed9c438e5daa784206
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 15:36:08 +0000 (17:36 +0200)]
added initial waiting for mdsal in topologyManager
Change-Id: I6ed1cf39abb520da8d79b14e097133d4e5418911
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 14:32:53 +0000 (16:32 +0200)]
added initial waiting for mdsal in dropTest
Change-Id: I49494116f1b78a0a0179390d52985c70964ba6c3
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 14:32:27 +0000 (16:32 +0200)]
added initial waiting for mdsal in tableMissEnforcer
Change-Id: Ifd315526e6263231ee41c7d36a9601e7a3bb6294
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Tue, 28 Apr 2015 18:43:57 +0000 (18:43 +0000)]
Merge "added initial waiting for mdsal in FRM"
michal rehak [Tue, 28 Apr 2015 18:43:51 +0000 (18:43 +0000)]
Merge "introduction of ofp-common"
Martin Bobak [Tue, 28 Apr 2015 18:02:00 +0000 (20:02 +0200)]
added versions to drop-test config file dependency
Change-Id: I06b1c676ec9dc095a2cd1dcb90b0a4dc12b868a3
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Tue, 28 Apr 2015 16:39:39 +0000 (16:39 +0000)]
Merge "requests map in deviceContext is synchronized now"
michal rehak [Tue, 28 Apr 2015 16:39:16 +0000 (16:39 +0000)]
Merge "fix npe when calculation port number hash"
Martin Bobak [Tue, 28 Apr 2015 14:31:23 +0000 (16:31 +0200)]
added initial waiting for mdsal in FRM
Change-Id: Iafff27b78597540b9fa273666a2a2c18af0233e7
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 14:29:25 +0000 (16:29 +0200)]
introduction of ofp-common
- SimpleTaskRetryLooper added (for waiting till given task/action succeeds)
Change-Id: I92e3ba42ddc8fd3d6965b56cc3f329d14ba109e2
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 16:01:30 +0000 (18:01 +0200)]
requests map in deviceContext is synchronized now
Change-Id: If4514e604bf0ad98a52bd713736c1b5a63b75681
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 15:06:41 +0000 (17:06 +0200)]
fix npe when calculation port number hash
Change-Id: I57f66d57ce447e84da170aa2e8a97febfdd0dd7f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
michal rehak [Tue, 28 Apr 2015 15:59:02 +0000 (15:59 +0000)]
Merge "clean features dependencies in pom"
Martin Bobak [Tue, 28 Apr 2015 14:03:11 +0000 (16:03 +0200)]
Li feature renamed to be less tongue twisting
Change-Id: I100230ec251ce77f0f4bfd5844d917ee13154652
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 13:28:43 +0000 (15:28 +0200)]
XID is hooked inside CommonService
Change-Id: Iab83464ccaf2c59b5f8cd9211bb63dc8d0971c89
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 09:17:45 +0000 (11:17 +0200)]
fixed statistics gathering future handling in StatsManager
Change-Id: I71b618a7dc45998f7f5a524332589181be2eaf99
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 09:09:40 +0000 (11:09 +0200)]
Fix npe when closing connection
Change-Id: I29eb9511678c72a1589620f4f23ca5e165852691
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 09:08:31 +0000 (11:08 +0200)]
StatisticsContext returns information whether some of statistics were gathered
- StatisticsManager doesn't delete node from DS, DeviceCtx does that instead
Change-Id: Ic9ad83521be7a5a73b2216ac3ad615eced1754a8
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Tue, 28 Apr 2015 08:05:47 +0000 (10:05 +0200)]
StatsContext that fails to gather initial statistics is not registerd in manager's registry
Change-Id: Id6597dbfdc4bbf35f50efd02220e9c1f393bbea7
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Mon, 27 Apr 2015 16:29:47 +0000 (18:29 +0200)]
fix npe when calculating mask hash
Change-Id: I6a1e1234f78938246fb438639c54afd8ffa7b708
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Mon, 27 Apr 2015 15:59:02 +0000 (17:59 +0200)]
fix npe when calculating metadata hash
Change-Id: I5702948147a40fc3fba09c8a83e7d6a0a8daedad
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Mon, 27 Apr 2015 15:08:19 +0000 (17:08 +0200)]
calclulate IP addresses hash only from masked part of address
Change-Id: I9fabfc6bffe2341576eed2582de40f118baee255
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Code Review / openflowplugin.git / log