Claudio D. Gasparini [Thu, 15 Mar 2018 07:01:28 +0000 (08:01 +0100)]
Improve sync under EffectiveRibInWriter
Change-Id: I63e46860de46ea0a008400dfb64b1e8e97ea7e73
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Mar 2018 08:06:48 +0000 (09:06 +0100)]
BGPCEP-589: BGP Neighbor match
match Peer-Id generated from neighbor address,
it can be used as replacement for generate similar
policy than removed simple-routing-policy.
Change-Id: I347a77cb40c72ff110b5088682f8edd375cecca1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Mar 2018 10:47:28 +0000 (11:47 +0100)]
Fix BestPathState NPE
Check As Path segments are not null when
selecting best path.
Change-Id: Id4d76b9f83d957b505300aabde248978151f5b73
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 13 Mar 2018 06:25:45 +0000 (07:25 +0100)]
Fix RIB SPI checkstyle complains
Change-Id: Ia1862f8db58413ca284f4d76f1d24c0a2d818ac9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 9 Mar 2018 19:47:37 +0000 (20:47 +0100)]
BGPCEP-574: Apply Export Config policy
Change-Id: Ia117f0676edb02b2d92aba46aa99d2ba5fa52ce5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 12 Mar 2018 09:01:08 +0000 (10:01 +0100)]
BGPCEP-574: Remove old Export Policy
Change-Id: I99c774cfb9c40469f2880307b2b9e2427f9b9dfa
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Thu, 8 Mar 2018 14:30:55 +0000 (15:30 +0100)]
Bump yangtools to 2.0.2
This patch bumps yangtools 2.0.2.
Change-Id: I21576a27323dff34e77db70f290e3a4e5b6beeb6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Sun, 11 Mar 2018 20:35:48 +0000 (21:35 +0100)]
Use long instead of PathId wrapper
until the moment a PathId is required.
Change-Id: Idc2ce010fe4f2081f0d8131f2af226dfe88aec72
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 12 Mar 2018 09:21:55 +0000 (10:21 +0100)]
Fix Test values comparison
use { instead of [
Change-Id: I2750e4d00a389f6ca1051851749cb6f21f9f5538
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 11 Mar 2018 19:07:04 +0000 (20:07 +0100)]
Clean up
Remove unused ribsupport method
Change-Id: I7d0867e51faf6f420c14e5df65ac8b4b43c794e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 11 Mar 2018 12:28:18 +0000 (13:28 +0100)]
BGPCEP-574: Remove unnesary methods
- remove extract key
- remove extract changed routes
Change-Id: I6bc6e83be77edcc8312dde8509ebd18051d888ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 9 Mar 2018 13:39:36 +0000 (14:39 +0100)]
Rename Base Route Entry classes
to keep consistency with
Add Path Route Entry classes.
Change-Id: I742540b51cfae5ee6935cf5340ff617858e9c31a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 9 Mar 2018 13:02:16 +0000 (14:02 +0100)]
BGPCEP-754: Fix NPE and rework
- Fix npe
- Simplify PeerTracker
- Fix test name
Change-Id: I239d634a98799c73220e55cbb9b295b84576f7ec
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 9 Mar 2018 10:33:24 +0000 (11:33 +0100)]
BGPCEP-574: Install RIB policy config file
by default.
Make config file loader depency between them
in order to avoid race condition when loading
configurations.
Change-Id: I35ab0886c64502c3ec9961d83dbae330667c0ea3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 8 Mar 2018 11:54:00 +0000 (12:54 +0100)]
BGPCEP-754: Rework EffectiveRibInWriter
use ClusteredDataTreeChangeListener instead
of ClusteredDOMDataTreeChangeListener
Change-Id: I773ada0d2b593afad1c63dc8ed54c88e48fee500
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 7 Mar 2018 12:05:10 +0000 (13:05 +0100)]
BGPCEP-574: Fix features
by importing features intead of use the
blundles.
Change-Id: I645778f3e4e2338c74040f819ff1c56d3cdd822e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 3 Mar 2018 07:30:32 +0000 (08:30 +0100)]
BGPCEP-574: Rework rib config policies
by making possible to pass only wanted
attribute for condition match.
Change-Id: I876fafaba79ed2e4598a1de2db280ff280442d4a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 1 Mar 2018 10:26:09 +0000 (11:26 +0100)]
BGPCEP-763: Fix Pcep Deadlocked thread
improve synchronization
Change-Id: I9d0b97aefe58e742d10313d7ab18f69f3e8be69c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 1 Mar 2018 11:01:21 +0000 (12:01 +0100)]
BGPCEP-574: Remove old ImportPolicyPeerTracker
Change-Id: Ife1849081727a6ab06038f3f5dbab010797347a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 26 Feb 2018 11:01:55 +0000 (12:01 +0100)]
BGPCEP-754: Start using default import policy
configuration with configurable rib policies.
Change-Id: I6aeb4c4261aafb7faf1ff0a08edfefb443590830
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 14 Feb 2018 15:43:30 +0000 (16:43 +0100)]
BGPCEP-754: Remove simple-routing-policy
Can be replace by configuring a rib policy
Change-Id: I12ef5f2571b01020e23ee073c8745ca9fe972a1a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 18 Jan 2018 09:53:15 +0000 (10:53 +0100)]
BGPCEP-754: PeerTracker Impl
- recollected information for advertize
path, as supported families, peerID, etc..
will be provided by peers themselves.
Change-Id: I759bb14fa513ba5927f52ac4160cc2ffb4641d5d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 17 Jan 2018 16:05:58 +0000 (17:05 +0100)]
BGPCEP-754: Introduce BGPPeerTracker interfaces
as replacement for static Export group.
Each Peer will provide information required
per rib policies for update tables.
BGPPeerTracker will just keep track of
all registered peers.
Change-Id: I08c94afab183a49c7277e30792d8344b87064d8a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 Jan 2018 16:09:05 +0000 (17:09 +0100)]
BGPCEP-589: Openconfig Basic Routing Policy Statement
- match prefix set
- match originator set
- match cluster-id set
- match peer-role set
- community
- ext-community
- as-path set
- med eq
- next-hop-in
- as-path length
- local-pref-eq
Basic actions
- accept
- reject
- as-path prepend
- set community
- set excommunity
- set originator-id
- originator-id prepend
- cluster-id prepend
- set local-pref
- set next-hop
- set med
- transitive attributes filtering
Change-Id: I5052ad5a0e5319dfd143a79b2bf812cad8676236
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 28 Feb 2018 14:23:03 +0000 (15:23 +0100)]
BGPCEP-589: use odl communities / ext-communities
on openconfig-bgp-policy.
Odl supports more comm/ext-comm that the ones
defined by oepnconfig. Also this improve efficency
for match comparisons.
Change-Id: I6989c64cdd8bf102f3d44ac5b545a97990578459
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 Jan 2018 15:53:27 +0000 (16:53 +0100)]
BGPCEP-754: Openconfig Routing Policy Service
- Routing Policy Registry, listening DS and
keeping track of all defined policies
- RIB Policy Factory, provide a factory
for create rib policies per specific RIB.
Change-Id: Id5521811a23b65ad1ae5e4e20eb41a61d78beb95
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 12:06:36 +0000 (13:06 +0100)]
BGPCEP-574: Openconfig Routing Policy SPI
- Actions API
- Conditions API
- Statement handlers registry
- Feature
Change-Id: Ie1784f18c5d27fb8750e1d0ae2417b6561434bcc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 10:47:56 +0000 (11:47 +0100)]
BGPCEP-574: Introduce RIB Policy interfaces
for Configurable RIB policies.
Change-Id: I20930255ede101204b2d7402831953539e6a4398
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 Jan 2018 13:02:51 +0000 (14:02 +0100)]
BGPCEP-589: Define default routing policies
create basic routing policies required
for default bgp default rib policy.
Change-Id: Ia9cdbdfa9f9ef6231a7bb774d6d66701dc777d26
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Wed, 28 Feb 2018 00:11:11 +0000 (01:11 +0100)]
Fix model compliance
Declared prefix should be unique within a module, as that is
the prefix that is used to refer to a module within itself.
Change-Id: I699c529831fd62854a50e46c105a3d7922d670f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 21:23:24 +0000 (22:23 +0100)]
BUG-6966: Openconfig policy config file loader.
Loads from xml Openconfig rib policies and
sets.
Change-Id: I59153172cf5ab917420e3b1e182b84d5e0ef0abe
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 1 Feb 2018 22:57:44 +0000 (23:57 +0100)]
Remove deprecated methods
Change-Id: I7abb75ae3b151e3ff3171b78fee47cb6853c2478
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 17 Jan 2018 08:05:51 +0000 (09:05 +0100)]
Reduce number of parameters for RIBImpl
Change-Id: Ib9a9fff4e1d21673fec9251b32663106614fb8c1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 21:35:25 +0000 (22:35 +0100)]
Reduce number of parameters for path selection
-enforce findbug.
Change-Id: Idc9cb566e31b81c7d87cf544016525122487393b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 26 Feb 2018 15:58:31 +0000 (16:58 +0100)]
Add missing copyrights
Change-Id: I992492a29d54cd0d70e0a1289fb891754775584b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Anil Belur [Mon, 26 Feb 2018 07:41:40 +0000 (17:41 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Ia32d405970372481dd25d9764f92c409a5e98c3e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Claudio D. Gasparini [Fri, 23 Feb 2018 21:12:09 +0000 (22:12 +0100)]
BGPCEP-760: Fix Dead lock
when connecting multiple peers at
the same time multiple routes are announced.
Fix by improve sync under Peer export groups.
Change-Id: I588db1bfc3cfca80308837084ac5088b8fc89cea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 23 Feb 2018 14:40:33 +0000 (15:40 +0100)]
Fix NPE
when calling containsEqualConfiguration on Peer
Change-Id: Idc674a8be808386c0a3050dca3a3895cf0491caf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Feb 2018 09:59:07 +0000 (10:59 +0100)]
Remove no longer required service-properties
for restart OSGI CSS service
Change-Id: I65c4810ca5da9bd357dbdabb3ed413649ba8fbb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 14 Feb 2018 11:06:38 +0000 (12:06 +0100)]
BGPCEP-758: Use random ip for Pcc mock tests
-perform some clean up
Change-Id: I79ef9f8e5f01b1d461c5848d7966f9e3521f926d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 14 Feb 2018 10:16:19 +0000 (11:16 +0100)]
BGPCEP-757: Handle WRITE as SUBTREE_MODIFIED
on case of Topology rewrite, following
the same procedure as if it was an update.
Change-Id: Ida6bf596137054bb6a5d02d4345daee8cf5f3394
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 12 Feb 2018 13:24:46 +0000 (14:24 +0100)]
Remove unnecesary sync
Change-Id: I6cf0f20346719e311164bf96c3b87387878200d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 Jan 2018 17:31:15 +0000 (18:31 +0100)]
Remove default pcep tunnel topology
until is documented.
Change-Id: Iaa046626cdad1271db7a89a7d455bbe04ea88364
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 30 Jan 2018 18:54:39 +0000 (19:54 +0100)]
BGPCEP-745: Improve synchronization
when unbinding PCEPState
Change-Id: I7558610208f12e09f69d859bb0b613a044f8b1ce
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 30 Jan 2018 19:16:06 +0000 (20:16 +0100)]
Fix Tunnel Topology configuration
by catch correctly the id of the pcep
topology from topology-ref.
- Improve logs
- Add tunnel topology to example config
Change-Id: If55ea04c6361241b4199bfca02a4c534e67805b6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 25 Jan 2018 21:55:10 +0000 (22:55 +0100)]
Remove config-parent
Change-Id: I0e75ed7e809b5904e3ec11fa3f1937b371d0c2d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 25 Jan 2018 10:31:32 +0000 (11:31 +0100)]
BGPCEP-739: Fix "raced with transaction PingPongTransaction"
under TopologyNodeState. Raced call to putTopologyNode
will cause an override node and therefore PathComputationClient
was being removed and ending on exception when trying to update
it after such change.
Change-Id: I1d5b44c383d7159669bec7475afff3713f1370a0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 24 Jan 2018 11:25:59 +0000 (12:25 +0100)]
Rework poms
- Remove bundle-parent.
- Remove dependency-version-management
- Use instead bgpcep-parent
- Clean up bgpcep parent
Change-Id: Icc0e40017204916c8fa2c33546195f56e0249591
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 23 Jan 2018 16:39:05 +0000 (17:39 +0100)]
Simplify config loader tests
Change-Id: I8c04f7f27aafb9a4760bb5d043db2f08bdee91d9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 23 Jan 2018 09:01:22 +0000 (10:01 +0100)]
BGPCEP-748: Fix AFI/SAFI
peer support registration when old-school BGP-4
is used.
Change-Id: I2137ea2647f01fb87bad04e682fe0bf5541768e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 15 Jan 2018 15:36:35 +0000 (16:36 +0100)]
Replace deprecated CheckNotNull
Change-Id: I21ec7c40264533e027320f7b5b31ee895003537e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 22 Jan 2018 13:08:34 +0000 (14:08 +0100)]
Document path-id reserved value
Change-Id: I663ffac423e8a48c8528782165abc1406d70bb44
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 20 Jan 2018 12:08:18 +0000 (13:08 +0100)]
BGPCEP-672: Fix key storage un adj-rib-out
list key must not be null, therefore
path-id should always be included.
Reserving PATH-ID 0 for non-supporting
add-path.
Change-Id: I9b0af92e91e7c0b1c7281230a804c7adeff2dbca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Kevin Wang [Mon, 11 Dec 2017 21:58:17 +0000 (13:58 -0800)]
BGPCEP-724 Make BGP Session recoverable
This patch make BGP Session recoverable when anything wrong
happens during netty session negotiation. When an exception
is captured, the BGP session will be terminated.
Change-Id: Id3fc7ec282a2151e3bd6bdbfa8930e141b3ceaff
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Fri, 12 Jan 2018 15:57:33 +0000 (16:57 +0100)]
Remove private constructor tests
Change-Id: I33cc6ffcf940db226826e350e59c8af5eb1e1d71
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 12 Jan 2018 11:26:26 +0000 (12:26 +0100)]
Remove no longer required method
Change-Id: Ic987e86f09cff5df35f81c13a7385866727f30ed
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 18 Jan 2018 10:49:15 +0000 (11:49 +0100)]
Reduce number of parameters for pcep
-improve logs
Change-Id: Ibdf63a2b7d7894600a466a07086d7b9d4d9b5cc4
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 21 Jan 2018 17:21:11 +0000 (18:21 +0100)]
Add feature-repo-parent pom
reducing duplicated dependencies
by inheritance.
Change-Id: I8683f302ec4bd7aa08ed38bbc8a149e17de24a5d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 21 Jan 2018 16:14:45 +0000 (17:14 +0100)]
Add single feature parent
reducing duplicated dependencies
by inheritance
Change-Id: Ia143e2f70f1aa76cb611f58b7673bb96a722bdd1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 21 Jan 2018 11:31:44 +0000 (12:31 +0100)]
Fix poms
- use dependency version management
- fix checkstyle complains
- add checkstyles to parents
Change-Id: Ide387d38f5d4e6c865f12070c5f8e3bbea5f9aef
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Thu, 18 Jan 2018 22:47:50 +0000 (23:47 +0100)]
Eliminate unneeded declarations
yangtools.version is not really useful, as are the plugin
declarations, which we are inheriting from elsewhere.
Change-Id: I78ca9db9bb0341237fca05d251a801efab95266b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 18 Jan 2018 22:59:38 +0000 (23:59 +0100)]
Cleanup feature dependencies
Use smaller upstream features to the extent we need them.
Change-Id: I9bf9dac7fe926c5c69a544ac7620d8a18085e5e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 15 Jan 2018 12:24:01 +0000 (13:24 +0100)]
Fix config-loader-spi pulling in bundles
Depend on odl-mdsal-broker instead of pulling in controller bundles
into this feature.
Change-Id: I86c7e150a0e972f2f802c8bc5e8bea892b0d5bad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Thu, 18 Jan 2018 07:07:26 +0000 (08:07 +0100)]
Bump to yang 2.0.1
Change-Id: I6551c9e338f7e178997edaf1fdc680598f587c6c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 15 Jan 2018 12:09:40 +0000 (13:09 +0100)]
Disable offline link detection in bmp-impl
This seems to suffer from a similar affliction.
Change-Id: I236f7bdfd00dc361d8d7e5177c4d9eac8954d2a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 15 Jan 2018 10:39:01 +0000 (11:39 +0100)]
Disable offline links in bgp-rib-impl
This is a workaround for broken merge job -- disable link
detection until we figure out what is wrong with jenkins.
Change-Id: I985702541b46fd015cde55a9e35390ffc978cf8a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 23 Nov 2017 12:51:31 +0000 (13:51 +0100)]
Bump to odlparent-3.0.2 and yangtools-2.0.0
This is a combined upgrade of dependencies, adopting them in one
go. Since yangtools has switched to using java.util.Optional,
mirror that decision in interfacing expected do directly interact
with NormalizedNodes.
Change-Id: I87977f2757777c3cefe2a59acb0ec1f2d3beed21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Fri, 12 Jan 2018 15:29:08 +0000 (16:29 +0100)]
Fix yangtools feature reference
The feature was renamed to odl-yangtools-data, fix the reference.
Change-Id: I1f26a9206ff151bc90d8bb298bff8a83af755a1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Fri, 12 Jan 2018 14:32:23 +0000 (15:32 +0100)]
Bump to odlparent-3.0.0 and yangtools-2.0.0
This is a combined upgrade of dependencies,
adopting them in one go.
Change-Id: I68206648e60f657a2d16f1160bd379c0a769ee75
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 14:59:46 +0000 (15:59 +0100)]
BGPCEP-742 Fix BGP NPE filter null BGP State
from BGP State collector.
Change-Id: Ic23277b22466140c2e17c429eea7467fd9d33ce8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 08:52:34 +0000 (09:52 +0100)]
BGPCEP-739: Improve logs under programming
- make programming service closeable
- close service when pcep-topology provider
service is closed.
Change-Id: I87ad85b3b4a54c71b1020f12b962277b7595b182
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 9 Jan 2018 12:24:33 +0000 (13:24 +0100)]
Introduce testtool-parent
to enforce findbug and checkstyle
under testtools
Change-Id: I971c273cbfd739e308d3548faf664af7812cc30c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 9 Jan 2018 11:51:34 +0000 (12:51 +0100)]
Fix findbug and checkstyle issues
Change-Id: Ia8fef246d76af79c9557f7cecf7cbd2740249ab9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 22:06:47 +0000 (23:06 +0100)]
Fix findbug issues under pcep modules
Change-Id: Ia1fd4067479bc0bbdc8242ef7cc111394b62c059
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 21:37:20 +0000 (22:37 +0100)]
Fix findbug issues
for rib-spi & rib-impl module
Change-Id: I76e4bebdab4581ec4475647af5ce87bcfc52d616
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 18:35:13 +0000 (19:35 +0100)]
Enforce checkstyle & findbug under bundle-parent
and remove enforcement from modules which
contains it as a parent.
Change-Id: I48846c5765f35411ab28508da8df7fdcf2c8f8a2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 17:17:19 +0000 (18:17 +0100)]
Enforce checksyle findbug and checkstyle
under bgp topology
Change-Id: Id30c083d36fa47b42f45f2eaa1c0ccd91109564f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 16:44:22 +0000 (17:44 +0100)]
Enforce checkstyle and findbug
under PeerAcceptor
Change-Id: Ied636638346c6a3852aa7c453d73b8d13c011278
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 16:13:11 +0000 (17:13 +0100)]
Enforce checkstyle and findbug
under openconfig-state
Change-Id: I01cca3a4b084691449da90f64cfe55d370a99db9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Jan 2018 15:28:05 +0000 (16:28 +0100)]
Fix checkstyle issues under rib-spi
and enforce findbug
Change-Id: I4bf3cc40aa28636a016dbc97c9bda17284557c63
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 28 Dec 2017 23:29:00 +0000 (00:29 +0100)]
Enforce findbug and checkstyle
under programming spi
Change-Id: I5f2b757c48ac2ae107dadd1174fb4779528b3e77
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 28 Dec 2017 13:15:18 +0000 (14:15 +0100)]
Enforce findbug and checkstyle
under openconfig-spi & rib-mock
Change-Id: I09a97928c539f5638d920794704cc9796b534e53
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 26 Dec 2017 20:38:59 +0000 (21:38 +0100)]
Enforce findbug and checkstyle
under modules
- openconfig-api
- parser-api
- ri-api
- testool
- util
Change-Id: I01838e001689835f1d4f4b3dab5c1e3fe311fc72
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 20 Dec 2017 17:30:27 +0000 (18:30 +0100)]
Remove GLOBAL strict bgp registry
Change-Id: Id11ef8a8bcb31949f90734d43fae0a19da81b4b2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 23 Dec 2017 22:23:45 +0000 (23:23 +0100)]
Enforce findbug and checkstyle
under programming impl
Change-Id: I46db1e8dbf0c94ad8640af15b5bbe25e30ff8559
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 23 Dec 2017 22:09:39 +0000 (23:09 +0100)]
Enforce findbug and checkstyle under utils
Change-Id: I3598bd00429565b11f5fa1913efe70634ccd5b36
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sat, 5 Aug 2017 23:54:10 +0000 (01:54 +0200)]
Optimize TerminationReason memory usage and performance
Using a map is forcing us to box on each lookup. Given the cardinality
a simple array lookup is just fine.
Change-Id: Id39151267545e6c35a3c0b9997612879e9b88c65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 22:30:41 +0000 (23:30 +0100)]
Enforce findbug and checkstyle under PCEP
Topology provider
Change-Id: I90c6e45d3a9c8ae559c327de8c0e4fa09cc02a76
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 22:15:11 +0000 (23:15 +0100)]
BGPCEP-738: fix unbind pcep stats
by doing it when session is finished
or topology is closed.
Change-Id: I5f46f1e2bfb7f37a9fad6d3101177c8f127ba67a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 11:39:26 +0000 (12:39 +0100)]
Enforce findbug and checkstyle under BMP Parser
Change-Id: I9f2b96af276dbbe4edd528373473c42a1d459daf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 11:02:41 +0000 (12:02 +0100)]
Enforce findbug and checkstyle under BMP IMPL
Change-Id: I6f6edbb401c95a80768d2c507e6c909d69ae493d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 10:57:03 +0000 (11:57 +0100)]
Enforce findbug and checkstyle under BMP SPI
Change-Id: I6e0de407586040e6de8d86bf45bedb614a769d4d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Dec 2017 10:56:33 +0000 (11:56 +0100)]
Enforce Findbug and checkstyle under BMP API
Change-Id: I7882d0af8603bd5939edc4a8d2850c544b6fef50
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 21 Dec 2017 10:46:36 +0000 (11:46 +0100)]
BGPCEP-737: Implement BMP client reconnection
after succesful connection goes down.
Remove duplicate code.
Change-Id: I8690de7d6a49c6c92e319c840a37a1fe043b9775
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 20 Dec 2017 10:29:16 +0000 (11:29 +0100)]
Enforce findbug and checkstyle for pcep auto bandwith
Change-Id: I69959b94839f6b16836a2123a7f481fccdaafd6b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:57:16 +0000 (17:57 +0100)]
Enforce findbug and checkstyle under l3vpn
Change-Id: I049c4941cc69bddb1f1db2f7713a6127a02a2b0d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:38:47 +0000 (17:38 +0100)]
Enforce findbug & checkstyle for bgp inet
Change-Id: Ie623110fa1d1a5466f2ceb914284b07d24e76f87
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:17:20 +0000 (17:17 +0100)]
Enforce findbug and checkstyle under bgp concepts
Change-Id: I16ef040f415e742f94751f57ebd965c51f3747ce
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:08:03 +0000 (17:08 +0100)]
Enforce findbug and checktyle under bgp cli
Change-Id: I081909c05f31d02fd11042c96d564c499ef1f328
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 18 Dec 2017 16:06:46 +0000 (17:06 +0100)]
Enforce findbug & checkstyle under bgp benchmark
Change-Id: I9f6afa12f79cf17f7927a7fdd11ffaa766278ff8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Code Review / bgpcep.git / log