Remove unused imports

Eclipse-reported unused imports -- remove them.

Change-Id: I0ecfda5cd3730ee685740f300d7268898f5d748c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not override versions

Fix a few maven warnings about overriding managed versions.

Change-Id: Icd980761fb33b35213ffc8b43fd85e25d725ef3f
Signed-off-by: Robert Varga <rovarga@cisco.com>

MessageSpy should not be generic

This reduces the amount of warnings and confusion around when the actual
argument should be.

Change-Id: I614f2ba44f8432e3be3f3fd79c37f5d95f87fd76
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use pre-constructed NODES_IDENTIFIER

We have a constant for the first-order identifier. Make sure it is a
proper constant and use it as a base for all child identifiers.

Change-Id: I53d6ddfc782424aae0e4ac0997afb735c9ca7688
Signed-off-by: Robert Varga <rovarga@cisco.com>

check for manadatory attribute

Change-Id: Ibe1ba13e63b65a8cb4a2799a2c8b902d7feaf8bb
Signed-off-by: Martin Bobak <mbobak@cisco.com>

corrected way of handlig XID

Change-Id: Iad1386ca6a1b47a1849ceabeabd234ba012d1a4f
Signed-off-by: Martin Bobak <mbobak@cisco.com>

corrected message spy counters per service

Change-Id: I62bf785d96f8dd1e4226f4d46278de243e3214e5
Signed-off-by: Martin Bobak <mbobak@cisco.com>

fixed npes in service processing and message spying

Change-Id: I607200b0ac2a9324c44c2460a6c633000f0029f1
Signed-off-by: Martin Bobak <mbobak@cisco.com>

removed worthless callbacks

Change-Id: I8e408f2dbd0d7c7a52eb8731cd3ae79049d03ea0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

FlowCapableTransactionServiceImpl  and SalEchoServiceImpl.java shifted to new OFJ codepath

Change-Id: I3787c1c8ed16a2ebabdc26425ea8f4e823c72cc8
Signed-off-by: Martin Bobak <mbobak@cisco.com>

NodeConfigService shifted to new OFJ codepath

Change-Id: I5b5e6cb1906e1fc9a9a99a446606dc4b106c0399
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Make sure RequestContext has a constant XID

All callers end up talking to the underlying device to acquire an XID.
Since all RequestContextStack implementations already have (potential)
access to a DeviceContext, there is no need to do this.

Thus make sure RequestContext has an XID allocated by the underlying
device, which unifies code and makes callers simpler. If we fail to
allocate one, the caller will see that XID as null.

We also take this opportunity to make Xid take a Long instead of a
primitive type, as that's what we need for DataObjects and that's what
we get from the Device anyway -- thus preventing autoboxing operations.

Change-Id: I7f553a9a1283d1c82ba7e287d0f21cf4147779e2
Signed-off-by: Robert Varga <rovarga@cisco.com>

DataCrate removed and its usage replaced by RequestContext

DataCrate created unnecessary code and in light of newest OFJ changes became obsolete.
All we need to have when handling rpc call is request context.

Change-Id: Iff565c48af6634c9000a2b09057997b81cbb062b
Signed-off-by: Martin Bobak <mbobak@cisco.com>

removed redundat xid reservation

Change-Id: Ic6bfadf9b163b53a6930219df10da7d3865dd213
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Cleanup RequestContextStack

Instead of exposing the limits as a tweakable API, we should specify the
limit at instantiation as an implementation-specific thing.

We document that RequestContextStack.createRequestContext() can return
null and let callers deal with that.

This change allows us to implement RpcContext throttling using a simple
counting Semaphore, which is more scalable and efficient than an
explicit queue. To do that, we turn RequestContextImpl into AbstractRequestContext,
which is subclassed as needed by the various RequestContextStack
implementations.

Change-Id: Ibbeafad6cd7f740284264cca22412e11696cede8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove DeviceContextImpl.XidGenerator

The generator is not used anymore, remove it.

Change-Id: Ia4a50a0b2b02b34f3854a4f09c4b307ccebb24c2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix various small warnings

All of these are reported by eclipse: needlessly raw types, missing
serialversionUUID, methods which can be made static.

Change-Id: I5b71c35ee37167ead77f7baa2e5d6e5c23f99834
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Speed FlowUtil up a bit"

Merge "Explicitly deal with rejected offer operation"

Speed FlowUtil up a bit

Instead of taking a Short, it can take the primitive short, increasing
performance just a tiny bit.

Change-Id: I7a2c4b0f20108c943110b83ba1237a9ad21d57e0
Signed-off-by: Robert Varga <rovarga@cisco.com>

Explicitly deal with rejected offer operation

Performance traces show a whopping 30% of the method's time being spent
in ImmediateFailedFuture.get(). Make sure this does not occur by
checking for the well-known constant first, shaving 4% of global CPU
usage.

Change-Id: Id7fdfbb32a071634e7e5467441beb242181c68bb
Signed-off-by: Robert Varga <rovarga@cisco.com>

removed misplaced internal statistics counters

Change-Id: I8ca8fde20d01982c7564a47dc308d2eaf6193021
Signed-off-by: Martin Bobak <mbobak@cisco.com>

fixe NPE when logging in add flow's future callback

Change-Id: Iaf53511e8b1f09676ddb7284b3c5b239d778c1d4
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "Do not use InstanceIdentifier.builder()"

Make sure we wait for the reserve XID

 Base openflowjava OutboundQueue has non-blocking semantics, so can fail
easily. Convert our handler to be a blocking proxy working on top of it.

- no throttling on packetIn
- fix npe when logging response from queue
- unregister request context in queue callback when request fails
  - positive callbacks are gathered by multipart message collector
    and unregistered when all multiparts are collected by device
    context

- OutboundQueueProvider encapsulation in deviceContext

Change-Id: I52cc145d2b59bf51594c7da08796570b35b8250b
Signed-off-by: Martin Bobak <mbobak@cisco.com>

common service doesn't wrap future into BaseCallback
removed unwanted callbacks in SalFlowService

Change-Id: I83a55752544826aaeeb5d1246e5a622fe1021532
Signed-off-by: Martin Bobak <mbobak@cisco.com>

statistics groups renamed

- fixed statistics counting in device context's notification forwarding
- added new statistics group for spying on unregistering items from rpc stack
- changed way how barrier nanos value is expressed
- spying on rpc stack operations

Change-Id: I82df21076543458f9e34f677007bfe31aa697634
Signed-off-by: Martin Bobak <mbobak@cisco.com>

added new statistics groups for measuring refused notifications and XID requests

- spying for new statistics
- initial OFJ queue length set to 25600
- when first XID reservation on outbound queue fails, we attempt for second one
- PacketProcessingService uses outbound queue for sending requests to OFJ
- StatisticsGatheringService doesn't use uoutbound queue in synchronized block

Change-Id: I9f40be8c65c2ff4d75d81b9b814fa28cc1cae8f2
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceContext provides reserved values for XID

Change-Id: I1db70922f8a4bbbb4d0b44c66888975dc8b949b4
Signed-off-by: Martin Bobak <mbobak@cisco.com>

MultipartMessageCollector is used one per device context

- Multipart messages are collected inside OutboundQueue callback.
- StatisticsGatheringService collects its multipart responses in queue callback

Change-Id: I7e4cf52d2e396f08b94d4d7f08af8b591061dfc3
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Introduced OutboundQueue from OFJ for outbound messages processing

BarrierProcessor and related classes are removed
Device static info gathered trough OutboundQueue
Outbound queue used in CommonService and SalFlowService

Change-Id: Ieeff15184aac44cdfd0a902b2f3ae89bfa149461
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Do not use InstanceIdentifier.builder()

Adding a single node to a InstanceIdentifier is much faster than
instantiating a builder.

Change-Id: I9a41aa2c46b9a7977bdc579577852b23e6804a0e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

added missing empty method

Change-Id: I64bc561758f73f74278c824ddfe2f7f0c4adc44b
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Ensuring exclusive access to flow registry.

Ensure that checking of existence of flow and writing not
existing flow is exclusive.

Change-Id: I39db4dba23928bbf42cbe7801b4d67be82bcc652
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "Multipart processing - gett id from device context."

Merge "Improving logging."

Improving logging.

Change-Id: Ic4b8d30eccbaf175f6352b775aa2f80f31c425b5
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Alien flows in operational datastore.

If statistics from device were too fast while batch of flows
it caused that for some of them (somethimes all) wasn't generated
flow ID. Thus flows from statistic didn't have ID only alien ID.

In this fix operational datastore with all flows is deleted everytime
when flow statistics are received. Flows from statistics are looked up
in flow registry. If found then stored ID is used, if not then new
alien ID is generated.

Change-Id: I039daac851208d60c5c7c63d65a7ffba58ae6a6a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Bug 3208: Add actions SetNsch[1-4] and matches Nsch[1-4]

Change-Id: Ifd8788dc171b9071b6141f4108edf801a54aff9a
Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Multipart processing - gett id from device context.

For deleting of meter, group and flow statistics was used attitude,
where node id was get from statistic data.
This patch changed it to get node id from device context.

Change-Id: I0dbad1c246347b3fd9be7a097adda9c2c2f10bd1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "fix parital multipart processing"

fix parital multipart processing

Change-Id: I7428a7df9e448d766a491f15535356c9ace7f0d9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Adaptive throttling

  - throttling is based on md-sal publishing capacity
  - regulation is based on ability to offer new nottification
  - close now throws only SecurityException

Change-Id: Ia29b78ea9bec6bd544a62a61c0dc358cfb01936d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

adapted to notificationProvider API

Change-Id: I50ceba80dd8125b0037e7ae970e0150615f086be
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "Explicitly set git-review branch to master"

Explicitly set git-review branch to master

Change-Id: I667e4b078afe82d492857ceb6b1f363d2ead98e4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

fix npe when calculating IpMatchHash

Change-Id: I32a0af1b840cb1716be40f8a7596e1fa235f51b8
Signed-off-by: Martin Bobak <mbobak@cisco.com>

hashed wheel timer lenght prolonged

Change-Id: I934f028f4a9c7f962143e08f4b282ba1d005e2ee
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "un - throttle connection interval set to 10ms"

Merge "HashedWheel timer tick duration set to 10ms"

Merge "DeviceFlowRegistryImpl uses HashSet instead of ArrayList"

Merge "DeviceContextImpl uses HashSet instead of ArrayList"

Merge "StatisticsContextImpl uses HashSet instead of ArrayList"

Merge "RpcContextImpl uses HashSet instead of ArrayList"

Merge "changed log level to debug"

un - throttle connection interval set to 10ms

Change-Id: I887ddf453c06203f107db12fbb082a9b7c3ca793
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit 199e8cd252cf5dfde1e4c161d50eeb6876b692f3)

HashedWheel timer tick duration set to 10ms

Change-Id: I29221888dabbf856de0e26304824ad28c3bd760f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit 67d4ef643b1a16f26abc5a0f006e1c4e8a7fa806)

DeviceFlowRegistryImpl uses HashSet instead of ArrayList

Change-Id: I333031330279e5d56b2cedef5be29614cec47c5b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit c7d744538d466aa20c5d6bf117e6a4549efe0386)

DeviceContextImpl uses HashSet instead of ArrayList

Change-Id: If1a0606bc0cfad7c48f6c0172b1a4ab3b26d6ff9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit 7936b51a1ff5671c268da6149d9fea3b0cf36048)

StatisticsContextImpl uses HashSet instead of ArrayList

Change-Id: Ib962a35f5323db0670c016220ff6d0b3ad5ee0b9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit ad090d357d4545947a6a34a6c01f39c4f309e664)

RpcContextImpl uses HashSet instead of ArrayList

Change-Id: I78b5c4f02e1318e0562c8bd6595c63b21c39e3ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit deba865e660aab31820f51df6cc9d7c53d36d7d7)

changed log level to debug

Change-Id: I1820ebd13c9166d198a87e5f1f8d3b4e64891008
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit 53121333e59c9096b9647bb46303d1cf22be2019)

BUG 2429 - not releasing dead connection threads

Implementation of fix for this bug was added also to
Lithium codebase.

Change-Id: Id807d54b0f7f0eec0e83f078579f893f818fe0e1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
(cherry picked from commit 1510a4b08068939f3fb3342c5d47d5b42a629f6f)

Merge "Adding required capabilities for LLDP Speaker."

Adding required capabilities for LLDP Speaker.

Adding required capabilities tags to xml of LLDP Speaker
for config subsystem.

Change-Id: Ie5a713ab5845651fd16c0897adfecadab6e0d106
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Adding required capabilities for FRM.

Adding required capabilities tags to xml of FRM for config subsystem.

Change-Id: I77a35265c4529ce289c6a76fdc64ac7d2f676c66
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

binding thread pools in drop test to target node

Change-Id: I593fb2d9dee8d991522d7538a8144b6c74c4417a
Signed-off-by: Martin Bobak <mbobak@cisco.com>

flow hash should be written to device flow registry only if alien ID was generated

Change-Id: I649171151ea2079e56ca200a353f2cff0658973c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

performance fix - nodeConnector II reuse

 - instead of full creating of instanceIdentifier of nodeConnector
   we now reuse instanceIdentifier of node and add just nodeConnector part

Change-Id: I7f55fc73d38f716d3d8b08d65ba5bdc68174dad7
Signed-off-by: Martin Bobak <mbobak@cisco.com>

FlowRegistryException is not used anymore

Change-Id: I407c837aeb9e65ae79ed25c8f4e93ff6f8d43d3d
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "internal message statistics available trough JMX bean"

internal message statistics available trough JMX bean

Change-Id: Id49ab7080ee396e16af2f06282f1cc6b5e268010
Signed-off-by: Martin Bobak <mbobak@cisco.com>

more of internal flow mode stats

Change-Id: Iaaafcd27e4fc81b3fa0e60f16f0f1907e5edbf99
Signed-off-by: Martin Bobak <mbobak@cisco.com>

added internal stats for packetIn+addFlow

Change-Id: Ie179559c2ceffdb74412843cce5298b0bc57bf9d
Signed-off-by: Martin Bobak <mbobak@cisco.com>

connection adapter is set to autoread = false when notofications are not handled

Change-Id: Ie97ed2237a862c64dbd7b7616dce37ef98f3673e
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Fix LOG: private static final

Change-Id: Id153479e96cf97d17064e7f90b4661982dcf2da1
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceFlowRegistry doesn't use ConcurrentHashMap

Change-Id: I3d670585272ec986c078fa2a2ca392e452c22bd3
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Added signum where missing

 - for BigInteger ctor based on byte[] it might get negative value
 - 1 is for positive value - replaced by constant

Change-Id: I478880925dabeae7296222e731800c55b92b8175
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Eliminating new BigInteger where possible

Change-Id: I5c2b7d209f4c80e8cc4d0320f4e7f01f28963b54
Signed-off-by: Martin Bobak <mbobak@cisco.com>

fixed pool size

Change-Id: I1097a0860a55bdeaabd399c7bd826fb4730c4875
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceContext changes approach to synchronization

Instead of creating synchronization locks on whole DeviceContext object,
we create locks on relevant fields.

Change-Id: I593d579a2d4c40eb8b5aef29f7c7c76f5e918e70
Signed-off-by: Martin Bobak <mbobak@cisco.com>

CommonService has its fields private

Change-Id: I24a3ecf9ab3b869cc0575f4b36b4a7effb6a468a
Signed-off-by: Martin Bobak <mbobak@cisco.com>

removed worthless logging wrapping

Change-Id: If005d2a5e84a187e6798629015b133f41e436f5d
Signed-off-by: Martin Bobak <mbobak@cisco.com>

changed approach to synchronization of DeviceContext

Change-Id: I557bf7c894708a1612feb9d304bee70b68667109
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "deviceCtx should not be used where is not needed"

Merge "Use ImmutableMap for TranslatorLibrary"

Merge "Lower fast-path locking in RpcContext"

deviceCtx should not be used where is not needed

Change-Id: Iec28b063342a13aafed81ee0cae49852561ab34c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Use ImmutableMap for TranslatorLibrary

There is no need for this to be concurrent.

 - fixed typo

Change-Id: If189f01e931e066205aa12108775a8c28e9c404c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Lower fast-path locking in RpcContext

Instead of acquiring the lock three times, perform common operations
under the lock and then follow-up without it.

 - fixed typo

Change-Id: Ie5b3f5cdd388c54f170e2a742855a6e654094994
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "add flowHash to device registry only after flow is successfully written to DS"

add flowHash to device registry only after flow is successfully written to DS

Change-Id: Ib3b746140462bab3fa632f23c67fb6088266184e
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Cleanup BaseCallback

The fields should be private and final, so clean them up, making the
lifecycle much easier to understand.

Change-Id: I54b029ded933f2f56da6559b0991e2fdd7d5a91d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix null check

Preconditions.checkNotNull() was not used correctly. Fix that up.

Change-Id: I31582fd72365e4ad7c457f4e7cba4286bf133782
Signed-off-by: Robert Varga <rovarga@cisco.com>

Lower the size of deviceContext synchronized block

The synchronized block is needlessly large, slowing things down with
unrelated transitions happening.

Change-Id: I700ba58f567c592a611fd50f94cf27594385f865
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fixed Scariest level bugs from findbugs.

Change-Id: I22b51dd31887c9c61a049b7c06835f082fd7fd4f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

optimized usage of registry

Change-Id: I9f7a551e172cb932af0f7b13d4c47f0a30db59d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>

optimized removal request context from registry

Change-Id: I0f73d5abe4dd15e525725a6f4ceec3f57f387b26
Signed-off-by: Martin Bobak <mbobak@cisco.com>

TranslatorLibrary holds translators in synchronized structure

Change-Id: I2fbbba39bbfa67937af7306ea63ce85005aa1f9c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

hash usage optimized

Change-Id: Ie84d00786e0e2f74a45c20dfdec52f7f1c11e3ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>