openflowplugin.git
7 years agoBug 5540 - GroupConvertor, GroupStatsConvertor, GroupDescStatsConvertor 44/40944/19
Tomas Slusny [Tue, 28 Jun 2016 13:59:50 +0000 (15:59 +0200)]
Bug 5540 - GroupConvertor, GroupStatsConvertor, GroupDescStatsConvertor

- Reworked GroupConvertor and GroupStatsConvertor to new ConvertorManager design
- Added GroupDescStatsConvertor (moved some logic from GroupStatsConvertor)
- Updated (and fixed) tests, and updated usages accordingly

Change-Id: Iabae7191ceeefeb208487ab5cf0280e8f8186c3e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5540 - ActionConvertor, ActionResponseConvertor 37/40937/19
Tomas Slusny [Tue, 28 Jun 2016 12:55:02 +0000 (14:55 +0200)]
Bug 5540 - ActionConvertor, ActionResponseConvertor

- Reworked ActionConvertor to use new ConvertorManager desing
- Added new ActionResponseConvertor (moved a bit of logic from ActionConvertor)
- Updated tests and usages accordingly

Change-Id: I76a9b345942272dc555e4d75766968931ee4ecdb
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5540 - PortConvertor, MatchConvertor 77/40877/23
Tomas Slusny [Mon, 27 Jun 2016 14:10:40 +0000 (16:10 +0200)]
Bug 5540 - PortConvertor, MatchConvertor

- Reworked MatchConvertorImpl and MatchConvertorV10Impl (extracted some logic from it)
- Added MatchResponseConvertor and MatchV10ResponseConvertor
- Updated and added new tests, and updated usage of match convertors
- Reworked PortConvertor to use new ConvertorManager design
- Updated tests and usage of PortConvertor accordingly

Change-Id: If53d7c521bf4a718a466ec7cd11d28e57d8cf4bd
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5540 - MeterStatsResponseConvertor, MeterConfigStatsResponseConvertor 75/40875/21
Tomas Slusny [Mon, 27 Jun 2016 13:49:27 +0000 (15:49 +0200)]
Bug 5540 - MeterStatsResponseConvertor, MeterConfigStatsResponseConvertor

- Reworked MeterStatsResponseConvertor to use new ConvertorManager desing
- Moved part of logic of MeterStatsResponseConvertor to new
  MeterConfigStatsResponseConvertor
- Updated tests and usage of MeterStatsResponseConvertor and
  MeterConfigStatsResponseConvertor accordingly

Change-Id: I5555fae748fd8d3c2e0baa8d2b56ee450fe4697b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5540 - MeterConvertor 70/40870/21
Tomas Slusny [Mon, 27 Jun 2016 13:17:39 +0000 (15:17 +0200)]
Bug 5540 - MeterConvertor

- Reworked MeterConvertor to use new ConvertorManager design
- Updated tests and usage of TableFeaturesConvertor accordingly

Change-Id: Icaf9a28d569ae76e396427d79241401f6517a46c
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5540 - TableFeaturesResponseConvertor 68/40868/22
Tomas Slusny [Mon, 27 Jun 2016 12:52:17 +0000 (14:52 +0200)]
Bug 5540 - TableFeaturesResponseConvertor

- Reworked TableFeaturesReplyConvertor (renamed to TableFeaturesResponseConvertor) to
  use new ConvertorManager desing
- Updated tests and usage of TableFeaturesReplyConvertor/TableFeaturesResponseConvertor

Change-Id: Ifc48f3228ba09d6ee8cf87d902178957c3a67f7d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5540 - TableFeaturesConvertor 65/40865/23
Tomas Slusny [Mon, 27 Jun 2016 12:24:11 +0000 (14:24 +0200)]
Bug 5540 - TableFeaturesConvertor

- Reworked TableFeaturesConvertor to use new ConvertorManager design
- Updated tests and usage of TableFeaturesConvertor accordingly

Change-Id: Ic2430412edac4cc0658f1fa7ccdecb5ebf937eef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5540 - ConvertorManager base 63/40863/24
Tomas Slusny [Mon, 27 Jun 2016 11:36:16 +0000 (13:36 +0200)]
Bug 5540 - ConvertorManager base

- Added base for ConvertorManager
- Removed datapathId from Convertor interface (as it was not needed anymore)
- Updated usages and tests accordingly
- Moved IPProtocols and IPConversionUtil to package
  org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.common

Change-Id: I22940403495be5f0398682cab4e3377ee86ce7be
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5895 - Support of Ext109 openflow tcp flag matching in openflowplugin 30/42630/5
Anil Vishnoi [Wed, 27 Jul 2016 10:59:27 +0000 (03:59 -0700)]
Bug 5895 - Support of Ext109 openflow tcp flag matching in openflowplugin

Flow matching based on TCP FLAGs is now ONF approved
extension for OpenFlow Spec 1.3.X. OVS also support this
extension as well as it's own version of Nicira Extension.

Depends-On: https://git.opendaylight.org/gerrit/#/c/42954/2

Change-Id: I23c1e9956112e72b28d24a088b375f2732e5523c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoBUG:6058 - Currently the Operational Datastore does not get cleaned up and the switch 67/37767/12
Shuva Kar [Tue, 19 Apr 2016 02:52:27 +0000 (08:22 +0530)]
BUG:6058 - Currently the Operational Datastore does not get cleaned up and the switch
continues to persist if the node that is connected to the switch goes
down. The patch addresses it

Change-Id: I0e8a65c8f38ac9d4de1def65be1daf7afbab5d18
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoAdded feature for forwardingrules-sync app 30/42730/2
Andrej Leitner [Thu, 28 Jul 2016 16:41:25 +0000 (18:41 +0200)]
Added feature for forwardingrules-sync app

Change-Id: Ia9a65769e9a5466a536dd79802214f45f149a0ec
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoMerge "Bug 6146 - Some Flows not found in DeviceFlowRegistry"
Abhijit Kumbhare [Thu, 28 Jul 2016 20:34:37 +0000 (20:34 +0000)]
Merge "Bug 6146 - Some Flows not found in DeviceFlowRegistry"

7 years agoFRS - sonar issues and repackage 96/42696/1
Andrej Leitner [Thu, 28 Jul 2016 09:53:36 +0000 (11:53 +0200)]
FRS - sonar issues and repackage

 - forwarders moved to strategy package
 - functions converted to labmdas
 - simplified statements
 - remove comments

Change-Id: I103d02f0dab3234ca9338f207a4102d814da2019
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoUse SyncupEntry in syncup method (Bug 6170 cleaning) 47/42547/3
Andrej Leitner [Tue, 26 Jul 2016 08:59:35 +0000 (10:59 +0200)]
Use SyncupEntry in syncup method (Bug 6170 cleaning)

 - used wrapper object SyncupEntry instead of two
   FCN objects in syncup (enriched with source DS types)
 - fixed skipping Config/Operational change in retry
   decorator with using SyncupEntry
 - made updateCompressionState more comprehensible
 - updated junit tests & improved logging

Change-Id: Iedcc94e9ce806c425e47f719e391cf7110ddb2c3
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoBug 6170 + Bug 5919 - made FRS cluster-aware 89/41889/18
Andrej Leitner [Wed, 13 Jul 2016 07:47:43 +0000 (09:47 +0200)]
Bug 6170 + Bug 5919 - made FRS cluster-aware

 - NodeListener changed to clustered DTCL
 - added ClusterRegistration per connected device
   with corresponding actions (on mastership change)
 - added ClusterServiceManager to register services
   at the provider and keep these registrations
 - added ClusterDecorator to skip modifications
   if device is not currently mastered
 - added and updated tests

Change-Id: I4fd9459e67cc5127f7eacca93adbd456a34fab0f
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoCleaning and preparation before bug 6170 88/41888/7
Andrej Leitner [Fri, 8 Jul 2016 12:50:06 +0000 (14:50 +0200)]
Cleaning and preparation before bug 6170

 - refactored name RetryRegistry -> ReconciliationRegistry
 - merged operational listener w/ retry subclass (since not needed)
 - extracted Modification util methods into new class
 - moved SwitchFlowId to utils
 - added some finals, lambdas and fixed typos
 - removed dead code

Change-Id: I4d62c157a39490e14be198e3757d206f3b780558
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoMerge "Move empty match constant into OFConstants"
Jozef Bacigal [Tue, 26 Jul 2016 06:52:50 +0000 (06:52 +0000)]
Merge "Move empty match constant into OFConstants"

7 years agoMerge "SONAR TD - SinglePurposeMultipartReplyTranslator - CC"
Jozef Bacigal [Tue, 26 Jul 2016 06:47:34 +0000 (06:47 +0000)]
Merge "SONAR TD - SinglePurposeMultipartReplyTranslator - CC"

7 years agoMerge "SONAR TD - DeviceFlowRegistryImpl, FlowDescriptorFactory, FlowRegistryKeyFactory"
Jozef Bacigal [Tue, 26 Jul 2016 06:46:14 +0000 (06:46 +0000)]
Merge "SONAR TD - DeviceFlowRegistryImpl, FlowDescriptorFactory, FlowRegistryKeyFactory"

7 years agoMerge "Topology manager small sonar issues (+ optimized imports)"
Jozef Bacigal [Tue, 26 Jul 2016 06:44:51 +0000 (06:44 +0000)]
Merge "Topology manager small sonar issues (+ optimized imports)"

7 years agoBug 6146 - Some Flows not found in DeviceFlowRegistry 10/42510/1
Anil Vishnoi [Mon, 25 Jul 2016 20:18:14 +0000 (13:18 -0700)]
Bug 6146 - Some Flows not found in DeviceFlowRegistry

Hook in the custom comparator code from Helium design
that will bring in the custom flow-match constructs
comparison and address all the regression scenario
poped up because of the hashcode/equals based matching.
Default equals/hashcode approach won't work for flow matching,
because flows match contructs (e.g ip/mac) are not normalized
and also because of the extension augmentation.

This hook don't change the default behavior, it will trigger
only if the flow is not found in the flowRegistry, so as far
as user installs flow with the normalized values, custom
comparator is not required.

Change-Id: Ibeba9693d1c4dc0092fa9a11c8acd0ce7cf7a15d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoMove empty match constant into OFConstants 54/42454/1
Andrej Leitner [Mon, 25 Jul 2016 09:43:22 +0000 (11:43 +0200)]
Move empty match constant into OFConstants

Change-Id: Iee2666f3b2b92e371b9f085849502ec5f22c5650
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoTopology manager small sonar issues 25/42225/3
Andrej Leitner [Thu, 21 Jul 2016 09:31:51 +0000 (11:31 +0200)]
Topology manager small sonar issues
(+ optimized imports)

Change-Id: I123ebdc38a6955b6a8677c78dda97a396108d29c
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoBug 5390 - Adding Ipv6 L3ArbitraryBitMask feature support. 76/42176/5
Sai MarapaReddy [Tue, 12 Jul 2016 01:31:32 +0000 (18:31 -0700)]
Bug 5390 - Adding Ipv6 L3ArbitraryBitMask feature support.

project:- openflowplugin; sub project:- applications

For Stable/Beryllium corresponding patch of subproject
openflowplugin is  https://git.opendaylight.org/gerrit/#/c/41686/

Sample Payload Input:
<ipv6-source-address-no-mask>2070:2070:2001:2001:2001:0471:0471:0471
</ipv6-source-address-no-mask>
<ipv6-source-arbitrary-bitmask>FFFF::0471</ipv6-source-arbitrary-bitmask>
<ipv6-destination-address-no-mask>2001:2001:2001:2001:2001:0471:0471:0471
</ipv6-destination-address-no-mask>
<ipv6-destination-arbitrary-bitmask>FFFF:FFFF::FFFF
</ipv6-destination-arbitrary-bitmask>

Author: Eleftherios Koxias <elkoks@intracom-telecom.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>
Change-Id: I179526fdf8bb1b536f10d851698e1b0a63a70a7d
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
7 years agoBug 5390 - Adding Ipv6 L3ArbitraryBitMask feature support. 05/42105/3
Sai MarapaReddy [Tue, 12 Jul 2016 00:20:08 +0000 (17:20 -0700)]
Bug 5390 - Adding Ipv6 L3ArbitraryBitMask feature support.

New yang file is created to accomodate the introduction of
ipv6 L3ArbitraryBitMask feature. It includes unit test coverage.

Sample Payload Input:
<ipv6-source-address-no-mask>2070:2070:2001:2001:2001:0471:0471:0471
</ipv6-source-address-no-mask>
<ipv6-source-arbitrary-bitmask>FFFF::0471</ipv6-source-arbitrary-bitmask>
<ipv6-destination-address-no-mask>2001:2001:2001:2001:2001:0471:0471:0471
</ipv6-destination-address-no-mask>
<ipv6-destination-arbitrary-bitmask>FFFF:FFFF::FFFF
</ipv6-destination-arbitrary-bitmask>

Change-Id: I901bd17b716fafbb44a5e0a1d7237764b14fd23c
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Author: Eleftherios Koxias <elkoks@intracom-telecom.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>

7 years agoMerge "Bug 6073: Wait for completion of add-group RPCs as needed."
Anil Vishnoi [Sun, 24 Jul 2016 04:26:59 +0000 (04:26 +0000)]
Merge "Bug 6073: Wait for completion of add-group RPCs as needed."

7 years agoAdd missing license headers 72/42372/1
Thanh Ha [Sat, 23 Jul 2016 02:03:16 +0000 (22:03 -0400)]
Add missing license headers

Change-Id: I55ddbc065dba438b595b1d080ac1943b2ee547af
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBug 6073: Wait for completion of add-group RPCs as needed. 29/40429/7
Shigeru Yasuda [Thu, 16 Jun 2016 06:58:53 +0000 (15:58 +0900)]
Bug 6073: Wait for completion of add-group RPCs as needed.

We need to wait for completion of add-group RPCs that install groups
referenced from other flows/groups.

Additional changes:

  * Fixed NPE in group reconciliation caused by null buckets.

Change-Id: Iad9bdf62ecdb189fe5e6080085f2ab7cc3131396
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoBUG-4117: Adding Retries during DTCL registration 67/39967/8
Shuva Kar [Tue, 7 Jun 2016 17:46:22 +0000 (23:16 +0530)]
BUG-4117: Adding Retries during DTCL registration

Change-Id: I38427b63e4047895dcbcd976f02d57e2981d3518
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoSONAR TD - DeviceFlowRegistryImpl, FlowDescriptorFactory, FlowRegistryKeyFactory 63/41963/2
Tomas Slusny [Mon, 18 Jul 2016 10:52:27 +0000 (12:52 +0200)]
SONAR TD - DeviceFlowRegistryImpl, FlowDescriptorFactory, FlowRegistryKeyFactory

- Removed DeviceFlowRegistryImpl dependency on FlowUtil (moved FlowUtil.createAlienFlowId
  to DeviceFlowRegistryImpl, adjusted SalFlowServiceImpl to use methods from
  DeviceFlowRegistry to manage flow ids)
- Created private constructors for FlowDescriptorFactory, FlowRegistryKeyFactory
- Created private constructors for FlowDescriptorDto, FlowRegistryKeyDto

Change-Id: I94d38df3c42251274366441b55b1f727e1170bca
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoMerge "Create empty match only once"
Jozef Bacigal [Wed, 20 Jul 2016 12:15:46 +0000 (12:15 +0000)]
Merge "Create empty match only once"

7 years agoMerge "Optimized imports in frm"
Jozef Bacigal [Wed, 20 Jul 2016 12:13:37 +0000 (12:13 +0000)]
Merge "Optimized imports in frm"

7 years agoMerge "Bug 4148: Fixed the log level."
Jozef Bacigal [Wed, 20 Jul 2016 12:00:25 +0000 (12:00 +0000)]
Merge "Bug 4148: Fixed the log level."

7 years agoRevert "Merge "Bug 6235 - Cookie compare in FlowRegistryKeyFactory"" 32/42132/1
Jozef Bacigal [Wed, 20 Jul 2016 09:38:34 +0000 (11:38 +0200)]
Revert "Merge "Bug 6235 - Cookie compare in FlowRegistryKeyFactory""

This reverts commit 9f162b87886b2bb3917fb5aa8aa3b37f49215516, reversing
changes made to 7fa33fd58abd5d38788581d9207e972dfd3eb592.

Change-Id: Icbc0738d392e0d270f033b3efb9b90cd33824fac
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
7 years agoOptimized imports in frm 30/42130/1
miroslav.macko [Wed, 20 Jul 2016 09:28:02 +0000 (11:28 +0200)]
Optimized imports in frm

Change-Id: I96545bca8ef2a01aef974b2223961717ccb62866
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 4148: Fixed the log level. 27/42127/1
Andrej Leitner [Wed, 20 Jul 2016 08:44:24 +0000 (10:44 +0200)]
Bug 4148: Fixed the log level.

 - changed to debug as it was agreed in ch-p on Be branch
   to prevent log flooding

Change-Id: If2cbc0d5ab4c6678b7c1a9a62cdb152ea1e554e5
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoCreate empty match only once 26/42126/2
Andrej Leitner [Wed, 20 Jul 2016 08:14:56 +0000 (10:14 +0200)]
Create empty match only once

Change-Id: I206a588303c563d42c173cf2062501c92159dcc4
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoMerge "Bug 6235 - Cookie compare in FlowRegistryKeyFactory"
Jozef Bacigal [Wed, 20 Jul 2016 08:14:38 +0000 (08:14 +0000)]
Merge "Bug 6235 - Cookie compare in FlowRegistryKeyFactory"

7 years agoMerge "Bug 6193 - Change in length of DatapathId of a switch"
Jozef Bacigal [Wed, 20 Jul 2016 08:11:14 +0000 (08:11 +0000)]
Merge "Bug 6193 - Change in length of DatapathId of a switch"

7 years agoMerge "Sonar major issues."
michal rehak [Wed, 20 Jul 2016 08:07:53 +0000 (08:07 +0000)]
Merge "Sonar major issues."

7 years agoMerge "BUG-6059: Moving Statistics Manager to DTCL"
Anil Vishnoi [Wed, 20 Jul 2016 08:01:17 +0000 (08:01 +0000)]
Merge "BUG-6059: Moving Statistics Manager to DTCL"

7 years agoMerge "Technical Debt part 2"
Jozef Bacigal [Wed, 20 Jul 2016 07:55:15 +0000 (07:55 +0000)]
Merge "Technical Debt part 2"

7 years agoMerge "Technical Debt part 1"
Jozef Bacigal [Wed, 20 Jul 2016 07:52:12 +0000 (07:52 +0000)]
Merge "Technical Debt part 1"

7 years agoFix He plugin config push failure 17/42117/1
Tom Pantelis [Wed, 20 Jul 2016 01:51:37 +0000 (21:51 -0400)]
Fix He plugin config push failure

The 42-openflowplugin.xml referenced the distributed-entity-ownership
config module as a required capability but this config module was
recently removed. However it should never have referenced this module in the
first place as it's an implementation module.

Change-Id: I6e4236fab3ab6a7e878dcb996dc386250cee5159
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
7 years agoBug 6193 - Change in length of DatapathId of a switch 92/42092/1
Sai MarapaReddy [Tue, 19 Jul 2016 20:37:21 +0000 (13:37 -0700)]
Bug 6193 - Change in length of DatapathId of a switch

Dpid can go out of the Long range which results in NumberFormatException.
Hence the need to use BigInteger to hold the Dpid

Current patch accomodates Dpid to be of type BigInteger.

Change-Id: Id10a6afb09ee6da04faad6a0bcfaa960f32e93b7
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>

7 years agoMerge "BUG 6179 - Turning off flow removed notification"
Jozef Bacigal [Tue, 19 Jul 2016 14:45:44 +0000 (14:45 +0000)]
Merge "BUG 6179 - Turning off flow removed notification"

7 years agoSONAR TD - SinglePurposeMultipartReplyTranslator - CC 43/42043/1
Tomas Slusny [Tue, 19 Jul 2016 12:19:14 +0000 (14:19 +0200)]
SONAR TD - SinglePurposeMultipartReplyTranslator - CC

- Reduced cyclomatic complexity of method
  SinglePurposeMultipartReplyTranslator.translate

Change-Id: Ib410f51d646ec39f3795f344c5e3199fd912eae4
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBUG 6179 - Turning off flow removed notification 63/41563/9
miroslav.macko [Thu, 7 Jul 2016 07:06:22 +0000 (09:06 +0200)]
BUG 6179 - Turning off flow removed notification

- created notification-flow-removed-off switch
in openflow-provider-config.yang with default value false
- added managed-properties to openflowplugin.xml

Change-Id: Id657e0b995a40eee3beda85794fbe81fc15c6875
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 6235 - Cookie compare in FlowRegistryKeyFactory 36/42036/2
Tomas Slusny [Tue, 19 Jul 2016 10:37:16 +0000 (12:37 +0200)]
Bug 6235 - Cookie compare in FlowRegistryKeyFactory

- Comparing by cookie was missing, so updated equals() and
  hashCode() methods

Change-Id: I373ec09b2ab1089ec23fdb44a8b5dd0bf9ee4296
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoTechnical Debt part 2 54/41754/2
miroslav.macko [Wed, 13 Jul 2016 09:56:10 +0000 (11:56 +0200)]
Technical Debt part 2

- NodeStaticReplyTranslatorUtil
- Cyclomatic Complexity "nodeGroupFeatureTranslator"
- SystemNotificationsListenerImpl
- Cyclomatic Complexity "onSwitchIdleEvent"
- Reduce lambda expression number of lines

Change-Id: Id042ceba0155f6aa33a49fe1950c2d68b50b2853
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoTechnical Debt part 1 48/41748/2
miroslav.macko [Wed, 13 Jul 2016 07:43:13 +0000 (09:43 +0200)]
Technical Debt part 1

- MultipartRequestInputFactory
- added switch default case, removed unused method
- ConnectionManagerImpl
- BITMAP_NEGOTIATION_ENABLED constant
- HandshakeListenerImpl
- more readable changes
- log error

Change-Id: I8a52f1db824ca261e9b3da2aa1c7ca7999e7a745
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBUG-6059: Moving Statistics Manager to DTCL 99/40199/8
Shuva Kar [Sun, 12 Jun 2016 10:11:38 +0000 (15:41 +0530)]
BUG-6059: Moving Statistics Manager to DTCL

Change-Id: Icd82a0be1c905ffa7039575bf668ba00ece736e7
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoSonar major issues. 45/41845/1
Jozef Bacigal [Thu, 14 Jul 2016 16:28:40 +0000 (18:28 +0200)]
Sonar major issues.

Change-Id: I514bc07d4bb2f86aeab7e67a4cca6e0482debc5c
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
7 years agoFix DeviceFlowRegistry filling 34/41834/1
Tomas Slusny [Thu, 14 Jul 2016 14:01:54 +0000 (16:01 +0200)]
Fix DeviceFlowRegistry filling

- Fixed double filling of DeviceFlowRegistry
- Moved nodeInstanceIdentifier parameter from DeviceFlowRegistry.fill
  to it's constructor

Change-Id: I11be668a80b98f40e0b9aaa863d616fe669c0921
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoMerge "Bug 6181 - DeviceFlowRegistry performance issue when reading from datastore"
Jozef Bacigal [Thu, 14 Jul 2016 06:47:43 +0000 (06:47 +0000)]
Merge "Bug 6181 - DeviceFlowRegistry performance issue when reading from datastore"

7 years agoMerge "Upgrade ietf-{inet,yang}-types to 2013-07-15"
Thanh Ha [Wed, 13 Jul 2016 15:39:49 +0000 (15:39 +0000)]
Merge "Upgrade ietf-{inet,yang}-types to 2013-07-15"

7 years agoBug 6181 - DeviceFlowRegistry performance issue when reading from datastore 63/41663/5
Tomas Slusny [Fri, 8 Jul 2016 05:55:24 +0000 (07:55 +0200)]
Bug 6181 - DeviceFlowRegistry performance issue when reading from datastore

- Moved DeviceFlowRegistry.fill() to separate thread
- Chained statistics scheduling to start after DeviceFlowRegistry
  initialization
- Changed DeviceFlowRegistry.retrieveIdForFlow(FlowRegistryKey) to not
  generate alien flow ids
- Now DeviceFlowRegistry is properly cleaned after device becomes slave

Change-Id: Icf8445dbc7b2140c412d66b463f31d72cf43f3ba
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoBug 5572 update features.xml 70/37670/10
Andrej Leitner [Mon, 27 Jun 2016 09:53:52 +0000 (11:53 +0200)]
Bug 5572 update features.xml

 - added new feature for FRM (odl-openflowplugin-app-forwardingrules-manager)
 - features lldp-speaker, topology-lldp-discovery and topology-manager merged
   into new feature (odl-openflowplugin-app-topology)
 - odl-openflowplugin-flow-services starts standard apps (config, FRM, topology)
   then southbound API for them
 - removed feature odl-openflowplugin-nsf-services (not needed)
 - removed feature odl-openflowplugin-all (not needed)
 - made feature odl-openflowplugin-app-notifications dependent on soutbound

Change-Id: Ia680f391ffeb74d5ec41271b582be9f85dab8451
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoUpgrade ietf-{inet,yang}-types to 2013-07-15 98/40798/6
Lorand Jakab [Wed, 6 Jul 2016 15:20:26 +0000 (10:20 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: Iffaa4ae8127e59eb507dadd02830382059ca5122
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBUG-6145 Flows rm'ed from DeviceFlowRegistry after being updated 47/41247/4
Josh [Sun, 3 Jul 2016 15:32:58 +0000 (17:32 +0200)]
BUG-6145 Flows rm'ed from DeviceFlowRegistry after being updated

Fixed this by implementing an actual update
instead of delete+add.

Changes:
DeviceFlowRegistry: no changes required since the
store method overwrites whatever was previously there.
SalFlowServiceImpl: Reworked logic to support update
and add
ItemLifecycleListener: added update methods.

Change-Id: I2bab85020656c0d19c3db3d029c86cd699cb65b9
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoMerge "BUG-6109: Having a null match field is totally fine."
Jozef Bacigal [Mon, 11 Jul 2016 09:59:57 +0000 (09:59 +0000)]
Merge "BUG-6109: Having a null match field is totally fine."

7 years agoBUG-6109: Having a null match field is totally fine. 05/41605/1
Shuva Kar [Sat, 9 Jul 2016 01:55:51 +0000 (07:25 +0530)]
BUG-6109: Having a null match field is totally fine.

The ofplugin flow registry being modified to handle it in the newer
version of the ofplugin

Change-Id: I07c9b9941bcac2bd5cb82d84898b732bbfc21968
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoMerge "BUG-5888: moving the reconciliation process into a different thread to prevent...
Anil Vishnoi [Fri, 8 Jul 2016 20:44:45 +0000 (20:44 +0000)]
Merge "BUG-5888: moving the reconciliation process into a different thread to prevent holding on to DTCL thread while provisioning bulk flows/groups."

7 years agoBUG-5888: moving the reconciliation process into a different thread to 83/41583/1
Shuva Kar [Tue, 7 Jun 2016 18:28:01 +0000 (23:58 +0530)]
BUG-5888: moving the reconciliation process into a different thread to
prevent holding on to DTCL thread while provisioning bulk flows/groups.

Change-Id: I1ee14e6899fdf9d373634de0260a09ab86303e7f
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoMerge "Added createEmptyRpcBatchResultFuture method"
Jozef Bacigal [Fri, 8 Jul 2016 11:14:46 +0000 (11:14 +0000)]
Merge "Added createEmptyRpcBatchResultFuture method"

7 years agoMerge "Cyclomatic complexity more than 10"
michal rehak [Fri, 8 Jul 2016 07:20:00 +0000 (07:20 +0000)]
Merge "Cyclomatic complexity more than 10"

7 years agoMerge "Bug 6161 - PrintStackTrace replaced with logger"
michal rehak [Fri, 8 Jul 2016 07:08:39 +0000 (07:08 +0000)]
Merge "Bug 6161 - PrintStackTrace replaced with logger"

7 years agoMerge "Fixed debug log messages."
Anil Vishnoi [Fri, 8 Jul 2016 05:52:34 +0000 (05:52 +0000)]
Merge "Fixed debug log messages."

7 years agoAdded createEmptyRpcBatchResultFuture method 92/41492/1
Andrej Leitner [Thu, 7 Jul 2016 14:59:48 +0000 (16:59 +0200)]
Added createEmptyRpcBatchResultFuture method

 - duplicated creation replaced by util method

Change-Id: I1dcf8a15c294f0810112c4c9b1bf25dccb0f105c
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoBug 6161 - PrintStackTrace replaced with logger 88/41388/3
Jozef Bacigal [Wed, 6 Jul 2016 10:17:06 +0000 (12:17 +0200)]
Bug 6161 - PrintStackTrace replaced with logger

Change-Id: I3ce83e9a65d5b6249733338f86f8e3aca24d5412
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
7 years agoCyclomatic complexity more than 10 93/41393/3
Jozef Bacigal [Wed, 6 Jul 2016 11:48:19 +0000 (13:48 +0200)]
Cyclomatic complexity more than 10

- Lifecycle conductor changes, more readable
- Connection context small changes
- MDSalRegistrationUtils simplify

Change-Id: Ief4b28dc6a994741bb43aa9a3acf1c7c749ad85e
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
7 years agoMerge "Bug 6162 Using generic Exceptions"
michal rehak [Thu, 7 Jul 2016 12:11:02 +0000 (12:11 +0000)]
Merge "Bug 6162 Using generic Exceptions"

7 years agoBug 6162 Using generic Exceptions 89/41389/1
Jozef Bacigal [Wed, 6 Jul 2016 10:41:30 +0000 (12:41 +0200)]
Bug 6162 Using generic Exceptions

Change-Id: I4a2eccf82799f304beb543b4ef6e026cbfe8da6c
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
7 years agoBug 5578 Improve frsync (cleaning) 84/41384/2
Andrej Leitner [Wed, 6 Jul 2016 07:53:44 +0000 (09:53 +0200)]
Bug 5578 Improve frsync (cleaning)

 - method for RPC results merge moved into utils
 - updated tests
 - renamed methods according to functionality changes
 - improved comments

Change-Id: I705941d48e7f459cea9df61487b6a4392480b54f
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoBug 5578 Improve frsync (barriers) 56/40956/6
Andrej Leitner [Tue, 28 Jun 2016 16:49:57 +0000 (18:49 +0200)]
Bug 5578 Improve frsync (barriers)

 - edit batch futures chaining to wait for barrier
   only when it is necessary/planned

Change-Id: I29f18939682c0344e2a23925f6643c9b43463ffe
Signed-off-by: Andrej Leitner <anleitne@cisco.com>
7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_13"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:33 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_13"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_12"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:28 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_12"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_11"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:23 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_11"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_10"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:17 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_10"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_9"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:10 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_9"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_8"
Jozef Bacigal [Wed, 6 Jul 2016 06:11:04 +0000 (06:11 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_8"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_7"
Jozef Bacigal [Wed, 6 Jul 2016 06:10:58 +0000 (06:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_7"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_6"
Jozef Bacigal [Wed, 6 Jul 2016 06:10:51 +0000 (06:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_6"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_5"
Jozef Bacigal [Wed, 6 Jul 2016 06:10:45 +0000 (06:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_5"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_4"
Jozef Bacigal [Wed, 6 Jul 2016 06:10:39 +0000 (06:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_4"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_3"
Jozef Bacigal [Fri, 1 Jul 2016 11:06:23 +0000 (11:06 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_3"

7 years agoMerge "Bug 5578 Improve frsync (threadpool)"
Jozef Bacigal [Fri, 1 Jul 2016 10:33:54 +0000 (10:33 +0000)]
Merge "Bug 5578 Improve frsync (threadpool)"

7 years agoMerge "BUG-4117: Migrating notification-supplier from DCN to DTCN"
Jozef Bacigal [Fri, 1 Jul 2016 10:16:01 +0000 (10:16 +0000)]
Merge "BUG-4117: Migrating notification-supplier from DCN to DTCN"

7 years agoMerge "Bug 5543 - Bo: Update JUnit tests part_2"
Jozef Bacigal [Fri, 1 Jul 2016 10:10:33 +0000 (10:10 +0000)]
Merge "Bug 5543 - Bo: Update JUnit tests part_2"

7 years agoBug-5543 - Bo: Update JUnit tests part 11 95/40695/4
miroslav.macko [Wed, 22 Jun 2016 11:51:14 +0000 (13:51 +0200)]
Bug-5543 - Bo: Update JUnit tests part 11

Added tests for openflowplugin-extension-nicira

Change-Id: I3f77e2bb41f17b6ae1a29572241ca549830781ad
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_13 29/40729/2
miroslav.macko [Wed, 22 Jun 2016 13:49:04 +0000 (15:49 +0200)]
Bug 5543 - Bo: Update JUnit tests part_13

- Added tests for openflowjava-extension-nicira

Change-Id: Ia5af62c8569515a4fa0a3ce80fba5daf76b219b1
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_12 26/40726/2
miroslav.macko [Wed, 22 Jun 2016 13:47:55 +0000 (15:47 +0200)]
Bug 5543 - Bo: Update JUnit tests part_12

- Added tests for openflowjava-extension-nicira

Change-Id: I1b400e3f15f0cb5ac5da647844f1abc613a4848a
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_11 22/40722/2
miroslav.macko [Wed, 22 Jun 2016 13:31:41 +0000 (15:31 +0200)]
Bug 5543 - Bo: Update JUnit tests part_11

- Added tests for openflowjava-extension-nicira

Change-Id: I6fb6f864655c69db933c4d1ebe2adde9189221ab
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_10 21/40721/2
miroslav.macko [Wed, 22 Jun 2016 13:29:58 +0000 (15:29 +0200)]
Bug 5543 - Bo: Update JUnit tests part_10

- Added tests for openflowjava-extension-nicira

Change-Id: I9d95d5648687989d75dd7b5e315adfc0a452b406
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_9 20/40720/2
miroslav.macko [Wed, 22 Jun 2016 13:29:07 +0000 (15:29 +0200)]
Bug 5543 - Bo: Update JUnit tests part_9

- Added tests for openflowjava-extension-nicira

Change-Id: I59ad64ec53d25c59850e8847ad820774c3e77575
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_8 19/40719/2
miroslav.macko [Wed, 22 Jun 2016 13:27:43 +0000 (15:27 +0200)]
Bug 5543 - Bo: Update JUnit tests part_8

- Added tests for openflowjava-extension-nicira

Change-Id: I5849585383d6188cbaa39ace7a48937f178e06d7
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_7 18/40718/2
miroslav.macko [Wed, 22 Jun 2016 13:25:32 +0000 (15:25 +0200)]
Bug 5543 - Bo: Update JUnit tests part_7

- Added tests for openflowjava-extension-nicira

Change-Id: Ia1940d83b038c4ff4f1c7ca37a3413dedb1fe03b
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_6 17/40717/2
miroslav.macko [Wed, 22 Jun 2016 13:22:19 +0000 (15:22 +0200)]
Bug 5543 - Bo: Update JUnit tests part_6

- Added tests for openflowjava-extension-nicira

Change-Id: I356edcdf1042f5812c1b164025745b628870d334
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_5 15/40715/2
miroslav.macko [Wed, 22 Jun 2016 13:19:54 +0000 (15:19 +0200)]
Bug 5543 - Bo: Update JUnit tests part_5

- Added tests for openflowjava-extension-nicira

Change-Id: I337111f968dafe255e7acafcb5302b726d6264f8
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 5543 - Bo: Update JUnit tests part_4 14/40714/3
miroslav.macko [Wed, 22 Jun 2016 13:10:43 +0000 (15:10 +0200)]
Bug 5543 - Bo: Update JUnit tests part_4

- Added tests for openflowjava-extension-nicira

Change-Id: I184beff17ea648298e10889689e328284a650dac
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>