serviceutils.git
2 years agoDitch blueprint from srm-impl 55/97755/2
Robert Varga [Tue, 5 Oct 2021 18:06:01 +0000 (20:06 +0200)]
Ditch blueprint from srm-impl

We are using a dead plugin to generate half of wiring, with the rest
hand-written. Convert to OSGi DS, noticing a private method, which
really should be part of interface (in keeping with others).

This also fixes a TOCTOU race in removeRecoverableListener(), which
could lead to NPEs.

Since we are now SCR-enabled, we can ditch the use of ODL blueprint
extensions in shell, making everyone a bit happier.

Change-Id: Ia9d4d0fc3f0bc430d3a106f53975ab7d6e1241d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoCleanup dependency 54/97754/2
Robert Varga [Tue, 5 Oct 2021 16:27:44 +0000 (18:27 +0200)]
Cleanup dependency

We have some over-inclusion of dependencies on tools-api. Clean that up
along with testutils and upgrade.

Change-Id: I5fbfc167c9d47a3e33347f5d37079d0a13d32a59
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoRename utils.function to metrics.function
Robert Varga [Tue, 5 Oct 2021 21:18:21 +0000 (23:18 +0200)]
Rename utils.function to metrics.function

This is the sole user of these interfaces, rehost them.

JIRA: INFRAUTILS-92
Change-Id: I17d0e11e9c053cd53477faa4ea264f9e3a675e5b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoRename utils.types.IDs to metrics.IDs
Robert Varga [Tue, 5 Oct 2021 21:12:17 +0000 (23:12 +0200)]
Rename utils.types.IDs to metrics.IDs

This is the sole user, migrate the utility class.

JIRA: INFRAUTILS-95
Change-Id: I89aa77f52ffe3de9043c295fcfb9231522d4ab1f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoRemove caches
Robert Varga [Tue, 5 Oct 2021 18:24:52 +0000 (20:24 +0200)]
Remove caches

This component has been deprecated for removal with no known-live
downstreams. Remove it at start of 3.0.0.

Change-Id: Ifac61ef87173a667fbbf87a4db3a236adbca551c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 3.0.0-SNAPSHOT
Robert Varga [Tue, 5 Oct 2021 18:24:11 +0000 (20:24 +0200)]
Bump versions to 3.0.0-SNAPSHOT

This starts the next major development iteration.

Change-Id: I89c0adfb4f57e9f87c1f6f101c2469d5022816d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoMigrate metrics sample to OSGi DS
Robert Varga [Tue, 5 Oct 2021 14:49:59 +0000 (16:49 +0200)]
Migrate metrics sample to OSGi DS

Rather than using blueprint, switch over to OSGi DS, making things
a bit faster.

JIRA: INFRAUTILS-81
Change-Id: I19754b5145830bf48e2e3c6ca3a9d223e4e8dc61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 2.0.7-SNAPSHOT
Robert Varga [Fri, 10 Sep 2021 20:39:27 +0000 (22:39 +0200)]
Bump versions to 2.0.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I6c3f576a56b961da641fc6bf8e7cac9c4326b7b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 9.0.6
Robert Varga [Wed, 8 Sep 2021 14:23:53 +0000 (16:23 +0200)]
Bump odlparent to 9.0.6

Adopt latest upgrades from upstream.

Change-Id: I03e4ad4da1430e7190aa862c03f7532d70d4e56b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 2.0.6-SNAPSHOT
Robert Varga [Tue, 24 Aug 2021 11:08:10 +0000 (13:08 +0200)]
Bump versions to 2.0.6-SNAPSHOT

This starts the next development iteration.

Change-Id: Ibd074a9a69dc623283d2360e04a7d17a019eeace
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 9.0.5
Robert Varga [Tue, 24 Aug 2021 11:07:43 +0000 (13:07 +0200)]
Bump odlparent to 9.0.5

Pick up the last part of BouncyCastle fix.

Change-Id: I07583c548c8b71277b18421fb39937408e747c3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 2.0.5-SNAPSHOT
Robert Varga [Mon, 23 Aug 2021 16:22:09 +0000 (18:22 +0200)]
Bump versions to 2.0.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I2aa4a72a52598731064bc3db8ae07b144ba91332
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 9.0.4
Robert Varga [Mon, 23 Aug 2021 16:21:35 +0000 (18:21 +0200)]
Bump odlparent to 9.0.4

Pick up BouncyCastle fix from upstream.

Change-Id: Ic245f9b0af55546624ddca0f0709d26f6a348138
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 2.0.4-SNAPSHOT
Robert Varga [Thu, 19 Aug 2021 19:07:17 +0000 (21:07 +0200)]
Bump versions to 2.0.4-SNAPSHOT

This starts the next development iteration.

Change-Id: Ib6f6e08eea47583385adf6973349b42d0c79ee21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoAdopt odlparent-9.0.3
Robert Varga [Thu, 19 Aug 2021 13:25:59 +0000 (15:25 +0200)]
Adopt odlparent-9.0.3

Pick up latest upgrades and fixes from upstream.

Change-Id: I8e25826dc72dcf874a8b17bfecd97fdf2efdc06c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 2.0.3-SNAPSHOT
Robert Varga [Mon, 24 May 2021 21:41:56 +0000 (23:41 +0200)]
Bump versions to 2.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I4647b5ac0e3d2b8181a8646e03063800dc87c135
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 9.0.2
Robert Varga [Mon, 24 May 2021 09:42:02 +0000 (11:42 +0200)]
Bump odlparent to 9.0.2

Adopt latest upgrades and fixes from upstream.

Change-Id: I4d769a794ee1547399e83236680c2ccb32eeacc1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBimp versions to 2.0.2-SNAPSHOT
Robert Varga [Sun, 9 May 2021 04:48:25 +0000 (06:48 +0200)]
Bimp versions to 2.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I43afe6154f2fec278af483055e0e84b92e840bf1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoUse odlparent-.9.0.1
Robert Varga [Sun, 9 May 2021 04:48:02 +0000 (06:48 +0200)]
Use odlparent-.9.0.1

Pick up latest upgrades from upstream.

Change-Id: I3983e3b776270c0ba1eebce5c5035a90cdfb19ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 2.0.1-SNAPSHOT
Robert Varga [Wed, 14 Apr 2021 09:42:37 +0000 (11:42 +0200)]
Bump versions to 2.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I26c3acb975148c32710183bd0f1d55a4b18a1f63
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 9.0.0
Robert Varga [Tue, 13 Apr 2021 21:41:56 +0000 (23:41 +0200)]
Bump odlparent to 9.0.0

Bump to latest odlparent release.

Change-Id: I1dbdc71ce8545c18112b1d011b322d7f10fbf49e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoUse javax.inject from GuicedEE
Robert Varga [Tue, 13 Apr 2021 21:48:11 +0000 (23:48 +0200)]
Use javax.inject from GuicedEE

com.guicedee.services provides an alternative artifact, which is a
proper jar and also a JPMS module.

Change-Id: Ifd5ddc61666ed279261cc024e12e272d8bbce6d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 2.0.0-SNAPSHOT
Robert Varga [Tue, 13 Apr 2021 20:28:37 +0000 (22:28 +0200)]
Bump versions to 2.0.0-SNAPSHOT

This starts the next major development iteration.

Change-Id: I1aa9de1dea66e0e38334c7999a280e620291a879
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump Prometheus to 0.10.0
Robert Varga [Tue, 13 Apr 2021 21:15:33 +0000 (23:15 +0200)]
Bump Prometheus to 0.10.0

https://github.com/prometheus/client_java/releases/tag/parent-0.10.0

Change-Id: I1effc8e1434b156e8a60203cfb1a17f5de3d60b7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.9.7-SNAPSHOT
Robert Varga [Wed, 24 Feb 2021 10:53:47 +0000 (11:53 +0100)]
Bump versions to 1.9.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I2edd615eb085341b0c17ce7af8c2d353762ff743
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 8.1.1
Robert Varga [Wed, 24 Feb 2021 10:52:08 +0000 (11:52 +0100)]
Bump odlparent to 8.1.1

Adopt updates from upstream.

Change-Id: I1c28db1203a8e679f1f82ce33ef229a2e6195437
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.9.6-SNAPSHOT
Robert Varga [Sat, 23 Jan 2021 16:20:50 +0000 (17:20 +0100)]
Bump versions to 1.9.6-SNAPSHOT

This starts the next development iteration.

Change-Id: I9bebbb1c8b6c0ed837b0625bc9ff695f12522bf9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 8.1.0
Robert Varga [Thu, 21 Jan 2021 16:25:09 +0000 (17:25 +0100)]
Bump odlparent to 8.1.0

Pick up karaf-4.3.0 and related goodies, as well as OSGi R7,
updating references to osgi.core.

Change-Id: Ib6d94cbba72aa51cc7b823a9f0ad5d15478df73b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.9.5-SNAPSHOT
Robert Varga [Thu, 7 Jan 2021 13:59:07 +0000 (14:59 +0100)]
Bump versions to 1.9.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I82e14c869b358a79986f4d1cbaeac12f057f3726
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 8.0.3
Robert Varga [Thu, 7 Jan 2021 13:58:31 +0000 (14:58 +0100)]
Bump odlparent to 8.0.3

Pick up the fixes from upstream.

Change-Id: Ie039874d150b2baf87d5a96ba081b0a00aefead1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.9.4-SNAPSHOT
Robert Varga [Mon, 14 Dec 2020 09:42:38 +0000 (10:42 +0100)]
Bump versions to 1.9.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I7c8ed7f6498eda18626e4d8fe81b459016b76502
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 8.0.2
Robert Varga [Fri, 11 Dec 2020 14:15:41 +0000 (15:15 +0100)]
Bump odlparent to 8.0.2

Pick up latest upgrades.

Change-Id: I0890f9b899bd0224dc74c5ecc4b5b1b0673f5fea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.9.3-SNAPSHOT
Robert Varga [Wed, 18 Nov 2020 09:58:07 +0000 (10:58 +0100)]
Bump versions to 1.9.3-SNAPSHOT

This starts the next development iteration.

Change-Id: Id6427d92185eec8c369469de37efc78a7c1b0f68
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 8.0.1
Robert Varga [Fri, 6 Nov 2020 12:27:04 +0000 (13:27 +0100)]
Bump odlparent to 8.0.1

Pick up latest fixes from upstream.

Change-Id: I754530c664592a994374e753c3c993d83afcb8dc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.9.2-SNAPSHOT
Robert Varga [Mon, 19 Oct 2020 23:30:45 +0000 (01:30 +0200)]
Bump versions to 1.9.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I798de6e6b42161cf84b31fb717ced7ab89dc2b6c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.9.1-SNAPSHOT
Robert Varga [Tue, 29 Sep 2020 20:05:35 +0000 (22:05 +0200)]
Bump versions to 1.9.1-SNAPSHOT

This starts the next development iteration.

Change-Id: Ie4033624fcaff51b3ad9a857626940f1684a14ad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoAdopt odlparent-8.0.0
Robert Varga [Tue, 29 Sep 2020 13:10:17 +0000 (15:10 +0200)]
Adopt odlparent-8.0.0

Use upstream version. Also fix javadoc references.

Change-Id: I898185fd145d4a659feb9a96d2759eb57f2f4a9c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 8.0.0-SNAPSHOT
Robert Varga [Tue, 22 Sep 2020 08:39:56 +0000 (10:39 +0200)]
Bump odlparent to 8.0.0-SNAPSHOT

Adopt latest upstream version prior to it being released.

Change-Id: I4d795c7ae5f356252a82d8c15db07938ffe9f3c6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoAdd automatic module names
Robert Varga [Fri, 25 Sep 2020 21:23:01 +0000 (23:23 +0200)]
Add automatic module names

We are running in Java 11 world, let's be more friendly to JPMS
with step one: declaring automatic module names for all production
artifacts.

JIRA: INFRAUTILS-72
Change-Id: I6afd50b76d0987c292681a66c79fd743a3478e1b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoStrengthen MetricProvider deprecations
Robert Varga [Wed, 23 Sep 2020 22:15:01 +0000 (00:15 +0200)]
Strengthen MetricProvider deprecations

Downstreams are not moving with their migrations, turn up the heat
just a little bit.

Change-Id: I377b16fa80381bbe7c7c594e95a8d3c6f99d7dfd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.9.0-SNAPSHOT
Robert Varga [Tue, 22 Sep 2020 08:39:15 +0000 (10:39 +0200)]
Bump versions to 1.9.0-SNAPSHOT

This starts the next development iteration.

Change-Id: I3cb11e882259a01311416e802230dbcdcd3a217c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.8.2-SNAPSHOT
Robert Varga [Mon, 21 Sep 2020 12:21:11 +0000 (14:21 +0200)]
Bump versions to 1.8.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I0c0a980cd43b34cce01a62abad7f383ef0ca8436
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 7.0.6
Robert Varga [Mon, 21 Sep 2020 12:13:37 +0000 (14:13 +0200)]
Bump odlparent to 7.0.6

Pick latest upgrades from upstream.

Change-Id: I49317998ee702a1a19df96b76c04b8b09e06196c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions to 1.8.1-SNAPSHOT
Robert Varga [Tue, 28 Jul 2020 09:52:03 +0000 (11:52 +0200)]
Bump versions to 1.8.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I145443ecf4a1fd084210fc36a7d8cc1de630c149
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent/yangtools/mdsal/controller
Robert Varga [Sun, 26 Jul 2020 23:57:40 +0000 (01:57 +0200)]
Bump odlparent/yangtools/mdsal/controller

Adopt upstream versions:
- odlparent-7.0.5
- yangtools-5.0.5
- mdsal-6.0.4
- controller-2.0.3

Change-Id: Iad33596b44ec7d69ae53a514c7138812242c4c12
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoStrengthen utils.concurrent deprecations
Robert Varga [Fri, 24 Jul 2020 10:50:54 +0000 (12:50 +0200)]
Strengthen utils.concurrent deprecations

We will be removing deprecated API elements in the next release,
make sure all of them are deprecated.

Change-Id: Iad10e82fc91801cc185f9f73dd0fd6e03a64fb3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoRemove metrics-sample annotation leak
Robert Varga [Fri, 24 Jul 2020 10:32:11 +0000 (12:32 +0200)]
Remove metrics-sample annotation leak

We should not be leaking inject into OSGi, make sure it is
properly scoped.

Change-Id: Ica40801c332e6aef6681f8820122c0056ff905de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoRefactor feature repositories
Robert Varga [Thu, 23 Jul 2020 22:24:35 +0000 (00:24 +0200)]
Refactor feature repositories

We have three classes of features: stable, experimental, sample.
Separate them into three repositories, naming the results
consistently with the rest of opendaylight.

Furthermore eliminate the need to declare versions for all artifacts
except samples (which are just for us).

Change-Id: I3a5344cec943247e10a7b5e40341762830ab7f15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoMove features out of common
Robert Varga [Thu, 23 Jul 2020 21:07:30 +0000 (23:07 +0200)]
Move features out of common

Features should be a top-level directory, fix that up.

Change-Id: I7e296aaff32ac2ee8b1ca30b77e12381e0faa1f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoDo not deploy aggregator poms
Robert Varga [Thu, 23 Jul 2020 18:39:54 +0000 (20:39 +0200)]
Do not deploy aggregator poms

Aggregators are used purely for organizing our project structure
and should never be referenced/installed/deployed.

Change-Id: I3eac537dc833520186d3ccaab5448d74b8e62ef4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoConvert metrics-prometheus to use OSGi DS
Robert Varga [Thu, 23 Jul 2020 14:30:53 +0000 (16:30 +0200)]
Convert metrics-prometheus to use OSGi DS

This is rather simple wiring, make a straight conversion. There are
some weird undocumented injection tricks, but alas the entire component
seems to be woefully incomplete.

Change-Id: I2ea329f823645c80830b52caaeeb21d829f49207
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoUpgrade io.prometheus to 0.9.0
Robert Varga [Thu, 23 Jul 2020 13:53:00 +0000 (15:53 +0200)]
Upgrade io.prometheus to 0.9.0

We are using version 0.4.0, which is quite old, upgrade to latest
available.

Change-Id: I7669f9b94a07b84248c332fa4dbafb32bebb3016
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoConvert metrics-impl to OSGi Declarative Services
Robert Varga [Thu, 23 Jul 2020 11:42:54 +0000 (13:42 +0200)]
Convert metrics-impl to OSGi Declarative Services

Rather than going through hybrid generated and hand-written blueprint,
convert activation to OSGi DS, which handles both aspects.

Change-Id: I171e9356a77b00155adc10ac7d9215c4cdd80f85
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 7.0.3
Robert Varga [Wed, 10 Jun 2020 20:24:13 +0000 (22:24 +0200)]
Bump odlparent to 7.0.3

Pick up latest fixes from upstream.

Change-Id: Ia94adac077d56d048e636bd78e85c4fe312a7c5f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 7.0.2
Robert Varga [Sat, 30 May 2020 11:16:57 +0000 (13:16 +0200)]
Bump odlparent to 7.0.2

Pick up latest upgrades from upstream.

Change-Id: I6ba0b55a74b60624f49904be4aa78a243551b6c1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoFix error-prone reported warnings
Robert Varga [Sat, 30 May 2020 11:30:52 +0000 (13:30 +0200)]
Fix error-prone reported warnings

This cleans up the codebase more to EP's liking.

Change-Id: Iddcc67811bbf75724a4455cde5bf13ddf9d4d157
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 7.0.1
Robert Varga [Tue, 31 Mar 2020 14:38:57 +0000 (16:38 +0200)]
Bump odlparent to 7.0.1

Update odlparent in preparation for Aluminium MRI, also adopting
Guice dependency versions.

Some updates are needed around Truth, but since we are using only
primitive assert, adopt plain JUnit asserts as needed.

Change-Id: I74495579c8d9a7b867b4058d5f2430425d6b190e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoFix checkstyle
Robert Varga [Tue, 31 Mar 2020 15:00:20 +0000 (17:00 +0200)]
Fix checkstyle

Updated checkstyle is flushing this violation out.

Change-Id: I38fe8c19a6529528420184c693c89046ebe12e4e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoMigrate OSGi companion references
Robert Varga [Tue, 31 Mar 2020 14:42:40 +0000 (16:42 +0200)]
Migrate OSGi companion references

We are using OSGi R6, which has a different artifact providing
the same interfaces. Update references so they do not point to R5.

Change-Id: Ic7ba53794a406dcc53f35aafa70240e5c8bfa0b6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions by x.y.(z+1)
jenkins-releng [Sat, 22 Feb 2020 04:30:16 +0000 (04:30 +0000)]
Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I0c4b15e27c85d09a29a9c2a150e10a3ca8a4de5a

2 years agoDeprecate Asserts for removal
Robert Varga [Thu, 16 Jan 2020 16:02:15 +0000 (17:02 +0100)]
Deprecate Asserts for removal

We have JUnit 4.13 integrated, which provides equivalent functionality.
Use it directly and deprecate the entire class.

Change-Id: I18e246400b045c89264d91fca6699de837a141b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoUpdate odlparent to 6.0.4
Robert Varga [Thu, 16 Jan 2020 15:51:11 +0000 (16:51 +0100)]
Update odlparent to 6.0.4

This picks up latest updates.

Change-Id: I07249816ecd2d4252760151eba893a1761e22acb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoRework immutables.org integration
Robert Varga [Fri, 22 Nov 2019 09:46:07 +0000 (10:46 +0100)]
Rework immutables.org integration

Rather than depending on the annotation processor, depend only
on the annotations -- the processor comes integrated in the javac
configuration in odlparent.

Change-Id: Icc84c207621fbdad44ef99a46a9bd13dde3d84e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump to odlparent-6.0.3
Robert Varga [Fri, 22 Nov 2019 09:39:57 +0000 (10:39 +0100)]
Bump to odlparent-6.0.3

This picks up the latest upgrades.

Change-Id: I8359aa6a9326ce0264d6101cb8af490b0502fcf4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoDisable ThreadsWatcher by default
Robert Varga [Wed, 27 Nov 2019 12:06:34 +0000 (13:06 +0100)]
Disable ThreadsWatcher by default

Analyzing the JVM for deadlocks is a stop-the-world operation,
which can end up taking seconds to tens of seconds when the JVM
is heavily loaded. Disable this functionality by default, until
we can devise a better strategy for cutting off deadlock detection.

JIRA: INFRAUTILS-66
Change-Id: I7f3a74605ff7c62a0426d9e197064f382e20bf5f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoTolerate platforms without thread management
Robert Varga [Wed, 27 Nov 2019 11:57:35 +0000 (12:57 +0100)]
Tolerate platforms without thread management

ManagementFactory.getThreadMXBean() can legally return null,
make sure we handle it properly. Also cache the platform bean
so we do not end looking it up over and over again.

Change-Id: I50a1781a5f34abc136e6bfd7402a6985066e9cb0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoUse ByteArrayOutputStream.toString(Charset)
Robert Varga [Wed, 27 Nov 2019 11:43:22 +0000 (12:43 +0100)]
Use ByteArrayOutputStream.toString(Charset)

This is a faster version available in Java 10+, use it instead
of toString(String). Since we are in the area, remove unneeded
IOException throws/catch.

Change-Id: I074cc1a8db3479d423b537a6bc9925ff1b87de50
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoFix NPE when updating metrics configuration
Tomas Cere [Tue, 26 Nov 2019 11:35:25 +0000 (12:35 +0100)]
Fix NPE when updating metrics configuration

Incorrect brace nesting was causing NPE when updating config.

Change-Id: I762451984e628bdc9074926578e99318b666552c
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
2 years agoBump to odlparent-6.0.1
Robert Varga [Wed, 6 Nov 2019 14:08:23 +0000 (15:08 +0100)]
Bump to odlparent-6.0.1

This picks up latest upgrades and fixes.

Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 6.0.0
Robert Varga [Wed, 21 Aug 2019 12:11:54 +0000 (14:11 +0200)]
Bump odlparent to 6.0.0

This bumps odlparent to 6.0.0 as part of Magnesium MRI.

Change-Id: I19505dd80b832cd6ed8b68daf471d9e90d3dfdd2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 5.0.2
Robert Varga [Wed, 21 Aug 2019 12:11:23 +0000 (14:11 +0200)]
Bump odlparent to 5.0.2

This bumps odlparent to pick up latest references.

Change-Id: Ica16c98bd6eeeb2530bdc9cee4bb7f198e4a6ab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoFix checkstyle
Robert Varga [Wed, 21 Aug 2019 12:31:36 +0000 (14:31 +0200)]
Fix checkstyle

These violations are caught by updated checkstyle, fix them up.

Change-Id: I082fbfe4998b88151b4cd39af2d6bbc7f027e0be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions by x.y.(z+1)
jenkins-releng [Mon, 12 Aug 2019 16:14:12 +0000 (16:14 +0000)]
Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ib57798ae70c24d686e0ef66ca07aab01e94092d8

2 years agoBump odlparent to 5.0.1
Robert Varga [Thu, 18 Jul 2019 10:32:49 +0000 (12:32 +0200)]
Bump odlparent to 5.0.1

This picks up the latest upgrades.

Change-Id: If6006a94197839a9718cd5eae16b0a025913af93
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoEliminate use of jsr-305
Robert Varga [Sat, 29 Jun 2019 09:27:26 +0000 (11:27 +0200)]
Eliminate use of jsr-305

We are using a single @ThreadSafe annotation and a few @Nullable
annotations. Migrate the first to a comment and the others to JDT.

Change-Id: I7b42f6c39d1730567fa35273517c6c8483b79be4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoMigrate Threadswatcher use of infrautils APIs
Robert Varga [Sat, 13 Apr 2019 08:14:34 +0000 (10:14 +0200)]
Migrate Threadswatcher use of infrautils APIs

This fixes up references to deprecated utils methods.

Change-Id: I22d34b3a3c533e68d31c901b9a3fbe5cc397a882
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoRemove JSR305 dependency from metrics-impl
Robert Varga [Sat, 13 Apr 2019 08:11:41 +0000 (10:11 +0200)]
Remove JSR305 dependency from metrics-impl

There is only a single reference, move it to JDT.

Change-Id: I562ea4a4b4c23388587757bd102c8c223b13ac91
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoUse @code instead of <tt>
Stephen Kitt [Tue, 30 Apr 2019 16:19:44 +0000 (18:19 +0200)]
Use @code instead of <tt>

<tt> breaks Javadocs, the Javadoc markup is {@code ...}.

Change-Id: Iee194acb06c1b01434af0525b3a750ca55bb3a26
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2 years agoBump odlparent to 5.0.0
Robert Varga [Fri, 15 Mar 2019 15:31:14 +0000 (16:31 +0100)]
Bump odlparent to 5.0.0

This bumps the version to MRI, adding JSR305 dependencies where
needed.

Change-Id: I5d4ad0a4c31a31bd0ef36ab6adb2eade6c9fb0a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoFix annotation positions
Robert Varga [Mon, 8 Apr 2019 15:40:40 +0000 (17:40 +0200)]
Fix annotation positions

errorprone is complaining a bit about non-TYPE_USE annotations
being in the wrong place. Fix up most of the violations, omitting
@Nullable, as that is pending migration to JDT, which will fix
those warnings.

Change-Id: I3a8f076f64192b675168af462656576f085a5522
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoRemove post-odlparent-4.0.9 changes
Robert Varga [Fri, 15 Mar 2019 16:17:36 +0000 (17:17 +0100)]
Remove post-odlparent-4.0.9 changes

javax.annotation-api version is declared by odlparent, do not
repeat it here.

Change-Id: I88518900c7c79887e8fc74276b98f02bad3133ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions by x.y.(z+1)
jenkins-releng [Fri, 1 Feb 2019 13:06:29 +0000 (13:06 +0000)]
Bump versions by x.y.(z+1)

Change-Id: Iad90fad64275055fb499d8382227330d53df26a5
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
2 years agoBump to odlparent 4.0.9
Stephen Kitt [Fri, 18 Jan 2019 15:32:48 +0000 (16:32 +0100)]
Bump to odlparent 4.0.9

Change-Id: I84a781c028b0ed9e9fb3b660ef8777c319c6d51b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2 years agoUse odl-dropwizard-metrics
Robert Varga [Thu, 10 Jan 2019 15:38:05 +0000 (16:38 +0100)]
Use odl-dropwizard-metrics

odlparent-4.0.8+ provides a dependency import and the corresponding
feature, use it instead of packaging our own.

Change-Id: Id42c3bbec8eee3a04432e5ad5fec37d0a316f628
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump to odlparent 4.0.8
Stephen Kitt [Wed, 9 Jan 2019 14:54:53 +0000 (15:54 +0100)]
Bump to odlparent 4.0.8

Change-Id: I788dc0ffa71b2728e1cdbd6650b60dd2952f1b87
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2 years agoUse metrics-bom for versions
Robert Varga [Tue, 1 Jan 2019 21:46:47 +0000 (22:46 +0100)]
Use metrics-bom for versions

Rather than repeating versions, import metrics-bom to get all
versions declared to a consistent set. Also upgrades to version
4.0.5, with three patches:

https://github.com/dropwizard/metrics/releases/tag/v4.0.4
https://github.com/dropwizard/metrics/releases/tag/v4.0.5

Change-Id: I5520555540525f81ee865fda873429bd237a4122
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoAdd javax.annotation-api dependencies
Robert Varga [Thu, 3 Jan 2019 23:30:26 +0000 (00:30 +0100)]
Add javax.annotation-api dependencies

Java 11 is shipping without these, hence we need to add dependecies.

Change-Id: Ie99cc82c2c565e0539e03fdc5e64cf09d72731ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoCleanup dependency structure
Robert Varga [Thu, 3 Jan 2019 15:23:02 +0000 (16:23 +0100)]
Cleanup dependency structure

Our parent should import our artifacts, so we can freely refer
to them with proper versions and scope -- otherwise it is extremely
easy to leak things like infrautils-testutils to runtime.

Change-Id: I79bf9a04ec87d50e1434f317d926168980d71b69
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump odlparent to 4.0.7
Robert Varga [Tue, 1 Jan 2019 21:47:47 +0000 (22:47 +0100)]
Bump odlparent to 4.0.7

This fixes SFT/JDK11 compatibility.

Change-Id: Ibec02d9a65a7587633a423b0babc4e8fcbaf2655
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump to odlparent 4.0.5
Stephen Kitt [Fri, 21 Dec 2018 09:10:17 +0000 (10:10 +0100)]
Bump to odlparent 4.0.5

Change-Id: I2adeaf4ba7b3e0dac43a9685912eb9757b26ad29
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2 years agoadd modernizer-maven-plugin to infrautils' parent
Michael Vorburger [Fri, 2 Feb 2018 00:54:04 +0000 (01:54 +0100)]
add modernizer-maven-plugin to infrautils' parent

see https://github.com/gaul/modernizer-maven-plugin

This change was prepared 9 months ago, and is now finally
ready to go in, following last week's release of modernizer-maven-plugin
with my https://github.com/gaul/modernizer-maven-plugin/pull/67.

Change-Id: Id85737d789efb7ee07c8c7a34bdac39d8a96e076
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
2 years agoBump odlparent to 4.0.2
Robert Varga [Mon, 6 Aug 2018 19:01:46 +0000 (21:01 +0200)]
Bump odlparent to 4.0.2

This bumps to Neon-targeted odlparent.

Change-Id: Id376a54639daf286aaef5486a9a82b6f762c5c3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2 years agoexpose report() method in MetricsFileReporter
Michael Vorburger [Sun, 23 Sep 2018 11:48:40 +0000 (13:48 +0200)]
expose report() method in MetricsFileReporter

so that performance tests (e.g. etc'd) can dump Timer metrics.

Change-Id: I22fb8a7f8f1305bd4bbcba7f74b5faacb8e1c438
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
2 years agominor change in MetricsFileReporter
Michael Vorburger [Sun, 23 Sep 2018 11:41:41 +0000 (13:41 +0200)]
minor change in MetricsFileReporter

just move a line up, this should make no difference.  This is in
preparation of the refactoring in the next commit which moves part of
the report() method out into a new method.

Change-Id: If4912e0d7f9b0ac97fda65f56c5dffb12e608133
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
2 years agobump dropwizard.metrics from 4.0.2 to 4.0.3
Michael Vorburger [Tue, 4 Sep 2018 21:34:09 +0000 (23:34 +0200)]
bump dropwizard.metrics from 4.0.2 to 4.0.3

very minor bump; no details in release notes on
https://github.com/dropwizard/metrics/releases

Change-Id: I9850f5479eb1cbfd63fb6c28e3ff2776e827b3be
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
2 years agoPort to Blueprint annotations
Stephen Kitt [Mon, 3 Sep 2018 14:06:48 +0000 (16:06 +0200)]
Port to Blueprint annotations

Blueprint annotations are a perfect match for Blueprint features, and
avoid issues with Pax CDI annotations (including the removal of
@OsgiService and @OsgiServiceProvider in Pax CDI API 1.0.0).

Change-Id: Ic1642863d8c2c7189fd8f8dd0ce1f5ebff619080
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2 years agoAvoid depending on immutables.value at runtime
Robert Varga [Tue, 7 Aug 2018 08:09:03 +0000 (10:09 +0200)]
Avoid depending on immutables.value at runtime

Change-Id: Ia399e0cf7b258d4760461ee5b5635f7e41343f33
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 years agoBump versions by x.(y+1).z for next dev cycle
Anil Belur [Thu, 9 Aug 2018 12:40:15 +0000 (18:10 +0530)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: Iefeaa1909c4bcce65fac47f523e1f46c518ad8f3
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
2 years agoAdding coverage for MetricProvider
manojna v [Wed, 8 Aug 2018 08:28:18 +0000 (13:58 +0530)]
Adding coverage for MetricProvider

Change-Id: I3948497978ff639b76f6032c664b5d16ed162dfc
Signed-off-by: manojna v <manojna.vijayakrishna@ericsson.com>
2 years agoadd odl-infrautils-metrics-sample to docs
Michael Vorburger [Tue, 31 Jul 2018 08:58:29 +0000 (10:58 +0200)]
add odl-infrautils-metrics-sample to docs

Change-Id: I2795643ce73f17f5e64d0d6c09fca57ec6438af4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>