Anil Vishnoi [Wed, 22 Feb 2017 02:38:08 +0000 (18:38 -0800)]
Bug 2487 - Too large configuration file from OVS
Change-Id: Id8d7c9864503cb996112207c6018957ca302a3ad
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Lorand Jakab [Fri, 3 Feb 2017 13:06:05 +0000 (15:06 +0200)]
Checkstyle: fix ParenPad violations
Enforcing no space(s) after a left parenthesis and before a right
parenthesis is a proposed change [0] which can only be merged when all
violations are fixed in projects enforcing checkstyle. This patch fixes
those violations.
[0] https://git.opendaylight.org/gerrit/#/c/51316/
Change-Id: I70e3a8443a05615979fd149a9881bd6ca4b01125
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Michael Vorburger [Mon, 23 Jan 2017 18:58:43 +0000 (19:58 +0100)]
Replace mockito-all by mockito-core (see Bug 7662)
Change-Id: Ie67cd9d6b29672cefa581006015ca5d3a53da563
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Thu, 2 Feb 2017 20:26:14 +0000 (12:26 -0800)]
Bug 7023 - NPE at org.opendaylight.ovsdb.southbound.OvsdbConnectionManager.getClient
Change-Id: If157e70dbbbafa39d2334c1704f0ae9d7460bbda
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
melserngawy [Fri, 18 Nov 2016 14:47:25 +0000 (09:47 -0500)]
Bug 5306: Enable the SSL connection for ovs manager
Use the aaa-cert feature to manage the TLS connection
certificates and add configuration to the southbound-impl
to allow SSL communication.
Change-Id: I1354644b7a4cb30493ce2bc5b33a2d1d504aaae0
Signed-off-by: melserngawy <melserngawy@inocybe.com>
Daniel Malachovsky [Wed, 14 Dec 2016 15:34:17 +0000 (16:34 +0100)]
Replace dlux with dluxapps features
Bug 7484 - Dlux project split - patch for OVSDB project
Renaming is due to DLUX project split.
Also, replacing yangui feature with yangman, new, redesigned and restyled
application.
Change-Id: Ife40e4279a0875adf328fb214f9f6a5003dba12d
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>
Vishal Thapar [Wed, 25 Jan 2017 07:29:16 +0000 (12:59 +0530)]
Bug 7563: Add config for inactivity_probe and max_backoff
Fix v2.: Fixes wrong schema definition for MaxBackoff column in Controller
table. Adds two more exceptions to catch in
OvsdbOperationalCommandAggregator.
This adds support for inactivity_probe and max_backoff fields in
Controller entry. Changes to Util method for addBridge and setControllers
is done in a backward compatible way. Once Netvirt changes to new API,
older one will be removed.
Change-Id: Ia41afa0e6de9be28a50f0a408270ef854b3e1bbe
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Michael Vorburger [Mon, 23 Jan 2017 19:49:37 +0000 (20:49 +0100)]
Replace FindBugs :jsr305 by full :annotation (Bug 7663)
Change-Id: I743b4b4f2c49837cda5c37c0f4ccd9444b67a65d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Alon Kochba [Tue, 24 Jan 2017 14:07:50 +0000 (16:07 +0200)]
Revert "Bug 7563: Add an ability to configure inactivity_probe for OVS"
This reverts commit
5791295e2c408ff8b975916bf673a6ffe2573ae0.
Change-Id: I44533ea4aa7bc2697be9888e15edad20de914c9b
Signed-off-by: Alon Kochba <alonko@hpe.com>
Vishal Thapar [Wed, 18 Jan 2017 21:37:45 +0000 (03:07 +0530)]
Bug 7563: Add an ability to configure inactivity_probe for OVS
This adds support for inactivity_probe and max_backoff fields in
controller entry. Changes to Util method for addBridge and setControllers
is done in a backward compatible way. Once Netvirt changes to new API,
older one will be removed.
Change-Id: Ib7fbb1f6ac70b745264ca6fa191b3f382f3580d0
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Alon Kochba [Sun, 1 Jan 2017 16:25:22 +0000 (18:25 +0200)]
Bug 7559: Add utilities to expose TP by ext-id, get dpnId from TP
- Add utility to return nodes that contain a termination point
referencing a given interface ID via external interface ID.
- Add utility to return the external ID value of a given termination point.
- Add utility to return the datapath ID of a given node identifier
Change-Id: I630773d6291b33d2fa85a3bcb5c344538d83813b
Signed-off-by: Alon Kochba <alonko@hpe.com>
Robert Varga [Fri, 13 Jan 2017 09:08:47 +0000 (10:08 +0100)]
BUG-5222: do not pull in odl-mdsal-xsql
xsql is deprecated, buggy and never was meant for production
use. Do not pull it in.
Change-Id: Ic3577c6433490b91f5a0cdba0b4211721d95f6f0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 10 Jan 2017 14:23:01 +0000 (15:23 +0100)]
BUG-7446: remove use of deprecated MoreExecutors method
sameThreadExecutor() was split into two methods, use the
correct one.
Change-Id: I72ce2c66d1f299552a9ef26fb662981467a239fb
Signed-off-by: Robert Varga <rovarga@cisco.com>
K.V Suneelu Verma [Fri, 2 Dec 2016 14:54:50 +0000 (20:24 +0530)]
bug 6579 removed boilerplate code
removed the boilerplate code from commands moved it to super class
pulled the methods extractUpdated and extractRemoved to super class
child class implements getData and areEqual methods
extractUpdated method compares old data and new data and returns the
change set.
Comparison logic is taken care by the sub class.
extractDeleted gets the deleted keys .
for local ucast mac remove command ,If logical switch is deleted ,
it will return the local ucast macs to be deleted aswell.
logical switch removal is fired in seperate transaction to avoid
failure of transaction because of some local references which odl is not
aware of sometimes due to racing conditions.
if mcast mac locator set gets emptied , fire removal of mcast mac
if the json rpc transaction fails, clear the intransit data from device
info
Change-Id: Ia172b5887887f202ba1149ba748862d86f9c9869
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Vishal Thapar [Wed, 7 Dec 2016 06:41:45 +0000 (12:11 +0530)]
BUG 7310: Add configurable option to skip columns
Adds a new cfg file to configure table columns to be skipped when monitoring updates from OVS
switch. Currently following tables and columns are configurable:
1. Manager: status
Change-Id: I6d869ca559cb69374dcdf75b60282c105af85806
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Wed, 21 Dec 2016 05:49:12 +0000 (11:19 +0530)]
BUG 7414: Tunnel pushed to wrong OVS
If we get DTCN with modiications on multiple nodes, we're processing the
changes as if they were recieved on all nodes. updateData() gets client
for each node in change, but instead of passing on the changes that are
made only on that node, it passes it all the changes including ones on
other nodes/clients.
Fix is to have a map of changes per client and only transact this subset
to the client.
Change-Id: Ie03176b470b120eba76478c8c12e44d831329953
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Anil Vishnoi [Thu, 15 Dec 2016 01:49:17 +0000 (17:49 -0800)]
Bug 7373 - ConflictingModificationAppliedException: Node was
created by other transaction
Ovsdb/Hwvtep plugin creates respective topology under network-topology/topology
and also they make a check if the parent node (network-topology) exist or not.
If not they create the root node. In a scenario where user loads both the
plugin together, their is a possibility that both the plugin can try to
create the network-topology as the same time and one of them will end up
with ConflictingModificationAppliedException. To resolve this scenario
this patch avoid the explcit create of the parent node, and uses the md-sal
PUT api that creates the missing parents. Although it's slow compared to
the other version of PUT api, but given that it's one time operation
at warm up time, it of not much concern.
Change-Id: I9171f17ceef43040d91e75e368ab4e6f59970c59
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
K.V Suneelu Verma [Thu, 1 Dec 2016 18:20:27 +0000 (23:50 +0530)]
bug 6579 checking the depency before transaction
integrated the mcast , ucast mac and logical switch with dependency queue
Change-Id: I60643affc1d275b5a1b3586147ac83a67a01d22d
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Thu, 1 Dec 2016 07:11:23 +0000 (12:41 +0530)]
bug 6579 added dependency queue
Added Dependency Queue which gets processed upon config and op events.
Any object ( mac / port ) whose dependencies are not met gets pushed the
queue with an expiry timeout.
Added the following apis in UnMetDependencyGetter
getInTransitDependencies returns list of keys in json rpc transaction
which are needed by this object to be processed.
getUnMetConfigDependencies returns list of missing config keys
Added the following apis in HwvtepDeviceInfo
onConfigDataAvailable processes config dependency queue
onOpDataAvailable processes in transit dependency queue , gets called
after every json rpc transaction is done
Change-Id: I012958a40e0ab0aa0e0db14dc670f9c4dacbdd09
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Mon, 28 Nov 2016 14:14:50 +0000 (19:44 +0530)]
bug 6579 handling back to back tx updates
Added the following utility methods in operational state and device info
isKeyPartOfCurrentTx indicates this key is also part of the same tx
isKeyInTransit indicates this key is part of prev tx to device
Before inserting any key into any table
check if this key or its dependent keys are part of prev transaction
Change-Id: I87699c244b7feee27d2c95178dfe5727f4148cdb
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Mon, 28 Nov 2016 07:29:20 +0000 (12:59 +0530)]
bug 6579 added basic unit tests
Added unit tests for the following commands
McastMacsRemoteUpdateCommand
UcastMacsRemoteUpdateCommand
LogicalSwitchUpdateCommand
When logical switch is configured ensure that op.insert is fired
same with mcast mac and ucast mac also.
Change-Id: Ie08664faa233776f82fb0a4ea8d6f0522a4b4810
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Vishal Thapar [Tue, 6 Dec 2016 17:53:45 +0000 (23:23 +0530)]
Add docs for OVSDB
This patch just initializes sphinx for OVSDB.
Refer: https://git.opendaylight.org/gerrit/#/c/39142/
Change-Id: I1e2b0c83941fdf2d1ab080863d6d6b3fc04e94b0
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Stephen Kitt [Wed, 7 Dec 2016 07:57:25 +0000 (08:57 +0100)]
Specify karaf dependency types
The -karaf projects only produce .zip and .tar.gz artifacts, so the
-it projects need to specify a type. (Our Nexus provides fake
dependencies to handle this type of situation, but local builds
without snapshot repositories fail.)
Change-Id: Icac98ceab94da4fc49862d5bddae04da4f4a0602
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Wed, 23 Nov 2016 13:58:24 +0000 (14:58 +0100)]
Checkstyle clean-up: Remove useless "final" in interfaces
The "final" in interfaces only shows up for me in Eclipse, but doesn't
fail the CLI build; I suspect that is becaues of a slightly different CS
version in-IDE and on CLI; on the next CS upgrade this probably would
have been seen in the build as well, and so it's good to clean it up.
Change-Id: Id235738c1217c32e16c756ad876672b609fd3172
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
K.V Suneelu Verma [Fri, 18 Nov 2016 07:21:45 +0000 (12:51 +0530)]
bug 7202 upon node reboot hwvtep op ds is missing
When the cluster is rebooted hwvtep operational datastore is not populated
for the existing clients.
Existing clients keep retrying , the moment 6640 port is up they establish
connection.
But by that time hwtep bundle is not up.
Eventually when the bundle is up it is only notified of future clients
only and not the already existing clients.
Change-Id: Ic816aea61c43000d7c8fbf14e51e0bcc5661664e
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Fri, 18 Nov 2016 06:18:18 +0000 (11:48 +0530)]
bug 7201 skip monitoring stats tables
skip monitoring stats table and version columns
which are generating huge traffic to controller
Change-Id: Icb84f92262d7e9464291a6f233a741a767d79003
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Josh [Sun, 30 Oct 2016 14:56:01 +0000 (16:56 +0200)]
Prep for provider network IT
1. Support for configuring OvsdbPing timeout (probably not necessary but
left it in anyway
2. Support for docker-compose version 2 yaml
3. Support for not specifying ovsdb.controller.address. If this env var
is not passed in, DockerOvs will create a docker network and use that
instead. See the javadoc in DockerOvs.java for more details.
Change-Id: Ife26f5f241ed6a45b00b15750a8ebafa471f8434
Signed-off-by: Josh <jhershbe@redhat.com>
Shashidhar Raja [Thu, 3 Nov 2016 12:22:03 +0000 (17:52 +0530)]
Corrected data type for "src-mac" in hwvtep.yang
Change-Id: I6c866000dc527cb24890a05890793a2deed5a664
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Tarun Thakur [Thu, 22 Sep 2016 07:45:24 +0000 (13:15 +0530)]
Bug 6851 fix: handling OtherConfig column clear
This fix would take care of updating datastore for the OVSDB Node
when 'other_config' column is cleared from openvswitch table.
Update to handle case OtherConfig column cleared
setOtherConfig() is updated to handle all cases to set OtherConfig
in Ovsdb node if present in OpenVSwitch new entry and to remove
OtherConfig from Ovsdb node if present in OpenVSwitch old entry.
Current method was missing the case when OtherConfig is cleared for
OVS table from switch. This case was generating the condition when
OtherConfig is NULL for OpenVSwitch new entry and OtherConfig is
non-NULL for OpenVSwitch old entry.
Change-Id: I366ce0f160079e211e5fe02b0e16c84df40d34cf
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
K.V Suneelu Verma [Tue, 16 Aug 2016 17:32:52 +0000 (23:02 +0530)]
bug 6643 hwvtep configuration reconcilation
Added operational node listener to trigger reconcillation
listens for physical switch node added event and schedules the reconcillation.
trigger transactions for changes in macs and logical switches and vlan bindings
trigger transactions for removal of local ucast and mcast macs aswell
so that to be deleted logical switches will not have any references
cancel the queued reconcilation task if any upon receiving node disconnect event
fixed some npes in mac remove commands
run the logical switch remove command post mac entries remove command as
those logical switches removed logical swithes have to be visible in the
other remove commands
validated the following test cases
1) disconnect the device and push the config (logical switch and remote
macs and vlan bindings ) and connect the device again
2) disconnect the device and delete some confing and connect the device
again
Change-Id: I12d0692e4c8b040f261a9c2cc5cffc05bef96f0d
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Hsin-Yi Shen [Mon, 19 Sep 2016 15:57:23 +0000 (08:57 -0700)]
Change cipher suites for SSL connection
Change the list of enabled protocls and cipher suites to meet FIPs security requirement.
Following protocols and cipher suites will be enabled:
ssl protocols [SSLv2Hello, TLSv1.1, TLSv1.2]
cipher suites [TLS_ECDH_RSA_WITH_AES_128_CBC_SHA256, TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA256,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,
TLS_RSA_WITH_AES_127_CBC_SHA256]
Change-Id: Ie257c8c89a789911255e92b54997b915deb6c2a4
Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>
Stephen Kitt [Fri, 16 Sep 2016 08:49:27 +0000 (10:49 +0200)]
Bug 6692: don't mock Optional
There's no need to ever mock Optional.
Change-Id: I31a875fc7c2201f066af057c616538a7a998ef7a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 15 Sep 2016 12:36:59 +0000 (14:36 +0200)]
Bug 6692: remove InstanceIdentifierCodec instance from SBU
Turn SouthboundUtil into a "clean" utility class: pull out all methods
involving InstanceIdentifierCodec.
Change-Id: I68f93fd7295b99ac6e29e4f7fcee744b38372630
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 21 Sep 2016 08:22:49 +0000 (10:22 +0200)]
Bug 6692: use non-deprecated firstKeyOf() variant
This patch also adds a cast in SouthboundUtilTest to fix a
false-positive deprecation detection.
Change-Id: I10fa53e40575c66de622887a84353abe2eba2786
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 23 Sep 2016 13:04:27 +0000 (15:04 +0200)]
Bug 5995: remove org.json
org.json doesn't seem to be used in ovsdb, remove it.
Change-Id: I5d09d5a6a860e91fa43affe83d322fbb3d5c7be9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Vishnoi [Fri, 16 Sep 2016 20:21:35 +0000 (20:21 +0000)]
Merge "Bug 6692: improve TyperUtils tests (first pass)"
Anil Vishnoi [Fri, 16 Sep 2016 20:12:54 +0000 (20:12 +0000)]
Merge "Bug 6692: clean up MonitorRequestBuilder"
Stephen Kitt [Mon, 5 Sep 2016 12:35:58 +0000 (14:35 +0200)]
Bug 6692: improve TyperUtils tests (first pass)
This also drops the unused type parameter on getTableSchema().
For now we preserve the IllegalArgumentException-based behaviour in
getTableSchema() (instead of handling the missing schema and returning
null).
Change-Id: If704a3d94694f44d6ccad6536cb230d09fa4e4b5
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 31 Aug 2016 16:36:58 +0000 (18:36 +0200)]
Bug 6692: clean up MonitorRequestBuilder
MonitorRequest can't be made immutable, so the utility of this builder
is to support fluent-style construction and addColumns() with multiple
columns. This patch removes unneeded methods from MonitorRequest,
drops the static builder() in favour of the constructor, adds support
for addColumns() with multiple strings, and constructs a new instance
for every call to build(). It also performs the skip cleanup in one
step instead of looping over the columns.
Change-Id: I89fd8a554551c3142efc82dbf6bb43417c6148ae
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Vishnoi [Sat, 10 Sep 2016 00:29:25 +0000 (00:29 +0000)]
Merge "Clean up SouthboundConstants"
Anil Vishnoi [Fri, 2 Sep 2016 06:21:13 +0000 (06:21 +0000)]
Merge "Fix clear bug related to "num" in JSON Node"
Sam Hague [Thu, 1 Sep 2016 13:46:06 +0000 (09:46 -0400)]
Bug 6486: get right docker instance
Change-Id: I7319674e4ed54f45582b4ccd38a48ddcdad51be4
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Wed, 31 Aug 2016 15:45:52 +0000 (17:45 +0200)]
Clean up SouthboundConstants
Remove the values in SKIP_OVSDB_TABLE, they aren't used; if any
complementary information needs to be provided, it should be done as
comments. (As it stands the information doesn't seem to be useful.)
Use the varargs variants of Arrays.asList() in SKIP_COLUMN_FROM_TABLE,
or Collections.singletonList() for single values.
Change-Id: I32f9dddaca922cd82cf4646aa6ebeb96e5546c3d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Tue, 30 Aug 2016 22:17:56 +0000 (18:17 -0400)]
Bug 6486: get right docker instance
Change-Id: I35d7e773dd4f9bccf46a790b6e3699166ba0b6a1
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Mon, 29 Aug 2016 19:48:29 +0000 (19:48 +0000)]
Merge "Bug 5555: Exception during operations on ReadWriteTransaction"
Michael Vorburger [Fri, 22 Jul 2016 22:07:53 +0000 (00:07 +0200)]
Fix clear bug related to "num" in JSON Node
Before this change, getConstraints() would call populateEnum() which
would ... do nothing, ultimately; this was pointless, as it is currently
implemented.
I'm assuming here that the code was meant to do what I turned it into,
but I don't understand enough of this code to be certain. I've also NOT
tested this in any way. It does kind of seem reasonable though, looking
at what the lines before in getConstraints do.
An alternative would be to just remove those populateEnum methods - if
they do nothing, and there is no real bug here, then that was just dead
code. More likely, I suspect it is a real bug that hasn't been found
yet.
I'll try to add FindBugs error detection for such cases in the future -
UC_USELESS_OBJECT is exactly for finding these kind of programming
errors, AFAIK.
Change-Id: I587e053b5145320b600e2db0109118d799da8822
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Hideyuki Tai [Thu, 25 Aug 2016 13:45:44 +0000 (06:45 -0700)]
Fixed inappropriate WARN message.
The plugin output the following inappropriate WARN message sometimes.
Found non-topological node Optional.absent() on path {}
This patch fixed the inappropriate message, and changed the log level
from WARN to DEBUG because it is a debug information.
Other change:
Modified the code which used Optional<> in an ineffective way.
Change-Id: I714a10b509e9a88676e910ec9fba717800c52272
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
Sam Hague [Fri, 26 Aug 2016 01:23:08 +0000 (21:23 -0400)]
Bug 6486: Add support for two node DockerOvs
Change-Id: I61996cc2bc5b573309f6c389c670e09540aa2710
Signed-off-by: Sam Hague <shague@redhat.com>
K.V Suneelu Verma [Tue, 16 Aug 2016 17:23:48 +0000 (22:53 +0530)]
Bug 5555: Exception during operations on ReadWriteTransaction
An IllegalStateException can be happened during operations on
ReadWriteTransaction. This was resulting in system not being able to
process any southbound ovsdb events, since the code didn't handle this
exception.
Change-Id: I24ab3acc01fd5fb4d9380ccc8bcc7d332738d242
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Sam Hague [Tue, 23 Aug 2016 16:24:41 +0000 (16:24 +0000)]
Merge "Bug 6505 - blueprint managed-property is not reading the .cfg file during the reboot."
Anil Vishnoi [Tue, 23 Aug 2016 08:00:04 +0000 (08:00 +0000)]
Merge "Bug 6475: Removed unnecessary read operations."
Anil Vishnoi [Mon, 22 Aug 2016 21:25:30 +0000 (14:25 -0700)]
Bug 6505 - blueprint managed-property is not reading the .cfg file during the reboot.
Change-Id: Ifb70a789e809ff5ecaa1cf138fa915606f530bfd
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Peng Zhang [Thu, 18 Aug 2016 03:10:55 +0000 (11:10 +0800)]
Bug 6506: Add bridge stp_enble to ovsdb.yang
We can use command "ovs-vsctl" to enbale spanning tree protocol on a bridge,
e.g., "ovs-vsctl set Bridge br0 stp_enable=true". But there is missing the
stp_enble in ovsdb.yang.
Change-Id: Ied5c093fb739f220fe673c80cd74cf84be7e0c0b
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>
Hideyuki Tai [Thu, 18 Aug 2016 20:51:11 +0000 (13:51 -0700)]
Bug 6475: Removed unnecessary read operations.
Some classes always read data from MD-SAL even in the case they don't
use these data. This patch modified these classes to remove unnecessary
read operations.
Other change:
* Removed unused members
- updatedOpenVSwitchRows from OvsdbQosRemovedCommand.java
- updatedOpenVSwitchRows from OvsdbQueueRemovedCommand.java
Change-Id: I53af02892bbfbb8f4f95ab94d988825fbc832f1b
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
Sam Hague [Mon, 22 Aug 2016 02:02:51 +0000 (22:02 -0400)]
Bug 6486 - Add waits for IT Utils
Change-Id: I9e537ecf65cf4c88408213760b8119b7be709505
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sat, 20 Aug 2016 01:36:39 +0000 (21:36 -0400)]
Bug 6486 - Add waits for IT Utils
Change-Id: Ieea6276eda62f4b437436bf73336c8dea2aa0c0b
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 19 Aug 2016 22:01:19 +0000 (22:01 +0000)]
Merge "Bug 6472 - JsonRpcEndpoint Reaper Thread's daemon property is not set"
Victor Pickard [Fri, 19 Aug 2016 20:12:27 +0000 (16:12 -0400)]
BUG 6467: Add cli flag to use virtual environment
Add a trailing "/" to $WORKSPACE being passed in.
Works a little different in jenkins than on
local machine.
Change-Id: I1a12aa0a7f10a1fe621a1bf7c8def203630297be
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Victor Pickard [Fri, 19 Aug 2016 18:03:34 +0000 (14:03 -0400)]
BUG 6467: Add cli flag to use virtual environment
This change is a followup to patch:
https://git.opendaylight.org/gerrit/#/c/44022/
Add cli flag for virtual environment
Docker-compose is installed in a virtual environment on Jenkins.
Add a cli flag to enable switching to a virtual environment, if needed.
Netvirt IT requires docker-compose, so the netvirt IT jenkins
script will set this flag: -Ddocker.vEnvWs=$WORKSPACE
Change-Id: I989d071ef2303f4b4813c3145435b2ddb785a228
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Anil Vishnoi [Thu, 18 Aug 2016 23:23:47 +0000 (16:23 -0700)]
Bug 6472 - JsonRpcEndpoint Reaper Thread's daemon property is not set
Change-Id: I0cfd2a192eed62eab988831398f8f8e89876417e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Thu, 18 Aug 2016 15:58:26 +0000 (15:58 +0000)]
Merge "Add cli flag for virtual environment"
Sam Hague [Thu, 18 Aug 2016 12:31:42 +0000 (12:31 +0000)]
Merge "Bug 6454: ProcUtils stdout should be grouped together"
Sam Hague [Wed, 17 Aug 2016 21:34:21 +0000 (17:34 -0400)]
Bug 6454: ProcUtils stdout should be grouped together
Change-Id: I559d66666c7f8af05f3f380ed9a90c77b1437691
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Thu, 18 Aug 2016 10:04:11 +0000 (03:04 -0700)]
Bug 6463 - Monitoring _version column on the ovsdb
table is generating huge updates from switch
Change-Id: I421d2af0adabb2197af7ec2ccb68a2e95e58d2e1
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Vishal Thapar [Tue, 19 Jul 2016 16:19:25 +0000 (21:49 +0530)]
Filter out monitor updates for some columns
This filters out statistics and _version columns from all tables
when setting up monitoring for table updates.
This also filters out status column for Controller table.
Change-Id: I3ed875a6070c2ce61ab8ecf626a6856f99f8179f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Victor Pickard [Mon, 15 Aug 2016 21:55:10 +0000 (17:55 -0400)]
Add cli flag for virtual environment
Docker-compose is installed in a virtual environment on Jenkins.
Add a cli flag to enable switching to a virtual environment, if needed.
Netvirt IT requires docker-compose, so the netvirt IT jenkins
script will set this flag: -DuseVenv=true
Change-Id: Ie66e274dd10f1cefcbe134d837faea7c52a55013
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Anil Vishnoi [Wed, 17 Aug 2016 11:41:57 +0000 (04:41 -0700)]
Bug 6332 - Conflicting modification Exception for topology path
Change-Id: Id7e8403c666689042eb73066f6203bb8edec0b41
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Akash [Thu, 11 Aug 2016 06:54:01 +0000 (12:24 +0530)]
Bug 6336 using single tx for logical switch, macs
To handle the issue if logical switch is not present in OP tree then
logical siwtch name will be fetch from instanceIdentifier sub node as part
of the function getLogicalSwitchUUID in TransactUtils.java class.
Change-Id: Id3addade78464f967019c9c87053856bb111aed4
Signed-off-by: Akash <a.k.sahu@ericsson.com>
Thanh Ha [Mon, 8 Aug 2016 21:50:19 +0000 (17:50 -0400)]
Bump versions by 0.1.0 for next dev cycle
Change-Id: Ic49b3af15fcadabc68d88eb0c891bf6c36eff192
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Sam Hague [Mon, 8 Aug 2016 18:02:08 +0000 (18:02 +0000)]
Merge "Bug 6352 - [SR3] RPC timeout in JsonRPCEndpoint is not configurable"
Anil Vishnoi [Sun, 7 Aug 2016 02:23:41 +0000 (19:23 -0700)]
Bug 6352 - [SR3] RPC timeout in JsonRPCEndpoint is not configurable
Change-Id: I4d35c64d61a6732441a942abd4a766551506f2d5
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Robert Varga [Thu, 4 Aug 2016 10:35:26 +0000 (12:35 +0200)]
Switch from yangtools to mdsal binding APIs
This reflects the move of these interfaces from yangtools
to mdsal.
Change-Id: I5532deea7396104a4a850124f9a0ca21c8f275af
Signed-off-by: Robert Varga <rovarga@cisco.com>
Anil Vishnoi [Fri, 5 Aug 2016 21:12:39 +0000 (21:12 +0000)]
Merge "added support for switch/port fault status for hwvtep schema changes."
Anil Vishnoi [Thu, 4 Aug 2016 21:12:08 +0000 (21:12 +0000)]
Merge "Docker-compose files for hwvtep IT, ovs 2.4/2.5"
Anil Vishnoi [Thu, 4 Aug 2016 19:47:30 +0000 (19:47 +0000)]
Merge changes from topic 'move-karaf-parent'
* changes:
Bug 6278: Switch to use odlparent's karaf-parent
Bug 6278: Switch to use odlparent's karaf-parent
ENIAGUA [Fri, 29 Jul 2016 09:18:15 +0000 (14:48 +0530)]
added support for switch/port fault status for hwvtep schema changes.
Change-Id: I2e66a9dc8f71393168daf0f14e7f1563c4fae1ed
Signed-off-by: ENIAGUA <nishchya.gupta@ericsson.com>
Josh [Wed, 3 Aug 2016 16:04:22 +0000 (18:04 +0200)]
Docker-compose files for hwvtep IT, ovs 2.4/2.5
Change-Id: Id1b38786f78ee9f9b22e6168c99d9ac3988fc678
Signed-off-by: Josh <jhershbe@redhat.com>
Anil Vishnoi [Thu, 4 Aug 2016 00:12:23 +0000 (00:12 +0000)]
Merge "Bug 6278: Switch to use odlparent's karaf-parent"
Anil Vishnoi [Thu, 4 Aug 2016 00:12:08 +0000 (00:12 +0000)]
Merge "Bug 6278: Switch to use odlparent's karaf-parent"
Ryan Goulding [Wed, 3 Aug 2016 16:38:16 +0000 (12:38 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent
Change-Id: I0052370159e7a061bc7aa2566907549b8c416208
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Josh [Tue, 2 Aug 2016 15:15:31 +0000 (17:15 +0200)]
bug-6326 Modify config, not operational version
pull bridge from config before modifying
+ only write controllers that don't already exist
Change-Id: I6f6d2a9fa33459988da8450065714ec86eab5781
Signed-off-by: Josh <jhershbe@redhat.com>
Anil Vishnoi [Mon, 1 Aug 2016 19:29:47 +0000 (19:29 +0000)]
Merge "Bug 5951 - Termination point config reconciliation"
Vinh Nguyen [Fri, 17 Jun 2016 19:06:01 +0000 (12:06 -0700)]
Bug 5951 - Termination point config reconciliation
Add termination point configuration reconciliation logic
to southbound plugin.
When the OVS switch connects to the ODL, the list of all bridge
and termination point configurations in the config datastore
is obtained. We then listens for any new bridge creations in the
operational DS. If the newly created bridge is in the above described
list, termination point reconciliation is triggered for that bridge.
This is the solution for reconciliation scenarios #5 and #7 in:
https://wiki.opendaylight.org/view/OVSDB_Integration:OVSDB_SB_Reconciliation
Change-Id: Ie0fc8bcbd12a5c1dd763a580db7097a4afd7e01a
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
Josh [Thu, 28 Jul 2016 11:13:33 +0000 (13:13 +0200)]
Add various methods to SouthboundUtils
These are required by netvirt for vlan
and tunnel support
Change-Id: Ied88f25ca4c22babaedb95bc2bea9190f41d3d29
Signed-off-by: Josh <jhershbe@redhat.com>
Anil Vishnoi [Fri, 29 Jul 2016 19:27:34 +0000 (19:27 +0000)]
Merge "Add getTerminationPointOfBridge method to SouthboundUtils"
Vishal Thapar [Fri, 29 Jul 2016 08:34:05 +0000 (08:34 +0000)]
Merge "Bug 6304 - Regression in Connection reconciliation functionality"
Anil Vishnoi [Fri, 29 Jul 2016 04:35:07 +0000 (21:35 -0700)]
Bug 6304 - Regression in Connection reconciliation functionality
After enabling the checkstyle, we start catching the
specific exceptions rather then catching all the exception
using Exception. During the retry, connection task encounters
ConnectionException, but nobody catches that exception and
it kills the reconciliation thread, so it does not retry
the connection after first attempt. This patch fixes this
issue and handles the ConnectionException properly.
Change-Id: I0e1f71ea6fa550df484ade9036f7dfe6c9dfa57e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Thu, 28 Jul 2016 07:27:13 +0000 (00:27 -0700)]
Bug 6284 - Cancellation exceptions during operation execution
Change-Id: Icacfa535dc4ac3aa146ab73d363a9888542e3a8e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Ryan Goulding [Thu, 28 Jul 2016 16:03:55 +0000 (12:03 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent
Change-Id: Ib10f2a4ddeeda607890145cbe277d72c4ebf3d6e
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Ryan Goulding [Thu, 28 Jul 2016 16:03:28 +0000 (12:03 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent
Change-Id: Iafc12b95e41de5b043648149be9eade00773f82b
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Ryan Goulding [Thu, 28 Jul 2016 16:02:51 +0000 (12:02 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent
Change-Id: I0781e8ae2b14af68e32d3048fe17370cca276425
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Oded Shvartz [Thu, 28 Jul 2016 12:59:23 +0000 (15:59 +0300)]
Add getTerminationPointOfBridge method to SouthboundUtils
instead of duplicating the method for the new netvirt project
the method was added to SouthboundUtils.
Change-Id: Idda2640c80fbbb96a03a5f4f248ccb87ed1c65a2
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>
vinoth [Wed, 22 Jun 2016 13:47:20 +0000 (19:17 +0530)]
BUG-6136 - Southbound plugin throws IllegalStateException when add bridge config via POST.
* Checking isPresent() while reading a OvsdbBridgeAugumentation value.
Change-Id: I1ac53efca678c9e40f46f5e86595b0c1d9e8bc62
Signed-off-by: vinoth <m.vinoth@hcl.com>
Sam Hague [Sat, 23 Jul 2016 19:26:23 +0000 (19:26 +0000)]
Merge "Checkstyle fixes (to be enforced)"
Sam Hague [Sat, 23 Jul 2016 13:58:13 +0000 (13:58 +0000)]
Merge "Add support for setting the db schema version"
Sam Hague [Fri, 22 Jul 2016 01:38:49 +0000 (21:38 -0400)]
Add support for setting the db schema version
The db schema was a field in the ovsdb.yang but it was never copied
from the ovsdb to mdsal.
Also removed IT test code that was getting the schema version
via connecting to the ovsdb nodes.
Change-Id: Id7a49f9832c27eec746aeff9d190e9295dbd3244
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Fri, 22 Jul 2016 21:05:19 +0000 (23:05 +0200)]
Checkstyle fixes (to be enforced)
preparing for https://git.opendaylight.org/gerrit/#/c/41305/ with:
* Utility classes should have private constructor
* potential future problems re. hidden fields
* inner assignments
Change-Id: I616414ed56e468910167a790b5e67a6807600f37
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Fri, 22 Jul 2016 19:28:49 +0000 (15:28 -0400)]
Fixes for HwvtepSouthboundIT to run
Change-Id: I12adb6221e18fd5d80c9b053c4f03b7d1d79b730
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 22 Jul 2016 16:56:54 +0000 (12:56 -0400)]
Checkstyle fixes for ovsdb test dirs
Change-Id: I96d5843f9b26463f89e54992aea34b2438b571d4
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Thu, 21 Jul 2016 16:08:28 +0000 (18:08 +0200)]
Fix more Sonar (soon Checkstyle) constant name
Change-Id: I503e402c80d57c946805385ac542b992eed1cf8a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>