Sam Hague [Wed, 9 Aug 2017 12:31:45 +0000 (12:31 +0000)]
Merge "Bug 8882 - With conntrack SNAT communication with PNF fails "
Faseela K [Wed, 9 Aug 2017 07:16:51 +0000 (07:16 +0000)]
Merge "Add private constructor to this utility class"
Faseela K [Wed, 9 Aug 2017 07:11:45 +0000 (07:11 +0000)]
Merge "Cleanup"
Faseela K [Wed, 9 Aug 2017 06:57:34 +0000 (06:57 +0000)]
Merge "Changing the default value of Interfacemanager statistics polling interval to 15 Minutes"
Sam Hague [Tue, 8 Aug 2017 18:39:26 +0000 (18:39 +0000)]
Merge "BUG 8876 - Fix to remove ELAN interface flows when external network deleted"
Aswin Suryanarayanan [Tue, 8 Aug 2017 17:18:21 +0000 (22:48 +0530)]
Bug 8882 - With conntrack SNAT communication with PNF fails
Make the load metadata start and end bit configurable.
Change-Id: If4ed5e311b249dbff942a936caaa5556d6c933fd
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Faseela K [Tue, 8 Aug 2017 10:45:36 +0000 (10:45 +0000)]
Merge "Add GPE option to ITM config"
Akash Kumar Sahu [Fri, 17 Mar 2017 06:48:54 +0000 (12:18 +0530)]
Bug 7599 -hwvtep ucast mac consumption improvement
Caching ITM External Tunnels so that it would be faster to get from cache
then to read from Data store.
Change-Id: Iac67eb65ac546cf1c197cedd5e039b06d54ab2af
Signed-off-by: Akash Kumar Sahu <a.k.sahu@ericsson.com>
Faseela K [Mon, 7 Aug 2017 17:35:26 +0000 (17:35 +0000)]
Merge "Bug 8859 : Table 220 programmed with wrong service-index"
Faseela K [Mon, 7 Aug 2017 10:10:13 +0000 (10:10 +0000)]
Merge "IdManager: Use lock only when required"
Gowri R [Mon, 7 Aug 2017 08:47:17 +0000 (14:17 +0530)]
Changing the default value of Interfacemanager statistics polling interval to 15 Minutes
Change-Id: Ia7dbc21971e60fd788956876b8457cbdc989a88a
Signed-off-by: Gowri R <gowri.r@ericsson.com>
Faseela K [Mon, 7 Aug 2017 08:48:15 +0000 (08:48 +0000)]
Merge "Make DJC to be more concurrent and fixing signal issue b/w enqueue jobs"
Faseela K [Fri, 4 Aug 2017 18:34:21 +0000 (00:04 +0530)]
Bug 8859 : Table 220 programmed with wrong service-index
Fix synchronization issues with service binding transaction submissions
Change-Id: I1cab1590b7333513f079f062c07de483895c316c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Vinh Nguyen [Thu, 3 Aug 2017 19:28:26 +0000 (12:28 -0700)]
BUG 8876 - Fix to remove ELAN interface flows when external network deleted
Add check for null when getting Interface object from Config DS.
This changeset is related to the patch:
https://git.opendaylight.org/gerrit/#/c/61131/
Change-Id: I57bb96081afcc114346dfea08521ab0df7f9b8e8
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
Aswin Suryanarayanan [Fri, 28 Jul 2017 12:16:48 +0000 (17:46 +0530)]
Bug 8882 - With conntrack SNAT communication with PNF fails
Added support for load metadata action.
depends on https://git.opendaylight.org/gerrit/#/c/60869
Change-Id: Iafa22368dbeea9e76b3d5f5f43ae5f615f476bcc
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
epgoraj [Tue, 4 Jul 2017 05:14:12 +0000 (10:44 +0530)]
Make DJC to be more concurrent and fixing signal issue b/w enqueue jobs
and job queue handler
Change-Id: I7bfbd15f7a8fa1b80555a0a99689a536a4896c8e
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Kency Kurian [Mon, 10 Jul 2017 11:03:48 +0000 (16:33 +0530)]
IdManager: Use lock only when required
It was observed that there were more than one thread waiting to acquire
lock for the uniqueKey. This can be avoided since there is a local map
which tracks the idValue allocated for every request until the idValue
is persisted in the DS.
During testing, there were some conflictModificationExceptions thrown.
This was because the arrayList for delayedIdEntries were not set as
CopyOnArrayList at certain places.
Also have done some refactoring for allocateIdFromLocalPool()
Change-Id: I5b24b2a5d4ebe809d7217a509c74750b0d399f9c
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Faseela K [Thu, 3 Aug 2017 08:33:34 +0000 (14:03 +0530)]
Fix Service-binding flowRef
Change-Id: Ica70eaeafde21531d8b77fe3a8911af9adffe017
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Wed, 2 Aug 2017 10:50:08 +0000 (12:50 +0200)]
Cleanup
- Add private constructor to utility class
- Remove useless code
- Replace size() == 0 by is empty.
Change-Id: I6bf50f41f3a018c6dbc92ab825de5b82be94366a
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
David Suarez [Wed, 2 Aug 2017 08:36:16 +0000 (10:36 +0200)]
Add private constructor to this utility class
Add private constructor to this utility class.
Change-Id: I6e769e388156db70db42841d5f58e68a5e81377d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Mon, 31 Jul 2017 19:28:09 +0000 (00:58 +0530)]
Fix IfmClusterUtils logs
Change-Id: I93d84a162ffcf61847b1ccb2a0a69aa803462963
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Fri, 28 Jul 2017 07:19:47 +0000 (07:19 +0000)]
Merge "Enqueued Job not getting cleaned up in some cases"
Vishal Thapar [Thu, 27 Jul 2017 21:40:34 +0000 (21:40 +0000)]
Merge "Remove derivation from controller config-parent"
Michael Vorburger [Thu, 27 Jul 2017 18:12:54 +0000 (18:12 +0000)]
Merge "Avoid .transform() NPEs"
Michael Vorburger [Thu, 27 Jul 2017 14:53:48 +0000 (14:53 +0000)]
Merge "hwvtep transaction batching separation across shards"
Vishal Thapar [Thu, 27 Jul 2017 14:45:29 +0000 (14:45 +0000)]
Merge "Bug 8476 Add support for logical switch replication mode"
Michael Vorburger [Thu, 27 Jul 2017 14:39:28 +0000 (14:39 +0000)]
Merge "Change method names to comply with naming conventions"
Vishal Thapar [Thu, 27 Jul 2017 14:35:19 +0000 (14:35 +0000)]
Merge "Guard some TRACE logs in DJC"
Vishal Thapar [Thu, 27 Jul 2017 14:34:10 +0000 (14:34 +0000)]
Merge "Add a private constructor to avoid instantiation"
Vivek Srivastava [Thu, 27 Jul 2017 14:30:35 +0000 (14:30 +0000)]
Merge "Remove un-used TestDataStoreJobCoordinator"
Vishal Thapar [Thu, 27 Jul 2017 14:29:20 +0000 (14:29 +0000)]
Merge "Remove un-used newWriteOnlyTransaction() in removeTerminationEndPoint()"
Jaime Caamaño Ruiz [Thu, 1 Jun 2017 10:20:54 +0000 (12:20 +0200)]
Add GPE option to ITM config
Add a GPE option on ITM config as a straight forward way to enable the
VXLAN GPE extension system wide.
Change-Id: I3cf5ce42cddef15c071a0b80ab0cc95a83e2b4d1
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
Victor Pickard [Tue, 16 May 2017 20:32:07 +0000 (16:32 -0400)]
Bug 8476 Add support for logical switch replication mode
With OVS 2.6, the Logical Switch table, in the hardware_vtep schema, has
a new field, replication_mode. This bug will be used to add support to
netvirt, ovsdb, and genius for setting the replication_mode of logical
switches. The default will be for ODL to set the replication_mode
to "source_node" when creating logical switches.
Refer to [1] for more details on replication_mode.
[1] http://openvswitch.org/support/dist-docs/vtep.5.html
This patch depends on ovsdb patch:
https://git.opendaylight.org/gerrit/#/c/57209/
Change-Id: I538634a791f73d60b5a9c7cc479f4c42847889bd
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Vishal Thapar [Thu, 13 Jul 2017 00:01:01 +0000 (05:31 +0530)]
Capture flow addition to debug log
debug log any flows that get added to config DS
trace log flow deletion
Change-Id: Ic15db83a08fca26b01b3c89ebf910d5dbff0be91
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
David Suarez [Sun, 23 Jul 2017 20:44:03 +0000 (22:44 +0200)]
Change method names to comply with naming conventions
Change method names to comply with naming conventions.
And minor cleanup.
Change-Id: Ia68f1484a4574d1a639fd93856579ff79ed19024
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Tom Pantelis [Fri, 21 Jul 2017 17:42:17 +0000 (13:42 -0400)]
Remove derivation from controller config-parent
Genius does not use the config subsystem so does nto need to
derive from controller config-parent.
Change-Id: I9dbe6f0e53c2f6d8848d2a56538e81e0fe99a275
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
David Suarez [Sun, 23 Jul 2017 15:44:56 +0000 (17:44 +0200)]
Add a private constructor to avoid instantiation
Add a private constructor to avoid instantiation of this utility class.
Change-Id: I0a44ac809b9a5e303b30b8927c0c1e334a7cb8c1
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Stephen Kitt [Mon, 3 Jul 2017 13:23:01 +0000 (15:23 +0200)]
Avoid .transform() NPEs
Guava’s Optional::transform doesn’t support null values returned by
the mapping function — it throws a NPE if that happens. java.util’s
Optional::map does support null values and returns an empty Optional.
Combined with the current YANG-based code’s ability to return null,
this means it’s better to use java.util’s method; this patch switches
all YANG-based Optional transforms to java.util.
Change-Id: I8b26820ce5627e9ee950baee6d99a315e9e3494e
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Thu, 20 Jul 2017 09:21:03 +0000 (14:51 +0530)]
Enqueued Job not getting cleaned up in some cases
Jobs were not getting cleaned up from JobQueue in case of Throwables.
This results in some residual jobs remaining in the JobQueue forever,
and unnecessarily hogging CPU.
Change-Id: I4d910592a4d2da45fed0767b23bfbe4bb31cdee1
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Thu, 20 Jul 2017 08:13:13 +0000 (08:13 +0000)]
Merge "Port Number Change on OVS restart not handled by IFM"
Faseela K [Wed, 12 Jul 2017 09:35:07 +0000 (15:05 +0530)]
hwvtep transaction batching separation across shards
Hwvtep helpers were doing a single transaction for operations
spread across shards, which is not recommended, and hence refactoring
the same. Also, in case of continuous HWVTEP channel flap, there are
some issues observed with tunnels not getting programmed on TOR.
Fixing this by avoiding read on topology/oper DS to derive global nodeId.
Change-Id: I7153c8e30dd66d6474125b83dfd3f13f0b760d01
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Sat, 15 Jul 2017 08:54:46 +0000 (14:24 +0530)]
@Ignore flaky newl2vlanInterfaceTests InterfaceManagerConfigurationTest
Change-Id: Icca2e7ecfd93e12bc867885fd1f547a5aae0932f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 13 Jul 2017 19:40:46 +0000 (01:10 +0530)]
Remove un-used newWriteOnlyTransaction() in removeTerminationEndPoint()
Change-Id: If95dfdbdb777c71f19c715f96677d5f523f83eb5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 13 Jul 2017 11:39:03 +0000 (17:09 +0530)]
Remove un-used TestDataStoreJobCoordinator
The TestDataStoreJobCoordinator is not used anymore anywhere in genius
and netvirt, and can and should thus be removed now.
It was my first take on the async test problem, but it has since been
replaced by the
org.opendaylight.genius.datastoreutils.testutils.TestableJobCoordinatorEventsWaiter,
which it *IS* actively used e.g. in genius' interfacemanager and
netvirt's aclservice component tests.
Change-Id: I882e8e943195e39399cb4c972bff85f34c91cf62
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Thu, 13 Jul 2017 14:44:55 +0000 (14:44 +0000)]
Merge "Fix missing getter and toString in ActionNxResubmit & tests for it"
Michael Vorburger [Tue, 11 Jul 2017 21:24:56 +0000 (02:54 +0530)]
Fix missing getter and toString in ActionNxResubmit & tests for it
This fixes a problem in TestIMdsalApiManager related to xtendbeans hit
in a failure of aclservice's
AclServiceStatelessTest>AclServiceTestBase.newInterface.
Also ActionLearn, ActionOutput & ActionNxConntrack, ActionSetArpOp,
ActionSetDestinationIp. ActionSetFieldDscp, ActionSetFieldMeta,
ActionSetFieldMplsLabel, ActionSetFieldPbbIsid, ActionSetFieldVlanVid,
ActionSetTunnelDestinationIp, ActionSetTunnelSourceIp all similarly
broken for xtendbeans tests due to missing getters - it would never have
correctly shown differences in these, and just silently ignored any.
as well as further missing correct overloaded toString() in ActionGroup,
ActionRegLoad, ActionLoadIpToSpa, ActionLoadMacToSha,
ActionNxLoadInPort, ActionRegMove, ActionSetDestinationIp,
ActionSetFieldEthernetDestination, ActionSetFieldEthernetSource,
ActionSetFieldTunnelId, ActionSetIcmpType, ActionSetIcmpv6Type,
ActionSetSourceIp, ActionSetSourceIpv6, ActionSetTcpDestinationPort,
ActionSetTcpSourcePort, ActionSetUdpDestinationPort and
ActionSetUdpSourcePort.
Change-Id: Id7adf0786dfda5f3be53c980a109a0d8d911ada5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 4 Jul 2017 06:33:50 +0000 (12:03 +0530)]
Exception in service-binding logic when a neutron port is deleted
With the recent changes in ACL, deletion of a vpninterface triggers
an unbind and bind of ACL service. Parallelly interface-config
delete triggers one more unbind of ACL service, and the final unbind
results in NPEs in service-binding logic. The last unbind is anyways
a NOP, and hence returning with an ERROR message. Whenever ACL improvises
their logic, this ERROR will also automatically go away.
Change-Id: Ib28794ef5b6ace7a8759be9c6b2c8e9ef9c9793e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 12 Jul 2017 07:18:58 +0000 (12:48 +0530)]
Port Number Change on OVS restart not handled by IFM
If port number for an interface changes on OVS restart, interface-manager
was not handling the same, and this results in stale entries remaining in
interface-state DS. Making the code robust to handle OF port number
updates.
Change-Id: If5cd5d9a6643a2bd67a500530ecc9f0bf2dfbd5c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 12 Jul 2017 07:14:04 +0000 (07:14 +0000)]
Merge "VM Migration: Handle VM migration only for OFPT_PORT_STATUS/OFPPR_ADD"
Sam Hague [Tue, 11 Jul 2017 21:32:57 +0000 (21:32 +0000)]
Merge "Bug 8677: Bump odlparent from 2.0.0 to 2.0.2"
Tom Pantelis [Tue, 11 Jul 2017 17:53:16 +0000 (13:53 -0400)]
Bug 8163: Use async DTCL verification in MdSalUtilTest
https://git.opendaylight.org/gerrit/#/c/60022/ is changing the
DTCL executor to MT so the DTCL verification in MdSalUtilTest needs
to be done asynchronously instead of assuming direct notification.
Change-Id: Ib099d0ed807ae2fe8cb978b787bef0b84c0951ff
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Faseela K [Tue, 11 Jul 2017 12:26:05 +0000 (17:56 +0530)]
Guard some TRACE logs in DJC
Change-Id: I04b7496efbdb3e4859b62cf98c542262683d6052
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Tue, 11 Jul 2017 09:21:13 +0000 (09:21 +0000)]
Merge "Bug 8800: TestIMdsalApiManager assertFlowsInAnyOrder fail safe"
Michael Vorburger [Tue, 4 Jul 2017 09:26:50 +0000 (11:26 +0200)]
Bug 8677: Bump odlparent from 2.0.0 to 2.0.2
This lets Windows users build Karaf distributions
locally more easily (without requiring Git Bash/Cygwin).
see https://lists.opendaylight.org/pipermail/odlparent-dev/2017-June/001154.html
Change-Id: Idddf44e8cf63b8266ce8049cbe3a52b8a8a543ba
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vishal Thapar [Fri, 7 Jul 2017 15:34:49 +0000 (15:34 +0000)]
Merge "Removing unnecessary TRACE log in service-binding"
Michael Vorburger [Tue, 4 Jul 2017 22:20:11 +0000 (00:20 +0200)]
Bug 8800: TestIMdsalApiManager assertFlowsInAnyOrder fail safe
It *MUST* fail in case that:
assertThat(sortedFlows).containsExactlyElementsIn(sortedExpectedFlows);
failed but:
assertEqualBeans(sortedExpectedFlows, sortedFlows);
passed; any such case is likely a bug in ch.vorburger.xtendbeans.
netvirt aclservice tests (or their expected flows) must be fixed before
this change can be merged. This doesn't fix anything, it would just let
us discover this kind of problem much earlier, if things ever broke
again.
The new FlowEntityAssertBeansTest adds a non-regression test for the
reoot cause problem; it fails as of the time of writing, but will pass
once the ch.vorburger.xtendbeans dependency is bumped from 1.2.3 to the
1.3.0 in https://git.opendaylight.org/gerrit/#/c/59950.
See bug 8800 for full background and details.
Change-Id: I1e67a8cd1401d6490538742d4100a8a2be2630c5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Fri, 7 Jul 2017 10:02:34 +0000 (15:32 +0530)]
Removing unnecessary TRACE log in service-binding
This TRACE log is printing the whole tree of a change notification.
There are other informative logs already in place after the initial
processing, and this one is not needed.
Change-Id: I5063c5b88de602065eaf294fb100ae92ba057d16
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Tue, 4 Jul 2017 06:40:18 +0000 (12:10 +0530)]
Making ActionConverterUtil log to DEBUG
As these logs are filling up netvirt CSIT logs
Change-Id: I3b1225d484693dad4d9dc664760a4125ff8bd20e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Tue, 4 Jul 2017 22:45:57 +0000 (00:45 +0200)]
Bug 8800: Prevent xtendbeans NPE warn.log in InstructionApplyActions
Change-Id: I0e5c018231a79a5970efe862d62aaedfc091ebfd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 4 Jul 2017 07:18:56 +0000 (12:48 +0530)]
Remove odl-genius-ui from artifacts and features
Change-Id: Idc40abbd996ac968f35706c29de9a510abab3d4c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 28 Jun 2017 17:42:49 +0000 (23:12 +0530)]
DO NOT install or deploy the karaf artifact
Change-Id: I664de7a1cf122b5e465df4a5c9ec1c0cf55d16d3
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Jaime Caamaño Ruiz [Mon, 22 May 2017 14:23:26 +0000 (16:23 +0200)]
BUG 8528: Fix duplicate Apply Actions Instruction
When an egress service sends it's own Apply Actions instruction, Genius
will generate two Apply Actions instructions southbound, one of it's
own containing the action to set REG6 and a different one containing the
service supplied actions. This is not correct per Openflow specification
and OVS rejects the operation.
Fixed by bundling the set REG6 action and the service provided
actions into the same Apply Actions instruction, taking care of
not rearranging the order of the service actions.
Change-Id: I48735857418fed0025b172b73eb02be9c8e9bbbe
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
Vishal Thapar [Wed, 21 Jun 2017 15:23:37 +0000 (20:53 +0530)]
Upgrade to odlparent 2.0.0, karaf4 and Guava21
1. Change odlparent-lite to 2.0.0
2. Delete genius-features and rename features4-genius to genius-features
3. Change single-feature-parent to 2.0.0
4. Cleanup in karaf/pom.xml for karaf4
5. Fixes for Guava21
6. Removed odl-genius-ui feature, removing dependency on dlux
Change-Id: I62c4a791d658e74f7347cc03aafb24c999c85a7f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Michael Vorburger [Tue, 20 Jun 2017 17:58:48 +0000 (17:58 +0000)]
Merge "Genius wide blueprint xml path change: /OSGI-INF/ -> /org/opendaylight/"
Michael Vorburger [Tue, 20 Jun 2017 15:42:07 +0000 (15:42 +0000)]
Merge "avoiding logging full stack trace in case of id doesn't exist"
Abhinav Gupta [Tue, 20 Jun 2017 08:52:55 +0000 (14:22 +0530)]
Genius wide blueprint xml path change: /OSGI-INF/ -> /org/opendaylight/
Also have removed fake "availability=optional"
Change-Id: Ia4c21bbba98f01d938c97990f2a02dd9996a8490
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Stephen Kitt [Tue, 20 Jun 2017 08:26:13 +0000 (10:26 +0200)]
Don’t load odl-genius-ui on boot
This drops odl-genius-ui as the Karaf 4 distribution’s local feature,
so that it’s no longer loaded as a boot feature. The Genius feature
repository will still be part of the distribution.
Change-Id: I3da7ebf2771235bbd86cfa1728a80889e0e59cd4
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Tue, 13 Jun 2017 11:19:31 +0000 (16:49 +0530)]
changing karaf3 to karaf4 for genius features
Change-Id: I5ddc6382cbe1fd1d3cc6b17ccf8b35cffe9917be
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Periyasamy Palanisamy [Wed, 10 May 2017 06:02:20 +0000 (11:32 +0530)]
avoiding logging full stack trace in case of id doesn't exist
* This fix is to avoid filling karaf logs exception with full of stack
trace if source of exception is known by its exception type and message.
Change-Id: I057647f9a4ac90c32476e8d9eb2494a1b9d3c4a2
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Faseela K [Sat, 17 Jun 2017 00:37:39 +0000 (00:37 +0000)]
Merge "Bug 8146:BFD tunnel monitoring interval update fix"
Stephen Kitt [Tue, 23 May 2017 08:19:40 +0000 (10:19 +0200)]
Remove uses of Optional for conditionals
Optional instances should never be constructed just to facilitate
conditional handling of the form
Type variable = ...
if (variable != null) {
...
}
Turning this into
Optional<Type> variable = Optional.ofNullable(...);
variable.ifPresent(value -> ...);
causes more GC activity and makes the code harder to read (and
analyse).
This patch doesn’t address the issue of whether the values in question
are actually nullable.
Change-Id: Ieb48152cacc721a77473f4229d595b8486561bc3
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Hema Gopalakrishnan [Fri, 9 Jun 2017 06:21:55 +0000 (11:51 +0530)]
Bug 8146:BFD tunnel monitoring interval update fix
Added support for dumping more caches
Caches were not getting cleared correctly. Fix to remove tunnels from Cache whenTEPs are deleted.
Change-Id: I4bbc5e203cf90f81ba9b9b70818c4972d05ef2c6
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Michael Vorburger [Thu, 15 Jun 2017 15:02:10 +0000 (15:02 +0000)]
Merge "Use TestEntityOwnershipService that's now in controller"
Michael Vorburger [Thu, 15 Jun 2017 15:00:24 +0000 (15:00 +0000)]
Merge "Listener base classes should not throw exception if close()'d "
Thanh Ha [Tue, 13 Jun 2017 20:15:14 +0000 (16:15 -0400)]
Migrate to odlparent 1.9.0
Change-Id: I40a03cc92255b08e54815050d15d487ef6c081bf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Faseela K [Tue, 13 Jun 2017 12:15:59 +0000 (17:45 +0530)]
Fixing a typo in DJC log statement
Change-Id: Iff8853ea40b547235d36d495a23ce0fa055abff6
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Tue, 13 Jun 2017 11:12:48 +0000 (11:12 +0000)]
Merge "Bug 8555 - Too many log info print to the console"
Stephen Kitt [Tue, 23 May 2017 09:20:50 +0000 (11:20 +0200)]
Use polymorphism instead of Optional
Optional shouldn’t be used instead of method polymorphism. This patch
deprecates
InterfaceManagerCommonUtils.createInterfaceChildEntry(String, String,
Optional) and replaces it with variants using either no transaction or
an explicit WriteTransaction.
Change-Id: If5face3a7629f71e4d004eadf2b45fb6175dc61f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Thu, 1 Jun 2017 03:43:51 +0000 (05:43 +0200)]
Use TestEntityOwnershipService that's now in controller
following https://git.opendaylight.org/gerrit/#/c/58089/
Change-Id: If0626ef349e16469cef14504ae6b11595030dad2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 12 Jun 2017 10:01:33 +0000 (10:01 +0000)]
Merge "Neutron Port Allocation For DHCP Service"
Faseela K [Mon, 12 Jun 2017 07:09:30 +0000 (07:09 +0000)]
Merge "Bug 8008: NPE detected in IfMgrRpcService.getDpnInterfaceList"
Michael Vorburger [Wed, 17 May 2017 10:36:46 +0000 (12:36 +0200)]
Listener base classes should not throw exception if close()'d
for AsyncClusteredDataTreeChangeListenerBase and
AsyncDataTreeChangeListenerBase, by introducing a new
ShutdownLoggingExecutorService infra util. related to -1 discussion in
https://git.opendaylight.org/gerrit/#/c/57004/
This is an alternative proposal to the ShutdownLoggingExecutorService
idea from https://git.opendaylight.org/gerrit/#/c/57156/
Change-Id: I5884a188fb5ea3581f99cc559acb158ed370ed7b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
D Arunprakash [Thu, 1 Jun 2017 03:37:34 +0000 (09:07 +0530)]
VM Migration: Handle VM migration only for OFPT_PORT_STATUS/OFPPR_ADD
Trigger VM migration only for OFPT_PORT_STATUS/OFPPR_ADD event.
Ignore all the other events, which is triggering the migration.
Change-Id: I340e02301bed437910f0afda7a1f98a38e62fb33
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Miguel Perez [Tue, 6 Jun 2017 14:40:16 +0000 (16:40 +0200)]
Bug 8008: NPE detected in IfMgrRpcService.getDpnInterfaceList
+ This line is throwing NPEs because rpcResultBuilder is NULL under
certain circumstances:
return Futures.immediateFuture(rpcResultBuilder.build());
+ I'm fixing other potential NPE for the same price
Change-Id: Ib6bf5039234f114228eb7d6a9c4f3b1882831e5d
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
David Suarez [Fri, 2 Jun 2017 22:20:47 +0000 (00:20 +0200)]
Fix checkstyle problems not detected by the current version
This change is required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle
Change-Id: I800ea4c89c9c517bc5baa992c67d17b9ba79547c
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Freeingo Sure [Sat, 27 May 2017 01:08:33 +0000 (09:08 +0800)]
Bug 8555 - Too many log info print to the console
Change-Id: I19133b5e7b2768ff5762bcf5d4a97994178a893b
Signed-off-by: 肖锋钢10072566 <xiao.fenggang@zte.com.cn>
Vijayalakshmi Chickkamenahalli Nagaraju [Wed, 17 May 2017 08:09:59 +0000 (13:39 +0530)]
Neutron Port Allocation For DHCP Service
Adding new ARP_CHECK_TABLE constant in NwConstants for Neutron Port
Allocation For DHCP Service.
New pipeline for DHCP & Gateway IP ARP Responder in ELAN.
LPort Dispatcher Table(17) -> ARP Check Table(43) -> ARPResponder Group
-> ELAN Base Table(48), ARP Responder Table(81), Controller
-> ELAN Base Table(48) (ARP Reply), Table 220( Floating IP ARP reply)
Change-Id: I2dce5e253d3c94180dd18e51125c5c18170b5c69
signed-off-by: Vijayalakshmi Chickkamenahalli Nagaraju <vijayalakshmi.c@altencalsoftlabs.com>
Signed-off-by: Achuth Maniyedath <achuth.m@altencalsoftlabs.com>
David Suarez [Wed, 7 Jun 2017 10:31:16 +0000 (12:31 +0200)]
Migrate to odlparent 1.8.0-Carbon
Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.
Jira: RELENG-159
RT: 41406
Change-Id: Id6ca083bce9475ae604a2085046b36e307a2ac26
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Sam Hague [Tue, 6 Jun 2017 12:33:37 +0000 (12:33 +0000)]
Merge "@Immutable GroupEntity"
Sam Hague [Sun, 4 Jun 2017 21:53:28 +0000 (21:53 +0000)]
Merge "Simplify boolean expressions"
Sam Hague [Sun, 4 Jun 2017 21:51:14 +0000 (21:51 +0000)]
Merge "Make testutils a JAR instead of a POM"
Vyshakh Krishnan CH [Fri, 2 Jun 2017 05:54:20 +0000 (11:24 +0530)]
EVPN RT2 : L2VNI Demux Table id
For EVPN RT2 a new table(table 24) is introduced to demux the l2vni from packets
coming from DC-GW
Spec is approved and is available at : https://git.opendaylight.org/gerrit/#/c/51693/
Change-Id: Ie23457df4d9d20a01f53e271c5b7ece77342225f
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Sam Hague [Fri, 2 Jun 2017 01:00:27 +0000 (01:00 +0000)]
Merge "Utility api to configure icmpv6 type"
Michael Vorburger [Thu, 1 Jun 2017 18:58:33 +0000 (18:58 +0000)]
Merge "Make ActionInfo.toString() generic"
Michael Vorburger [Thu, 1 Jun 2017 14:05:39 +0000 (16:05 +0200)]
Remove TestableDataTreeChangeListenerModule from ResourceManagerTest
It's currently not used anyway, and (because it's not used!) it can
occasionally cause the "heisenbug" (i.e. arbitrary test failure on some
runs, but not always) problem "IllegalStateException: Test forgot an
awaitEventsConsumption()".
see also (new) doc on
https://wiki.opendaylight.org/view/BestPractices/Component_Tests#Async
Change-Id: I8140df5e06b1b35deae4d4137af768c2c275b68b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 30 May 2017 13:10:49 +0000 (15:10 +0200)]
Add missing @Override and serialVersionUID to genius.mdsalutil
Change-Id: Ib1079a5c59390d9b902d8f6653931f9c62ecf7ac
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 1 Jun 2017 05:18:52 +0000 (05:18 +0000)]
Merge "Add Unit Test (only) for ActionDrop equals"
Michael Vorburger [Thu, 1 Jun 2017 05:14:19 +0000 (05:14 +0000)]
Merge "Add yangtools:testutils to mdsalutil-testutils"
Michael Vorburger [Thu, 1 Jun 2017 05:11:52 +0000 (05:11 +0000)]
Merge "Support for moving Src/Dest IPv6 addresses in NxRegMove action"
Michael Vorburger [Thu, 1 Jun 2017 05:11:42 +0000 (05:11 +0000)]
Merge "Support API that configures IPv6 address as sourceAddress"