Merge "BUG-2283: introduce OutputLimiter"

Merge "BUG-2383: rework RIB inbound"

BUG-2283: introduce OutputLimiter

This is a simple utility class to perform backpressure based on channel
writability.

Change-Id: I2b4018722eee9dfa88ff92d49d17b969134a7de3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix an checkstyle not being recognized by eclipse

Since we override mappings, we need to make sure we carry checkstyle
declaration, otherwise eclipse reports an error.

Change-Id: I6fe6ea161ea963883284f68ed6faffe06f7d8f58
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make sure we execute the maven plugin

This will make it easier on the developers, as eclipse will
automatically generate bindings.

Change-Id: I55df6997361195b3da8c506a68527349edb6201a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not override maven-dependency-plugin version

odlparent already defines it to 2.10, we were reverting it to 2.8.

Change-Id: I489264ffa8805f24cc9db355e224c35fcb8cab3d
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: rework RIB inbound

Each Peer (like BGPPeer) performs updates the adj-rib-in via a dedicated
AdjRibInWriter instance. That class, along with RIBSupport and TableContext,
is responsible for translating the Binding-Aware messages coming from
the message parser into Binding-Independent form within the datastore.

Changes are then propagated via DataChangeNotifications into
InboundPolicyEnforcer, which performs any munging of attributes required
and checks if the route is eligible for inclusion in the local RIB. If
it is, the route is output into the effective-rib-in hosted in the
datastore.

From there it is picked up by BestPathSelection, which compares the
effective routes from multiple peers and installs the best one into the
local RIB.

Change-Id: Ie23746b2fc44499f42d346595562b498c19fd112
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-2383: add BestPathSelector and related classes"

Merge "BUG-2383: introduce OffsetMap"

Merge "BUG-2383: fix the RIB model"

BUG-2383: add BestPathSelector and related classes

Introduce a utility BestPath class along with a builder-style selector.
The selector can be run incrementally by initiating the state from
previous selection run, then feeding all candidates and finally
extracting the best-matching path.

Change-Id: I34aab7f0c2ab4b917597a77d54508f5d93e6a8c9
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: introduce OffsetMap

For the sectionprocess we will need a compact way of tracing
peer/attribute mappings. Storing things in array is the most compact
form, but we need to manage a lookup table. This is the role of
OffsetMap, which maps an UnsignedInteger (e.g. a BGP Identifier) to an
offset. We then need to only allocate a single array for each entry to
hold the actual values.

Change-Id: I7c4c8b841cca0330f9646e5e629a824fd929f181
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: fix the RIB model

The overall goal is to store adjacency ribs in the datastore. In order
to do that, we need to fix the (defunct) model, so each peer has a
unique subtree. This patch fixes the model and introduces a peer ID
type, which we will use throughout to identify peers.

Change-Id: I45a4493d0aabb29828e6e935017939a5b09e7b60
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2749 : deprecate unused methods

- cannot be removed, they are used in stateful02

Change-Id: I08d149b7fc9dbf376942104d3eb4f35fa1a02a93
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2794 : refactored code to use BitArray"

Fixed IT breakage after migration of NSF from controller.

PcepServices test declared uncessary dependencies on
model-inventory, which was transitive compile dependency.

Transitive dependency relationship via sal-binding-it
was removed during removal of NSF from controller,
which prevented pax-exam starting these pcep test.

Removed offending declaration, since is not needed
for test to be run.

Change-Id: Ib505bbd0f91407ec6c7f89995b19fe61b1437d94
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-2794 : refactored code to use BitArray

Change-Id: I8906ec2b9671cd71916f0e3c4225199cf5963bdc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "BUG-2794 : created BitArray class"

Getting rid of readerIndex handling.

- in most cases it can be replaced by skipBytes()

Change-Id: Ia2d7fb64f61879bb5404745c270ae5364f051077
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2794 : created BitArray class

Change-Id: I6857fb22eea643d90fb61933fb170b620c6dbf63
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixup supporting-node requiring also a topology ID

The fixed base model requires also a topology reference.

Change-Id: I21e272e8b3a70e89fd9e424a523b40d06575ab75
Signed-off-by: Robert Varga <rovarga@cisco.com>

Cleaned up dependencies.

Change-Id: Iaab661407fcee445199e0be1f1f59abbd22c41e9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Split feature file"

Merge "Removed linkstate dependency from bgp-parser-impl."

Merge "BUG-608 : fixed typo"

BUG-608 : fixed typo

- ip4 vs ipv4

Change-Id: Ib48cd1df3c6ad156f93a80639980e1f835dbc992
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2712: do not hold lock while updating future"

Removed linkstate dependency from bgp-parser-impl.

Change-Id: Ibe2cf3b6d27514518d1cf015159ccc19a4ce9379
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Removed some sonar warnings.

Change-Id: I5f152d314c5021134f54f4c1b9ca2fc77d685d0f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Remove <repositories> and <pluginRepositories> section

It is recommended that developers and servers configure this locally via
settings.xml.

https://lists.opendaylight.org/pipermail/discuss/2015-January/004482.html

Conflicts:
parent/pom.xml

Change-Id: Ia457b7368d85cf021d434f0262d749c9d954d67c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-2712: do not hold lock while updating future

SettableFuture will call any and all registrants, which could
potentially lead to AB/BA deadlocks. with ProgrammingServiceImpl. Issue
the call to set outside a synchronized block.

Change-Id: Iddb268d2157256466b597aaef78002b4f474a149
Signed-off-by: Robert Varga <rovarga@cisco.com>

Removed warnings from linkstate.

- refactored some big methods

Change-Id: Ibf230b2a430ef7b26c4bb80468534852a8d281af
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Bug 2231 - Parser/Serializer StartTLS"

Bug 2231 - Parser/Serializer StartTLS

- changed type of PCEPStartTLSParser to temporary unused value

- registered parser and serializer into activator

- added parser/serialized test

Change-Id: Ie7ce9a5ad93192e3fbe712a15288f0e3f73915e0
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Added private constructors + tests to linkstate classes.

Change-Id: I996eba6cfa0c088e07bfb6d261e732dcb07f0191
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Split feature file

- now split to bgp/pcep/data-change-counter (extras)

Change-Id: Ia55da0791e03dca1208f925f79b435e86117ba70
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2738 : fixed path setup tlv type"

Merge "Added new linkstate revision to configuration file."

Merge "Added some unit tests."

Merge "BUG-2571 : Fixed flowspec MpUnreach imports."

BUG-2738 : fixed path setup tlv type

Change-Id: Ic19c57a9a614bacd9be2709b09c2e94214276282
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Added new linkstate revision to configuration file.

Change-Id: I2143966c3cfb886ce2cc8cd255a03a74bd15102a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Added some unit tests.

Change-Id: I4fbcf0775956087b089db136327e1bbbe4ec348e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2571 : Fixed flowspec MpUnreach imports.

Change-Id: I5ca53a4a834ad90b9364de53398b87a8b88777b9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Bug 2231 - Paerser/Serializer for startTLS message"

Bug 2231 - Paerser/Serializer for startTLS message

Change-Id: I231327deb2fcb9b794b9b791d061c978aeb15190
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Bug 608 - implemented parsers/serializers

- for Adjacency Segment Identifier, Lan Adjacency Segment Identifier

Conflicts:
bgp/linkstate/src/main/java/org/opendaylight/protocol/bgp/linkstate/attribute/LinkAttributesParser.java
bgp/linkstate/src/main/java/org/opendaylight/protocol/bgp/linkstate/attribute/PrefixAttributesParser.java
bgp/linkstate/src/main/java/org/opendaylight/protocol/bgp/linkstate/attribute/sr/SrPrefixAttributesParser.java
bgp/linkstate/src/test/java/org/opendaylight/protocol/bgp/linkstate/SrAttributeParserTest.java

Change-Id: I18bfb03fb9392076fceae99e33205746f000d33a
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "BUG-608 : implemented SrPrefix parser/serializers"

Merge "Bug 2231 - API for StartTLS message"

BUG-608 : implemented SrPrefix parser/serializers

Change-Id: I55b6cc996d0fdeb8a77ecaa703f1ce8c9ec2770e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Moved serializing of forwarding address to conform tlv order

- adjusting also the tests

Change-Id: Ib2857f0f3f0ec90252d21c19ed4a1b4075837321
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Untagle packages
by moving TlvUtil to separate spi package.

Change-Id: I3a0619e65d392c5c38d4a97220245de397451e1f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-608: parsers/serializers for SID Label Binding TLV and sub-tlvs

Change-Id: I49d0e7fe2effaef56eef690e23ed8a177a0f722b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 2231 - API for StartTLS message

- implemented by
  https://tools.ietf.org/html/draft-ietf-pce-pceps-02#section-3.3

- added new message type into pcep-types.yang

- added new notification into pcep-message.yang

Change-Id: Icdf862a11852ffe673fdc1dbcb58266a03ce3a6a
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "Use readUnsignedByte instead of readByte and typecast."

Merge "Remove check for empty lists, where not needed."

Bug-2208: pcc-mock support tunnel initiate and remove

-pcc-mock can handle PCInitaiate message (create/remove tunnel)
and sends fake report message.
-extended EndPointIpv4ObjectParser to avoid checking "P" object header flag

Change-Id: I822d649940a1a8d0fb8ab5dedf886bb2a9f63a47
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2208: pcc-mock configurable port numbers

-input arguments "--local-address" and "--remote-address"
can now handle parameter in form "<IPAddress:PortNumber>"
The port number can be omitted - deafult values are used.
Default remote port number is 4189 and local is 0.

Change-Id: I18ef3c75c07743b919fb8fcca757746e44998287
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "Bug-2250: pcc-mock support TCP MD5"

Merge "Bug-2208: pcc-mock code refactoring"

Use readUnsignedByte instead of readByte and typecast.

- gets rid of UnsignedBytes import in most cases
- will be followed up by cleaning up readByte()

Change-Id: I98846e2b71c4724ef978e5681d9b6e71405d1a1d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Remove check for empty lists, where not needed.

- fixed communities tests

Change-Id: I232bb411f56b06fb2711b268587e3213039223a3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Replaced slice() with readSlice() where appropriate.

- reduces the need to move readerIndex manually

Change-Id: I3cfe1f0d9e64a0efd7a71db02dacbe40d79eaaaa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2250: pcc-mock support TCP MD5

-new input argument "--password <string>"
-when password is omitted, plain tcp is used

Change-Id: I973ac455be1fe093a129dc065bd1d6a28bc3dfe4
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "BUG-2571 : added parser/serializer for flowspec NLRI"

Bug-2208: pcc-mock code refactoring

-removed unnecessary code
-switched to use immediate reconnecting strategy
-refactored client dispatcher and main class
-improved junit tests

Change-Id: I3d44ad88a5bf81212443bd0079ad82719e367b1c
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-608 : implemented parsers/serializers for
- SrAlgorithm
- SrCapabilities

Change-Id: I9dd5bf14f12238a64981a2f78b7a41689ab73426
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-608 : additional rework of models

Change-Id: I19b4e1fb605bcfc5dbc9c3956711a38ede2c53a3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Migrate Objects->MoreObjects

This future-proofs our codebase as Guava have moved the helper to
MoreObjects.

Change-Id: I02651171981c243c2cf95417d8dd2b2bc92e876c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Update to conform with guava 18

Stopwatch instantiation has changed, so adjust accordingly.

Change-Id: I97800f17c0af3dad038b07c6aa393c44fd9f80ee
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not override plugins from odlparent

These plugins are already defined in odlparent.

Change-Id: I53eda9fe25b08d1045a38675f268a1889c8aa83b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unused properties

We do not use these properties anywhere -- just remove them.

Change-Id: I699e99ce8a1e4753b8fcbf6dc55f256391eac1d2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Migrate to using features-parent

odlparent gives us a convenience parent, so let's use it.

Change-Id: I57c20ce1d1ade81c7d6ae3b0c6fa82eff49ae44c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Move features

this moves the features artifact to the standardized place.

Change-Id: I0b4e9d82c51c46f742f3de5f1de46ba0cfe475d5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unneeded dependencyManagement sections

All these are inherited from the artifacts artifact, so should no longer
be needed.

Change-Id: I9154403b2d69df0e47f146738c8d3da1ae3f8ff1
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove legacy eclipse project

The project has been moved, so we do not need this file anymore.

Change-Id: I7be269a78dbe4775c02fd37bc9a838d41f2ab0a2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Rework project structure

- create an artifacts artifact
- move parent to standard place, renaming it
- rename top-level aggregator

Change-Id: I77f0ffca4bd660d993471719ad16b26bbf3fe936
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Added synchronized to close()."

Merge "BUG-608 : added prefix-sid tlv - added another revision of linkstate to include SR - changed imports of linkstate"

Merge "BUG-2708 : fixed failing tests"

Added synchronized to close().

Change-Id: Ie975458b918dd17dd7e2a0e4fb52edc0cc577904
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2708 : fixed failing tests

Change-Id: I7b3516d39d80dabf568e0d52122c2730f65163c6
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

PCEP add-lsp RPC: propagate TLVs from input to initiate message.

Change-Id: Iaf9d010f178feec90f349e389c5b8f39bc2cba19
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 6b884d7bdc4427036f37ce01721458ee87c0168c)

Merge "Remove repositories declaration"

Remove repositories declaration

This has moved to settings.xml, so let's remove it. Building without a
custom settings.xml will no longer work.

Change-Id: I7986ad598ceabb6475fd7e7a87a02cde1d39dcc0
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 2227 - RFC7311 Parser/Serializer

- added parser and serializer for Aigp attribute

- added transformation utility class, which transform bytebuffer to
  instance of Aigp and vice versa.

- added test for parsing and serializing aigp attribute

Change-Id: Idbf67c1baddf3abe8132f1bd0936fe0360a92c90
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Bug 2227 - API for RFC7311

- added new metric into network_concepts.yang

- added new path attribute represents AIGP into bgp_message.yang

Change-Id: Ie82066f1bc7f7cb241438a80ac21ecfd57b5763d
Signed-off-by: Ladislav Borak <lborak@cisco.com>

BUG-2571 : added parser/serializer for flowspec NLRI

Change-Id: I42a59f81a3d9023768f6ae526b5e15463d4b40f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix integration tests after sal-dom-broker change

Upstream has pulled in LMAX disruptor into dependencies, so we need to
add these, too.

Change-Id: I56c25ee0f8902e9e8aab78a0d22302e8b7b66107
Signed-off-by: Robert Varga <rovarga@cisco.com>

Disable to create duplicate (with same IP Address) PCEP sessions.

Moved duplicate session handling into AbstractSessionNegtiatorFactory (PCEPPeerRegistry),
to be usable for all session negotiators created by. PCEPPeerRegistry also handle session-id caching.

Session ref. entries stored in bi-map were identifed by byte array (raw IP Address of client),
casuing that already existing session in bi-map were not look-up properly => allowing to create duplicate sessions.
Changed type of bi-map's key to wrapper of byte array.

Fixed also removing of session refs. from map on channel close. Turned bi-map to map, since inverse map is not used anymore.

pcc-mock is reusing this code - need to create session negotiator factory per pcc.

Change-Id: I85670b083b6ea832f8b9a4891c812845174f03ff
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-608 : added prefix-sid tlv
- added another revision of linkstate to include SR
- changed imports of linkstate

Change-Id: I9f8db2172cccf07aedaecc581eeacefd72ea208a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Do not redefine dependencies from odlparent"

Do not redefine dependencies from odlparent

These are already mentioned in odlparent, no need to repeat them here.

Change-Id: I1e78d3debbe74d2b5e6ca331d53a4dc3ff6113c3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug-2229: RFC6286 - AS-wide Unique BGP Identifier

-extended Connection Collision Resolution
https://tools.ietf.org/html/rfc6286#section-2.3
-if BGP identifiers are same, compare AS numbers

-modified Open Message Error Handling
https://tools.ietf.org/html/rfc6286#section-2.2
-if BGP Identifier of local and remote speaker is the same -
return error "Bad BGP Identifier"

Change-Id: Idcf18390129805c2b78cf6070ba47f3d4ab0e9d0
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Create client dispatcher for testing.

-allows client to be binded to specified IP address

Change-Id: I1f665e30ed452ec672f16c7b3a39ca9a2e42706a
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2631 - Fixed BGP connection collision detection

-have to examine all connections, in OpenConfirm state
-before, only fully established connections were examined
-connections are kept in map
-remove connection from map, when session goes down
-avoids https://bugs.opendaylight.org/show_bug.cgi?id=2109
-brings dependency of BGPSessionImpl on BGPPeerRegistry
-fixed bgp-identifier conversion to long

Change-Id: I700e8e5a0fb0874731ab2fe013cd7853e44428da
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "BUG-608 : initial segment routing model for BGP"

BUG-608 : initial segment routing model for BGP

Change-Id: Id364a1e4255f6d0604b0ff66f51da0c1799167f0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2208: Added ability to configure keepalive and deadtimer

-d, --deadtimer <0..255> (optional, default 120) - DeadTimer value in seconds
-ka, --keepalive <0.255> (optional, deafult 30) - KeepAlive timer value in seconds

Change-Id: I1fcc983f96793853d719ed8c5aaa241e848801b4
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2208: Mocked PCC can connect to multiple PCEs.

-input argument "--remote-address" can handle multiple
ip addresses (separated by comma).

Change-Id: I9e32781b9ced77d6351b4d681ed7677e357b039e
Signed-off-by: Milos Fabian <milfabia@cisco.com>