Sridhar Gaddam [Tue, 23 May 2017 12:57:09 +0000 (18:27 +0530)]
Bug 8535: Fix IPv6 OXMHeader Mask issue
When programming an OVS flow to set an ipv6_src/dest as
an action field (i.e., set_field:2001::1->ipv6_src), the
current implementation is not checking the Mask and is
including the Mask (even for a full ipv6 address) in the
OXM header. Because of this, switch is rejecting the flow
with the following error.
"decode error: OFPBAC_BAD_SET_MASK. OXM header 0:32768:26:1:32
includes mask but masked OXMs are not allowed here"
This patch addresses this issue by checking the prefix and
including the prefix only if applicable.
Change-Id: Ieffdc7f0e74e9418156171d85a28c24dd336527c
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Tomas Slusny [Fri, 5 May 2017 15:05:36 +0000 (15:05 +0000)]
Merge "Remove unnecessary method from abstract class."
Jozef Bacigal [Fri, 5 May 2017 12:55:39 +0000 (14:55 +0200)]
Remove unnecessary method from abstract class.
Change-Id: I23de0d1973418854c6fce039f6e694ed13c1d04b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
miroslav.macko [Fri, 10 Feb 2017 13:23:43 +0000 (14:23 +0100)]
Change sal bundle yang model
- Put messages to message container
Change-Id: Ie86d70bf070ca16659f02ba536655c6e6f1682af
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
miroslav.macko [Wed, 8 Feb 2017 17:01:20 +0000 (18:01 +0100)]
Update BundleAddMessageConverter
- Update serialization
- Set Xid and Node
Change-Id: Ie7f9a0d99dc348c71212a9cc0a53893f29ff971e
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 7 Feb 2017 08:21:20 +0000 (09:21 +0100)]
Change yang models due to errors
- Added container for cases where was duplicate declaration of fields.
- Renamed cases to not to have duplicate name of interfaces.
- Renamed wrong spelled "Convertor" to "Converter".
- Fixed tests. (Ignored, fixed in following patches)
- Added nbactions.xml to gitignore (netbeans help file)
Change-Id: Ie268f9d8a697097e3892196e26442c917026b993
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 14:32:41 +0000 (15:32 +0100)]
Add BundleControl converter from OFJ
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I57709f7d089e651525ddc65a4a51a68f39f38772
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 14:09:45 +0000 (15:09 +0100)]
Update bundle extension tests
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: If4b197b8ecf334286d4bb01748b8b622c2112182
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 12:47:09 +0000 (13:47 +0100)]
Add BundleAddMessageConvertor
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: If6bc0a657c04e95454a3576a5707ddd00a16b38e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 12:42:10 +0000 (13:42 +0100)]
Add BundleControl converter
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I850e5119bd4ee7d73222dd90bf1e28e4a19916a8
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 09:45:36 +0000 (10:45 +0100)]
Add simple SalBundleService
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I1457d7988b68a8eb74928088e253fc5f523d29c4
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 09:35:46 +0000 (10:35 +0100)]
Add Bundle and Error (ONF-extension) deserializers
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I583e15333df3811adf47ba174b4f593946be7d39
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 07:56:34 +0000 (08:56 +0100)]
Add Bundle messages serialzers
- moved from openflowjava
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I36e7600f15d1a5d345e62cd4f42c0f0f999ae588
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 07:54:35 +0000 (08:54 +0100)]
Add model for ONF bundle extension
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I17e22dadb910ed76ba6ccfae711a81fd0856762f
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 23 Jan 2017 13:30:48 +0000 (14:30 +0100)]
Add ONF extension provider and wire via blueprint w/OFP
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I49d08c82d4b973b888939aff2a4cd110289c9fe3
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 11 Apr 2017 15:52:16 +0000 (17:52 +0200)]
Fix no match serialization
This patch ensures that even when match in flow is null, at least empty
match is sent to device.
Change-Id: If77c59b889e45698da4b96f098088cdbdf4698ee
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Tue, 25 Apr 2017 08:26:50 +0000 (08:26 +0000)]
Merge "Bug 8217: Set error information into direct statistics RPC result."
Tomas Slusny [Tue, 25 Apr 2017 07:47:20 +0000 (07:47 +0000)]
Merge "Bug 8223: Fixed incorrect enable-flow-removed-notification check."
Tomas Slusny [Mon, 24 Apr 2017 10:23:59 +0000 (12:23 +0200)]
Prevent changing single-layer-serialization on fly
Prevent changing use-single-layer-serialization config
parameter on the fly, allow it only during initialization.
Resolves: bug 8278
Change-Id: Idfd2f7aa99fdf330bc32615431b4378209c83fda
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 24 Apr 2017 07:07:30 +0000 (07:07 +0000)]
Merge "Improve property-based configuration"
Tomas Slusny [Tue, 21 Mar 2017 18:17:22 +0000 (19:17 +0100)]
Improve property-based configuration
- Add OpenFlowPluginConfigurationService. This service can control
updating of OpenFlowPlugin configuration (skip-table-features etc.)
in initialization phase and also on the fly.
- Comment out default settings in org.opendaylight.openflowplugin.cfg
because with all default values set in that file, we are ignoring
values specified in openflow-provider-config.yang.
- Add support for missing configuration values from
openflow-provider-config.yang to OpenFlowPluginConfigurationService
- Remove changeable configuration values that was passed to some
OpenFlowPlugin class implementations to both constructors and setters
from constructors to prevent code duplicity and to simplify code a bit
Now, when feature is installed,
default values are taken from openflow-provider-config.yang, then we
check if we have org.opendaylight.openflowplugin.cfg file in karaf/etc/
(blueprint will do this for us) and try to read it as map. Then we will
pass this map to update method, that will iterate over this map and
parse it's keys and values and calls appropriate update methods in
OpenflowPluginProviderImpl based on key
(f.e skip-table-features will call
OpenflowPluginProviderImpl#updateSkipTableFeatures).
When org.opendaylight.openflowplugin.cfg file is changed, we receive
notification about it in form of
OpenFlowPluginConfigurationService#update method call, and we will
repeat same procedure as during initialization (parse map passed as
argument to this method and update configuration).
Resolves: bug 7218
Change-Id: Ida986f7dfffe55a90ddb6f354f0addf56c3c4b90
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Shigeru Yasuda [Thu, 13 Apr 2017 11:12:19 +0000 (20:12 +0900)]
Bug 8223: Fixed incorrect enable-flow-removed-notification check.
flow-removed notification needs to be published if
DeviceManager.isFlowRemovedNotificationOn() returns true.
Change-Id: I10c025f11e14670303b70bf31d3a9cefa5a676ec
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit
644f1bbd99d4fd949800fb3167d11d4ce968c950)
Tomas Slusny [Mon, 27 Mar 2017 14:59:24 +0000 (16:59 +0200)]
Ignore early port status msg and process it later
When port status message arrives before we got MASTER role,
ignore it. Then, after receiving mastership collect PORT_DESC statistics
again to make sure we do not missed any port status messages in process
Resolves: bug 6908
Change-Id: I01285ed4880533f48bf90fa7c6a4ca2c7d3a210f
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Shigeru Yasuda [Wed, 12 Apr 2017 14:01:23 +0000 (23:01 +0900)]
Bug 8217: Set error information into direct statistics RPC result.
Change-Id: I3fdf51b94bf95afefa47dddea37a82b8f139af95
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Anil Belur [Tue, 11 Apr 2017 01:45:52 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I69b8fcbaf59487fae8564634aebfb52c6951101a
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Tomas Slusny [Mon, 13 Mar 2017 13:27:55 +0000 (14:27 +0100)]
Update multipart request services for single layer
Update all single layer services that was sending OpenFlowJava
multipart requests to send OpenFlowPlugin multipart requests
instead to avoid translations.
Remove failing tests from NodeConnectorRefToPortTranslatorTest. These
tests are not needed anymore, since now JUnit auto-handles @NonNull
annotations.
See also: bug 6915
Change-Id: I427a6148e67d61080a85de5c304f478df0e26682
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 1 Mar 2017 15:38:29 +0000 (16:38 +0100)]
Add multipart request message serializers
- Add serializers for multipart request and it's subtypes
- Add YANG models for multipart request and it's subtypes
See also: bug 6915
Change-Id: I465c23a6fc3bea0cf944bbe8e6f75e17833d4449
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Tue, 4 Apr 2017 12:00:23 +0000 (14:00 +0200)]
Add timer and auxiliary connection
- added time to check if all devices are master or slave.
- auxiliary connection is no more dropped but stored.
Change-Id: I720f90f70631de0fddea8eaeaa39c2186c90db20
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 3 Apr 2017 09:56:43 +0000 (11:56 +0200)]
Fix startup.
Change-Id: Ia3488423f70b045c766692205c947e078af9a8f7
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 31 Mar 2017 09:33:57 +0000 (11:33 +0200)]
Clean up
- removed yang configuration
- moved yang enum to java enum
- changes in txChain for initial gathering
Change-Id: I8b37bb40374cd1c861252a320b1ff83ab86d2d74
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 24 Mar 2017 11:20:40 +0000 (12:20 +0100)]
Fix after FRM changes.
Change-Id: I3ed9764d1b7d65f6e70b9d87a38125da30d2ffb6
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 20 Mar 2017 10:33:23 +0000 (11:33 +0100)]
Remove unneccessary code
Change-Id: I4fa5afa56ab17cff88b81ef57c8ed05fed650aee
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 14 Mar 2017 13:11:32 +0000 (14:11 +0100)]
Remove to set all devices slave.
- wait 5 seconds for obtaining master
- if not set as slave
- clean up
Change-Id: Ie4be0290f76714ff749145ffd31e11ea5a98aa0c
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 8 Mar 2017 14:55:00 +0000 (15:55 +0100)]
Add EOS listener.
Change-Id: I93d7364e097c100f1677b392726019a4058bcc9d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 10 Feb 2017 08:28:29 +0000 (09:28 +0100)]
Change dropping mastership.
Change-Id: I6bd5f67e72dea7415e08a0de557cc5900d16a308
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 7 Feb 2017 09:00:15 +0000 (10:00 +0100)]
Update ttl timers for 1s.
Change-Id: I17ab28c99fcdf743e1c19d580451e90cc4890b00
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 26 Jan 2017 13:45:34 +0000 (14:45 +0100)]
Fix bug when device does not get role after reconnect.
Change-Id: I6a00c803c34de5d9452d1eb18e9dae617d46e2e4
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 18 Jan 2017 08:14:17 +0000 (09:14 +0100)]
Add tests.
- part 1, changes need to be made to properly test it.
Change-Id: I13b6f9773406c4fc04c3863994d3c01e67a27531
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 16 Jan 2017 08:17:47 +0000 (09:17 +0100)]
Add posibillity to never drop context chains.
Change-Id: Id4c7814899a9403304a4ed230750f1595b45f9cc
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 11 Jan 2017 14:47:32 +0000 (15:47 +0100)]
Fix problem with unregistering from cluster services.
Change-Id: If1b7f5118c1834204c6676b9130bf23d2cb95328
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 10 Jan 2017 15:04:05 +0000 (16:04 +0100)]
Fix several issues with disconecting device
Change-Id: I29a0b08643fce88599a1d3e76d0f382369127780
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 9 Jan 2017 14:43:53 +0000 (15:43 +0100)]
Add disconect login after time to live is up.
Change-Id: Icf90cd0154b2f1afbec8c5956f30595d4a948d29
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 20 Dec 2016 14:40:14 +0000 (15:40 +0100)]
Repair style check for new classes.
Change-Id: I02f6d0ec3a122e41ad750520a65eaee7e9a7c64e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 14 Dec 2016 16:15:24 +0000 (17:15 +0100)]
Disconnection improvements.
Change-Id: I547bf7fab3604e8b7dad8ce8964528b3cbc05998
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 12 Dec 2016 12:44:28 +0000 (13:44 +0100)]
Add mastership listener to Initialization callbacks.
Change-Id: I743feb5429578ffe571bc366786d317efa0cacfa
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 1 Dec 2016 13:51:12 +0000 (14:51 +0100)]
Implement connection core layer basic behavior
Change-Id: Ibc4882ce67d0db2ad4ccf6ce070f25126e3fb1a0
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 28 Mar 2017 11:06:04 +0000 (13:06 +0200)]
Fix DeviceFlowRegistry performance regression
- Remove use of marks and modify DeviceFlowRegistry immediately
- Synchronize only access to DeviceFlowRegistry BiMap and not
entire class
- Replace custom match comparison with match normalization (should be a
lot faster on big amount of flows)
- When logging to console, compute FlowRegistryKey hashes only when needed
See also: bug 6917
Change-Id: I25e12a8254b75063e4fdc840eddd70386e3b0f26
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 3 Apr 2017 08:06:05 +0000 (08:06 +0000)]
Merge "Add missing karaf 4 features to artifacts"
Jozef Bacigal [Mon, 3 Apr 2017 07:26:49 +0000 (07:26 +0000)]
Merge "BUG-7622: Karaf 4 Migration"
miroslav.macko [Fri, 31 Mar 2017 09:40:35 +0000 (11:40 +0200)]
Add missing karaf 4 features to artifacts
See also: BUG-7622
Change-Id: I8afab9271a50469073168827db68e9b296cead15
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Jozef Bacigal [Fri, 31 Mar 2017 07:53:18 +0000 (07:53 +0000)]
Merge "Fix table miss flow push"
Claudio D. Gasparini [Wed, 29 Mar 2017 11:03:49 +0000 (13:03 +0200)]
BUG-7622: Karaf 4 Migration
Add missing karaf 4 features to artifacts.
Change-Id: I907afa3a31b44412ae3ffa6ba3cca9ab81695b07
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Jozef Bacigal [Thu, 30 Mar 2017 14:52:34 +0000 (14:52 +0000)]
Merge "Replace project-specific checkstyle by odlparent's"
Jozef Bacigal [Thu, 30 Mar 2017 14:52:10 +0000 (14:52 +0000)]
Merge "Fix minor issues regarding checkstyle"
Jozef Bacigal [Thu, 30 Mar 2017 14:51:21 +0000 (14:51 +0000)]
Merge "Fix modifiers order to comply with Java coding guidelines"
Jozef Bacigal [Thu, 30 Mar 2017 14:49:24 +0000 (14:49 +0000)]
Merge "Fix checkstyle .api.openflow.protocol"
Jozef Bacigal [Thu, 30 Mar 2017 14:49:19 +0000 (14:49 +0000)]
Merge "Fix checkstyle api.openflow.md.util"
Jozef Bacigal [Thu, 30 Mar 2017 14:49:08 +0000 (14:49 +0000)]
Merge "Fix checkstyle - api.openflow.md.queue"
Jozef Bacigal [Thu, 30 Mar 2017 14:48:57 +0000 (14:48 +0000)]
Merge "Fix checkstyle warnings."
Jozef Bacigal [Thu, 30 Mar 2017 14:48:52 +0000 (14:48 +0000)]
Merge "Fix checkstyle warnings"
Jozef Bacigal [Thu, 30 Mar 2017 14:03:32 +0000 (14:03 +0000)]
Merge "BUG-7901: fix unsynchronized transaction access"
Robert Varga [Tue, 28 Mar 2017 15:29:16 +0000 (17:29 +0200)]
BUG-7901: fix unsynchronized transaction access
The evidence in the issue indicates that we have a race condition
where a batch of modifications is being submitted (triggered by
a write/delete and exceeded batch count) and we are observing a
concurrent modification. After auditing the CDS side of this, while
we can improve safety a bit, the scenario has to involve multi-threaded
access by the client.
Looking at TransactionChainManager, it seems to be heavily synchronized,
but there is a hole in the paths which are using getTransactionSafely().
While the access to the TransactionChain, it returns the transaction
(which really is an alias to the wTx field). That throws of static
analysis, as we end up the object pointed to by wTx without holding
the lock -- hence concurrent threads will end up touching the transaction
without any guards, leading to a violation of Transaction contract (which
requires external synchronization).
This patch reworks getTransactionSafely() so it only ensures the field
is initialized as appropriate and makes its callers access the wTx field
with the proper lock held.
Bug: 7500
Bug: 7901
Bug: 8060
Change-Id: I058feb55f91a40ccda6d69ee87cd1a20f792afba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tali [Mon, 27 Mar 2017 10:19:32 +0000 (13:19 +0300)]
Fix masked NXM reg length
Change-Id: I0ed5fe6a2db52521b13d0943d8b25911d5ac5fe9
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Jozef Bacigal [Mon, 27 Mar 2017 07:36:52 +0000 (09:36 +0200)]
Fix checkstyle .api.openflow.protocol
Change-Id: Ib7a3b2eebe4aae5a2662574817b41642486f662b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 27 Mar 2017 07:33:42 +0000 (09:33 +0200)]
Fix checkstyle api.openflow.md.util
Change-Id: I506f097383676a71caadc6b39393a30551dba11a
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
miroslav.macko [Mon, 20 Mar 2017 12:37:56 +0000 (13:37 +0100)]
Fix table miss flow push
- Use ClusteredDataTreeChangeListener
Resolves: Bug 7770
Change-Id: Icf845b5348af374530ce2db01203aea89e2bdbad
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Jozef Bacigal [Thu, 23 Mar 2017 14:21:43 +0000 (15:21 +0100)]
Fix checkstyle - api.openflow.md.queue
Change-Id: I1c91dcee7b74ac1dba17e5c04651009c312124c3
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 3 Mar 2017 11:46:20 +0000 (12:46 +0100)]
Fix checkstyle warnings.
- org.opendaylight.openflowplugin.api.openflow.md.core
Change-Id: Ida0bf4149aaa70657a22fb527708d61b0d7d43b3
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 2 Mar 2017 13:50:17 +0000 (14:50 +0100)]
Fix checkstyle warnings
- org.opendaylight.openflowplugin.api.openflow.md.core
Change-Id: I98490f3a4054bcfdb1339ac490d432ece0539097
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
David [Tue, 21 Mar 2017 18:37:59 +0000 (19:37 +0100)]
Replace project-specific checkstyle by odlparent's
This change replaces the project-specific checkstyle rules by the common
ones defined in odlparent's pom.xml as other projects have already done
(Netvirt, Genius, AAA, etc.). The actual enforcement of the checkstyle
rules
are applied on a per-module-basis in their own pom.xml by adding the
following section to the maven-checkstyle-plugin:
<configuration>
<propertyExpansion>checkstyle.violationSeverity=error</ropertyExpansion>
</configuration>
I have commented the checkstyle enforcement of some current modules to
do this enforcement process in a progressive way by solving the
checkstyle issues module by module. I'll rise separate commits for
those modules soon.
Change-Id: I19bf36ddcd1f02b5cca388562386294b40603566
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
David [Fri, 17 Mar 2017 20:30:44 +0000 (21:30 +0100)]
Fix modifiers order to comply with Java coding guidelines
Minor change: replace "final static" with "static final".
Change-Id: If7df3dd6f6999dde5a4bc1b495f28a598b6a9da1
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
David [Fri, 17 Mar 2017 22:09:09 +0000 (23:09 +0100)]
Fix minor issues regarding checkstyle
- Make BulkOMaticUtils a final class since its constructor is private.
- Parenthesis not needed
Change-Id: I2e0a58dfe204aec89ab49cb3fbd870229932c317
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Shuva Jyoti Kar [Mon, 20 Mar 2017 03:32:43 +0000 (03:32 +0000)]
Merge "Bug 7915 - Zero flows populated in all switches when connected to Leader Node"
Anil Vishnoi [Tue, 13 Dec 2016 03:57:05 +0000 (19:57 -0800)]
Bug 7349 - Flow ID not updated in operational after removing and adding a flow with same match
Change-Id: Ie370cf017bd8642c52f1469cc0b01b10fa38842d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit
66c19f4bbb00399056dce40db7d3312375558bc1)
Anil Vishnoi [Thu, 16 Mar 2017 07:10:20 +0000 (00:10 -0700)]
Bug 7915 - Zero flows populated in all switches when connected to Leader Node
Change-Id: I8e8df5d6cb51c114b23f8690d3d6f01fef37f81b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Jozef Bacigal [Thu, 16 Mar 2017 13:38:29 +0000 (13:38 +0000)]
Merge "Add arbitrary mask for nxm-reg"
Jozef Bacigal [Thu, 16 Mar 2017 13:37:06 +0000 (13:37 +0000)]
Merge "Fix statistics race condition on big flows"
Shuva Jyoti Kar [Thu, 16 Mar 2017 10:20:38 +0000 (10:20 +0000)]
Merge "Fix checkstyle warnings"
Shuva Jyoti Kar [Thu, 16 Mar 2017 10:20:31 +0000 (10:20 +0000)]
Merge "Fix checkstyle warnings"
Shuva Jyoti Kar [Thu, 16 Mar 2017 10:20:18 +0000 (10:20 +0000)]
Merge "Fix checkstyle warnings"
Shuva Jyoti Kar [Thu, 16 Mar 2017 10:17:41 +0000 (10:17 +0000)]
Merge "Remove drop-test feature from He design"
Shigeru Yasuda [Fri, 24 Jun 2016 13:10:07 +0000 (22:10 +0900)]
Bug 6110: Fixed bugs in statistics manager due to race condition.
* Stats notification listener needs to wait for the XID to be cached.
* Enqueue DS operation after all notifications are received.
Change-Id: I42ac315a65be1a1f02152fbd9ea9510bee586eb3
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Abhijit Kumbhare [Wed, 15 Mar 2017 22:14:34 +0000 (22:14 +0000)]
Merge "Bug 7916: MatchConvertorImpl detailed IllegalStateException instead NPE"
Jozef Bacigal [Thu, 2 Mar 2017 13:24:46 +0000 (14:24 +0100)]
Fix checkstyle warnings
- org.opendaylight.openflowplugin.api.openflow.lifecycle
Change-Id: Iaa95b9c49441adc943a4c510e1583ac92146ee63
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 9 Mar 2017 09:24:14 +0000 (10:24 +0100)]
Remove drop-test feature from He design
Change-Id: I3c9ffc1aa0d105601ceaa427f2bc043324d8e296
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 2 Mar 2017 13:17:58 +0000 (14:17 +0100)]
Fix checkstyle warnings
- org.opendylight.openflowplugin.api.openflow.device
Change-Id: I775fd56bee4a1d80b2c2ace37f32836c993c5b97
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 14 Mar 2017 09:27:48 +0000 (10:27 +0100)]
Add arbitrary mask for nxm-reg
According to specification, nxm-reg should be fully maskable
using arbitrary mask.
Resolves: bug 7897
Change-Id: I912017e6bd33813ac65ed5799c8bfa7ebf217889
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Wed, 1 Mar 2017 11:07:46 +0000 (12:07 +0100)]
Fix checkstyle warnings
- org.opendaylight.openflowplugin.api.openflow.connection
Change-Id: Ib061f1fd2dbb6da1cd24e23e1846d79e41026f3e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Fri, 24 Feb 2017 08:40:45 +0000 (09:40 +0100)]
Fix statistics race condition on big flows
Fix race condition that happens when we receive statistics faster
than flow is deleted from device, but we already sent request for
deletion and removed this flow from device registy.
Resolves: bug 6917
Change-Id: I95510fbc5d507eaffc34d58b3b7743e60911b541
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Wed, 1 Mar 2017 10:40:21 +0000 (11:40 +0100)]
Fix checkstyle warnings
- org.opendaylight.openflowplugin.api
Change-Id: I7b24e696af69505163bbd515ffa7db3b32ca497d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 10 Mar 2017 09:09:37 +0000 (09:09 +0000)]
Merge "Remove old drop-test module and files."
Jozef Bacigal [Fri, 10 Mar 2017 09:09:17 +0000 (09:09 +0000)]
Merge "Implement core API's methods."
Jozef Bacigal [Fri, 10 Mar 2017 09:09:09 +0000 (09:09 +0000)]
Merge "Define new API for context chain and context chain holder."
Jozef Bacigal [Fri, 10 Mar 2017 09:08:40 +0000 (09:08 +0000)]
Merge "Add module and feature for ONF extensions"
Anil Vishnoi [Tue, 7 Mar 2017 02:49:23 +0000 (18:49 -0800)]
Bug 7910 - Flow with ethernet mask (ff:ff:ff:ff:ff:ff),
get stored under alien-id in operational data store
Custom comparator for ethernet mask address is modified
to take care of this issue.
Change-Id: I0c5c1dbd61dd1a3fb83d3b16695553649c4ecf8f
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Jozef Bacigal [Thu, 9 Mar 2017 17:04:28 +0000 (17:04 +0000)]
Merge "Add configuration knob for Single Layer"
Jozef Bacigal [Thu, 9 Mar 2017 17:00:08 +0000 (17:00 +0000)]
Merge "Turn Single Layer Serialization on by default"
Jozef Bacigal [Mon, 21 Nov 2016 11:30:37 +0000 (12:30 +0100)]
Implement core API's methods.
Change-Id: I3005c82e2cdea0cf719c5f500041ad3ad9ce4480
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 14 Nov 2016 09:23:53 +0000 (10:23 +0100)]
Define new API for context chain and context chain holder.
Change-Id: I1ad94bab7b5ff3d98dee939420b2f28d3eb36261
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 8 Mar 2017 17:15:40 +0000 (18:15 +0100)]
Revert "Use Karaf 4 for the Karaf distribution"
This reverts commit
c14a28f3a6f7f095d597fb7354cbc317b3c3100a.
Change-Id: I6f9c29023380ff7942ebdb3e903d6cfbc2071f6d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>