Aswin Suryanarayanan [Mon, 6 Jul 2015 14:39:52 +0000 (20:09 +0530)]
Added fixed DHCP security rules, which will be added on a VM create.
Change-Id: I8652c986acf3488ddf661ed265bff4cf6fb5ed1e
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Flavio Fernandes [Tue, 30 Jun 2015 15:58:50 +0000 (11:58 -0400)]
Bug 3893: provide well known url to know that net-virt topology is ready
With this change, one can check the following url and know that ovsdb's netvirt
is up and functional:
http://${ODL_IP}:8080/restconf/operational/network-topology:network-topology/topology/netvirt:1
Patch set 2: fix transaction
Patch set 3: code review, move new function to OvsdbInventoryServiceImpl
Patch set 4: typo (functional)
Change-Id: Ibe71d823b986fcdc9c12b6fa2a3994ae158fb696
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Mon, 29 Jun 2015 17:12:59 +0000 (17:12 +0000)]
Merge "Added the robot framework to OVSDB VMs"
Ben Eze [Fri, 26 Jun 2015 20:26:32 +0000 (16:26 -0400)]
Added the robot framework to OVSDB VMs
Change-Id: Ib57793b05661d5d5487788574ef65cfa990d3cb4
Signed-off-by: Ben Eze <beze@inocybe.ca>
Alexis de Talhouët [Fri, 26 Jun 2015 14:21:16 +0000 (10:21 -0400)]
Fix Javadoc errors.
The build was failing due to those errors:
[ERROR] /ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/EgressAclProvider.java:13: error: @param name not found
--> doesn't exist
[ERROR] /ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/IngressAclProvider.java:22: error: @param name not found
--> doesn't exist
[ERROR] /ovsdb/openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/AbstractServiceInstance.java:205: error: @param name not found
--> Node instead of node
Java version "1.8.0_45"
Change-Id: I386bb5ba6be41c134c6f843f78ef06147528fd61
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Flavio Fernandes [Fri, 26 Jun 2015 13:41:20 +0000 (13:41 +0000)]
Merge "Sonar bug fix"
Flavio Fernandes [Tue, 23 Jun 2015 15:33:24 +0000 (11:33 -0400)]
Bug 3841 - wrong severity level: getTenantNetwork did not find network
when using normal ovsdb net-virt, I see benign logs like these:
WARN | ntDispatcherImpl | TenantNetworkManagerImpl | 271 - org.opendaylight.ovsdb.openstack.net-virt - 1.1.0.SNAPSHOT | getTenantNetwork did not find network for patch-int
these should be debug at best; not warning.
Patch set 2: add changes from code review
Change-Id: I6f0b0aa6880c2b6892e5b9974ce5df6c0d217bf5
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Tue, 23 Jun 2015 13:50:33 +0000 (09:50 -0400)]
Bug-2094 : less is more remove redundant code
In pipeline, there is no need to set register value to 0,
as that is the expected value upon classifier table.
Change-Id: Iea4c53c14be980713ff060c8c9df8869c60926df
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Eric Multanen [Mon, 22 Jun 2015 16:45:18 +0000 (09:45 -0700)]
Bug 3831 - ignore unknown OVS interface and datapath types
Ighore OVSDB interface or datapath types which are not
present in the MD-SAL southbound model (but are present
in the OVS nodes open_vswitch table iface-types or
datapath-types columns).
Tested by making a build of ODL which removed supported
types from the ODL code to varify the log warnings
were created.
Change-Id: I05e689fa2b2dc906e3083e4fc44ba60abdb1d352
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
(cherry picked from commit
c525fd2b379171af656ffd060d9e520ab4e3854e)
Eric Multanen [Mon, 22 Jun 2015 15:47:17 +0000 (08:47 -0700)]
Bug 3831 - add stt interface type to model
On a build from openvswitch master branch, there was an
interface type 'stt' which was not included in the ovsdb.yang
model for the southbound MD-SAL. When an OVSDB connection
was made to this OVS node, the operational md-sal failed
to populate.
Adding the 'stt' interface type to the model is a quick
fix. A better fix would ignore types not present in the model.
Change-Id: Idf259998f73d43be587d19de73794a174d4d81d3
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
(cherry picked from commit
444b68f6f7637d9b4eb7e4f07c9ff6ced4e8ce76)
Raksha Madhava Bangera [Mon, 22 Jun 2015 20:26:36 +0000 (13:26 -0700)]
Sonar bug fix
Removing redundant 'public' keyword in interface in ConfigurationService.java
Signed-off-by: Raksha Madhava Bangera <raksha.madhava.bangera@intel.com>
Sharon Aicler [Fri, 15 May 2015 19:04:03 +0000 (12:04 -0700)]
Remove frame size limit for scale OVS
Change-Id: I4f1c7e29c332964eea077fd6958453be34fa04a5
Signed-off-by: Sharon Aicler <saichler@cisco.com>
Sharad Mishra [Mon, 22 Jun 2015 06:38:24 +0000 (23:38 -0700)]
Bug 3647 :Operational not set correctly when other-config is removed from switch.
similar to BZ 3647, but for other-config
Change-Id: I48f6636e5d3e67de024958a1e3b9e8efb7e6f8dc
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
Sharad Mishra [Thu, 18 Jun 2015 07:01:04 +0000 (00:01 -0700)]
Bug 3647 : Fix for bugzilla 3647
https://bugs.opendaylight.org/show_bug.cgi?id=3647
Change-Id: I504a7155050bb47e3eb768ab7420c8b5892af324
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
Flavio Fernandes [Fri, 19 Jun 2015 04:58:54 +0000 (00:58 -0400)]
Bug-2094 : L3 North-South does not work -- fix outbound rewrite
This set of changes will fix the outbound table (ie table 100) to
match on fixedIp associated with floatingIp, destined to neutron
router's mac. Packets that match the criteria will have rewrite
done, and be sent out of the patch-port in br-int.
Pat set 2: Fix copy and paste mistake in testProgramIpRewriteRule()
Change-Id: I2fc3f1f88b8cb9f26aaf0b69fda6836a1cebd264
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Fri, 19 Jun 2015 00:56:28 +0000 (00:56 +0000)]
Merge "Added Vagrant images to run CSIT."
Ben Eze [Thu, 18 Jun 2015 14:20:55 +0000 (10:20 -0400)]
Added Vagrant images to run CSIT.
Change-Id: I147cb90878f8f8af6d535b2b15988e9221777a4c
Signed-off-by: Gabriel Robitaille-Montpetit <grmontpetit@inocybe.com>
Signed-off-by: Ben Eze <beze@inocybe.ca>
Flavio Fernandes [Wed, 17 Jun 2015 12:37:12 +0000 (08:37 -0400)]
Bug-2094 : L3 North-South does not work -- fix inbound rewrite
This set of changes will fix the inbound table (ie table 30) to use reg3
to track the ip rewrite. Also, changes added to routing table (talbe 60)
so that reg3 match can route packet into tenant segmentation.
Patch set 2: code review.
Patch set 3: fix test to account for removal of inboundIpRewriteExclusionCache.
Change-Id: I53b327da1631ac35aa7aaa519e0e9945d017fb3e
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Tue, 16 Jun 2015 00:42:36 +0000 (20:42 -0400)]
Bug-2094 : L3 North-South does not work -- fix ARP table
This set of changes will fix the ARP responder table (ie table 20) to properly
handle the responding of ARP queries made on br-ex for the associated floating
ip addresses.
Change-Id: I72c5f24d00a42fb011441849adfdb244ba01937b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Tue, 16 Jun 2015 20:28:16 +0000 (20:28 +0000)]
Merge "Skeleton for the ovsdb-ui feature"
Maxime Millette-Coulombe [Wed, 10 Jun 2015 20:27:26 +0000 (16:27 -0400)]
Skeleton for the ovsdb-ui feature
Folders structure and basic files to create and add a external
module on DLUX. It also include a CRUD implementation of
the southbounds REST API.
Change-Id: If48eb4d055db3b91529e76e75503aa4c68b0c6a3
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>
Flavio Fernandes [Tue, 16 Jun 2015 14:51:25 +0000 (10:51 -0400)]
Bug 3752 : NPE at SouthboundMapper.java -- createControllerEntries
Check that ovsdbBridgeAugmentation.getControllerEntry() is not
returning null
Change-Id: I2b91710e6d388309f524797a2a2584e37e1cc4de
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Sam Hague [Sat, 13 Jun 2015 16:26:08 +0000 (12:26 -0400)]
Bug 3379:java.lang.IllegalArgumentException: ControllerEntryKey
Change-Id: I60ff0485707445ac119d76a5046a708a63f302fa
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 9 Jun 2015 19:50:00 +0000 (15:50 -0400)]
Bug 3379:java.lang.IllegalArgumentException: ControllerEntryKey
Problem: OVSDB Controller updates are indpendent of Bridge updates but the ovsdb.yang model includes the controller data in the OVsdbBridgeAugmentation. This existing code assumed that the Controller and Bridge updates would be together and thus would always have the OvsdbBridgeAugmentation to update. That is not the case since the Controller updates can be received without a Bridge update.
Solution: Add the ControllerEntry to the OvsdbBridgeAugmentation using the Bridge if it was included with the Controller update. Otherwise, find all the OvsdbBridgeAugmentations for the connection and update them if they are using the updated Controller.
Patch also includes updates to SouthboundIT and NetvirtIT. NetvirtIT was needed so that the isConnected=true case would be tested. Southbound does not include the openflowplugin but Netvirt does. The openflowplugin is needed to test when the switch connects to the openflow controller.
Other fixes were made to the existing testOvsdbBridgeControllerInfo(). That test was using the ovsdb node ip:port as the controller target but it should have been the controller's ip:port.
Change-Id: I30785dbdf955614ad6fc675507da048434c2485e
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
fd1b45b2100fb2bfe7a7b58295cebdc949833680)
Sam Hague [Sat, 13 Jun 2015 13:45:08 +0000 (13:45 +0000)]
Merge "Bug 3681 - Uncaught ConnectException leaves library in bad state"
Sam Hague [Sat, 13 Jun 2015 13:44:55 +0000 (13:44 +0000)]
Merge "Bug 3681 - Uncaught ConnectException leaves library in bad state"
Flavio Fernandes [Fri, 12 Jun 2015 21:05:08 +0000 (21:05 +0000)]
Merge "Separation of ARP Responder from config.ini. Amended to use ConfigurationService & fix comments"
evvy [Fri, 12 Jun 2015 20:05:15 +0000 (01:35 +0530)]
Separation of ARP Responder from config.ini. Amended to use ConfigurationService & fix comments
Change-Id: I2dac1bec77bdc9818489dc7773a8804464a7bad5
Signed-off-by: evvy <dhiraviam.natarajan@gmail.com>
Alexis de Talhouët [Fri, 12 Jun 2015 13:14:07 +0000 (09:14 -0400)]
Fix Bug 3663: Wrong assert statement causing test failure.
Also remove a System.out than shouldn't have been there in a first place.
Change-Id: Iad4a3968451d57ff7fe4d37ea380f583ffc9d3c7
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Praveen Mala [Fri, 12 Jun 2015 01:06:27 +0000 (21:06 -0400)]
Adding test case to set-target controller for a bridge and verify if it is set in the bridge as expected
Change-Id: I85b29409178716920c6e0859580f035055a0901c
Signed-off-by: Praveen Mala <praveen.mala@intel.com>
Sam Hague [Fri, 12 Jun 2015 00:40:42 +0000 (00:40 +0000)]
Merge "Fix Bug 3663: Update netvirt.provider UT"
Sam Hague [Fri, 12 Jun 2015 00:05:19 +0000 (20:05 -0400)]
Bug 3681 - Uncaught ConnectException leaves library in bad state
Change-Id: I282162be62d9b6d8deb94906dddac9df766255eb
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 12 Jun 2015 00:05:09 +0000 (20:05 -0400)]
Bug 3681 - Uncaught ConnectException leaves library in bad state
Change-Id: Iccf9be6e7e08b0fd77f0ee47a71b92640890a9df
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 12 Jun 2015 00:18:11 +0000 (00:18 +0000)]
Merge "Bug 3141 - OVSDB southbound operational MDSAL stops getting populated after ovs-vsctl del-manager"
Sam Hague [Fri, 12 Jun 2015 00:17:41 +0000 (00:17 +0000)]
Merge "Bug 3676 - OvsdbNodeRemoveCommand .. had no OvsdbNodeAugmentation"
Sam Hague [Thu, 11 Jun 2015 20:46:22 +0000 (16:46 -0400)]
Bug 3141 - OVSDB southbound operational MDSAL stops getting populated after ovs-vsctl del-manager
The symptom looked like the OvsdbDataChangeListener#onDataChanged() was not being called when the node was added back to config (after it was deleted from operational followed by deleted from config)
This was because of a AbstractFuture.get() was not returning. This was a get() for the transaction responses for ovsdb transactions. In this particular path the node was deleted from oeprational. Then the node is deleted from config. During the processing of the config update there was an expectation that some ovsdb updates would happen but there aren't any because the node was already removed from operational and there is no active connection to the ovsdb node. This caused the invoker thread to block on the future result.get(). Later when the node was added to config, the onDataChanged() was not called since the thread was still blocked on the get().
Solution: check if there were any ovsdb transactions and not call get() if there aren't any.
Change-Id: Id183aed2ae9b4f1d156cf89d7899a1868a6451f6
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 11 Jun 2015 20:45:53 +0000 (16:45 -0400)]
Bug 3676 - OvsdbNodeRemoveCommand .. had no OvsdbNodeAugmentation
Change-Id: I40684762bdd9f4933afbe67a58540e1cfc4b8a35
Signed-off-by: Sam Hague <shague@redhat.com>
Alexis de Talhouët [Thu, 11 Jun 2015 18:47:17 +0000 (14:47 -0400)]
Fix Bug 3663: Update netvirt.provider UT
This patch update all the test classes within the
org.opendaylight.ovsdb.openstack.netvirt.provider package
Change-Id: I40b73ae5efe472449b2b3a11e91dbef6d5bf24cc
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Sam Hague [Thu, 11 Jun 2015 14:53:29 +0000 (14:53 +0000)]
Merge "Fix Bug 3663: Update netvirt.impl UT"
Flavio Fernandes [Thu, 11 Jun 2015 14:43:42 +0000 (14:43 +0000)]
Merge "Fix Bug 3663: Update netvirt UT"
Alexis de Talhouët [Wed, 10 Jun 2015 16:18:48 +0000 (12:18 -0400)]
Fix Bug 3663: Update netvirt.impl UT
This patch update all the test classes within the
org.opendaylight.ovsdb.openstack.netvirt.impl package
Change-Id: If9864fc98385c602627b279653875875fdcf700c
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Wed, 10 Jun 2015 18:40:50 +0000 (14:40 -0400)]
Fix Bug 3665: Call the nodeCache.remove() by passing the NodeId.
Change-Id: I7b55ef7e86c76f473e9dc044f5441d989034a52b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Tue, 9 Jun 2015 14:46:29 +0000 (10:46 -0400)]
Fix Bug 3663: Update netvirt UT
This patch update all the test classes within the
org.opendaylight.ovsdb.openstack.netvirt package
Change-Id: I8f747293f9283bc4f3c0823f4504a63dd59a03c0
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Tue, 9 Jun 2015 15:04:04 +0000 (11:04 -0400)]
Change EventDispatcher field visibility of AbstractHandler to protected.
Instead of having EventDisptacher private, we set it as protected thus
all the classes that extends AbstractHandler can use the variable.
This patch remove:
- the setDispatcher() method from AbstractHandler
- the declared EventDispactcher field of the classes extending AbstractHandler
Change-Id: Idbd000def09aa91cc4e40976ac4a37274bfce762
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Flavio Fernandes [Wed, 3 Jun 2015 10:45:15 +0000 (06:45 -0400)]
Bug-2094 : L3 North-South does not work
Create br-ex and add patch port between br-int and br-ex when L3 fwd is enabled.
Patch set 2: Use consts for patch port names
Patch set 3: Use config to determine if l3 fwd is enabled
Patch set 4: Fix tests part 1 of 2
Patch set 5: Fix tests part 2 of 2
Patch set 6: Add changes from code review
Change-Id: I2425d83c68025617a50000f98c4e60b3a9a15ee8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Also-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
6940c8d516345a3e9b11e148830d881053edfde7)
Ed Warnicke [Sat, 30 May 2015 18:02:57 +0000 (11:02 -0700)]
Bug 3310 Bug 3316: Fix for iids for termination points
Change-Id: I9174fe480fc95570e52095474c3e9ae78b8efd8e
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit
5c5ed0bec9b9f908d97d024549cb754f3898d5eb)
Ed Warnicke [Thu, 21 May 2015 20:55:25 +0000 (13:55 -0700)]
Bug 3310 Bug 3316: Fix for iids for bridges
Change-Id: Ieabaa7040cbcdc8e72a2aae21a9181667c543880
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit
004394b0b3da86ddb506c757b8c5f110d916b02a)
Ed Warnicke [Fri, 15 May 2015 16:42:36 +0000 (09:42 -0700)]
Bug 3310 Bug 3316 Use iid stamp if we configured a connection, otherwise systemid
This has been tested, and passes SB IT tests (all 21)
As well as manually tested beyond their coverage.
PatchSet3: Switch to using ovsdb://uuid/<uuid> for default
NodeKey for OPER nodes we discover that we did not configure.
Conflicts:
southbound/southbound-it/src/test/java/org/opendaylight/ovsdb/southbound/it/SouthboundIT.java
Change-Id: I270a64e13a6fca257b49d2e2ff34f754698c2df4
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 3 Jun 2015 17:22:25 +0000 (17:22 +0000)]
Merge "Slight refactoring of the lifecycle of data"
Flavio Fernandes [Wed, 3 Jun 2015 17:11:27 +0000 (17:11 +0000)]
Merge "Bug 3563 - Fix/clean methods that determine the OpenFlow Controller ip address"
Flavio Fernandes [Wed, 3 Jun 2015 17:10:21 +0000 (17:10 +0000)]
Merge "Add per test information"
Ed Warnicke [Thu, 14 May 2015 15:13:56 +0000 (08:13 -0700)]
Slight refactoring of the lifecycle of data
With this patch, we change slightly the manner in which we handle
data change events (including connections)
Previously, when we got a DataChangeEvent we'd try the following
1) connect(changes) - do all the work for connecting, including
registeringCallbacks
2) connectionUpdate - handle connection updates
3) updateData - use transact to write any data changes to the ovsdb instance
4) disconnect - disconnect anything if needed
Now we have changed this so that
a) #1 (connect) - does *not* registerCallbacks
b) Added a 5) registerCallbacks
The reason this was done is so that the normal pipeline for writing data
can handle flushing the externalId for the OpenVSwitch table down to ovsdb
*before* we registerCallbacks and have it come back to the operational data
store.
Conflicts:
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionInstance.java
Change-Id: I105dd01bf87b1be170e2c4082a7914fba2002249
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 3 Jun 2015 16:39:50 +0000 (16:39 +0000)]
Merge "Write iid of ovsdb-node to OpenVSwitch.externalIds"
Ed Warnicke [Thu, 14 May 2015 04:31:54 +0000 (21:31 -0700)]
Write iid of ovsdb-node to OpenVSwitch.externalIds
Change-Id: I4fbdd5499b19d452f253a3600944aecced59dafc
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit
3747b449b15deccb33d152924c492647a92c8d25)
Ed Warnicke [Thu, 14 May 2015 02:51:28 +0000 (19:51 -0700)]
Switch from using OvsdbCreateCommand to using OpenVSwitchUpdateCommand
Have the initial registration of the ovsdb-node come from getting
the OpenVswitch table data come to use from the monitor command in the
initial db dump.
This passes all SB-IT tests:
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0
Change-Id: If098081bb89292f0bac320659b41fa05994e195e
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Ed Warnicke [Thu, 14 May 2015 02:17:38 +0000 (19:17 -0700)]
Pass OvsdbConnectionInstance to Commands instead of ConnectionInfo
This is in preperation to have the adding of ovsdb-nodes handled
by the OpenVSwitchUpdateCommand, so it can write the iid to the
externalIds.
Change-Id: Ib478c776e0906e7424b5759422d0be986dccdc29
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit
02c8562dfca6d7863ae6cdf34ef502d6a4ad370d)
Anil Vishnoi [Wed, 3 Jun 2015 13:33:47 +0000 (19:03 +0530)]
Bug 3563 - Fix/clean methods that determine the OpenFlow Controller ip address
Change-Id: I420a10e769be016efa0a4e6c71d863fd39c12e23
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit
94dbb902c1f020c87407ba0fb87ff770dea01cbc)
Sam Hague [Wed, 3 Jun 2015 02:12:12 +0000 (22:12 -0400)]
Add per test information
Change-Id: I4859e9977db5099485fe53c4bc663bd484a61ed5
Signed-off-by: Sam Hague <shague@redhat.com>
shc411 [Tue, 2 Jun 2015 06:46:33 +0000 (15:46 +0900)]
Fix for bug 3538
in removeOutputPortFromInstructions function,
when reordering the actionList setKey should be used same key with order.
Change-Id: I3ab3b6c9bbf6bf0b3914dc0819501177f37dc31a
Signed-off-by: shc411 <jung33@gmail.com>
Sam Hague [Sun, 31 May 2015 16:07:18 +0000 (12:07 -0400)]
Remove northbound and compat it tests
Change-Id: Ie2b3cd0342cc97f660949873b9d50fa1378071db
Signed-off-by: Sam Hague <shague@redhat.com>
Eric Multanen [Thu, 21 May 2015 20:04:02 +0000 (13:04 -0700)]
Bug 3332: Fix connections made to an ODL instance
If an OVSDB connection is made via OVSDB SB MD-SAL
to self (same ODL) or another ODL instacne, the
OVSDB SB provider would hang or otherwise stop working.
This fixes by returning a null list to the 'list_dbs'
command.
v2 - remove white space
When an OVSDB connection is established,
the first request that the OVSDB Southbound makes is a
list_dbs command. By returning an empty db list, two
things occur:
1 - the request gets a response
2 - the empty db list signals an uninteresting connection
Change-Id: I295dd47b821f7ec4ead0eb489a1b124cc574e8cf
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Flavio Fernandes [Fri, 29 May 2015 20:46:17 +0000 (20:46 +0000)]
Merge "Fixing sonar issues on ConfigurationServiceImpl.java"
Flavio Fernandes [Fri, 29 May 2015 15:12:02 +0000 (11:12 -0400)]
Bug-3425 : Cont. minor changes to incorporate the code review from Sam
Change-Id: I859864631f2842af48ad044ff7305ceeec5bf9ff
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Anil Vishnoi [Thu, 28 May 2015 19:56:35 +0000 (01:26 +0530)]
Bug-3425 : VM doesn't get the ip address from DHCP
server, if network is not attached to the router
This failure happens when net-virt don't find tunnel port in
the Node update from operational data store.
It tries to extract termination point from node update which
doesn't have tunnel port termination point. And because
there are other termination point exist, it doesn't go and
read from data store. ProgrammeTunnelPort() method iterate
through these existing termination points and it doesn't find the
tunnel port and it returns without installing the Local Ingress
Bridge Rules. This patch first try to create a tunnel configuration
on integration bridge of both end node of the tunnel and then
installs the tunnel flows. Also while installing tunnel flows
It specifically look for tunnel port in the nodes update and if
it doesn't find that it reads it from data store.
Change-Id: I61e70c230051908a12f6ea93b9b2d046b699eccb
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Leo Cavalcanti [Thu, 16 Apr 2015 22:48:50 +0000 (19:48 -0300)]
Fixing sonar issues on ConfigurationServiceImpl.java
Change-Id: Ic042ebc8605b23eea7d8a9db089f0cf6b1206e9b
Signed-off-by: Leo Cavalcanti <leozinho@gmail.com>
Sam Hague [Fri, 29 May 2015 11:55:52 +0000 (07:55 -0400)]
Remove adsal-related modules from features
Change-Id: Id53932e243803e8d1cfc58b438cebaadb7fbcf1f
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Thu, 28 May 2015 17:43:42 +0000 (13:43 -0400)]
Incrementing versions by 0.1.0 for post-lithium master branch
Change-Id: I57d093485b91eba70b43dfd02e6bda9868a6426c
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Thu, 28 May 2015 17:32:40 +0000 (17:32 +0000)]
Merge "Add sonar report to SouthboundIT"
Flavio Fernandes [Thu, 28 May 2015 17:32:30 +0000 (17:32 +0000)]
Merge "Modify testGetOvsdbNodes to allow multiple connected nodes"
Flavio Fernandes [Thu, 28 May 2015 17:10:24 +0000 (17:10 +0000)]
Merge "Enable sonar for netvirt and southbound"
Sam Hague [Thu, 28 May 2015 17:03:07 +0000 (13:03 -0400)]
Add sonar report to SouthboundIT
Change-Id: Ia99e9d322ba21de85fe570926647398d8ada7806
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 28 May 2015 16:58:33 +0000 (12:58 -0400)]
Modify testGetOvsdbNodes to allow multiple connected nodes
Change-Id: Id5640716224e3d0803fcc26822c3d567e0c95f76
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 28 May 2015 13:01:12 +0000 (09:01 -0400)]
Enable sonar for netvirt and southbound
Change-Id: I97177b841ab0cfac92fe705f0aa6a61a2ab5f1eb
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Thu, 28 May 2015 12:56:38 +0000 (08:56 -0400)]
Bug 3404: Check dstNode together with src and dst to make sure tunnel can be created
Patch 2: add code review request
Change-Id: Ia170452f4275fb665d0ecbd6da304af6d1233474
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Sam Hague [Wed, 27 May 2015 22:55:01 +0000 (18:55 -0400)]
Remove unused files
Change-Id: I0ced05c1b65691de7d3cfb8d1971678dc7af5af1
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 27 May 2015 20:18:59 +0000 (16:18 -0400)]
Rename MdsalUtils to be Southbound and remove statics
Change-Id: I621d9c8a4d31bce707b64cc70de7c872963f9ba3
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Wed, 27 May 2015 17:00:23 +0000 (22:30 +0530)]
Create node-iid in a connection-info agnostic way
Cleaned up MdsalHelper class as well, removed unused methods.
Change-Id: I521ff23be712ea2be16ce71d6921fe91f67f98d9
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Flavio Fernandes [Wed, 27 May 2015 16:02:19 +0000 (12:02 -0400)]
Bug 2991: Handle cases when neutron network has no segmentationId
External networks have no tenant segmentation id. Because of that, code
must not assume that field is non-null.
Change-Id: Ifaebe02c76c1a769cee79f54e11233dae2dcce6d
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Wed, 27 May 2015 12:08:20 +0000 (12:08 +0000)]
Merge "Reenable BridgeConfigurationManagerImplTest"
Sam Hague [Wed, 27 May 2015 03:12:45 +0000 (23:12 -0400)]
Reenable BridgeConfigurationManagerImplTest
Change-Id: Iae4f40a899d7fed9013defcff51ee1d22b4794c4
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 26 May 2015 23:10:51 +0000 (23:10 +0000)]
Merge "Revert "Added controller is-connected code""
Flavio Fernandes [Tue, 26 May 2015 21:17:32 +0000 (21:17 +0000)]
Revert "Added controller is-connected code"
This reverts commit
dcc846b12b09e8b998b4ee361617dbf54f65dafa.
To be re-visited, once regression is resolved.
See bug: https://bugs.opendaylight.org/show_bug.cgi?id=3379
Ref: https://git.opendaylight.org/gerrit/#/c/18766/
Change-Id: I9fa30c70ab988f5e7f14d4e5ff31c945eda1ad69
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Tue, 26 May 2015 18:32:50 +0000 (18:32 +0000)]
Merge "Wait to process datastore until providers are ready"
Sam Hague [Tue, 26 May 2015 18:30:17 +0000 (18:30 +0000)]
Merge "Added controller is-connected code"
Sam Hague [Tue, 26 May 2015 16:49:15 +0000 (12:49 -0400)]
Wait to process datastore until providers are ready
Change-Id: I51d54ee77cd1b9b130edffba6b62829e33f7bf6d
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Tue, 26 May 2015 16:20:34 +0000 (12:20 -0400)]
L3 Bugfix: routing table needs to add rules when destination net is not local
Because L3 routes at ingress, it is possible that the dest neutron network is
not present at the the ingress node.
Fix cache so only id of node is used.
Fix logging format, so only node id is provided.
Change-Id: I7930ec3615f06098d1d2ca63ed386cb6bbb737bc
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Ryan Goulding [Fri, 22 May 2015 23:59:27 +0000 (19:59 -0400)]
Refactor vlan tests for update case in SouthboundIT
This patch consolidates existing Create, Read and Delete tests with newly
added Update test functionality.
Change-Id: I45aa430f7757a5d9b1666ce4c23f784f3ea4174d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Sam Hague [Fri, 22 May 2015 22:56:37 +0000 (22:56 +0000)]
Merge "Refactor integration tests"
Sam Hague [Fri, 22 May 2015 22:56:12 +0000 (22:56 +0000)]
Merge "Refactor Termination Point Port Other Configs SouthbondIT"
Ryan Goulding [Thu, 21 May 2015 14:28:15 +0000 (10:28 -0400)]
Refactor ofport and ofport_request update testing SouthboundIT
Cleans up the code surrounding ofport and ofport_request CRUD testing by
extracting local constants. Adds documentation to explain why update
testing is not applicable. Changes the names of the test cases to
accurately reflect the intent of the tests.
Change-Id: I29724a9922b7514399c616ecdcf8ea85f36d4ef2
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Ryan Goulding [Wed, 20 May 2015 15:09:30 +0000 (11:09 -0400)]
Refactor Termination Point Port Other Configs SouthbondIT
This patch consolidates existing Create, Read and Delete tests with newly
added Update test functionality. Additionally, more test cases are added
to provide more coverage.
Change-Id: I73ab9013ff6e6ffdc882e0886e517c6c4c163f49
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Ryan Goulding [Mon, 18 May 2015 18:25:15 +0000 (14:25 -0400)]
Refactor integration tests
This patch cleans and adds functionality to the Southbound integration tests.
Specifically, the changes do the following:
1) enable negative test cases that were previously disabled
2) remove checkErased tests, as the configurations aren't replaced but merged
3) consolidate existing Termination Point Interface other_configs testing with
new update test cases, resulting in full CRUD tests.
Change-Id: I7eff55e452372d16cbaecb125d4a134a690b7c49
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Sam Hague [Fri, 22 May 2015 13:44:51 +0000 (09:44 -0400)]
Reorder openflowplugin features
Change-Id: I5264359b30eb607e92beb8c90ef959368c4ed5d9
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 21 May 2015 01:07:33 +0000 (21:07 -0400)]
Use config instead of Activator for netvirt and netvirt-providers
Change-Id: I06076ab94011be23c51055132a429c4584476193
Signed-off-by: Sam Hague <shague@redhat.com>
evvy [Mon, 18 May 2015 13:08:07 +0000 (18:38 +0530)]
Fixing all but one sonar issues in NodeDatabase:Amended
Need to fix UT scripts before using logger.
Change-Id: I8d48caefe7662d4ef721aef2b17f3eed048110e9
Signed-off-by: evvy <dhiraviam.natarajan@gmail.com>
Sam Hague [Fri, 15 May 2015 18:49:27 +0000 (14:49 -0400)]
Fix for vlan physical port flows on add and remove
Change-Id: I897fb048bce6fb8610e8855e501b9d9024809c64
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 15 May 2015 18:47:37 +0000 (14:47 -0400)]
Fix for NPE on port delete
2015-05-15 13:30:06,114 | WARN | n-invoker-impl-0 | TransactionInvokerImpl | 332 - org.opendaylight.ovsdb.southbound-impl - 1.1.0.SNAPSHOT | Exception invoking Transaction:
java.lang.NullPointerException
at org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortRemoveCommand.execute(OvsdbPortRemoveCommand.java:53)[332:org.opendaylight.ovsdb.southbound-impl:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.southbound.transactions.md.OvsdbOperationalCommandAggregator.execute(OvsdbOperationalCommandAggregator.java:29)[332:org.opendaylight.ovsdb.southbound-impl:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl.run(TransactionInvokerImpl.java:77)[332:org.opendaylight.ovsdb.southbound-impl:1.1.0.SNAPSHOT]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)[:1.7.0_71]
at java.util.concurrent.FutureTask.run(FutureTask.java:262)[:1.7.0_71]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)[:1.7.0_71]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)[:1.7.0_71]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_71]
2015-05-15 13:30:06,115 | WARN | n-invoker-impl-0 | TransactionInvokerImpl | 332 - org.opendaylight.ovsdb.southbound-impl - 1.1.0.SNAPSHOT | Exception invoking Transaction:
java.lang.IllegalStateException: Previous transaction is not ready yet
at com.google.common.base.Preconditions.checkState(Preconditions.java:173)[78:com.google.guava:18.0.0]
at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.checkReadyState(TransactionChainProxy.java:133)[266:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.allocateWriteTransaction(TransactionChainProxy.java:121)[266:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.newReadWriteTransaction(TransactionChainProxy.java:101)[266:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]
at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.createTransaction(DOMBrokerReadWriteTransaction.java:49)[266:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]
at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.createTransaction(DOMBrokerReadWriteTransaction.java:22)[266:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]
at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerTransaction.getSubtransaction(AbstractDOMBrokerTransaction.java:57)[266:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]
at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.read(DOMBrokerReadWriteTransaction.java:37)[266:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]
at org.opendaylight.controller.md.sal.binding.impl.AbstractForwardedTransaction.doRead(AbstractForwardedTransaction.java:63)[244:org.opendaylight.controller.sal-binding-broker-impl:1.2.0.SNAPSHOT]
at org.opendaylight.controller.md.sal.binding.impl.BindingDOMReadWriteTransactionAdapter.read(BindingDOMReadWriteTransactionAdapter.java:31)[244:org.opendaylight.controller.sal-binding-broker-impl:1.2.0.SNAPSHOT]
at org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.readNode(OvsdbBridgeUpdateCommand.java:191)[332:org.opendaylight.ovsdb.southbound-impl:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.updateBridge(OvsdbBridgeUpdateCommand.java:83)[332:org.opendaylight.ovsdb.southbound-impl:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.execute(OvsdbBridgeUpdateCommand.java:76)[332:org.opendaylight.ovsdb.southbound-impl:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.southbound.transactions.md.OvsdbOperationalCommandAggregator.execute(OvsdbOperationalCommandAggregator.java:29)[332:org.opendaylight.ovsdb.southbound-impl:1.1.0.SNAPSHOT]
at org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl.run(TransactionInvokerImpl.java:77)[332:org.opendaylight.ovsdb.southbound-impl:1.1.0.SNAPSHOT]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)[:1.7.0_71]
at java.util.concurrent.FutureTask.run(FutureTask.java:262)[:1.7.0_71]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)[:1.7.0_71]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)[:1.7.0_71]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_71]
Change-Id: I5a95a43faeefe4d91556dd1499cb0ba414974838
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 15 May 2015 14:14:32 +0000 (10:14 -0400)]
Remove net-virt dependency from it poms
Change-Id: I8cf3dd36007ff9af40820d8cd41f61eb4b3602ea
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 15 May 2015 13:14:28 +0000 (09:14 -0400)]
Add option to use karaf-empty for netvirtIT
Change-Id: I921dd9964501714556a3732b3fc560de2a1d228e
Signed-off-by: Sam Hague <shague@redhat.com>
Hideyuki Tai [Fri, 15 May 2015 00:38:26 +0000 (17:38 -0700)]
Fixed dependencies of features-ovsdb.
This patch added southbound-features:xml:features to dependencies of
features-ovsdb instead of southbound-features:jar, since its
features.xml used southbound-features:xml:features.
Change-Id: Ia016d084f7b11bd56fc94de0e5e062315ab38749
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>